From patchwork Sun Mar 3 16:55:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Li X-Patchwork-Id: 10837103 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 110C914DE for ; Sun, 3 Mar 2019 16:55:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F17B6296F1 for ; Sun, 3 Mar 2019 16:55:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E4A4029933; Sun, 3 Mar 2019 16:55:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 946D6296F1 for ; Sun, 3 Mar 2019 16:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbfCCQzw (ORCPT ); Sun, 3 Mar 2019 11:55:52 -0500 Received: from tomli.me ([153.92.126.73]:42626 "EHLO tomli.me" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726474AbfCCQzv (ORCPT ); Sun, 3 Mar 2019 11:55:51 -0500 Received: from tomli.me (localhost [127.0.0.1]) by tomli.me (OpenSMTPD) with ESMTP id 377c99eb; Sun, 3 Mar 2019 16:55:49 +0000 (UTC) X-HELO: localhost.lan Authentication-Results: tomli.me; auth=pass (login) smtp.auth=tomli Received: from Unknown (HELO localhost.lan) (2402:f000:1:1501:200:5efe:3d30:3659) by tomli.me (qpsmtpd/0.95) with ESMTPSA (DHE-RSA-CHACHA20-POLY1305 encrypted); Sun, 03 Mar 2019 16:55:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tomli.me; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=1490979754; bh=q4L6XezyUz8vykrzKVzwY31jWC0rgV5GxcNGUX2GJME=; b=NBHlragC8DCbaOLy17Fj/0DKG4d7NMBdBVZo6dygE0RnxBLTpaXZDiF7VO9qWkQCIcSbNrBWcMi/VIAUjW4p34jyNIWrKXu4pGJ2etVJC+HesEW9l0wpk5Wakj3yYCuYmxwjurKP0mkRv0TCyeQd8J+si2hGanVCO0rs1ZDStoreVy1eUYGNrkRXN41Foe6bu2b07R4TlIi87Kk8uXODn+DAe4onJfSonWzu3025qkFhb2zHl5sgizr5EOUdO8j17MuE6WevS4I4jl+mldP1kJ50+WkFzgkwSRbO1LyHzDSG/O1Q7OTyUlVNwr1foRIJgqvH6FfMk3sCLW0qKqqmyQ== From: Yifeng Li To: Jiri Kosina , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org Cc: Yifeng Li , Sudip Mukherjee , Teddy Wang , linux-kernel@vger.kernel.org Subject: [RESEND][PATCH 1/2] staging: sm750fb: trivial comment indention fix. Date: Mon, 4 Mar 2019 00:55:31 +0800 Message-Id: <20190303165532.23727-2-tomli@tomli.me> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190303165532.23727-1-tomli@tomli.me> References: <20190303165532.23727-1-tomli@tomli.me> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In function sm750_hw_copyarea() of sm750_accel.c, there are some comments in ASCII graphs, describing 4 possible scenarios of overlapping areas when copying an area. However, the graphs have broken indention. The entire SiliconMotion series video controllers, including SM501, SM712 and SM750 have similar 2D engines, yet, I have not seen a single version of it with ASCII graphs properly formatted... Fix the the misleading ASCII graphs. It would eliminate the confusions and improve code readability. Signed-off-by: Yifeng Li --- drivers/staging/sm750fb/sm750_accel.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index eed840b251da..dbcbbd1055da 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -155,26 +155,26 @@ unsigned int rop2) /* ROP value */ if (sBase == dBase && sPitch == dPitch) { /* Determine direction of operation */ if (sy < dy) { - /* +----------+ - * |S | - * | +----------+ - * | | | | - * | | | | - * +---|------+ | - * | D| - * +----------+ + /* +----------+ + * |S | + * | +----------+ + * | | | | + * | | | | + * +---|------+ | + * | D| + * +----------+ */ nDirection = BOTTOM_TO_TOP; } else if (sy > dy) { - /* +----------+ - * |D | - * | +----------+ - * | | | | - * | | | | - * +---|------+ | - * | S| - * +----------+ + /* +----------+ + * |D | + * | +----------+ + * | | | | + * | | | | + * +---|------+ | + * | S| + * +----------+ */ nDirection = TOP_TO_BOTTOM; From patchwork Sun Mar 3 16:55:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Li X-Patchwork-Id: 10837107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E3B7B1575 for ; Sun, 3 Mar 2019 16:56:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFB92296F1 for ; Sun, 3 Mar 2019 16:56:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C3E4229AA8; Sun, 3 Mar 2019 16:56:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 232F7296F1 for ; Sun, 3 Mar 2019 16:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726476AbfCCQz5 (ORCPT ); Sun, 3 Mar 2019 11:55:57 -0500 Received: from tomli.me ([153.92.126.73]:42626 "EHLO tomli.me" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbfCCQz4 (ORCPT ); Sun, 3 Mar 2019 11:55:56 -0500 Received: from tomli.me (localhost [127.0.0.1]) by tomli.me (OpenSMTPD) with ESMTP id 855162e8; Sun, 3 Mar 2019 16:55:54 +0000 (UTC) X-HELO: localhost.lan Authentication-Results: tomli.me; auth=pass (login) smtp.auth=tomli Received: from Unknown (HELO localhost.lan) (2402:f000:1:1501:200:5efe:3d30:3659) by tomli.me (qpsmtpd/0.95) with ESMTPSA (DHE-RSA-CHACHA20-POLY1305 encrypted); Sun, 03 Mar 2019 16:55:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tomli.me; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=1490979754; bh=In5+wEpZ+A7H086V4WiG1jXm7trt64OIVFCTapa2uOo=; b=lS8vo+k8GX3j6Vzl4mTn50Y1uor5kSc19GJuU0AspKjFxa+G5sBf52xowOSi9MANa9nbXz7EXwgzQ3FoeUCUKkDN4kpcbZQioD25+Pc/D6/8f8EkvCcUo2M02OgX6j0CL1nxyTaB38Z3gRWUlMium5LGoXD3naMKlCw/XlqiSX57e+8SNPrVC533U/wOKPWaPbX/qyHrLd1N7BVexwAEhEBjQ7v0e2bOp5EffB4HFjiK+r62i1gbbGAd4ZIMzoUHtIfVgWnoW487PeWD8f6mrkrWfgLrMLpiExb9x0qDe9lmaNsDvG1d6p34ScaOouAnb2BSbHxmAbckxD/TQPGCsA== From: Yifeng Li To: Jiri Kosina , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org Cc: Yifeng Li , Sudip Mukherjee , Teddy Wang , linux-kernel@vger.kernel.org, Jin Chen Subject: [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl(). Date: Mon, 4 Mar 2019 00:55:32 +0800 Message-Id: <20190303165532.23727-3-tomli@tomli.me> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190303165532.23727-1-tomli@tomli.me> References: <20190303165532.23727-1-tomli@tomli.me> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rename the function setDisplayControl() to set_display_control(). This fixes the following checkpatch.pl warning: CHECK: Avoid CamelCase: Suggested-by: Jin Chen Signed-off-by: Jin Chen [tomli@tomli.me: resent as trivial patch, reworded the commit message] Signed-off-by: Yifeng Li --- drivers/staging/sm750fb/ddk750_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c index 1273e7d18925..f38051eedb6c 100644 --- a/drivers/staging/sm750fb/ddk750_display.c +++ b/drivers/staging/sm750fb/ddk750_display.c @@ -5,7 +5,7 @@ #include "ddk750_power.h" #include "ddk750_dvi.h" -static void setDisplayControl(int ctrl, int disp_state) +static void set_display_control(int ctrl, int disp_state) { /* state != 0 means turn on both timing & plane en_bit */ unsigned long reg, val, reserved; @@ -137,12 +137,12 @@ void ddk750_setLogicalDispOut(enum disp_output output) if (output & PRI_TP_USAGE) { /* set primary timing and plane en_bit */ - setDisplayControl(0, (output & PRI_TP_MASK) >> PRI_TP_OFFSET); + set_display_control(0, (output & PRI_TP_MASK) >> PRI_TP_OFFSET); } if (output & SEC_TP_USAGE) { /* set secondary timing and plane en_bit*/ - setDisplayControl(1, (output & SEC_TP_MASK) >> SEC_TP_OFFSET); + set_display_control(1, (output & SEC_TP_MASK) >> SEC_TP_OFFSET); } if (output & PNL_SEQ_USAGE) {