From patchwork Mon Jul 15 12:15:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733384 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10406C3DA59 for ; Mon, 15 Jul 2024 12:16:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7220D10E36F; Mon, 15 Jul 2024 12:16:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qXNoYxJk"; dkim-atps=neutral Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E14410E375 for ; Mon, 15 Jul 2024 12:16:07 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-367ab76d5e1so1190729f8f.3 for ; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045766; x=1721650566; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CwYPDTPYAwmjKmZ1/Gf11accW/fLFhZgeFXsYW2+ut4=; b=qXNoYxJk1EHMIYo+h9XFvAxzzohnKxDok2YABQsYObKPxNh4vw2jHwxQV65ov2RLVJ 3byd6A7SCzvTxjYqXIHbxBP/H84+ZI11TCXhWockSWtnS2cPvTO9xi8Den43gb5yNhS3 c+dX75I2a7Q7JcWxG++1G4MfMUdf/9NdbrDiSPlh4rIjNo5zMf9W8IEb3Tv9a3VFPIoP 7ldgljffNCi3XzLRE4cCtyiXqJxzdDSbVFAK08iS7XVGHx2OB7D5DVPqGom8rG9OMChg 7FzZwstf5hgU3qQzVQOkMn91v/Ga8/ta5GfZKZHiZr4eDVWECP0NWWomghY76jtDURec 4OgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045766; x=1721650566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CwYPDTPYAwmjKmZ1/Gf11accW/fLFhZgeFXsYW2+ut4=; b=WJH1LFiiNZGR1yz6Ob7iMAaFmUHZxflrEcWNBKbwzPNs41KhAeqqCOQYpCuKZgjpzE hffB+fqVJzBI0dcO6kxKpNFaWT7tYb+OblsLsvHfEgsy+npiPQ3dBcZxlwd8DOLyZwf0 PYT8n4/mpKTqdb7St69GGHRTMe9KoddD2j5W9iq2nXNpJ6HahumxkoFZ/KlTTXo/5RVS P/Ii5szmaLl7YIcCRYOyOxKITTY85vtkqdlar1DW7QeC9ph8bFGQzyQ76m6LDHX82WLM /jdiFOZ7APHk6Dx3v4X5hBSOwzratmEwBr5dRqzZ0taMRz5s+vD9Yc1i3PIg+f0U08rJ Cm0A== X-Forwarded-Encrypted: i=1; AJvYcCUGvy7h/2KUFGo379LvdW0+IekTHJ7zpm7m9EI83P7rYAHMg7X4vmb1n7G+UZqjmVOvQryf1CJZkADPi4Vn56T14jcKbae6IcOPVtKhQ0V6 X-Gm-Message-State: AOJu0Yx0Ir6DazoJT/nNILb9Wx0w+7xPeX4ApUoGmxYRPIJQKn/hkmT1 WOQLR2WN3IHLbtk7uzvH6fjLhWUFr7zshvBAvvAsHu+C7032MJ1+rsxsRVAc8is= X-Google-Smtp-Source: AGHT+IGqx28NbMNvmzLw5J0w/TQ3ZQHmxkK+h/DWdncxb76LIdC5qwbxWV7jVF8Ibsfqau3YeIjlGw== X-Received: by 2002:a5d:47c3:0:b0:367:8a3b:2098 with SMTP id ffacd0b85a97d-367cea46076mr15982239f8f.3.1721045765987; Mon, 15 Jul 2024 05:16:05 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:05 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:37 +0200 Subject: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01 MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-1-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Use the existing "samsung,atna33xc20" as fallback compatible since existing drivers should work as-is, given that resolution and size are discoverable through the eDP link. Signed-off-by: Stephan Gerhold Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson Acked-by: Conor Dooley --- .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml index 765ca155c83a..5192c93fbd67 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml @@ -14,7 +14,13 @@ allOf: properties: compatible: - const: samsung,atna33xc20 + oneOf: + # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel + - const: samsung,atna33xc20 + # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel + - items: + - const: samsung,atna45af01 + - const: samsung,atna33xc20 enable-gpios: true port: true From patchwork Mon Jul 15 12:15:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87569C3DA4B for ; Mon, 15 Jul 2024 12:16:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF0BA10E36C; Mon, 15 Jul 2024 12:16:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="cWJ/ZweM"; dkim-atps=neutral Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40B2E10E36F for ; Mon, 15 Jul 2024 12:16:08 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4265c2b602aso28002165e9.3 for ; Mon, 15 Jul 2024 05:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045766; x=1721650566; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C4zewyPEhlNFFIG7IewHHr+zZpf0Zw7H1PjOS7/qftA=; b=cWJ/ZweMI4BOrfZXBEFnt7y/tHKfnTX4JoxiKGoySnif8ennKc9mTHMP/ULtdcQ4e0 jMWIfiFseCaDJ/0NgJlbIr1jyJ1Kjkn7fTSlxxbhcdbQKuvEZ8MV8KwV+0lGBrSvUQvl 2t8dLivcVFqUkNqF45ydZ+HdQFOPE2Eloq4X2wzE0b7TrcBiOxPiAsISk3k9Z8TEj6/6 WXx9doaWbF3rkH0ihHMf1jzTeZP/vFV4S4aY3fHA80hcFhNpc4BEURLvT31L54j/vu05 4V9jO3wRE65iyoDjf8krNo99q3X/HujLYezquzmoKFu+V6kBPbCeeQ6CEI/CPD19/C/A 6Mew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045766; x=1721650566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C4zewyPEhlNFFIG7IewHHr+zZpf0Zw7H1PjOS7/qftA=; b=WV8Y/ogmxqATx8jKnbAX+Wu0duIuvc4U7kKv8tzauNWx+Y7YfOIG6r0URLJz6F7e5r FE5j4o7tn2ozGHs2Z/HxS4Te565LYHJ1KZGwPA3JCNxTFvYv1lKHASnXj0i8OvZOpPZ3 8E07k5xrrBqX+d6B/Fm/dnfpIzjiI2yQvAYpPmSNWQ+6wEQIEbZG645trEQbogRCLHzQ CI7JSM/Y30Vdy0fY5EMz/nFwynAUdV2ZMLySj/EjZAWAuCBdh8/wXx00ug8OQ2gI30pA 2GHmQ8Ig2ucahg/HFLMm6HradWMFh2eAJyRSCZ4WJJg7xJtmdZFMrJwMVmiVQSjL/lNT y+iA== X-Forwarded-Encrypted: i=1; AJvYcCWKz71C3qqCJCMm68FWf4eTfSOP0q9bxZQSIq6gubIXWvIVkASgO575FyHPURrN4GlrHuSFjoQFWzHEpizpIsy1aS3zu26zfNDr7s1dKBHR X-Gm-Message-State: AOJu0YxOwJYEElrycUoXqV6M/rIewftXnqOsmLR5FUrvJi/5NKjHGMzA JeRBPszB9g7Oklew7XprfjFa9NtwLMayiGZm9prfs7zTpAuQ/5feYu5wY2EBIMg2j8yVpBq47t9 yKWCt8Q== X-Google-Smtp-Source: AGHT+IE1hOML28f+XraJzEd8SFOSIj91LonNL45CkfZTFsChgS0t1o51jq4Yctj5be3mCBmPsTXBdQ== X-Received: by 2002:adf:ffcd:0:b0:367:9791:2939 with SMTP id ffacd0b85a97d-367cea6b804mr11785800f8f.21.1721045766633; Mon, 15 Jul 2024 05:16:06 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:06 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:38 +0200 Subject: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01" MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-2-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Reviewed-by: Douglas Anderson Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Tested-by: Johan Hovold --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), From patchwork Mon Jul 15 12:15:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 020B6C3DA59 for ; Mon, 15 Jul 2024 12:16:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C75F10E363; Mon, 15 Jul 2024 12:16:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iweJ2yEL"; dkim-atps=neutral Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAA9210E36A for ; Mon, 15 Jul 2024 12:16:08 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3678f36f154so2487521f8f.2 for ; Mon, 15 Jul 2024 05:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045767; x=1721650567; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nlicpzX8j7ceD/JMCHCgT4Wp1znP1wKt2ZwJqztrd3Q=; b=iweJ2yELRnInCHWR2zyskGIKVl0CJ1tLL1G4YClbQvRjCwcugh0PVafY4aVXzeHMn0 fI16YbR7zpXh18lsq0ZIJPn2EFpxamUMasQE74vUa3qgPCYzNiJmvcnHid8nq0syHSf6 g+a+o7rEWS00BOtm/REDEluSLs6C5USC63AgiDxx7pA6O7w4kwL05kApYpJwpSvtE6na tiYtMCIcwkj7+/dUAyArlwM0QUuEYvb2E7+0aDm/A4Y0ynPw0/abSFhuApdcFCvTEa5V ft35rYJdOHyCXb3O24+8W/5a+fYo9o3xZ0tFKOTjjZtLJ79N3MTFjwDadFPk4WoV+Kx9 GMNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045767; x=1721650567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nlicpzX8j7ceD/JMCHCgT4Wp1znP1wKt2ZwJqztrd3Q=; b=gjO4psucFCpKsTgvUUhU2o7O55LBBMUPMOTtR7miIwUBMCasGJRzWKiNMxE/daS+Ac rbN2dujJ0suIFIEOa1gu5lI090GMkC6sh3AKF3B75P+hSMjMtRKFo01py9Lleojgy7KU pLYYPe8bHXI/jzQm0d4KnvKS7/2IDh+gVGF/5Whzo74Duq4FLShipSf65QVaU4NSol8F yro2BPi8nBFXlnHnLSp5fgW4terCN/ZYZmHHbV/ce833Qj0zsWRRsnltuiolQttga1J/ +bioqxsn/eQkRE5Qc3EW3SDSmG8Y+pQdsBE7TKqWgwTvu2NzV8lsD0GMWhM+XoV2Ulwq SgsQ== X-Forwarded-Encrypted: i=1; AJvYcCUYF0Vr969jnlAsgmzDa3ewBOrQHO0yaszDQjt94PuxHSaXEJABlXeyU8TX3apq+uJtP48qeSWCZ/Vui0Jse1NB3Q1RqI8+FBNoxktbpMMO X-Gm-Message-State: AOJu0YzES5JKpUCcIXlSyS3pcQRR80YKqOZFgHKiOCGT8ZKbGPSExZ65 6DCidYX9ugZsCU+0dcTDIy4YQVpvycdNa4azH+Nm6uR7H2XqfcYcZ+Jp4TSn6EQ= X-Google-Smtp-Source: AGHT+IGgvcNb0nVQlFTcKcu6JOIlWWDkfbIbuPOAB1CSXeabBGkhzvEOawCNDGbvQTG94lGN9DpG+Q== X-Received: by 2002:a05:6000:2c3:b0:367:f281:260e with SMTP id ffacd0b85a97d-367f2812acamr10220652f8f.3.1721045767292; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:07 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:39 +0200 Subject: [PATCH v2 3/4] arm64: dts: qcom: x1e80100-crd: Fix backlight MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-3-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") Reviewed-by: Konrad Dybcio Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Tested-by: Johan Hovold --- This can be applied as fix for 6.11 since the driver works as-is with the fallback compatible. If so, the defconfig patch should ideally also go there to ensure people actually have the driver enabled. --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index 6152bcd0bc1f..4a4eb7211e69 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -268,7 +268,6 @@ vreg_edp_3p3: regulator-edp-3p3 { pinctrl-0 = <&edp_reg_en>; pinctrl-names = "default"; - regulator-always-on; regulator-boot-on; }; @@ -724,9 +723,13 @@ &mdss_dp3 { aux-bus { panel { - compatible = "edp-panel"; + compatible = "samsung,atna45af01", "samsung,atna33xc20"; + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_bl_en>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -785,6 +788,16 @@ &pcie6a_phy { status = "okay"; }; +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins = "gpio4"; + function = "normal"; + power-source = <1>; /* 1.8V */ + input-disable; + output-enable; + }; +}; + &qupv3_0 { status = "okay"; }; From patchwork Mon Jul 15 12:15:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733385 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83D7BC3DA4B for ; Mon, 15 Jul 2024 12:16:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00BA510E36B; Mon, 15 Jul 2024 12:16:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="BIwbcPuf"; dkim-atps=neutral Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96F7010E374 for ; Mon, 15 Jul 2024 12:16:09 +0000 (UTC) Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3680667d831so1511434f8f.3 for ; Mon, 15 Jul 2024 05:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045768; x=1721650568; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kTq2r+cTBBf6PJ97371cfxGvOYB5A8cmvVmwB9VmmPg=; b=BIwbcPufWfrx+oex9hLyFn03CP+FFD8IDsCO2dW1M0qGNjdcVRQp34dv8s+B5vDunX GPQ6IwC5EEZGFZFRet65t7A8fZid71A/1+vhm4p0B4ocy7IXlY4hrlcX0YQibbufzWZW 7aFz5I8bKD41ZZVStsuHHLCdJuHbUcMGbamZ52CvTAhZhkytDM8ZA2ManvW1g5KJyTlW 4QUvI8Mo+9NWjAdO9b8Iu942WXGBwHI+Eu586kPmPxdVccJ8wLN2n9ANjym8Ufd2h48T Tl5W3OvITBZ9KIcxmgWOuMCNcOY6WoAm/dkQrABDdv7Jm7I+rdvLSmgp2J2xZMg4MtGk ffQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045768; x=1721650568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kTq2r+cTBBf6PJ97371cfxGvOYB5A8cmvVmwB9VmmPg=; b=w3Cq9xoYe+D7kgKAwkvfckbif+JK57DYhcsO3ya4cPA3g1/HnFofffrNy4A272/IWq amSbCGvyH57RTMj5EJNuyUU/GR1jbHmxP0z6WiF7mdGxvdytkJE0DSODhcACS6ToiuTf Y3cXe/7d0p/rXlKtR88GZozf37hZN2k3I3ZEyauOMGLHNljKL89KehbeEsUxpxXx9itb Pu1qUiJ4MAzFwm3ZefpVtL/j0xaQ8iXRqW9f6zydYPXkOYWCmUCwUSimPyKwMBosn5Mo qlTGbDmWAF+B8w2+wvAU9Jw//a5/F9AOiuWjh5AgzbI7F+mOYnzvXOuKkxtxEt+KvlER TnKA== X-Forwarded-Encrypted: i=1; AJvYcCWmXjZeTsjd82ncr5En3iYCUGMt6lylqM1lLeKNO9zpmPfW4ca+4G9NOkmyCq/xVwvIP9/Bjohjr7BWF8HC1YwRXyjJA2KW8OgYlyLe5FaQ X-Gm-Message-State: AOJu0YxNItyq4vHorqU5LzVnmRg1/2OGu/jFIIbaAFuE5QFBlgJVZU2y 3YQRDBj1E+y8gZ4c0+DK0K6Yp6RXxiPSgfbg2kbOMQgYxaxOLapGIU7APNZLk7I= X-Google-Smtp-Source: AGHT+IFs1erFYCijcBGp0SVQyMBvfH9pHBYbLhKOfck+AMcQPdS3cmXHK20l4yRwr/hKh+tKqHhBsQ== X-Received: by 2002:a5d:480c:0:b0:364:6c08:b9b2 with SMTP id ffacd0b85a97d-367cead1d1amr10964785f8f.45.1721045767976; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:07 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:40 +0200 Subject: [PATCH v2 4/4] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-4-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Reviewed-by: Douglas Anderson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 7d32fca64996..362df9390263 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -887,6 +887,7 @@ CONFIG_DRM_PANEL_KHADAS_TS050=m CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=m CONFIG_DRM_PANEL_NOVATEK_NT36672E=m CONFIG_DRM_PANEL_RAYDIUM_RM67191=m +CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=m CONFIG_DRM_PANEL_SITRONIX_ST7703=m CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m