From patchwork Wed Jul 17 09:35:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13735249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ADD4C3DA42 for ; Wed, 17 Jul 2024 09:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Z6No/akmzq0Xu0OdMS1/eT6CGcfoSRGGgGEw2lPMvSM=; b=tZVE03P6m70m/X2uct2YkCpkhb ECdEPh2OqIth6/YK9xlxNboUHkaoXz1WQtdxEtkvj9zal65LmP7b3J6fs2YG6PuDgFOZjxHIHtmiL wibBi14ZynvRQE5N0s8+A9Efbh30bBsCtpaiiJ27E1zFnu9s5n3YjUbKFOGBLkekI17vb7QvE0sto 2F2K0NF+sAFtmiD2BTw0pdiBl8SVTeDiwlxZMIAF+1yX7MOqqTe8qIdKw3gJ81BdnfvKDEFDGDnTU BocRC3Lf3cUSUB8QboMHaotMrunaJeftVczi1d/n9m70migwy2FDz/wMbMnNBTLXaX6ZBwoW79vmu 2GPYHuyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU0wA-0000000DJPW-01Rv; Wed, 17 Jul 2024 09:27:02 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU0vp-0000000DJLL-3Uvx for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2024 09:26:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XEkaWNwLSatsjOXTsRAmtoKNnQgZzq0wIrIxYEkp7ydVPZGuCE+wkY0EtnchfGPbytgdWveg/XaPyiPkNXpA4Ri8Dti1gjSwYcsbClEFxIJiRm/uqdiPxyPgm/ao3p7fg1aidkeP/pqa47sZ/q0UOaxsiYml/5s5H7JBLQNdCw+1s2+EXUlDVamn7NUU7GE4YTxcvoyU5EHlFIiCmsqSqNnkOpAmPXEM7SI5DUKiYGJIvG8LxgQP8wWy9H51XOcaOwYTkfINeBAx7vu7PVcQXsJn96RX1UNMjq/PEz/5oF1BSQtvwkRVKcZbkiJMLoPeu5z8a1oKEWy2Sex4D5Nqww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z6No/akmzq0Xu0OdMS1/eT6CGcfoSRGGgGEw2lPMvSM=; b=Utw1mBzcVOEt7Lv4GhCl/skB+3YZZ486cdIZJ7FLRfwkzy4W5Q5g8UphwBS7RSrWVwAIsSlQ+tNdb1/0DgLx5KiMo72qaKPLsLpaqnNr0AwRWwoHuTl0zbgpAMlxQ9WSn5pYBOjvOohU2Q+2/YL5B8dgjsLtsd0+hXC6iTns2A+0Vx0viP9oThL8JGcBOudpfZY0bBx8fZdboeLAIU+NaY3v68c5in68L/DxV6xD22/hXsQS0z9wFVPTGUA2CRDMM5Gy6t2CV/IDtSeIUo+DpojKRBnUF7eah6DdOpDkQAZNiV3Dw/sMzjS39/bCy3H9jWoregGzgskw6YOMwgmNAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z6No/akmzq0Xu0OdMS1/eT6CGcfoSRGGgGEw2lPMvSM=; b=c18NNvB5ROYDZT/D0rgVBNYFajVgrJc8+nNiIXWgPEYnHzuafZtqsvQQ26KPrPT1FvtYhUXQND4Q1grFyEeoExcyozKVReckuZA1c7s/XoNbKyD/6zf7ttnOvLFR0MEi8yq5xu2akBAn4no+UG/PVYJsBmkUkindWul8ILac87M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VE1PR04MB7424.eurprd04.prod.outlook.com (2603:10a6:800:1a7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Wed, 17 Jul 2024 09:26:19 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.7762.020; Wed, 17 Jul 2024 09:26:19 +0000 From: "Peng Fan (OSS)" To: sudeep.holla@arm.com, cristian.marussi@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, Peng Fan Subject: [PATCH] firmware: arm_scmi: bus: bypass set fwnode for scmi cpufreq Date: Wed, 17 Jul 2024 17:35:15 +0800 Message-Id: <20240717093515.327647-1-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 X-ClientProxiedBy: SI2PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:194::11) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VE1PR04MB7424:EE_ X-MS-Office365-Filtering-Correlation-Id: c41f6d58-e0c7-4b5a-5f60-08dca6428328 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: CXKKQ1o0tsdDBXotjnOmC+NsMKlT+KbmSAI0NxKcTE+LjJ5CzQk6S9gsjb3Id5AEVKKu6SU4Rfl38zmsKl7Z0s5BT0xA5ykLKfOkM4kL1yhRxP2Mz57bwoacTFad+oWzG8h+GuK9woAjrbYJiHauxAfupmnZGAWFNBZ/O/rCpkkxGrSWavjg6noD/2FtzeqPRaK24zSOQr9ovEI3mFa/7ImmHvcU8BfaE4vAdAQ4IoxCku/krYEZXsdXiPJfWwBz13km8bKuoyRO9Ir+jR4kFv6JIBAGaXqZQjH7RtbYBZ+JvjnoRQn8JC8ch19DCLg4wdcobElxFnkqLOAIrxRbkBFxJWZiw2TfxDxOTtm6aAhU9sH8ailRVqSI5TrO819EsUv9fdILGbRDm0E3BeBlTVEy3gRuG0cdeC6k2zjAmKBDhoXzqesTsGPMn9lRd6yVjoHQ+ksw8SoKZPUs+3+6y+bL38hLVdhzBZtm4N3wewPkqlM8UqWC6MNHpMeDpnM9xGEbJgQEy05yV/zYGq3ApwpeBAJ8l55sJaY4zLX4HbCdG5fUeohvOb+0lPLtomM6bL3E24+yRXamV/aL4OhxtYIQ/U+71Aw6GOWiNZ7d6Jb+fIZCL6TUFm3lA7Kc3AqoiOTBmUXxWWtChB8VW225oZiiGApWfFBaqkrMbWY+ASpej4bFLnN6mqY79HDLaOLpkOkwWoqBSKHF/ABFMX0Ub/6RQYza5klBk32Arw0PQH/By7V/4/wqeDM9Y8YG13cg8K8hLwT9/IAz9MdfQv8B3Rk7KSXLuJ0IISbJRMs0vZTmK66qImphqNO/f3INkIdsCq3NrQz5tzwZHaO5AqFHmeCrxLsCM2UBAq/GogWnE8FX2dGUzu+zBproSx40j7PKJCgv4MaDXwiSM5g/tbLgArXJRx5uqyrS1Ju2J5T+rDHk0/SEmq9Ma2lZ2ke01+6miP+seUauJ2bcqNnYRupxxtztHE6u4TUxiUilDW5WPDe9Ky3QlMMFaXrwrfj2HWZPG111GItDIn4uUsH7LsBdLfE3b/mXOrNISUlUoRJIt3RrhZp7RMOV5y4gqUGS5dyDGPf3XXlAEByrS/EaFnk6QWvJmfxYwSo7CjlSWWZEqlfqsSN8uilTFCU4gKTJHbTO93Gr29iGc69qPpCMhcisheTfTTKzSwO4iHI90lFrdtosgz8/+oGCEcPhhEavps+IxMgE7ysqmGZT+2Wk3MABI7rzpM+Ie81QHjU8C0Gn+NmwBfK2SyDfLrcXyNmfd3rzXxkBa9OdD2Bbj/oBH6M0sb7ePd8XL58nDMCwXBnL4adxat0eszUhQRGi+7ovPsJDdMBhRROrhm9U9FzKNPg3jjX0doFX0XMkPo9yRDgdvQlHM2RHCPeei0szy7BcHRlUlfk3uMqXV1z93LaZb9MnhA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rgutCSQSss2c+oURP9lf91s8VTaSkya3Ob8CMmsFPo6A+eEb/D65rZhKzXazk5xojPA0fQOOPdHtKAgN4io2yDO+4DjgKSavAu86jH/xQ718xTa3Kk56s92bsF+7ATyubh9t1ugGyPzm96nIhLqYnMykPpveixzRLfy8xSWMsECvhbej9V+Pdns/919dTG623goHcfZNm9fmxSw0hes78A0PhyNuqXAqv0yTe//Ahogp2IAPstPAokercLs+nTip3313MkLJB+Hx/LEIXGDaZmIfx9mryYF8X5qKNTRO16yGJjKcT2oUu+Th70PdamGW6lsV3JMGm/mbpdIceZ2qXUQmMv+3ibVSZHRoJ4PwTASqguXdI/sv0m45fmTOp0gTr0nVehRMUsM1Ns5FwWoDfNBp0cZ+lNFMbKaj8GtClSLtuROG0cfoK15mXid2cvjoUQVgstOcqcTw2fqkCrKRqK1rKNN2zTrPOsoHDHlvrVyjWzB7vIPmsbXcsJhv8MrnjXFFG+PLuO/yZ8qeVAL1y7rp01OAUoN4euKgkzfjPKHG7Y5zCu9yPkvTe1IEcrBfiTWb+sND+okMKq4fJwjOZK4Q1hK4klEOsyC+m+I/lxB+YvcR4SuYNW7KrqD870lfNhycpzSJ/jw7KPUNNmgkR7nE/yg0sNhHH+889xpotHUIMV9XECYQaRDrO/ZmNQhVnOQzGTNLdzXU1IApJuJVp7pLz9SYBxiaCC1hpzxAs2wnta0riBRaiVVFWzQkChufZfcy44IsWPe2VuXiNB3ag1RFAHroGTTVsOhLOli7KI/GMQ14LjkLZ2DtuyNKTsa4eUghUee9Q4mvfNaORdMTPUTqKLfBQj5MvpVYrFUCVDscdY4bWwNvXwUAprRqJGEIKNDwnHC1Z8uTNyq++OSb/FOO7BDqLKIPfY/1wkIkuOczBUr0ROpEAY2X6+vngLyIvlveZeGZNw2Qa1nRFAq2oFTWE7tdNe4EtYMTZUHPAIUmQ99gJzgp/DUb9Z71kgVDuPGYU1ZtwTgJ8A9G9p7xu0OsVyUQqG1maHeKbFXZtAiiYk76HTu3jN4WJw9Gb5GdGJCU7LGfrtOCNhOGN1jPzHAGzp4Qu8lmMbYyAjDLpRJ5U5YDP3FYtLyKsCQY3rNrYCtGF7lvMJ/1wCMR25OAuGHqs6AE5YF01gGDwbVpP68aWrEFhbiFVu5Sx3d0mUKUIYgxHxXTr0w7nkg3iyfYmPHTtrsg2upBF7CEFUtcI8GbOUCqePO6DdL7fnVL5YizAFJMXRVyMgxzHJo+/4+RALIWsAh5gpr8YDFr+UW1E7JpZAts6M8Bh3JFY1Uh4lI2qaBC9VaRd12qTWS/M5McFdO+/rtYTKPG2VhDzPfyap0MilLhTXJ4QFSG5jGUrhDt1sYK7ME8+kqVbCYKhwNBuGLRz9xg0/ZW8JSjFqdOSPEpc7jhNUT+MoVmRDzup/3n6mwPJj99F3ZcUsRPTHMB7bQauIXLqq5Mi0jrkZ4PRvBmsXOcFLU+5GeyOkdiGwT9RIFIcqvlLy218CY1YxmfIUBQC2QFRFYVS1Ijo3fvvSeiPdF+pNMEfzovRws34b3D X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c41f6d58-e0c7-4b5a-5f60-08dca6428328 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2024 09:26:19.7308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kNLtXrIJ6SDzM0XnWfrhURmIn7Hnk8HM1KDlJ91k8vmxXWJQNJqqENVnGHqGHqUCKAtdy3Ofc+xg1Y1KVztPNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7424 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240717_022642_187411_225F9437 X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Two drivers scmi_cpufreq.c and scmi_perf_domain.c both use SCMI_PROTCOL_PERF protocol, but with different name, so two scmi devices will be created. But the fwnode->dev could only point to one device. If scmi cpufreq device created earlier, the fwnode->dev will point to the scmi cpufreq device. Then the fw_devlink will link performance domain user device(consumer) to the scmi cpufreq device(supplier). But actually the performance domain user device, such as GPU, should use the scmi perf device as supplier. Also if 'cpufreq.off=1' in bootargs, the GPU driver will defer probe always, because of the scmi cpufreq device not ready. Because for cpufreq, no need use fw_devlink. So bypass setting fwnode for scmi cpufreq device. Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index 96b2e5f9a8ef..84c8e2714cfa 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -395,7 +395,8 @@ __scmi_device_create(struct device_node *np, struct device *parent, scmi_dev->id = id; scmi_dev->protocol_id = protocol; scmi_dev->dev.parent = parent; - device_set_node(&scmi_dev->dev, of_fwnode_handle(np)); + if (!(protocol == SCMI_PROTOCOL_PERF) || strcmp(name, "cpufreq")) + device_set_node(&scmi_dev->dev, of_fwnode_handle(np)); scmi_dev->dev.bus = &scmi_bus_type; scmi_dev->dev.release = scmi_device_release; dev_set_name(&scmi_dev->dev, "scmi_dev.%d", id);