From patchwork Wed Jul 17 09:59:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 13735292 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88FA817F369; Wed, 17 Jul 2024 10:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210401; cv=none; b=f82MNcKC6YkUmpy8fqCXMhjnSF2NNMDfC0mhFFAsSB3luE7av3IXfQT7gSob3m41iFfW5evWahMWNKG29MlsEKzvKJa8+xJ4fojjaNsKV/V4K0somhUyHOrVj21/bwxyKnU5OChIpaP8HPnGgTJH0KuLx5/gPGzcfAvPimThXKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210401; c=relaxed/simple; bh=fcaQeVYlwpBiQy64PeATOVnG5Jbx+9u+ZH3xphKxDbs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=See2RKRhvXq3NoFGYdAeA5KlY8UXtp1sLxXNntySHeiYOTkmJuQgmG7wzeRB7XmDIRQQ1V0bx45m23WsSch0rhZhLNSRk2TESl4NFyCJM8wuGTvU8lDY5YlE11E1Ab0ow+B2VlY2lO0DBK52vhl4IMXiZchOoTrvc6/xtPzEEaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uWzKtiZH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uWzKtiZH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2D2CC4AF0E; Wed, 17 Jul 2024 09:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721210401; bh=fcaQeVYlwpBiQy64PeATOVnG5Jbx+9u+ZH3xphKxDbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uWzKtiZHNwzAdTR9t9wQgbyxeYKOt0/Lxl6aHY9GvSIdfqcg3wPb90t3/wMNPNu84 fBYPuj5D/mXTWKYpHmH33HTj0eiogdfjxHFMhwvi4BrgC1YbnTSdDk7v0QaTEKS490 Xd6f/ljj3T85DHqHjrgS4GLsvXyIRW72NOGb4bqUBSQPipWdtGk02B+2XBMSzk5noW uxvSUYFgD20aQt2tVrYMctia1f7Mn2lfyrZimpUeZxaPWe+vahj5rCLt6sRpO42igx 3BMD06I2RN8kqMFbEOcCjCpDARzoGHWHqNpusV3Xsl6gaGbKayQRCuSYrhq1A456LY UZbjQxC5SZKtQ== From: Conor Dooley To: linux-kernel@vger.kernel.org Cc: conor@kernel.org, Conor Dooley , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Mark Brown , Maxime Ripard , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Subject: [PATCH v1 1/3] dt-bindings: trivial-devices: fix Rohm BH2228FV compatible string Date: Wed, 17 Jul 2024 10:59:48 +0100 Message-ID: <20240717-exuberant-enlighten-f890fabcd247@spud> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240717-impotence-zippy-254b86593069@spud> References: <20240717-impotence-zippy-254b86593069@spud> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1324; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=Pv6EDJ42tO+761aHkXvuRjBuVza1njIC6Q/agA+48Ro=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDGnTp4lsC+Y/eeJan/OEI+e1bji8ErrYWeJTsOHi4225i efLJVfc7yhlYRDjYJAVU2RJvN3XIrX+j8sO5563MHNYmUCGMHBxCsBEttxiZGhWn7HP9fuSRT/+ 3bJamxGzeLl/5Px296XXt921kmD4E7uJkaGDPyPj8dyTnz92mN1fycofO6ndVLE6VIZhi0ByZez jMzwA X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C From: Conor Dooley When Maxime originally added the BH2228FV to the spidev driver, he spelt it incorrectly - the d should have been a b. That spelling was then propagated to the binding when written by Krzysztof. Add a new, correctly spelt compatible and advise against using the incorrectly spelling. Fixes: 025aea27732d ("dt-bindings: trivial-devices: document SPI dev compatibles") Signed-off-by: Conor Dooley --- Documentation/devicetree/bindings/trivial-devices.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 5d3dc952770d..7913ca9b6b54 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -328,7 +328,9 @@ properties: - renesas,hs3001 # Renesas ISL29501 time-of-flight sensor - renesas,isl29501 - # Rohm DH2228FV + # Rohm BH2228FV 8 channel DAC + - rohm,bh2228fv + # Rohm DH2228FV - This device does not exist, use rohm,bh2228fv instead. - rohm,dh2228fv # S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power) - samsung,24ad0xd1 From patchwork Wed Jul 17 09:59:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 13735293 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B40104204D; Wed, 17 Jul 2024 10:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210405; cv=none; b=oh/BmJKwWQ+1Ov7aCPOvQ9Xp2pirlDRwqv3RD4cKflr2prb3Vo4kAndlf6MJRz7RpJjxJ+aRqHhPiCmSIoS0leQ2pPluTJkdyOuDfHndReUfr57fr+a2AwOJSRDu+WDoQ4dNlOo6IktNC/v2VLTlhOwaz23pHffIYE6I/rToS9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210405; c=relaxed/simple; bh=FB+gkQhT8RGDWncY72r8oB3sgk2ZpbFKbtUPoW8K3ro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rx+P4hE6i4j7bbY1/vXcT1d0BP3bca/w5iCftZRt4qYTMVqZo45O/OakxLTg6V+dBjFE6PQxZvy08QhOYXRB4wMDJPl9/EvXfdWrGVyRC/S1sYcwwaqG4Mfcp8yWqrARv0s5pb2shoNeG0vK3y9UeoNqY/lhQl1hqBr8N2yqoxk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cLbf45OZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cLbf45OZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F4AEC4AF0E; Wed, 17 Jul 2024 10:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721210405; bh=FB+gkQhT8RGDWncY72r8oB3sgk2ZpbFKbtUPoW8K3ro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cLbf45OZYqiYbIcHcRNJb4KrYMYYjFMhVimjgs0C0QtbTsC8jVsjoIGa0WdzLMRZu v/ehkUUqnYmNv+4ZN30fHK0wAy7eCfMWWSUcj/eP7/thoYBkOLgCqQZoFBoEb8Kowo fb2pUCLKEDsj0E+wEdXHcPm/3CES4y6qwaiyuR3B0G99mDFFiew3/xTL1/BPy0+dCw +FZ539tYFAxVVD3CVemJJZv0gq5Otw0iIGy2kkJE5mADZ3MglTn5d+Rd9Mt8/BWdTi yIlyiwoaYff/AsfsylnZP7Tb2yEehaAYB9BinUTP8xbNPLdgoc/lEgvYzatsGTGrkY YD19Ehnp1QLoQ== From: Conor Dooley To: linux-kernel@vger.kernel.org Cc: conor@kernel.org, Conor Dooley , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Mark Brown , Maxime Ripard , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Subject: [PATCH v1 2/3] spi: spidev: add correct compatible for Rohm BH2228FV Date: Wed, 17 Jul 2024 10:59:49 +0100 Message-ID: <20240717-ventricle-strewn-a7678c509e85@spud> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240717-impotence-zippy-254b86593069@spud> References: <20240717-impotence-zippy-254b86593069@spud> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1283; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=CcLwP+5TB3urQavRjMU4fiPAsz1HM8MlYRRdrepViDs=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDGnTp4nceKp5cWXHwjXRd7fOEkrkmbDX6bDe+3Pe/2s/8 P7evL/XoqOUhUGMg0FWTJEl8XZfi9T6Py47nHvewsxhZQIZwsDFKQATaaxi+J9b9ovrqNg+x8Rb bq9KHjIstVARn2gYeifsurOtWdyBV6KMDPeWn2898GnGgotrL97pFZh0Yd7StcknX7boTVvdu1a TdS4zAA== X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C From: Conor Dooley When Maxime originally added the BH2228FV to the spidev driver, he spelt it incorrectly - the d should have been a b. Add the correctly spelt compatible to the driver. Although the majority of users of this compatible are abusers, there is at least one board that validly uses the incorrect spelt compatible, so keep it in the driver to avoid breaking the few real users it has. Fixes: 8fad805bdc52 ("spi: spidev: Add Rohm DH2228FV DAC compatible string") Signed-off-by: Conor Dooley --- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 95fb5f1c91c1..05e6d007f9a7 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -734,6 +734,7 @@ static const struct of_device_id spidev_dt_ids[] = { { .compatible = "lwn,bk4", .data = &spidev_of_check }, { .compatible = "menlo,m53cpld", .data = &spidev_of_check }, { .compatible = "micron,spi-authenta", .data = &spidev_of_check }, + { .compatible = "rohm,bh2228fv", .data = &spidev_of_check }, { .compatible = "rohm,dh2228fv", .data = &spidev_of_check }, { .compatible = "semtech,sx1301", .data = &spidev_of_check }, { .compatible = "silabs,em3581", .data = &spidev_of_check }, From patchwork Wed Jul 17 09:59:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 13735294 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B24D17E91D; Wed, 17 Jul 2024 10:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210410; cv=none; b=cpHIyinjzcifncECtyBP9MKRWmSx1+J6rRl3n3dluXSEF5BerRNTr574cJmna3BsUC9PHoGgbX/aC3lpqZ8YKiTFHmqvCmqQUY9nmehDNJDPMZlbWM103hgkh//tb6ejj6+b68Nm613rBB2j+1dT7FdtHhW3XYDOBRpT0LrlidE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210410; c=relaxed/simple; bh=apvG84V5D72A2ovX8Ym5o4GyiAqCNrUwmsljBqYzti4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PBdPlNioEp55niQpcDcMblYVzI/+LEu1pkRuVTPFR8ZEc0IC2I8/qwMcF83Qayo0mHDopgQzxBDlGbSDTeQM7sHCzjEu3g2zTP4Q3ewjsOH579W2WrsR7cKM9We4+0QSi7ucOn4MA7nq3RTlT2XNfXNZn60IjUKfinadzJ4t7cc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hAMxBM7d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hAMxBM7d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BD3EC4AF0C; Wed, 17 Jul 2024 10:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721210409; bh=apvG84V5D72A2ovX8Ym5o4GyiAqCNrUwmsljBqYzti4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hAMxBM7dM3iZM90G09J2sTpcTYpvsVGIavBmWZyzFQL4/DSzwqvfSXS0MtcJDwh44 ZyEujha0/1Rh6u+ryIuXzHi1KXHWorR9lMt+5zSyEiC8+5AHkv1ahoFmywS/jO05RN 4YxpNrtmavjmQHpe0kn6nB/E8ctiC5Qb9dAUmFZrxD2JoFVkGaomRBLKoy0IOYnNu/ HZ7RZyQ3nf2n4VnjoxdXRqNJLByFfvDoNKWTDXVabxeECcvVg7RjZGBB+mZxE2OLb8 WcXwVLP9YbYZsuQW8o3Ov+6YaVjKcqbUMBXeWhkY/2+45Ip5Ge06qKgPHaU0Kp107z 7z648utjzWGZw== From: Conor Dooley To: linux-kernel@vger.kernel.org Cc: conor@kernel.org, Conor Dooley , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Mark Brown , Maxime Ripard , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Subject: [PATCH v1 3/3] ARM: dts: nxp: correct DAC compatible on Crystalfontz's CFA10049 Date: Wed, 17 Jul 2024 10:59:50 +0100 Message-ID: <20240717-ruse-cardinal-c30cf11bbf1e@spud> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240717-impotence-zippy-254b86593069@spud> References: <20240717-impotence-zippy-254b86593069@spud> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=868; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=po4ukk2TtrTbTP6VRex1woV9O4IoqV8AZfS3boi8AP0=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDGnTp4kYKOQ98du0snKlpi5ztLVBwPSoH0v7dPQNJne8c bW9ECDeUcrCIMbBICumyJJ4u69Fav0flx3OPW9h5rAygQxh4OIUgInEfWRkWJH67I1ayQXV7/wh up3X71lVHfNSkFNw5GjS/PnMnH/7bIb/sTNy5rt9eHDk/J7q+8XtfzbV9fmfmm957P3G3Tsyf74 5zAAA X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C From: Conor Dooley When Maxime originally added the BH2228FV to the kernel, he spelt it incorrectly - the d should have been a b. Correct the compatible used in the devicetree. Fixes: db7a8946dc40 ("ARM: dts: cfa10049: Add the DH2228FV DAC to the DTS") Signed-off-by: Conor Dooley Acked-by: Krzysztof Kozlowski --- arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts b/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts index f0ce897b9d5c..3cd2acbd8931 100644 --- a/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts +++ b/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts @@ -143,7 +143,7 @@ gpio6: gpio6@1 { }; dac0: dh2228@2 { - compatible = "rohm,dh2228fv"; + compatible = "rohm,bh2228fv"; reg = <2>; spi-max-frequency = <100000>; };