From patchwork Thu Jul 18 10:26:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 13736339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04EBDC3DA60 for ; Thu, 18 Jul 2024 10:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Ea3q8DGyqZWZT3weIDeXRJreBmnXAssnNCOmfCGdYPo=; b=f6ew1VaxYwF6heKENa6G03lll1 8XTssjFjLahKuG7ruOn+4HQLcLUnPnm5Ntk+3VQdH/QgXCRBt0USQb8zCgbl0U0FT4tLGdECBIfkP jkoQaUws/39qXkR+x9a7XbaTl3SbXiuoKBC3jOKA26NpbR2LIloRc9Noq8fkG5ZFWhANsbZbI57xH VRJuNIyr32Fa1ddZSSyOQOL6HAm6NCJR1eUXDR8uMLAKXApFy1x6UEOoNYaJ/4TTgr4Z7sO/w17/W 4MA4lZBBXNsx+ekFAvxgd6jF1bJkJPTErjWDQWgeB1Ni1WtCdaiNWTqEtlj3IUIBz+DevvFyWRFTb mkj7xIAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOLj-0000000GgPp-1n91; Thu, 18 Jul 2024 10:26:59 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOLK-0000000GgKA-34Vk; Thu, 18 Jul 2024 10:26:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ey0XvknHvDnmIg/LI7kPR9Q50YdmU6Ex++6AdukdGO6/teK0frrbWqSjamrgQbmpMMEOjM2w0W8fara+yZrFMVgqEVWtvtepN3hEnYSahmOiHNoBIxhbIW9+rETB7MIoGtUO+T9LADeeXsiDCokLdxMu6oOTs5ojfTGdjVNUL5VRnIK2BfvjmHcJ/3+R3PgX/eTZPFskZfMMgan7MS/KYwFg6/vVZOSbuqi1vdTa9fQajZZKHjSKnqbyn0hncJssMXJ9ElzCnHJxq9csvaMJ70lOiNlL0MVxzCrIfft4UiW5v5K12+nlh8wYWmiukQyAZc0VEQKh2P1hTRNPN8kV+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ea3q8DGyqZWZT3weIDeXRJreBmnXAssnNCOmfCGdYPo=; b=GW0ySr8IbyiP2ScGzP2hyphQj3RetLy8zIbeM5vNydAOJN7622jFjoIIxbY+90Ayucmi2ycOojRA9N+UUEglPI6tmLIoe22wSNSnkNZ6SaetcbvNBGhozCwlzeGtRdzsCduWjm1nIMvvIahJSsTuf/8sibIjRPQDF/qjj8xa8ZkHjA9U4naa86GRRa8HyIfqxqfbuo5+XIFtx5pXFFa9bXlRJxn1dMr2MHXTIwcT7xr8Rp4SSvBQPQ9+7FK7mk6XwgXHdXJ41MsklJtmgSmjk8ErrefMl+LxHKdABagig9bMypEVDZ/f/LFx0Z4ojoKAXLjYPsNBaqzaIaTLAueZRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ea3q8DGyqZWZT3weIDeXRJreBmnXAssnNCOmfCGdYPo=; b=PjCbSg3xWT1ZjFtPU3IEmc1DBtSiIgs9nKAbr6II9BErYCgeVlP/XYqLwBhST+Z5S9tv0xoPU325y0zezbOcWgK+MYAgNaGJE6KZvM1FEKBUq0DLgF28ZJzLP91ardXtqye0bGnGqU0AYoma0DDQN6SpP+TSAfMY2JpHe1MXQaw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAWPR04MB9886.eurprd04.prod.outlook.com (2603:10a6:102:37f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18; Thu, 18 Jul 2024 10:26:26 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%5]) with mapi id 15.20.7784.016; Thu, 18 Jul 2024 10:26:26 +0000 From: Xu Yang To: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: [PATCH 1/6] usb: phy: mxs: Using regulator phy-3p0 Date: Thu, 18 Jul 2024 18:26:32 +0800 Message-Id: <20240718102637.3964232-1-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAWPR04MB9886:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f1f90a5-9c82-40f8-8878-08dca714147b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|1800799024|7416014|376014|38350700014|921020; X-Microsoft-Antispam-Message-Info: 926EaJYAJqH0W/eItKhosfCdOzgTm4tJTIB1CufsqggR0Kout6COZvXepVPJUUj45BB7W/dvYtAGUV9tcAotbbJpOcrkKlXGNZjftpY4DoNokOhbgFlZ4bSpjHcj3ZCKYsHiN26D3Ylzad4hwTtTl9q9yJH6SJD2BPcECBdw8/QwvIl2u/ePW2/40wgvFfoRgk2bsy5rffENP+zMkzHEe9VkoPWjEiy7QjOTh2mNsmkX45oSj3cAkKPbbsftmsHOufhFEsaiSEBC99ej+vZ6/wINHQHOUxKx6G87hWhAmIZj6OugrTMH4xzk/xcfDK5GA7v72mR/kAqZvdeHPR5+HM+9XS90+lBt+yxEaeyj8p3V5CxIJXhQJBYuisgmEp8vTEyyfC1zk09y7F0adztJR1kNfRiVBbYhw0oKWZUaSWqDVT+L4PQsRzLyXAkyPpPL0rciZ08FJqf25RcmWQTVsmK5K2wp/IZkxcf3EsSdbT/bfCUUwFCqCsEVzhO3l5Q0NPnPVCjYmI2k5tx87UKqAsx4ADRIYeVFxXk+R3kQKOhruzsIWqEph0RrY6SvVAC7jm870tzS7pF1BkwdcmDHYykPFtMCVJSsgR5GqKM/qS+LME7LtqkbJJ5wKaeLGw/0pbpvfjHhqnQ4rMEbPKFL6I6Mjkq7PNoTd2TCa+XNrBwnA+XJQ1ynBwuuCdupxKRWm97bKrfH2fJLkacjGixDR75M3AKyc6EL+mNQtfCz6dlqT7VtD5lpzOhEZ9PFnba93uTK9Thwql9ca0Gg7Ag7NxNX4xd4Cz2Q0poAjjql7O9iqNYo/h+MStgA72lB1++Bc+Hk5qhb2xHYqETIjqQrS1NJVQ1HZ9imVJcWfy6fgAyQbR+nWYNv19w0+uKl8RVPe4NobRPqwglZNd4X8eJER+4dKSE91Sx0By8S9zFvqkB4qa2RR9geqMLKeJ/1mhQIj3mwvOwwlV2GjflKIjtYDZimuhgDtXrQ+SC2mtu6IuzWpASGJqSXXFl6EM+jfp+KA01B22ZgKc/Nlq9JBB0hj6WPKjwAnJ4vOPrADiouSnwLwL/tjharwdHWKC+/hQQDtzSFbU0jANKkSL5/odbkSD+latMsNAiNXIbsWWOxEaXvlPDqpbpRwug3I1nNdD6YBnye7TbEKKobtQulmTSkTbKbzB+ncFZX4jdUeGbjalrePA9rrlWW0SN78kdLv3vdga3PMTn9TImZZQpTwr0/bTxuJFun1tPQBPhPlPNE7vBlp4PQ+tMTQjiOEBZMHSuwkAUlN3YBEDJQvYsbrgA0oN//0gySqGZkIwRhW6Hsj6b+Em8fMH4gaw3miZ7hLgRkTEA1iVNB9kOjq+vdGyWMl0jBsPmjGBp2NIvul1xYbObgGCzjt+EYvoiCwYXjGRUTAFmuuvkuAKh24yIZ6ag56D6AiiLTUeYkBunIta0p404= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(1800799024)(7416014)(376014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6JcRU8x5BjFxSGq4/CpJNJJ+HAt8x0oj08hkMlAJBkRd2e1G8OvtBscbp2FADKK2Nu0NwSmTdb/hnaJg1csyAlKfnHvFEaocNw6awRMizd4XseIDQIRFmOPpgBN2QpaAVZjB02ydFaV+JgaaGNmoKdazIS+GKa6+tEaVWElvQ2WDMsV9IHIcEB5H3KpMFRXSyWQctJmszieUo49spgcWiakC5HVbB1HjOV2Gs1vFVmaOB9sHVjRaEOJ3gBqq6NgeuRx8aDFMReHBraEYgi6CHDzBy1do5BJI7zQuablp/r0IvcVEA4D1JiC8ZfhzndDVBI4FkDWkglSfTfSpwtX3PBQQsVwp0d2z0oeIVFZjojqtSVfI9RMgAyNZqeWFPxDbXO1BdV+IxGJ8prlgmrIOenHTsCmhHq0nLaZnw7SK5n5G/qz0AlURQk5jX1ilrGHMa9wNWpvW5MTIEJbFXLSSoht5Vt7fRGvuAnnlLqZudYebC9QfmIOgAohgUzNnZA2ij2GLrOSy2BKrMTYSQkIaKHh37RKvmPqfIMNvivYobUFMgKeHHlGPtbtSvoKzc1h73HoTa1Rk23bUqgU7/+gk9avyNGZi0exprvApJH+MZipzDhLWUX+LMcY5B9+yrbUFmbA7LxwZs7k1Ap0pWTOReWXjFUvHv7BQt6lmdBwyD7MKLhYSzcTIiBnNQNYH2SKxk3e8g2E8rvM2vrTVmiqqDhSLI8EHCQUHVd80xPQs4fY3t2kskPNmI3H7wBbb5TT5NcZfgGGSdytWOPz9EbavoljCpkYSUpLb++Okf1D3YEi3hUlAjQt5YXodPQpccVIkbcOH0T5W4qDJvjZVYbqCM3/SD59flJJANaOkRd1Qy0DWIbUm2CJG1IGV+dlISnHCCyC3ykD3H7DM+XhL3lJTWZXcuOYf2/42BDE5gZVGSbuyX9EpkJVeIuk2CXm5Gwj05dRNrXQwa+h3vYYkXu+cutMIlJh2fpp15pZynopStk50ao3YOD+uHBbKh7YAWpeuLaY0u9Kekfd0zFKQffXOOsmfsTBEb26O+8baBcmqF1Go7a1b9oOneL3HpvW0saZeKcFvi4NmNJJGKft/epFoRxc3X9ssN45xCKwIMlq7xh3Uyaxi8VvI9TTcPJoHK8GK9QGzuZ286nFtv61SUdPdnz9lq4seSBfMnrf5UdMv292fOeNBSD2ykCNSvVYVLh+bmsW9D97M9HuJB1dWXzoJaV4zJzlYh4EPf9zntInsOCLA/z6ngVg1GYDOj9a1O+5NVgF0o4QAm6/IDdVfOTOU6ZGE/rxiJW6CbIR5/9DCQoPcK0L6q+DTZ9HBVIYXIUnh+IHCEt0qcki6NdoSYuH2dDnB82+ULX+cot4cUuJHeuabkK2ePm5S+4Po7eGo68nKJlaoUiOtidZ//0oipjMK+BGhPhMNiabKjbPkeONg/+kB5HiPKOP+ihhstFDj4YZz+wvbqxiqj8y3xM30IfBPO0YmjbY9ers1pALw2Tk2rTzB8/NplHNQQzCrt2k3dEO24mNmX75tSGnD27dSWq4GKn97/Z1bGi1k5uGP3xdNE/OpF4F/H67pyPH/pWJR6Cfd X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f1f90a5-9c82-40f8-8878-08dca714147b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 10:26:26.7637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cYY8R/yPk8tyfQ2QWtfoo2TZ/aVjeA+Imzs6E9+5UYZiBIst/rn31m3jE8oIZIK3IG5Gk/ZDQ8DKe2diaD7J/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9886 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240718_032635_025387_401EC665 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It is one of PHY's power, and we need to enable it to keep signal quality good, and pass eye diagram test. Signed-off-by: Xu Yang --- drivers/usb/phy/phy-mxs-usb.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 920a32cd094d..42fcc8ad9492 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -18,6 +18,7 @@ #include #include #include +#include #define DRIVER_NAME "mxs_phy" @@ -204,6 +205,7 @@ struct mxs_phy { int port_id; u32 tx_reg_set; u32 tx_reg_mask; + struct regulator *phy_3p0; }; static inline bool is_imx6q_phy(struct mxs_phy *mxs_phy) @@ -288,6 +290,16 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy) if (ret) goto disable_pll; + if (mxs_phy->phy_3p0) { + ret = regulator_enable(mxs_phy->phy_3p0); + if (ret) { + dev_err(mxs_phy->phy.dev, + "Failed to enable 3p0 regulator, ret=%d\n", + ret); + return ret; + } + } + /* Power up the PHY */ writel(0, base + HW_USBPHY_PWD); @@ -448,6 +460,9 @@ static void mxs_phy_shutdown(struct usb_phy *phy) if (is_imx7ulp_phy(mxs_phy)) mxs_phy_pll_enable(phy->io_priv, false); + if (mxs_phy->phy_3p0) + regulator_disable(mxs_phy->phy_3p0); + clk_disable_unprepare(mxs_phy->clk); } @@ -789,6 +804,21 @@ static int mxs_phy_probe(struct platform_device *pdev) mxs_phy->clk = clk; mxs_phy->data = of_device_get_match_data(&pdev->dev); + mxs_phy->phy_3p0 = devm_regulator_get(&pdev->dev, "phy-3p0"); + if (PTR_ERR(mxs_phy->phy_3p0) == -EPROBE_DEFER) { + return -EPROBE_DEFER; + } else if (PTR_ERR(mxs_phy->phy_3p0) == -ENODEV) { + /* not exist */ + mxs_phy->phy_3p0 = NULL; + } else if (IS_ERR(mxs_phy->phy_3p0)) { + dev_err(&pdev->dev, "Getting regulator error: %ld\n", + PTR_ERR(mxs_phy->phy_3p0)); + return PTR_ERR(mxs_phy->phy_3p0); + } + + if (mxs_phy->phy_3p0) + regulator_set_voltage(mxs_phy->phy_3p0, 3200000, 3200000); + platform_set_drvdata(pdev, mxs_phy); device_set_wakeup_capable(&pdev->dev, true); From patchwork Thu Jul 18 10:26:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 13736345 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C7E3C3DA49 for ; Thu, 18 Jul 2024 10:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m51t4uc5Oy+0Zciu0H66lXyWPQeyP0+RVa70o+vUCRE=; b=uYz6J2JVGRkYdUskPX/pvEyAMl 3W1Yiile6tRv8jld2ZsHK8Ir973DA8+J5d5a0av9YkC1V55lSbJMJ+bQOVpxOc2wO+b94+zMCNSES yu3vw1qeDk+hYKUSWnKXYEIFwh/kYu+xz7R9WVxLKbDR0R3IHq5bKi2c+R3YIVSp65sBhjjwxt1o/ kJxz+GKxBgmECXWFAuaG4vAZ/Akr2DdLUvhKCIQJ6EXGYkcnvb2XX7JANaMQtGVh6TA5iq3HzWPW6 BWgM/7u3xTEIVZKykLtS0GbtATOq1MDacSmzNqKUrEAAxavaqmgBdWYwwHlTNh6oxFo+Gl9zmzHbV vFBnRikQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOM6-0000000GgYs-0MlQ; Thu, 18 Jul 2024 10:27:22 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOLM-0000000GgKA-2buS; Thu, 18 Jul 2024 10:26:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r8lsy4IDjWFZGfG9F3oGsDPkyTTlZMREVaOT6O06501rOtBPH/Y5Z62IEbxwE9Ck3XlDrYND3F4CclS05aHEsWlQld5rZlA0zPGAbqVWh5fA9wawC/14S8gCJ9AX4weinSxV9GcBK6j+IG/rIKPzJtdPp/EQc4xRbCF+tL626TxNeIGm+sRI2lv4lKY6YHitf3QkF4QA59JA0gSNN+CrMgAmZFmw/2hB7u8s70Q9Kc5Lzj+vmjjr3kA9vOIkFHtSG7nvCA5HSNI3pAl038QHRr77sdsIDzFBIPq+w6RXJzItDhCSaVTVcrLsfRb5XyNKUTtdjbX9cZFe8RJvDBWEnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m51t4uc5Oy+0Zciu0H66lXyWPQeyP0+RVa70o+vUCRE=; b=HBPzp6S2w/tbM3eA9ELtRvqefCZqHut61gSzMu9yaTNuaqWjqi69nMLd32ePl/vDzo5uCkoWRj5XkBt7aSZqCfX8d5Bn/RQP4s+SRSgHca78Mw7PwBzVbPIg7nh3q1YyMfpb9DwqJUt/PjtVjrMhVIXr0G8A4JeYB5TV90jYOF1vYTKPzwF/f5gjfbFgY2H32uQB3V7al59hSy0VPKY8/NEW08uZB7xeLHs2a1DNkPOmqn2JxisfUFCXg0zvh10g7VpK722xsN/h6s7VJbbZadvL9Mq1cEWkahvmcpbYGqyL5ln/rxdg6an647IdgsvTIZ0PDjoKrrMgoy9AGGWDHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m51t4uc5Oy+0Zciu0H66lXyWPQeyP0+RVa70o+vUCRE=; b=hgt8OX/EgC8bmKV76CrZ99rChHRyD9DT0G1kykd+rJWlODPdjcToNnmEB+hU817ovNmszWeNPn0ThoZYK7RWSINUirLdtHfuwhBu7twnY057nOAfEMMzGcByh7PIYYdrDrjbGwj6sWQZ0cEdfXs1rQVSihQ5OoFxa6T1Agh91uE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAWPR04MB9886.eurprd04.prod.outlook.com (2603:10a6:102:37f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18; Thu, 18 Jul 2024 10:26:32 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%5]) with mapi id 15.20.7784.016; Thu, 18 Jul 2024 10:26:32 +0000 From: Xu Yang To: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: [PATCH 2/6] usb: phy: mxs: keep USBPHY2's clk always on Date: Thu, 18 Jul 2024 18:26:33 +0800 Message-Id: <20240718102637.3964232-2-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240718102637.3964232-1-xu.yang_2@nxp.com> References: <20240718102637.3964232-1-xu.yang_2@nxp.com> X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAWPR04MB9886:EE_ X-MS-Office365-Filtering-Correlation-Id: cf5bf809-f277-4974-5096-08dca71417b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|1800799024|7416014|376014|38350700014|921020; X-Microsoft-Antispam-Message-Info: Q6q1k1b3Cm3RtipL4ee+W3hnmvORt70ThVP9vC0tZJRTqep6ElLheGFV2pWO+kg1LdOgEhC5Kuxjbas9tCLGfRiFVxMPNZBi+ZdyVxBAKqlmDjZ+Ly8/PiNGYxycdqzBxaxaUf8NrTLzWVMk6p6XiMqVLBZGuXF7dm4bOLmloAimDpE1LyxwaescOLZyaNLrU8mw3Z9RFsux0RNhqdumb6Va6PrWJRj1W2CSBNXStlfxvCvqWGcvmrXG47tH9W/Coq2VGDAeaznRUocXoUi4kPMkEBqu/C3d/lsLGTGUav2X8nqz2AEN5xFBSuGqKvIPYr0NH2Nyq0OGuL2iBhAS//add/z7dd4P8cpAlXscwjuD2yKp57dbIUJV4NXHQ5yqP+SydgG/ai78M6uY6lVura68tZQ1SJJDQoUTeFs4uPD0kjkxtNqtIa/7CMUu8ncqnUBg/RtOzk5mIe0Uig9cWmgvD01pkuDMdFD97shNAEWdPGRtf/DhyDJKEVatSN3uUInvU0MeDEkOxWeQwRLhItDK5gXJHSNrT2d02rNtQI2fkygW40+Fxm8B6mMXuTHsaqKvlKBDSX5bkTXkYwbg4huPeWQKhiatzPlFisBBF56mNDwV2zDmcL5JQ5KEO9zzjkmscucwhON2BZDZIUdj/4nI0I1zo7ZOeWGsK8kToPhsGavVXd5ojQpB1xgguK76nWNcFDokd6r65Uvi0PA4Oqhb3GC6V+2uz78tBWlNtq0tNQNbpV2DRa7rbtxQV6Zsajjo5KB4rhQfZtLocdsrrtqUz4mbkcVJGADBfp7srGGJh6/3wOQDU/upaO+iF4WdV0Uu0Gumm5xvIBiWcIJb0HXRcwjq+opLAmchQXdIyiN4aOwnRlmnbO/EhMvmvgqk8t68pgJkWWmt2dDPN9aIvkyfCz3znleBICQJKW+iORmcM54ZFlHtu1/7hJ+ooDeFGR/ftA0VF2aAfY9orpwH+2qO8ZCsSUqiodNKTvUrh5XC4jUOAXF0m0rx+v0cpmvk1Hq/I/v6NdhTFYDEWJ3bFq0Hk1dey3Nwdh0/NkhDUxcU4yPKZDttq0n4kKf7L19wfnkeclKwa5eQazdhXD8w4C2FC1vL2v65x3Ea+O1FwdbUd7wk8fFHEFcycVelAAm1aaBADFDGVSD34REtSJUux0fokDu2fhPK9vcjlzw6i2UfqAQ2XTaZsw+qRQs9qm7G08mlnlmXc5EmIxpISEKKtTiZb9JxN7Q4zLxc+aRRt4ogxcz7IBMERf1ihKd7uBXmpevsqPGBLREDqKnOeM73kyREJtbCW6BtA8EQmsgN8maUJtqazg6xbu5gqM4gJyq0CTlfySHk8rpOlI45YrJjajCrL9yN9i+yG0sckH8TKTi6rLlSZHPEMztZEq+arMfWfwnhn8HK5Q+TSXJL4/oZg9hseI0SDxSsxrVJWa8GpVA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(1800799024)(7416014)(376014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yU3JYDGVQTBHYw2E7gDVLYBR/iBu1h9ewvkYO7Fn6L4FVJERI4CY8CA23pFGC3+6hNZqBgIM0YFfN0gR3hDcHuYnPi0VG25q97kk7WW5uQNo6X8Pij+V+Isd4oJbKHit7ekLeNOiLFd8RtC/0CQEdPxruGlc8a3truse0Vzc2CvFNI08WtukX6uM1YhlsKGcjS/s5QTkAXsqn9xorSXuQXlloyY1lqVGhJWSe1prHUClIEkRafT9K72+td78f43YQJ/ogjycOhTiYWTRTHJXVe7dQAhA3XDt4j/wmPTlwlgv8M0qyHnWJpO9Qcs8KDxLsrp1JTtQ3pmC3Dn/EDX0a0ckc33ex9fyVVxJmhCeOFxWa8G+p1y812z+P/IDDuEX8mZYskXvZsvB3Vk0TQ6hCTOMzDAAFuIltO9J3+bXU142JuaGzyVBam7EagMCi6tHANj0LkgWCuUQL25sIBKUTEoWVl/DnGUNJ+XhXi/4ArHUIN7uj120x0hwuC5oa75yDJUHoMmrXU2jM/SrTu0LpPxo0k8E54aAK1yOBip7FffPL42eJ4F5UCdqAyMQ9HeLpkQp93b1mdgpdustT3DEG0QFDEHWaqNvse9I8sZ0gqfguizS82JEGw//H3JPJyLihiMGcbUP73kZ9mZwBqVY3BgJfbnbiUKE26DKQ5t+O0cqDn8DZB5CzruDkDENc4sB9BomrtSMawRK9UoSR6ifNLBVHLTRSBNwUN/CopdhAo4IfOeeeBdKgvuMjU7pa7Y0XpErjsr6wLqhFzmrNvGYW/FtknOQkw+HSPlJfStLESPxMws7tyHX8ij3JgS0WbY09C3TRdYnJK2mK9TZZy3HDHNYHB/9V/Xeeh4Uql7lOkMNhN5G60oACV2xQyCopkvZmJhEXK9hpt0Nn53hrqGKZkR6y83857iw6epTSOx94G1AsnmeNfXqBcdMTB1B0FLV8cArMvX2yFgLrUUuNSakSnLli7cAL/hyi6/J6coHQmHOXVnEGPNSF9cig7/ZneRxDuxOsE2G93dQAkxH/v2J8POW3fAkMiH7a2b0tFjfEg9HJjrmMmj9J6qLTkOGUipwBIw7ZUGbH8FkbpdvFSQ6kEV7hhthAw5e8oNyz4mTeW+7ufH04Om+ki09o5aMVVSkHf9LAFY5gAQZ39zbJZyGNyHq2+wTAULlpjh+voOyX5aKjofMIxGrkdNlozsoaTbTIP1qqzxM1ZRdcpIPZJ/Qj8ofJtZkwyNbCPijZXgZ7EhQc4avz6Cu0EEPeCXSY3hZzO6H1WkKYOfzEmFPPmfmyvZ52WAfrsa3IALMt8JxY8qzYBX5YltL3kRL2iFcKzqsbR9WOl+G5hlw0WuztnuCJvdv/VfaAoC9UUVJxmtPCh4lkEWhSdb17/Ukl8e071aYnwjucqj7qqe9xVOEgWFPcGkQdNwRVHx60wU/scTVPlrf7G+Kqt4SgboeXywghepB8bWUZdZy2RiJ6sSC96/tEC1qHRfJzXckHFFLvv9d7y2T/OOLGt7rk5CUVuKU5k9x3ZlDQAA2f0APk27g8HbHc0TF6MCkpttvAQ4aOUK1ANyKXb9lBHHrDiYqzAjmlxRS X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf5bf809-f277-4974-5096-08dca71417b2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 10:26:32.0470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +9YFkGJjo4wzMrp0T1I6bnhbBhMBtuIBNCj4Q7BVq+1zuPOmLixHY3tDIleL5PNmU7cu78r91RZKu/ltbxe8MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9886 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240718_032636_693047_697E2F83 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Per IC engineer request, we need to keep USBPHY2's clk always on, in this way, the USBPHY2 (PLL7) power can be controlled by hardware suspend signal totally. It is benefit of USB remote wakeup case which needs the resume signal be sent out as soon as possible (without software interfere). Without this, we may see usb remote wakeup issue since the host does not send resume in time. Signed-off-by: Xu Yang --- drivers/usb/phy/phy-mxs-usb.c | 36 ++++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 42fcc8ad9492..b6868cc22c1e 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -150,6 +150,16 @@ #define MXS_PHY_TX_D_CAL_MIN 79 #define MXS_PHY_TX_D_CAL_MAX 119 +/* + * At some versions, the PHY2's clock is controlled by hardware directly, + * eg, according to PHY's suspend status. In these PHYs, we only need to + * open the clock at the initialization and close it at its shutdown routine. + * It will be benefit for remote wakeup case which needs to send resume + * signal as soon as possible, and in this case, the resume signal can be sent + * out without software interfere. + */ +#define MXS_PHY_HARDWARE_CONTROL_PHY2_CLK BIT(4) + struct mxs_phy_data { unsigned int flags; }; @@ -161,12 +171,14 @@ static const struct mxs_phy_data imx23_phy_data = { static const struct mxs_phy_data imx6q_phy_data = { .flags = MXS_PHY_SENDING_SOF_TOO_FAST | MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | - MXS_PHY_NEED_IP_FIX, + MXS_PHY_NEED_IP_FIX | + MXS_PHY_HARDWARE_CONTROL_PHY2_CLK, }; static const struct mxs_phy_data imx6sl_phy_data = { .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | - MXS_PHY_NEED_IP_FIX, + MXS_PHY_NEED_IP_FIX | + MXS_PHY_HARDWARE_CONTROL_PHY2_CLK, }; static const struct mxs_phy_data vf610_phy_data = { @@ -175,7 +187,8 @@ static const struct mxs_phy_data vf610_phy_data = { }; static const struct mxs_phy_data imx6sx_phy_data = { - .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS, + .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | + MXS_PHY_HARDWARE_CONTROL_PHY2_CLK, }; static const struct mxs_phy_data imx6ul_phy_data = { @@ -206,6 +219,7 @@ struct mxs_phy { u32 tx_reg_set; u32 tx_reg_mask; struct regulator *phy_3p0; + bool hardware_control_phy2_clk; }; static inline bool is_imx6q_phy(struct mxs_phy *mxs_phy) @@ -518,12 +532,17 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend) } writel(BM_USBPHY_CTRL_CLKGATE, x->io_priv + HW_USBPHY_CTRL_SET); - clk_disable_unprepare(mxs_phy->clk); + if (!(mxs_phy->port_id == 1 && + mxs_phy->hardware_control_phy2_clk)) + clk_disable_unprepare(mxs_phy->clk); } else { mxs_phy_clock_switch_delay(); - ret = clk_prepare_enable(mxs_phy->clk); - if (ret) - return ret; + if (!(mxs_phy->port_id == 1 && + mxs_phy->hardware_control_phy2_clk)) { + ret = clk_prepare_enable(mxs_phy->clk); + if (ret) + return ret; + } writel(BM_USBPHY_CTRL_CLKGATE, x->io_priv + HW_USBPHY_CTRL_CLR); writel(0, x->io_priv + HW_USBPHY_PWD); @@ -819,6 +838,9 @@ static int mxs_phy_probe(struct platform_device *pdev) if (mxs_phy->phy_3p0) regulator_set_voltage(mxs_phy->phy_3p0, 3200000, 3200000); + if (mxs_phy->data->flags & MXS_PHY_HARDWARE_CONTROL_PHY2_CLK) + mxs_phy->hardware_control_phy2_clk = true; + platform_set_drvdata(pdev, mxs_phy); device_set_wakeup_capable(&pdev->dev, true); From patchwork Thu Jul 18 10:26:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 13736346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF8A8C3DA49 for ; Thu, 18 Jul 2024 10:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=moImxgU1cnIjGIS623G3ednFYdspClC2J+dAMdHXN6I=; b=PE9kgCETcfA8b3mGAFixwYj+j7 TY8ypQJag+ug1k4HhrKQZv3g5V/oT1Z7O22g6qWKZHuwBIHm2GZaufGrwZvTBmbqFxhe+RhDOUhZ+ fkSZ8/mrgu7gBOukBoS25EPZ/3OFrRw/GjkkcIJAb6IFbT69m0fNyFHR7MOlS8zHE6afLDJE1guSv z1AgAXsVUr3Fx5co+bGEg7xJddVm0gTfFfn9Tn3QiICd75muTwe4kusXLWCAO8fEaKR4wbwEj4v3X 24zIDdo473+dnoQC0xc0OHtJPkd7To1ZdRPFgyWp6NDtdZwuZvnR2se3s6oXNJ4bziwB34FrROISI gw/M6bqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOMP-0000000GggZ-2kcJ; Thu, 18 Jul 2024 10:27:41 +0000 Received: from mail-northeuropeazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c200::3] helo=DU2PR03CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOLT-0000000GgMV-0HCj; Thu, 18 Jul 2024 10:26:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hlNze1qr31rjXNg2Dne0NjCNEmJ0EKOAcRdqvNT8b/I25BkOxhfi1t4uLAj4eklyp4aN3NSgECM1zQBIAZprWe8EMey9IUiRkMJvcqON+tGgns/fzk/E9PfNTJNB9U1rvMpGAZgv8N1iwKSs/mqEH7zuJAKbAi0IvadwcGTofDu382nYZZFE7edlnAdLv8e0MoVjTCcswk4dv6taW8QxE06oPXWPCqgmSjyB65w6addiT/BnP39pHUdl3NlNPGPWCkpOk8hGvMXeLZu9m1lv0Dj0ZtUQqe9pGPVD/79Dx9J8U1dgvbh3Ts0Fn7ic0lysCs/x0wUlc2PFdm6sJNxnkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=moImxgU1cnIjGIS623G3ednFYdspClC2J+dAMdHXN6I=; b=yaJ/IJz8W/skEBSGKDqST49CzTIvVxG4oFAfaVrXtdns8t3YCfWxTunRA99xEqw+UzdLrZJ8LdC3IgiZDFIhnSGYXiNkkZ970vHKGpjeSAhuEXdNRnoCnRytiSLInyby/kZIsAnw61UARprI0TBhoHn3IGRN9K9n+9Uc+MCRH/uWFU9Ti5Efhzh+4D6I5FY+Kx5KR2u+9JEAju04yfadJbvf2NeTrnWGUUIvmh0tMCbEun3GGWwfcJARDwk85wH7DocQ82BPdxZ4e9JviMv+qNxc1D/WVLC53yyHdo333IKYsPNEJjBu2FdsuKkEoWKjtp14leZ48rnljhoFQXn2vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=moImxgU1cnIjGIS623G3ednFYdspClC2J+dAMdHXN6I=; b=O7sBbikkgf4KUOwyyFOppPeGo5hDuoSM8Zs6PNL9RKr/NoQCSQ4SNfh88RFgwdzTxq4j9fAguN3l7HukWd6EtKXuqxUwdmrBaQSbGxaJd0txi70g6JNPMXhjsuRQjLidbmY11Fn7QX8G/2KyQXzl3v6KZM+Tz7CCXRL8j/I5WZY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAWPR04MB9886.eurprd04.prod.outlook.com (2603:10a6:102:37f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18; Thu, 18 Jul 2024 10:26:37 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%5]) with mapi id 15.20.7784.016; Thu, 18 Jul 2024 10:26:37 +0000 From: Xu Yang To: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: [PATCH 3/6] dt-bindings: phy: mxs-usb-phy: add nxp,sim property Date: Thu, 18 Jul 2024 18:26:34 +0800 Message-Id: <20240718102637.3964232-3-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240718102637.3964232-1-xu.yang_2@nxp.com> References: <20240718102637.3964232-1-xu.yang_2@nxp.com> X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAWPR04MB9886:EE_ X-MS-Office365-Filtering-Correlation-Id: 2594818c-c110-45bc-044e-08dca7141ad3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|1800799024|7416014|376014|38350700014|921020; X-Microsoft-Antispam-Message-Info: tTB10cfERRf1BjlqjwcEh9PfxnfhV6U/JMxOZcPowLvXsxT4/NzEBIY4sbXTfLtG3U37UkXF/oM4Z2v13RIXbzIfRkYactajCWHjXZmBjTUzjKgUSwVE5u0nl2Aoe/MzDlDv5vpifmMfIfqWi8w5kW9Klw6hJtMAc41VwHvLoErd4AWa52rfxB1WIja/72Ovb26+pBffFM1yJ6VaXiXFKbHY2K1e441N20tVL3dq6f+ld+dpTTL+ZlXTNvGjRxN8+bs3Mluml5Lq1IlTeYPF1ARHkwo403ro8zScvotjwIgk11HOIxaHI0ouq1++ZydyJ730UDHrkl38+4+35J9bNRgNXA9Z11Qeuy0C17Y8hP5tMChOenx/nQjrZxK5YFaUXeQAPvmEsMq9bUW5ypYmearWJEJLoKLMKJIZgOI202ApqzLpOY7KeeY5Hk6WDSUHSwfcn+F6Gje7pwWy9uan7xim856J1+/h+JR67qdzwJSDPs22mFCettOCxDalKBshLhE3AcOeOcrtUOxzd0joT1LCj1o05K1UxZuwNy/VNd7CEsu82H2zRSmaChUGnGBiT6ug+Xir6KfKmTJhpcTbRszDQlZ5tj8gxYFHeaujxRqzUQfKTRAyqJ6+KYrZpf6Z0KxZoDCiiW9KxZI8ht8h3A4fjGbsG8io4LdMg5itPOT0z05YwiDEgMzY0sOw35Y/+I4He72gOE4bmzQpo8rZldeQkj0RWYutMR/sRX2QeDlHwMicC7faLOCygDWywS/GYRbagPhkRhddN8A7Fp/CiOkA8HGfJFza7LKQRb+rP3PExaZGdUzGRGra96qdkP42FpK+wyR+VwPkuFWkt4KBymB28ITENZ5NHWAwvJNO/I0TEp0q79MG1CUU7cY0QqioquYwrTdLe34B2dkCq52yufYWm20SrCErWvFwplmrXv5iaHMDZOFeBuaPEDjv8L0CvI3d+gThhDizHOidy13Xc2CnuJdBn2e31mzh/jEBdlLWf1EvGY/QK79rEc+Hza8f01i+h3zcoMFIvuofd1fzkbQhSnRHrI8VHbwpw/hRTINQDvX6fqQsCO12MAjO21CojbmAzQA05v/W3CMZM2yJlv6kyhoIS18+QK3WEM7R90f+9Ujg1iwXVire2KW4svWzaOOyYpEoGJ7WEx4I8dqxhBlSekEhY2CaTwlg2wxIYuFna4OCMdCEUKIkC6Ar9INYEYeoUmxKmsOoxEE+g3Mc3bpFd819OGZr2MLORi280neCGulYJ2isf1xrM7alGY4NYDTWmasrqrnCUx55abGNZc6YZKNPHaDKIOKjEOmueDfDhPyrecelQkFuS2TIqdX5e9bjXw/jLYroNKTYk1cW07e239V12f4Wkql2uypffkDQEhFMFas2w6pxA4nXvyUkutImaFpyZouEIm6aqAnHqYZ4xG8psw+24UcPybon+F0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(1800799024)(7416014)(376014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DWAf6zNsl+M7BqlHhjNFtcbH3yztPh/9mIahuLm4Aj/GMcwg6Yhe7wryje1EkioqSuclpJOnLnq9iOsz6mewCK3mPpSgH160D9jSPcd2rkEp5bAeNCNjXkpaubLoEnfAYoO375sIMLyUIk+WnUMTkXKbH09HwNkaTcT5vavJPEoJEXC8nKqq42zCWe+rUDGIXoGbd8Mo/g5qG8SB5p8CQlhs3dtfZlHUa5LcWDJJ015SvbMUYmomfyfgnLaCOHPubIvH3YtrkFyF2sNMqmVz+2ZUdi8Jrt4T1ECRqMIDvH4dTYfsdeFaABzWR79dVG0TZo6LEv23WIRtxDwvNXJCm5DQat1tge4KQ6ruxYsGWcnzxgSeCWIA1tsFIjaMDLqipvU0mySmrsXsYf+a93U2md2Gm6cGvecTg5f7y4Od0AtSnRgUqf9vs8HfsaPL2hUq3KIMy1vw2K7EUeWiV9ODrdfUHMSRxNzuhq1eqidP2MtzunU7fKJ5I3byfvaWNK4oaVAuRH/klwo0Tn9mYhooXhSE0PGm0lH7wvA5L6+qZerXhkh/O4Bzk/YV2n9FQAmA/VFn1UkchLUGxrPWoInnGYscYKPKSKGb8m7tngpw5UoDfYbVgNkNtCY7KUInS2Lz2IA4Uh9qSmdglXDkyISIDF6h/gnUjOH4SuSlYfizkUZS7+Zrn8kDd0kOeSte3bhB7buI+pUVu4SsclQOP/Idp0mEoCpVDtJxmrUuyQkhIenQvkTWnHTYKjXBUisaMrW9Sj1lKLuO6pBeZjJqdoUFLKjfuVLF40L7//PHy8iakLvqBn6yMmEp009XtL4Cu7n/OxDeOtuL3sgI2S5BvOP0/LGA4Hl2hubJRzZZHvnPmuO5RV4ettfHYZzzUfou5zeIMwNlcGXjoY5nj9ODno81Iwsrrw+cjr0OT4fV40jW/ShaxzVKbFcj4cWlnVA15JW3S5BzerUIKnCJPccF/+xmnf+lDXrVI0ja5dJakbiLsU4KlfRalEKdB4PCNgBP9F5A6ZsUlKSj10ZfBi3TyfyQ3DrkGjI310AAnFFmIZY6L091gi297sXeQ0koV7JFzwVO9vqj4V5+D6Ds3xjkUY6UToFH59csIaZ2//XJ0Q19EwmRSUakEzxu5Zrh+LQNpTeCNGbZ5E1wDoW9uFFcGtYHLgXnwkpeSsSOTfQrAa3E/+xpNka2+Ox9BFMKEED/EC5oOc+GNGpH5hjmXzR6asCTVL+UdwRpBF6dkWlZ8GFtinP+/EQXRjh1TpQEZiJ4JEs0f4EEInQPdwKhRtivJIe/L6U74Zv0Ll6Y0J9m/JieFUo9dbxqPqq5WGt5cW0WTetAj9frCXGES1ISxwSr4xneVkukLSNptrEmzWWblcGRuH1Zb1iJZNndmYMyzp3lr9ejnA8X6QgkdTa3uo4rXZPohd1ont9a3XZIhTRF7ooh08bt0xui8SaBTrcZJLZchgk72JTnmt6p65PA0jWuiiBNP7fBZAYhTIFWv+vHDOOwyDZGialVmotXPXsEFcULRy/f/yj5er3d2B6TSlmKXECkRvrYtnifI8UUgWQ/uyYKXRbDh4H7m6JBOViYtcWe3VEq X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2594818c-c110-45bc-044e-08dca7141ad3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 10:26:37.4772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: epuaBqUzRMZ3bJL371h7El9yT36/VjR19u+XJQP3vGoYkJP2r8TPnOTw4xyy2A9BzrEUJksW2I1B+2+Ragcejg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9886 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240718_032643_129347_5A188C6E X-CRM114-Status: UNSURE ( 7.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org i.MX7ULP need properly set System Integration Module(SIM) module to make usb wakeup work well. This will add a "nxp,sim" property. Signed-off-by: Xu Yang --- .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml index f4b1ca2fb562..2141f271f8f1 100644 --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml @@ -87,6 +87,12 @@ properties: maximum: 119 default: 100 + nxp,sim: + description: + The system integration module (SIM) provides system control and chip + configuration registers. + $ref: /schemas/types.yaml#/definitions/phandle + required: - compatible - reg @@ -110,6 +116,14 @@ allOf: required: - fsl,anatop + - if: + properties: + compatible: + const: fsl,imx7ulp-usbphy + then: + required: + - nxp,sim + additionalProperties: false examples: From patchwork Thu Jul 18 10:26:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 13736347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EA0AC3DA60 for ; Thu, 18 Jul 2024 10:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mcvbzRl/VE/KFD8skHTI0HGO6I/l8lVE1KIxdLYGVHw=; b=Sy45XLfPXfXfhRE98mPpryxgHt +mA2WgGb4qm0zcq7y76kIj2/XGSukj+vpCzZ9OpP4fBUueXdvxS4DpiJ5yZ6lPeFbPWhKzzoBLpPu cQkjvvtRyMJgEYOxhBEJ1XRpdmUFMA4+oyPQMgeFlE2nQ9pqjKLZ7oFOBKzPb40pY9voBkQ8jwIpW 7EkDxswegSmVsfQuXcS+o2k70xwjd8pdTL4a0cLKiArVnkP0pTjQwPu/X/vL8QTa+oyaeY7AFaMJ9 ZC4MoafDmjP4hjWS2hou8Qdrw4PCzatlzG6ORlmRxkc5XaER3iUkQKl5Z2oP1WgY5xP9cJL4DUuoQ XQ17615A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOMj-0000000Ggmt-0V0e; Thu, 18 Jul 2024 10:28:01 +0000 Received: from mail-westeuropeazlp170100000.outbound.protection.outlook.com ([2a01:111:f403:c201::] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOLZ-0000000GgOB-1tnj; Thu, 18 Jul 2024 10:26:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v+YJX/TSAvMO856EbQY6NnNsNSHd6xwypoI2+QRdfTg+JNNyry7IsWKHTIxuFAgbUYYep/HHU9116BybD3BEupUqcWUl+i5b6ISWN/BWR+ffZz9eb4Hf0UxuaGs7moHGarUB6tdou6jY43u+YpaK1RTBT3BMOnX5/K6KGYCDfx38QS2UTzLZn4PttXUKDt4W/3kvdXfH2UvwlGPo0VPZEo/oGU7gbpEU7bDHqGEx01H92LY/Hq8binUFAsJb2QqcbwqtioMfRm6lNcaNUxvjOJ/K7RQJrAqmD6tV2ypttMEYFrY/+n54LgYtUVoubM40yMwdqX8K4T8mb2UOOpfbJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mcvbzRl/VE/KFD8skHTI0HGO6I/l8lVE1KIxdLYGVHw=; b=cI5Ymd0sHpF92YQbjoc5lbyDz6Holrd6i/ltEkrhOTUmvlrh1RXjku30KfffLeEcDfA5wLcPK1CpfHwkmIx6L6d6H+bW0AsaJ15ilrdyMAw1pIj38xJYfdilIj89aqa+Xahhco71Jm4g7W5S9kRS25SOjFPSNW9qcF0NW6//gmG4h1uKxYr4q8SHTMr0xGf6pFDTmiHOBZUjwEjgQwZI3Lgb0z43kd9x5p2Ek47n+jW2ZHqaFQp3Mh+A/r75jwtn9SFjnMM6EJL3mB51zQwm5+zDlrzbV1P6IguQ1LlpkNnZyQ5B9HLS4RP8QLiGAYLOVb4X5oK0bXlCwZhJYH1KwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mcvbzRl/VE/KFD8skHTI0HGO6I/l8lVE1KIxdLYGVHw=; b=NBVbMaic3R8hqekOtWhSjwc8fHB3neAT7rV57MXETHqzVNfA0Dc4UmWZX4j0HGcjfi/Tb9+Y8YVzlxCl/F7HXjENkpFFe//OgiUtzlErEgNW2ucr8C3xAbc4bZ7AUsd2oC4aIjIbAt0EU8y1BSPWZYB53PRGu25a+m13DD8u6h8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAWPR04MB9886.eurprd04.prod.outlook.com (2603:10a6:102:37f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18; Thu, 18 Jul 2024 10:26:43 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%5]) with mapi id 15.20.7784.016; Thu, 18 Jul 2024 10:26:43 +0000 From: Xu Yang To: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: [PATCH 4/6] usb: phy: mxs: add wakeup enable for imx7ulp Date: Thu, 18 Jul 2024 18:26:35 +0800 Message-Id: <20240718102637.3964232-4-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240718102637.3964232-1-xu.yang_2@nxp.com> References: <20240718102637.3964232-1-xu.yang_2@nxp.com> X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAWPR04MB9886:EE_ X-MS-Office365-Filtering-Correlation-Id: 97484c2c-f7d1-4c1d-fe79-08dca7141e1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|1800799024|7416014|376014|38350700014|921020; X-Microsoft-Antispam-Message-Info: Judc1rqP9Xh/qYBENu2gsJuVB3Tcaq9UNbpZ/9obYCQVX15t5XZC4lIzaARjexL5jaTSsCCgA5HKN89m5wfNE+55Vy937y0OGkd6at9Xs6o6x2g3XsiXQEhQCik2Y7e2f+PT/S8cBLkhIueH/zUXGkrP5miGp04bpZZDdnqJmsG6Aa17Ts5HbNyUvlI9cBvjCNNgZxzAsvor5E7MCoT4CulslBwpVfa3BSnQDY3Exv1VH/3XjwmHu62SH0LNn793R6eGUrvuJc746Y0lcOtgN9522zlp7lTszeaUmXaSqU/rtvruKhcPMqpC/mHAG8NOky4z42RxtBbrdB+QafzWARuoeiq4F3MbXNTkcSfTNK9NXVf+YRmIMks2R2yWUsIIqsEIWiJPEqrAiJd30tNdEAD23tK23fQQlUFT03Z6gfUHVS7xyyGO53jfOdw8m4+7zsFNueS8/bSQF/ekfZvSI5RCod5nrJVvK46ZMaUnWPiIGP5QUsiZrtS5LI6IMG93vkfyKvuCF2B1HeXxlQRRFQIEwHZSeKtzvzOYK1Ak6O4ZGo526HwUdO8dAtgfuc469EsmrxUB6EIvUjmW0M0iR3y58GuWkotqHNM9u9rOpJKSs4TXu2XHx29fhlNXe4WRdqGQf+ybXwB/7LGMBRfsuVo8lMkZQHn7eFiyQfWbfGyWl/tDZ34rGKWOQFuT341kYFlfbokPkcCXXPkcts4YPRPj7kmZt/GSv7d+R8Ek8QAHFew3D7xoxxIapzJpoLQWvvYMCxAMEZakTxHh32BetSlp4iUOyQp3E1olwYldpj+X7lJHhsnxIc3gY/JSiNBgu58hGg8wqxQRVfYDLhRZmUwk981v8kYUV1GLUk/6tszFtJqo8k+gnxpVPZXm8tshGNmAxCoLV1XLgDjk/cdPrlN1LEGYaWxEzCpaCJuRoA4S0o0Nk2qiCRuBDyFNABNBATxwmkrWupPv1FkT5yoZWMKusVokHj541v7P5ovcCUC7bThg2+acajGmteRFmhOxUZ5yVMhpePJrNzT1ZuGhp+jQudhtGaCCMvdtkbI9+KL+0rlCN7RqGXB/rMXN82y3u6Q715bN7JBOLZPsbOBL3bldumA/CcYiXxvh0dCDvcVFY3mYT9w0moeK1xq7J3vnL5BkL6VCLc4H8j9a4rOaGZy62HqW9N98e4EkQcYmOUjOVu0qFLPzUbdIqF09TFGjNGYMiOxNPm7aIaTOy8rAZ/aiostKoeI7/YnRlGvUrntjVdNx5HssINF99J2h14YPOc6FGewrfqsGsgW30GGZVObPBdTNBelgrH4mQa09DN325ZF8Ii17CbNm2Z1eyEk+dFvegnM1KD5OpzScSpPQrrnAAMWIjUNMKdc5E+yzNxju38MTFyXyRFr2H1ZfrGMBBELBD6DVBqjJwYIJocSEmMNEjLLX8a38MB9Vy6tAflo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(1800799024)(7416014)(376014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mZpvqDIwWFi+HUF/BNFBfXyTUOzOMIO8lMxzeQCkzAqnDgDGHQ/ZC6kkW19hZ5t4W21oiAWiwKjz63fiCjb0nc94P3t3YUR1hPr1ojvlOPond+Z11+C4vd/k06JGZfV+5RWmvAkvyU9SPmlES8PDIz7zmed2oPTjyFmWYxn86MBM5Qa/B8026VlpfVA9jT8JwTBxIE9y4oT6zqX085Abxx2jY6/Gmj56AE6wcFn9Ub97rTx+yPQoKsprVYygiN21ZGQnpdWrm5LrPcdeC4fDo5dvUN/hKRYZWIrDD7b/SvVrvxNG7Jp+AqDSnBUweUYJQzAEEskPoIqa2huTBW4kfUq89ObhiYk/P9baXfG53uxaGpMWHTBPd6FAe8DVsgds+JCLsVm8ztjK1bc6IQJk5ypx2vJHnVGbahixwqb1LSjWvUbLyHnNOpwNDNdTexvG1XvqgU9TpTzbwixQCv99qhyJgyVvwgGSPN10tpLtR0TCGhR0CrR+wOZvYxAw2dqfZ2UtEoVYR8rIRRovTKwgCAdXQJF5ZXlHTbJSdM3xv53DcnEjNoHs8pi/uyV6HrXVti++6cK5AqoPv4k8fsDUCvL236IsSSVqkW68e9Ac9ottJh2Sa/U1iv3pn7U2AZyLBSkeW6RNf6N39NPmjSummOfHzY3Wa2lM262NZw9EHuVA5K7IRkWE2FkanQn0RH9Z7SFrDI575HK9x+GMzaUghPOZY9cmTQ6764dnep8g6sTeQ2qo7uaR/bK2nAjt0O6DB7221PAEqtjXUOULVupZYzj7BP4VS3PW12XgiQYAQTkV3z2FuoQAFbJyQWOSJ3sXxdIQreQE+hg50RTY0/JOoqzFofHXDX8Zhv6HA0ovGFMjd6ZRVVdEEXZZTix+1KphIFXDgsHUA6j1f4ezRyAx9S0rRzFk8z+oToA7EjczCL63JwpurkqxakCUgbSdqunwGREpMMZ8CeRQPGp3zqgQ+/uX/qhTFTzb7R2XWUJbVJ9Tin4FhKxNxhzlwaKorD5Y2W2hYwBeH4S9Gw/KrK1yO4PaJXZalpH5eWEWNZlsK8LViqJwHj92iV75N2YBb2a/F6jhBl8GWAoTEFt9/u5ed0RJN5op1UnovFOJJpn8emJH1qDhRF4F+zFzFSm+iqhd7BguJs87AsaHcgUgt6nP/Y8r4LKb2tWtkxKjlcBjp5JGXAiyuy0KDYYChJPznBkpCLHVz0wrOup/cMCNkIR/l8JcLhPTlSdfsnhL6WR3V/FGpMr4KcemQPX5FSc88SI/RaFHHVgkTm7PGv49vs1mAVl2aaHdU5tL+tVsFYgbt4duIL1uOQiyWl3a0YLBrprijCkAogxa1IgWQrJ4Cjzr6m24vQe9idK6XjOZECnDemPSFzUPliYtpmWwx2quzsBPqyrTYQehJNwomyBWcEbHF9CIIi3iGofO+YklrC8ZJ5LMB711JaruW3/osNenschEdTuPhLVmTLF08Z+nPxCOQbqZmb0jQC1wou4pqdlJV54h0PixuDvkocYffNbt9tpMxkn1ebJosD+onvFGPaXuVQRAcxknYvJJnDfMRLZarxkQYPklU92gNtkrUBFJ+ucB X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97484c2c-f7d1-4c1d-fe79-08dca7141e1d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 10:26:42.9183 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RSEHXxm4s79VvYqMP5pJ5WFZrwUYBRuw5DYiwLWSNXiM+t+Sv478A5u331UpKBZK4MiRNbQhF/PycfSaCzFNGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9886 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240718_032649_520797_11BDCC5C X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This wakeup setting can enable USB wakeup function even the controller's power is lost, and both A7 and M4 are in VLLS mode. Signed-off-by: Xu Yang --- drivers/usb/phy/phy-mxs-usb.c | 41 +++++++++++++++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index b6868cc22c1e..627733a982d1 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -118,6 +118,11 @@ #define BM_ANADIG_USB2_MISC_RX_VPIN_FS BIT(29) #define BM_ANADIG_USB2_MISC_RX_VMIN_FS BIT(28) +/* System Integration Module (SIM) Registers */ +#define SIM_GPR1 0x30 + +#define USB_PHY_VLLS_WAKEUP_EN BIT(0) + #define to_mxs_phy(p) container_of((p), struct mxs_phy, phy) /* Do disconnection between PHY and controller without vbus */ @@ -215,6 +220,7 @@ struct mxs_phy { struct clk *clk; const struct mxs_phy_data *data; struct regmap *regmap_anatop; + struct regmap *regmap_sim; int port_id; u32 tx_reg_set; u32 tx_reg_mask; @@ -772,6 +778,17 @@ static int mxs_phy_probe(struct platform_device *pdev) } } + /* Currently, only imx7ulp has SIM module */ + if (of_get_property(np, "nxp,sim", NULL)) { + mxs_phy->regmap_sim = syscon_regmap_lookup_by_phandle + (np, "nxp,sim"); + if (IS_ERR(mxs_phy->regmap_sim)) { + dev_dbg(&pdev->dev, + "failed to find regmap for sim\n"); + return PTR_ERR(mxs_phy->regmap_sim); + } + } + /* Precompute which bits of the TX register are to be updated, if any */ if (!of_property_read_u32(np, "fsl,tx-cal-45-dn-ohms", &val) && val >= MXS_PHY_TX_CAL45_MIN && val <= MXS_PHY_TX_CAL45_MAX) { @@ -856,6 +873,22 @@ static void mxs_phy_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP +static void mxs_phy_wakeup_enable(struct mxs_phy *mxs_phy, bool on) +{ + u32 mask = USB_PHY_VLLS_WAKEUP_EN; + + /* If the SoCs don't have SIM, quit */ + if (!mxs_phy->regmap_sim) + return; + + if (on) { + regmap_update_bits(mxs_phy->regmap_sim, SIM_GPR1, mask, mask); + udelay(500); + } else { + regmap_update_bits(mxs_phy->regmap_sim, SIM_GPR1, mask, 0); + } +} + static void mxs_phy_enable_ldo_in_suspend(struct mxs_phy *mxs_phy, bool on) { unsigned int reg = on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR; @@ -876,8 +909,10 @@ static int mxs_phy_system_suspend(struct device *dev) { struct mxs_phy *mxs_phy = dev_get_drvdata(dev); - if (device_may_wakeup(dev)) + if (device_may_wakeup(dev)) { mxs_phy_enable_ldo_in_suspend(mxs_phy, true); + mxs_phy_wakeup_enable(mxs_phy, true); + } return 0; } @@ -886,8 +921,10 @@ static int mxs_phy_system_resume(struct device *dev) { struct mxs_phy *mxs_phy = dev_get_drvdata(dev); - if (device_may_wakeup(dev)) + if (device_may_wakeup(dev)) { mxs_phy_enable_ldo_in_suspend(mxs_phy, false); + mxs_phy_wakeup_enable(mxs_phy, false); + } return 0; } From patchwork Thu Jul 18 10:26:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 13736348 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A8A5C3DA60 for ; Thu, 18 Jul 2024 10:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eDLChDrm2VhOs40dhdZbGqXup///V8YEJRleLaNpxXc=; b=bFhArkXl0HgUATiad7J2I09z9x tyq/vHvbHWoG70+pQvZyOQwURiYKmBBQWtCCtDnjRZPdOUOH7iYrdX9eegG4KsP3yC7GtGXdr8vnu 6oqTP4Vm0Ac+7Uk+4sIfG7+KqLKYEQe6hfdcuoZOmDro1c2k4MOlkL6/ecVmJ1fChzBJ+Cv6YXPVd zESDbLKXWXM8m2uuXwoaLzXqIlYzrIDvzzumxl3ySjrm7jnOjS+eNiLNZIImxI0Lj1HT8bgWQtfaz J3oGSpGgvAcgDMukg0VIYNW+1UJQSR7P/3hYNdXIdTKZXrw5wcl1MEQ9H6i26r8snvVCzX9SFp6CU W4ny5hyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUON5-0000000GgwR-1lDE; Thu, 18 Jul 2024 10:28:23 +0000 Received: from mail-westeuropeazlp170100000.outbound.protection.outlook.com ([2a01:111:f403:c201::] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOLb-0000000GgOB-0XS9; Thu, 18 Jul 2024 10:26:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vo/ZDieAHbxmqAtE7d6HQ5adlGaTVEN09KXqvsTDb2bFiFANOqq5K6vzGPeFbWQQKn1K7QdD5Q0WkhZv7OZGZkJgC1uHKWTLS3+E1UIltzujmVXw+2uoo3v8FriPcpUZDMk4Flvzwlh/uI6fVkz7IcAax4fYIPJZU4QuZJwtYk9ap54BpXkAvHRHDzK0vGi/wWSUD7fNqeRfWHsZwDuLm2LCDh2ZnSefHKTQskTzLUtbtTijZl9sxMN4Dl9O8T3rR5CWFNC9i6PpJaBxc9rxxXrj3nGYOY6z4NoztROkd1keDOUrdTjwbqoVSBLY1A/WLXhCfpwyIavxDu4zN9iODA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eDLChDrm2VhOs40dhdZbGqXup///V8YEJRleLaNpxXc=; b=vcp+25+3+Bw+NMj52y9tsChOSKHsCW4mLG4k4X0zjvv0o+Uc1qWv7rKEUEnjqnAdpKSGg3dUvbb0sHnUaBwaQWkALQZxhBTDawi6S/sQgUWeyFK4k2KHn/IzALaKtQem8fyunsCqFe7+eAN6o4YsfPN4lOqlyVbWgwwwLpkGTj73vbnYtnse+EUQbaNAbsLJiY8UZ2MXDeddXZdC4iybPF7AXm1z46oR9nAAT+NnjcqUK7SDM/7bcnM8OKlM5LeRRheE7hGjq27yqmGFc37yEz1lEFwlHKUuAGQBknZUuhJDrn7wu17PCIe8OLSHqM+DbRFx8ulTTVjDN9GvmbImkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eDLChDrm2VhOs40dhdZbGqXup///V8YEJRleLaNpxXc=; b=oucl3LYo9mF556lJofoZIhOaGym3k2oANzLJAI6MpPZBQyvbAw1VvkRNxrm1vvYQyWERuhEjYwViF6EYxns0DbKV60XLB0U/MerVIeVT7M1VhYliSAyGC8IfXEu1CKC0VDIALK/7Xgrkqj3J8bEX/z4gYEvuHXEHgvy8hqe7Vms= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAWPR04MB9886.eurprd04.prod.outlook.com (2603:10a6:102:37f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18; Thu, 18 Jul 2024 10:26:48 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%5]) with mapi id 15.20.7784.016; Thu, 18 Jul 2024 10:26:48 +0000 From: Xu Yang To: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: [PATCH 5/6] usb: phy: mxs: enable weak 1p1 regulator for imx6ul during suspend Date: Thu, 18 Jul 2024 18:26:36 +0800 Message-Id: <20240718102637.3964232-5-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240718102637.3964232-1-xu.yang_2@nxp.com> References: <20240718102637.3964232-1-xu.yang_2@nxp.com> X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAWPR04MB9886:EE_ X-MS-Office365-Filtering-Correlation-Id: 3462f68c-acc9-4fcf-e83c-08dca71421a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|1800799024|7416014|376014|38350700014|921020; X-Microsoft-Antispam-Message-Info: BLvSONq79Unc1LulgBbGAg3VJN8y1+6FGjyJvJJlEs6lzi2c2MipvBsgAQ/mtu5mZLHtWnDAJmTnjkQp9aDzTXs3fovn2yPSpAGjSzTmV3kuHUMY+jpheOZ1geAyzwME25oHJ1nYtjYu7vHOhPpCrVPrACLgWaVyLreA4Gm/4dY3sCySnSstU9CCI/aSLKjPIclj8JTnxrF9jLWrU58uVD4jgS9R5gEqG+xXAv6SBB0f7UAE61J8gjAU0fbojzIhbh/msBbZjzSagO71+rqmuhJC8Xb6CtHBP9uyvZ3LOkKtuaY5jbaYtpXwKVbEQ/1Y8mnx9+uBSWa2YdRm6PFiXmlLtaVZO7FTNxKKF8rgWlu7HqN1ewf/nSulQ6romXZ/rXNOABPkM3/YKmXGTknWka9sdRBK0bayvwQH7eaj015cnKnQ3NBNOFNEy1rGumu0V/5xejC+f6hrLrrvINpAAp6M+mByz9r4dtEQY8F2WjExfd8PlVJLygE0ChBN7p6wrck+MLXC2bkdSwsHp357zr+so2kxoJ++oKyl5hn3NxeWUP2zm0k+vTJsrMFo91ORKPSpNoInVMBO+g3cmWzYQpzOEzr3LNb6yVRBp89IyIJap9JQhp6bOJD1xMJd57B8h2IR1FX7gGWw98K9avPerayw0hy2PNJgJ0kORca3+wPpz1hYEFVnzC9VgJCJ7bbhlSCg4VdPICxQVzx0nNtT32Q5r/UwsdV3JmCVBQnoHZaGs7wt1tXES8syhSm3R4qek1smsy1ARZuyWVDoNradO3wjkeYlEmKCPvWTWuroESAt7YezJzXyWVSpCnqSZ4WT0vcM7w2KOzLmdPBK0vQ45jQBOfj9gYE8GMCx2AzR8OJNhWXpc3hZ/KLL6miKIpLAzjnP0/h4al02QHA1Lw8DCeRCxL80mVAgBKtLHoCHPLAhAbCs80UVTc1wseH/IHBFIO34P010vxjngcyYWMmTFvccMUEg/xUgEs0zNA2q98EnKXO/mJW3Tpi7+DUHk49rEkXd1xEDsOM5M4v7zA/LxPHZcJwdl6L2oOnQOT9wPWq4AN/MVm3yd+aUUt3mvDg0ZkmMl7hsqHqipB87gstTbDWsQSmYP9BghiL8PwM8kbk+ekBlTBuDrjrkoO6ewD81JDiGvVkI1FFeGKso4+b+IHjmmve95c3DB3LOhVKySoTPZcea/g+HHor8e6WEjLTRn8dMA9UerST08grMHC75hJsZOOuna/yFVMi1dZVByeM5h4/mMyWAbwrMa3JSWOo6EefVal36v2ZdGfdWB54GPD+xLkHPiJIOOZZx+tyGo357cFzx/JLQ4OkX6iAsOD1nIdVZ5lJ5hPccAiCq52T39SpN0D2w40+ePcqYyeIZt3/54s7r95YtTaKAbrBn+k0WfG+Fm5gVdNVXPeb4Ya1cjLFyck+aD4I/Xwl0CRD9Du0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(1800799024)(7416014)(376014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1KiAKCTKZv9EtenxH2fzd1as/x3oHCb+D994rDUAlWnvCkuENkX023gHECjGggppsePrvlU1SoxJ2iDDOyxclvufehNdpifJCXh1VkN+KA1gndN6xBZBQ1Ba9Ef29VSG/gh04NEFWW7kE144L35mBfZoQ0dToBatKisPHnQGqXuQ2MHx/TBVNSzeGq4jMoF2ju8Mtvqd/KJ5OiTOEAXSCvbmuJAueFIDcaPJUqW04wW47XC3mYWQFYs22nNJTQvzRRnrOhwSs5K7tK5fvzHuUSwakUqNiXVOdXhHhFScdXPJQELKTkfFQ/0DEjf8XPUNP6q+b95Ml0bo/gABr3Bj5fIvls1WLErvblePM69pA0G6DDmx++8acqIa9JfEythKUzppFDxu2Weg4HHwJKNKrKfqe1231f/NEnZZ7boVmoSqt16wE8xgPQmDdr5MOtJvm/FCoJ7d9xkECjPDeSTsRYNY6QCX4+yGz8NbMbrOL8ay0BN4bP8QJPabrJzk/LdXC2XSM9KL3L9YBgv+XuTHayhRmwJEAo0uGFi1QmFOxh4KNJxh74apZ8QpzJiFvw/xYN9AnUPfPUcy/ilfREj0yqkC+VwgRqBwxxK20qB8PX9qx4Qwq63qiYLyZAR01k7wwTsMluKCtZLHHubGZcvs2Ls7APPdZE2Q1vXLAjkJccMwZ75hwHYjpB0X0Xkxu1S9hvA27AiPjrW81x6slYxieKLA2xG4zjFyqNkXu3d1rC960cW6OB+cklgVASdAYDot7hMjNn3S6e5KpptWf2vLRgFsmDLte4X6kGiDZmjSB61Ha6FFv+fulua5vVvjOkKrVyR+h1na2mQZlMnnHAZUXd6Key43Ps7Rgj/iGsA5H15a0GGiPZ0QmRW3KF+mRc8eNcRtkPdi7bFwkFD0vj4x78jKUoKXl7KwWJa2cUecXBGSwlSH873CZdZU1ll9fuMbtfpQ4Y6chBVC/pZjnaB1EOqUuHNxq4WtnzlU8uyEONr5lwvKiWJ6hUcvS2u/uOb9X/dc8t0OdRl1n4Hy6ELJZBy9Oui8Ik6autkXnx0LeyfzLL9x8c8GvcDrZe2Dordaw7Qb3HkEMQyZoIx6ocKxoZz4jgD2evjGDWepb26rMbtlzIEEM60ocKmzNRePKLoi4KATDote0wo3rTaCI3j6nmPpacA5kpPYyKXkAtAbyKvQHCUuD+foHV9zVJ+uEoS/uka6j9ZhJeJcuoefvxXPNXK9CAhCdU2o/0odU8SlpqBHSYcRWgfnkIpkx/x/sWjoT2gUt0ncPU0RhtbJ3clkdTQiR51VwexpMq2Ikqe99LrSrvSE7FamVmxq6tYRzVjYaSgyv3hvPo3FwxJvwSrlcvbQhq1/98SYSTlGxsvOa8vUuPLU17oDFWVUcRbGVpmAXyG1AY1EYH5xIUNvCxW2KDH8iSoNSIxOtr8mQDR07A6rIE4fiWVD9KiTO/agf8pI0Bq3sJLe6ezyh3HiQ1rn4s8c1749gCAdhr0I7URxc0XuMphnPfNW107F1SRGWRVC4AU1zyouceXKvJIu8RU9Yn0nt4Xjbr2aefp4chkrKXPD1UaYUBliCwjZrm8vkevR X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3462f68c-acc9-4fcf-e83c-08dca71421a3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 10:26:48.6685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hF3oxExlT+zNs+qw0OvqKZoLGRbVWElNrOXhz/cUvk+xaQrc8FK+afiJeN5n8+7WlRX7vfBSFgS4PMdnmDT9vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9886 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240718_032653_853754_F59E36CB X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For imx6ul PHY, when the system enters suspend, its 1p1 is off by default, that may cause the PHY get inaccurate USB DP/DM value. If the USB wakeup is enabled at this time, the unexpected wakeup may occur when the system enters suspend. In this patch, when the vbus is there, we enable weak 1p1 during the PHY suspend API, in that case, the USB DP/DM will be accurate for USB PHY, then unexpected usb wakeup will not be occurred, especially for the USB charger is connected scenario. The user needs to enable PHY wakeup for USB wakeup function using below setting. echo enabled > /sys/devices/platform/soc/2000000.aips-bus/20c9000.usbphy /power/wakeup Signed-off-by: Xu Yang --- drivers/usb/phy/phy-mxs-usb.c | 32 ++++++++++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 627733a982d1..dcd032678814 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -71,6 +71,9 @@ #define BM_USBPHY_PLL_EN_USB_CLKS BIT(6) /* Anatop Registers */ +#define ANADIG_REG_1P1_SET 0x114 +#define ANADIG_REG_1P1_CLR 0x118 + #define ANADIG_ANA_MISC0 0x150 #define ANADIG_ANA_MISC0_SET 0x154 #define ANADIG_ANA_MISC0_CLR 0x158 @@ -123,6 +126,9 @@ #define USB_PHY_VLLS_WAKEUP_EN BIT(0) +#define BM_ANADIG_REG_1P1_ENABLE_WEAK_LINREG BIT(18) +#define BM_ANADIG_REG_1P1_TRACK_VDD_SOC_CAP BIT(19) + #define to_mxs_phy(p) container_of((p), struct mxs_phy, phy) /* Do disconnection between PHY and controller without vbus */ @@ -197,7 +203,8 @@ static const struct mxs_phy_data imx6sx_phy_data = { }; static const struct mxs_phy_data imx6ul_phy_data = { - .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS, + .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | + MXS_PHY_HARDWARE_CONTROL_PHY2_CLK, }; static const struct mxs_phy_data imx7ulp_phy_data = { @@ -243,6 +250,11 @@ static inline bool is_imx7ulp_phy(struct mxs_phy *mxs_phy) return mxs_phy->data == &imx7ulp_phy_data; } +static inline bool is_imx6ul_phy(struct mxs_phy *mxs_phy) +{ + return mxs_phy->data == &imx6ul_phy_data; +} + /* * PHY needs some 32K cycles to switch from 32K clock to * bus (such as AHB/AXI, etc) clock. @@ -891,18 +903,30 @@ static void mxs_phy_wakeup_enable(struct mxs_phy *mxs_phy, bool on) static void mxs_phy_enable_ldo_in_suspend(struct mxs_phy *mxs_phy, bool on) { - unsigned int reg = on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR; + unsigned int reg; + u32 value; /* If the SoCs don't have anatop, quit */ if (!mxs_phy->regmap_anatop) return; - if (is_imx6q_phy(mxs_phy)) + if (is_imx6q_phy(mxs_phy)) { + reg = on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR; regmap_write(mxs_phy->regmap_anatop, reg, BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG); - else if (is_imx6sl_phy(mxs_phy)) + } else if (is_imx6sl_phy(mxs_phy)) { + reg = on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR; regmap_write(mxs_phy->regmap_anatop, reg, BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG_SL); + } else if (is_imx6ul_phy(mxs_phy)) { + reg = on ? ANADIG_REG_1P1_SET : ANADIG_REG_1P1_CLR; + value = BM_ANADIG_REG_1P1_ENABLE_WEAK_LINREG | + BM_ANADIG_REG_1P1_TRACK_VDD_SOC_CAP; + if (mxs_phy_get_vbus_status(mxs_phy) && on) + regmap_write(mxs_phy->regmap_anatop, reg, value); + else if (!on) + regmap_write(mxs_phy->regmap_anatop, reg, value); + } } static int mxs_phy_system_suspend(struct device *dev) From patchwork Thu Jul 18 10:26:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 13736349 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F246AC3DA49 for ; Thu, 18 Jul 2024 10:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T8iiBZqWWOCgkBeIfi/qDwAyWhISq6BAWOpP+6iS0cI=; b=Ubhuh+G/mD3uahhWG8PA13roG+ YPnGitj6bIEcp5IcPuMGyHbgGq1zXkVc30HEmm1ogFgiWALwlCrBUwu2N+p0HI7aUZGgl2VCPlcss axBVMs0aBRHQ6SaJfUoRqEK2rDQWCqc/tapp8fc9GbQtV6ifSnZK/PcrttdyydRpiKSCT2gQsvcRD I3HGeKjq5ItokywqkNJ5DTbI1rDjJUy0gWINiS6XE67wh0LF+ZQxEqv04JtMe6OMYQXzDqTE00Z50 hvRwLU8sKSl94E+wnAZTsSUPH+BlYrjTbSZFdGRs9Xm4aXMqdgvm5UDcZB9xkCivLhAVZJa1eqTw9 I62ASydg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUONO-0000000Gh1x-10UY; Thu, 18 Jul 2024 10:28:42 +0000 Received: from mail-westeuropeazlp170100000.outbound.protection.outlook.com ([2a01:111:f403:c201::] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUOLk-0000000GgOB-0R2U; Thu, 18 Jul 2024 10:27:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FJm/qd78oblXtB0IVY9P2nl1gmqTZd7cnepnru4yhVFuKeYplh9wHjQ3ZE849C06hTKVsXlGIYHLxLmFIXpVeVGFYzCiswUlPkNITdDB/4WDkl4oaQYEpnmm8j2fpKzTrThg/VTUK77ALibe0PD7KAb1uOJZATYjbKz5ekogn3ul+bpIwea52VkZt69yYFoicpYmw2i3AVrh8ISonLRCGMk+itAV3ZsHbWl3J1FA44jNpX4dKlrSqUUdMVw1yG6iZKhUcG1PfG/ZFm8w71GgTRhUE899v7fWlLQLLaeh0bd1Tu35AGFIksZ3QIIyvp1RPBAM76HEd7/3HEycK1QV8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T8iiBZqWWOCgkBeIfi/qDwAyWhISq6BAWOpP+6iS0cI=; b=vdaJIySrjqmRLjjZ7qQY2kAB/sfv6qXvP+bBqE7Wnr1kulMEQMit2ZPJPpI7YG00I08ydSNoTlesMnQPXVIhlKFLs9rLPU4zBO7zfq9kt/cwDXNRwC2E9aSvHPosCSR7o+GxgAKfKKJQuJk+XpIbn8BrO9kgZLx9GoqIiIqvuRva/jGdNZUbwflQ/5KMbgVCaZ1uftvKvw4/vuPzNqanQTu4GDD/KlnkWOdxZHGox4vYihffxvLefJ5kaOd7RCOafL6y2dXTCxBCXLiskP1BFtxCS6CEO0ISWYc71eOGvZPKXWrFLed3WV8dNjo/9SIJuUrovV4e43K+k1NjgE+XAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T8iiBZqWWOCgkBeIfi/qDwAyWhISq6BAWOpP+6iS0cI=; b=Gi9hXxRv0uzyaXcUtJMOFrGDAkhriiD3QM/3v+NpzYfpNHX+kMzSp45XOsSTOj1FW6FwY3IOcxJ0SSVGpYQsDCrvMh5GSobeMKFMR9V+6BoE6Rqjy9PNbYH5A5T0bv1AijVbQhJgSbF80VSWKha3elq7T8yI0ywG5zJDMQqRmPk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAWPR04MB9886.eurprd04.prod.outlook.com (2603:10a6:102:37f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18; Thu, 18 Jul 2024 10:26:54 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%5]) with mapi id 15.20.7784.016; Thu, 18 Jul 2024 10:26:54 +0000 From: Xu Yang To: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: [PATCH 6/6] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1 Date: Thu, 18 Jul 2024 18:26:37 +0800 Message-Id: <20240718102637.3964232-6-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240718102637.3964232-1-xu.yang_2@nxp.com> References: <20240718102637.3964232-1-xu.yang_2@nxp.com> X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAWPR04MB9886:EE_ X-MS-Office365-Filtering-Correlation-Id: a8b60586-7649-456e-a99d-08dca71424f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|1800799024|7416014|376014|38350700014|921020; X-Microsoft-Antispam-Message-Info: SlM4CJRpU4LQPM8T3/ywtDPETXdcT8HLBeqYlSN487jCeEKsWEwkvGK6r52SfFaieD8RM6iLccsZz53Z31b6JALd7AbGnZ2vOU7hQNeoyiIVt4aW4wgVKk4Ql5wJRmW9aW3FOBHphuiikd7Q4kZQQBb6OfPdXCav2we09yJUwHt25FfbAKoto+9l8H1NrzhG8ptopyRdK/kT2bWUTmOjirwmEzEEZskhLwpQF0RdTjKozKlrB/ww1aRVRWRfDL0u0S154/lgcL9nUqZ1CEPJyHOTkQKnYd+EKuS759xmv5g7FRQQE3tTpSz7iMfecuQZeZ5mUhsHtZ3kcUsD5IGJbHj/J5OQw4oRVmoDrnkxRtXpw23SVABb9bVQ+jvHwgFWSbOLtqoiHDHr7W9lKbg363xSkgXGcu6zjBRNsbXxa+6jdP4IatpjA6xkRnK5CBmVER/4qo1iuYPyfTqQg2ywY1ncpJi67hGX5ATtP5Wxf1k/TrKEFhkd+Xd+wBXIVw3XhnMKqbDugaMjXqFTrBHmMhWG8CdU+/4Q7WbxNSg2v1E92aSYt+rvrbjmhetQ2+ZmcXDGzO2WuZYuJo0wRpMRg08N5uDBwhtxZbnFYmHQXmHWPeAr+bpmtXZGoTTJZJH9Uf6t4qHsT103or36lXoNcldf956CH2y/Y+FR1diGhMUdYDPmKO7ouHT8HWmbAQl0sJLTTSWRderSVhp5OqN7GS8ILCaye8cawugd7ti6H47bu896zXoNa3Udy2I7Xb9RnxVBlB5qURpYHS0pkhoa2XynXRHd1e3hrvoDUQcJrHB2l5g/21JG5IxONeUXYXLFXzpnctk4SifZpxX70hsdrHR2w1g6q5tiKzPPvU+VI0NHgpQ4mfvp87VbDTUhMqIDTur4X2SYviqXBOb4gtFtzAd/mnC4S2d16MwYd5gCinaOzxs3xVnAu9tv7uuF8KigrMOmG+BdoK1wn4fXU4D77Zl1mIl8Mh827ghEWbHZoxNNjDp9tkydmy7C82sxjLJfK/s/DxUvgFehJjs0PRzcgx+Y9dbF+JYADiKP49m/QMM7lKHQOQKI+jLs1BP0Kv7g9NnZ/epEAUSmvEg20brfwV4WZmXiO1C2Fuq6HI6YLS+YkLksX47x2XvTQloyPVIxM9MjP0g7FH9XnB3G1Ptd0JlE6znBRqKh8U4mnq5PhiN5kE+wdF9WRWt6uqfXmke80UOxwIqdQ+uxj4b3rvM9KHMRtIfm4pSjuVhzZhXxhNbed6mdIfNPBJIChUl15TLrxiKvinyMANSJmuRHQuB94I6xfcYl0+wd5ND/7FFzYPW8lHkVWfCnONnYYVGSoRHGogrNQdFTJi1UahLJC3ly/He6802nmgyokUHRbqnAzYL54FOx9IXdFFN5QJxxZ47f5aARyr4iDh1RB0V8b+SS3nD8EpcoAl/fBNDoetUYlCk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(1800799024)(7416014)(376014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5JUe401T+4P3O9s+9eKUwLz6RfORbyGwYGjCT/EMJb2ncUx88wuTfFBUqpe9PrS2Fvc3WFnOeYXiaj1pQQO2h5b4C5aiyC8sS/9Jmzc8UalFbB4+Pfl9ou5p8GPSTBGJwapAMnrPpoUQaWZxm08XFcYfarEtvQGUeXnYnXxMYyM7o9oY5gvU2KtcniP5t9nrqQlKgyvgcAue/JERmU4EVFmN5v3OlgZURng5fOo0LTPxdNHz0m5MTycf2+8edNMUDB1HYa3Pxlcecd+KtfqyHMatWO261Q8BfXIjdhE7hrwMKvJ6kxuyeB9wG/HTJkjI/QEQKIQ8ZMJXQyHKHDwG/8ti4uOwLqPQDRNwz2UC4I7U/V/bysJnlAieqm3ADPneN6CQbd9N7s2hlQXaD+lzLmXRZ7heglqNZKPDMwOkKNENTCXknRgJekUFMYnYcsy/qsyEj0sCLBCjvbCRSq3tDhcKfah23rW1FoMq0NNX7Pj47kEvzxdcGyjZ6bcSRY3w5qSpIPKm3LJqxon0/cmyxPiMLDtIf8hUY+gjVKHpc/qcnzvbFnnRSXG8BL5tuIlQB5U0hr+hKKDsW+avTXlVUiSojG7oQxTCzkO1UjV0VcuXd0yWzh4c7eG/KIymoDB7/LxiMfRNuOOg3fdV0eJb/4fRtNVqQ2OU2IBY5Riu/HvlPG0LnGnUGDo0Qqrv+l1KelU/WnbUXhMY84hCrUS4iV6EuIb37j0HfIwGa5zX9fo+EqcwY30f9SMaSKp7FfmpcpZuqA1U7+CKP+zN1r5ShFyijUDYXoWzzeugFOrjSCmLB7EG3YoZcARNnSi5WTPR47JtZvLnEON/02V4gn9t083BSVbBBslsm/1356luTS44gigRdIPwEWfvNmc+5pbihLVsR1AK/nZrwyp3rpnA1a4VBaMJykaQ+KnSN8DE86al8BddAtefBVBX7W2TyVUdHApB7X3WSPbfksjELTIUgLoYTzblcy2XQfGLZentWfLd81cAleu7pDXEz7i3WxwuG93L79JBLPscNmEUL+QEj2zizsX7PIBKVDf6ggCeXExvf1r2pSadyotbqU8SYt69jKd706Oy2zR0r8sDRV/ZgxedCkzVHCYCcYkBFPDbPPo2Je1ov+093s4G8FUIDaVzoOf/oZote1PZ8EWe2ayRMjJCM+M9f//dafv84vn+FQtgltkr88nNY+fn7vFwqpTKn2cwcLnrNhosIuNBlDaPwV6FZ9/AVC9/sZhPnjYDrIom3Ewf9GltB0wxhXv/kyX9jbi2Sdiw3VvU6C/C0X2Cejuwxyc6ADeMU+DlvzT80387jZfdEGjh6113vuzBJkU7e6w4TIUH6t8KP/Mny78sTH+BV80KDjWqM6zrsl91jGNcHdiMj7OPFskilqaXtQw6HvZNDRBygZW0XhlzRMOyMh6lNR6zDsT5VVBVPTrt5F5lRkioMfg0c6gN6o636P9z1i4uhPhFeIDIuMiC7+9q/DH+vfeIUOYgoTaqXyiDTZ/v970flevff6a0soWMLBmY6o3Ac5DauanmsTYQE2BHbsvh32ULWc0HmK6xvzYBC11klu8bZMtu/UAGfQJ/VXlr X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8b60586-7649-456e-a99d-08dca71424f4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 10:26:54.5856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1IWXopR1sSktG3yBPkXuM6Az/CXzGIxVwZq913E2vflN1FumWg/Ed2ARosZzUJ7LP8TLJszW21iv8eQk0cMN3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9886 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240718_032700_286655_9028FD32 X-CRM114-Status: UNSURE ( 9.02 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org i.MX7ULP need properly set System Integration Module(SIM) module to make usb wakeup work well. This will add a "nxp,sim" property for usbphy1. Signed-off-by: Xu Yang --- arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi index ac338320ac1d..b093f2a447ae 100644 --- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi @@ -214,6 +214,7 @@ usbphy1: usb-phy@40350000 { interrupts = ; clocks = <&pcc2 IMX7ULP_CLK_USB_PHY>; #phy-cells = <0>; + nxp,sim = <&sim>; }; usdhc0: mmc@40370000 {