From patchwork Sat Jul 20 16:21:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 13737844 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C23FE83CDB; Sat, 20 Jul 2024 16:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721492501; cv=none; b=HR3NjOLRzq1NwpUt83g6LAD+o729x/FrR7uW0uU8T2dLqLaE4biPU59o149gJBDy9bhbrNVfhBeLi40CcbyygqTM43+00wmWqqG5bQzePe88Qx/DI4rod+SHwIMljk98btBd2OaMDuAD32V6UhCqCR9yaRa50l4TTTIZD8FE390= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721492501; c=relaxed/simple; bh=PAUwm1I5mdnfi1Vk2EodpjrA/IhnO7lVRUkHoUJsJ3s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NehUKiSq9Lge6fszR2VLThKjN/wTe8Cgr5N52X3krNUhbOh8MN+TdUiejNDh/MlEv2hrwfIr6IXO2YJIHvQZSgG7hBPNgbSjOrV7/xTC+DD7BHJEkaYn5k3o5mbHgl3s2nZZKQWsCwYfqawXl5tt7bykP8PVvEvavjdvxZ7ZSuY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pASLfWW6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pASLfWW6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5807DC2BD10; Sat, 20 Jul 2024 16:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721492501; bh=PAUwm1I5mdnfi1Vk2EodpjrA/IhnO7lVRUkHoUJsJ3s=; h=From:To:Cc:Subject:Date:From; b=pASLfWW6dvWL59zwxzGVWMTQ11q1JjEmAz5LBchZpzk0Rp1sJrMhduR55WQkMdNoG hpYgNYbCzJNamqXdsNdSU2/bYjfGXsxv4bjFgdSXmRkT6Lt5ILCKpRIGTo6l5aP5Q4 ZtgznuCYwgn6wKsuWFT7v/mOPmrjDZzMV0CpigyT2JluG1oC6lYw7SRwMAV+Wzhc8J dlZUHNfgDRQr/o4PwoXMtcU4kNuwXs4WhCP2GiP3WQ/T+9xBw2GSaM3XqlWOIC5rsA 2EPGKF8JVFHEA4cljUPyRPsYsTy9SbQD8QWXh+7rjoqnuvOI1Q2X9Ueco1c7yMB1nO vlw/6Inp6FvAQ== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH 1/2] kallsyms: unify seq and start_pos fields of struct sym_entry Date: Sun, 21 Jul 2024 01:21:13 +0900 Message-ID: <20240720162136.111898-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The struct sym_entry uses the 'seq' and 'start_pos' fields to remember the index in the symbol table. They serve the same purpose and are not used simultaneously. Unify them. Signed-off-by: Masahiro Yamada --- scripts/kallsyms.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index e291e34a450b..9a0535c59702 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -36,7 +36,6 @@ struct sym_entry { unsigned long long addr; unsigned int len; unsigned int seq; - unsigned int start_pos; unsigned int percpu_absolute; unsigned char sym[]; }; @@ -278,7 +277,7 @@ static void read_map(const char *in) if (!sym) continue; - sym->start_pos = table_cnt; + sym->seq = table_cnt; if (table_cnt >= table_size) { table_size += 10000; @@ -762,7 +761,7 @@ static int compare_symbols(const void *a, const void *b) return wa - wb; /* sort by initial order, so that other symbols are left undisturbed */ - return sa->start_pos - sb->start_pos; + return sa->seq - sb->seq; } static void sort_symbols(void) From patchwork Sat Jul 20 16:21:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 13737845 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A71146A96; Sat, 20 Jul 2024 16:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721492503; cv=none; b=gRXNoOaugSamCsg+qXKJcVCO1jg9+ziT3Er2owAbeRufpAsoRZG/afaeTV5i2P4srrnWQR+9uXL9Zfl68H6PHNCPFIJs6zkkuQ78XVfI66YdGD3azKnpVnWU4i9wRiGbrf8r8jFbiZd+JUuCYXXNfn3KPGJZR/bkI1B8kvxWYaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721492503; c=relaxed/simple; bh=vL3miUANwmXmD+NJf1Syoh2nk+z/Q2eiOhWN7u9K1m4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bWEt7tWVfNaK1oFQVBrF54Mh3V1x39NDHXTabOKVRvVSKKuoI7AnlOMyexy8qUskxU8ji4NZcrFd8kLZFxvutVFB2sS2ii0ZMDNj9LfWmPHVqAj8KAzUl4uybjtqfoT6Jgkzen6OTWDWFnQRekU0Z9vSR9DrW5UsZRpRRr0jRag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gjRFI2oO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gjRFI2oO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4B9FC4AF09; Sat, 20 Jul 2024 16:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721492502; bh=vL3miUANwmXmD+NJf1Syoh2nk+z/Q2eiOhWN7u9K1m4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gjRFI2oOTJvpOhsjAzkxsugqhtMdy2Vuh0s+6OLbsjyLkuMmFgbs/x319HZ+B7OwT HUo07x/81SxI2Wv9XHKuiSSS7+QfA/OXUHSYUX9bdtD80ARw8muRJdZ15gMDNlJrSb 37EpkM2gvNnZtAXKa57+nmaBqlsa7sfJcEG5tZx/ZVtF3Xuca6nylT4KbQmtS+J6pu a/cyXI0ZNvquL49NMM+FJdzYOwlTdH3WSgRYi3JgBQLt6qGjlIw3qlUEMJt+N2N6ID rLy8jNa1hkVJnL62z+j1VX9jS/meFFF5KaGFrfd14H6dsLRdPRHIctPqz9O86Peql/ rkj34p+/2e2/Q== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH 2/2] kallsyms: change sym_entry::percpu_absolute to bool type Date: Sun, 21 Jul 2024 01:21:14 +0900 Message-ID: <20240720162136.111898-2-masahiroy@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240720162136.111898-1-masahiroy@kernel.org> References: <20240720162136.111898-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This field is boolean. Signed-off-by: Masahiro Yamada --- scripts/kallsyms.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index 9a0535c59702..0ed873491bf5 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -36,7 +36,7 @@ struct sym_entry { unsigned long long addr; unsigned int len; unsigned int seq; - unsigned int percpu_absolute; + bool percpu_absolute; unsigned char sym[]; }; @@ -181,7 +181,7 @@ static struct sym_entry *read_symbol(FILE *in, char **buf, size_t *buf_len) sym->len = len; sym->sym[0] = type; strcpy(sym_name(sym), name); - sym->percpu_absolute = 0; + sym->percpu_absolute = false; return sym; } @@ -339,7 +339,7 @@ static int expand_symbol(const unsigned char *data, int len, char *result) return total; } -static int symbol_absolute(const struct sym_entry *s) +static bool symbol_absolute(const struct sym_entry *s) { return s->percpu_absolute; } @@ -781,7 +781,7 @@ static void make_percpus_absolute(void) * versions of this tool. */ table[i]->sym[0] = 'A'; - table[i]->percpu_absolute = 1; + table[i]->percpu_absolute = true; } }