From patchwork Wed Jul 24 16:19:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Finkel X-Patchwork-Id: 13741165 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B068C3DA63 for ; Wed, 24 Jul 2024 16:19:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE4716B0093; Wed, 24 Jul 2024 12:19:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C93246B0095; Wed, 24 Jul 2024 12:19:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0C226B0096; Wed, 24 Jul 2024 12:19:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C57C6B0093 for ; Wed, 24 Jul 2024 12:19:54 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3D341A0155 for ; Wed, 24 Jul 2024 16:19:54 +0000 (UTC) X-FDA: 82375157508.21.4393660 Received: from m35-116.mailgun.net (m35-116.mailgun.net [69.72.35.116]) by imf17.hostedemail.com (Postfix) with ESMTP id 2608A40028 for ; Wed, 24 Jul 2024 16:19:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=relay.vimeo.com header.s=mailo header.b=iEDnb+Sw; spf=pass (imf17.hostedemail.com: domain of "bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com" designates 69.72.35.116 as permitted sender) smtp.mailfrom="bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com"; dmarc=pass (policy=reject) header.from=vimeo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721837968; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=heWQ7YrOsx+4DBKY279H6HgH8ge0lVhhSYfkiz6T6iE=; b=H1Rlu/4hwW5N697ef+n+wWYYhegMS/P1ZgT0KQIYjQMzad2H8K2T9ZYzLCvHtWqfxJxvDj BR6/41DrLPFdsW6kYd33bmUQTwJgIYnnAOS1wsc499v3qTBjgTNs3l6kzkhqyn4XTxs7dK 6IG07yNXE+w+uBDavIZJbU7sFwhrMsc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=relay.vimeo.com header.s=mailo header.b=iEDnb+Sw; spf=pass (imf17.hostedemail.com: domain of "bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com" designates 69.72.35.116 as permitted sender) smtp.mailfrom="bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com"; dmarc=pass (policy=reject) header.from=vimeo.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721837968; a=rsa-sha256; cv=none; b=WpLApmx15F+PGBO+f9O+scPbHPHrzasoGvite7jW5XuHOoayM0v952AHLfRaknPAXNHSb/ zY/bmE00ULsuNGBtRgo4ayg5M5sDyS+gFvQINz9ltXjHNVaMXnLj8qMiyEeAbdourUBYSq Piedp4rnXqnzB8T8ZwkOoJ0sMUCwT0Q= DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=relay.vimeo.com; q=dns/txt; s=mailo; t=1721837991; x=1721845191; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-Id: Date: Subject: Subject: Cc: To: To: From: From: Sender: Sender; bh=heWQ7YrOsx+4DBKY279H6HgH8ge0lVhhSYfkiz6T6iE=; b=iEDnb+SwUdLTG9D0o+X/sXJlwcy0uQebJyyO8HaRalxye02kNZaffMXEHBq3RRER9UpROJ8/7TlxQJDsmHGMkJJ4wc70MOhYHGfauJrK/FZ2j0oOQ/tyaN6/DzOTuOUSLWHd0a2F5/zvwzjPWpYlQkQTxt73DHjyo9p1mAxfwPY= X-Mailgun-Sending-Ip: 69.72.35.116 X-Mailgun-Sid: WyI5NTRmYiIsImxpbnV4LW1tQGt2YWNrLm9yZyIsIjlkMmExYyJd Received: from smtp.vimeo.com (215.71.185.35.bc.googleusercontent.com [35.185.71.215]) by f81c9394ec5c with SMTP id 66a129a68091003b4df3fe1a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 24 Jul 2024 16:19:50 GMT Received: from nutau (gke-sre-us-east1-main-4c35368b-n90a.c.vimeo-core.internal [10.56.27.205]) by smtp.vimeo.com (Postfix) with ESMTP id D08D363DD6; Wed, 24 Jul 2024 16:19:49 +0000 (UTC) Received: by nutau (Postfix, from userid 1001) id AB37FB4128D; Wed, 24 Jul 2024 12:19:49 -0400 (EDT) From: David Finkel To: Muchun Song , Tejun Heo , Roman Gushchin , Andrew Morton Cc: core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Shakeel Butt , Shuah Khan , Johannes Weiner , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, David Finkel , Waiman Long Subject: [PATCH v5 1/2] mm, memcg: cg2 memory{.swap,}.peak write handlers Date: Wed, 24 Jul 2024 12:19:41 -0400 Message-Id: <20240724161942.3448841-2-davidf@vimeo.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240724161942.3448841-1-davidf@vimeo.com> References: <20240724161942.3448841-1-davidf@vimeo.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2608A40028 X-Stat-Signature: cn1u4tab8nb6afcsf9s74koafheimr3q X-HE-Tag: 1721837992-54758 X-HE-Meta: U2FsdGVkX1/iupJ4suCZYfkw2pQdKo9biD+NYXxjy6a5pxnmg++CyFLLAJNhFw5idP8rsIUeF8f/JHkkSbACdY4GIpDoeBdf5AAZhnCcvUuWfkgPYfkp+7SleFPjm91vThTpZCoG0DKN172OkWM6/zveTh68sO2ug1mZPNQ5dZcD8gZJMu8yrmiUfeoFIJnwt1lu390xhe3tfyK7dU4G37jKAjtiArU02zKx7zJlzcPm2ILyIdhcVx+psnpsQkozNhMzs95udiuS8NiRun0eG/cZbxZ2lBqR0C2hJ/azqM92na/nlLVL/OzYTEYDhfFJJUUnJzOsMTOzxw8ugd5jMSA0/+hs7A1zY7+Oe//PbAEE7RpjuMuD9jGCrTT2gcF/Zv3JTQXDwmW62fyRQu5XXos/PiUBzIe1eFCgfTfMhyi+VBECZHyJIOb5YOIQD0CZiC9tjk8oz0YMDiWLzIhhfIMydZTqpLaStL9p80BmKM+PpZKnACdq5PrP/CBWmGyyHtJ4wx/JdnnhN6pVHBRe6evPQmNsbUxV+vI1xj9PbZ12kM02T2Ile1x3bFPDZufJbij6ZqwrERiuqi5nBBHtmUIdRrBegw6/PCWfCLFJLairxpJjGts3q1225r4KAy2TfqBD2WxR6w/6zgts/PhIvZd4thl8qinFseK4khiHXvDeI/ZrNuw2+BfmAMmWAbZZSeXOLZqwZCTuq9Q1DRhgKknN75QYvHcNOSQnvXtT6haypXj2l/3JBxcOKu/F8+gisGYw6vUxn4gSiUW45oMlW0ZxwUUBrWHTifocfoGt92B1bphoKt+N8UDRS3GBFYyXDhLONwRYWbzTqMOSeC5FYU7vAeeuMGIum4qkvYZ1FxvoXhD/Yicw/dBJHMYMYJDWjbOkoPE2+SW1z7/+FHnsw8JTSXg8z0B5yoC5OxwxPMP9GaIHF5RK9TWLf/S0NTlitW+5vp3myfqjd6+nXtL CQSWzYCq oSJJxJcml+HqoP+3rbAkTvR8WJcH1865S8Ftm5Pmi1krVnV7bltwkwhICdhcYQOhZJEzm+sk8Eu8l1EK/aFeFqeiyIeB2PmGa/SD1m6KYyCSMJ3i+dudENAr1AAOxbU97kFDeydPwQsMSR/No+cUJ0WqPSvxWcuG/apCDbJG+tXryPYpYnZUACDOq/JQKP7Qji/JW+tAU7dKjNnPjNs/bvSehGMASgJQN4DO6d/ub0a49/Gx5cygW4wi9Q41PYOz8hYir58yrDrMhKgQyy8GNIpjO6vmulteVbu6tCZhHFWMISyjIDcURAmBv9nv7M07Mk5VA0SZy7iMQDH8a4MgPCuqIKecezpwWKfO96nZ2xtqJF4mcFYC2nm7yPbjRLDQCkBq4wWUi8jqcJTZmUS40gtKyqCsYw6npuoT1OkcfQ6rpZBTPRUndl+VuGT9q59MT/Vl7Z2/KpvBZ9wiPnIWYzjWLnGb8Iv8ZKLs0hBrClFktLRRY3a42pI5xIejIYdbXWGNZpJx48bUVfUaeUZWXMwp85JUsP3Uqtpz8mNu0YuHAlKiyOGvjz/EKRpiddvS9jz7r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Other mechanisms for querying the peak memory usage of either a process or v1 memory cgroup allow for resetting the high watermark. Restore parity with those mechanisms, but with a less racy API. For example: - Any write to memory.max_usage_in_bytes in a cgroup v1 mount resets the high watermark. - writing "5" to the clear_refs pseudo-file in a processes's proc directory resets the peak RSS. This change is an evolution of a previous patch, which mostly copied the cgroup v1 behavior, however, there were concerns about races/ownership issues with a global reset, so instead this change makes the reset filedescriptor-local. Writing a specific string to the memory.peak and memory.swap.peak pseudo-files reset the high watermark to the current usage for subsequent reads through that same fd. Notably, following Johannes's suggestion, this implementation moves the O(fds that have written) behavior onto the fd write(2) path. Instead, on the page-allocation path, we simply add one additional watermark to conditionally bump per-hierarchy level in the page-counter. Additionally, this takes Longman's suggestion of nesting the page-charging-path checks for the two watermarks to reduce the number of common-case comparisons. This behavior is particularly useful for work scheduling systems that need to track memory usage of worker processes/cgroups per-work-item. Since memory can't be squeezed like CPU can (the OOM-killer has opinions), these systems need to track the peak memory usage to compute system/container fullness when binpacking workitems. Most notably, Vimeo's use-case involves a system that's doing global binpacking across many Kubernetes pods/containers, and while we can use PSI for some local decisions about overload, we strive to avoid packing workloads too tightly in the first place. To facilitate this, we track the peak memory usage. However, since we run with long-lived workers (to amortize startup costs) we need a way to track the high watermark while a work-item is executing. Polling runs the risk of missing short spikes that last for timescales below the polling interval, and peak memory tracking at the cgroup level is otherwise perfect for this use-case. As this data is used to ensure that binpacked work ends up with sufficient headroom, this use-case mostly avoids the inaccuracies surrounding reclaimable memory. Suggested-by: Johannes Weiner Suggested-by: Waiman Long Signed-off-by: David Finkel --- Documentation/admin-guide/cgroup-v2.rst | 26 ++++-- include/linux/cgroup-defs.h | 5 + include/linux/cgroup.h | 3 + include/linux/memcontrol.h | 5 + include/linux/page_counter.h | 10 +- kernel/cgroup/cgroup-internal.h | 2 + kernel/cgroup/cgroup.c | 7 ++ mm/memcontrol.c | 117 ++++++++++++++++++++++-- mm/page_counter.c | 30 ++++-- 9 files changed, 178 insertions(+), 27 deletions(-) diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst index 86311c2907cd3..01554cf6e55b4 100644 --- a/Documentation/admin-guide/cgroup-v2.rst +++ b/Documentation/admin-guide/cgroup-v2.rst @@ -1333,11 +1333,16 @@ The following nested keys are defined. all the existing limitations and potential future extensions. memory.peak - A read-only single value file which exists on non-root - cgroups. + A read-write single value file which exists on non-root cgroups. + + The max memory usage recorded for the cgroup and its descendants since + either the creation of the cgroup or the most recent reset for that FD. - The max memory usage recorded for the cgroup and its - descendants since the creation of the cgroup. + A write of the string "reset" to this file resets it to the + current memory usage for subsequent reads through the same + file descriptor. + Attempts to write any other non-empty string will return EINVAL + (modulo leading and trailing whitespace). memory.oom.group A read-write single value file which exists on non-root @@ -1663,11 +1668,16 @@ The following nested keys are defined. Healthy workloads are not expected to reach this limit. memory.swap.peak - A read-only single value file which exists on non-root - cgroups. + A read-write single value file which exists on non-root cgroups. + + The max swap usage recorded for the cgroup and its descendants since + the creation of the cgroup or the most recent reset for that FD. - The max swap usage recorded for the cgroup and its - descendants since the creation of the cgroup. + A write of the string "reset" to this file resets it to the + current memory usage for subsequent reads through the same + file descriptor. + Attempts to write any other non-empty string will return EINVAL + (modulo leading and trailing whitespace). memory.swap.max A read-write single value file which exists on non-root diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index ae04035b6cbe5..2188ea76ab327 100644 --- a/include/linux/cgroup-defs.h +++ b/include/linux/cgroup-defs.h @@ -775,6 +775,11 @@ struct cgroup_subsys { extern struct percpu_rw_semaphore cgroup_threadgroup_rwsem; +struct cgroup_of_peak { + long value; + struct list_head list; +}; + /** * cgroup_threadgroup_change_begin - threadgroup exclusion for cgroups * @tsk: target task diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index c60ba0ab14627..3e0563753cc3e 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -854,4 +855,6 @@ static inline void cgroup_bpf_put(struct cgroup *cgrp) {} struct cgroup *task_get_cgroup1(struct task_struct *tsk, int hierarchy_id); +struct cgroup_of_peak *of_peak(struct kernfs_open_file *of); + #endif /* _LINUX_CGROUP_H */ diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 7e2eb091049a0..4fa4f0e931d26 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -192,6 +192,11 @@ struct mem_cgroup { struct page_counter memsw; /* v1 only */ }; + /* registered local peak watchers */ + struct list_head memory_peaks; + struct list_head swap_peaks; + spinlock_t peaks_lock; + /* Range enforcement for interrupt charges */ struct work_struct high_work; diff --git a/include/linux/page_counter.h b/include/linux/page_counter.h index 904c52f97284f..e1295e3e1f195 100644 --- a/include/linux/page_counter.h +++ b/include/linux/page_counter.h @@ -26,6 +26,7 @@ struct page_counter { atomic_long_t children_low_usage; unsigned long watermark; + unsigned long local_watermark; unsigned long failcnt; /* Keep all the read most fields in a separete cacheline. */ @@ -78,7 +79,14 @@ int page_counter_memparse(const char *buf, const char *max, static inline void page_counter_reset_watermark(struct page_counter *counter) { - counter->watermark = page_counter_read(counter); + unsigned long usage = page_counter_read(counter); + + /* + * Update local_watermark first, so it's always <= watermark + * (modulo CPU/compiler re-ordering) + */ + counter->local_watermark = usage; + counter->watermark = usage; } void page_counter_calculate_protection(struct page_counter *root, diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h index 520b90dd97eca..c964dd7ff967a 100644 --- a/kernel/cgroup/cgroup-internal.h +++ b/kernel/cgroup/cgroup-internal.h @@ -81,6 +81,8 @@ struct cgroup_file_ctx { struct { struct cgroup_pidlist *pidlist; } procs1; + + struct cgroup_of_peak peak; }; /* diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index c8e4b62b436a4..0a97cb2ef1245 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1972,6 +1972,13 @@ static int cgroup2_parse_param(struct fs_context *fc, struct fs_parameter *param return -EINVAL; } +struct cgroup_of_peak *of_peak(struct kernfs_open_file *of) +{ + struct cgroup_file_ctx *ctx = of->priv; + + return &ctx->peak; +} + static void apply_cgroup_root_flags(unsigned int root_flags) { if (current->nsproxy->cgroup_ns == &init_cgroup_ns) { diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 9603717886877..a6998a194c6b4 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -25,6 +25,7 @@ * Copyright (C) 2020 Alibaba, Inc, Alex Shi */ +#include #include #include #include @@ -41,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -3558,6 +3560,9 @@ static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent) INIT_WORK(&memcg->high_work, high_work_func); vmpressure_init(&memcg->vmpressure); + INIT_LIST_HEAD(&memcg->memory_peaks); + INIT_LIST_HEAD(&memcg->swap_peaks); + spin_lock_init(&memcg->peaks_lock); memcg->socket_pressure = jiffies; memcg1_memcg_init(memcg); memcg->kmemcg_id = -1; @@ -3950,12 +3955,90 @@ static u64 memory_current_read(struct cgroup_subsys_state *css, return (u64)page_counter_read(&memcg->memory) * PAGE_SIZE; } -static u64 memory_peak_read(struct cgroup_subsys_state *css, - struct cftype *cft) +static int peak_show(struct seq_file *sf, void *v, struct page_counter *pc) { - struct mem_cgroup *memcg = mem_cgroup_from_css(css); + struct cgroup_of_peak *ofp = of_peak(sf->private); + u64 fd_peak = READ_ONCE(ofp->value), peak; + + /* User wants global or local peak? */ + if (fd_peak == -1UL) + peak = pc->watermark; + else + peak = max(fd_peak, pc->local_watermark); + + seq_printf(sf, "%llu\n", peak * PAGE_SIZE); + return 0; +} - return (u64)memcg->memory.watermark * PAGE_SIZE; +static int memory_peak_show(struct seq_file *sf, void *v) +{ + struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(sf)); + + return peak_show(sf, v, &memcg->memory); +} + +static int peak_open(struct kernfs_open_file *of) +{ + struct cgroup_of_peak *ofp = of_peak(of); + + ofp->value = -1; + return 0; +} + +static void peak_release(struct kernfs_open_file *of) +{ + struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); + struct cgroup_of_peak *ofp = of_peak(of); + + if (ofp->value == -1) { + /* fast path (no writes on this fd) */ + return; + } + spin_lock(&memcg->peaks_lock); + list_del(&ofp->list); + spin_unlock(&memcg->peaks_lock); +} + +static ssize_t peak_write(struct kernfs_open_file *of, char *buf, size_t nbytes, + loff_t off, struct page_counter *pc, + struct list_head *watchers) +{ + unsigned long usage; + struct cgroup_of_peak *peer_ctx; + struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); + struct cgroup_of_peak *ofp = of_peak(of); + + buf = strstrip(buf); + /* Only allow "reset" to keep the API clear */ + if (strcmp(buf, "reset")) + return -EINVAL; + + spin_lock(&memcg->peaks_lock); + + pc->local_watermark = page_counter_read(pc); + usage = pc->local_watermark; + + list_for_each_entry(peer_ctx, watchers, list) + if (usage > peer_ctx->value) + peer_ctx->value = usage; + + /* initial write, register watcher */ + if (ofp->value == -1) + list_add(&ofp->list, watchers); + + ofp->value = usage; + spin_unlock(&memcg->peaks_lock); + + return nbytes; +} + +static ssize_t memory_peak_write(struct kernfs_open_file *of, char *buf, + size_t nbytes, loff_t off) +{ + struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); + + return peak_write(of, buf, nbytes, off, &memcg->memory, + &memcg->memory_peaks); } static int memory_min_show(struct seq_file *m, void *v) @@ -4307,7 +4390,10 @@ static struct cftype memory_files[] = { { .name = "peak", .flags = CFTYPE_NOT_ON_ROOT, - .read_u64 = memory_peak_read, + .open = peak_open, + .release = peak_release, + .seq_show = memory_peak_show, + .write = memory_peak_write, }, { .name = "min", @@ -5099,12 +5185,20 @@ static u64 swap_current_read(struct cgroup_subsys_state *css, return (u64)page_counter_read(&memcg->swap) * PAGE_SIZE; } -static u64 swap_peak_read(struct cgroup_subsys_state *css, - struct cftype *cft) +static int swap_peak_show(struct seq_file *sf, void *v) { - struct mem_cgroup *memcg = mem_cgroup_from_css(css); + struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(sf)); + + return peak_show(sf, v, &memcg->swap); +} + +static ssize_t swap_peak_write(struct kernfs_open_file *of, char *buf, + size_t nbytes, loff_t off) +{ + struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); - return (u64)memcg->swap.watermark * PAGE_SIZE; + return peak_write(of, buf, nbytes, off, &memcg->swap, + &memcg->swap_peaks); } static int swap_high_show(struct seq_file *m, void *v) @@ -5188,7 +5282,10 @@ static struct cftype swap_files[] = { { .name = "swap.peak", .flags = CFTYPE_NOT_ON_ROOT, - .read_u64 = swap_peak_read, + .open = peak_open, + .release = peak_release, + .seq_show = swap_peak_show, + .write = swap_peak_write, }, { .name = "swap.events", diff --git a/mm/page_counter.c b/mm/page_counter.c index 0153f5bb31611..ad9bdde5d5d20 100644 --- a/mm/page_counter.c +++ b/mm/page_counter.c @@ -79,9 +79,22 @@ void page_counter_charge(struct page_counter *counter, unsigned long nr_pages) /* * This is indeed racy, but we can live with some * inaccuracy in the watermark. + * + * Notably, we have two watermarks to allow for both a globally + * visible peak and one that can be reset at a smaller scope. + * + * Since we reset both watermarks when the global reset occurs, + * we can guarantee that watermark >= local_watermark, so we + * don't need to do both comparisons every time. + * + * On systems with branch predictors, the inner condition should + * be almost free. */ - if (new > READ_ONCE(c->watermark)) - WRITE_ONCE(c->watermark, new); + if (new > READ_ONCE(c->local_watermark)) { + WRITE_ONCE(c->local_watermark, new); + if (new > READ_ONCE(c->watermark)) + WRITE_ONCE(c->watermark, new); + } } } @@ -129,12 +142,13 @@ bool page_counter_try_charge(struct page_counter *counter, goto failed; } propagate_protected_usage(c, new); - /* - * Just like with failcnt, we can live with some - * inaccuracy in the watermark. - */ - if (new > READ_ONCE(c->watermark)) - WRITE_ONCE(c->watermark, new); + + /* see comment on page_counter_charge */ + if (new > READ_ONCE(c->local_watermark)) { + WRITE_ONCE(c->local_watermark, new); + if (new > READ_ONCE(c->watermark)) + WRITE_ONCE(c->watermark, new); + } } return true; From patchwork Wed Jul 24 16:19:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Finkel X-Patchwork-Id: 13741166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8026C3DA7E for ; Wed, 24 Jul 2024 16:19:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5336B0095; Wed, 24 Jul 2024 12:19:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA4496B0096; Wed, 24 Jul 2024 12:19:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C46166B0098; Wed, 24 Jul 2024 12:19:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A5F996B0095 for ; Wed, 24 Jul 2024 12:19:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5F381A41E7 for ; Wed, 24 Jul 2024 16:19:55 +0000 (UTC) X-FDA: 82375157550.25.8D46DD3 Received: from m47-110.mailgun.net (m47-110.mailgun.net [69.72.47.110]) by imf19.hostedemail.com (Postfix) with ESMTP id 80B031A000C for ; Wed, 24 Jul 2024 16:19:53 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=relay.vimeo.com header.s=mailo header.b=XUB4aBRx; spf=pass (imf19.hostedemail.com: domain of "bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com" designates 69.72.47.110 as permitted sender) smtp.mailfrom="bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com"; dmarc=pass (policy=reject) header.from=vimeo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721837946; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t2iHNmDNFh2Lhloylho+v4Z/hy/KUWvSDvmAzMoAG5g=; b=2a1H0OncP9PNtvKP743FK7zMvfJJd0lt8NQj/QLOhsIUl9dOUTYWodi/w3D0ao+DRDVqJ4 lgNSwY6UbCHLHDgoFbF//Ip4E9tN/AbQdDlo/FBfdIRXrNtxcnSogWlMxGLbJlj1yhGRrI dAH5emPjWaOsr6zgawHuDBN7Ha3xlpc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721837946; a=rsa-sha256; cv=none; b=2Bin0GLH6GiouiFVDtLZXh5vjcFfqxQJWMfUevV8FslgzxGc/vRpMCqWkIScskxtMsv5/t VeBGRDPDcARyrFFiXgNi54vQTEuMOoC5BlDPAlkzg8g6l36ONg8TdD5FeDhSmw8ANM4wIa J7DqubTKe6WfWcHBuFpim8FDZ/PiKEM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=relay.vimeo.com header.s=mailo header.b=XUB4aBRx; spf=pass (imf19.hostedemail.com: domain of "bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com" designates 69.72.47.110 as permitted sender) smtp.mailfrom="bounce+ea57f2.9d2a1c-linux-mm=kvack.org@relay.vimeo.com"; dmarc=pass (policy=reject) header.from=vimeo.com DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=relay.vimeo.com; q=dns/txt; s=mailo; t=1721837992; x=1721845192; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-Id: Date: Subject: Subject: Cc: To: To: From: From: Sender: Sender; bh=t2iHNmDNFh2Lhloylho+v4Z/hy/KUWvSDvmAzMoAG5g=; b=XUB4aBRxiTGaIzuR3zTnx0m4f5Fdyi6zRq6IiGgVs8dLFMjq7/BB5d++crbPlsf6qEMtD19Yu4YQ0J1wBxtNGQ7Od4anE2awc1Oze4wLoWS3YiYQbUcXJ5NmOUvgA3N99jXC8G2tTe39bee2dr2tWPpRbKQlYq6Un/gzVglsPBU= X-Mailgun-Sending-Ip: 69.72.47.110 X-Mailgun-Sid: WyI5NTRmYiIsImxpbnV4LW1tQGt2YWNrLm9yZyIsIjlkMmExYyJd Received: from smtp.vimeo.com (215.71.185.35.bc.googleusercontent.com [35.185.71.215]) by fa9eff58138b with SMTP id 66a129a8ecd0d8824c830136 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 24 Jul 2024 16:19:52 GMT Received: from nutau (gke-sre-us-east1-main-c45160e0-2rrj.c.vimeo-core.internal [10.56.27.206]) by smtp.vimeo.com (Postfix) with ESMTP id D075363DD6; Wed, 24 Jul 2024 16:19:51 +0000 (UTC) Received: by nutau (Postfix, from userid 1001) id BA4A2B4128D; Wed, 24 Jul 2024 12:19:51 -0400 (EDT) From: David Finkel To: Muchun Song , Tejun Heo , Roman Gushchin , Andrew Morton Cc: core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Shakeel Butt , Shuah Khan , Johannes Weiner , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, David Finkel Subject: [PATCH v5 2/2] mm, memcg: cg2 memory{.swap,}.peak write tests Date: Wed, 24 Jul 2024 12:19:42 -0400 Message-Id: <20240724161942.3448841-3-davidf@vimeo.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240724161942.3448841-1-davidf@vimeo.com> References: <20240724161942.3448841-1-davidf@vimeo.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 80B031A000C X-Stat-Signature: iu9xy4dhsqi8hhhxeccnz4ek5jzpocwh X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721837993-384185 X-HE-Meta: U2FsdGVkX1+ifuznHcC9Gw8Fv4DuZyZcDIL+Vdwy+WtZsxHVV6fZ5A/lMEnoJfU/TN661pVjiRk/Kv6/OK89RPZTYdk8SdZTCEaffhLik4Tq2Oc6oKHSbFbRya5ML1TWRmY3nA71WNw0+IzfPMImXfFcM6T4Q3VILj7YO+5aMqQRPjD9jjpZPNsf3xytNDB6QyN0enj6bVbFHJUOC1wLCqYcrTLCl6J7V771DhOM/ZiOEKKqfaXJrxx39RkAJ/PAgVFYiiBjSmO6R+mGxtq43xMwgWKcnKlq7qj9uApVFE6SRA8erfbfRkCxHDLiKNeeB0p3JLSoA7EJAgJuf75y38C+MGP7rUWOZtYRXjfDl/NQmj8gl/FFGb0iESB7tpx6Fvb/r2+BClkPpUvZ403FrvdFL0Fev6KiRnKySaVwXYJEVzM12lnNRKfryuF9BSlnl8QGPUREwj8pLTAeT9igZrRO4yjNrvxc+pqtyJhIpNchNVe/Mde5ydJ4I3EFOz4grBlB3AUrWx55xoXpjse2i32qkf4nW1HS3Wt5ubEpMZauyAR731tz0xE2f/M8FkMRi9AjbYW0ErD6hZhsR20Fx5sZSQe3kCzuN5ZgCIFqFQNEtP4bioxyMBTd0y3HiXPvewelnSxCCQnwCwYqWYteqVbUJHggxeCHghdrzoAkbdwAKsPgShYpGv70a4DdIQZzbOS/FomYhsXeggqGfj1O2E60XZ/3By0ShigG+3hmawI6UsZIebF1YVpWQL0gDoQyCs0gsuLSJRp6vuG+fh+jQmTwKgvGnsSe+R7GZU5rN2+A8KMEfyjUXE7gfRWbbK1X1wKGJYJ2vnK1nKjGEHe3t0bjuBGt1h3EcVK9xejWC+j2kqUs8dbpGBSvdiH9GYboROtt7cB8vVZeeFQwQFGPMeU4xrPjceGcc1jL62yrHG0hxytPU37Q3YkUr1S2MNXrY+TpsQ17JDZKKnOKbec OXnCMSY9 jzYoHLhX3EaXfkmrNyW5lH3g0BA3SLlt2piz8ww/iMJJEPKG5SFhNLjfLY0Rmv7SsP7asBUBF7YmmO3hRqGUh18OwhT/U3tSTWuEeNSx8sVJQxRy2CAYzX1qSl5nQAmiI5X2vli/dcWgOUbMBiQrF6FntMZhpboXIoTqV8twalp1czpMxYHMYfb+RAqOfPFVsYHmf+s8BIr0Q0EZqohCrk6J8UfrM9fowhWyNgGuwpLVDUpb+NgAWvIkuQX7HPPlgnIDd3YJ+oK+V6jgi+VR3QvHiqtX7CAwIzj4gzaOcDSd9FGAlyO+ou0xyyeZABsx0u9UrPcJCOV1mQCI2d99n8Y6nL8rW7Qnkn2LbTXFQApkndr6eD2aGAbAYOzsb1jxev0hLxa/T5TlYt+qVcg/KbOKajhO+yF8CaTot2lThuxBwB4us45o5HZEU/6a1cGZzy9mTnvFq8ImN9DB2pOMZ4s82rpNTY0idjFXKAQw+fDzWBk4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002539, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Extend two existing tests to cover extracting memory usage through the newly mutable memory.peak and memory.swap.peak handlers. In particular, make sure to exercise adding and removing watchers with overlapping lifetimes so the less-trivial logic gets tested. Signed-off-by: David Finkel --- tools/testing/selftests/cgroup/cgroup_util.c | 22 ++ tools/testing/selftests/cgroup/cgroup_util.h | 2 + .../selftests/cgroup/test_memcontrol.c | 226 +++++++++++++++++- 3 files changed, 242 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c index 432db923bced0..1e2d46636a0ca 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.c +++ b/tools/testing/selftests/cgroup/cgroup_util.c @@ -141,6 +141,16 @@ long cg_read_long(const char *cgroup, const char *control) return atol(buf); } +long cg_read_long_fd(int fd) +{ + char buf[128]; + + if (pread(fd, buf, sizeof(buf), 0) <= 0) + return -1; + + return atol(buf); +} + long cg_read_key_long(const char *cgroup, const char *control, const char *key) { char buf[PAGE_SIZE]; @@ -183,6 +193,18 @@ int cg_write(const char *cgroup, const char *control, char *buf) return ret == len ? 0 : ret; } +/* + * Returns fd on success, or -1 on failure. + * (fd should be closed with close() as usual) + */ +int cg_open(const char *cgroup, const char *control, int flags) +{ + char path[PATH_MAX]; + + snprintf(path, sizeof(path), "%s/%s", cgroup, control); + return open(path, flags); +} + int cg_write_numeric(const char *cgroup, const char *control, long value) { char buf[64]; diff --git a/tools/testing/selftests/cgroup/cgroup_util.h b/tools/testing/selftests/cgroup/cgroup_util.h index e8d04ac9e3d23..19b131ee77072 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.h +++ b/tools/testing/selftests/cgroup/cgroup_util.h @@ -34,9 +34,11 @@ extern int cg_read_strcmp(const char *cgroup, const char *control, extern int cg_read_strstr(const char *cgroup, const char *control, const char *needle); extern long cg_read_long(const char *cgroup, const char *control); +extern long cg_read_long_fd(int fd); long cg_read_key_long(const char *cgroup, const char *control, const char *key); extern long cg_read_lc(const char *cgroup, const char *control); extern int cg_write(const char *cgroup, const char *control, char *buf); +extern int cg_open(const char *cgroup, const char *control, int flags); int cg_write_numeric(const char *cgroup, const char *control, long value); extern int cg_run(const char *cgroup, int (*fn)(const char *cgroup, void *arg), diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 41ae8047b8895..30730a3c26412 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -161,12 +161,12 @@ static int alloc_pagecache_50M_check(const char *cgroup, void *arg) /* * This test create a memory cgroup, allocates * some anonymous memory and some pagecache - * and check memory.current and some memory.stat values. + * and checks memory.current, memory.peak, and some memory.stat values. */ -static int test_memcg_current(const char *root) +static int test_memcg_current_peak(const char *root) { int ret = KSFT_FAIL; - long current; + long current, peak, peak_reset; char *memcg; memcg = cg_name(root, "memcg_test"); @@ -180,15 +180,108 @@ static int test_memcg_current(const char *root) if (current != 0) goto cleanup; + peak = cg_read_long(memcg, "memory.peak"); + if (peak != 0) + goto cleanup; + if (cg_run(memcg, alloc_anon_50M_check, NULL)) goto cleanup; + peak = cg_read_long(memcg, "memory.peak"); + if (peak < MB(50)) + goto cleanup; + + /* + * We'll open a few FDs for the same memory.peak file to exercise the free-path + * We need at least three to be closed in a different order than writes occurred to test + * the linked-list handling. + */ + int peak_fd = cg_open(memcg, "memory.peak", O_RDWR | O_APPEND | O_CLOEXEC); + + if (peak_fd == -1) + goto cleanup; + + bool fd2_closed = false, fd3_closed = false, fd4_closed = false; + int peak_fd2 = cg_open(memcg, "memory.peak", O_RDWR | O_APPEND | O_CLOEXEC); + + if (peak_fd2 == -1) + goto cleanup; + + int peak_fd3 = cg_open(memcg, "memory.peak", O_RDWR | O_APPEND | O_CLOEXEC); + + if (peak_fd3 == -1) + goto cleanup; + + static const char reset_string[] = "reset\n"; + + peak_reset = write(peak_fd, reset_string, sizeof(reset_string)); + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + peak_reset = write(peak_fd2, reset_string, sizeof(reset_string)); + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + peak_reset = write(peak_fd3, reset_string, sizeof(reset_string)); + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + /* Make sure a completely independent read isn't affected by our FD-local reset above*/ + peak = cg_read_long(memcg, "memory.peak"); + if (peak < MB(50)) + goto cleanup; + + fd2_closed = true; + if (close(peak_fd2)) + goto cleanup; + + int peak_fd4 = cg_open(memcg, "memory.peak", O_RDWR | O_APPEND | O_CLOEXEC); + + if (peak_fd4 == -1) + goto cleanup; + + peak_reset = write(peak_fd4, reset_string, sizeof(reset_string)); + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + peak = cg_read_long_fd(peak_fd); + if (peak > MB(30) || peak < 0) + goto cleanup; + if (cg_run(memcg, alloc_pagecache_50M_check, NULL)) goto cleanup; + peak = cg_read_long(memcg, "memory.peak"); + if (peak < MB(50)) + goto cleanup; + + /* Make sure everything is back to normal */ + peak = cg_read_long_fd(peak_fd); + if (peak < MB(50)) + goto cleanup; + + peak = cg_read_long_fd(peak_fd4); + if (peak < MB(50)) + goto cleanup; + + fd3_closed = true; + if (close(peak_fd3)) + goto cleanup; + + fd4_closed = true; + if (close(peak_fd4)) + goto cleanup; + ret = KSFT_PASS; cleanup: + close(peak_fd); + if (!fd2_closed) + close(peak_fd2); + if (!fd3_closed) + close(peak_fd3); + if (!fd4_closed) + close(peak_fd4); cg_destroy(memcg); free(memcg); @@ -817,13 +910,16 @@ static int alloc_anon_50M_check_swap(const char *cgroup, void *arg) /* * This test checks that memory.swap.max limits the amount of - * anonymous memory which can be swapped out. + * anonymous memory which can be swapped out. Additionally, it verifies that + * memory.swap.peak reflects the high watermark and can be reset. */ -static int test_memcg_swap_max(const char *root) +static int test_memcg_swap_max_peak(const char *root) { int ret = KSFT_FAIL; char *memcg; - long max; + long max, peak; + + static const char reset_string[] = "reset\n"; if (!is_swap_enabled()) return KSFT_SKIP; @@ -840,6 +936,45 @@ static int test_memcg_swap_max(const char *root) goto cleanup; } + int swap_peak_fd = cg_open(memcg, "memory.swap.peak", + O_RDWR | O_APPEND | O_CLOEXEC); + + if (swap_peak_fd == -1) + goto cleanup; + + int mem_peak_fd = cg_open(memcg, "memory.peak", O_RDWR | O_APPEND | O_CLOEXEC); + + if (mem_peak_fd == -1) + goto cleanup; + + if (cg_read_long(memcg, "memory.swap.peak")) + goto cleanup; + + if (cg_read_long_fd(swap_peak_fd)) + goto cleanup; + + /* switch the swap and mem fds into local-peak tracking mode*/ + int peak_reset = write(swap_peak_fd, reset_string, sizeof(reset_string)); + + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + if (cg_read_long_fd(swap_peak_fd)) + goto cleanup; + + if (cg_read_long(memcg, "memory.peak")) + goto cleanup; + + if (cg_read_long_fd(mem_peak_fd)) + goto cleanup; + + peak_reset = write(mem_peak_fd, reset_string, sizeof(reset_string)); + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + if (cg_read_long_fd(mem_peak_fd)) + goto cleanup; + if (cg_read_strcmp(memcg, "memory.max", "max\n")) goto cleanup; @@ -862,6 +997,61 @@ static int test_memcg_swap_max(const char *root) if (cg_read_key_long(memcg, "memory.events", "oom_kill ") != 1) goto cleanup; + peak = cg_read_long(memcg, "memory.peak"); + if (peak < MB(29)) + goto cleanup; + + peak = cg_read_long(memcg, "memory.swap.peak"); + if (peak < MB(29)) + goto cleanup; + + peak = cg_read_long_fd(mem_peak_fd); + if (peak < MB(29)) + goto cleanup; + + peak = cg_read_long_fd(swap_peak_fd); + if (peak < MB(29)) + goto cleanup; + + /* + * open, reset and close the peak swap on another FD to make sure + * multiple extant fds don't corrupt the linked-list + */ + peak_reset = cg_write(memcg, "memory.swap.peak", (char *)reset_string); + if (peak_reset) + goto cleanup; + + peak_reset = cg_write(memcg, "memory.peak", (char *)reset_string); + if (peak_reset) + goto cleanup; + + /* actually reset on the fds */ + peak_reset = write(swap_peak_fd, reset_string, sizeof(reset_string)); + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + peak_reset = write(mem_peak_fd, reset_string, sizeof(reset_string)); + if (peak_reset != sizeof(reset_string)) + goto cleanup; + + peak = cg_read_long_fd(swap_peak_fd); + if (peak > MB(10)) + goto cleanup; + + /* + * The cgroup is now empty, but there may be a page or two associated + * with the open FD accounted to it. + */ + peak = cg_read_long_fd(mem_peak_fd); + if (peak > MB(1)) + goto cleanup; + + if (cg_read_long(memcg, "memory.peak") < MB(29)) + goto cleanup; + + if (cg_read_long(memcg, "memory.swap.peak") < MB(29)) + goto cleanup; + if (cg_run(memcg, alloc_anon_50M_check_swap, (void *)MB(30))) goto cleanup; @@ -869,9 +1059,29 @@ static int test_memcg_swap_max(const char *root) if (max <= 0) goto cleanup; + peak = cg_read_long(memcg, "memory.peak"); + if (peak < MB(29)) + goto cleanup; + + peak = cg_read_long(memcg, "memory.swap.peak"); + if (peak < MB(29)) + goto cleanup; + + peak = cg_read_long_fd(mem_peak_fd); + if (peak < MB(29)) + goto cleanup; + + peak = cg_read_long_fd(swap_peak_fd); + if (peak < MB(19)) + goto cleanup; + ret = KSFT_PASS; cleanup: + if (close(mem_peak_fd)) + ret = KSFT_FAIL; + if (close(swap_peak_fd)) + ret = KSFT_FAIL; cg_destroy(memcg); free(memcg); @@ -1295,7 +1505,7 @@ struct memcg_test { const char *name; } tests[] = { T(test_memcg_subtree_control), - T(test_memcg_current), + T(test_memcg_current_peak), T(test_memcg_min), T(test_memcg_low), T(test_memcg_high), @@ -1303,7 +1513,7 @@ struct memcg_test { T(test_memcg_max), T(test_memcg_reclaim), T(test_memcg_oom_events), - T(test_memcg_swap_max), + T(test_memcg_swap_max_peak), T(test_memcg_sock), T(test_memcg_oom_group_leaf_events), T(test_memcg_oom_group_parent_events),