From patchwork Sun Jul 28 23:19:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 13744108 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD7342BCF9 for ; Sun, 28 Jul 2024 23:20:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722208810; cv=none; b=iubgYavheYeaj+GdcMrLf+J7RZCvGT3/0SzMJgmCOj9fIjLhYfkae82cHP1bMNqOid92NuRM1SKTdw4HcdDJyPVzqPf+pMlQSPYO8Doy02IlwHw9+4VBsSwGG1QVFzoizkVjo/n3dsdCoFNHmjlEsKYS0ZG+nI6Btixac4CG0iY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722208810; c=relaxed/simple; bh=+dP40l89F19I3cNbdMF63OXjKsihv2/8PwPxnwj6LNc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dADBP9460cB5kQjB3NVei8o31lqNSSWtzcPlRDxZVlHMqBohTEkmrFBbU/x7/+L7zbKJbvM2io5XpZJGXDVEEiiZpXqk8FXhD+Avt4iYVzAhMYwoEfAXTTZDVSIfr7OMyByvsRaJ81PVz6jTS/eRq88T2TQ+6khpLS/rRKD6Nvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SG/vJNdi; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SG/vJNdi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722208807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=+eRbOioU+yVUzmrkos9cLIO1XQ0vF0g/0lgz70sgOCo=; b=SG/vJNdirJRnKESSxsw2RiN+IP3Z6OSpTn/ZZmBs49yqwgVr2gMfZdV5wTdyrX0gYCEs5m 7sM8yn1fjdrUwAvp6ClSv6azLtqPWOo7op37l1aRpV9uMK1Ljc874LjPT46fMzAc3Naj7A EggCh9xsriJmxtoNq00YicTB/yvKkXM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-iOgSj8Y_MjShc3QC1j1uBQ-1; Sun, 28 Jul 2024 19:20:04 -0400 X-MC-Unique: iOgSj8Y_MjShc3QC1j1uBQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-427ffa0c9c7so17804425e9.1 for ; Sun, 28 Jul 2024 16:20:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722208803; x=1722813603; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+eRbOioU+yVUzmrkos9cLIO1XQ0vF0g/0lgz70sgOCo=; b=TVv1aY7ElUM6hgv5D5LR29PS9F09ntXUExVsw05MA3SKZUFDRtqi88gpUEpETmGVAw v2+lW4UbI0k05+9hC/CdsCjmmNou8Y5Ccko/oKt1F7cbH2v02de9YOC3HnjAdc70RvW4 EY9/mFMHP+txKdFSyNE5dvxGjl2Wk68OJ1mFhlg4Jq7QbbBCLwiy0KuWO2uJR8VyFeEx sASVCTTkUq8W3r4p9Up7xAfyFDlaq7InjBiNp1q4yOc2IgFijMfiTSqXfy41ifPs7Vig XehGmypoYENPWaZzhIS/mNGInzGM4FxzzCUuEnU+rPHmFTSzAJpkiFbiHld+A1bYP1rm hzUg== X-Forwarded-Encrypted: i=1; AJvYcCWvxAmGniGVuatRzQm50Mii6o9gdT5KtkxaL9y7eT3K2txIWzYbTLhw+40TfvUxoXSKvSTaRFv6n99LWo3nrdBLh9U+MrJw X-Gm-Message-State: AOJu0Yzz5yF/U2jfadhwSYsv1z6U3NtXNmcE0tK/Bzqz5A3FUlGnhIiv 9brwQI6ZK+l7yhGU7JxjgYEPN45+JKIB7+OBsTxoYuNNNZmkJTit1hwnSp8CrWImW/HRqIUB2hI yHZjVauy13PY1BVDXJR0b5dB1atVbGL07W0haOpa+RipsjhtfME8MHg== X-Received: by 2002:a05:600c:19c8:b0:426:6fd2:e14b with SMTP id 5b1f17b1804b1-42811d8c0d7mr48465205e9.11.1722208803523; Sun, 28 Jul 2024 16:20:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJQeBFE1Ei3wW/3T05Gw1tpFuinUnNFeeMy1TSpz7EYl+J4w9ikvZ++fHV9MkZAfomQa2gNg== X-Received: by 2002:a05:600c:19c8:b0:426:6fd2:e14b with SMTP id 5b1f17b1804b1-42811d8c0d7mr48464915e9.11.1722208802271; Sun, 28 Jul 2024 16:20:02 -0700 (PDT) Received: from redhat.com ([2a0d:6fc7:55d:98c4:742e:26be:b52d:dd54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4281a26e1bcsm33145835e9.34.2024.07.28.16.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jul 2024 16:20:01 -0700 (PDT) Date: Sun, 28 Jul 2024 19:19:56 -0400 From: "Michael S. Tsirkin" To: Linus Torvalds Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, jiri@nvidia.com, jiri@resnulli.us, mst@redhat.com, quic_jjohnson@quicinc.com Subject: [GIT PULL] virtio: fixes for rc1 Message-ID: <20240728191956-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mutt-Fcc: =sent The biggest thing here is the adminq change - but it looks like the only way to avoid headq blocking causing indefinite stalls. The following changes since commit 6c85d6b653caeba2ef982925703cbb4f2b3b3163: virtio: rename virtio_find_vqs_info() to virtio_find_vqs() (2024-07-17 05:20:58 -0400) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 6d834691da474ed1c648753d3d3a3ef8379fa1c1: virtio_pci_modern: remove admin queue serialization lock (2024-07-17 05:43:21 -0400) ---------------------------------------------------------------- virtio: fixes This fixes 3 issues: - prevent admin commands on one VF blocking another: fixes a huge scalability issue with large # of VFs - correctly return error on command failure on octeon fixes a corruption if any commands fail - fix modpost warning when building virtio_dma_buf harmless, but the fix is trivial Signed-off-by: Michael S. Tsirkin ---------------------------------------------------------------- Dan Carpenter (1): vdpa/octeon_ep: Fix error code in octep_process_mbox() Jeff Johnson (1): virtio: add missing MODULE_DESCRIPTION() macro Jiri Pirko (13): virtio_pci: push out single vq find code to vp_find_one_vq_msix() virtio_pci: simplify vp_request_msix_vectors() call a bit virtio_pci: pass vector policy enum to vp_find_vqs_msix() virtio_pci: pass vector policy enum to vp_find_one_vq_msix() virtio_pci: introduce vector allocation fallback for slow path virtqueues virtio_pci_modern: treat vp_dev->admin_vq.info.vq pointer as static virtio: push out code to vp_avq_index() virtio_pci: pass vq info as an argument to vp_setup_vq() virtio: create admin queues alongside other virtqueues virtio_pci_modern: create admin queue of queried size virtio_pci_modern: pass cmd as an identification token virtio_pci_modern: use completion instead of busy loop to wait on admin cmd result virtio_pci_modern: remove admin queue serialization lock drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 2 +- drivers/virtio/virtio.c | 28 +---- drivers/virtio/virtio_dma_buf.c | 1 + drivers/virtio/virtio_pci_common.c | 192 ++++++++++++++++++++++++++------- drivers/virtio/virtio_pci_common.h | 16 +-- drivers/virtio/virtio_pci_modern.c | 161 +++++++++++++-------------- include/linux/virtio.h | 3 + include/linux/virtio_config.h | 4 - 8 files changed, 243 insertions(+), 164 deletions(-)