From patchwork Thu Aug 16 11:57:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 10567365 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8CE9F15E2 for ; Thu, 16 Aug 2018 11:58:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79F292A85C for ; Thu, 16 Aug 2018 11:58:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BD1F2A803; Thu, 16 Aug 2018 11:58:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 094442A803 for ; Thu, 16 Aug 2018 11:58:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F6DF6B0010; Thu, 16 Aug 2018 07:58:02 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2A7936B0266; Thu, 16 Aug 2018 07:58:02 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BE4B6B0269; Thu, 16 Aug 2018 07:58:02 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f71.google.com (mail-pl0-f71.google.com [209.85.160.71]) by kanga.kvack.org (Postfix) with ESMTP id D229A6B0010 for ; Thu, 16 Aug 2018 07:58:01 -0400 (EDT) Received: by mail-pl0-f71.google.com with SMTP id 90-v6so2582550pla.18 for ; Thu, 16 Aug 2018 04:58:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :from:date:message-id:mime-version:content-transfer-encoding; bh=z4ISglmvZsnMeQ8uupd/xNKZbvpzxgjmittzNXx3Dw0=; b=FYC5QZVOEPuoaJi+uCEkgjLL16SYuJrqHFuZY+x3UL5EzSB8z13ZOewoYE+pkojTgk GoKDHyEcjfGnYQkKus85rcCmdAZOvmg/r3KLVvEe0Qdjo9KCUI3hKc8pBxuCLdm2yy8q 4VRRzuNbTbXjB0tW6AJ7Tm0CfCvm6q9/zGIXkSrpR9oz7x3Wr4dfz+qj48rKnrY4ZduP k/YRC8mI99W5XDDtkXxPrVuPVu8r3tv0EDFDbSWQN/97NTwWFmjwl/yI1VWUssyc+01F 3KCUg0+EHE9LmRp1YRiVD9gjFEaj/rFAF8Og5sm79etbe9kRBOUOL3CWM4gwvF9iU8hD HqYw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Gm-Message-State: AOUpUlFbqgLpODlnCiilMgAy4vrdFFIMZMKeNuE5KcWC1ZR2QY1NdcYD E05GijJEHHMAcl4nP4UWcWaciuoIP15WmCGgjIkmsnMFYSdx95dYBG8ZrJ/B5VLa87e9OlY6n4e zrughjj6ixKKakq42vH6jmoJeBssqes9UBKgpL6lujf0P5WJO8Va/LvUpURKO50nl1w== X-Received: by 2002:a63:f18:: with SMTP id e24-v6mr29006683pgl.320.1534420681525; Thu, 16 Aug 2018 04:58:01 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwwXAQBKAToiDzr7HrMZu41md4EtxtOfO8xBhHnk1Oorxz7Vb9UsR0IbrhEfbM32NZ2g6JN X-Received: by 2002:a63:f18:: with SMTP id e24-v6mr29006622pgl.320.1534420680901; Thu, 16 Aug 2018 04:58:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534420680; cv=none; d=google.com; s=arc-20160816; b=HNd2u/47gok+54RZs+3AsuvYHAEF+uQbb1uyiAl0UguBszQ6AaSEgCgEVYUmi5Vfww OyTjxctv+qJxCrlDK5h4zhBob1xSV+yMQ3rxcR4GHn3i6QnfedjeSefG6+PmxoYbo4Fk q+lOIOOV7RohqPeefOnWUpwPvYuWMSWZ+GKD4oQ1rwSC+DDMhsu3z3pU9blswTmxBLjI xDaQoMT2+w+l1F+Byzsk/ZCKdd0AHUAYHSxOU6yeIxePsq4c9IbG2GcX31wqRrRkIg3q mI87QVcnxp5CbQrk04cr+009lPp22jEr4V4De1p9ypY/PScf0O7+tISAD69S6bY1Ipev S7+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:from:cc:to :subject:arc-authentication-results; bh=z4ISglmvZsnMeQ8uupd/xNKZbvpzxgjmittzNXx3Dw0=; b=ingXx137iGxzUhCWhLwVs1ieyhyaUIv1x/GDuksm2tJdqIllJc2KFMXFmqRxDhQmR0 rUQjXBCYbaz7YYCjQPPHXGHPT0cZMlT12u8zR9JsuARk6TdJfdFt09Gtq3y68WUMb2Vs qFXXyKv8QS7toQSjoPPLG6h9401ka/BGOu6WpVyPBGxEHQ+DLdDGGH6dYryQZYXBvFpY KO6OwMP023lPSubVRLvMl1/ejPYNL+Q4sn91x2DN8E+y9qQmCxtJ8L4tAPDzyVEtcJ6T haDU6vBBxglvXYEPGH5VhkS10Y3qi4PSeNozGuAXG5I6saK2uQ5nhX2Fwcqks2e3Kys6 hg0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id t18-v6si25440090pga.301.2018.08.16.04.58.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Aug 2018 04:58:00 -0700 (PDT) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 2DBA4C19; Thu, 16 Aug 2018 11:58:00 +0000 (UTC) Subject: Patch "x86/mm: Disable ioremap free page handling on x86-PAE" has been added to the 4.4-stable tree To: 20180627141348.21777-2-toshi.kani@hpe.com,akpm@linux-foundation.org,cpandya@codeaurora.org,gregkh@linuxfoundation.org,hpa@zytor.com,joro@8bytes.org,linux-arm-kernel@lists.infradead.org,linux-mm@kvack.org,mhocko@suse.com,tglx@linutronix.de,toshi.kani@hpe.com Cc: From: Date: Thu, 16 Aug 2018 13:57:49 +0200 Message-ID: <1534420669170195@kroah.com> MIME-Version: 1.0 X-stable: commit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This is a note to let you know that I've just added the patch titled x86/mm: Disable ioremap free page handling on x86-PAE to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-mm-disable-ioremap-free-page-handling-on-x86-pae.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. From f967db0b9ed44ec3057a28f3b28efc51df51b835 Mon Sep 17 00:00:00 2001 From: Toshi Kani Date: Wed, 27 Jun 2018 08:13:46 -0600 Subject: x86/mm: Disable ioremap free page handling on x86-PAE From: Toshi Kani commit f967db0b9ed44ec3057a28f3b28efc51df51b835 upstream. ioremap() supports pmd mappings on x86-PAE. However, kernel's pmd tables are not shared among processes on x86-PAE. Therefore, any update to sync'd pmd entries need re-syncing. Freeing a pte page also leads to a vmalloc fault and hits the BUG_ON in vmalloc_sync_one(). Disable free page handling on x86-PAE. pud_free_pmd_page() and pmd_free_pte_page() simply return 0 if a given pud/pmd entry is present. This assures that ioremap() does not update sync'd pmd entries at the cost of falling back to pte mappings. Fixes: 28ee90fe6048 ("x86/mm: implement free pmd/pte page interfaces") Reported-by: Joerg Roedel Signed-off-by: Toshi Kani Signed-off-by: Thomas Gleixner Cc: mhocko@suse.com Cc: akpm@linux-foundation.org Cc: hpa@zytor.com Cc: cpandya@codeaurora.org Cc: linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org Cc: stable@vger.kernel.org Cc: Andrew Morton Cc: Michal Hocko Cc: "H. Peter Anvin" Cc: Link: https://lkml.kernel.org/r/20180627141348.21777-2-toshi.kani@hpe.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/mm/pgtable.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) Patches currently in stable-queue which might be from toshi.kani@hpe.com are queue-4.4/x86-mm-disable-ioremap-free-page-handling-on-x86-pae.patch --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -676,6 +676,7 @@ int pmd_clear_huge(pmd_t *pmd) return 0; } +#ifdef CONFIG_X86_64 /** * pud_free_pmd_page - Clear pud entry and free pmd page. * @pud: Pointer to a PUD. @@ -723,4 +724,22 @@ int pmd_free_pte_page(pmd_t *pmd) return 1; } + +#else /* !CONFIG_X86_64 */ + +int pud_free_pmd_page(pud_t *pud) +{ + return pud_none(*pud); +} + +/* + * Disable free page handling on x86-PAE. This assures that ioremap() + * does not update sync'd pmd entries. See vmalloc_sync_one(). + */ +int pmd_free_pte_page(pmd_t *pmd) +{ + return pmd_none(*pmd); +} + +#endif /* CONFIG_X86_64 */ #endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */