From patchwork Tue Jul 30 07:22:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= X-Patchwork-Id: 13746845 Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D288D18754F; Tue, 30 Jul 2024 07:22:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.252.153.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722324129; cv=none; b=rt11w4yIfT9YAaIWcgZ3VYBEoI4kZRPgsVCSYNYTTVHZo3QvN0QMJ2m2zYGiWmVZti2u6XUiK/0gnkyHajriqUiYLeeDE3bdxy7GHdIooSXkLdbkYopqJ8gif9yxUseyjSD6kY+kntSXI6Hfo2HVTI0ibWLJJbFoNN5UKHK+iLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722324129; c=relaxed/simple; bh=k6u1msdn4xjaBh51mVpqy52CCsPFga4yXT58BzIXQS0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=Ms4oe5Cw+N3YJAu4hnhWOgku/TTgZpwVgCamIKLW2mPCElsyGLIe8E40tz2whRVLZHE0avduPiAamq64sMGAky4ExmUP2LIMg2DlTJ+sZWfA4SqDYOfDW8V9sAnDOA4RS9vdTtNH2lyIzwD/jMx4uAQKhnyQWm/xuYASd9G4NvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net; spf=pass smtp.mailfrom=riseup.net; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b=BePqTENv; arc=none smtp.client-ip=198.252.153.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riseup.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b="BePqTENv" Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx0.riseup.net (Postfix) with ESMTPS id 4WY69q0hXvz9tMg; Tue, 30 Jul 2024 07:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1722324127; bh=k6u1msdn4xjaBh51mVpqy52CCsPFga4yXT58BzIXQS0=; h=From:To:Cc:Subject:Date:From; b=BePqTENvcK8hXiemprWsGoOj0b0WnQJQhysvzjfZ/orTuW+IK8Va33nX7p7aOH6Oa 1hKZlqSXFEN84HPRq95ZGkUwH/EPjMtqPRKodtGUpiT0LiOlWc1CysfcwuSD7j55BK 6y9Iv7OuAT8fG0UfzmDvr0/Q3MW9LXIvX5r53Tm4= X-Riseup-User-ID: 2F20839050D65C01DC730B48ADB22AFA65990E70D5E6AA7E08C6B97C322414F9 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4WY69p0rttzFtgM; Tue, 30 Jul 2024 07:22:05 +0000 (UTC) From: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= To: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: helen.koike@collabora.com, ~lkcamp/patches@lists.sr.ht Subject: [PATCH 1/2] [PATCH v1] staging: media: sdis: move open brace to a new line Date: Tue, 30 Jul 2024 16:22:03 +0900 Message-Id: <20240730072204.989633-1-santiagorr@riseup.net> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fix checkpatch error "ERROR: open brace '{' following function definitions go on the next line" in sdis_1.0/ia_css_sdis.host.c:239. Signed-off-by: Santiago Ruano Rincón --- This is one of my first patches. Could you please tell me if is there anything wrong with it? Thank you. --- --- .../atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c index bf0a768f8..cabacfc84 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c @@ -239,7 +239,8 @@ void ia_css_sdis_clear_coefficients( int ia_css_get_dvs_statistics( struct ia_css_dvs_statistics *host_stats, - const struct ia_css_isp_dvs_statistics *isp_stats) { + const struct ia_css_isp_dvs_statistics *isp_stats) +{ struct ia_css_isp_dvs_statistics_map *map; int ret = 0; From patchwork Tue Jul 30 07:22:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= X-Patchwork-Id: 13746846 Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9E3118FDB9; Tue, 30 Jul 2024 07:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.252.153.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722324132; cv=none; b=m2a63YAeJdQiMeUlzKUwQNigP6LAy37B3pCfIxxNiOoelJhzhxw9WH7qaNsZObxi21cknVe6tiS9MHfpDZpWNHUMm3zydH4kV2HZGUOxRVQWQg5pl8Yst0WeBvWyeB6RM5SbTbSJCyzh1N6GgibXGFyJjnoiMAfRyUnwAUnDt+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722324132; c=relaxed/simple; bh=IN0HWJHUttJgKzmbuBRdQBSALWkp3yw0kKtP0uBLjb4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=PR7vC75EUmOFAyyuNkelqepFwBAA6k9KpCcW4AhfwkjXgghh5sUsOlLP/h6ZtmwsA+ytDt7XyiUtqMhgSoHWkbZ/arKvS9ZH33hQ2ydsZFjVsS6AA+Q1DjEMamq4N+gfJw6azvNhKdo2AonQx+fOASL1GNMu9OU+F1d1z3V3Y+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net; spf=pass smtp.mailfrom=riseup.net; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b=iCZ7NFbF; arc=none smtp.client-ip=198.252.153.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riseup.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b="iCZ7NFbF" Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4WY69t1vZXzDqQ0; Tue, 30 Jul 2024 07:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1722324130; bh=IN0HWJHUttJgKzmbuBRdQBSALWkp3yw0kKtP0uBLjb4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iCZ7NFbFedWyJiauzUfXftf8EgKQnzi60m8ybsVGQwBAKjzJi2WXe+3td2CrlF2mV ncU1zt9uTV2/PxA3coi8k7NllpZkjmOIK/UygVqaTtgm8o7vOA084ydb22wn2037kn 2B5qOGMdz5B0ZayXT/jxstnCw2dE4i+uNNWjY8KM= X-Riseup-User-ID: C22EFBD79D4794DCDD84B52A23D721205AECDBE08D8E5A569EA1E03EED89DF0A Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4WY69s3HFSzFtgM; Tue, 30 Jul 2024 07:22:09 +0000 (UTC) From: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= To: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: helen.koike@collabora.com, ~lkcamp/patches@lists.sr.ht Subject: [PATCH 2/2] [PATCH v1] staging: media: sdis: move open braces to the previous line Date: Tue, 30 Jul 2024 16:22:04 +0900 Message-Id: <20240730072204.989633-2-santiagorr@riseup.net> In-Reply-To: <20240730072204.989633-1-santiagorr@riseup.net> References: <20240730072204.989633-1-santiagorr@riseup.net> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fix checkpatch error "ERROR: that open brace { should be on the previous line" in ia_css_sdis.host.c:253 and :258. Signed-off-by: Santiago Ruano Rincón --- This is one of my first patches. Could you please if is there anything wrong with it? Thank you --- --- .../pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c index cabacfc84..467572d84 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c @@ -250,13 +250,11 @@ ia_css_get_dvs_statistics( assert(isp_stats); map = ia_css_isp_dvs_statistics_map_allocate(isp_stats, NULL); - if (map) - { + if (map) { hmm_load(isp_stats->data_ptr, map->data_ptr, isp_stats->size); ia_css_translate_dvs_statistics(host_stats, map); ia_css_isp_dvs_statistics_map_free(map); - } else - { + } else { IA_CSS_ERROR("out of memory"); ret = -ENOMEM; }