From patchwork Wed Jul 31 16:21:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13748954 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0238CC3DA64 for ; Wed, 31 Jul 2024 16:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=WMehmwAmU1991OM64djKNhA6gD/SUdsp7kAsnQKpIi4=; b=yUkU0GgMCfX1XzzFHZJLrBet9i 4c0folFwaOLT4uvxPwZP2akHU1eb/x1Xj++q9/3S7y4Fl8czkqRFnf7IX7M3jxrnyMsYerV6WSOgP 2om5Q1GrqJeLTNUzT36YmRnTnBwO0bACIC8g416STtlP9CobxRWyiPftLmig87CKYmy1LrAgHWSUH hMFhdM2rwiawu7rgkZ5gqaNP2sH4y+nydp85rY5pO4BYp6rwxiXjrsfcPWJCSiKUWDuWCIXC0KRhw ZWclFOXQ86ydh7gzELGJr3QQQ1Llrl1JAtfV8NV8rV3Qs/sFSdmoQYdhYOxuRQRHWkRL0SDKsiA7R lB1gX/bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZC6G-00000001qjr-0ssd; Wed, 31 Jul 2024 16:22:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZC5m-00000001qdt-3z0h for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 16:22:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 189B06252E; Wed, 31 Jul 2024 16:22:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FC3EC116B1; Wed, 31 Jul 2024 16:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722442941; bh=4xS0pD2n/vpTAJI9k2seY/mT9WcQsaPxpoFu1kzIwSY=; h=From:Date:Subject:To:Cc:From; b=C2MBkEavnwa7rJ0kZ6GI52VlH99xH0jl9GgQckr4U22QF1wbaiyYfZS2iN4ZFMVPo 3q39Q5+M5eeaEBGfXwDM/YBr8h61g4cd+XHy3ibH7EWN3WEvp0EkeCOmfVzh+0Mcnh AT6hJ/Io+sUULd9tDslVf+aTTDWJKHB4dtXpsKep8+nIB/+9e+AspZiFJ0ONroji50 BKnBXAPFJ7PdKYoswBaWwFj1nHzFWHBDSiKd5D8mhpdtmAu+yNhxKdmnOFpchzqzbB 6oPhsqyb/l9AOyVmJhcXk2kjTNQGwQqGOJ4FPn01qBt3fJKw8J2FCZEhVen4ShKzGE WcxzWG4VQZMAg== From: Mark Brown Date: Wed, 31 Jul 2024 17:21:13 +0100 Subject: [PATCH] KVM: selftests: arm64: Correct feature test for S1PIE in get-reg-list MIME-Version: 1.0 Message-Id: <20240731-kvm-arm64-fix-s1pie-test-v1-1-a9253f3b7db4@kernel.org> X-B4-Tracking: v=1; b=H4sIAHlkqmYC/x2MSQqAMAwAvyI5G2i1WvEr4qHVqEFcaESE4t8tH gdmJoJQYBJoswiBbhY+9gQ6z2BY3D4T8pgYClUYZUuN672hC1ttcOIHRZ9MeJFc6IzytaeqGa2 HlJ+BkvGvu/59P+CCE1pqAAAA To: Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Paolo Bonzini , Shuah Khan , Catalin Marinas , Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-37811 X-Developer-Signature: v=1; a=openpgp-sha256; l=1222; i=broonie@kernel.org; h=from:subject:message-id; bh=4xS0pD2n/vpTAJI9k2seY/mT9WcQsaPxpoFu1kzIwSY=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBmqmS6GOeWEWP62/aXDViXEkZrsrUtBn51zh/OWFiZ uDkGI/aJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZqpkugAKCRAk1otyXVSH0E06B/ 9VOmuwqQYplgVUUsHIPEJG5GVO9uTAgm62aij3o6EomU20qF9CObSRrFct3b0xaucS568Co/VI6tpp gWS3LZJAz5GqV1E1ZynABm+8i9Fo8tVfaWY/E16wv4/DSNNOYApn7+5p7p+sodTV6y2v5y4rWulO9D DnT2pOYhB6A163lBIbSdOuFoeLfDRcvA0ou2OICK3GUDa0H5993gqjVbJhh8dSmvSA43qhm6yLW7Oe qotWzu21jHfs+PPxIPBVstkTPueah2l0mESFTOOGEi7PcMIUMF7uCjrpiJZqwowtAyjyeL1Iyqcjl4 4yOCGR/2Cb/u/Y8Hf+11+sr7jTugSm X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_092223_091385_C8C4179B X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The ID register for S1PIE is ID_AA64MMFR3_EL1.S1PIE which is bits 11:8 but get-reg-list uses a shift of 4, checking SCTLRX instead. Use a shift of 8 instead. Fixes: 5f0419a0083b ("KVM: selftests: get-reg-list: add Permission Indirection registers") Signed-off-by: Mark Brown Reviewed-by: Joey Gouly --- tools/testing/selftests/kvm/aarch64/get-reg-list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b change-id: 20240731-kvm-arm64-fix-s1pie-test-a40b6be58d7b Best regards, diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c b/tools/testing/selftests/kvm/aarch64/get-reg-list.c index 709d7d721760..4abebde78187 100644 --- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c +++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c @@ -32,13 +32,13 @@ static struct feature_id_reg feat_id_regs[] = { { ARM64_SYS_REG(3, 0, 10, 2, 2), /* PIRE0_EL1 */ ARM64_SYS_REG(3, 0, 0, 7, 3), /* ID_AA64MMFR3_EL1 */ - 4, + 8, 1 }, { ARM64_SYS_REG(3, 0, 10, 2, 3), /* PIR_EL1 */ ARM64_SYS_REG(3, 0, 0, 7, 3), /* ID_AA64MMFR3_EL1 */ - 4, + 8, 1 } };