From patchwork Tue Mar 5 02:59:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10838869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1DF99922 for ; Tue, 5 Mar 2019 02:59:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0C8C2B51A for ; Tue, 5 Mar 2019 02:59:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E491D2B601; Tue, 5 Mar 2019 02:59:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7603C2B51A for ; Tue, 5 Mar 2019 02:59:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbfCEC7N (ORCPT ); Mon, 4 Mar 2019 21:59:13 -0500 Received: from mail-eopbgr130080.outbound.protection.outlook.com ([40.107.13.80]:31811 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726522AbfCEC7N (ORCPT ); Mon, 4 Mar 2019 21:59:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xzghQ45LM7IR8X+O/Hdbedq0zbq2Th6sW1GuuUa5Ups=; b=QTAAuBDUhLekhRwKzGOzeZ/VJwIuWSO3QA5ASSbYKcVSZJV5srZ7FsjyP3Tm+aq5ey/2l88dU9+fYeqy0ZImQ2f7Zl1B7PZgvIXY0jPeL9h+NZCats4zQklftgP1utYbXJJomQ/+WlAr/GKLPtWXHUnkzBts+Y1dYHSiRM9Iib8= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB2080.eurprd04.prod.outlook.com (10.166.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Tue, 5 Mar 2019 02:59:08 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1665.020; Tue, 5 Mar 2019 02:59:08 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v3 1/5] mmc: sdhci-of-esdhc: add erratum eSDHC5 support Thread-Topic: [PATCH v3 1/5] mmc: sdhci-of-esdhc: add erratum eSDHC5 support Thread-Index: AQHU0v9mTvDxH8VxJ0K7xDPa32N3+Q== Date: Tue, 5 Mar 2019 02:59:07 +0000 Message-ID: <20190305025811.38328-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ae42306-28ce-4d1a-df44-08d6a11688bf x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB2080; x-ms-traffictypediagnostic: VI1PR04MB2080: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB2080=3B23=3Ars?= =?iso-8859-1?q?dpmwzkA6JSK2JikxJ7cpabBKyhWJ4GkFPP1WRhiv9B9RW3kN8PxX7NRGCQAN?= =?iso-8859-1?q?XTTN/FmeHMqkWKcDXlxblJ448fmts98ibQ0uKeUW8UBCXvZzseVvDWNeKFO8?= =?iso-8859-1?q?IHdL9xdpe+tKGA6oLxuHdL5z3TU3RYSt4UmGJ/Sho0aK9JKW2KAPexduscey?= =?iso-8859-1?q?v+TVH8PlFi8QNVLvYHgbLNuVbCpHM2Z7Sm5+FhyzUnshtlccDxW9CpZh8Pf1?= =?iso-8859-1?q?JRXtoJ+Na5e3P0I15ljzksoVo3kEtnfDu+1D4+uhXDxkdWyxtXLGbfTPbEIR?= =?iso-8859-1?q?4voI8LPPGysSMvqvbMDYvagqWySW0BIU5Q46zvIHPcf+OFKjC+jsIbdDJYSX?= =?iso-8859-1?q?K18KEbHtaUWkOHjxUPtCi++DyoCTAvAsRPTf0re9LvcufxAqbUEIfjjNZgnH?= =?iso-8859-1?q?qPHhA+FTlisip5QECQfemPwCxadbz1GVnMtw3bXrteWS8o7NpcB0pQRgL9pe?= =?iso-8859-1?q?dpiSZjoIFsvtEwu8cySBB84LwtmPQRMkRSwy1U/NClQFqWYu3nJOjpQ5xxkT?= =?iso-8859-1?q?Vhd/n9fR35lyOHz1tHoss36ZkAC1UyIgdm1IEMaW7jh53nx5UmoBS8YkSsxP?= =?iso-8859-1?q?sBuhMbw6vkR8WzWwKe3+rc6BQkqy5cKLEtVQW2/IwzjF0s4oUi18ivx3eJ7r?= =?iso-8859-1?q?eq0+eEGgEuGrUr/drlxEuJyQpURKYP+P//776dgE7FortzYJguaEKIVC+jck?= =?iso-8859-1?q?A3znkyPulOzN7rKVWRabQRutAe9dgQutjx14WHcQPTwQdJsRn4tC/pNMB7Jl?= =?iso-8859-1?q?HApKPr/djP+AiCttIsOBOmuTcJ60/Jx+dYmD6J/R+KuJ3ownadkhePhaXkdc?= =?iso-8859-1?q?WS01Igbdo3B4kLqB5DNnCfIryvm0LH5Q0D2m0UvnJE+YjbXkM+5wuExkqsk4?= =?iso-8859-1?q?0yKx/Sy6r1rMyG8EKKVFQx4qF05Aork78CP4EMd1DevQqvlDACVYBplHRSU4?= =?iso-8859-1?q?jNtaFcM3Vwl+Ll4Rj02nq7YqocqJLCVPKP1Vw4b2O0UnbzFlv2E+Z/a1DXvf?= =?iso-8859-1?q?4VwtkqtaYpqSVeabrxU7gpOutZDEh3rmfza1dZIucXb7At6L8eDTik4rkwqe?= =?iso-8859-1?q?A6hnc9UMtVbKxtdIpp7sdJK1h1GPDcF3n2WFaz28AvgS4F/2jCOETUk4kAWY?= =?iso-8859-1?q?6sCoEkTUcp+DiUVN/bm/2WhZbz6uIJv/ggXzxMbTZ2d6dAifAjueghTYBanU?= =?iso-8859-1?q?YdEDamcGXFZFyK?= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(8676002)(305945005)(106356001)(102836004)(386003)(6506007)(99286004)(97736004)(8936002)(256004)(5660300002)(71190400001)(1076003)(14444005)(478600001)(81166006)(81156014)(7736002)(26005)(186003)(71200400001)(50226002)(6512007)(6486002)(6436002)(6116002)(53936002)(36756003)(68736007)(316002)(44832011)(2616005)(476003)(86362001)(486006)(14454004)(25786009)(52116002)(2906002)(66066001)(2501003)(54906003)(4326008)(110136005)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB2080;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /aDGqfQbIynMIKnNgHkMlPjAkDSXyJpm3BO9aE5gu06LdfzRWmDPgCwCAZgAmqSbBBjXVDrJP6K9EMr5po+oLnQ55lgMiFv2Cqeffn8FJeGhRsbkJht0162jZNVhxgD8gHEHnhpTFXPqEw8P+D+hO/fdgUgcf03XRX/aOlxofd/HhvpxJs/ttxVeLLPuoNRfzIHqRAMnpZRSlnsaE2PXHgRVM3bcdABotWQinkHV/CmG64QmLAB0iPG8Y42pdv0aOqo93jyqNUw1zeC74P4/43ET4TkK/8SZgpPwiJh4WTcMtqqfIIflXBHLrsJMqImmMeWa6VYVSZDt1/4vjoP18JT2krpd/+yzaHl1WktOxNTxGNq3/8VsE3UEbWAjoJSYuTkoc/wJvuxRKz5OXh9puLTJNdiJuB4/b3Z/MjXSJFY= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ae42306-28ce-4d1a-df44-08d6a11688bf X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 02:59:08.0225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2080 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu Software writing to the Transfer Type configuration register (system clock domain) can cause a setup/hold violation in the CRC flops (card clock domain), which can cause write accesses to be sent with corrupt CRC values. This issue occurs only for write preceded by read. this erratum is to fix this issue. Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 4e669b4..9da53e5 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -1074,6 +1074,9 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (esdhc->vendor_ver > VENDOR_V_22) host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST; + if (of_device_is_compatible(np, "fsl,p5040-esdhc") || of_device_is_compatible(np, "fsl,p5020-esdhc") || of_device_is_compatible(np, "fsl,p4080-esdhc") || From patchwork Tue Mar 5 02:59:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10838871 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 93948922 for ; Tue, 5 Mar 2019 02:59:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7DCEB2B51A for ; Tue, 5 Mar 2019 02:59:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71D7D2B601; Tue, 5 Mar 2019 02:59:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 061802B51A for ; Tue, 5 Mar 2019 02:59:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfCEC7P (ORCPT ); Mon, 4 Mar 2019 21:59:15 -0500 Received: from mail-eopbgr130080.outbound.protection.outlook.com ([40.107.13.80]:31811 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726522AbfCEC7P (ORCPT ); Mon, 4 Mar 2019 21:59:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DqCBYN/AjsXgTa22hFT6wV7K0XlozzOunnDb2D1MpFc=; b=Xw9jjO5WtgsbVCdUe1gUeBc/m00DqrNz4V46deCR6K76cgxKIIym1CcgLULHa/S8Jnb3nYrCVwRkQz7C2zac1JU3pA+lz+47pchdU7lkxLhLuMspsW7SedmYR7+GttkwZpNeshbl08M9LO2PK1+/TaqW+TVH+C20hSnoXWYTQCA= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB2080.eurprd04.prod.outlook.com (10.166.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Tue, 5 Mar 2019 02:59:11 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1665.020; Tue, 5 Mar 2019 02:59:11 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v3 2/5] mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support Thread-Topic: [PATCH v3 2/5] mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support Thread-Index: AQHU0v9ofU5GaWJyCka4t5WXv4PQ6A== Date: Tue, 5 Mar 2019 02:59:11 +0000 Message-ID: <20190305025811.38328-2-yinbo.zhu@nxp.com> References: <20190305025811.38328-1-yinbo.zhu@nxp.com> In-Reply-To: <20190305025811.38328-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f170961-3d3a-47bf-b9f6-08d6a1168b18 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB2080; x-ms-traffictypediagnostic: VI1PR04MB2080: x-microsoft-exchange-diagnostics: =?utf-8?q?1=3BVI1PR04MB2080=3B23=3AyrSioKz?= =?utf-8?q?FqU3zFfxzWATWfKAFQzt+giCXvJTrP6p2mPgMOESfvyXIG9iTZUGzrDz+eU8gtS1K?= =?utf-8?q?q6OmFh/Uj1kHU+3LRXFSv/Rumvr3p/HZYrmD8SKcULmd5qeYkoDiv+rU3uJ7qLBAS?= =?utf-8?q?dD+ZL+awtHvP3lrMrUD7QqnsMwRwVn2zK9o/SCV+1SJvbbX5xGnKvfrFE1jYIQTTT?= =?utf-8?q?vHHIzfHtvA164+iKihclMER9CJUJdZC/xCgAfvjDdfptnX60MjF/ub3e76Gi3VlPM?= =?utf-8?q?zkCo8zSFPWtBcNOBXZ6qW7tgrpjtwu4df4zwkSyQgxOg0yVyva+62z9ll1RQs8QJO?= =?utf-8?q?lIOJiEC1fCGDmExG+dFwikcwYBu5ST0ME80WvlHV+Ls7eJuht/vfQSAVssEuq9Mev?= =?utf-8?q?LGZimEieIC4aIQU9vuHMtPloP5MraxTkn6OWk3e1CH9/OfCoxj3O9OSzc4uWIAwQA?= =?utf-8?q?XaRrPTBuYLPyE7xKRN2g1Y9fZ/yDqyeGYyqLAnAMxJygVR4ueolzSc3zEYjB5CM+H?= =?utf-8?q?wyPIHEw/YsPjhw2BpcN7R48BKJi4J4E9eaqolKFbHot2CW7OXBcWfWA2p3gs3SB+f?= =?utf-8?q?/uDjYdewYHSAjvI2zt/bWrzJwv5XLeZmuESB3LHbPIBns6FhOhXdXF6f3ihXJRXg6?= =?utf-8?q?CGwyL9t6uGcgIVivky/I/HDIeL/CZzvG97ySSvzF+vF/dlhD0mBM6ciA3hvM8SDqe?= =?utf-8?q?ghERdb8oKYm+49y25w9Z/SRGLtsr/g+WrRvaZkt+Rc6MJ3bfhUAzvLD3NND5yR8Rm?= =?utf-8?q?yR7UmkAS8KZAN+WSEqlEkW+twHO1nfazzot0M2Y4nG/XgD8+yZk/fhp6Y5R7u6AIU?= =?utf-8?q?m7+bXEdLthM/PvgImEkoZWC7+SRnFvbvNtASwMFS57sZTcQlTlhP+qeMNyouWOSnD?= =?utf-8?q?jzQdIgeyVAz+z5DKyM5x+L9r3DKdkKnSBL5gitrzXPTjlzE3kvVlKBSdGIoBizzC0?= =?utf-8?q?S3bVwL+sRLZAb2YM0ldDczTwjHYWNsjWydKKubML1Z39dM6bjl5w3pvBR1rNxr9gT?= =?utf-8?q?r682HEVZW1NYX4AQ18he4L0C75xxFh1iaWUSxAAHXOWphnyTwyIm/VM3lorxUwiSW?= =?utf-8?q?KP/48hVtkO4OIUyFckF8BrYb07xR4U57h/8LktvtZVcqTfjmfWwxNd03To1lGknbR?= =?utf-8?q?S4TBR/qp+LcopEjV9JnOaKE7YJ5OTc93WheCcXfp1IWAGf9AOXxioBN187juNbf3f?= =?utf-8?q?zMQ6u6yIQ5gsIJTibzlxQqQwttIOAWQjDsT+uW?= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(8676002)(305945005)(106356001)(102836004)(386003)(6506007)(99286004)(97736004)(8936002)(256004)(5660300002)(71190400001)(1076003)(14444005)(478600001)(81166006)(81156014)(7736002)(26005)(186003)(71200400001)(50226002)(6512007)(6486002)(6436002)(6116002)(53936002)(36756003)(68736007)(316002)(44832011)(11346002)(2616005)(446003)(476003)(86362001)(486006)(76176011)(14454004)(25786009)(52116002)(2906002)(66066001)(2501003)(54906003)(4326008)(110136005)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB2080;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2RTTSGz7XrnP60EpF8SUp7lYjwPcDLwM7+PJ+WE+2aCZWtkH6/odSOhtkLCU26nqhAKf5hKCZnETPF7tzZMZOlLfH3UGNzIMCvFhF1k9OdPsmUm5GO5TUSdEc9pDL5aWSrTxUnwfnk6vUYweONqOMxbmnR+NqOoxndDmfUrSwferCQBCExrB5WkiRs08XwZiqW3C4tbnTAS8+aJ+cbDvc+LiuBW2Q49ph2TAJrwTbsPgf7CNatkkjvBOeuTEYI/rgQn98eBMFmw9GsCwFXj5omMMwQbjipPADvhm2xCkMfz6NBVG3PwMNMs3+B7ilN7RH3nCpTsA6cVEPl32tH/8qC0q9G+V165Cexr8kRJOsCRbT2yVh8Z8kKlwbrY5por+hOAW/XGevGGpRv+s5kt6FSv9W23oD5O0NuSaB6InMTo= Content-ID: <635CA44C65D9044EAD703E98915DFA81@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f170961-3d3a-47bf-b9f6-08d6a1168b18 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 02:59:11.7091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2080 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu eSDHC-A001: The data timeout counter (SYSCTL[DTOCV]) is not reliable for DTOCV values 0x4(2^17 SD clock), 0x8(2^21 SD clock), and 0xC(2^25 SD clock). The data timeout counter can count from 2^13–2^27, but for values 2^17, 2^21, and 2^25, the timeout counter counts for only 2^13 SD clocks. A-008358: The data timeout counter value loaded into the timeout counter is less than expected and can result into early timeout error in case of eSDHC data transactions. The table below shows the expected vs actual timeout period for different values of SYSCTL[DTOCV]: these two erratum has the same quirk to control it, and set SDHCI_QUIRK_RESET_AFTER_REQUEST to fix above issue. Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 9da53e5..1ac1133 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -1074,8 +1074,10 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (esdhc->vendor_ver > VENDOR_V_22) host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; - if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) { host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST; + host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; + } if (of_device_is_compatible(np, "fsl,p5040-esdhc") || of_device_is_compatible(np, "fsl,p5020-esdhc") || From patchwork Tue Mar 5 02:59:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10838873 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 84BF11803 for ; Tue, 5 Mar 2019 02:59:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 720AF2B51A for ; Tue, 5 Mar 2019 02:59:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 664A02B601; Tue, 5 Mar 2019 02:59:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD9592B51A for ; Tue, 5 Mar 2019 02:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbfCEC7U (ORCPT ); Mon, 4 Mar 2019 21:59:20 -0500 Received: from mail-eopbgr130053.outbound.protection.outlook.com ([40.107.13.53]:63618 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726522AbfCEC7U (ORCPT ); Mon, 4 Mar 2019 21:59:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ESiUvGjPNFyrMJUYQEMnMILGAd0pInvq06RuX4rUJVE=; b=CkpGwkolMbEoy13jfkQ9QkJ8hosBJaVuk3nG0m+EAy1ETsbtBtlyO1mjeuuWR13wpdjm5AfjrjWz2ZmDuUNYv3dgFa5pGlUCLUKtCl3HhnzP9JBSFUObJl7eixE2C7KCK5ZbNMsBtLWlFQFJ8xYf+5c7e8ZkYwhj77GzFPDXxio= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB2080.eurprd04.prod.outlook.com (10.166.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Tue, 5 Mar 2019 02:59:16 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1665.020; Tue, 5 Mar 2019 02:59:16 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v3 3/5] mmc: sdhci-of-esdhc: add erratum A-009204 support Thread-Topic: [PATCH v3 3/5] mmc: sdhci-of-esdhc: add erratum A-009204 support Thread-Index: AQHU0v9rcXDxR6sw4UqWbXyq+1TxXg== Date: Tue, 5 Mar 2019 02:59:16 +0000 Message-ID: <20190305025811.38328-3-yinbo.zhu@nxp.com> References: <20190305025811.38328-1-yinbo.zhu@nxp.com> In-Reply-To: <20190305025811.38328-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1d37a58b-d99d-4317-f09a-08d6a1168dda x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB2080; x-ms-traffictypediagnostic: VI1PR04MB2080: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB2080=3B23=3AfA?= =?iso-8859-1?q?YbZ1p/6wfvWtE3z2jaAKKrE4WJMuUVo9mKoBHQO51dp6N6D6++GxbqjRgvx/?= =?iso-8859-1?q?n7+APQjaaqO9hs0dLm3hjfCD4inxN3PCnEyKHPyBcyL8MtiffJs69g1w8oJ+?= =?iso-8859-1?q?AI/CJjcwxXuWOEwpTIoEry+bHW2k9paP7lxvFinXRwS5pHDkAjAU7aGRr343?= =?iso-8859-1?q?au1ob6gdRk6SO1Qs/TDAd7pf1+GHaMaF0IDYkssYpA4Js4724Ch+xcOCQ5Aa?= =?iso-8859-1?q?GNY7PqGRoMbmrl8NaYJNprBLl1NGsWmo693J/ZR0etoPFDyja7VipAN+V8Uu?= =?iso-8859-1?q?oD3iIP1qcNHZHsCZDkNgvj9jolxasV6lOebK+kEtwLJtDoGs+kJSaWIpn+vE?= =?iso-8859-1?q?2RUolaKENQ5v3AUDznPHPNx1V3daYxqX1qALWZRVIUdXxklHkgqmB7AueYOp?= =?iso-8859-1?q?n8L5xe+volSDoam7muJwQXjm77yB04WDrqr4iCQWHouv98tsljJU6TOoamSC?= =?iso-8859-1?q?kswH2cV/lWk52IyLkKUJEf4QLMEFpxMZkLjI6KSGelRzu2g6muu7Dd+9WsCX?= =?iso-8859-1?q?0moZBQBitMt/d25SbpNKv27f593Nwos4/x4g2xSU2/UfuZjVR8JyHX80VeC6?= =?iso-8859-1?q?BKHnxnrjncQ72BMdVwQZSCdr2C9ebQEg/2SH5Y9x55EZ7WiRDS7MTSeKFu3b?= =?iso-8859-1?q?8uAYVCfr9CgioXVaa1C/R58Qtj6o36dJjjg4tnDjo+af8XelGNwW7lrbCnsp?= =?iso-8859-1?q?38VhPzFyX/lUBWlvosy7S0A7AuS3myAhGsXhBmQaP3cO/ZfVFRM5S0pn78jp?= =?iso-8859-1?q?TzUuVvfHyVzlOXPAmvHJ5oMZp1XKgO0NJm9mB6Mrdv5ru2SeTBNHvV+EEiVO?= =?iso-8859-1?q?gL7cRarByzu20QP8qLkkKqgxe8/qSt+PKGVYi0M5c568StYNsd81GRN5CbHn?= =?iso-8859-1?q?gSRjJ7VfwPAsnhm5S13TcGgyqvLyWtqn1uslGUX8uj1tRxMV0lejYbwWB4TM?= =?iso-8859-1?q?LON7gcgRxot9jlda5vwyJMLr8YChjCf3YQDtHjmU+I490iSreONFIPexZqI8?= =?iso-8859-1?q?7Yj3YPLx5cAsK8LkL9R17Qsrsgo1MXCoK5+pDYhq3KT2RljR8s2ZMTaAqAhG?= =?iso-8859-1?q?t8JP+Z3uPoixev3HZv/6ky8ieebcTDJMn5VyjTvh7k2hpYRSmX2nVLfU3Bt5?= =?iso-8859-1?q?ybuWjwO5x9EUFFZb8rFLMiNPPaLbZOOQgTXjH2ES1xentewyZ4cRoG3cXUsJ?= =?iso-8859-1?q?BRA8BSu8M3Y40F+5RRTDBngnTtIVL/AlvM5Hb4jnWKGLg98RsGheBAN1DFAP?= =?iso-8859-1?q?/oRvq0Cof9ZH5hQ3c5?= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(8676002)(305945005)(106356001)(102836004)(386003)(6506007)(99286004)(97736004)(8936002)(256004)(5660300002)(71190400001)(1076003)(14444005)(478600001)(81166006)(81156014)(7736002)(26005)(186003)(71200400001)(50226002)(6512007)(6486002)(6436002)(6116002)(53936002)(36756003)(68736007)(316002)(44832011)(11346002)(2616005)(446003)(476003)(86362001)(486006)(76176011)(14454004)(25786009)(52116002)(2906002)(66066001)(2501003)(54906003)(4326008)(110136005)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB2080;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jTiWw8NSqjInJf/O44FPxlFb18AAjcc2FuTTqO1Y9YNKWHT6ORbNyVYxcia7Vr4MhyVF1qmafI2GLWm9Oghl8Vb33C6DM0zcsAwIEOQ6fBtXJH7+n7TVe30MGxQYnQnefTJgoP2FoGu6+YIiX+ecKZ1SrXumG+TI9HBKFQvW8SjC8tz5ZXmCWgaUrOu57R6zDC77iLXg4GkffO7H4Y1NsG7fxSVA/DwV8tva76tZUSasHEMtNHjdmNkJeu8JNQ/uXDsejryv7RaIspLyqCW3IowhbByTPW03/soyHrmn83t/i7fegwGDyAkGUgMoQ7eyAyzHUStaZu5dyxvNwdChX+L3cqEHVe3N22cYrTBCT5BIJJI3/ob5gtw4wN7B0GB21XVn5FVO10McKtRIiWfgKDYW5PT9KjV93P5I/8fbmP4= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d37a58b-d99d-4317-f09a-08d6a1168dda X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 02:59:16.5725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2080 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu In the event of that any data error (like, IRQSTAT[DCE]) occurs during an eSDHC data transaction where DMA is used for data transfer to/from the system memory, setting the SYSCTL[RSTD] register may cause a system hang. If software sets the register SYSCTL[RSTD] to 1 for error recovery while DMA transferring is not complete, eSDHC may hang the system bus. This happens because the software register SYSCTL[RSTD] resets the DMA engine without waiting for the completion of pending system transactions. This erratum is to fix this issue. Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 1ac1133..7e0eae8 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -694,6 +694,9 @@ static void esdhc_reset(struct sdhci_host *host, u8 mask) sdhci_writel(host, host->ier, SDHCI_INT_ENABLE); sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE); + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + mdelay(5); + if (mask & SDHCI_RESET_ALL) { val = sdhci_readl(host, ESDHC_TBCTL); val &= ~ESDHC_TB_EN; From patchwork Tue Mar 5 02:59:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10838875 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4D491803 for ; Tue, 5 Mar 2019 02:59:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8F5192B802 for ; Tue, 5 Mar 2019 02:59:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80C292B819; Tue, 5 Mar 2019 02:59:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22F152B802 for ; Tue, 5 Mar 2019 02:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfCEC72 (ORCPT ); Mon, 4 Mar 2019 21:59:28 -0500 Received: from mail-eopbgr130087.outbound.protection.outlook.com ([40.107.13.87]:17454 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726522AbfCEC72 (ORCPT ); Mon, 4 Mar 2019 21:59:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3R+I4dpla92W1DihMZ2hXK/r8vLPjR/WNDaY4hoN2M=; b=Duwqzu6yrzmtKn9q/G5H+GxUOYGVKWnmY06QTeTjNccIKqkyRUohcE37uY5F8uPigUzA+BiSkfYcNXJoodwn55TGq6v+jFlUZR+35C2oxOFcDZbfhtxoraTQC+hmKS84mQI65KKaRSJRXy6jwZO5SjRFQhYJD0VnvTPaxRFGO6o= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB2080.eurprd04.prod.outlook.com (10.166.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Tue, 5 Mar 2019 02:59:21 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1665.020; Tue, 5 Mar 2019 02:59:21 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v3 4/5] mmc: sdhci-of-esdhc: add erratum eSDHC7 support Thread-Topic: [PATCH v3 4/5] mmc: sdhci-of-esdhc: add erratum eSDHC7 support Thread-Index: AQHU0v9uZawGZYBqK0y/9xgBPz8pAw== Date: Tue, 5 Mar 2019 02:59:21 +0000 Message-ID: <20190305025811.38328-4-yinbo.zhu@nxp.com> References: <20190305025811.38328-1-yinbo.zhu@nxp.com> In-Reply-To: <20190305025811.38328-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 168d669f-5f94-429c-29ad-08d6a116910c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB2080; x-ms-traffictypediagnostic: VI1PR04MB2080: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB2080=3B23=3AIi?= =?iso-8859-1?q?GXrgWugCRTEfBMDhswAuANL37WAz9Ct4chMXp/XdZHX0dxrUUD7yCQkSfmXZ?= =?iso-8859-1?q?q/WA43UpUY4lyzZ3QkB15puEE0MHbRQqUbxa/MvGJNEBo/bJPyMXsMcb9mct?= =?iso-8859-1?q?CBQwGrB1W0uv6ITXz+CTL82P3OWNRkagcBmdhdJPyGnEzuXZ7kGNSVy4rWDL?= =?iso-8859-1?q?qGKKm38HEuAaSnPr3NXm3nk9VHZ3cN9B5dNwVla5VezUT6bZWuCAyzUdNG8G?= =?iso-8859-1?q?8hZ9kbO4/OYJ92Pgz1IY/jT1Dj4BF8gsVhpgoRCHVvZRVdD43jo07x/5hdHs?= =?iso-8859-1?q?Rrv1nsUv30DkM8pgqFnUwGs65BHjzCPYmJ3cocKOPYO6UIIu4dhDZaICHcP8?= =?iso-8859-1?q?P0vD7btSvnFGRfNGhHEw3lhKxRYWeb/u0vV79lTqXcFIwJyd0dF85t9/Rx1k?= =?iso-8859-1?q?6CuxygYoo8A1WSWkMnKIJI2Bu9xm/1GTuTkUfT0dQDUwixYrl8EzrZ3FesTn?= =?iso-8859-1?q?dv4y6gqa1iS4ksA5PGw1U7/x/96Y+XM/FjpTQinNaQUm9lpFpYc/qX7xEGKe?= =?iso-8859-1?q?5V0+xsPG2ZUdh6SPYX7U0PpFZ/ANl+248UNoAzYDJWQJPUtUDoKgrymHlpFU?= =?iso-8859-1?q?MjfGGBC0HQeG46HCpY8K4/uwW4xCQiqIXO7btrjW3mOJVR8LgyMuAgR2XMYn?= =?iso-8859-1?q?IIjLJuEuLpZUbBg7RPaPb5On665GcZGTWDzX/pLeY0n0zo0Qsz53WCf4xkX/?= =?iso-8859-1?q?UOMtM6gZ1e//ABNASfXB+UpQ17+kUkqn8RleplsYY77b9M/uiNShDqCYnNKE?= =?iso-8859-1?q?3UvUrX2ox9cHuokUm0Rqm1eLuF1V87y8xrJfaTWXBopRxw3NNzW/B+ZMsfiz?= =?iso-8859-1?q?holE5fkCl/aSkb4+PE70HqHepVRL2p0iWJgIemnA2XM44TIXlxb4YjW0l4Vk?= =?iso-8859-1?q?eZn9a02YDtiyxRsByMtQ3rSalUZUwhWxE3igOzz+6Q/emqoj9IB98CGGt45x?= =?iso-8859-1?q?QOJOeIUeBJPguvh6iD4jxkPhGEEwK2X8aNwQpAM5Ugh/xAMwby0KtxcJLu2O?= =?iso-8859-1?q?nmXYbYkGsci09flAe0vc/3nzn4db4B4Mhz4fvHBVBWe8SIsmIYKz9b2TX7US?= =?iso-8859-1?q?TLgtHQHZj/IB2otkRNjQHWkxNIgsIzXeObS41NZAKFWaZaAcK4tYYUN+7BWB?= =?iso-8859-1?q?55BeEjgE+vX+Fdlwk9Zo9RMeHaAudDzX7At5zJFK9gxxgBqO9GN9467uGmI4?= =?iso-8859-1?q?zpPxnutB2KSwtRGiDNt69G/WhKwj8LaWZvqNnvW5IEQxCDic6HF9xz9xBgvb?= =?iso-8859-1?q?AQs+fbvPaJz/aIFkKB?= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(8676002)(305945005)(106356001)(102836004)(386003)(6506007)(99286004)(97736004)(8936002)(256004)(5660300002)(71190400001)(1076003)(14444005)(478600001)(81166006)(81156014)(7736002)(26005)(186003)(71200400001)(50226002)(6512007)(6486002)(6436002)(6116002)(53936002)(36756003)(68736007)(316002)(44832011)(11346002)(2616005)(446003)(476003)(86362001)(486006)(76176011)(14454004)(25786009)(52116002)(2906002)(66066001)(2501003)(54906003)(4326008)(110136005)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB2080;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Sc3P/4VjoR8NQxbtoViFWL17LU2uXDEDJUueqx/tgVjeNvzmYTxhqeBAkmNmvloPwc1s40rJQqmOkbZgvzUdjnD9ptDVFXzWTkbUrZponmUD1aMH8aUlUha4UV5gO+VjtqBecpBWck9z+Bd+D0I/Fl1qrNjvTgB/zE5HvXRrr4r43SqNhvWQsju4ixjgemmvn5i3WGPYEWojOo1Ly1Drm+p6AtOxo5xGpgnMBYE4McCrM/0cRVYJmivouy+9KBz3jTCGjs+a3PLB+enV4QJusN3QPA8Ss6lRL7D4GnACZ34GbMt/MaYttfm0Cf3P9g7A+IQm7YnnJIGrbU+VLhbkecY/9rMqvZCrHuHRAnhKReQw0RHjObN0j21g5uwyiBmfbIPiDgVQsg/j3TKiHkYNLFQb9HR0l1xIvDViycqPXt8= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 168d669f-5f94-429c-29ad-08d6a116910c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 02:59:21.6631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2080 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu Invalid Transfer Complete (IRQSTAT[TC]) bit could be set during multi-write operation even when the BLK_CNT in BLKATTR register has not reached zero. Therefore, Transfer Complete might be reported twice due to this erratum since a valid Transfer Complete occurs when BLK_CNT reaches zero. This erratum is to fix this issue Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- Change in v3: Define a host->ops->irq callback to clear the SDHCI_INT_DATA_END bit drivers/mmc/host/sdhci-of-esdhc.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 7e0eae8..ef36f46 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -24,6 +24,7 @@ #include #include #include +#include #include "sdhci-pltfm.h" #include "sdhci-esdhc.h" @@ -867,6 +868,22 @@ static void esdhc_set_uhs_signaling(struct sdhci_host *host, sdhci_set_uhs_signaling(host, timing); } +static u32 esdhc_irq(struct sdhci_host *host, u32 intmask) +{ + u32 command; + + if (of_find_compatible_node(NULL, NULL, + "fsl,p2020-esdhc")) { + command = SDHCI_GET_CMD(sdhci_readw(host, + SDHCI_COMMAND)); + if (command == MMC_WRITE_MULTIPLE_BLOCK && + sdhci_readw(host, SDHCI_BLOCK_COUNT) + != 0) + intmask &= ~SDHCI_INT_DATA_END; + } + return intmask; +} + #ifdef CONFIG_PM_SLEEP static u32 esdhc_proctl; static int esdhc_of_suspend(struct device *dev) @@ -914,6 +931,7 @@ static SIMPLE_DEV_PM_OPS(esdhc_of_dev_pm_ops, .set_bus_width = esdhc_pltfm_set_bus_width, .reset = esdhc_reset, .set_uhs_signaling = esdhc_set_uhs_signaling, + .irq = esdhc_irq, }; static const struct sdhci_ops sdhci_esdhc_le_ops = { @@ -931,6 +949,7 @@ static SIMPLE_DEV_PM_OPS(esdhc_of_dev_pm_ops, .set_bus_width = esdhc_pltfm_set_bus_width, .reset = esdhc_reset, .set_uhs_signaling = esdhc_set_uhs_signaling, + .irq = esdhc_irq, }; static const struct sdhci_pltfm_data sdhci_esdhc_be_pdata = { From patchwork Tue Mar 5 02:59:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10838877 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD54F922 for ; Tue, 5 Mar 2019 02:59:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA71C2B802 for ; Tue, 5 Mar 2019 02:59:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D7EB2B819; Tue, 5 Mar 2019 02:59:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 339E52B802 for ; Tue, 5 Mar 2019 02:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbfCEC7a (ORCPT ); Mon, 4 Mar 2019 21:59:30 -0500 Received: from mail-eopbgr130087.outbound.protection.outlook.com ([40.107.13.87]:17454 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726522AbfCEC7a (ORCPT ); Mon, 4 Mar 2019 21:59:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jejosDOnC7nTapP/dHKFRIWsFc8zVTPEVxkeIKEjAQw=; b=LcxZN8OcsKicsFxIW2d/jH0XNXwH19HfH+OcetP7qhWgfcH0PJ7IExJDAmorVY9/aL3qaWAg/t6F3H5zAfWDz+fGs5pj1xaDHZ6Pp8U68lMvqouTTsnZ4h9u/DzOejdZYdBFRY9JGQRtVhX3LvKXzgCybVAiZCsAoHLPUK8uq2w= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB2080.eurprd04.prod.outlook.com (10.166.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Tue, 5 Mar 2019 02:59:26 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1665.020; Tue, 5 Mar 2019 02:59:26 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v3 5/5] mmc: sdhci: add quirk to ignore command inhibit for data Thread-Topic: [PATCH v3 5/5] mmc: sdhci: add quirk to ignore command inhibit for data Thread-Index: AQHU0v9x2jHXd6ImK0KsZesnYWCVCg== Date: Tue, 5 Mar 2019 02:59:26 +0000 Message-ID: <20190305025811.38328-5-yinbo.zhu@nxp.com> References: <20190305025811.38328-1-yinbo.zhu@nxp.com> In-Reply-To: <20190305025811.38328-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR02CA0208.apcprd02.prod.outlook.com (2603:1096:201:20::20) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 75ffc85d-d8e0-4ced-ca3d-08d6a1169407 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB2080; x-ms-traffictypediagnostic: VI1PR04MB2080: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB2080=3B23=3Ab8?= =?iso-8859-1?q?sm99LSItEQ1U2GwWVnGl2l+KD7LIY4dzyOvAwj7Tl5BhttdpgV2uZaLlamqP?= =?iso-8859-1?q?VvqnbJcxa75Seh6Wu/X3hcQ9J/oZ5GngPAfDmKRWAkYHyzf4eO/weboqeU3p?= =?iso-8859-1?q?Kq7IMd/fC02VRbEzWwe9TuLlKqzPIBkcEEQ26kSxArsvNeeYy/iS8erIuo2r?= =?iso-8859-1?q?K1tOQZwHZPizyvT3oBX8/gNwN+HYChOKm2JAsIenpkbk+vumNZISYdV5P8vE?= =?iso-8859-1?q?uI+pG5vaGzqvxkqNX6F1wRLNauax9oMqdodbnHYpreu+yoppkxSHhxG4C+FF?= =?iso-8859-1?q?kQtb7MiGyCyOdO1djMPT1+osoIMrXIq2Leln5AdIfaXeQ2eXCO9ubumCkCqh?= =?iso-8859-1?q?T8AcGVus8IoYYiVsht1cWX6/A2Swx4XtnEabxQdVz5QB8fEH2lJ/2TgpezEx?= =?iso-8859-1?q?et2fmyFmWAj9gKmTkpEAxM+Ic8OIRu+feRDV57RPo81vyM0wnCJDetYLiQKT?= =?iso-8859-1?q?7vcz4nKK5IBc1BOVpqd3TX3Jii7RmF2dvMcvWxVGbfWVZcIIVtL+i3DQCs9B?= =?iso-8859-1?q?PCRyuCb/HnvN2GKlihEWD9X28Lg4DEFfZDAhc/Vmf4353ORNAG2iALIVrg5H?= =?iso-8859-1?q?NVH1Oy/M9ztQ2LvK2OupvOqXLkxqz42emmGrLokJbX8qg7ipJd841ufcgQny?= =?iso-8859-1?q?AmfVuMTydfCS1HALZpWd33clLQS3kWuFNmc8bRFK6Rv/Fu4EYkYv8jl7NUkf?= =?iso-8859-1?q?4YfnwLZQeB4dmY9ak3jrkSMaAmLkXy9ua2konDjkw6WDlnA8z04hERUb8tXz?= =?iso-8859-1?q?8HLdetSNpYUVPum3ZwSHKVoSNdu5pdYOB1WopSO35l6fGkHk4ewaXCHmcRSq?= =?iso-8859-1?q?YSpQ3/qKNckZx/bFlEWy5/mt1M0GwIfcP0Kx8H8TPor+mvsHUnHOllu160Fw?= =?iso-8859-1?q?R1lFbdTGBV3SjjJdXx+neepxEl+W2gKG4uQEtDvZ/ButeT+pQPa7swLWMrO1?= =?iso-8859-1?q?oS3i3bZNnDTvF+ehY6D9x3J12Z6KFx3vZvKY8bRRoiicH8WhpGUPfXSnN5iS?= =?iso-8859-1?q?DAMhQxOiwUVSVy8QkxHhsMUcPVkzGwFBTobVG6tU9nnOlLEdEMG+xfeeo2Gi?= =?iso-8859-1?q?A2rsvMnDink/uEkq7jNyplkBfyWIzZlAFrhNJNgyDPcZtN/H5PeSAJLOnKZj?= =?iso-8859-1?q?cKwabEp/cBxzzra9Srdk6zReuYISYPkuQIgws6qUGOjnUhYTv8+uiAdjufgj?= =?iso-8859-1?q?UmdMCxYy+Wyfa5PW0kQGEeJ53mZSR/dsdO3gXCYcbTklW7qgmIFVYtQGc=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(8676002)(305945005)(106356001)(102836004)(386003)(6506007)(99286004)(97736004)(8936002)(256004)(5660300002)(71190400001)(1076003)(478600001)(81166006)(81156014)(7736002)(26005)(186003)(71200400001)(50226002)(6512007)(6486002)(6436002)(6116002)(53936002)(36756003)(68736007)(316002)(44832011)(11346002)(2616005)(446003)(476003)(86362001)(486006)(76176011)(14454004)(25786009)(52116002)(2906002)(66066001)(2501003)(54906003)(4326008)(110136005)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB2080;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7oSbTJOfwCkgnK5fu8FXuxwwK4T5akeOgTG+CX7d2Z9hrMBJ3efRct4ERNrcuBA7NrXs2WqdHM68L/cD7SjpbExKPn3f5J3v8WULR/YmrLX6rfR78E5P9baIXyJEtF7s1/5BW3E74nFqYGH4z7tTf2c2LdvnMhS/W2Mf1LI8gR8uQUJqp7VWtj9Ehu1NRj5CII8EPToAqrupOT1HSrClUa5Rj6xWHUjGsoQBrD2cF9VcUkXWalOoAInSdlDSnE8YQRxgaPc+Mm0/JMa0Es1ad9Dja9PJuaZwXvy43be7XqaXScPV/ldUWLfmj/LrC+a+iBqUc+ripokN2Suozl6qxjO95zAGLput0ibUGPkiurEvQagF3O4b9WnGvNaSk4F354kACkhTqjHsuXNl2te45m7BsH030o8HxKTfC9wwA7Y= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75ffc85d-d8e0-4ced-ca3d-08d6a1169407 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 02:59:26.6906 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2080 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yangbo Lu For some controllers, in Present State Register, Data Line Active bit is not reliable for commands (such as CMD6, CMD7, CMD12, CMD28, CMD29, or CMD38) with busy signal. DLA affects Command with Data Inhibit bit. Therefore, software driver may not know the busy status in DLA/CDIHB. Futunately MMC core driver has already polled card status with CMD13 after sending any command with busy signal. So we can just ignore CDIHB never released issue for such controllers. This patch is to add a quirk to handle this. Signed-off-by: Yangbo Lu Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- Change in v3: move the quirk to sdhci_esdhc and remove the patch[6/6] drivers/mmc/host/sdhci-of-esdhc.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index ef36f46..da7d538 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -82,6 +82,7 @@ struct sdhci_esdhc { bool quirk_limited_clk_division; bool quirk_unreliable_pulse_detection; bool quirk_fixup_tuning; + bool quirk_ignore_data_inhibit; unsigned int peripheral_clock; const struct esdhc_clk_fixup *clk_fixup; u32 div_ratio; @@ -148,6 +149,19 @@ static u32 esdhc_readl_fixup(struct sdhci_host *host, return ret; } + /* + * Some controllers have unreliable Data Line Active + * bit for commands with busy signal. This affects + * Command Inhibit (data) bit. Just ignore it since + * MMC core driver has already polled card status + * with CMD13 after any command with busy siganl. + */ + if ((spec_reg == SDHCI_PRESENT_STATE) && + (esdhc->quirk_ignore_data_inhibit == true)) { + ret = value & ~SDHCI_DATA_INHIBIT; + return ret; + } + ret = value; return ret; } @@ -1111,12 +1125,14 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (of_device_is_compatible(np, "fsl,ls1021a-esdhc")) host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; + esdhc->quirk_ignore_data_inhibit = false; if (of_device_is_compatible(np, "fsl,p2020-esdhc")) { /* * Freescale messed up with P2020 as it has a non-standard * host control register */ host->quirks2 |= SDHCI_QUIRK2_BROKEN_HOST_CONTROL; + esdhc->quirk_ignore_data_inhibit = true; } /* call to generic mmc_of_parse to support additional capabilities */