From patchwork Wed Aug 7 05:13:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755636 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2056.outbound.protection.outlook.com [40.107.223.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F741917D9; Wed, 7 Aug 2024 05:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007648; cv=fail; b=dfnrJRmuK22kD4z1HjK1CGBu8qb1NCmOQ8XaZHOd6ZEylXuUEZthx82LA0XGroWkKvMRreMUORoOnBKRxjueA1hsHBD9ZEWgPxfI5PfpFulLX4rb4B/om/BIk3gPf/VVh5s9BHsiM43RKUGU/Wrq+wFYKIoUrSWaNviZnDwskbI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007648; c=relaxed/simple; bh=utFnCjXXq3dUZomEwbJIe/F8SDIZtbTlgz1KvAdmlz4=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=EKEQXU1rnudztcF08TRJh/MZP0w3+pO8vDZwF32IkgyeDxLF2cugQU5qqUSf94HwCZ1vFEC1ZgqcaNdPYGoidT5oyud8haQpWHAMqikczcfRo54kyKd+pV0zdtY39NK181ioFy8fBwEfkhMTv3lz3f/FiC3kfwXlCryHTvQqQkA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=qhkW4dFJ; arc=fail smtp.client-ip=40.107.223.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="qhkW4dFJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qHbxmjk1Es2zhalCFntx11oLPCDOThArEE9/EHNvv4emkWKwPSL9QUBH5HQECcpvE/O7YRYDbMhVIFR2wDTghfk6GZ1QVrMhEBjrFCdhqJHojbKNJ7m2NYHcDfgEimCId9kv+2O5M8IXl364TK+hQOAIDUU5Rtwk6pdgZYEUrn8MZzLbFWiSMzAb7C9sWfoIOH9WEqQEyqzj+XIyUuWjhbWvRONVzIVHpNYDtL++cNiLRlE2D8wrhowSDKoFTbUflEKdq0+y7c52trhG0bFeGFVERtzd6YQCSSD8J6A+Q7WIv4FWuOxPaJrFWaFQLrAcGx7zYrIlSQBPC7wruvUjUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aoOn35PB7tB6CN6MRHOsqsIBZ7eeJhHJe6rpmwRrJWE=; b=romCbfaOOsaeEy5bJj1U9JusLkH0WcHRtFTYHWKL1iQOrM3xrP2rNdn4rUg4Qf5JNEBXn7wdq+mYtTy9wySeou+h2iSeTmtyEFWdPSttXEUD1eXiT3dys0XHXrFUNScKS6Ce2yk6/iPPCKTjr3ZxpQMBnJjrdq1j4aOFSkqnF1svgr6N3aOGMLvFE04mxuvdB87M6rNMRB7Xu9JheXP6FaQgRNBaoEEIHjjVRCIwEPMWMv2jbozGHYi6uCB92+gGNPS+OVgSqKzn0WUW7BD9GA0g/iI7KS9rD15qU6+cwnC2nJn1BPF/aFa3HfzQPY0dqxnAwPOwgXOKLBJwJ/NMJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aoOn35PB7tB6CN6MRHOsqsIBZ7eeJhHJe6rpmwRrJWE=; b=qhkW4dFJP8FU/kkKSvY3k9l0pG3kJCBBz1q70BY3xxL8udby0dRLd1fW2WfkFUvdcZ3xuM5NNygwmdp+rQw1c9qUxQ42Jw4oVJnce1JkjGUbczn+fV0o2oujeoqHNn8C7AX3xVb9/p8MEkLGaVBoFl4z6lVMunaQSK1YxhnnFnI= Received: from BY5PR04CA0003.namprd04.prod.outlook.com (2603:10b6:a03:1d0::13) by LV2PR12MB5800.namprd12.prod.outlook.com (2603:10b6:408:178::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.13; Wed, 7 Aug 2024 05:14:02 +0000 Received: from SJ5PEPF000001E9.namprd05.prod.outlook.com (2603:10b6:a03:1d0:cafe::77) by BY5PR04CA0003.outlook.office365.com (2603:10b6:a03:1d0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.27 via Frontend Transport; Wed, 7 Aug 2024 05:14:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001E9.mail.protection.outlook.com (10.167.242.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:14:01 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:13:54 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , "Kai Vehmanen" , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Krzysztof Kozlowski , Ajit Kumar Pandey , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 1/8] ASoC: SOF: amd: Fix for incorrect acp error satus register offset Date: Wed, 7 Aug 2024 10:43:13 +0530 Message-ID: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E9:EE_|LV2PR12MB5800:EE_ X-MS-Office365-Filtering-Correlation-Id: 54ae472b-2dcf-4be8-abfc-08dcb69fbfbf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: FNhd1ZfIPGc68HYFXSmV/F+H3H2jjNuepiKU/Bwh18HJnviFD6sMzZ5kuiiKCknJg57e+CbfmpYS+Pa3s0J81ZIm0O3FOhYBF7rjb2KJJxqmOvP3q4lF3PaJzuXrALJ+Tsv7Ra/XPmEPwQiNgpbtbfKCITbx84hWmACJJua9zcH/3XUVAQhhi2WxB432cY9Mriww082luUcZUD1lw3mVnCRmEfktKpoLeHvrZdlmX5J0Uj6wwI0FlFM8fydnfiPmVgKCnANKuidyELbvsUrCAHgwV/jqiZT48YABWXx3IzSCnYUeSaGVSJEjEKGs2D8otMiZmLpjJQ2gtIwI6MC+g0emmKY9OmIGpQfy5+CEp0fhYUWF2uS4UQry9W7vBPxbgvayYeapCOqn5bP6aRAfmC2Pyqs80ad0wMhCwt276unZWphI7l8Q5n/8+a5BCfc+Sc4DaxzVzLeLs1Tj5Uqo3fTWCMXqztgG0bCVlIjblzz41VFaabntbPWtJkTj5de18/UvyS2bXxIhDSnDQRJE731ek/cyTmEriLTxOowkzhDxPlM7zPZYxQsQq8zlfuUmGR5s9R+mG4x2utJ1PucrHK1ba8LOnxjNDaF11+90WE+7OsT2ELHcWyAGM1mvQwsxruG4lS35ng5qLPHGy9+3VNJ4ETXn/mcZg1jZv0FwQgTBUDxLYTMPEH2ZV9zqk+QTk4sYXbMQH0JSXVe0K0nELwyyK7Oio71CEqoxm1Gr/Eu7NoTPOI5EG4ZmWAIefeIHDqlrmV9oth05M8KbSGwZjT+woG0YGWoOrMJl4ErrFKvXy6ppgaR6ydhiZsh4jO2/US/JIT2DKRmjryU0MBuXuRTaVYORwBoKccbLRuC0F4GvgRIf/0/NuGTl6bU2CXF3J3tpspfGqcJUTveIYtwkjDj15Vw1H0Dp6qnMUCBbe71D/PC+zLCtM5I8Br6HQiVwVwoj0NeYyW79Ra7F6wjMXFHwcokSpGFq+1BGlZdZrvulA+PQVb5mDF4AiDYDZ/svLcMRBAkTA24h+y2PSdleRQBM4epOZNSrhxlErX2tz+8SEvRvk2H1VWd3HCBj+6wMyaIT8oQPi6wtvXaxQmYbAwY6KnSaDwcRJo71WdEmNPCQWGooOTvhFcVuNbAjHH2gCDaBar9yBPMINMUKuk/1AbWO3o+HC2aJ7bvf/Ts6dSR9qcafn16rg657kOtQtp/xr5tBgTieqGiTTl0quSmE/6OrQwLxhjpEcSPh7ba5gTPJPSEn4XadrdRw4OEZ+WgJgwtE9eUAo6GTC2SpiK9H1f8voC4Yn+la2TkW3U3Dc2xnkri7qtw9VtED5gq2wMNtOny1+/QAjpJ0ydyNEVcMTvv4vv7Q4EpoQANSu6ut2QYIfH4Rzmzcsl1sVfj/CnaB7buuhCf1Ljrt+D3TkGbPUQh++Oz1naiq8B5YLOFcqgU1fCrmrCGFg2h7pkvagsRx X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:14:01.1426 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54ae472b-2dcf-4be8-abfc-08dcb69fbfbf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5800 Adding 'dsp_intr_base' to ACP error status register offset in irq handler points to wrong register offset. ACP error status register offset got changed from ACP 6.0 onwards. Add 'acp_error_stat' descriptor field and update the value based on the ACP variant. Fixes: 0e44572a28a4 ("ASoC: SOF: amd: Add helper callbacks for ACP's DMA configuration") Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/sof/amd/acp-dsp-offset.h | 3 ++- sound/soc/sof/amd/acp.c | 5 +++-- sound/soc/sof/amd/acp.h | 1 + sound/soc/sof/amd/pci-acp63.c | 1 + sound/soc/sof/amd/pci-rmb.c | 1 + sound/soc/sof/amd/pci-rn.c | 1 + 6 files changed, 9 insertions(+), 3 deletions(-) diff --git a/sound/soc/sof/amd/acp-dsp-offset.h b/sound/soc/sof/amd/acp-dsp-offset.h index 59afbe2e0f42..66968efda869 100644 --- a/sound/soc/sof/amd/acp-dsp-offset.h +++ b/sound/soc/sof/amd/acp-dsp-offset.h @@ -76,7 +76,8 @@ #define DSP_SW_INTR_CNTL_OFFSET 0x0 #define DSP_SW_INTR_STAT_OFFSET 0x4 #define DSP_SW_INTR_TRIG_OFFSET 0x8 -#define ACP_ERROR_STATUS 0x18C4 +#define ACP3X_ERROR_STATUS 0x18C4 +#define ACP6X_ERROR_STATUS 0x1A4C #define ACP3X_AXI2DAGB_SEM_0 0x1880 #define ACP5X_AXI2DAGB_SEM_0 0x1884 #define ACP6X_AXI2DAGB_SEM_0 0x1874 diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index 7b122656efd1..d0b7d1c54248 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -92,6 +92,7 @@ static int config_dma_channel(struct acp_dev_data *adata, unsigned int ch, unsigned int idx, unsigned int dscr_count) { struct snd_sof_dev *sdev = adata->dev; + const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata); unsigned int val, status; int ret; @@ -102,7 +103,7 @@ static int config_dma_channel(struct acp_dev_data *adata, unsigned int ch, val & (1 << ch), ACP_REG_POLL_INTERVAL, ACP_REG_POLL_TIMEOUT_US); if (ret < 0) { - status = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_ERROR_STATUS); + status = snd_sof_dsp_read(sdev, ACP_DSP_BAR, desc->acp_error_stat); val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_DMA_ERR_STS_0 + ch * sizeof(u32)); dev_err(sdev->dev, "ACP_DMA_ERR_STS :0x%x ACP_ERROR_STATUS :0x%x\n", val, status); @@ -404,7 +405,7 @@ static irqreturn_t acp_irq_handler(int irq, void *dev_id) snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->ext_intr_stat, ACP_ERROR_IRQ_MASK); snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + ACP_SW0_I2S_ERROR_REASON, 0); snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + ACP_SW1_I2S_ERROR_REASON, 0); - snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + ACP_ERROR_STATUS, 0); + snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->acp_error_stat, 0); irq_flag = 1; } diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h index ec9170b3f068..6ac853ff6093 100644 --- a/sound/soc/sof/amd/acp.h +++ b/sound/soc/sof/amd/acp.h @@ -203,6 +203,7 @@ struct sof_amd_acp_desc { u32 probe_reg_offset; u32 reg_start_addr; u32 reg_end_addr; + u32 acp_error_stat; u32 sdw_max_link_count; u64 sdw_acpi_dev_addr; }; diff --git a/sound/soc/sof/amd/pci-acp63.c b/sound/soc/sof/amd/pci-acp63.c index 54d42f83ce9e..c3da70549995 100644 --- a/sound/soc/sof/amd/pci-acp63.c +++ b/sound/soc/sof/amd/pci-acp63.c @@ -35,6 +35,7 @@ static const struct sof_amd_acp_desc acp63_chip_info = { .ext_intr_cntl = ACP6X_EXTERNAL_INTR_CNTL, .ext_intr_stat = ACP6X_EXT_INTR_STAT, .ext_intr_stat1 = ACP6X_EXT_INTR_STAT1, + .acp_error_stat = ACP6X_ERROR_STATUS, .dsp_intr_base = ACP6X_DSP_SW_INTR_BASE, .sram_pte_offset = ACP6X_SRAM_PTE_OFFSET, .hw_semaphore_offset = ACP6X_AXI2DAGB_SEM_0, diff --git a/sound/soc/sof/amd/pci-rmb.c b/sound/soc/sof/amd/pci-rmb.c index 4bc30951f8b0..194b7ff37e9e 100644 --- a/sound/soc/sof/amd/pci-rmb.c +++ b/sound/soc/sof/amd/pci-rmb.c @@ -33,6 +33,7 @@ static const struct sof_amd_acp_desc rembrandt_chip_info = { .pgfsm_base = ACP6X_PGFSM_BASE, .ext_intr_stat = ACP6X_EXT_INTR_STAT, .dsp_intr_base = ACP6X_DSP_SW_INTR_BASE, + .acp_error_stat = ACP6X_ERROR_STATUS, .sram_pte_offset = ACP6X_SRAM_PTE_OFFSET, .hw_semaphore_offset = ACP6X_AXI2DAGB_SEM_0, .fusion_dsp_offset = ACP6X_DSP_FUSION_RUNSTALL, diff --git a/sound/soc/sof/amd/pci-rn.c b/sound/soc/sof/amd/pci-rn.c index e08875bdfa8b..bff2d979ea6a 100644 --- a/sound/soc/sof/amd/pci-rn.c +++ b/sound/soc/sof/amd/pci-rn.c @@ -33,6 +33,7 @@ static const struct sof_amd_acp_desc renoir_chip_info = { .pgfsm_base = ACP3X_PGFSM_BASE, .ext_intr_stat = ACP3X_EXT_INTR_STAT, .dsp_intr_base = ACP3X_DSP_SW_INTR_BASE, + .acp_error_stat = ACP3X_ERROR_STATUS, .sram_pte_offset = ACP3X_SRAM_PTE_OFFSET, .hw_semaphore_offset = ACP3X_AXI2DAGB_SEM_0, .acp_clkmux_sel = ACP3X_CLKMUX_SEL, From patchwork Wed Aug 7 05:13:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755637 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A73241917F2; Wed, 7 Aug 2024 05:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007674; cv=fail; b=qfyTa4D5wXh6OkqOWbqCIsXYTcOvd/YpN2eatEhaZjNlgGqYZVefgrm+MqeFSrWi8Csi/KuVGC/J6u8lnEW6/yb+cssEM3OpLSmL27CaOEBahoL6pE778CnlzjenjR/uxL+DLcDQDjV8plqESCJNhcYOPzKsNIkEW2NdONZYtk4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007674; c=relaxed/simple; bh=EYvWmbwapxhXRrApxnPn19zusiErRpPzHSu/Ib9cSag=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=so7tcbul9XQRQnNk+N4TaxLFNpsqfw14qCxT4dhR8C1HAhWRvRdLx2i78t6xwaEL+p3ycJtDTL+EOWk0ye3fG5daYPIvUOaw/Ekt4FbcdM/4uf46aMXIkQPpQdHoBLI7H+3mnbZKW7fMfaFavOMROuSw2hESg3uIQ7qfWG4s2Fs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=u+wHKsEi; arc=fail smtp.client-ip=40.107.223.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="u+wHKsEi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g9xJsEc9wjYoyhAuOGgIjOfVp6U0AFrA41bAHXYOjJUfpDe4v2c4cMJg425S+MKaFBTy5PDSjSp46fWU+SRP6FZPpLrQdGFrdLBfFd46WbNiry6hn6hlpKwX1PLJhKZBFb7YNTHQ/D6kZsVi5IW483Dy7+2kh/jqzg1qatUP4LvWbyFjtfRv/WlvuJ2eQF4CEGzeHnfUJ2bVLGd4wH4vBVSqdeMdSHO14r/ew7lzC9CgsDprQRfDj/wuC3bAj0ENM2fDuD53QYDHs7uMfFphAOpe3BTPZsGG01PRwtkLdJxOh7lC2epJazeaBko7/UC+jey7PrGS5L5YSSmjN/vXIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=niKGXD7RG6SLE2Z/Fkk9hOW6fVU5W+mLoOggWoOsWho=; b=UPGoq5td8Uih9c3XJHNWn9D7Ebe8MxlKUCCroJJKbAUpbIgqy7RWWBSijJfqQOSUyfA+jw+cRPtNVhLUYv5VAVTGRW+xzgXY76NbClrsXM5K+DJl2u7l8xU2ogOXsA8AwSf8B+TuGIfwvwxaaxPzfztDhVwo27Qm2tbBOYULK/x+YBZbb8Msy6tXjfx3/MGyTbi0pMAzFUQh67H6hJzfNZ98TUCs+2kcb1vlrjbaHPcrwWGgzaIYWEdBvAOCYy0CcaTTEycPjsYe6h3cUJvjlc9QgQ+q2b19p26bjUNlNAstCZMnl2uQCBCfWzcq1ctnl5Shg0A4cX/U6D6pj/pUFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=niKGXD7RG6SLE2Z/Fkk9hOW6fVU5W+mLoOggWoOsWho=; b=u+wHKsEiSsJ7T23vAF4uB3CdOLmCJZ9rx+F+bofq0DlKD6b/HGuN6s9q7s9/BnEUa4nm1w9uwqMeJRRXOk9rO4Wq7hWGCj7cDqbWqZdUQbRlHUJ4W1NiUGXdrXWFNXdtoLbbXZbN5Ys0TX4a4kAj4CsXoR3lp6ko3dMjZAiWqj4= Received: from BY5PR04CA0019.namprd04.prod.outlook.com (2603:10b6:a03:1d0::29) by BY5PR12MB4276.namprd12.prod.outlook.com (2603:10b6:a03:20f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.27; Wed, 7 Aug 2024 05:14:27 +0000 Received: from SJ5PEPF000001E9.namprd05.prod.outlook.com (2603:10b6:a03:1d0:cafe::35) by BY5PR04CA0019.outlook.office365.com (2603:10b6:a03:1d0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.27 via Frontend Transport; Wed, 7 Aug 2024 05:14:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001E9.mail.protection.outlook.com (10.167.242.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:14:27 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:14:21 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , "Kai Vehmanen" , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Krzysztof Kozlowski , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 2/8] ASoC: SOF: amd: fix for acp error reason registers wrong offset Date: Wed, 7 Aug 2024 10:43:14 +0530 Message-ID: <20240807051341.1616925-2-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E9:EE_|BY5PR12MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: ba82c707-306a-48a1-47d6-08dcb69fcf2e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: 3g7u15CPQ3XBPgMXcHLt6l/28TY5qZCdRcL8GzQnRtLpl4PFmvmhZ7iOzuNm91a6Q6CC5/NbV0w/+nC0yTv9yTt8ZIKKR/3fnGAAaoycwLdFpvRG+EMiKwpUtx3/TE8Rimn/3zA8A7rIlrOmKy0M+ovzxTTgLPrEzeROybjUHTDeaRiuUY+jFnl+CN5Po1ouEW4/N3f6mWum+ZOSIH5+ygT3d4bAmaAh/VYSgs4ECC5hmZgYHQo+GppIU8B7LX2wjfZxQH5luXk5H+B/EKn9oqURdFQtc9KJQ1nMeHfo0GAaDq5AbaYBinmed3/gkab99WtNjKsoKtUJExzmJQShx0zoyeIfH1Jl7BDraEaA/9XGrGOxnNOzWQvPvj38Faaxl6PfNNVCtvT4M2IEBWV7gngAt1hKD71mjCD7DgVkyJDc8GtaIQAkF9/ZJbIyQfIGhTuhIVOqwaJzhzFKqfbu9ZHUjRKkQA5CDw+HQTru7zxUhztrtsk9pwzk8kFt3luNnnFr3IxC3ZjIRGcDpYLyDq0R0RgfW8fMOL1S3TekpM3U9AQ7XsoGohDKwudm5A5xl9BlGIjT3MduuGJQ/jE1B0MHzKX5XVG68tSIMH4EXwlJphkZq+5z/Mpalbh2hmIzZX0F+q1LX5OwXX1tpBfTKXoWQzMfth8Rprmr7L6eoopnm+pownC24B2dOP7+FuDIr+77M1XJkejHUB7dfnVAxueGPVtNKkcRB6lHEQnbc0Ml7npq21g2QOqBUSWJjOp4zXG2XpQVx2IPEhK5B8YXUTetZFU74A4VsZtccfjv34Ic0kblHmZGz4s3ZzIW/p1AXfl3lP3rKHcF//gf+EmV4Kfwhid8JVYLwNUHfS9trX7kLv2YZm7yZGp3T2Enhv7uG+lVOcF8qAo3/2j4qPMbBCHcZNW24JuymkqWgGIA2HC7Ibe4IyzVMjBr+9yKN4slilE7FEFjMIy5lw/3ohakSGTMIgzNi1EpMAlcrcK7CHKfw2X2gRsjhXcC3KUP48FO6Nfjbg+tFnIyZXxD7iJn8ASwanTQC7gXAZ2rl9CZ9WpSDrJDkrfpb2o3YtHlDQSUhOZCYEqlCrBLbY5QZ/JHKEOGXyAsjVokzOUqj2BZ2a0uDjyu/ZUlBlqZ+B7tbuyaVbRwgWF8WibB5hmTBI3bhji7iV4ks76qPz6+bMosg7zdPOb2XxrFL200rzwQx2KpOYIaYTUBENoZ0swxOcG9zSPbQKcvWyi0yltQVHDI8SvWOcgZ+/CLwtS/vqXWKbYgTCaJJl4mW6g6nnqxcaX9/G1DZQz6v5PvG84A0a4WticmYnen50iNfuZ5OgIydXulANtv9lHQYWKSm+xHGZ+Aj2nAs0g9+xyot2ttzoNk6dcmCJpyQgM5yGZ2fsRN1X1cyPBGFJooQ6mbzQISdu3oeMZspkrTHRln9dYQWYhngExMFY9PaoPFE6uUYQh9tUlz X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:14:27.0333 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba82c707-306a-48a1-47d6-08dcb69fcf2e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4276 Fix the incorrect register offsets for acp error reason registers. Add 'acp_sw0_i2s_err_reason' as register field in acp descriptor structure and update the value based on the acp variant. ACP_SW1_ERROR_REASON register was added from Rembrandt platform onwards. Add conditional check for the same. Fixes: 96eb81851012 ("ASoC: SOF: amd: add interrupt handling for SoundWire manager devices") Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/sof/amd/acp-dsp-offset.h | 3 ++- sound/soc/sof/amd/acp.c | 5 +++-- sound/soc/sof/amd/acp.h | 1 + sound/soc/sof/amd/pci-acp63.c | 1 + sound/soc/sof/amd/pci-rmb.c | 1 + sound/soc/sof/amd/pci-rn.c | 1 + 6 files changed, 9 insertions(+), 3 deletions(-) diff --git a/sound/soc/sof/amd/acp-dsp-offset.h b/sound/soc/sof/amd/acp-dsp-offset.h index 66968efda869..072b703f9b3f 100644 --- a/sound/soc/sof/amd/acp-dsp-offset.h +++ b/sound/soc/sof/amd/acp-dsp-offset.h @@ -83,7 +83,8 @@ #define ACP6X_AXI2DAGB_SEM_0 0x1874 /* ACP common registers to report errors related to I2S & SoundWire interfaces */ -#define ACP_SW0_I2S_ERROR_REASON 0x18B4 +#define ACP3X_SW_I2S_ERROR_REASON 0x18C8 +#define ACP6X_SW0_I2S_ERROR_REASON 0x18B4 #define ACP_SW1_I2S_ERROR_REASON 0x1A50 /* Registers from ACP_SHA block */ diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index d0b7d1c54248..9ce8b5ccb3d7 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -403,8 +403,9 @@ static irqreturn_t acp_irq_handler(int irq, void *dev_id) if (val & ACP_ERROR_IRQ_MASK) { snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->ext_intr_stat, ACP_ERROR_IRQ_MASK); - snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + ACP_SW0_I2S_ERROR_REASON, 0); - snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + ACP_SW1_I2S_ERROR_REASON, 0); + snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->acp_sw0_i2s_err_reason, 0); + if (adata->pci_rev >= ACP_RMB_PCI_ID) + snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SW1_I2S_ERROR_REASON, 0); snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->acp_error_stat, 0); irq_flag = 1; } diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h index 6ac853ff6093..f6f0fcfeb691 100644 --- a/sound/soc/sof/amd/acp.h +++ b/sound/soc/sof/amd/acp.h @@ -204,6 +204,7 @@ struct sof_amd_acp_desc { u32 reg_start_addr; u32 reg_end_addr; u32 acp_error_stat; + u32 acp_sw0_i2s_err_reason; u32 sdw_max_link_count; u64 sdw_acpi_dev_addr; }; diff --git a/sound/soc/sof/amd/pci-acp63.c b/sound/soc/sof/amd/pci-acp63.c index c3da70549995..e90658ba2bd7 100644 --- a/sound/soc/sof/amd/pci-acp63.c +++ b/sound/soc/sof/amd/pci-acp63.c @@ -36,6 +36,7 @@ static const struct sof_amd_acp_desc acp63_chip_info = { .ext_intr_stat = ACP6X_EXT_INTR_STAT, .ext_intr_stat1 = ACP6X_EXT_INTR_STAT1, .acp_error_stat = ACP6X_ERROR_STATUS, + .acp_sw0_i2s_err_reason = ACP6X_SW0_I2S_ERROR_REASON, .dsp_intr_base = ACP6X_DSP_SW_INTR_BASE, .sram_pte_offset = ACP6X_SRAM_PTE_OFFSET, .hw_semaphore_offset = ACP6X_AXI2DAGB_SEM_0, diff --git a/sound/soc/sof/amd/pci-rmb.c b/sound/soc/sof/amd/pci-rmb.c index 194b7ff37e9e..a366f904e6f3 100644 --- a/sound/soc/sof/amd/pci-rmb.c +++ b/sound/soc/sof/amd/pci-rmb.c @@ -34,6 +34,7 @@ static const struct sof_amd_acp_desc rembrandt_chip_info = { .ext_intr_stat = ACP6X_EXT_INTR_STAT, .dsp_intr_base = ACP6X_DSP_SW_INTR_BASE, .acp_error_stat = ACP6X_ERROR_STATUS, + .acp_sw0_i2s_err_reason = ACP6X_SW0_I2S_ERROR_REASON, .sram_pte_offset = ACP6X_SRAM_PTE_OFFSET, .hw_semaphore_offset = ACP6X_AXI2DAGB_SEM_0, .fusion_dsp_offset = ACP6X_DSP_FUSION_RUNSTALL, diff --git a/sound/soc/sof/amd/pci-rn.c b/sound/soc/sof/amd/pci-rn.c index bff2d979ea6a..2b7c53470ce8 100644 --- a/sound/soc/sof/amd/pci-rn.c +++ b/sound/soc/sof/amd/pci-rn.c @@ -34,6 +34,7 @@ static const struct sof_amd_acp_desc renoir_chip_info = { .ext_intr_stat = ACP3X_EXT_INTR_STAT, .dsp_intr_base = ACP3X_DSP_SW_INTR_BASE, .acp_error_stat = ACP3X_ERROR_STATUS, + .acp_sw0_i2s_err_reason = ACP3X_SW_I2S_ERROR_REASON, .sram_pte_offset = ACP3X_SRAM_PTE_OFFSET, .hw_semaphore_offset = ACP3X_AXI2DAGB_SEM_0, .acp_clkmux_sel = ACP3X_CLKMUX_SEL, From patchwork Wed Aug 7 05:13:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755638 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2063.outbound.protection.outlook.com [40.107.92.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5A7191495; Wed, 7 Aug 2024 05:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007683; cv=fail; b=Ehh6cB+u55T2OKo78GZCL66J6s6HNrdS9pP3AJXMGB6XYl/VTfsXtFKQadfT7pA7/umB9WyGWmTlqyYjmdeBWMF8CSI1zbcsvBedc/8OwBM+hDl77OysUZOTjTEOYZzH3QCIrdiwp0jwTMI9tYBr4sGCtf42YcQFNdyffbKEsqw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007683; c=relaxed/simple; bh=3Dcu6aJU8X/aJgTk736SCzyefoHjdCUG7aL9wcxERrk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nK9g7uRfS46YGQYhT1kM7VWCtAc/M3MRjmqDZVR+2FnNf8ToDNvfQorFrPScBewBk/y8t7LS65I1Xb0z9AgiHqkUzmZc5GA8Z5JnDIwdgqeDPUAL5UHLHCdcTtIagI6Rao/p3tf0VefmmNvnMjCmdKJ/aTFAX3UJ94SWFT1wzok= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=iun5F19I; arc=fail smtp.client-ip=40.107.92.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="iun5F19I" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dmI+WRKu4JH6uZ7+c5aRR5bbbhRZ6H+sFyQ7FcpzvLWp21XQjhxRxS7uVbaDs8DY4TLHkMvOwiqYp/7kR9/JhgvlPbq+ZIkXWqvAGwSdPmLSGn3St8bQALF2LZzCmCJAisvoD7NTWDOCOQzhrV4MlS5IS3KuqVfqTW13XtqXHYRup+L+IUeAGfzTrK0bAPYL5rU5vTdkisf/h2X3JMr9/QsysKJRhfRqryyLprJCgun1tWcY/aBZpH8Hd4W/SzYEJphl/pmgRRDWrfGeG7FBBHRO1kreE+SV/SZpZhv/Prk8flqRs9YEV9uMVv1nvv1gP43C0XuCkf/yDMw7N37u9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I2KCJG/+YUEu+WHixSrZZlPKZxJ6pb4opybJ0tKtTd4=; b=RhNkzm7xiNrD/JjBtForyZzyCEzeR7+vZq4OZ+i4YhX4FQRcpkgZIF/6o1kt2jL9ZwDkG5iibc/n4i0DWnKc4WrjbEWjKcad3WHKUeZzbcxgzp4RQHX+SGp60PvyoIO3ha5nVOU5K6UWmm0exxk2ggSiwRvrhVVctZWjVNrH///das5wpF0fuaAnefJWL8LTKSEiEKvGvr/zSFXMu+SVQRI1WN2zPAbACGR2Jzv9j85MOskHDSMMfhKKAPnvMrQkzysm5yIcVggLzYqQvN+IxXU3PZl/gslSmiKImUGrKRHWAk9g/ZEG1cINGm4/SAPhMCRwOcDIt+doSYuzL2/BOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I2KCJG/+YUEu+WHixSrZZlPKZxJ6pb4opybJ0tKtTd4=; b=iun5F19I2IpPZ2H7vaHHem3gZullLn/6uDH94BJl+HBwzcJsWufLBqN8o680nhwgy6lSk2VhnnjuHbJT3oJIbCW8uFYuL5RYnwdanWcrq+/rNdYWHXR1yHJARVHIoyugOAQUt/OmKuvDQ9Q6r1rNbuBcBnGREV/xlhdIaWvpFLM= Received: from MW4PR04CA0243.namprd04.prod.outlook.com (2603:10b6:303:88::8) by MN0PR12MB6173.namprd12.prod.outlook.com (2603:10b6:208:3c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Wed, 7 Aug 2024 05:14:37 +0000 Received: from SJ5PEPF000001EC.namprd05.prod.outlook.com (2603:10b6:303:88:cafe::bd) by MW4PR04CA0243.outlook.office365.com (2603:10b6:303:88::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.13 via Frontend Transport; Wed, 7 Aug 2024 05:14:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001EC.mail.protection.outlook.com (10.167.242.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:14:35 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:14:29 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , "Kai Vehmanen" , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Emil Velikov , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "open list" Subject: [PATCH 3/8] ASoC: SOF: amd: move iram-dram fence register programming sequence Date: Wed, 7 Aug 2024 10:43:15 +0530 Message-ID: <20240807051341.1616925-3-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EC:EE_|MN0PR12MB6173:EE_ X-MS-Office365-Filtering-Correlation-Id: 935c2783-930f-418e-7260-08dcb69fd462 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|7416014|376014|82310400026; X-Microsoft-Antispam-Message-Info: htsKZ1Sjff1rPqE6lW7FAiLnrXXEaK8tFND+h7t0pqK/UFZJt0Lf8JkaVZeuxaAbXE7xPxGhPvPmhd913Mtg5UmqESbupQWte0RjquM/ZYqbNRxl3k0O1iZAO5ikRTdM7s8MzXK0dH4mW+lQEfFD3Dayekn1o570tWtBfZW2s55XMdNBE2NTYdmMKnb4TRHjYxYcX403hRxx3t0yfbXQiiCQPS1L/S7+OXwtGLI9BTj8gUFnDVwtflaSwTikj2D+xdt8xohXeg6vG8K9Q8FLPVmdIMxXWh4Od5dgWXNU3m809YBb20S9SNbBGe22i7wUWxbTKPs8EZGSqT1+/lvUWUtXT2dN/fhqG0OeVF43nHDsqedhFo3nM+9ZCNZJdfcj5jCs6E2F0JbAQ3HhleWbj/6Y6wtMVg/59pSNNRPc01EkgjrTftcJ3HP2iATAPBfhOrGdfVpcZ+KXrQcDAjpnl4ry1eGz0z+c4syUS52wyqL98s9IYd7USqP5p4U/NMdDWLcTwfde/pCKc7eRJ5EHmc/FWlGS4+gzHposI0OiuCgY4WmgHp99eseqaprTPugSgC0PwNgfksECpDbGUV+ZusKwDnddr2ibsN2dFgRcKgaMrPJH5BqoeQXcfRGtN2Fu4njrBWnlRphemm7yjgkTDcY+lzQ4+O0+yQC4PMvt8nre/HoC5jl/ZJ6KMHKyKtkUeQD4v3WswCzeXcAzGOW63oV93GzRuz0U1/38qYgvEdqQN6rBXEW0HgdYwjG4Ai5qQKh7Kc8FYZyPyF6kOwpIYAMjICJfrit3bcwAZJWeUwRlkEXKTSbcUb6K3CvUKRwB5i3ZRtEXgAEJRElrNTEmONlITz5cQs7NzTNkpGy65byzQYU2xxY2UXDmOLWlY6qIvG9n2MVbOM2X90YXZm1O9bx1JUXQVqBUWHxBXhH06WhpgL9B1UagbASqRMsoN68n3I2WlBD7U/zLGavlFdOTgqkc52rTJEuqtcAcErCvMwXCIZlUgePvovPW3gajMRnkpyYErVZw31goaizoEo9Oqe4XXHAckWhxp5gffkTW2TQKEd3vJrvKvJlAahFYZuxVwmok2UQv6huXaD2bGT1d5+o24r5dptGmc2DKu6LbWCgTElqyj5dAbo/XotRq5UtciUKVX99MHRqqUrf//N5Ob9t/RTp+sKidSW7IxEbAgzmynHA6GMx/kD7/fQKtKVY+Etap6H2zymGUkSk4wZpG9A6Le9hIm+4sq8kDZIJmCk+DP1p9SN5+pnZmlbWnnpnhnwkv8dRwDCQNeHGAkkxH1MTlKRc9dqXEU+m4ey19EJGhzcif1ssJkAsthls6ENnXUqKcCFycXs3zwOBUe627RRnlTYyDjQP0vQNW+xbSt60AsYJfQ5LGK3g2npiU3zskOsQ7IH+OcQv52RVve27vMTL58PGfITe8x/HTpX6ZU/zoBrxrgzhIP6OHT+lDHvV1 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(7416014)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:14:35.7638 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 935c2783-930f-418e-7260-08dcb69fd462 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6173 As per design, ACP iram-dram fence register sequence should be initiated before triggering SHA dma. This ensures that IRAM size will programmed correctly before initiaing SHA dma. Fixes: 094d11768f74 ("ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED") Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/sof/amd/acp.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index 9ce8b5ccb3d7..d0ba641ba28c 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -264,6 +264,17 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr, snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr); snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_DESTINATION_ADDR, dest_addr); snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_MSG_LENGTH, image_length); + + /* psp_send_cmd only required for vangogh platform (rev - 5) */ + if (desc->rev == 5 && !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) { + /* Modify IRAM and DRAM size */ + ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | IRAM_DRAM_FENCE_2); + if (ret) + return ret; + ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | MBOX_ISREADY_FLAG); + if (ret) + return ret; + } snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RUN); ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_TRANSFER_BYTE_CNT, @@ -281,17 +292,6 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr, return ret; } - /* psp_send_cmd only required for vangogh platform (rev - 5) */ - if (desc->rev == 5 && !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) { - /* Modify IRAM and DRAM size */ - ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | IRAM_DRAM_FENCE_2); - if (ret) - return ret; - ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | MBOX_ISREADY_FLAG); - if (ret) - return ret; - } - ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_DSP_FW_QUALIFIER, fw_qualifier, fw_qualifier & DSP_FW_RUN_ENABLE, ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US); From patchwork Wed Aug 7 05:13:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755639 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2079.outbound.protection.outlook.com [40.107.93.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAA4B191F7B; Wed, 7 Aug 2024 05:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.79 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007693; cv=fail; b=hERQMTGKxQJJ9VPeOtPINc6FaTB3ZTVZr+cEuMptjoqSomtfD01CTWXToF1IdUI3IUl4tkSdnneXeur0X7w1AhOV4wqEi+JxQ4xLxOgqk4kfRaoKz1hEWsNx3ZoFR2zLnL+K4ZBtJ7qymP5JcuPCXxZV2Mu7EUKvLocwJLCXYQg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007693; c=relaxed/simple; bh=IbvEYfxUpu8uJp6sM8KoJiMvrQ3grjF0UH/yg6pUjIk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lRtIruvfKW5NOYm7F2VxPb+Tlce23swjxULWae03VRc+t9uKfsAfg68oxwFwVSFD33+Laq5x08k8w+cF4AlarV2Flfl4WlWPNzLYDbGtzp8VajpTV2mwmva2lDlzMYLivSZps6Lda3v7nPaQ7VjdBuATOzE3KQq3iix5RQd+sg8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=r4jxOMKm; arc=fail smtp.client-ip=40.107.93.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="r4jxOMKm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ogeY3tOrA0AY0LOT5qWK6T/viudwUz4r49M+doSsEBpK1DTm8hEPttDoH7AbBzPI/+PtyEPsO0Adc84546z0KAMZDL61xcgbHXcuUv/mfSY7sI+7lgfehxDJ9yKiwlzbEwsnz9BULipDZxSrDRahxzX9RoqqqPjGb4g0M60ymk3+64XbhFiRStTgleDKb5vsVQ3rq5ASWaCGKcAgsAVz9aGeZpkmov1gsI7YTG/DhltICIEy1YceTCxiRoY1CnkddjEC16G8mrpn4UoxsVPMlIQkn/kiGrJV4+Zxp8g7pg1/V0lcYfq5Dpj9WvZKr4tLXOj7/NXfV0gyZIPz9IKi6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RTVy/S40reH6dPiVHmQp8KHQmxDvKLVFHwzi2x1SwAE=; b=MV0o4z8KC0uF14CbXphXYBCcJeL0SkVfu3WpHTGIpZopJsyx5UpGwMpoxikQ61AniIarRf1W+pt4ysldqskjrops2792WDjAtV7n4OFao/bVSY2Wierjh68KioBy5ANMSVSe44XksS2qPBX3M+PPp53GxqcjoJNhDNzGXAzmblBu5Zz0SqITI5veVghEZHbowL/n7ifuQjxHXDMVl0fHGJjs5z9YKYAhIGt/bikS1zQzWffAy9Is1pv9O3qe74bXRMROzPmFSqKWY8ThDuCAbw8doAPQX1ujLINppDlw1u5HRyage2Mz21PtB+3ScgwyS8ghV+7Q66VIR/EgeSJ2eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RTVy/S40reH6dPiVHmQp8KHQmxDvKLVFHwzi2x1SwAE=; b=r4jxOMKmS44aCjgXjlanbnbAZcpQRn7WccUw8RZ0lRbmzLT6H2LFnV1S6UuMh55wAQWPQslQgnMYAoxiizklLdr1YrsHP1K+yi5je36hIqCEwiQcNQ4m6Gn3KeSscR/WOWP5pLH9Zd8spUo4Ra1oRBllEU+6pjpHS7Q8wDZuDYc= Received: from SJ0PR03CA0168.namprd03.prod.outlook.com (2603:10b6:a03:338::23) by MW6PR12MB8736.namprd12.prod.outlook.com (2603:10b6:303:244::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.29; Wed, 7 Aug 2024 05:14:48 +0000 Received: from SJ5PEPF000001EA.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::49) by SJ0PR03CA0168.outlook.office365.com (2603:10b6:a03:338::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.34 via Frontend Transport; Wed, 7 Aug 2024 05:14:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001EA.mail.protection.outlook.com (10.167.242.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:14:47 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:14:41 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , "Kai Vehmanen" , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Emil Velikov , Krzysztof Kozlowski , "Ajit Kumar Pandey" , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 4/8] ASoC: SOF: amd: fix for acp init sequence Date: Wed, 7 Aug 2024 10:43:16 +0530 Message-ID: <20240807051341.1616925-4-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EA:EE_|MW6PR12MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: ad08b38c-c3e0-4d04-0ca7-08dcb69fdba5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: WaBr7zXNEun1y+BCI25f9ke+Vg6DMLKCb16zwVcI235cbSwG1byh7Lv3lpDcmqeAeGXsiI6lYLmHzS4DqBEQ912I7soIXQXKeBLIUGlv5sDnY9FaH9spKLUhTGKpn06cAHkZ/T1bals3DBCLhOLo2k7rnnl1Y6AU0Gfe6JSz8LQ+eEWNCrtz9VsM7KmaeZ2WAkNfi7hNnduEtW1NlMo6cDKxJ/uk/+K7PZX0gQ27v3eaEG9nr8vY0lTsDEmkr2aJvj+VGAe72NwMCkCIgO5ZtWfvRhFJBrnwcmQUOuI7kT0kxxeJycmfVYa9lU1uww9DsPZsWhH54EKTODI27maCYnXixXEvG+WOdLzcFzO3ktnKXleDeZAIzcPvFCbIHejyVjTMMcZxxkHfxxM93nwB23GTccAsVh/N9cOc9ZZ9FHBp7ZPBdf27RONyCflOXRv3qCh+SYklGZe4ZqaXwhN2Q6ERG2CZ3UC/XgMePqsbj3yD0PaczPeldQAWPuS2GCV4PXaXHbWsmh5q1NICYstYSjx9R9dtmdxJBRqNmAO25Ah6OMU5tOB2BwE5mBquLEP3pG6jYa9PPpio9XH7QcrbWAtckyDPqSgqFFh+9CSSXAUS5egQQPvKlR1mhnGaHVIQ6KOp4RdLVQF2Id1JGEPj/qnOemKblCmr9F2DZ4Gp+ifAqZrgboXJwemcl0y8jHb7/KyhEzAnT1RyurY2zgwyaNUbFTUOkdXxPaSTHnVmFGYmdYQBc8P5b1w1rkwvew/WyzDyN0t47AcxXdcy9vkqdhvCwYQzTuMg4VEM7p/e1QjE/xmHc7VPdvjrbCQeqtEnLku2VAFR2v2F3E7kUxIeh1Y+84VwDhrpiU8aOkGwg+IVK7WRhW2ALy6YMhTA4bAbNSLjZP64yBTTzfngAb2Tz/oPabc3xNitk/lvo/YwW33i8E+SD+7/ivCi69joU5w9C9aZMAvFilssOnydqsMDmGugj532ULW384Cbv1wcmHMp7QaarfHcSw0eN9siZRTFuPiNiSkowCtXlIaXfhJc9t3QWJCzasUKopjKm/eL3k3/X5ZjX+nQOxmlYw/+3Q9TV7Ko88Z9XisU3REpURgWwI1osPrtL9wyp1wkRZ1niy/O2XeAILXDSCQjO5/634JoscRAU3E2hhDmf4c2EpUIdoCnhV0Bln3xtANa1Z4mLXLNsXXcx7yGuiH/2qbk19Q0GoDyCcY27S1ayQgCAoTKoe1AcrEZ93iQOnnIH/7JSY8HnuKdeoQmI2QfhFRlLr00RJT2+G4dqTaS/fx4F8iVY4karcBSrm1L+NA4Yx031c28iwHrXJnVZfpS3eUcwVfeVaDyi4Hu1fjj5VhRyYh9JBFvBAzZJWG21q3pSvfC2AKskfPPLZqgR+fbXsVCc4TdJ53NSznnNEYkUa3pjO9outaHO4kN3T4Pte+Kn69MZ4pqRr4afXIdG/pcpOrNLiXs X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:14:47.9443 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad08b38c-c3e0-4d04-0ca7-08dcb69fdba5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8736 When ACP is not powered on by default, acp power on sequence explicitly invoked by programming pgfsm control mask. Update ACP pgfsm control mask and status mask based on ACP variant. Fixes: 846aef1d7cc0 ("ASoC: SOF: amd: Add Renoir ACP HW support") Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/sof/amd/acp.c | 21 +++++++++++++++++++-- sound/soc/sof/amd/acp.h | 7 +++++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index d0ba641ba28c..a9f32983b3af 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -430,8 +430,10 @@ static irqreturn_t acp_irq_handler(int irq, void *dev_id) static int acp_power_on(struct snd_sof_dev *sdev) { const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata); + struct acp_dev_data *adata = sdev->pdata->hw_pdata; unsigned int base = desc->pgfsm_base; unsigned int val; + unsigned int acp_pgfsm_status_mask, acp_pgfsm_cntl_mask; int ret; val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, base + PGFSM_STATUS_OFFSET); @@ -439,9 +441,24 @@ static int acp_power_on(struct snd_sof_dev *sdev) if (val == ACP_POWERED_ON) return 0; - if (val & ACP_PGFSM_STATUS_MASK) + switch (adata->pci_rev) { + case ACP_RN_PCI_ID: + case ACP_VANGOGH_PCI_ID: + acp_pgfsm_status_mask = ACP3X_PGFSM_STATUS_MASK; + acp_pgfsm_cntl_mask = ACP3X_PGFSM_CNTL_POWER_ON_MASK; + break; + case ACP_RMB_PCI_ID: + case ACP63_PCI_ID: + acp_pgfsm_status_mask = ACP6X_PGFSM_STATUS_MASK; + acp_pgfsm_cntl_mask = ACP6X_PGFSM_CNTL_POWER_ON_MASK; + break; + default: + return -EINVAL; + } + + if (val & acp_pgfsm_status_mask) snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + PGFSM_CONTROL_OFFSET, - ACP_PGFSM_CNTL_POWER_ON_MASK); + acp_pgfsm_cntl_mask); ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, base + PGFSM_STATUS_OFFSET, val, !val, ACP_REG_POLL_INTERVAL, ACP_REG_POLL_TIMEOUT_US); diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h index f6f0fcfeb691..321c40cc6d50 100644 --- a/sound/soc/sof/amd/acp.h +++ b/sound/soc/sof/amd/acp.h @@ -25,8 +25,11 @@ #define ACP_REG_POLL_TIMEOUT_US 2000 #define ACP_DMA_COMPLETE_TIMEOUT_US 5000 -#define ACP_PGFSM_CNTL_POWER_ON_MASK 0x01 -#define ACP_PGFSM_STATUS_MASK 0x03 +#define ACP3X_PGFSM_CNTL_POWER_ON_MASK 0x01 +#define ACP3X_PGFSM_STATUS_MASK 0x03 +#define ACP6X_PGFSM_CNTL_POWER_ON_MASK 0x07 +#define ACP6X_PGFSM_STATUS_MASK 0x0F + #define ACP_POWERED_ON 0x00 #define ACP_ASSERT_RESET 0x01 #define ACP_RELEASE_RESET 0x00 From patchwork Wed Aug 7 05:13:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755640 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2046.outbound.protection.outlook.com [40.107.237.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC1A1917FD; Wed, 7 Aug 2024 05:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007703; cv=fail; b=qtwQo9ZGcPo/1N1LnanBzWWtIA1GzvJbapBoomZ+QE1dMt/wlV1y3X3+58cRZb2bEpCGyGb3sXXZyg/3Y17CKJuDV4wDnCmXWHshw2Gpwoy0XJcgijpb3g8qf7vfNnEwWOaI28Mmt0DhDWVpfpSsd+IqjxV2m+idzuezu0Un3is= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007703; c=relaxed/simple; bh=mTm3MAKgh+w308d/h61q/miRKwKQ6+/Z5FzsQKtxiJU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hB9lRVJcUuJX7mOLhX/lhh7z68CGQsQcfsaRzI0oZ/ILlI6jbDifCJKucDJnpTA8yCrWr0hl4ub6QUaxmWgrjeGTDEtWVYd+OQtw063dtSBkAj5qNMinsHy2IbYSLOvSwnL6Y0dpl2B6inKdAK0w9VcCbYcZp4pc5vfQ4uVRfKA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=o2g34QHv; arc=fail smtp.client-ip=40.107.237.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="o2g34QHv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Lycz7aIxBo3aQGl87rq7C2zYl86sVB3dY2fH0xOIDFU03seInSmm2OfIu/b12wXRIcRLK3+qbaznPOxrO2rWJMUKX607t9mUXBXnT3gpSq/k6PSnYQhgp888AZlfzZFCEwUlSBPWXklPg1nJsbDxa3NDseTYwC2slZpL6cp4iJbLqCani1ho/B1ZI8wPQsKWo2BpgAMvxw5zDBq4zhdV03pLaL0f6mnj3EVOzRQbC8OiZEeyH76AlIIFhpB0EERGB3yT2LLd9YSyboHnIKMZFuslsw7Z1f9peEVfs+hfTUuCZAVhEqI3tds5Izbe48DvuNlg99i4Ach/9yuSY5v6Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VcmZuvb5AQbGbL7i/i+v7liw89Xk0n11G1csEO6y+kk=; b=r1u+lZi6Ol3+fWEkJJ0n+en1G7lrnSPHVbXmBoM8D8bkAX5phobebuDYL/aG4k0qjmvJN24Dtz01x8Xo/AUUluih+9U28ywdWU8F0vbeO3cwpOGCcKOfYzXf7NvDR2w+55hYRQU8Ipd/futickXwR6N3+g/4sTp/T1pL3WCrU/+i+Pkps/q3xaoeOMuBX/RHAg+yQVexc+ZT9WS5j2XZB8TSNFPic3/s3cCvkdDjL06hl4WCQnFu7STzkQgC+pbh068NstVrJNTZe0QMEZwBAj0SdwqlJHg0UXOgCsXBUZlt0F0zDEcWOItBsIg6su9u39qZgHnjRMTuT11F3V24pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VcmZuvb5AQbGbL7i/i+v7liw89Xk0n11G1csEO6y+kk=; b=o2g34QHvvXcSlx2hpDdLWLSfy+QN6FkQysPYVLz7x3RZFpLM4P52bYNn8yUcBSLoD+HaUNR+HkMcRPe3ZauUZAgZJEl+WRRTvEZRknD0HGNz1wAhdQlwxKFclpaWu2Z84GSuUuNtgj2x5APlSlLtBDvwUTNXHGNNM4By+8JWB1E= Received: from BY5PR04CA0014.namprd04.prod.outlook.com (2603:10b6:a03:1d0::24) by CYXPR12MB9340.namprd12.prod.outlook.com (2603:10b6:930:e4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.13; Wed, 7 Aug 2024 05:14:56 +0000 Received: from SJ5PEPF000001E9.namprd05.prod.outlook.com (2603:10b6:a03:1d0:cafe::9e) by BY5PR04CA0014.outlook.office365.com (2603:10b6:a03:1d0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.29 via Frontend Transport; Wed, 7 Aug 2024 05:14:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001E9.mail.protection.outlook.com (10.167.242.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:14:56 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:14:50 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , "Kai Vehmanen" , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 5/8] ASoC: SOF: amd: update conditional check for cache register update Date: Wed, 7 Aug 2024 10:43:17 +0530 Message-ID: <20240807051341.1616925-5-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E9:EE_|CYXPR12MB9340:EE_ X-MS-Office365-Filtering-Correlation-Id: 601b7c56-e2b4-477c-f25f-08dcb69fe0b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: dPnZtwacsC0gYUPR25RfISHs6InLBNaotjNNH0V+p0oLOK3ZvYJR1VFjuaTttIY94uBwqO6rEGyl2nNEf/6Wm+e+5R6iMwwnzC01PJKbt5PCdD86TJN7JIowYrnhbutoMvJDSf8/RWiBD7y2p2KiQWqgAOXF1i7A7I75InOFSmKaXMiVN1w/BjDGWXs1JBGSBpHLPtOWdDaunPt0E9fPUsLsvsRqc9yVvp37X7cODoi+Jyyozn9DJm7i0iGa/tThe+vgjggzwn3E1y4eTGT4nDwdqGimUtfSHA86bBZuyJ8GwmX7eHhCfbXQE7YvJxZWZQhHQERODhAfdgXrj8EorQpVvYowR7Qi3xtHNUHaZpojWpfhoWK2IIKEijKW2wrypPj1W2hxWckzZehgV1wa6c+3bfeNULBZZvY4F178myXHOyKZLoOAI5wO/ioKbnZIRUDtBPpHOPQUgBcAeldxR+vK3p08lAZA83Cl9OuQFtR8IxrFLm+YIfqeN8Rlb7h/RK1Xgc/bDPYakf1jOSSpQIgDX0sEIP0pv3ViCrzAZ8mwkqZKKS5kCzfZmoUiNtSYyaw6HTUMLcU7i8nIs8uKZ8RCLzStgLZvie0yONtwsVbmdwYy5ulluSN7JndISiHY1OEx9xjR31X81jfkfc0JW17o5VCRWpIkUM3VkjVHgIyi1EXzz0Ejg9tLDa21tA2B26zUL9BAVTzC4rSWNvmXZiyXhZm3alHFxuwWkYTKq5MM3YzrcI5YqNGCBJMZHl8JpcLfmp04+kmIETE2Jblo/GRsAReFrHSYJqqbQawRdXVQVAFNhBfiTjw2vZuewYKjVVA+pEfIEhyj+L0f/W4UVsMVey/G92OA3qTQ6H07We0YOOuYfO2ogyYhd0V2+Gzo8Sg67ssXQu0M7avDc+cCtFwnOYNO2svLyn1x2HX3P4YJBUj2yHhG/RmyWwwLPH4iNL0xp0ypJJM8bUqnjxZ8WYCfYeCFHed6ittyS3AFVOM2zBi2Z5F/nOe/YAwDJmehFqrqm2XZ3AHnF0oDR0gtA0t0cUkSfjz/JlKzTP8e+BrnMaLwo4Ejea76D6Ujbhe5KO0/wzOLayH9F/LEVt06Y+kIs6Uk+lEWNnoqBU/RTJboY0+7NAfQFaZ0zuRcKhboTPzdfkSzmTUuPGuL/7ZsVJ5cvM4QPOxUIV/B6adI4xe6c+Ldv2W6Yq65An7FSgGEM42hbGsGRyB+8J22sNg7yAFMeeNLMRbf6SXPD5vqGX9NK2MQpgXHu9IF9mR5sTozspRiTq9CfrsNH7bD9Svo1FZ66/lhD7voKXjCDxdhojeyOWlVh5s71vs7Dm3QYwPM1pGcMX/mMCM9fEf8nNjy5yyCPp9nHMT83TW8wkABBCS4pw2BtrSEZgS7lPwejVjFeCjNje4pquihFEeNXQzBFrkGCuA2XSTVjj5JLPSdMB7ZovxZx+eftE9xZk/toFTm X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:14:56.4240 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 601b7c56-e2b4-477c-f25f-08dcb69fe0b2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9340 Instead of desc->rev, use acp pci revision id(pci_rev) for cache register conditional check. Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/sof/amd/acp-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/amd/acp-loader.c b/sound/soc/sof/amd/acp-loader.c index 2d5e58846499..19f10dd77e4b 100644 --- a/sound/soc/sof/amd/acp-loader.c +++ b/sound/soc/sof/amd/acp-loader.c @@ -219,7 +219,7 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev) dev_err(sdev->dev, "acp dma transfer status: %d\n", ret); } - if (desc->rev > 3) { + if (adata->pci_rev > ACP_RN_PCI_ID) { /* Cache Window enable */ snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DSP0_CACHE_OFFSET0, desc->sram_pte_offset); snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DSP0_CACHE_SIZE0, SRAM1_SIZE | BIT(31)); From patchwork Wed Aug 7 05:13:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755641 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2046.outbound.protection.outlook.com [40.107.244.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744B317AE1D; Wed, 7 Aug 2024 05:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007713; cv=fail; b=IcyDrWRQXRbc7oP87khyXr8H0kGiFS7JPXwDiZ2koN03LgWaU+bDoh+j112cwJoeEHtRmhlVNSKiMyiDKaHDymd7dBZRmFZHowI+IHQRoemsnNAnFPkHH9oTDVAzJVuiGRc1CdnZRhvGYEHJrRg9LXM96R9mqO+F9+oSi+73eYA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007713; c=relaxed/simple; bh=Yyh6nCD6uVaoGEFI0zqZzXeuR2btH2C6BgofcihcDmI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TRWJUZ6mEIuU35UjOolRzAhisTP2GH9CM/zZxFV+z/IisJ5HYRYhCTG7cWwHcdALsW+FAGZUdobu8NkCbZlCEe6hOfYG7ziOHJkS8gLNg6233ccnx7AL5CHlOiyxWBBAvVf15acJpmFfDss1OngBqWSyHMlzVJl9tL/Ve93hbSE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=xCZmnvOH; arc=fail smtp.client-ip=40.107.244.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="xCZmnvOH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j7LzSit+S0IUjokL9Qd2SoRNqLVfowB1eE6aV2WFCsYTM6UIUaH3V+GrmQ6Y73s3Q5fSW7dfi5VTJ0f5vHMrhgQt8uW0MEDXSnpFQAkgRmJ6OnxvNvh1XIaoCUqeGiRcjT7UsTnEunJtH7dNQQWmNW3Rjdso1Aujyrmt1/javMrJeDYUNxQM7AItXSIwaxOj3B4K0UugHgKOH+xsgNx2KihvQSWrviXzBCi0GJ4wgPTyBbfvmBoa2jKkOrcbNvYh+m7Y7vABlpKLWpZ8lcBO1tESOgNIo85gJBNgCzOLOZ4HUl/EjChQMN4WQ0lj+O0B6dTIrXF9XMuWXJvX3FQ17g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a+POgkQwJwZYUqG1jCGpOn1i7TKe6P4D3ciPqtPdWC8=; b=eLeI7CeGZsCV9h+vYa5+tsYX1lvRBlqvwoLBUGis85iK9Pjc/EsWAmwR11fAFppMedj2g1fX/IUfQSiE4BNZv/VE2yCWQRQjgibFvo+W/WN/TOEdtQa+fQl0BFgNCzPTxjawTrolGGs7fq2NWE8RPQvyNEnNkpXKyDyK0rhW4cddObN6fKSlZroMaqZjfv0jMI1MUmgQQeBQNtEiMi/Lv9dU3ZE7U4Ixr6qsJ3ysomiVgsyqIMKCNsa3QhVfKuvOy1D39zRjyw3WdtPL44fhKSPia4eEJ6yiyqDqB3vo1YRKE9Cwcw+99betJWQXGl1IPR4G94MhLkCiCISoVaAQXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+POgkQwJwZYUqG1jCGpOn1i7TKe6P4D3ciPqtPdWC8=; b=xCZmnvOH1yHtpp5osck2Xq1UbSua8ygQ5aKpsTrqlGKho7+G03ysq/6+c4NSkeWQf7rBo/Uz4KOh9iI4dOu0zkEQ8Xj5Gnh0vdkhOQtH7c8FSy/PgB06UwSN5TF74vzeNLj6oK3H4NoqwfsHBGvD8P8okUrEJqeVR6+gancBkrU= Received: from SJ0PR03CA0010.namprd03.prod.outlook.com (2603:10b6:a03:33a::15) by IA1PR12MB6652.namprd12.prod.outlook.com (2603:10b6:208:38a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Wed, 7 Aug 2024 05:15:08 +0000 Received: from SJ5PEPF000001EF.namprd05.prod.outlook.com (2603:10b6:a03:33a:cafe::40) by SJ0PR03CA0010.outlook.office365.com (2603:10b6:a03:33a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.28 via Frontend Transport; Wed, 7 Aug 2024 05:15:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001EF.mail.protection.outlook.com (10.167.242.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:15:07 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:14:59 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , "Kai Vehmanen" , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Emil Velikov , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "open list" Subject: [PATCH 6/8] ASoC: SOF: amd: modify psp send command conditional checks Date: Wed, 7 Aug 2024 10:43:18 +0530 Message-ID: <20240807051341.1616925-6-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EF:EE_|IA1PR12MB6652:EE_ X-MS-Office365-Filtering-Correlation-Id: 8111f9eb-48d8-434d-46ee-08dcb69fe732 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: CR6uIB+FkIlT3Pyt2spUTXfvLKQyFFQG77kJ6OMwnAYPnbOLHWP5UHNX8+KAotvGyOhCQ60HskalBPJP6tKjx4412IbLUhVT38jqw88F21lW3RS4HPzFwh2jbdLjIzDuQXlFFM/QXle1DEcFvORkemKN9iKTSKUrXPBf+XbonVgla1YxxEGsL5BQAxqWYpFNqJq/QznE8CYWONIl2aV70L/879EbGa/NZfV48YJV2j4Csygx32uzBFBHG0fJ4iOKcDSwtYngBVQq7sjnvvADzW3TmxzvrUxb8DW76THeRHKhkOkpRwd4fvPjQSUVClD+sV6bKCsP4WtsvZ9nop9JYJeWoSXPu4C8OWOH7ymXg9WxgS5AuiuJzzbS7Yrq/j8sbrY0eGuNSItiJ9efreUal0F2cjj0+QEvOhNNwexTVRK7CG1bDzbqgOTzShCA9v5F4GfJ7RGHrmPE43DaNjdAXF7NsNQRp81rjPH1u2SQ2cKKVH4kyiN7m3f4zkCUmemO+//yi6YkZzsOSI0S3mYkv8BCkZxjUKkpIah4QTfgW793xIhv7tuYbaliGXW00WNCwwLQNovKa2vSCzHnzMxz3W5LaKmmYYX81xEalkNbClOMW5ZCISPwvqV5pm4b57rxVlcdks7M6saOANEPCc1yiFToF0nnk2VDIkhS+94INEf9V4j/KR1FcaK3BSHlfMnRgJUTOVd7NxDUfKGoEksvanVAN6WAvh6AJO2tIKAX58R7TlrD2h7XhR8NCyKRnSHp3t+LFQeMWeMLhTG8ZSYKOtsprPcOy3m5wIvbbrdYKISW2nHMXs2OOs+R3zZNL+sv4A2QrmD3fCh+KPd5F54968VBYYlknK55d/5R13YETkivtSrbgmjzsey+hFvqP+kBSFhtdlhA13E3Qy3hszPxapxxCPyW2tOdx/KFXH/W+DYw90kg+j+p5ghf4gootHBl0e9vGzvLZN7l/WkBlUA+vU1TUqqmeYDmS0ANidrZC8S+AzgPorDhYBSejg/0C/YpLeH8glNvnRZ6npgUCeKQLU19jCx0XWXimI3Lqa4rqwnuao96XZ3bEXx8iu9ZGIcsrxudIr2+QE4Q8pc0jn5c1Uxcjlf9Roz2iJjTYxMf+4QBeuwCu0CO1/pRpDBoUUYoNmJM6H+Y8xKHJsNsSl3CZqTla8wHnrHkmHtalBYW5X7kr/+o+hvcfZx1b6uKsmSINDhrHJGCwr0Rl4QD2b1CxTQFoH6aRxvSyjQ6zbIawDLSuuR5PEOToRJ7ysWqfC9vlajkozozi9niEXdcgcg+KbghOPuypO+YNAtxU5vrup3qCbvLrN4aN2lIF8xlj6BQRfbU77Gyllb+apdJguHDnieWWVWc2ng5vnK3gzZlI0y6Gj4qKNSyRUlNUc8PJcV5qoylIfyHGtPJzbzTLcgiUzZD2+bnwJ9u+20O9xbDWb6bo+cuCai7QLtmzFTYiA0z X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:15:07.3248 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8111f9eb-48d8-434d-46ee-08dcb69fe732 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6652 Modify psp send command conditional checks for Renoir and Vangogh platforms by replacing desc->rev with acp pci revision id for that platform. Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/sof/amd/acp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index a9f32983b3af..a85f5eb54239 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -236,7 +236,6 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr, unsigned int image_length) { struct snd_sof_dev *sdev = adata->dev; - const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata); unsigned int tx_count, fw_qualifier, val; int ret; @@ -265,8 +264,9 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr, snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_DESTINATION_ADDR, dest_addr); snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_MSG_LENGTH, image_length); - /* psp_send_cmd only required for vangogh platform (rev - 5) */ - if (desc->rev == 5 && !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) { + /* psp_send_cmd only required for vangogh platform */ + if (adata->pci_rev == ACP_VANGOGH_PCI_ID && + !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) { /* Modify IRAM and DRAM size */ ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | IRAM_DRAM_FENCE_2); if (ret) @@ -285,8 +285,8 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr, return ret; } - /* psp_send_cmd only required for renoir platform (rev - 3) */ - if (desc->rev == 3) { + /* psp_send_cmd only required for renoir platform*/ + if (adata->pci_rev == ACP_RN_PCI_ID) { ret = psp_send_cmd(adata, MBOX_ACP_SHA_DMA_COMMAND); if (ret) return ret; From patchwork Wed Aug 7 05:13:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755642 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67E3418FC74; Wed, 7 Aug 2024 05:15:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007733; cv=fail; b=mwOM4vjoJWJft3tJMUKk8OJiMRwxuRtCKiblOr6r7AnT9Vn3h9kzpuVUZrSAIlEAOyO39EIFUJRBfG2N1lmu5ak5wTUta2UMVwVttSqOF9UZBpLi5VzqtvdK2uHCykKfKcn/j8NddvyidCRnU7ozd+Hv06igMyWgHoJ1jtunCek= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007733; c=relaxed/simple; bh=ieV+xBrhkWPYSpApUkwfDqYXotPUkyJV9b3CxxMkmO0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KVjPiIlP0jYcXJ0jIgaqFDPB+4QpGf/4A9C2vLDJOmSWR9f8L+3uCL567z9F1FjUkhRVf/FlgQcLVy+3WCRQ0Br94qN+bpUeqt4CFRS3x4eShBXjouBlmdGobtgEFWDHGSiOQfZf5DoeZwc/bs2SvwNuHSSRMO1gU7KaSecpnbA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=MRVpj2R+; arc=fail smtp.client-ip=40.107.220.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="MRVpj2R+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A7DSFCgzuox7QYkgOC/npu5B6nepOwSVXUEQnxCYerNO8sveZYDSENCTjN5b7lP/4oDbcaromwc7ktNFDjjjc/y3jiRgMDti1pMcGfayJFbnmLRoKZWiVFnYufL9NQNdAIis751aeP8XfIa1gMRH6B1ljV51RgyhiX/QIqYLecuY1fC4zXOtVrvBpmv06WPa2L50Dx2T680HlAsXt7Mx+NF/WDLXZ4T2vK0ONnakSdIGDemzWX/AoCitd5JfuW1+HpTE6DVlPyi/hdxTtBdA76GiioSoKuO61nJpbpuYHuYjnmS9iuO4aM7z6qeS37sjZXR13q8J/sZT369riX7wvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sxkBInJSWtS/+2b8sbBeUAK9a3OMWSIdNo6kSvk5wFo=; b=DhZBq4ZlcrDFochazD8BMND04CXWS5MxvxPBcqT7lxItGFo05GH+uxG48d71yG1C4PFMp9ftY9tAQAzZygzcXMI0Gx5+Fdo4g7FDMYWKVSyHiNoZzcySVYG4SLCIEPr5/onlSl0UbmDNlpo0nhtKcAeZ6dFsx7cuFFuZ4bGaDrBbAgP+iJpbLitO68hcShDyzF/As2XDoo1HsV7EoHBz97rWOJ2RwgebEcp5e3sRn+uBnhvMYr1ItuZCG+h9NpEYILUrcNXqNNt/lUctruo5gbpkaa49PrrwAhZkquDzrNJpHtrCh/QDQn2cnyvIeTX5ePztUmKJquY5sCco2DR7JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sxkBInJSWtS/+2b8sbBeUAK9a3OMWSIdNo6kSvk5wFo=; b=MRVpj2R+9F6crf7n0i0GI2QpHQsvB7CgBLJ907Z69ob7JkzgfPxCxxnRiq2sSlzrTcSYSbZzjsopHXLn1VSbyku9Qkh1hQzw580neY6m/4PHr26L9w79Dwcy2YoCDEHR8Eb6ItxL6TXxl/kU6UBNfX+mFn9JoXC+ZDcqXzRvfa4= Received: from SJ0PR03CA0070.namprd03.prod.outlook.com (2603:10b6:a03:331::15) by SA3PR12MB8763.namprd12.prod.outlook.com (2603:10b6:806:312::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.21; Wed, 7 Aug 2024 05:15:29 +0000 Received: from SJ5PEPF000001EE.namprd05.prod.outlook.com (2603:10b6:a03:331:cafe::d2) by SJ0PR03CA0070.outlook.office365.com (2603:10b6:a03:331::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.29 via Frontend Transport; Wed, 7 Aug 2024 05:15:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001EE.mail.protection.outlook.com (10.167.242.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:15:29 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:15:23 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , "Kai Vehmanen" , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Krzysztof Kozlowski , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 7/8] ASoC: SOF: amd: remove unused variable from sof_amd_acp_desc structure Date: Wed, 7 Aug 2024 10:43:19 +0530 Message-ID: <20240807051341.1616925-7-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EE:EE_|SA3PR12MB8763:EE_ X-MS-Office365-Filtering-Correlation-Id: dc4f9c7e-8a07-42ac-30b4-08dcb69ff45a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|7416014|36860700013; X-Microsoft-Antispam-Message-Info: 0rIKBakFylX0qD1lH3BJx6apGlANGJ/miyttHVrzsuU/J8EeMz7g13m8bt/m6DXyfkWHlIRQFx1OU5OHU+gjKQM7Ql5i7y0aBDAefMl+IgAPUWei1fiO/mviAWLDPMCDvm3N+MGSf7a+3/CMQQXWXS5GGsUGZflkWT7UrgMMqZdxdJBV8dZfZRSivxegsvhSQ92wFrnhjljZRRwWYLcKkPAWKigMYbdRm2bNIZtao0LBdi9AF58fHqKTWFrnUMts9vg884+lQU7SpplNfgra6RmW7pWZCK/i7JkOMfO6/32WOhsoZ6h1P4ILJCjHrpndT0aQPrTqDzFwRHS3k0zNqWsgY8FyDcYANGm64SLEGmf9FfUnquygtPFnyxTsVoFgfXFWCZe4OflGWTTxu79W2hs7wb5z5Lt137ENcLJrC0w8YNUChj2Dgf4W1ZsN4N+pmucGVDKNZ5oOPBlOszQgW95VpPgsXLvcz4eVnczBYFs3bN2pcvFH5CHCy93jgGfRmBXt1d8wq43ETGMFJBIDWBExzKJa9fQTP7hSdAMsCELrzeB5hgML9vy7d6K8gU6v+vY6FcdxoxBQO6FIINtapHoeQdvTCrCjFmXQx1VaXXbmMX73BfWZTpYo6LPZy3vrUBE+RsmPiyILGVJNSZdqnaG9lA3SsLyI2Uso32RGel+WmmrKyjZk5iaPV1NricG1DbVM1uQzkCHga4JShKZy5B6c+SKTkUxaxiRTmXHn8vJhil0qSr9pKYrNcsGuztXNtmNk65HemZ4hYYpGGQDLz6wPZy1QxbH4KPlpIxYqm5CJyqDYWeq42heY4LYT0EbTysyvelbY79Slux3tFFi/kzDlhv0+uEnsjxqhGJF3A/hWdKVr4uceaMR55MrYdqUz0bZgMrXM1lTQ29jubTiBt5vvqi1Ga0XA4kijNiqFV6KpBE5SedLNdHXPOjA79jFfeT8+Z+kOTVyvlE0nzW53DusXuqbAIUqFXrPMLBRSWY94B5QS+0VESS1b+OTvtC5KogWbtKfM9d2+XXio6EBKZXDk6WldgEywTgsbyMGfKW7QVK6en9PZi6tU6S6WtzjzBLGMjqwWnYon/45C6Mk9izQprnkL3cZDt4PHjZQIRIodMH5ZnzOareI/F+uV1PNDgFiDZwXUQsjeLwg4hBgTYt6HDaF+tLJvcVTLJxWOMgFk0+6DSO8VLnCBGuhl10c7p5tcfSSJbudaDSoZoYT8O994w8w6fYeK3QqiziqfYXBWFD6xX8OhXqHP96CHLcyTMMwlxyFRdkBZxuJQVR9qOTiNaZAFrE1lqm/1+3LycC0yec+43llLuSL3oNzlrPvdNJxXL1gNc0ppqowBlrAZI7oq8bIGunr4tnLlNwN+4k48rPKNFTmiTYO65qtJdT+H7x0spwCbylYjKdnRQchVKYjOQ87NcyX37GGr8JZDlfl2ErW0O7A+Wdj2PKgL68Rh X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:15:29.3811 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc4f9c7e-8a07-42ac-30b4-08dcb69ff45a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8763 Remove unused structure member 'rev' from sof_amd_acp_desc structure. Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/sof/amd/acp.h | 1 - sound/soc/sof/amd/pci-acp63.c | 1 - sound/soc/sof/amd/pci-rmb.c | 1 - sound/soc/sof/amd/pci-rn.c | 1 - sound/soc/sof/amd/pci-vangogh.c | 1 - 5 files changed, 5 deletions(-) diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h index 321c40cc6d50..11def07efc0f 100644 --- a/sound/soc/sof/amd/acp.h +++ b/sound/soc/sof/amd/acp.h @@ -190,7 +190,6 @@ struct acp_dsp_stream { }; struct sof_amd_acp_desc { - unsigned int rev; const char *name; unsigned int host_bridge_id; u32 pgfsm_base; diff --git a/sound/soc/sof/amd/pci-acp63.c b/sound/soc/sof/amd/pci-acp63.c index e90658ba2bd7..b54ed61b79ed 100644 --- a/sound/soc/sof/amd/pci-acp63.c +++ b/sound/soc/sof/amd/pci-acp63.c @@ -28,7 +28,6 @@ #define ACP6x_REG_END 0x125C000 static const struct sof_amd_acp_desc acp63_chip_info = { - .rev = 6, .host_bridge_id = HOST_BRIDGE_ACP63, .pgfsm_base = ACP6X_PGFSM_BASE, .ext_intr_enb = ACP6X_EXTERNAL_INTR_ENB, diff --git a/sound/soc/sof/amd/pci-rmb.c b/sound/soc/sof/amd/pci-rmb.c index a366f904e6f3..c45256bf4fda 100644 --- a/sound/soc/sof/amd/pci-rmb.c +++ b/sound/soc/sof/amd/pci-rmb.c @@ -28,7 +28,6 @@ #define ACP6X_FUTURE_REG_ACLK_0 0x1854 static const struct sof_amd_acp_desc rembrandt_chip_info = { - .rev = 6, .host_bridge_id = HOST_BRIDGE_RMB, .pgfsm_base = ACP6X_PGFSM_BASE, .ext_intr_stat = ACP6X_EXT_INTR_STAT, diff --git a/sound/soc/sof/amd/pci-rn.c b/sound/soc/sof/amd/pci-rn.c index 2b7c53470ce8..386a0f1e7ee0 100644 --- a/sound/soc/sof/amd/pci-rn.c +++ b/sound/soc/sof/amd/pci-rn.c @@ -28,7 +28,6 @@ #define ACP3X_FUTURE_REG_ACLK_0 0x1860 static const struct sof_amd_acp_desc renoir_chip_info = { - .rev = 3, .host_bridge_id = HOST_BRIDGE_CZN, .pgfsm_base = ACP3X_PGFSM_BASE, .ext_intr_stat = ACP3X_EXT_INTR_STAT, diff --git a/sound/soc/sof/amd/pci-vangogh.c b/sound/soc/sof/amd/pci-vangogh.c index eba580840100..cb845f81795e 100644 --- a/sound/soc/sof/amd/pci-vangogh.c +++ b/sound/soc/sof/amd/pci-vangogh.c @@ -26,7 +26,6 @@ #define ACP5X_FUTURE_REG_ACLK_0 0x1864 static const struct sof_amd_acp_desc vangogh_chip_info = { - .rev = 5, .name = "vangogh", .host_bridge_id = HOST_BRIDGE_VGH, .pgfsm_base = ACP5X_PGFSM_BASE, From patchwork Wed Aug 7 05:13:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 13755643 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2064.outbound.protection.outlook.com [40.107.244.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B201F190464; Wed, 7 Aug 2024 05:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007744; cv=fail; b=qrBhuub7qnzW2u4BuEgiMWEsM5uSTH4rK+YQHSq4FlSqn7h0mocVKSw5tIHtYktNLp+aQ4GX14GaQrJqhxHNDugHFh8HYAAvWxuzMsAi+DgjWAbO7/hePwovtrdRIMKPXhxh9eIz50PNh7Y8E4UtCvnFqWttvElfB6hKIti6+gg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723007744; c=relaxed/simple; bh=QxszdzAXMtanwDxUmQhoRcJ8Iy1ocp7vJQhlv0/g38U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tN/nwm1EHOA35NiM6FbNwJYwqAUL/J5R2RuwzR3lIuRajTOm9d/lVYlv8VgkD9BFB1/zb4Z+DW6GUpqvj5Zzn3dyg0JcED68Mx6P9mamIAgGwUWPa3bQbjVPuFiNhPJKMbhoXGI5NQSYjWX4XgnfVSNpkrieUJVfqarSjweOE3w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=rSw/VF0P; arc=fail smtp.client-ip=40.107.244.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="rSw/VF0P" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NPFAj0WKooqKpfIVtyTSLXXJUB6OqEECZ1/226G4oQljaLZ1uj8Fqc8gJtAnBVM8X8efo5ElaVxwR1dgL6jlpFPIFkNp8dS4IrLUx5lmc5DpEwh3Z/qaDYRTdnsqzBqYPSMKk/RdEq9+x3oJNdEzvyFeafpzLYq26KQORApNLnikIgjtA5GGUT2iLoGnexsgjvuzS9HC4DUAnUpRgNfeUWXRqCLO20lXsxWmQP8/ypkzS0nSFervFei7qNst0Bhn7IPeK5bCEApDj3w9HNCGOngULs6NbGvQFn+OHq+RfJTK8JxS5MUdsZHuSPTLv7+mjyMJvksfXNcPkz250+m6lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UBNfv35Z9aYp/a4IbdRFX7G0RUSMVnZLZzGXQqLX6hc=; b=UfTbV60a19REG+chXsqYsOhDIsndcSHoRCFwVpLdTEl3FSLxZ0UKpRyNj97GjndTvXZ0x2afWxVulec7riThizutXe+/9IvNILoN+e6ak+r2a/ovDeI2DkJgdEyeBhBqzsos/j8EqOmpwnJBGVwdawlE50fSTU9yKLK+VXXdpMMJANDlvJwglyaJJpa/RXKTWil53oOFc4H4UU+lvHFRywt31MySPC4+aoWXB7ttsTiIVaE9/e4QCg70Gwv1fZWotTs1B4wLxHB8zVEk9SFz8J3gTWgxLEEGEwioY9e5QR5LcxDICiFs3uyk2BmRmMDNZZEdqDr/dSALIp3OGZ6fOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UBNfv35Z9aYp/a4IbdRFX7G0RUSMVnZLZzGXQqLX6hc=; b=rSw/VF0P6gYh5+JiRSzLmkZ6bUAiSOhTfd7v9dSOh8NjfgOHW5/CHDHjSkiyXmFywfqh4epOzMcstDDK1FZu+33b65wvhgGk/s90ikmCfoiSqsxte27K50+qupkjC2zf8g7ULCN/JEVxhran1XCB1uqn61FMcUDE3Vp18Q4ZMN8= Received: from BYAPR07CA0042.namprd07.prod.outlook.com (2603:10b6:a03:60::19) by SJ1PR12MB6169.namprd12.prod.outlook.com (2603:10b6:a03:45c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Wed, 7 Aug 2024 05:15:40 +0000 Received: from SJ5PEPF000001ED.namprd05.prod.outlook.com (2603:10b6:a03:60:cafe::6b) by BYAPR07CA0042.outlook.office365.com (2603:10b6:a03:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.27 via Frontend Transport; Wed, 7 Aug 2024 05:15:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001ED.mail.protection.outlook.com (10.167.242.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7849.8 via Frontend Transport; Wed, 7 Aug 2024 05:15:40 +0000 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 00:15:35 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Bard Liao , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 8/8] ASoC: amd: acp: Convert comma to semicolon Date: Wed, 7 Aug 2024 10:43:20 +0530 Message-ID: <20240807051341.1616925-8-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001ED:EE_|SJ1PR12MB6169:EE_ X-MS-Office365-Filtering-Correlation-Id: 1278b9c5-4887-49a1-b6de-08dcb69ffabd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: CCjfe8bT+0dUWTKqOhhv5kHlwGICHPQACsTOgKv2DsRW9x4PiEIIOREXwsS4k5ZLTriikPHoXy8q7PNN6Xus30J/sjCb/VW6EIg7fxfQFcXcl+CiheI9R+HA3Ge9A1L8xTqnIdpRGo52Xe43raNclaC5BOLtQfxecpm/VKJ4NWhEhxeVusfuXYOlW3nOFu5j2JsH8vZUgXVri9TRKtISl1s7myPy2xzog+MLAAczivYEh8nwTevLAhdjNhvZcOtVRT6QXIGq2VuY9D0yHpMccFLUuhLDB7SZKYasJQkn0IXiQJA9zcYLE2Vn5qadXt9n6mwZwnQTkAYbMb5ZEGGY5WJtHxzjry27CmL+FzkkS80VB435R/rphxY0Thjs30ZbApbrN8krZSzM3CDzn0Ud54O/znrt2Ep2AA9r1UAkRxFkqMoc50xO36lGFXVAI3MjK7pmsJiDunm5adAFXvRn9cJjRI70T0OmwPG6/deqcY0ZIPPx/w8kWHKToiCMZBM3KRkvmj4SVUYso6aBVwbxkciLfEB+wgSEThIpQb9TzpuIU6aGD/VzkB3F79unCKpBauoq5YRWH+Q9zInJ7MdbrOH3RyQFfIFxxIFZCt9kBTRn3X77NHuCr1MFEtudYNN2ZqRu4BJHG1m7KTbryqP/3V0Pr3st0cvDeJ4LEQmGQCZkkh8ChJIMrE0d+ODLZVO6YURhS59/0hWpMqCbS8mWOalqVgbZXmR1U+wuupJhWxSbSpcflcVDqWZrSqyXr0U0HZPx0diQEkfe3mhmvEqd3LxJNVxrVnX9Q6dQdKb2AOqwCXeMjXP14lDOX84F3GhSE0l7sYmd4N8bn8IHJ2SjUTXnRDwgydP/PqVzHOxScG6cdpWTlMqzgD2kBuO/3zznHvDEx0FNlZAxFWDlQkXCg0CyQI4EFkhc9SHFt0BxmBHvvh9U2SUIow395/Ls/mrEMB8IitmVeuKxSPbyfUYE8s8Gj4dCiTxob2S7BdSEUHoVhjA87m4GSjJ9+OzF5p+rcOJP2HNpG08jpucxKfyBPUAmGly36Trs17GETIakDEcm6avI4eO9TvFGCqUqmlI4MmxRULHA4iK4bGOaPcSr+m1BT6ZFjsvdFZSaP+twZ9bsDMWE48E7rpvEG7NlaelOe7KDRmmq74ZyEycbFFuFWTLZ07Mky0ttgvnyW+pLEU1lqTPjTyGqgUUnK2JWtBt5PLP8w5c2qOhZJsrKUqWW0r8cfY5OJPNqF5smyl4f62aGxwBEdOGWHdoJJLcr0j5IOl1zKekAr6nMN7iFTrb6w/XC3tku0to99+pg4kMrXRwahADTJXAVej0aEiQcdRjIt/oVrP2VV/FX9MYPy7E//F6e4NRsb6NRyYElMLktjvy1+nHHWM1hnACzMTFQEMtiKNoejbTm6ktmgSYzPYP3KyOjxkL14RGbuSdIUGjyVw+bJB0YYWFqz/pR/lJ8SzRF X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 05:15:40.1153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1278b9c5-4887-49a1-b6de-08dcb69ffabd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001ED.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6169 Replace a comma between expression statements by a semicolon. Signed-off-by: Vijendar Mukunda Reviewed-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart --- sound/soc/amd/acp/acp-sdw-sof-mach.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/acp/acp-sdw-sof-mach.c b/sound/soc/amd/acp/acp-sdw-sof-mach.c index 3419675e45a9..0995b40d15f3 100644 --- a/sound/soc/amd/acp/acp-sdw-sof-mach.c +++ b/sound/soc/amd/acp/acp-sdw-sof-mach.c @@ -657,9 +657,9 @@ static int mc_probe(struct platform_device *pdev) ctx->private = amd_ctx; card = &ctx->card; card->dev = &pdev->dev; - card->name = "amd-soundwire", - card->owner = THIS_MODULE, - card->late_probe = asoc_sdw_card_late_probe, + card->name = "amd-soundwire"; + card->owner = THIS_MODULE; + card->late_probe = asoc_sdw_card_late_probe; snd_soc_card_set_drvdata(card, ctx);