From patchwork Thu Aug 15 07:28:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13764468 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9C41C3DA7F for ; Thu, 15 Aug 2024 07:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qrs2P5OJlmr0lgBiFqTQyhVZyN18HkIExX3lKJ6sUb0=; b=nN+KYotaoRjLHJiR8K4Tn6wT40 OYxSWRLehM2hlLMteOoH89FdvV7rsSfhGETtIc8pfnIX3QF6uDH0eHcgr9Mm84Eo/C3b/mcqlOsXi 6wLq2vuM7VwTmFRPVmwYmczQlo/YKsnhEdBf9MNmF0OW8IXvvFiYjhmuXZOKUiQo7SrewrrBhoZQg MzBw7r0TIBmdRi9MSssuCXAq26BeqVo7u1d9qrXi8bnmC1eYSQXP21ptlq/B/do0AfXjHd/KlDeWi CdlrQzdhNVqCz7KyW2YOdMcUo6x5C3eDYScB2eD2bfpcis1DeKic3ewd7WEcvckWSHjQg6S2CEMQ4 k8owRKZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seUwr-00000009Hib-1mFX; Thu, 15 Aug 2024 07:31:05 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seUvk-00000009HNY-299e; Thu, 15 Aug 2024 07:29:58 +0000 Received: from [127.0.1.1] (91-156-87-48.elisa-laajakaista.fi [91.156.87.48]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 180A6827; Thu, 15 Aug 2024 09:28:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1723706935; bh=bn7hb6abGotN+zJtZ8HsRWN0WBNQG9WEsGLPob3ZvdA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Z4vlJVxsoddUbNjmQ/ZWgs6CXr4epUbUWq2TSIb0cOEZEglXF4JA8TJb2Xrj8L+Ob FbMfa6l1zefPIGpouCGMLK97+kkwfVbEpcujVDZr4dYRBR4KiBCBWfX1yeBRrpbCfc /qMmjm1kjyb8MaTLCKz2mpT5bOT24BNtQB9QHD2E= From: Tomi Valkeinen Date: Thu, 15 Aug 2024 10:28:52 +0300 Subject: [PATCH v3 1/4] media: uapi: Add meta formats for PiSP FE config and stats MIME-Version: 1.0 Message-Id: <20240815-rp1-cfe-v3-1-e15a979db327@ideasonboard.com> References: <20240815-rp1-cfe-v3-0-e15a979db327@ideasonboard.com> In-Reply-To: <20240815-rp1-cfe-v3-0-e15a979db327@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4361; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=bn7hb6abGotN+zJtZ8HsRWN0WBNQG9WEsGLPob3ZvdA=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBmva5tVrV/zbUmV/w0YCQBIy1PpG4gVa+i3UJob vY4J02iYkSJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZr2ubQAKCRD6PaqMvJYe 9dR/D/9NeBqAi3Q9TBQvPDqtI78pv/0U1xeMmHnVZvqOLYrFVdPDwwWQJOZT6T1RjZmlMy2DZ1o ybm4yA3PqIXtFsdiAQRtYsBww6H/RqcBxIvOe0Yiul9DYx9ZS92GGD+A5IqfOChndRYcs/0ImGf ZqIwpygk3uO9K57HLhBbJiJEH1ubpi2z3pq+Fb9/wRrtzaYaUUVrAKmLfk42gbSKezgdVhFH/Pe /qxA+OSb3IJktAmuUd+fiO+XHdT4STxwXvmnABjdSkra0tGuAPca0tvt3QwodO3zrzCri5bRAdG 97TozN1KG9m5UdSsemga8JKoKWMJ8z5lJjEjQ/BANPhL39xi2Y6MIYkeLOLcMWSYzOcghKRc00m e0aKJOEq5DVgCx841OZw2ntYsZ/IMHwKMUt5SvXOYf0fUU/qUWlPUXdg/iYVpuPNNOMF7bAVFsv a7CV1QtMT55lYvYQ8zi/9AO+SBklEpiUuYud7QVVgh4BphtuV6+R39cRhuPg7rrFynsZhJupufG 5RMW1CwJPUuCFQTcpvQkXwYR/dFPf+6FAkGFmr5/gIVfbwvnD4WvcEX/Z72W6y4s1QCvp9hz4/E b8R/PwOEAFi6g9BQH72+MLb+oFI8zc4oht+LAfPQvypx3TCDBVSwkbuW60ObFvNeZcZsf2NqZgi 1AjcM3OphMxzIyw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_002956_735841_62EFC35C X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add two meta formats for PiSP FE: V4L2_META_FMT_RPI_FE_CFG and V4L2_META_FMT_RPI_FE_STATS. The former is used to provide configuration for the FE and the latter is used to read the statistics from the FE. Signed-off-by: Tomi Valkeinen --- .../userspace-api/media/v4l/meta-formats.rst | 1 + .../userspace-api/media/v4l/metafmt-pisp-fe.rst | 39 ++++++++++++++++++++++ drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 2 ++ 4 files changed, 44 insertions(+) diff --git a/Documentation/userspace-api/media/v4l/meta-formats.rst b/Documentation/userspace-api/media/v4l/meta-formats.rst index c6e56b5888bc..86ffb3bc8ade 100644 --- a/Documentation/userspace-api/media/v4l/meta-formats.rst +++ b/Documentation/userspace-api/media/v4l/meta-formats.rst @@ -16,6 +16,7 @@ These formats are used for the :ref:`metadata` interface only. metafmt-generic metafmt-intel-ipu3 metafmt-pisp-be + metafmt-pisp-fe metafmt-rkisp1 metafmt-uvc metafmt-vivid diff --git a/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst b/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst new file mode 100644 index 000000000000..fddeada83e4a --- /dev/null +++ b/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst @@ -0,0 +1,39 @@ +.. SPDX-License-Identifier: GPL-2.0 + +.. _v4l2-meta-fmt-rpi-fe-cfg: + +************************ +V4L2_META_FMT_RPI_FE_CFG +************************ + +Raspberry Pi PiSP Front End configuration format +================================================ + +The Raspberry Pi PiSP Front End image signal processor is configured by +userspace by providing a buffer of configuration parameters to the +`rp1-cfe-fe-config` output video device node using the +:c:type:`v4l2_meta_format` interface. + +The `Raspberry Pi PiSP technical specification +`_ +provide detailed description of the Front End configuration and programming +model. + +.. _v4l2-meta-fmt-rpi-fe-stats: + +************************** +V4L2_META_FMT_RPI_FE_STATS +************************** + +Raspberry Pi PiSP Front End statistics format +============================================= + +The Raspberry Pi PiSP Front End image signal processor provides statistics data +by writing to a buffer provided via the `rp1-cfe-fe-stats` capture video device +node using the +:c:type:`v4l2_meta_format` interface. + +The `Raspberry Pi PiSP technical specification +`_ +provide detailed description of the Front End configuration and programming +model. diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 5eb4d797d259..95c2c4a97966 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -1466,6 +1466,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) case V4L2_PIX_FMT_Y212: descr = "12-bit YUYV Packed"; break; case V4L2_PIX_FMT_Y216: descr = "16-bit YUYV Packed"; break; case V4L2_META_FMT_RPI_BE_CFG: descr = "RPi PiSP BE Config format"; break; + case V4L2_META_FMT_RPI_FE_CFG: descr = "RPi PiSP FE Config format"; break; + case V4L2_META_FMT_RPI_FE_STATS: descr = "RPi PiSP FE Statistics format"; break; case V4L2_META_FMT_GENERIC_8: descr = "8-bit Generic Metadata"; break; case V4L2_META_FMT_GENERIC_CSI2_10: descr = "8-bit Generic Meta, 10b CSI-2"; break; case V4L2_META_FMT_GENERIC_CSI2_12: descr = "8-bit Generic Meta, 12b CSI-2"; break; diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 4e91362da6da..9f68cd55248f 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -857,6 +857,8 @@ struct v4l2_pix_format { /* Vendor specific - used for RaspberryPi PiSP */ #define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C') /* PiSP BE configuration */ +#define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') /* PiSP FE configuration */ +#define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* PiSP FE stats */ #ifdef __KERNEL__ /* From patchwork Thu Aug 15 07:28:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13764469 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2F50C3DA7F for ; Thu, 15 Aug 2024 07:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1xflaiFG3m+KqEWq6uvtnskKnw6r6UX/CrcX/9HRzEI=; b=X1ge76kBg/nTMVdJNiNLWHliXY ygDNfGEh84t92K70QB9oB5iY7GcL0FUZG4duVmYnMfyCgbnWGtU2YSqYw3bCB+83il0yLx700X/sz sp3TLMoKI1QHDn0hzZLrU0/dStPJmdbCXdMh1zg8z93uB123mDOcpaZWU9OHvtQoZCimCeJetxnK2 Mj5kVIXdiPic93B9TSiQxt/5Cy/RPkzSKGGeYxaGPae7dRDTJxmZ4QUt6M/bTpNLPVV9o4PM70po+ ArJhZ+2EUYAgoc11NdF5jWbSPxm4PRPpMxmoEGKMf/iWTBriuJolgOmhXvTSQLO1KfTrKonMhrVYp oR9pXQIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seUxe-00000009HtX-13JS; Thu, 15 Aug 2024 07:31:54 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seUvl-00000009HNa-0R9c; Thu, 15 Aug 2024 07:29:59 +0000 Received: from [127.0.1.1] (91-156-87-48.elisa-laajakaista.fi [91.156.87.48]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 284B7AD8; Thu, 15 Aug 2024 09:28:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1723706936; bh=LTGYVECr/4UG+67KVgOfDzOZKmU4a+lQj00GmjRaLUg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Enam7f6oIwdFk1h4MKj0Rhb7E84saYESf+MqD30LGv4BwNDHd309MM7gBTDlrbI+u 5V0uwfO9D4DRq7kF75pAg5faDfVUQmKR9oSCE2bzWuZVn3LW9QLNKasrFO1pMuHWgn dnBCoE9kywhhBbagrRz//+IFJqx4rpFhVF1NISWA= From: Tomi Valkeinen Date: Thu, 15 Aug 2024 10:28:53 +0300 Subject: [PATCH v3 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe MIME-Version: 1.0 Message-Id: <20240815-rp1-cfe-v3-2-e15a979db327@ideasonboard.com> References: <20240815-rp1-cfe-v3-0-e15a979db327@ideasonboard.com> In-Reply-To: <20240815-rp1-cfe-v3-0-e15a979db327@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen , Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3029; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=LTGYVECr/4UG+67KVgOfDzOZKmU4a+lQj00GmjRaLUg=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBmva5tAVP/qCN0SxDccOoK06h4qGO2CpUFt0K0c 3kH9Qye7HKJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZr2ubQAKCRD6PaqMvJYe 9bmfD/wKVjZDLlHDVDAU1nOYgm0UaFC7Myhq5CvCtW701wFfmCmYVSjHYfDsbICobgT4u6NwFKV 1g3HntQVgb58OD7CtjkAl9lQBu8jXIh/uGxU/dzZ/WJQvUUP+WTgLJEKxbdqzgpgCEnmzcZ7YR+ lXr1n/YxWN1o+DUj5QQHqIzwbBd7u+OV6sp9xrVFH0rMB97lEGQWhosUDSXLZFbu97a9bem3sCY AaZMY5hO82V3VvSXWmI4PAW/uF5QhChKRvSvmDq7q8JSKZsLT4zRTyJHdytk7q2WTAdnsMZQGZe K21Yf6oaYreWMfjiwX0h4WKQSnU01cyJkzuEJHbS9oCml4HkgZVC8srXnIIGg3HFx1uLM1NUxH/ GF+7c9fNkhB29/G+5L/h1ZGCsJ8tTa5gRUhCU4TWXtwBcd1wXGPOYqUgw+R7Mt+kIpXr2E9tv7g UTQ7kS60TUOgYjbaw8H+aEC01yfQvTnE1mCa+5NnJgRyz+kq9P7K/HpuEsUl/pBKo8mfHySWN54 ZFhE8H7Mt0EFH0tC09Ed6tj9sCTocmXsUbg6u84l2b/JiLyJfi4RUH2o70yWfu8CwVUua96NFZb OgmDj33Xy3EOm6SV7OcBL6j3pNDuyqn+Rh/TD3gk4nwhP4hZYRLhlEWbwrHAyWj9TDEpSyofEYc nLxTPR70zcThaUA== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_002957_440628_DD2A90EB X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add DT bindings for raspberrypi,rp1-cfe. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tomi Valkeinen --- .../bindings/media/raspberrypi,rp1-cfe.yaml | 98 ++++++++++++++++++++++ 1 file changed, 98 insertions(+) diff --git a/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml new file mode 100644 index 000000000000..851533de2305 --- /dev/null +++ b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/raspberrypi,rp1-cfe.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raspberry Pi PiSP Camera Front End + +maintainers: + - Tomi Valkeinen + - Raspberry Pi Kernel Maintenance + +description: | + The Raspberry Pi PiSP Camera Front End is a module in Raspberrypi 5's RP1 I/O + controller, that contains: + - MIPI D-PHY + - MIPI CSI-2 receiver + - Simple image processor (called PiSP Front End, or FE) + + The FE documentation is available at: + https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf + + The PHY and CSI-2 receiver part have no public documentation. + +properties: + compatible: + items: + - const: raspberrypi,rp1-cfe + + reg: + items: + - description: CSI-2 registers + - description: D-PHY registers + - description: MIPI CFG (a simple top-level mux) registers + - description: FE registers + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + description: CSI-2 RX Port + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + maxItems: 4 + + clock-lanes: + maxItems: 1 + + required: + - clock-lanes + - data-lanes + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + rp1 { + #address-cells = <2>; + #size-cells = <2>; + + csi@110000 { + compatible = "raspberrypi,rp1-cfe"; + reg = <0xc0 0x40110000 0x0 0x100>, + <0xc0 0x40114000 0x0 0x100>, + <0xc0 0x40120000 0x0 0x100>, + <0xc0 0x40124000 0x0 0x1000>; + + interrupts = <42>; + + clocks = <&rp1_clocks>; + + port { + csi_ep: endpoint { + remote-endpoint = <&cam_endpoint>; + clock-lanes = <0>; + data-lanes = <1 2>; + }; + }; + }; + }; From patchwork Thu Aug 15 07:28:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13764470 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB482C52D7D for ; Thu, 15 Aug 2024 07:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kncMR9E8VHOybEPf6D6AZqvUKUCYvL+7V7vYdCgIAQ0=; b=4ppSHwrtpIvsl7cR6MMCCbozFZ rkJfZ/E5Z6FHNf728Teh+TMuUYRq5DqjAfEMHHikNNcpcurGQzFFrFHuFDPfKZfhT5A19OtqsGWCe 4xiNtL7vtYLgjrDQzrJBdUzKtZsWKQ53c/GTNv/oFZdB46fRXk7FmKKKNMxauuHxhlR3bpBoGD9WB +769jLd7jUDzWIoS9q5i7y4yjd7Y0fDWn0NZZfby1E3HTXqDWw8/ptSY9X44pYRJPpgucIjmrBxdq U1d9LlvgtirvpOSaYnlYbowDAdqFbORzPDqp2LnC0cWIYjXrZ8iHV0x9KuLQzBAiJtPbQcJVSVzCB aAwXJ/uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seUyF-00000009I2F-1yNW; Thu, 15 Aug 2024 07:32:31 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seUvl-00000009HOA-3ZIr; Thu, 15 Aug 2024 07:30:00 +0000 Received: from [127.0.1.1] (91-156-87-48.elisa-laajakaista.fi [91.156.87.48]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7545C16B0; Thu, 15 Aug 2024 09:28:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1723706938; bh=ldQ0outL4QKLwryuC/LIt5eVxQJHAdWhRM3fm421H80=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=U4R2mOSkTXcPHLm6QpKCEpz+Hw54Ax2DUTIDjyXHHbTZTl4MgjpFEgSLamw3a3ijL /fSNpshs3e6I7vGIAn4nMOqKaLdJ+Qz6acAqWbxSSV0s3SAXxMVlJTN+L2K/Pq5P6B j6Oe2IYOl3KEn6TIWKVj4zCcwh2GEGNtrt1Wj//o= From: Tomi Valkeinen Date: Thu, 15 Aug 2024 10:28:55 +0300 Subject: [PATCH v3 4/4] media: admin-guide: Document the Raspberry Pi CFE (rp1-cfe) MIME-Version: 1.0 Message-Id: <20240815-rp1-cfe-v3-4-e15a979db327@ideasonboard.com> References: <20240815-rp1-cfe-v3-0-e15a979db327@ideasonboard.com> In-Reply-To: <20240815-rp1-cfe-v3-0-e15a979db327@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6375; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=ldQ0outL4QKLwryuC/LIt5eVxQJHAdWhRM3fm421H80=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBmva5up5foUzCmunvjcc/xgqkCutlcEgG0jJVHQ cNqUqRY3taJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZr2ubgAKCRD6PaqMvJYe 9RxRD/96nm1jm0YWU+EbYRd+xRk4baJ4K9jCOMw6kFneR1Pzwd8DfM9k5XbvjWbheSymyeMMG4a g7ul8v/7zDYsStYh/07TWVCa7MwrjWe3rk1Lf62Ugr5OT+Oco/Rf5dcSsL8D/AAGkP1G1A4QPZg scC2h2mMxsmm2xJ9uVIW0iMG6PU6jY7AbMvlkj0pCG4t6jS4yMig+QxyK3ipBRMY5T1xQfm2z2h pqPkCAHIvq4CSBlNDSCQdayJHFh1QXq+VtN0nPDGs66e0w2x5QAe5TsNf6PWcXc9OdTusYaiCl5 gmd9fZ5Uie8b1iuwEj13lyj/L792BOgAIEi7HFRBzbw1KFcT8JEnEnuEcUSZHhtCgWiPQc8U6cO vxjau6mfIIfwkqJyNjVQafpzGLJPqMUEu/HC13YCkEaEmd7skGOfiD8joCZSya8/JlLIZDptdNF beNdCJMkAklO7dCKYMbBMMBKvd9EADk5jfpIYCEpwnx0q7rU6Fo9D4nStoIYt6wYcJdaRkddYqa 7SZPEeBcK689klOnwn4pV/Fq8o0dQPHEkT6KeLn9v/+7nAzx7aBNJJbWR11bNCuPmTeN8cxgwHF adVuMuMhFrbnyMf1n5o5HMCH5OoTjnrn4GcrixCVsupSSTOY6rBLFkko+IduXjIb26Ynabc5Dza qXLE4wCMFcD4wkg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_002958_153126_3C110F63 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add documentation for rp1-cfe driver. Signed-off-by: Tomi Valkeinen --- .../admin-guide/media/raspberrypi-rp1-cfe.dot | 27 ++++++++ .../admin-guide/media/raspberrypi-rp1-cfe.rst | 78 ++++++++++++++++++++++ Documentation/admin-guide/media/v4l-drivers.rst | 1 + 3 files changed, 106 insertions(+) diff --git a/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot new file mode 100644 index 000000000000..7717f2291049 --- /dev/null +++ b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot @@ -0,0 +1,27 @@ +digraph board { + rankdir=TB + n00000001 [label="{{ 0} | csi2\n/dev/v4l-subdev0 | { 1 | 2 | 3 | 4}}", shape=Mrecord, style=filled, fillcolor=green] + n00000001:port1 -> n00000011 [style=dashed] + n00000001:port1 -> n00000007:port0 + n00000001:port2 -> n00000015 + n00000001:port2 -> n00000007:port0 [style=dashed] + n00000001:port3 -> n00000019 [style=dashed] + n00000001:port3 -> n00000007:port0 [style=dashed] + n00000001:port4 -> n0000001d [style=dashed] + n00000001:port4 -> n00000007:port0 [style=dashed] + n00000007 [label="{{ 0 | 1} | pisp-fe\n/dev/v4l-subdev1 | { 2 | 3 | 4}}", shape=Mrecord, style=filled, fillcolor=green] + n00000007:port2 -> n00000021 + n00000007:port3 -> n00000025 [style=dashed] + n00000007:port4 -> n00000029 + n0000000d [label="{imx219 6-0010\n/dev/v4l-subdev2 | { 0}}", shape=Mrecord, style=filled, fillcolor=green] + n0000000d:port0 -> n00000001:port0 [style=bold] + n00000011 [label="rp1-cfe-csi2-ch0\n/dev/video0", shape=box, style=filled, fillcolor=yellow] + n00000015 [label="rp1-cfe-csi2-ch1\n/dev/video1", shape=box, style=filled, fillcolor=yellow] + n00000019 [label="rp1-cfe-csi2-ch2\n/dev/video2", shape=box, style=filled, fillcolor=yellow] + n0000001d [label="rp1-cfe-csi2-ch3\n/dev/video3", shape=box, style=filled, fillcolor=yellow] + n00000021 [label="rp1-cfe-fe-image0\n/dev/video4", shape=box, style=filled, fillcolor=yellow] + n00000025 [label="rp1-cfe-fe-image1\n/dev/video5", shape=box, style=filled, fillcolor=yellow] + n00000029 [label="rp1-cfe-fe-stats\n/dev/video6", shape=box, style=filled, fillcolor=yellow] + n0000002d [label="rp1-cfe-fe-config\n/dev/video7", shape=box, style=filled, fillcolor=yellow] + n0000002d -> n00000007:port1 +} diff --git a/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst new file mode 100644 index 000000000000..668d978a9875 --- /dev/null +++ b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst @@ -0,0 +1,78 @@ +.. SPDX-License-Identifier: GPL-2.0 + +============================================ +Raspberry Pi PiSP Camera Front End (rp1-cfe) +============================================ + +The PiSP Camera Front End +========================= + +The PiSP Camera Front End (CFE) is a module which combines a CSI-2 receiver with +a simple ISP, called the Front End (FE). + +The CFE has four DMA engines and can write frames from four separate streams +received from the CSI-2 to the memory. One of those streams can also be routed +directly to the FE, which can do minimal image processing, write two versions +(e.g. non-scaled and downscaled versions) of the received frames to memory and +provide statistics of the received frames. + +The FE registers are documented in the `Raspberry Pi Image Signal Processor +(ISP) Specification document +`_, +and example code for FE can be found in `libpisp +`_. + +The rp1-cfe driver +================== + +The Raspberry Pi PiSP Camera Front End (rp1-cfe) driver is located under +drivers/media/platform/raspberrypi/rp1-cfe. It uses the `V4L2 API` to register +a number of video capture and output devices, the `V4L2 subdev API` to register +subdevices for the CSI-2 received and the FE that connects the video devices in +a single media graph realized using the `Media Controller (MC) API`. + +The media topology registered by the `rp1-cfe` driver, in this particular +example connected to an imx219 sensor, is the following one: + +.. _rp1-cfe-topology: + +.. kernel-figure:: raspberrypi-rp1-cfe.dot + :alt: Diagram of an example media pipeline topology + :align: center + +The media graph contains the following video device nodes: + +- rp1-cfe-csi2-ch0: capture device for the first CSI-2 stream +- rp1-cfe-csi2-ch1: capture device for the second CSI-2 stream +- rp1-cfe-csi2-ch2: capture device for the third CSI-2 stream +- rp1-cfe-csi2-ch3: capture device for the fourth CSI-2 stream +- rp1-cfe-fe-image0: capture device for the first FE output +- rp1-cfe-fe-image1: capture device for the second FE output +- rp1-cfe-fe-stats: capture device for the FE statistics +- rp1-cfe-fe-config: output device for FE configuration + +rp1-cfe-csi2-chX +---------------- + +The rp1-cfe-csi2-chX capture devices are normal V4L2 capture devices which +can be used to capture video frames or metadata received from the CSI-2. + +rp1-cfe-fe-image0, rp1-cfe-fe-image1 +------------------------------------ + +The rp1-cfe-fe-image0 and rp1-cfe-fe-image1 capture devices are used to write +the processed frames to memory. + +rp1-cfe-fe-stats +---------------- + +The format of the FE statistics buffer is defined by +:c:type:`pisp_statistics` C structure and the meaning of each parameter is +described in the `PiSP specification` document. + +rp1-cfe-fe-config +----------------- + +The format of the FE configuration buffer is defined by +:c:type:`pisp_fe_config` C structure and the meaning of each parameter is +described in the `PiSP specification` document. diff --git a/Documentation/admin-guide/media/v4l-drivers.rst b/Documentation/admin-guide/media/v4l-drivers.rst index b6af448b9fe9..61da154e079a 100644 --- a/Documentation/admin-guide/media/v4l-drivers.rst +++ b/Documentation/admin-guide/media/v4l-drivers.rst @@ -26,6 +26,7 @@ Video4Linux (V4L) driver-specific documentation raspberrypi-pisp-be rcar-fdp1 rkisp1 + raspberrypi-rp1-cfe saa7134 si470x si4713