From patchwork Thu Aug 15 16:34:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13764983 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013049.outbound.protection.outlook.com [52.101.67.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81961B1429 for ; Thu, 15 Aug 2024 16:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723739670; cv=fail; b=DvQJlSP/bPBJ0XLnVOqrvWyYKB92sdVAIOpHTpehtkpDxZPsnVjUtScM8M8gVGInJeOOwq52V7uBqZ9GmMTFbcHemncjmvgm9un3J/4W6TabEWQfdY8TqdrtT0mDvWQnQEk3DEjmqpl1wYPlGSY7qK96thCQhwsFfM/lfuVfnJg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723739670; c=relaxed/simple; bh=G19CSiZR3FzaCVgeW+32jKk5th90BcXpwhdT1bO8EY0=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=rqumdlsJYReVIq2qeZucckPmH9kLNsnMhCcpsy79NN5VL21m0KGFDJw1N715/IkLRe2My3sKDMBnTpu6+tFtHwwSOYVvDCSlpEAGgZngI51p4L8zZ0uEpwCbnbczyasyI34Y/17SOcgLUacsRG4mBANf79H1qRdMXlPr0GQh/Mg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ftmxS0wJ; arc=fail smtp.client-ip=52.101.67.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ftmxS0wJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EcGgSKdkUbPRjXnHVgmE1WV3np1kfeeDfZ/vaBJsIxkXmbeZwXk3CqUp+1EmokBmmGQtyag+Ask/OXmXaKGwq8kIarayqVHZtZ21/ZDc2uuUUQ0uLccoKMVaB+FEd4Z4hcb8Yt15aQcEC8XCCtR+WNMwqGQeHXjs2TgGmSJilvQN1Rf61SKY5i9biY0osDO92ybfNOIaxkN93WR4pSkDf0CwXss+DpEjy97eqw9v+8KcqYyneNFp6EX9mOGeqlC0Vgj7YWySIs5DlW1bVgC2U93Xz9sYov8SDNZo5GSbvg0xQlwhXa5zfyAxIvUaK1dAnLSWcsF7YBM6hjQ9kXzg7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z4Vs7dibMtit9/jIXVQo6NUzzirbe7nn9qFME1jtu1o=; b=QY953CtQkpixCDIC59CPy/KiOMHSTHJ7xbSEw/mi3hQHrBbmZlfHezlZ9CcjAnbgtwye6r4JHhBXciOOdrE+o8SQB9fqPDfvGeElI17fZmspVKIY0PSra0jXmW4VX3cXXoFpsuhBqucKxUpl4jU9B511JksJpiW8e+5xbtT1o+W50xBCoQ/oT9GoDFg0V6G4wCDTt8r4AY3O7o1ryurnAkzkBbIS8nZT79XbvokIScgcvKTCRShCMDHJfr44s/qVuROVHuDBAjpK3Cj3naUdOlCjV9WE/e6KlEjsAVje4sJEB6ICfAroMOlNS3yKaEtbGSIGKgC/H+V5SG/xKvvbKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z4Vs7dibMtit9/jIXVQo6NUzzirbe7nn9qFME1jtu1o=; b=ftmxS0wJ70CeNLsM/dgP+EUT4XiAf8KkXZdJxZCpOPYI7RTf8EiPT79a+DWZDUV2tIRiIPw16wlJ9CACOBBECW+WUkboF1hP4di+PfSeiXLArF3uLyZhP36lwokWWjJfmd6YZewuSXcojfJe3bxYBheUIV/fNlEHMLOv4L7wMqd1FouxWZgcasKLzOg+lBMVw+GIClIS6sv7POzTTtuSgg7BkbNZUecXawhtNHot/gQNjY5eXOENIbQvS9uLgmc2YFVB2byGQGMP73LAPRCuzedZRlrX5AaByaxfmac1zPW8znr3FVtxxHrBajHe4ThucrcggztONUPRcAmhvVmcuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9928.eurprd04.prod.outlook.com (2603:10a6:150:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.16; Thu, 15 Aug 2024 16:34:25 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%3]) with mapi id 15.20.7875.016; Thu, 15 Aug 2024 16:34:25 +0000 From: Frank Li To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , netdev@vger.kernel.org (open list:ETHERNET PHY LIBRARY), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Cc: imx@lists.linux.dev Subject: [PATCH v4 1/1] dt-bindings: net: mdio: change nodename match pattern Date: Thu, 15 Aug 2024 12:34:07 -0400 Message-Id: <20240815163408.4184705-1-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SJ0PR03CA0218.namprd03.prod.outlook.com (2603:10b6:a03:39f::13) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9928:EE_ X-MS-Office365-Filtering-Correlation-Id: 90e149be-e040-4362-7ea8-08dcbd481fe3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|52116014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: o1lreCMNBU174CZvHh+WLwanTdJfKSM8UdZ7MPMp3eWnfMKwE7QpcTLNUI+XEU4qiRNwe5jWEE/9KMtheHyBAARzPCzBrYWCqPwvywNR9eC/n+Pus4DBbg+JoqItu7f0B25SQyh/Oe1MQ3cuSCFx9+TNcYG+BYevfHiGNOjOKh5JM2VXD8+qMQ3IFVFNnDUMA7wTFpAPjmhf2g2oo/48vI7i0RHwlQZ55QbgXozYe73pZKhmqftjbjOQ/vjBDJcJUNHGmudfhUY3OWlNK5xZCikENu860BPdkPMDcmU2Au5fmKgCDXoJW32VXBigbi42+lwvKAUQYWmmXqV3S0ksHJ4wz7s4N4pIJ9UNy2JdVDPyFZwiZSQUQJ2lJqvSh5NeHAlb1Pu9gwYWyEuh4EBwXhFHd9M6l6f8poNFvdJE5e4G4I8fOWLZsohOHtwuF4c8H89Hivc58PelnUeY0mKfNxGJ76+qdsHuNsEkRveuANrS8q1QV5ELFa7Kf5n+iJbyj+j+XXrHjnfI/NIMD45yp99nVWziwRwNS2zE20r9MHe0ZKRiT5AW7GuOWbe0npyUIsqIU+dfmsKLFq2BNZLPqRRkejLAoSkAYA3Ii7J27M4AE31IHsObou4IxqmfG4yw22Ry5Osuz65JC2ba0vdCMJuH4c53fmelbYRURR8Wz8ZdtzSbJuGuHbImsVKUX/8lcvSmDE7ADRGVvXFXzyChHTRkjAJGVBuZ49RYCyhBdNE8/Sqp4xgirXpseFHymjk3ZYIrKL9Q53m0kGeMIBbEnronPvfrJ+eBgPaU4+NnciH25xPY+jWJpY+SYx4f/ePkHtsuHpFg5H4I0Ud05mMB0GEdbduIzeub1kU1bCP/jDxcxuOQkEFuKsaBk/yswM3B94KMHwTYJKFI8ICBn+odjmkDRvUOmuEkd5/PrsWp26lNScJap0dTKOOYiRaj93ffqJs618m5qfMVz1e6rbDOjLXg8bQHpTzGJqgpuRA9BzQys8WyExGCA8DAHEtN9z5O4aprY1orLK99TWMg4XePuQruZ45idTGpYtWFf1iS9jQksYbYZK+fJ9jc2p7F2BXF2cb9DYRcs+sIyPGh8OVeip9W5ouEYO2ZMFBqa7pfnFsMSb+nBmzdq9kTzKfpjgMpKmujTM1316QVbpByUjJUq8Fq5FS8Vpdyly/8/fR7Zi9TJPZDFNt+NXbEV4R49RmedPLjUr+h4EYEdKC0GlbiKLK145Cs1aUbFpedMgblzhOC8Cfjay8rrqkuhFsjJAw/xnvCIJpEqcu0269hZKq8KIfM3s4S4R7F4lzApOEboGvggkzaYrD07QV/uiOLhVo6ZmMEw35hEfdtRA5CyJCSeh3Fakptqoh/kvo3bm0r3MOvaVy+xjosz3s5XCvwFz2C X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(52116014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KNCRvkHXXxzIEsK7B2nZYePhl7OpNNSYXYjUIdX9Rrdno/c19NaB5qAKSwDAWPjUPuiRfzFx3kEjAAqpGn6eCjwUU2c2VebaQwZQiflsQqdNQxnIcXq6twoy2vQ26cMR4ZISWKKEBJRpuTrXTnX8bmdvluRd+TrOcZkeoB7L1KZJ71M5H/tqDwrA9dpmvHX82Dy8Z6QfdF5ckbevR5bVUebXOBE+lmu53Oq9uCQgRLGetMa0/4euSBz6ARQ8pWAsrDzRnpusGKh5yqQ54GSd3W3whtnBy3uZaok0OC/n0s7qRo9JA2EvXGTNMwqn3Am1/bH/UH1XeMJbPgoZlA0h2wO3FIlMr1T2oDXRWaqbQzIUXVS2HHaeVjgp0111fYSwGzbJOQ8NoYVzEy4jvhP0myMqTQhBPEPTD1j+BDm+2ClEGBF8/l7uPjbgHx2dr4HPPIUeK/+Tvby87kjUAbUg60cvCm1s+/yMXo31LlzVBbqPOPGv0+z3DTIgrlaaUHZ4zYpBAlEZBOqFBvi7gYkTP2qIqp0LYGYCEnyUxi/PyhFQMdKrf5vQpVMyVwyhLY2qk8JuHQxs41Yo11i2bTAnrnbQQlZRr9iNEUguMXOUM0Wz6vVxAqFx1aJ43BEZ1ZSvdlCRILUQsk5z9FcB4T5pE74GrRkW8S9fAOwHid6OjCPieS2xXX0El+mUFrg/1bIHpRT6bRuNsisIZkz6YavBYhUvAXLrcFiTsrNMY3tK2uU5QeTHbmHmwXq39fQz5peq/QaN8gOSoVSfz7mFl1z8N4QiKPucBq/swSvOq6OmqTQpAEh0GtTBrsg0GB/XcBoCO60MV0O7UtXXMOOJ4lelTpqC4GDLDug5zXbDjIR0M+1erBeXtw40QQ900eruwhnLNsjZG/oUqR4FSlcbsiVjnN05p+XZMdx0lXr1WlH9LAlsK2EObIqfsEW/GN+FzNbKrvjF9w/ZO1/rW5RXwaYARFp1xKwqacoQ2Sy6erxW7KoySWeyYYGmdYrzim12/+kezsFS76cTFTFPjRwpApxerOdqJqyCBs4oQ+7i3Q5Yg7t/HqGX7YS3xs0OxUToodVZllX/FhUDq4BfzyIpNrGvOiOOzCG8E3b1ah/ObGWMSELXfTH9BYvqi4kF8SFy8uTC+Z+LBeMg+pEUpz9S6foNK58E/XauKpj4WEEYtoxm6iJfoGYzDHtgHA8aFUlHrsZxixc2mylVmISj5mfY4BRA3Zv2eZNiuCjGPaApp1sreQ5X55WAeCgM7x60IprxfcJouW6zkmd2cFzdsdXqKfYeCXQ6lSf2PFapWVcu1de3Re/NfJesKoB7TTCsPKMbDr8+RpxkSXFre8oeGWt85xf0FhOiVcLgy5iofhT48NHflqbYLBkiCzXt1VG5JYsF7li5GLelJIzO4/5r0OXP1Miqr+3dHlIwd8/XpDj8Tw/kClkwWaSgWAs3YdVXUoXHVYZS4v3/9DHplCtQrs8E2Gd7JmBctNlO0rFaGfQfUB4sULyzXVU+h2iADXo/6W0fUNcYQwfDsBMDsXOqD//25AR9VkEVRez+3YnwPFbfOE2n5yM= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90e149be-e040-4362-7ea8-08dcbd481fe3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2024 16:34:25.1434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Uma3Q1BvVZ6g2/lag33lpReu2xgK8CuDreeOzdYaSngX3o6bVJLjBFVggkp17ZKxyJpbRCZ+9APzdDGbUFyLTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9928 Change mdio.yaml nodename match pattern to '^mdio(-(bus|external))?(@.+|-([0-9]+))$' Fix mdio.yaml wrong parser mdio controller's address instead phy's address when mdio-mux exista. For example: mdio-mux-emi1@54 { compatible = "mdio-mux-mmioreg", "mdio-mux"; mdio@20 { reg = <0x20>; ^^^ This is mdio controller register ethernet-phy@2 { reg = <0x2>; ^^^ This phy's address }; }; }; Only phy's address is limited to 31 because MDIO bus definition. But CHECK_DTBS report below warning: arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: mdio-mux-emi1@54: mdio@20:reg:0:0: 32 is greater than the maximum of 31 The reason is that "mdio-mux-emi1@54" match "nodename: '^mdio(@.*)?'" in mdio.yaml. Change to '^mdio(-(bus|external))?(@.+|-([0-9]+))?$' to avoid wrong match mdio mux controller's node. Signed-off-by: Frank Li Reviewed-by: Rob Herring (Arm) --- Change from v3 to v4 - add ? in end of pattern to allow mdio{}. not touch mdio-gpio.yaml. Change from v2 to v3 - update mdio-gpio.yaml node name mdio to mdio-0 to fix dt_binding_check error foud by rob's bot. dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mdio-gpio.example.dtb: mdio: $nodename:0: 'mdio' does not match '^mdio(-(bus|external))?(@.+|-([0-9]+))$' from schema $id: http://devicetree.org/schemas/net/mdio-gpio.yaml# Change from v1 to v2 - use rob's suggest to fix node name pattern. --- Documentation/devicetree/bindings/net/mdio.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml index a266ade918ca7..bed3987a8fbf6 100644 --- a/Documentation/devicetree/bindings/net/mdio.yaml +++ b/Documentation/devicetree/bindings/net/mdio.yaml @@ -19,7 +19,7 @@ description: properties: $nodename: - pattern: "^mdio(@.*)?" + pattern: '^mdio(-(bus|external))?(@.+|-([0-9]+))?$' "#address-cells": const: 1