From patchwork Fri Aug 16 01:33:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Ge X-Patchwork-Id: 13765349 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C82DC52D7C for ; Fri, 16 Aug 2024 01:34:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 671638D002D; Thu, 15 Aug 2024 21:34:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 621B88D002B; Thu, 15 Aug 2024 21:34:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EAD68D002D; Thu, 15 Aug 2024 21:34:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 314E18D002B for ; Thu, 15 Aug 2024 21:34:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CC006A1862 for ; Fri, 16 Aug 2024 01:34:08 +0000 (UTC) X-FDA: 82456387776.18.95937F9 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf24.hostedemail.com (Postfix) with ESMTP id BCA0C180012 for ; Fri, 16 Aug 2024 01:34:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=exhJrQZJ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of hao.ge@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=hao.ge@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723771992; a=rsa-sha256; cv=none; b=i/jbmwfCHek0LKpycRRHKLStrBwyQMEPkZ+CIJ4HIe0kYsklxJyeNEQwvUqvTXa56BF9Of NPC+jO+tdok+wYY1ZAz0t61FIGU0HBhtAGx+PYtWfOb+jlt7T41r3s/GoNekwg5ao6JZ/0 sYjzFDKYgjwvYAaI1EriWzNABAOpBE0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=exhJrQZJ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of hao.ge@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=hao.ge@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723771992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BRPxcS0Hb28gbfuevEypKu5iGXP9IOHao5nXppLKMFo=; b=jrOeG2Mw+tjGrETqSKXGHJxh5Dre6dmg/YyhdETUaxN7Pzr/crhJNHSH7fBJMJkf/6W79F QZ5YOqBV93ON82n1OhTeeAC8Ej5jjwdbjjShdIvPatDpCuLiFlQBRjsxbSK/DtYL3YOP4N Mj3zFGHztZ/4qoEsiOA7ZpSpd/OODZc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723772043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BRPxcS0Hb28gbfuevEypKu5iGXP9IOHao5nXppLKMFo=; b=exhJrQZJe0SErKtm8EKncvJ30xbUH5sdl6vD/JuZ0cMA2n/NOskPy19TLAp8KIOYa6CqYN Zo3d/oVeqKWSnMGAw8uomE/NSn0AcQSC50ZVEVEGnRwzNaYY8FxaCBRyKMpOY50bQQQtkL jye9g2TOj2HdDwcYz1pZ5E93sh0riMo= From: Hao Ge To: surenb@google.com Cc: 42.hyeyoo@gmail.com, akpm@linux-foundation.org, cl@linux.com, gehao@kylinos.cn, hao.ge@linux.dev, iamjoonsoo.kim@lge.com, kees@kernel.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, vbabka@suse.cz Subject: [PATCH v2] mm/slub: Add check for s->flags in the alloc_tagging_slab_free_hook Date: Fri, 16 Aug 2024 09:33:36 +0800 Message-Id: <20240816013336.17505-1-hao.ge@linux.dev> In-Reply-To: References: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: BCA0C180012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: psqiiebqb1cbuzhunbrmdsgfxbwspk6y X-HE-Tag: 1723772046-27030 X-HE-Meta: U2FsdGVkX19X6bQ9DvAVR1dhl1Y5vmGPkkHhCDdlleZlxK2FvzvU5mz4Fg/UqfmU4jbOPchvqIuBIYmrRZ6lqg4X3T9aMWAuqEePLoEwvHq0sFihQdYeJZEMzdsQBYn5FT+ZnHYE8tTxnLVi1kv+q8FJgdUqOiVtB/UBPiVXOCy539LdHKCKXlxNrGzBX97ocvQ3+1ndQ3Q0ytYpuSyyIMbako/7a9zTP6aouGjGN6BF/eua1Fux7LyM8ldPNUxFmVkDSpSL7QPBPzsh7BuBzs6SOdqmN5/xYc/k+vkEZq/72H67h7ebgr9lzuaWUzsqzULIoxecx5cnuVD9/lDQrIeDfwS3YT56qUEKyTmS5dNZ+oSd7Ni5pHPtaQ3AvTPRoYkRkHBmEf/a7Vp4JL7WsVJkefNb2pNvpgR8tCzdyPWByeJnhaMC2vuuR4pw6WIPpDifZvrIDGVctKIjhoBVr/+Ak/ZOJedrbO5R/VsY3bbR6oK6clQO97gZUHlDCuVP6GG5nov8oAHWaou1+y3ibxGnjG4qNIakv9I2sKs8gpuwKslyUW43Tm12hOL3zg7bjJrAxTOeLVifzNcjaBu+zdmmHnNhnBVnhZj1ZP4rIXslva48GGZs72FTij/uHF4AF8V3BQIEq9NEOf6ATn42YaXF1JEXe1xE1eR7JdZA6Y0xQIaTMKaNMEdeD6xFd1CVdYkWsbfVQv/m8fKD8OdzCDSbW8Ly7gi9pCknqbJrv5YA5PWl9XRLzXwG1VKKIgq71PawmvOiLNgzoDV/5Pe6Shcjvg2E3yoWMGJ7ENAXhj3iz/2/Xf22jICVqstxvWtCa4NCyxdsUIg45YNypdzLPAcjUP0iFNb4gbflMVZ1xNV6Ard9dKZmWYayytXT9LBPt7zIDzOa+OBZVIQOo+cx1FYTWH3ECbEjK6IiS77Pw3k/eh86Ytbo29swu2sF5eaQjHPGq0dfqWprLlyP90k FVVu4aEx IJKgLyvscmTohO3HuB2EwlrbmcTIzc0UCVHFFnPA431YZydtHn7e9uoOSEauiqN9CDDB5pgYP9v4Dfx6Sc2PR5Mjp7L2AP7Mavnd88LrSFnmukVgqd5WK0uLuaq+YkpGT+JLLSsSvNx4rYFplTIfGdpVGCI1oAc1QmQ3gG4lP/c7Z+MUjOpZ/35lO30O4Cfib+yWmAk9OcjZdHNU5qX7f+HZWZxBnGxpkrMWOWlpMzdlZ1qU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Ge When enable CONFIG_MEMCG & CONFIG_KFENCE & CONFIG_KMEMLEAK, the following warning always occurs,This is because the following call stack occurred: mem_pool_alloc kmem_cache_alloc_noprof slab_alloc_node kfence_alloc Once the kfence allocation is successful,slab->obj_exts will not be empty, because it has already been assigned a value in kfence_init_pool. Since in the prepare_slab_obj_exts_hook function,we perform a check for s->flags & (SLAB_NO_OBJ_EXT | SLAB_NOLEAKTRACE),the alloc_tag_add function will not be called as a result.Therefore,ref->ct remains NULL. However,when we call mem_pool_free,since obj_ext is not empty, it eventually leads to the alloc_tag_sub scenario being invoked. This is where the warning occurs. So we should add corresponding checks in the alloc_tagging_slab_free_hook. For __GFP_NO_OBJ_EXT case,I didn't see the specific case where it's using kfence,so I won't add the corresponding check in alloc_tagging_slab_free_hook for now. [ 3.734349] ------------[ cut here ]------------ [ 3.734807] alloc_tag was not set [ 3.735129] WARNING: CPU: 4 PID: 40 at ./include/linux/alloc_tag.h:130 kmem_cache_free+0x444/0x574 [ 3.735866] Modules linked in: autofs4 [ 3.736211] CPU: 4 UID: 0 PID: 40 Comm: ksoftirqd/4 Tainted: G W 6.11.0-rc3-dirty #1 [ 3.736969] Tainted: [W]=WARN [ 3.737258] Hardware name: QEMU KVM Virtual Machine, BIOS unknown 2/2/2022 [ 3.737875] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 3.738501] pc : kmem_cache_free+0x444/0x574 [ 3.738951] lr : kmem_cache_free+0x444/0x574 [ 3.739361] sp : ffff80008357bb60 [ 3.739693] x29: ffff80008357bb70 x28: 0000000000000000 x27: 0000000000000000 [ 3.740338] x26: ffff80008207f000 x25: ffff000b2eb2fd60 x24: ffff0000c0005700 [ 3.740982] x23: ffff8000804229e4 x22: ffff800082080000 x21: ffff800081756000 [ 3.741630] x20: fffffd7ff8253360 x19: 00000000000000a8 x18: ffffffffffffffff [ 3.742274] x17: ffff800ab327f000 x16: ffff800083398000 x15: ffff800081756df0 [ 3.742919] x14: 0000000000000000 x13: 205d344320202020 x12: 5b5d373038343337 [ 3.743560] x11: ffff80008357b650 x10: 000000000000005d x9 : 00000000ffffffd0 [ 3.744231] x8 : 7f7f7f7f7f7f7f7f x7 : ffff80008237bad0 x6 : c0000000ffff7fff [ 3.744907] x5 : ffff80008237ba78 x4 : ffff8000820bbad0 x3 : 0000000000000001 [ 3.745580] x2 : 68d66547c09f7800 x1 : 68d66547c09f7800 x0 : 0000000000000000 [ 3.746255] Call trace: [ 3.746530] kmem_cache_free+0x444/0x574 [ 3.746931] mem_pool_free+0x44/0xf4 [ 3.747306] free_object_rcu+0xc8/0xdc [ 3.747693] rcu_do_batch+0x234/0x8a4 [ 3.748075] rcu_core+0x230/0x3e4 [ 3.748424] rcu_core_si+0x14/0x1c [ 3.748780] handle_softirqs+0x134/0x378 [ 3.749189] run_ksoftirqd+0x70/0x9c [ 3.749560] smpboot_thread_fn+0x148/0x22c [ 3.749978] kthread+0x10c/0x118 [ 3.750323] ret_from_fork+0x10/0x20 [ 3.750696] ---[ end trace 0000000000000000 ]--- Fixes: 4b8736964640 ("mm/slab: add allocation accounting into slab allocation and free paths") Signed-off-by: Hao Ge Acked-by: Vlastimil Babka --- mm/slub.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index c9d8a2497fd6..a77f354f8325 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2116,6 +2116,10 @@ alloc_tagging_slab_free_hook(struct kmem_cache *s, struct slab *slab, void **p, if (!mem_alloc_profiling_enabled()) return; + /* slab->obj_exts might not be NULL if it was created for MEMCG accounting. */ + if (s->flags & (SLAB_NO_OBJ_EXT | SLAB_NOLEAKTRACE)) + return; + obj_exts = slab_obj_exts(slab); if (!obj_exts) return;