From patchwork Tue Aug 20 13:46:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Deucher, Alexander" X-Patchwork-Id: 13770116 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36BC9C3DA4A for ; Tue, 20 Aug 2024 13:46:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B2A310E7EC; Tue, 20 Aug 2024 13:46:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="OX0xyIdz"; dkim-atps=neutral Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2044.outbound.protection.outlook.com [40.107.94.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 740A110E7E7; Tue, 20 Aug 2024 13:46:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DH1pF/Q4hHqZE1PE5hAygWzvqM3GFv1Dt2S9RklssoKF7dLPsFGmkC/yxx88jjrbSQDzNjvp84QYjYa6c86OKWQR2dPPvgCtexw4TWxPlV9t0OPaeehHQuWqzBJKWFSDD6NVm92uEwxF0VOfeEIw2lHVxOK8BNIGUuv9qWOQtUtj1UPPDFPmApDI+xj/QqWCzIbDQ15gNHzKa47J0xrSfBcFSTMk7UB0hMr+xOsyWllDjF5ZuFSdPf5qcQLSEp7+pAPBTJh6VQNEi0L4EEwDVQujAOsRe3WYxvTzRUrAjB9J3KT42EFvXLBzaQJOKp/wl2cNpO20CglH1luRXU7a0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AV8CFl/Mg0XaUiWCBHPzonY6n9Wc/Ii/6cs8PO0gVN8=; b=Qx/wTuMLRWeBQoeCp9xDfw+0a0aG96isiw0qe++Bm21M4KNKF0vctjgyl/nYhpd9lCOPR2sL1oVQY9rrNxksRnjgHfkz9jnomNg/OTGxTCgFwEABmVW73aNJgcOCBGHSrw/VGKaTHxdPGw9qDLwWI6v6be8ICFK1o+E/+fdZmGM+JXFRWnJEkoLpY3hN8DuhEj1TaV95+IJ2VwPkAAKJKJlMZO9L0RCYD5ddchAze1n1oqr5lh7FGZ5Ix+ujy5rRuwNLBSe2Ry7YCm1XWbK9NCkQWEctZGETrslpnVKkB6o411J2YIaqGsFpSDf0ytGCF9Tqb2e971gcqwZV/HGfaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AV8CFl/Mg0XaUiWCBHPzonY6n9Wc/Ii/6cs8PO0gVN8=; b=OX0xyIdz0MttHExGSbK20FuUgF83a2joo//CQ88cSDS9yrM3svkYaXPaQYZo41o4s5BEoximr9/0KxtLKg7zww7HMQ+x1ve/vEFCqIlirM67z5Vb0xNIkEJzyhVyhR8D4eHfEHVV+6MB2SZhbPz3PBtmh5hcCS54jvTDZAQ1HYc= Received: from PH7P220CA0017.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::9) by CH3PR12MB8878.namprd12.prod.outlook.com (2603:10b6:610:17e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.16; Tue, 20 Aug 2024 13:46:17 +0000 Received: from CY4PEPF0000FCBF.namprd03.prod.outlook.com (2603:10b6:510:326:cafe::57) by PH7P220CA0017.outlook.office365.com (2603:10b6:510:326::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21 via Frontend Transport; Tue, 20 Aug 2024 13:46:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000FCBF.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7897.11 via Frontend Transport; Tue, 20 Aug 2024 13:46:16 +0000 Received: from tr4.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 20 Aug 2024 08:46:15 -0500 From: Alex Deucher To: , CC: Alex Deucher , Zhu Lingshan , =?utf-8?q?Christian_K=C3=B6nig?= Subject: [PATCH] Revert "drm/ttm: increase ttm pre-fault value to PMD size" Date: Tue, 20 Aug 2024 09:46:00 -0400 Message-ID: <20240820134600.1909370-1-alexander.deucher@amd.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBF:EE_|CH3PR12MB8878:EE_ X-MS-Office365-Filtering-Correlation-Id: b1d0006e-4531-4abc-9cbb-08dcc11e76f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?pQWcW5/5YibK9D2DfU98SEiT3S3hSB+?= =?utf-8?q?8aQfSjyIp00F99caL4LjSTuVl2j8G/0s3XvhVNadAJ2ayPS8FxzNBrmmO3XX1Kal6?= =?utf-8?q?1Ct8OaZqOh/HWbgU2z0Pi88GLoFTFCRj+TReKM7We+xidBvWlT4jKad5isu0JvCiK?= =?utf-8?q?tzqWGdZq7AgXW7F4xQNpWA8n5cSDjmDuwuufCMc0Tcx/lGbT8aiVSTlt8wRWZf9En?= =?utf-8?q?oWtwUIIEn6ObmSkIEN3sbpV8ZtBy/R8qlbtUDZwJTUg3dy11arTWgnN35LgCM7DkF?= =?utf-8?q?cHb6TgFBmyrlhzy/0WbQkaoaorJ0NhsHuvX81Xrs9ieN8/+re8ImuejCvSsfGvdmM?= =?utf-8?q?Vurdx+lOgJJ3MU9myTldLOGDSA9w4P98VzKoVkLjl8pZ11Sx18913IR2KQKHgMa0L?= =?utf-8?q?yyo0fQrnGA/jFONZCu+4AyREuahoaQsOtWblg3bRX5qzYMQyuzM2wqUgfmk5mCziH?= =?utf-8?q?ZcpQ4ozCHA31sHVDlTUcc/hLm8NYQ8nKKgeYU7TfzXPAeAuVjb4EBb2+BRkroPQWz?= =?utf-8?q?AIC74UluEa8hD9nZmSsWWszGvYYhtzJs0f0MNOdZUD0VDsBlYO4npk6wIO6pFw+kq?= =?utf-8?q?TYP7Z1TFvOnHU1QKGgGDai+KRp35ZhI2jr7Q7tnFvevlqzI1UXVoXF6wjHze0/WRe?= =?utf-8?q?GjDGvnyoUQbxO74XQ7Ou44v47FQG689weezu48ZImp4ha13I6SGXrcENZ+39GDK8b?= =?utf-8?q?8ARlwOW9dcL+J5hS+5IMlXWJ+U4FfM7CBb1CJxtHfBNR7wNlnZpWmVRaANMDbd5Od?= =?utf-8?q?t6gx4EcvJP6o+wyAhUkM/hAkVJyvD1KzrkaGekxzgjAoV92HuLKjIETANnJMq6t+g?= =?utf-8?q?IxpPDYAduXypSA2agt0xo0l4mASN1VJq9zBRC08uD23MLO02ESiXKg4nRZ2jFsTNn?= =?utf-8?q?weYcBSerqu5c/kgJ1orF8hGlTWHPZ6hCahHDy966OdN2/s/UR4HX66Ojdxw9ltGyn?= =?utf-8?q?3TYcboLf3FR6skKZ/LIwt6rUSzHrjN3/6mArujmYLgWoXY//X027uyDYs+nim+qGy?= =?utf-8?q?/qyUU2XKTWf2wngKFmrpNwuUwi+bAquaf3Tv/IA/EeGguw3Y++sG5icIBfbLKQ4QD?= =?utf-8?q?H4QiZ3c0mHlOZXML8Ccw2454zhwx+64Y6PbKIUQZOgpom2cR2SoMSQwJNFj0jBWGe?= =?utf-8?q?xLRPnyFYsiwDzmbg3kf8Szp4AqJequ0uvwKU6zHZ2lQaNVopa+9KkfqvdzVJCvC5i?= =?utf-8?q?oSxapL7fiZ9K+h6wl/+AdC2PDojfRe9L4J2bCTnU48bn77RzBdkVKhAl5oDPh11uf?= =?utf-8?q?Uo68pF/MQvxKPg8KaLqV7FM1TiYrdw1P15mzdBs4IhcbBBGBcsTVVN34Leeq0HHB6?= =?utf-8?q?+VUfQ184g5p0?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2024 13:46:16.7702 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1d0006e-4531-4abc-9cbb-08dcc11e76f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8878 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0. This patch causes sluggishness and stuttering in graphical apps. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3564 Link: https://www.spinics.net/lists/dri-devel/msg457005.html Signed-off-by: Alex Deucher Cc: Zhu Lingshan Cc: Christian König Reviewed-by: Christian König --- include/drm/ttm/ttm_bo.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h index ef0f52f56ebc..6ccf96c91f3a 100644 --- a/include/drm/ttm/ttm_bo.h +++ b/include/drm/ttm/ttm_bo.h @@ -39,11 +39,7 @@ #include "ttm_device.h" /* Default number of pre-faulted pages in the TTM fault handler */ -#if CONFIG_PGTABLE_LEVELS > 2 -#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT)) -#else #define TTM_BO_VM_NUM_PREFAULT 16 -#endif struct iosys_map;