From patchwork Fri Aug 23 12:29:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ying zuxin X-Patchwork-Id: 13775055 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2049.outbound.protection.outlook.com [40.107.117.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E94B7376E0; Fri, 23 Aug 2024 12:30:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724416243; cv=fail; b=sL1IVGvRnBZQ4f70P4zWs5pYH65zEYYdg2zKGxtIic+aq2Pht9K7jHf6sHP2HTl20JKOi7kOK3B5WODzk5CFE8Ux7/lhFdUCjBJ/xOTEnNBAhqzILoJbuFL6rUIwEBZmn8Ij5SGb9umK6lDt3ZTmAKcgT0ihl2X0SKqWLiNVAhE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724416243; c=relaxed/simple; bh=IzXhiwzOuYP4F7YgimgaS60hqtmAqa2o6PzmDpB7V8o=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=Z0YiC2kS2Sk5QY8rSUJ04sCv8dTeApZzyOqsQyW8mqKNNcIkVhmZRro7zFqwMw5rcqtLj0l8ppIiyHFWF2kPwgEIt40LYwtYdjUTnTQZAsXRNlIpypt/00SvQY1/o3AtOUDqysDG2h3+aaiTM5Ijc8IrxG662L77dSjaXQADqtk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=qUPstVKw; arc=fail smtp.client-ip=40.107.117.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="qUPstVKw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cP+KUOn8cXTj0LnlIrofZoOOH3i+C/9rJT2Bpr2AebBJli1MqtIansZOKmQko6g1W4EfEKf9MEVUKnwDmVE7KcXex7JgSlf9rb9y6M+pQH7keyXtH6+BpmZ3p7WOlfKUqIaxe5Wkw8+qkXwm08UijjSjDx+GNVw4eqYyJgH7KujrodqNoHgdo3haxxVNwVnOLoYPblU1JbtYivSdeVItilrlZu7gxCxFVEnftwN5LVGsFKAirpu79rGi4RefDNaWQSjgHT48+53LbnyX4U02rBvajRaKD7MmNITZHbbXbYMnbKMFWNQS+Kc1vkvIB7dqQyKWovdKyUsQ0pySA0qJ3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d7bpAQ7cupdvEUiLMqx9JD8lyHyWFdLB7t/mchCwnAo=; b=uZxpqL/Ol5ihUscpfl1CI2w4OsF5qpm/XKqIcO5lninZZEpW+piXoGDGI1/5aRmxu3Zd7gFRNqeiOhpFrAemSMuZc0STL8Y2wj89AUyhxNGDWjtzx/x0wQUt8dAg7qkKXvwxHJ+FwxgRdr3VkAbV1LCJwoAe4zZ72rIwOq0wd597O7x1sfNtLbtm+B9GOEwXme/ksPCRrM/Nsz/VPnXnFIy9flfB4KY8n+3kPM2piicB52cwujGcMLwqox6J7tTGFkPrxyDkYWFki/nkjp/8oyqBbhExB+/xKEbhwC7phvx4DijtKtVAh5a0CKMMcysWJ2wMKHZxFpPRYJX/tMmoBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d7bpAQ7cupdvEUiLMqx9JD8lyHyWFdLB7t/mchCwnAo=; b=qUPstVKw3Xaz8MvZdr73xOsCToHZczuQqNl1i7zYVYQJC3NavUtTAeW7SkPGeJsD6802Wqk8H3t4NpZH/tDGJUN6PNnIEt9BMcdKAfMjb8pqPe2FoCno268tDnkj6hNz0IrlB+p/Gq49cGOPEjqe1GpFzs6+sye8RDcfj11Zi/YlJGfnL9Sg2vTK42R1DhbNSnnQQ6/g3CjQW+RRO28Z59TEIOXa5IiclVRJPgLZe1nsl2PyUJCwNmJiC5yWnV0wnny7P9KG3us3dY1wuQirL6j0FcHQaBEa0aEkXZm32LNSa78//yU1tqkltHMcPMZpqJrlNcD67FRX37/Dzouhuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB6332.apcprd06.prod.outlook.com (2603:1096:101:123::11) by TY0PR06MB5529.apcprd06.prod.outlook.com (2603:1096:400:27b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Fri, 23 Aug 2024 12:30:38 +0000 Received: from SEZPR06MB6332.apcprd06.prod.outlook.com ([fe80::6b3f:3bee:4364:6919]) by SEZPR06MB6332.apcprd06.prod.outlook.com ([fe80::6b3f:3bee:4364:6919%4]) with mapi id 15.20.7875.019; Fri, 23 Aug 2024 12:30:37 +0000 From: ying zuxin To: Helge Deller , Christophe JAILLET , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com, yang.yang@vivo.com, ying zuxin Subject: [PATCH] fbdev: mmp: Use devm_clk_get_enabled() helpers Date: Fri, 23 Aug 2024 20:29:57 +0800 Message-Id: <20240823123027.5753-1-yingzuxin@vivo.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SG2PR01CA0172.apcprd01.prod.exchangelabs.com (2603:1096:4:28::28) To SEZPR06MB6332.apcprd06.prod.outlook.com (2603:1096:101:123::11) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB6332:EE_|TY0PR06MB5529:EE_ X-MS-Office365-Filtering-Correlation-Id: 94be780e-5b6c-4caa-b6b7-08dcc36f6497 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: exNZgJHnelyKQQK+pDBj3PnIVpJyTuCVtRLYTX4TM17S8I87QXfORd4BvTwdbTwQEGZFqvbiMxOBBpQ/4hbS+gpG8+X3aOptzp9dTEcuRE+6jj/gyI+aKyKuDQU0IZ0//hCO0EI+S3qjoh4Go7CqWpAQflNgwE+Z4p063smSPCmTaNBk8tf2ZtMbAIT1M1xBNd4c68e+n4SsANNiJO/JmZs+BeCyNFtWcJ5rL2OTEioo0cY8aCKZK14Gz4Sye2jcOEDg36CfxkdolTxz94+mlZEyBm9i2UBEkYRq8ew3yQSJYYZ6dO+bQ9TWoqVaNZ0PBSQpfSEmq5glaHZfXXKe6fBALujUK9Cffgf6R74kfLIea/NOWztB0LeB+LrsP/b/2KL357r8bvVU3o3Do176yaPz9UI+rYqANV4jF6uF11pDUht3bugUfUPl7HFcOeFLRpAX2nMOLRryTSHGAkNpr/g1wfqH7blKsy3CpAMF+VY9JNXHm8ufkMxDiTuPT/hNvolCsNLAu3iKbMn/sHfwZV6qnO/sZa/BpXtTQkaXKuyGKsfG0t+RHSelM1RR/Bi7MsGZel2UMtzmDN6LL4FISt6Eh0Q6UMgsNejfijy+EyUljJpEMW9wa51Pm/SCMNizS2bXfwac8uznWGM7wwRqUnoH/UenS6F5fqEQSfWL29ked6j5mNwfinTqhEgiJxOBrdkOj/y+/xpuJmQJGvdHFQwbOEXPd/Ejx80z07DAKhOUb7DZZKt4UbPQfCTSEwXIsbCVE0hAbc5otZ3kQW3bCaMMlNdTIU9w6A24Qk27MpcIUnH05fkP3o1d+lb70mJr17nWlH6v6xVfdhi+ya9T5aEpjG+sxqQK7TDlltH1yQ5fu9Cc6e3ShxxRWK4TUqc81NdK/h3O07OhVmA7DHNzt/eNtUKz6YmNiaux1c8SBhyA2HOyDTSblspB3LBkUGtdr1oBwPHAayj7BEzprIhoxRCdGoex+bkze7H9P4WzYV8FKdO1vwesk+nneTQYMTZRduiebrtbF/Kw/27gnBzUIrQpRmmtcKyzf7Gkv1DWCuM/ouK6dgXEZ7QDpFTD8rjK8Vqm+ZGJVUIwySZlLixxZgmYlLHe2D3SsIvfQcdih/m5pk9E4ZwRWJV9tzBN2I8hNsB9tYvkhh/IyvliAoG+HOt7EnjVc/EKenuHo+whj2QWPpl3QKbcgJ2xI/6bUFFN424EgBefGoQ3L4Sq/BD1Sd6DKJi+KRoC1ORMV2lqDIromYOUVGhDtYaXNlEJ/eSHNGZYqzRVvM6zKmxkkf/W1Vh06GiwjiC6Xh/jp7TcMHP1FEBn3QbkO4EEeGk1xoCnEFksXENcq3UMl+0HMpxZPNnoHDF2Vc/9dhVk2tlh32puH1w4X0tv5GWWbN7HStwvw1F1ptHsMywCcji6YjjEng== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB6332.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +gSqx12Wpm+p+ScQLoJf348zO7DacvVe8DcpRULlUbEvFT5pjAM15hS/sajByl1D6TzrN5+lvot4Nt4f1RsSlhUP7X/PnKjVZ7wAtB5ZPb29TPP3VzJQcXvZQoQkA5s/t1O5hKf5HQ+e9ix00oiGPRDjgJl11iUDLC0ShkJKuhCE8GPoso8tFr83HyYNCXDfJyN3kQcCSFB2Holwo0SLZTqmgV26ihoGlPmstLThBaRxn8TP3BaXk7s+jaXWGKtQw9C4SbGAi4DLMbV0ijhx69a/Er/tQ9vEyZIwS6I93pGq+d5mkjDU0k6dNOcO2azAX13UViH5Sl1mQ7KRKmVtd6s+UpplsmPlln1TRGDu+Pt7ePvrENJls6A9rjZF0HAKO7B9JcC9B/54rOUR07PRqC+XArcwqumBobK8f+X3nTuTbbyhc4EwuFsgDAYZjM9g5lluVGGV6gURige/HAXmoonXCtimabcuO7aPtID+yfOqP4thOStXmQ9SKHKyqZ8MAifz9nyLI1eYo+w/HDNn6Xym7CRi4jDJWY4qfTXsyjD5Vp1f8lDJAN3QGSxW0Cpq/MhGa2rFM6mKoFAQCnxyMh2SFtVKsj2iKaSPTcfhhXn2P15se1mt4A4xpUjmDG79G+2PcvJd1BAYBfKbahCyaNZOC3R7lwFVK0mzRtLzmkyTy/k071rImD9bE/i2uKN4fqTsmZbsTeOgcVevVl8FKNSFRFYlgHaC3FksGZDrFqtsLVYmrAqUy6iWPhAfy2MDRx5/b/2lNkmUhRQCT4qrtZNWEb6UCCG2il+mKjBuUG29OE/J5LfboO2KcU8JVyCgEbC5+P8ZVlTTHnoWw0uv4z8+7CQ/vtuRhL/TcWOTCqBGgYXnrDLc5/z0YArNGR2q+1mjNSKOX0yRrcj2oMayONu3Sm24fUelW81OhDQEGTTwVxoMjbY8duWtSAu+cc9EArI+bwjeVB96sRtIwVuzvUijO653QNnPDVJMUvx6vKVZNU4fnDfeVYKPGlsgAmtC7y6hbM0l5rlBs78QFVc3jD3ycgMAXRlYi4Uo679a8fRmJd7fLGqAxxEhHvdKIUOxDxbMvDgGN/pc31v8ekMvbLla5crVXoeRxb7CKgACiKcxk5dhX4wuFXIRwcYvz3kLwUVcmkaPdO/qXRyWM0fUYTGRNoneycSGgZJTNE9EcpysHioaRpXmOXhIc2BC6hRdT1eNtYR/44ckJ9BTi7wpITRNlVDT7JjIAnwEZQDDp+sq6NTt/5/+0GlkaLdIKZwzt8nEtDRh05vSshrL4WssphAr8f6NFaRpbI3tCpI4afoEncCS2ybVmKUH3L0Irzj+tUkgm8tHwQgFhx/rndEkeXD1mMVFc1hK8Sb10ts9NDJfIwRn6JtLQICjGyCjFbxtvWAhYFttjs5sZV4zc4sf/8rBtfHCF7ek4njfjgd0LnbVvtyPMSqA6CCPNfU1/hEodp3o15XHuBP1Ms84FHqJuW96EZ+SiXDYO8HxVWNizCJVLFCGgQFcAS2sP/Y6ltdxHxwCq8gDKgXfPTFaJq6uXC8RAgW0MFH579TeVADAzhn2hdly6+hGRZhlfU1iUT8j X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94be780e-5b6c-4caa-b6b7-08dcc36f6497 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6332.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 12:30:37.7418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 787Gb8ihiFYEEAfQjt1RXXBagpc+EEXaYYZJlJ4JjfEGyP8NatedIHJ3VX8974rGYaPaqDU+QnnsSjztqoIKng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5529 The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Signed-off-by: ying zuxin --- drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c index a20a2c408127..03e23173198c 100644 --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c @@ -512,16 +512,13 @@ static int mmphw_probe(struct platform_device *pdev) } /* get clock */ - ctrl->clk = devm_clk_get(ctrl->dev, mi->clk_name); + ctrl->clk = devm_clk_get_enabled(ctrl->dev, mi->clk_name); if (IS_ERR(ctrl->clk)) { ret = PTR_ERR(ctrl->clk); dev_err_probe(ctrl->dev, ret, "unable to get clk %s\n", mi->clk_name); goto failed; } - ret = clk_prepare_enable(ctrl->clk); - if (ret) - goto failed; /* init global regs */ ctrl_set_default(ctrl); @@ -556,7 +553,6 @@ static int mmphw_probe(struct platform_device *pdev) path_deinit(path_plat); } - clk_disable_unprepare(ctrl->clk); failed: dev_err(&pdev->dev, "device init failed\n");