From patchwork Wed Mar 6 13:25:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F26441803 for ; Wed, 6 Mar 2019 13:25:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB7E12D95F for ; Wed, 6 Mar 2019 13:25:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CF3192D96E; Wed, 6 Mar 2019 13:25:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A1C332D95F for ; Wed, 6 Mar 2019 13:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+riG56qUV8fWCYzXs4Hw74p/vufX/n+EEaTFW/B9QPI=; b=WoUgjzO73btHIZ piVk6VTrFo6XZ5zbdyBpLZJk20rpDNaJx0b4gVskfRS7Mw74uMEWR9rX6R22om4L49CgKBVvQHbKk 8dsLlgbC5m5EFNaWgdGA8guXm04rXnyGWMkdbKohrrkUdsB1vHVLFoue4Tx5PpBJBL5FzL3UWhsKC aA9Mn+5SNDPku46vi4oUwLph3B2TXQ4Pg1qesvwwWjLLTTSf4gU83cLX0FxKFejhdakKEsYuKW9u/ 6ly0L+6j6ZGO4yZx5cwPPss35Ri9DWf4yUnRoPGb3J0QllqAmHT9qJa7KFIVeO2RWD+ST5dzuskwi DRg1/AQX8pLGCCfnY4lg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WY2-000587-9M; Wed, 06 Mar 2019 13:25:26 +0000 Received: from mail-am5eur02on0609.outbound.protection.outlook.com ([2a01:111:f400:fe07::609] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WXt-0004wD-4i for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 13:25:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qLnXgPwWUG37nyYymuZxDZbjc8/U+mMsYxMB1GSBj4=; b=lQHUd82SWH1rrdlvuf44uW/qy00TAez//NqK4PPD95Iy0Akd6Ki29H1999bHOWEaOV+4tUdPoxqv2CQJZGm2ol5laXaJwRCWp7EyjQEZC14lCmLFvn6vZLazvONXa8WuaXjF1It6zE7iGWwec/9KHpfyPXshyV9A6tob7Apui5k= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:12 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:12 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" Subject: [PATCH 1/6] PM / Domains: Improve warn for multiple states but no governor in genpd Thread-Topic: [PATCH 1/6] PM / Domains: Improve warn for multiple states but no governor in genpd Thread-Index: AQHU1CAG9faKd1tVckmbMj06d/iqUA== Date: Wed, 6 Mar 2019 13:25:12 +0000 Message-ID: <1551878302-8146-2-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51ec0e42-2259-427e-a1db-08d6a237292c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB5345; 23:xWSl7PN/9cA+FEmeYCtEqun7tAY3yP3fdOH8cEC?= =?iso-8859-1?q?fD32JOfyBu3SxaU?= =?iso-8859-1?q?kPIH6eKMZcg7DKMSKjvRSJx6OxoX5itKuF5Wz8l+P5smxrnUgGxHmGpCM2tN?= =?iso-8859-1?q?niR4NP8TsT7b5Q9OeMURBHUpyGDeZ7tEcq3L4ccuLzWuYhz0YCIC1p60vk7O?= =?iso-8859-1?q?Eqr1fWp1wgL1kmC14q0zs2alWh+Js4McYBOt1nPy/+YAjK4brDKDDAHRL2f/?= =?iso-8859-1?q?07kfxOtiSOvBzMU0zXhIYKntQN5A5ik5VsvfORwozwuUcSRRH2SWqxobYiv6?= =?iso-8859-1?q?jg5DLqC7oWBcs8wpXq3OdPt2kXQf3syRhrvI/xA5c7vI3rUEZbexzpA3E6oy?= =?iso-8859-1?q?pK+y9dieU59dmWBJ3EdfEIs7xjGC3fIbC2rgOHS/a6LFV7Tp1M/r2nxUr6LD?= =?iso-8859-1?q?bth58TzYYb1fL4OZ9FlhCTQ4FNXvD20MS43dhCmEXKxjiM5OT+ppZYqGgok9?= =?iso-8859-1?q?lM9E5s4RVmccmdf+ZlUYQzidwxP3tbvMAamOrIpfGnguauGjebW7FKURmR2M?= =?iso-8859-1?q?EAGQJ/eujWlyng58b1+PZWSWA3vh1NDQoGrqWxYFgGLRMrsZPGmtgDenmVVB?= =?iso-8859-1?q?qqAQJZMdzdc5LrwdvK9+oAAa9ZP4woAu41zhjsgAogif7KTHIecqtv7pRlha?= =?iso-8859-1?q?znnffBbRCdQ9OwhJnBJAmVR+21LVH8y67e4syy5mRmIfG0hVKP4it/f2EpAT?= =?iso-8859-1?q?+L8XV0xPEnI31FHj9RrVRC0sbbknq2gpCAw6vRUzOgvg59wNpTnRA2dvFIJE?= =?iso-8859-1?q?nafr3IuqkxvV4an2zhzeojDefesrKfXpl1CRQ0RHVOBZBec2abUOFp7p7wLk?= =?iso-8859-1?q?Oy4tL+zTXpXVchhTwCGwubUO2GlbOpsfSu9/xXQ3O5rTHVx5I+o+HNQ6nOC9?= =?iso-8859-1?q?NhQvY28rIZQDPgQhijU9moINtJxRxhhEJOYw4NP1QMmoBVS37JK92OiKJoT7?= =?iso-8859-1?q?iUVYC4iS5D96ir5JaBA8vSM+Ck4+/hqzD1P2EnDVglbat3QiL23bjDX8AKms?= =?iso-8859-1?q?EIKfYsGpXaB8CoD2JgfHWsfw15Hmy0xkj5ifFXI6/CxaS59kZiEIf+ivQDfI?= =?iso-8859-1?q?pTxBfWQU3fsMUqwVZhXpJEE8JGfcKgrse8ThxHWBcloAheLpyJRB3fD9sne5?= =?iso-8859-1?q?z8Tc4HJE8WqxQALGXBYGe4phPq/8HvpLOr7ZYqdwzUwzytK7bl5IaTMy73KX?= =?iso-8859-1?q?fY7r+gUtoWhodrp+ms8IpakTXcNfUAamDWc0M9YcHgdQvKc1z0kxl6rQ/sAg?= =?iso-8859-1?q?qE3127HNijpTroz2Fw0YbD3VXclbjskv7IKkwZ+ez3ZZjE0DllGTacsvDOtc?= =?iso-8859-1?q?RR+oB25TE=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(4744005)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5345; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +A+jq9+CJX/BjUeN/WOeeYaiGFv+3Dzi4QuES/fhQlaRvpNYubFg+FK7tuYA0qfb/26qrqSyBG+DMITlPccNJYfEigOa4j4AYRMa49Bwn0Q/vqYp80o1Hi0fTPQy/45hIKLQn5OFw8EVJjo943j3FOxS/xv1K3sE987HrNUM+nLFlkBStrntieGm0XSwLOFpP4zguSib0kkdEwCugwHruzSYloE3lFxHrssBcm3Ro2YUpsCLy14vER3PqrZJgPnyogO8+rOzK/9YFPqSxAIXGO1hXxCJqvld0ARJut2wmhW9fxdCYzsJzATtmx8lUopOD5zAIXgD8XMg67eV6HJScjAlg9iFp+Bvxl3R/yiDO/IWjT8nHfukP4S0NvcKEp7OtW6wbtwY7IltvStHrgdEOxwJzsciRyLosGroPJU3XxI= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51ec0e42-2259-427e-a1db-08d6a237292c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:12.1818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_052517_186830_6FE7DD96 X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "ulf.hansson@linaro.org" , "dongas86@gmail.com" , "khilman@kernel.org" , "rjw@rjwysocki.net" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP It's possible a PM domain defines only one state and it does not need a governor to work. For such case, a warning actually is not necessary. Signed-off-by: Dong Aisheng Reviewed-by: Ulf Hansson --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 2c334c0..394f9da 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1766,7 +1766,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd, ret = genpd_set_default_power_state(genpd); if (ret) return ret; - } else if (!gov) { + } else if (!gov && genpd->state_count > 1) { pr_warn("%s : no governor for states\n", genpd->name); } From patchwork Wed Mar 6 13:25:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 004E3180E for ; Wed, 6 Mar 2019 13:25:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DCE132D96D for ; Wed, 6 Mar 2019 13:25:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D14252D976; Wed, 6 Mar 2019 13:25:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D61C12D96D for ; Wed, 6 Mar 2019 13:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zYXAQqtTC4rZhQWyDyL/9NdZlGuulr6ibBZo7Sglsjk=; b=ZAD4R5go48TET0 neXcaUqcd3Q4NAaZLjROgKVm0QOll89pzw1Sb5CF1nBlQVgJPXAh1hvvxynEyjTYFwtqXxDIC02I3 LMhowOd66wRTi43A10IuY7b2QNE1HzoS2yMHlKzMBxE2W1nAw7xpl1cWp22fSpNvZ/qPP/sUIKVhe J/fsr5nxRtl0JVI+r6xpoqdy21E9e6MozS9KVkikfKr5xh4V87JfViW8zoL0zQNLIwbdMXid6Foha xcXG2X3cztuGWq3rLoq0unxoYm2ceVGBiaA6/1DSVaXMKAIaJzoX/HngiWrmSeMbdvh1m1TIp0dXa ZeCkeHlPPyAEPy0tgSBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WYF-0005Vr-E0; Wed, 06 Mar 2019 13:25:39 +0000 Received: from mail-am5eur02on0609.outbound.protection.outlook.com ([2a01:111:f400:fe07::609] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WXv-0004wD-Do for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 13:25:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7nkgWBuioz+922pJOcaiisSpu1jNZ4+FFA1b2Hk11gs=; b=LYlu9ROgnsrqoJ2eTZH8Us/wjuUJsuGOh7jJ+Kc9b3AoyE7XnCWgs44ZVl99Pq6VZ9d2Nz1bBYmD6MBoswEdzugikqGfLzyOxVSsICbWHFYiEWxjSltUcecrymEL5apsRK9/HsEAr2vnfzghimguBtQO4qKOxAAbJh+rj2oT740= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:15 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:15 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" Subject: [PATCH 2/6] PM / Domains: Return for all error cases in _genpd_power_off Thread-Topic: [PATCH 2/6] PM / Domains: Return for all error cases in _genpd_power_off Thread-Index: AQHU1CAJEYbz4lRmTECgXbYWCDIjjQ== Date: Wed, 6 Mar 2019 13:25:15 +0000 Message-ID: <1551878302-8146-3-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 832138c6-98b5-4365-e3d8-08d6a2372b3b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB5345; 23:72DGiHVjh6UkqnAwPtDJVtHrGMlta7A5rRslJUv?= =?iso-8859-1?q?ayu0LFFpv8GlZ3a?= =?iso-8859-1?q?OIU3/0H+5loeWiJz2OoTyD9qzZthVtKlMhaj/okS+pcxuubyLkz6YwqGOwZP?= =?iso-8859-1?q?QcYtcfsDnhPd0rFBGuo9477Ie85vjKacp5S3IqrtZ9NglTXL6jX1riL+aBDM?= =?iso-8859-1?q?+WxlWYOdTH1n/uoF8GWWKNJrzNY7X5JrBQrL6lo6h9dUTE+zSR2+Yuo+cay5?= =?iso-8859-1?q?4QnO1rvkhprfaMY3RV/CUC8ojmEfbiysf1hhzOVa1/N1iuq/C4dsHqNiIJA2?= =?iso-8859-1?q?Z6uRKmANP7FfpNyc1nV5UPR2j9G1pYAPbnf8QsfVBRMRAoRLvvt3vaySsq7q?= =?iso-8859-1?q?qy/4923PpuR4KjKc69JcNwprixpQw7G6DtJYSVn403wQ5rCZyEKp27SFhHym?= =?iso-8859-1?q?MT3ryJU989spaez4ADasz+Niux+cUdPZlKLA/lbV1OxJ4zk7N/9AMXuVJurH?= =?iso-8859-1?q?Kss1mS6lEFwX6P+b3FWQbpCg1V8rDguCWk/XgIiE6oYALFYPgv7U2auDJGGs?= =?iso-8859-1?q?O+vTnJGdRQD2FyEOGZxT3V3lOCthHxvG4xj7DvSlWmW8hX6sV480y6kGLOmx?= =?iso-8859-1?q?kDP6BM1hN0qA3WxMVHAiljNJoV0Vw8Kw6Moaqe2Vb1LnPQwSXMO7FDRyxS61?= =?iso-8859-1?q?hNmgilz/uCJt7M0rJPPnJxxyoBAM2qhGyUK6ko2TNON5+CKfZ45mIvz4YMTJ?= =?iso-8859-1?q?omZMYaRemE/1yOaNsBOtBMu7s4Qly63D9zs36Ik0e/SkAoI5IB6oFCcuhBAm?= =?iso-8859-1?q?AReopTX1ME+HxnIQtMwPhjH029N+YZSZqA7EbIbtZvc5DV/G9ensIhJ3kbcM?= =?iso-8859-1?q?7fX+hZNYfmu4nqTGXREwEDeHJ1gWuzgE0CogCkh+Hx++Pwm1ZSe8ACQtQG7y?= =?iso-8859-1?q?S0Z1lrGWJD4UFdMz2Ac6pvqqWbACZBJjrnSu66LxpCBkJD9dLcle6+ObcyOu?= =?iso-8859-1?q?bWf7CLfI2qs9dKBPh6wqJOLDkx/b2O3cbfqjm7EQIPeEj/r/D3aIC/GnOGVI?= =?iso-8859-1?q?j1R6hyb27m5G+quEwWu7GxSkD1qLvRm2j9VVyotwPR7hWIap5Wq6U47/rgWl?= =?iso-8859-1?q?iAOy8FgSj6P+lfaXGKqrxLWpYK5NrUzP4QT3+bPCIgM7nPtAXu0IckPQoaUZ?= =?iso-8859-1?q?chirqrHkMp4x7v3u+et0dpmSEerrGApfdo+Z9Cit1EXusD6/zfGSpKO175Rt?= =?iso-8859-1?q?M2RQf40JemOXkPDj15DUPMS+RJQiIrzlG7nySiYnQqAT8XWTtNSiKPyxLYln?= =?iso-8859-1?q?KeRkFYvCw0qgKjclSNJvUUim9z?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5345; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 54rfaafomUOU8hxbHFq97xXkaobDK7uHThB81gCJg7fxorkTZiVXfIa/zGklP3nEmgTmArYVJK35QFSDQOc/TM6oQdpikgbsOIUEZBWZ/Hl13b57hoJnWlgFf7RmxitTVSr+H8g3M++T3il3MF4gZ5+ZQrwhHwzisL9JAw1Lp5q4W8YGRYovopxHEsplTvIWxyNzHlBP1el8zF4ANV6CLPx3b7VAVQrAaDK+4Z6Vy/Kiext0+i8DDZcz4vmKx5x+BV9ae+9NvGj5HtkmC9kfu9SOH9ZWHhIL8yaIBB6qPkr8eEWpqra3gmgK+LsSAcSYPUtoHODGIs68AlVP9yd2emD6RBzodRe8nnT4yyE6QId1PMDGzTLtsFjq1lnL3nf72mPWYMwiRHsXLiiedgFGMBc6CwRbBueX9fjKYLAsWPI= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 832138c6-98b5-4365-e3d8-08d6a2372b3b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:15.7183 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_052519_765122_4AA4BCC9 X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "ulf.hansson@linaro.org" , "dongas86@gmail.com" , "khilman@kernel.org" , "rjw@rjwysocki.net" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP It is strange to only return early for -EBUSY state and left other errors to be still measured execution time. As for error cases, the elapsed_ns computed actually is not quite accurate and meaningful for governor to use. So let's simply return for all error cases. Signed-off-by: Dong Aisheng Reviewed-by: Ulf Hansson --- drivers/base/power/domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 394f9da..f012576 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -457,19 +457,19 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed) time_start = ktime_get(); ret = genpd->power_off(genpd); - if (ret == -EBUSY) + if (ret) return ret; elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start)); if (elapsed_ns <= genpd->states[state_idx].power_off_latency_ns) - return ret; + return 0; genpd->states[state_idx].power_off_latency_ns = elapsed_ns; genpd->max_off_time_changed = true; pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n", genpd->name, "off", elapsed_ns); - return ret; + return 0; } /** From patchwork Wed Mar 6 13:25:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841111 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 155F81803 for ; Wed, 6 Mar 2019 13:25:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F08122D96D for ; Wed, 6 Mar 2019 13:25:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E4B052D975; Wed, 6 Mar 2019 13:25:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, TVD_SUBJ_WIPE_DEBT autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8C6822D96D for ; Wed, 6 Mar 2019 13:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dx3rRWTgiAKIaVbCRcNa+ImuTy30E8naaazIY0KVqWs=; b=ETf2aIgyegfi8T Z9KfpNJMYfZFfJhdpiHpyhKU1W5zBB8h48Kb/ASvOe45LkGcDU+rL8iuVbu6h3w75HZAaQ0+vYiEV LbLCCPspWHzfkoNMI/HyJq1Med9VD4E9PJfqDlPWXx2m/rp4+snydBeYkkkxdhnivAfXPgfCRPqWG YLxKnh+RIRyIvn3wrVm7pzcOk7SNvYFliOBVHzi2ZnO2SnFNu+TEibTEIRjFl45Yx++iReDx6feDE c69jYfu+imdWI283+ZrQ1wRmJUwMWcA3Xg9FYHbrdPEuRHQZaOFcDu5/tU+UmQ/B4dGMeIg7dcjuH e1GIHaDcgKJK4Kg5b+dA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WYT-0005pK-4j; Wed, 06 Mar 2019 13:25:53 +0000 Received: from mail-am5eur02on0609.outbound.protection.outlook.com ([2a01:111:f400:fe07::609] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WXz-0004wD-QR for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 13:25:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y3gLM0Ep3WXLLGMnQhSS5jXJYa4NVBZga3MU5w3OOzk=; b=Hcl33a1y5r5V7h1Y5Fd9SjKxoeSStVjS0/GKrBcVw4LLnLIdYGseQ9hhq3TkRnfzkELq1Jigq37VUI0CaPVzQtQcLpGcSGi/G84G2NjUNddG9/UDumk/gGIqm+MMeBLlTspLZ95DTr8zTiNTx5sTWYCbHw3QAX9KVhOmRgduD2U= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:19 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:19 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" Subject: [PATCH 3/6] PM / Domains: Remove the unnecessary ->power_off() check in genpd_power_off Thread-Topic: [PATCH 3/6] PM / Domains: Remove the unnecessary ->power_off() check in genpd_power_off Thread-Index: AQHU1CALGa0PmZep30ehAvf1aptxPA== Date: Wed, 6 Mar 2019 13:25:18 +0000 Message-ID: <1551878302-8146-4-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e8ffba3-da54-4616-203e-08d6a2372d58 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB5345; 23:uQ6Ud3DGHsLWt/PZ0G7lsUhQ0IEhV1yStOCbpCF?= =?iso-8859-1?q?WfXGyiu8HajFhmH?= =?iso-8859-1?q?kR8Hq6MalhRJfm37wQkNnhf9JYJ2haRHIzojgda/se4OUmv02ZrUwSHqqA0g?= =?iso-8859-1?q?jhdLx4KghPL+GWGnvO2vXOJJGbGjmjZS1wzbnwDl8OJLCucJ4vOIby6w8zcj?= =?iso-8859-1?q?FPaC9MJR1eLUHJI8z5pNZLqtPUaDkKKBAE5cXKyuDkanqaARajVXsFN/k91u?= =?iso-8859-1?q?/I4om4xjkqVii1ilSA+UdnrfJY1GmbXONkIpZRBDNf4bo0ynzHDm43Hd5tbD?= =?iso-8859-1?q?uBnnXnzVn6F1KC6baqFDWw4DiCGc2FaJkithn4AEIkd1y16Ck/AmLc/1Vdos?= =?iso-8859-1?q?8xXUgZpHPCeCxiHGNZ0q6DWlZwf6CukFSR8UJ29yn+lqxL8RlPZIjdYkcDHN?= =?iso-8859-1?q?GflSPyqdJvkMBb2YCOoy+QSqU5BOcKaq4F/7U6Xvdo+KHODKdSk1Q0ScKh1R?= =?iso-8859-1?q?Kt9SswLiDICDnbx7sIDq240S3ASrPeclzbom4m2Z+Kdg3Qjd0skrWcz1SjiU?= =?iso-8859-1?q?6fjOZTtT4zOTgHdIalSOXwDlJNYnknrmFSJ3BDYfbqtU4/ciHOnmAinQOQ+w?= =?iso-8859-1?q?+U5ARpWDUAXUt4ccLQHrzF29e0hTJTiklT2Pniz1Jru8wUrymOXaXSk2ACvp?= =?iso-8859-1?q?w0GdxPstDryKgzuDggiYRywCZgCAXu56snAyKUy4f3kflSjigUO/zeRZ1l2v?= =?iso-8859-1?q?fPNlJtsK2XB3x7K6xxaiM7uogzXS/D63M4PTQ9HFsmPemPDDCXqL8XSBWbya?= =?iso-8859-1?q?v2u2Z1zRKZ6GfPhM6NBPRC0T5tGwTq8Ge9Hcj9Xw0j64uOIaCT/glx+YqHH3?= =?iso-8859-1?q?mbUD2LOsK7t5oM1brlD6o+p/LsUrFoAR60/fbt/1WU3bDL4cykl46EvWDwox?= =?iso-8859-1?q?t1cPT5PnIy29QYfOLkKObn4jJ1M9oYek5C2a2d++XPGTHdnZzZBaa0wNLduA?= =?iso-8859-1?q?aIs2y/D+eAcwshm0utefHu1ZOsdHbcpjKGQmcaC3XupqBWrRCXKPPK4/yAY5?= =?iso-8859-1?q?ACBnbk9bmCvrsessfMePvs5KuFFrRO+rj4+XKqrATke0ZMXgvKC28KiWeKRS?= =?iso-8859-1?q?CluJ7XGkEdPoIrJbadiAHvG6ajlGUD1oztsFOnOUE7rF5i6LapWwkcmwTs8B?= =?iso-8859-1?q?oIZsfCUHzwNsApr+sb5ximrDB0saPLHpOEKpDkrJioWzlo+E8XMb9MW3fW2S?= =?iso-8859-1?q?YKy3VblVh2btfh0ljnLT0ind7FRvisPo7kQ+bxkzXS3EAZ1+rqFrwZFEWD76?= =?iso-8859-1?q?/bY75Zzl2ITLa8uCj4AJVA56UhUElW32h6GPhcd9Uetmjn9A=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5345; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: X2Uiag33iWD+5oF7ZU+vXkCul2USrviIpWp+lDicnd8OUUwHyaQzLv7ekiOgBMIWGJyrzTKuGBj91G37m3xjVHMVhJFFmyguoTTrxy2O40LkoxuIcaM+MmP7LDb7/ZlvF3L9SSy4iJGA4+o8wOoEPnwkNAd6D8NIANARfZC0xcThJwAz+Vuad7190eJvk3u8f7oMODWOPAxmwOWD26DUiQ5aA116hTBQj1xfjGOvTdr4uuxJY+Htfg84DKdImL3bqU/R2Ig7IKsh+FHHRuBq2N261KaZfOd8WcWs7Rdoga8gvi8ytmeGjn0e+JCjmOyC4Sz1GcWkGNqT/wO4KncxB2pMLOlzXmRL0/1qsjaQr4bzlvU5rhKlEPjK1X+XmWRL/HxYsCc+hIkADvvk9/pTOxvbHN+oXmBLaEjmC8ktNG8= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e8ffba3-da54-4616-203e-08d6a2372d58 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:18.9997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_052524_558934_C19694C9 X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "ulf.hansson@linaro.org" , "dongas86@gmail.com" , "khilman@kernel.org" , "rjw@rjwysocki.net" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There's already a check in _genpd_power_off, so caller can directly call it without checking. Signed-off-by: Dong Aisheng --- drivers/base/power/domain.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index f012576..591f37f 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -501,6 +501,7 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, struct pm_domain_data *pdd; struct gpd_link *link; unsigned int not_suspended = 0; + int ret; /* * Do not try to power off the domain in the following situations: @@ -546,24 +547,20 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, if (!genpd->gov) genpd->state_idx = 0; - if (genpd->power_off) { - int ret; - - if (atomic_read(&genpd->sd_count) > 0) - return -EBUSY; + if (atomic_read(&genpd->sd_count) > 0) + return -EBUSY; - /* - * If sd_count > 0 at this point, one of the subdomains hasn't - * managed to call genpd_power_on() for the master yet after - * incrementing it. In that case genpd_power_on() will wait - * for us to drop the lock, so we can call .power_off() and let - * the genpd_power_on() restore power for us (this shouldn't - * happen very often). - */ - ret = _genpd_power_off(genpd, true); - if (ret) - return ret; - } + /* + * If sd_count > 0 at this point, one of the subdomains hasn't + * managed to call genpd_power_on() for the master yet after + * incrementing it. In that case genpd_power_on() will wait + * for us to drop the lock, so we can call .power_off() and let + * the genpd_power_on() restore power for us (this shouldn't + * happen very often). + */ + ret = _genpd_power_off(genpd, true); + if (ret) + return ret; genpd->status = GPD_STATE_POWER_OFF; genpd_update_accounting(genpd); From patchwork Wed Mar 6 13:25:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841119 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 73CFA1803 for ; Wed, 6 Mar 2019 13:26:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B9012D96D for ; Wed, 6 Mar 2019 13:26:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4FE632D975; Wed, 6 Mar 2019 13:26:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EE8D72D96D for ; Wed, 6 Mar 2019 13:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ST4ZEytLnd4PeJudZqAALNn5vDKM43Ok43SJ562QMSA=; b=UqDxsoIKhLYNbk xy5Ln/WaIcEOPs1335TaqubTfsLIQPm0ti0PRcRC5MO4/xd7zlrtJpeVIPWMgVy0HPmndH0EMfTmz QOzYBJGl4j/1wlc8RGhWCkgro5Un3MkeSjz/886zSeh5dE9kddk6sX0Igbx0/PevC2skvYBoRFPZR bGyi+xV0r/zpAtmjPx4xnepbgnryhH/Qk3HJry5CphptmhUQMDk4FK/+E5QwHZvLlzEat4u0s2Q5V a8Zokmnv9qtThnrUPWEmzrl33jwvlqC8t7wPFBvBz5x9XNrzF1de4z14MJaFAx1theJN9E/1vQ2Z7 HSnqkiwDnFeYBzhw4BOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WYk-0006Gn-1f; Wed, 06 Mar 2019 13:26:10 +0000 Received: from mail-am5eur02on0609.outbound.protection.outlook.com ([2a01:111:f400:fe07::609] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WY5-0004wD-CG for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 13:25:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/xuxisU4vv5vRzHAShWyRDcg2nis3Q//bBEKXXRVb8=; b=NQ5uSdAyfI+7Lfyup71zjfiNBIO39uQQYrVJuNkHXApZjeBJaG0D7QENj8/aYVQGNxTY23LgFg4Dikp2JsARZEf6eA/GtQWDqsAR52UZeb22a96g1Ql9cBeOMUXYjejeXwMEGI3uGZEqu6IQcPKr+HPsCNHyj6yQ1IpN+nJp+0E= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:22 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:22 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" Subject: [PATCH 4/6] PM / Domains: Move the Subdomain check into _genpd_power_off Thread-Topic: [PATCH 4/6] PM / Domains: Move the Subdomain check into _genpd_power_off Thread-Index: AQHU1CAMzk547olF3kOGQCSlDNQFUQ== Date: Wed, 6 Mar 2019 13:25:22 +0000 Message-ID: <1551878302-8146-5-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 519f0d6d-6b6b-43fc-d089-08d6a2372f4c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB5345; 23:eJYEuWzAw+JqpTJUy8mwdNPHY70+Yoo8pbSz0hh?= =?iso-8859-1?q?8nbTgpwW66Om/YE?= =?iso-8859-1?q?gdVaQibJEW6NE8HkX8VtApURqFhTbzr+rW/ceXQsU9OejS6RB2IyIh4EjTGS?= =?iso-8859-1?q?PufRdBfk8I8sFdxd6NN9ctMzhTT0+9eUic5nC+/qHZlungL70gQAWVB9V6Ri?= =?iso-8859-1?q?OTRYRV3NDP8pKcTUILZ6W42nO5aZAUK0E6r2efrJFhy7QjXN+kgWOko+1h15?= =?iso-8859-1?q?Ijp0/iOjJhOf8eh4DnmACksntmG/D7Ah7hXTITuDJprqs8cHmf3ohjH6QOIM?= =?iso-8859-1?q?V7lyyh92S65uFs/l+5NJ2guyFhz1/NVXnOnuNi+EsJmYHNSnJnLTJJSXZdoT?= =?iso-8859-1?q?DTEnTMx7wpJdp64hIIAeCdQCaF6JhwZ4UiC0lxd7oXiv/5wK7De8iszwutFS?= =?iso-8859-1?q?XZU21zRqNlqL4diPtYtmqhGzzaKAxgGs7EUEWeB8MfRMYspeU76+czkDexb0?= =?iso-8859-1?q?mtPViNyX1BU61IPd7iGN9G1r7GjVH+Nh9QGlwpFatHDDkztpK5UvLs8pEcU7?= =?iso-8859-1?q?A4cR3PA2t/X9OJyZIwdi26l7+pVNiFnoJkYuQoDCp5CHd9GOyePR2Mf8nJLf?= =?iso-8859-1?q?8zdHK1CippdV9NtwyHnQf6a9bK+X/mVWo9m6pIxg6C+2FRav18d8hzYgba2I?= =?iso-8859-1?q?UyzVwqExJj9obj5hzCLowjqtaABcHXWc0w9yx1g7queDfVJ3UZMxuOqZxRb+?= =?iso-8859-1?q?CDAIAIQ48ARUn9oVM4pRsRoeQuvjKwdchcwBLAMD1zn4wdG5u/75deXm1yFC?= =?iso-8859-1?q?mY+B/SH/WD10aESD1P/3T/DLT/gkWvv4nREmVR26M9sENOEBLjaTD+CJONGC?= =?iso-8859-1?q?GWbQT64HZmqkG97N9fIK/Uwzy2vU5XKpZmueTJTtMebPWCaVP4F+J/wQu+es?= =?iso-8859-1?q?PGMxNAgNUge7UqQUIWPKeatCq2Ts7cGpaydnwCp8DJWdMOFdS43SsBDDUsy/?= =?iso-8859-1?q?sRJORbNBfAKTpz85E18fCcRdM0k5ls6XINsVVj8V3I41+MeP4p2n2YveZ+l+?= =?iso-8859-1?q?6cFjvZHIjzC5cerj/v3omBm4pMt5ixehEHSH8aC0NMeIMp1pdNcZVCtgFxrd?= =?iso-8859-1?q?EDyXHlDeGefO6QJ14onnSuAGX74xg+NFiXoblKdoNNnmOHrRZ/gXzYV4fbBz?= =?iso-8859-1?q?pz2lNaYWDtTk9XGfHycfmzsifz1nVBL4B1rtYfFTp619/rvkPRxmNTbgJoXG?= =?iso-8859-1?q?+8xPABVOp7BWdf6NXevC0lTUxpuXkZzpFWHlNvKrp/6nwyE+j0S9s5vyJG+i?= =?iso-8859-1?q?bWMQxUS9BUExjzdLYCryeQCpv/JKQmKXFlXYPiJz+KGBtv/A=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5345; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: aO51EvjtVxFXkrDz1AY3lDXVIN2+ICX4lp1yaQQkcpd6fXWgB/NV0Cjy8PaHhqd/5oHeorzIALG7pXCdh6BxdQBiJze0WRCWbKnszuNwWwYHGbX/ERBklWlTKBI/nuHiOLvdvDC/GVdpVvQjA8inzSwzXeRZeFEHae58qmcWrUljPlN5dEs+BwZpQZrVsddeVC1M8FZR5xG4kxy9bKFa73NYvsT+/rnukRzEJTcKgYuAMTGDCDXFGvYpMse8LQHibOG+FtsrepHsUh52TAWhIgWutFBwT7rUXbWaZd9bDslntnvKQVHS5i0mAu3DU32EzmOa6alRA1jgqPW8tlycQ1kc10ON+Kxb1ZPBuJgoGvooAqyEppYnp2dy9MFBhR2vbjfLw6aJFv/l78+jOTMj8Y024ikEXEpDpEfnJlTG7+k= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 519f0d6d-6b6b-43fc-d089-08d6a2372f4c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:22.2630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_052529_990676_D77C0CEE X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "ulf.hansson@linaro.org" , "dongas86@gmail.com" , "khilman@kernel.org" , "rjw@rjwysocki.net" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Move the Subdomain check into _genpd_power_off, then the caller does not have to check it each time. This also ensures a double check of &genpd->sd_count before really power off domain in case it's increased asynchronously by subdomains. This is the same behavior as the original genpd_power_off() does. Signed-off-by: Dong Aisheng --- drivers/base/power/domain.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 591f37f..61cd500 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -452,6 +452,9 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed) if (!genpd->power_off) return 0; + if (atomic_read(&genpd->sd_count) > 0) + return -EBUSY; + if (!timed) return genpd->power_off(genpd); @@ -547,9 +550,6 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, if (!genpd->gov) genpd->state_idx = 0; - if (atomic_read(&genpd->sd_count) > 0) - return -EBUSY; - /* * If sd_count > 0 at this point, one of the subdomains hasn't * managed to call genpd_power_on() for the master yet after @@ -962,8 +962,7 @@ static void genpd_sync_power_off(struct generic_pm_domain *genpd, bool use_lock, if (!genpd_status_on(genpd) || genpd_is_always_on(genpd)) return; - if (genpd->suspended_count != genpd->device_count - || atomic_read(&genpd->sd_count) > 0) + if (genpd->suspended_count != genpd->device_count) return; /* Choose the deepest state when suspending */ From patchwork Wed Mar 6 13:25:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841121 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 14F0214DE for ; Wed, 6 Mar 2019 13:26:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F31212D96D for ; Wed, 6 Mar 2019 13:26:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6D2E2D978; Wed, 6 Mar 2019 13:26:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9B3702D96D for ; Wed, 6 Mar 2019 13:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rYXc3d4rWr6azcVxSTP+NClBTZnj+vRpFejYhUBzj6A=; b=qG14kPx74QblMZ iyUg9JnxXF/GaVp9dN9e8p3DsLBAlNoBYm2hJFrL4pC13TjdT1H7/eaSdelz05GnyYD/xm9dvHPEF Lmlm+JgOOfBkNOCtXNCYJjRzaKKpwaBIIz+xZtgCk0vDJQqfwOKSeFZVaq27jBbUuGZvKWlbVr5jp svgd8PLqd5tkD0RHFEdcGF3KneFZ8pzMLe5bpD/tikT5yMVDwNxdQXHlcp0GPUko8bioL9Xe5cWqL 8cjM5hUn9s8HUOEs8wUsSW69JXzpbWgcyFNbUAt/0zPTCWW4XuLUqD4mDwSZf+0opLPN+3L+iI+HZ 8xz2BZWGaUPuC6FbMpHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WYt-0006XX-VE; Wed, 06 Mar 2019 13:26:19 +0000 Received: from mail-am5eur02on0609.outbound.protection.outlook.com ([2a01:111:f400:fe07::609] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WYC-0004wD-Gd for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 13:25:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u8Inpm01HuN06vC0hunGcQTPeTA77qZA1/PYKqUYVrw=; b=DwIXkuUf/Ho82rNeZoUknnZo5v9pBMKWvEBvrFKeeGIiR+MFc3mi77PsEegvwJxD5vTyYeou50ttgUcmpAjgYqzb98k59B2sH6mDgvq3EiGWvxIKpfTI+if4G2kI2APr3iWo8/WcIKaOfAg95VOPMeDPMvlIz9vee2xibEPxzYo= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:25 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:25 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" Subject: [PATCH 5/6] PM / QoS: Fix a typo in file description Thread-Topic: [PATCH 5/6] PM / QoS: Fix a typo in file description Thread-Index: AQHU1CAP/M2cmYJ/UUG4SZb/w6VvKg== Date: Wed, 6 Mar 2019 13:25:25 +0000 Message-ID: <1551878302-8146-6-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48283d63-982a-4172-616d-08d6a237313d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB5345; 23:2U68A/dfu9dpwxhbqAKfIWxrUjJOkcgkQNgbkEB?= =?iso-8859-1?q?xO3N4O+eio4ZjlU?= =?iso-8859-1?q?QgDrVYPnbK8N/drPnc7cNb7HfJpQIkDREp48CwWf1+ZkHGlc/DNHzpP5akAP?= =?iso-8859-1?q?/4z128i0i6J9PqslIB2JRPg+kVSK5N/rDBWs8ySTMx1y44DIDHInfbHqHFG/?= =?iso-8859-1?q?C9pMBjO1oYTY6NofPOD0IrZUaKg2dD693cjD+y3NYDJXKEXtAlnKnJyGZvze?= =?iso-8859-1?q?ihsMFb2/IwMkB3N1/rwGKN8g0PcXww9cDGXZqCRqv9I09VIeQWwyDfh+eGuT?= =?iso-8859-1?q?MlZXRI4VbloJGcooQVuQWCZG4YekETgte4tLHxU89Cqil+HH9IRK6OkXfSOL?= =?iso-8859-1?q?7fBV8l26OZIOyN59/MBmNX4lRxd9F2yRQ3QqYEVK6G7tX7ufi/stWUs7knZd?= =?iso-8859-1?q?2aIp1+SoAK7ZIR7PLJFyYoDmPtswHuR9CwfMKOWa6hcfKnmtlJwKdOCc5DZS?= =?iso-8859-1?q?keJRINwo3IUsYJ7rHUnAGXu0O3B9s990LADoqce9+7V/yYJrsHaVz/fhm3Ny?= =?iso-8859-1?q?/+fYfcUFZSoXGTW0LyEfcZZtHelOqRn4M6oCQ/1z7C8zKjwQvAaKCm4qV634?= =?iso-8859-1?q?i9OKMlYVyP+uLIBGmSahmsQCFcWo5CecQli2/vryqzXz9uGaKbKtLHDSJDoo?= =?iso-8859-1?q?IfUCKNdKhfZmcFrfmWWM3xUevEussUbjH/qd6Ugj4QpOrugi+rBAT3wwkLFr?= =?iso-8859-1?q?eLqv7V7o+ZwkwpZ2K3i8jSBHoxm5vXRE5ckTfdY48Pbf94XpjbKgZN+ltY36?= =?iso-8859-1?q?b6u4SuUjoGgfK3sosXQC3FP7D4uKs2BWfvi26W9RGYpZ60cT2wXZgBcRcJHM?= =?iso-8859-1?q?v/D4M5EUP2UO4Dku8ASXvc5AWMCE8NpyguzKolhYw/tx8xmDs6XISGnjAhYS?= =?iso-8859-1?q?l0Q8HVCiHF/tLsTJXlTXUg8rrsoOllC48Nl1hu/67j0JRqH38Mksc3+iXvZA?= =?iso-8859-1?q?lKWh3H4WVYw8oK8s3+dEwDcV1NRi4WcO4Qdug5AtMyOzqRjecpDKo4X8ZRPh?= =?iso-8859-1?q?rfImSMV69vr7UMMRR8v90m6bRsehjzRPPfozcFZFxG6JZNDzMueS1iMAcyJG?= =?iso-8859-1?q?EtOKz8e7t/dEr6lov/LplzC78l6EYGpCWUz72P1DBJ3IcWzdbb1R04U68JAB?= =?iso-8859-1?q?1hcaseIobb8bi4ZlRnpWEz/gsT4HLOWi8nhG0dxDeW/S0EhXd50bdqi4rvgA?= =?iso-8859-1?q?Jk1GuqzMfDUfH4KuSQYL4EfvflZ4JHDsdKgcdEt5nfCgelExf3CfaOjwn1zx?= =?iso-8859-1?q?21alFV5Kp58knwVcbiBiTwgRzrcuhnaGXba5F7Ff8ESJSC2jXGzzQ3HD9WYs?= =?iso-8859-1?q?sJJvh66pI=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(4744005)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5345; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: J7NjUri5RUMCR+yxgrEsMmi62nT6MEW7SSCLzxbCB3LAsLuQryXihggnds9GbUOawPMY8ddk94aa2MlWTIQmr0uDoSGJG8IbaQl4krDhOoloJ98X0Hyhypga2o0i94lWozaJ2iOD2ysr0M6rhsdjfr7RDTFopnOgN3VuJBrpf6M9N02YqMcql8Ot7fjYvZqKFwBQPtN1sZasXxxMkHvxwNYI8CebCHoKOAIlK5/PyNVWERUzjtgLfhjK17OEe/Ndchu/hSOT4Kq6zW3kt5ai3F3+FVntn7GXaiURv1AINPkhfihW+skxO5ynL1e7MrrPqdLfqg8qlNcs8VXUskeyNY8D46WbFE5XkyWl3pKgBzhTirHu55rYiEw5VNlmCqIhm2xKJsafKwhHe+A2hbyPag7gJVUWMC3XxXSAsm2sgyQ= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48283d63-982a-4172-616d-08d6a237313d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:25.7264 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_052537_246834_19BC1C3E X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "ulf.hansson@linaro.org" , "dongas86@gmail.com" , "khilman@kernel.org" , "rjw@rjwysocki.net" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix a typo in file description Signed-off-by: Dong Aisheng --- drivers/base/power/qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c index 3382542..f80e402 100644 --- a/drivers/base/power/qos.c +++ b/drivers/base/power/qos.c @@ -22,7 +22,7 @@ * per-device constraint data struct. * * Note about the per-device constraint data struct allocation: - * . The per-device constraints data struct ptr is tored into the device + * . The per-device constraints data struct ptr is stored into the device * dev_pm_info. * . To minimize the data usage by the per-device constraints, the data struct * is only allocated at the first call to dev_pm_qos_add_request. From patchwork Wed Mar 6 13:25:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D9B61803 for ; Wed, 6 Mar 2019 13:26:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 757682D96E for ; Wed, 6 Mar 2019 13:26:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 699372D976; Wed, 6 Mar 2019 13:26:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 198162D96E for ; Wed, 6 Mar 2019 13:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UxO6lVJDFBccVxPDOMcm1nR5GG1xD1shcaBC8mZqAgM=; b=SWEkpRLlheFZiC P5SFRLBcr9jaz8tGAy4EtGIYDsfrAZF4eaNw9jJRCocceV8kdWFGRwMTz1qiymIeJccJPSb8GHIqE GR+LTUWZkpqyBg95s3f+zd1VQWZ55ss3FEMw7R8YfdZvc7PBfKJyunli9jaK86+oM3oFM7DiIiDkI lJcE1Q+cPFkkNK8NKHZH1gwojhNbgiw8W9jDGBBG7cV8fpvy8k4tVh/Z5nvlYZQ/09J2ciSUkPnml zSeBilDWb5Dd7zx/oBcup5mjKe/8DJPW9+Ic7QFptEEioptFU/vvhf9hCBNFeIWUhjKnn2TLwJBTQ tck73xEBLYDTs+mRz43g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WZE-0006vP-78; Wed, 06 Mar 2019 13:26:40 +0000 Received: from mail-am5eur02on0609.outbound.protection.outlook.com ([2a01:111:f400:fe07::609] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WYX-0004wD-OB for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 13:26:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8oNdiJyQaTZ8oEUyQVRFD7WhzX2hNsmaiAMeSBst6hY=; b=KqOl/eWSqT00laubM7eWXXC1Ncb/m6ryGfpsDjNQB29heLEJ5rrox6eg615J+eyik1avyEcFGaczCTSXtzQF957QNzRwfOZDu0oTn/ijjzmdInRvk/aTdYryOkADBpORdQ9odn25B8GxzxXhFq70WF5pMoqW5gX3ty7ar5033JE= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:29 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:29 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" Subject: [PATCH 6/6] PM / domains: Remove one unnecessary blank line Thread-Topic: [PATCH 6/6] PM / domains: Remove one unnecessary blank line Thread-Index: AQHU1CARZTO2kTZNHkGtrmdCJoOMbg== Date: Wed, 6 Mar 2019 13:25:29 +0000 Message-ID: <1551878302-8146-7-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 221dd8c5-a40e-4ecd-18a4-08d6a237334d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB5345; 23:DTj0xRHhf9e4EeEYYhSY6tnSR3yFE4K0oxYyig7?= =?iso-8859-1?q?aIinJZMUqMrvjcT?= =?iso-8859-1?q?fELPco9IGce6tpM+KVbL0pu25dpcEy22gdpWmYgsGQ0CUKH63NivQXfmns5S?= =?iso-8859-1?q?N7yhgbYgHBsJY/UQ6AN1Au5C/Mk/JuxPSREM3jDALAuJYiEHBSaVEzQ6EeoP?= =?iso-8859-1?q?PDY4SltSpNQ1FonIRttEXjlgSgJx8kvjNBSXpvnBdR7rMWp/3n8uJK3wy4yl?= =?iso-8859-1?q?PUUpQmVIE4H+Lcoxzh0t/4IrxYA0pBkcg4vD20HiZ/oYCJC7WpuUet5DztUN?= =?iso-8859-1?q?bZMK3BAhw7oO7UfRFYSP7tBi/bq4n8UysE+MqmOV+h4UZbi9u4WdzSJ4+jR2?= =?iso-8859-1?q?//ICc+dAXPbkh1fBMgQFSYOrHYc3XUIanxw2/EPa7Xh8/jQRPCEY9FC7uZEo?= =?iso-8859-1?q?Go6YkrhoywOnyoTwOkE8Ea9ul3CZedYvf/qWanHpoiGDo0wX+75jirnj2st+?= =?iso-8859-1?q?7GQKhtO2o7rzf7rUGJfuq150esyNzF/UqXxG83xtr3dq2iIm8pXoI/Qk8FWf?= =?iso-8859-1?q?RpZy/w4NrPC3yP5HQ/9C551ww/in3HtJa5L+Z+Xv58wh2Nj4rq40Aim1vslY?= =?iso-8859-1?q?c/8PqNla6grsKS4OakR34+JKmi/PKcicHKU5w7fZ45rXnBADCU+tTus1SXTS?= =?iso-8859-1?q?xg9wjLPPQk8DaDy5jAkAf8XGyLe0UZR8R+tLoDKnTgZFrQNtlovUTsIp1QEX?= =?iso-8859-1?q?IE9qxhvzjkWFJG39aRfvEv3OzR2yo8QznYb92ntRD9Kmsanlu+80e1kfxVJP?= =?iso-8859-1?q?gzbrgm1skXfjdVSfkg/iEN1+lRs2nUGHVSWIl5j7lZ4NYb650U+h6ob30ora?= =?iso-8859-1?q?+FNlREjY7zckbpv6bCisPNqvqC2SrN3k2fzLwCqNE9ZNakqqIyf/0RPtkquh?= =?iso-8859-1?q?d93X6V979KwG8wvxwqzjNNI3EpCx7K2pB+eaYMpEwVgBCdO+BtFH17CQPuus?= =?iso-8859-1?q?c3Pv8OUqe4Ki03vsgg9KExvho2qAyHJZu/DgMFlepKA2yoBFqZEbfYN9rtWg?= =?iso-8859-1?q?9zFgLjCQGYZtXncaQWTNjNgDnn1FKqebLRLxD4V2gKF+YvrIvHulqVlxQdHS?= =?iso-8859-1?q?ROYBQUUQeZfDeyWGYPK3Ve5BV5FIXppRb4EFS8iZlNdw79fO8N8VkaibW+G8?= =?iso-8859-1?q?a42RRU6NaoKrzdniz1UWHJlc17Bh4UzH6eTFLVkc5LBBAED4isHnspFiaIV/?= =?iso-8859-1?q?4tLrPmIPHtd78APVK5HbHPNLFxjVaZGrE9FaFJPh6TdO9M6K3xR+3oQ1Ox0C?= =?iso-8859-1?q?CwEn8kxYF33fy4Df4iqCXRQROg4EKGTahgf6HIfPq5PwOpqfLEtaa8K5PGVB?= =?iso-8859-1?q?UwNmMrI2M=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(4744005)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5345; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: DWuvNsl2kHIsQtaC1H88zKlq/xS2evhqdxkBht1qOUrfjCIhCOQ4BVf/SRQkqP1bUkPfEaNl2+JcnNIlBInD+I68/wu1o//GHJwvUAqNonveULBhurvhe6EiCe4eDwoPujOn9eAMl8hSS+eqMk2scXJ3fX4LaMu03Tn3OkCB5XkG9nIPTbWCbG9qty7RASN8eo3iQSHif+yfoelOszkXHaB8CrK37rLxrBxwS8jroaSMxQfvZI3Udyg9B6ehT44DFRt14QwpJX9qUIXD4nsgP7C8hZQdfRwnctkGdS7apxxdCHXo3q3NucJeXM5u60djvM5eXg+f+ICdCbauu6aL3tOyd+xnFgWSXJpwAmYVkRqJAn4SyqBPJTerbgnDTk988ZQsESlBQ2eoRBTTtWCxGQOopBVdZU+bVxz3hFadU4s= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 221dd8c5-a40e-4ecd-18a4-08d6a237334d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:29.2579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_052558_341831_CCE495C5 X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "ulf.hansson@linaro.org" , "dongas86@gmail.com" , "khilman@kernel.org" , "rjw@rjwysocki.net" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Remove one unnecessary blank line Signed-off-by: Dong Aisheng --- drivers/base/power/domain_governor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c index 99896fb..4d07e38 100644 --- a/drivers/base/power/domain_governor.c +++ b/drivers/base/power/domain_governor.c @@ -128,7 +128,6 @@ static bool __default_power_down_ok(struct dev_pm_domain *pd, off_on_time_ns = genpd->states[state].power_off_latency_ns + genpd->states[state].power_on_latency_ns; - min_off_time_ns = -1; /* * Check if subdomains can be off for enough time.