From patchwork Sun Aug 25 16:47:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ayush Singh X-Patchwork-Id: 13776836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F04B7C5321E for ; Sun, 25 Aug 2024 16:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jxz9W0rg7mMy2BV/5liqAlp9Grj+cfqvAy4EMVlcW0Q=; b=Z4Xdf0g/TVmmINS6CMjuNtMNeR +cJ1nk1xBj7X6dFGApI04eiPbnBM9VPssicoBrPokcZP1NJK1zMan3kMxMcmYayYTmgZVotI/A24F h3HXeW+T3drIzksj3YMGdty8+/FbUFm1Zbd93idPx8qKc/1zITFXfn6z4nGV0Uh5KYwME6v8Xuw0k Lq7wnYyxcMM0ZieLJBFdEXQrYO8G/P0sxXhEZi7gj1sjz5l+nYtOt9MMzb8ERgTqIOERz6AYcw79B A6uuMTuQZUv/SXIM7FNrGfkCKrC0+WGQWreIlmSeE+8rPQ9VNUIHrCf2TMfBf1ff6VXLcGKG/vXtQ 0e7iGKfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siGQK-00000004g7g-39cJ; Sun, 25 Aug 2024 16:49:04 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siGOp-00000004fi2-3gzj for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 16:47:33 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-201f7fb09f6so28029365ad.2 for ; Sun, 25 Aug 2024 09:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1724604450; x=1725209250; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jxz9W0rg7mMy2BV/5liqAlp9Grj+cfqvAy4EMVlcW0Q=; b=uG95DfLbynpMcppHDz3YcS1I21WKL8MdtlHRzcrEzjqr7uq97DqDJey1Pqf5doMYL0 S4PN/XZ92sVzDLEoBiN63S7ppBgG/1IvrXmw/uzImTAwYdhUQYGh7aJiUWKqnH27MVh+ 0RYL3b26pRa7eLI97ClI7hZYlsKUKx9SlOIGZp7+eHCGlEvwzboEuPgRd6nLravVWQ9b UzC2nRzQJN5B7wKy9TeLiEP0l44w8sXk1hqUbvEhQJ+zWMjnaxObvaGKjzjaEE4rBT+m RlP/RnaMh8Hro/g161m0SqQ5y3Bo82Ouv2c+3JnDCKUGkhDMR+QWJWX7tKZJ+Dt4sxPy xjqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724604450; x=1725209250; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jxz9W0rg7mMy2BV/5liqAlp9Grj+cfqvAy4EMVlcW0Q=; b=nv87PnbkFlw46htvC1FNB/S2SoXI6ifJRzFDxPTfMK2x2wUgBvZ6VjngDk+eklRla0 iB35hApPF9FQER6kXN5cb+R+jNbaa23HM1ik0PTx4jDWyAZWVC1ATv1oJTo4r3n4cm10 dZWKIIMjCngg2EMziObl6Nv+Wr2DAUmgx1l4uZ/tz470CDwLdhew0oVLMaoMnnSF1raD bRDj/N3lFDxV5NN+fyoH3Rl4ATi+G6UNQqTMEny4Oyi0+XQw+m9IwnkEnJkrbAq/OOD5 ZWmBITb1/P3pGoOHERiRa8XCiuqdt63g6HreLJ0UVCNrltDJiezAJ+LM8DcA+pmC/URW 8nNg== X-Forwarded-Encrypted: i=1; AJvYcCXKlrYFHVlfShjMY5EC+JBiuWiuHD2hNpBGCx1xkUlc3BVhskiiHsmtMVbj6aEcyuu7RDg9FrQyTZPD+Q2BVWMY@lists.infradead.org X-Gm-Message-State: AOJu0YzxmfKPshYwpsC1mHx+SrYgLLQjPV/0JRVnnzLLCVzPnZGXFwk2 CcsNOeViWd31/LaJ7RZv6VvjOJu/Lh6xZgLiLHjVhHBwvSBIUx5rAQXhN2c3MQ== X-Google-Smtp-Source: AGHT+IGVR21d8zqzI/Keli5KOIFPrhh0cOLMEXTUS9i86vC9K91QywMMPIUWj0mRJltzwRZynXU06g== X-Received: by 2002:a17:902:d4cd:b0:202:2f0:3bb2 with SMTP id d9443c01a7336-2039e555a4dmr75158555ad.60.1724604450596; Sun, 25 Aug 2024 09:47:30 -0700 (PDT) Received: from [192.168.41.46] ([2401:4900:5ae1:9eb1:890a:6b80:a16d:5ab4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20385609dddsm55411465ad.196.2024.08.25.09.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 09:47:30 -0700 (PDT) From: Ayush Singh Date: Sun, 25 Aug 2024 22:17:05 +0530 Subject: [PATCH v3 1/3] dt-bindings: net: ti,cc1352p7: Add bootloader-backdoor-gpios MIME-Version: 1.0 Message-Id: <20240825-beagleplay_fw_upgrade-v3-1-8f424a9de9f6@beagleboard.org> References: <20240825-beagleplay_fw_upgrade-v3-0-8f424a9de9f6@beagleboard.org> In-Reply-To: <20240825-beagleplay_fw_upgrade-v3-0-8f424a9de9f6@beagleboard.org> To: lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ayush Singh X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1346; i=ayush@beagleboard.org; h=from:subject:message-id; bh=GMfOVBjnJuIyDUwmWasZ6B3xnGuCFW07MH/nRO0xhUA=; b=owEBbQKS/ZANAwAIAQXO9ceJ5Vp0AcsmYgBmy2AQ2QBtHN5N93ah4bgfx1vdyCdBtkCC+s3tb u9GqnkyqcmJAjMEAAEIAB0WIQTfzBMe8k8tZW+lBNYFzvXHieVadAUCZstgEAAKCRAFzvXHieVa dHc8D/93PwsuFi6L+Z/37jsgx7MhUtmNxp+24Wzk9vMkyykd5HReCsim7ISof3Kg6TBA77Ytp8z WGifo40UZ7NZ2oMdYizXh/zeVfPUQ9aqXEOCD8uMhb/KsQBeaiF14zqE0Ef5CSwEmW9ed+2zjCF sYoPm67yXMV2B472oR2DDUlHAKZmF5C+PuwX1OHa8lVxzn01xci2IDxgrLNKk4TV/exJjCmNUsX zvDMugn0FYID0rV7sE+Pgdrf7WkblXNA624ZzL3SlIj2pwVV6h4hEHEBiT6vF04SbhXrpZqaMV6 tEwIQ8QQT1XjvMEtkmJMn2AWC7Yv4V3HH9ZjXlcIv3nHI7JmGVu36EBT2wn4mkp9MOeVe253QPc G+8YRqqoYNR067PQD7LZ6xJ2xmNtbLI/dgJK90/uBXeYS6cnjkHQt7TXzxbTmZ2C1z6Riq6JJnF FM+BW8BwyQzXwKMD9ZVIko3kmRmGOYTn+nS/ghK1+uxGiqLNXOkkAXuHA9PZ24chCfMI1RH4xF7 zO28q4vrvMX3y94l6BKLKPyALVcG8IKP8yya1m64kYpDeKWrvclvi9j70I0MCEbCp1f7SPjLdkj oaL5ayWcLNJmlLaOcqE03yvyDJoDElOxk9Oyo71qSowojg5iYbAYTrXghsFhETMzLJ8tJm5WSQU U7t6YLDAYwcQhEg== X-Developer-Key: i=ayush@beagleboard.org; a=openpgp; fpr=DFCC131EF24F2D656FA504D605CEF5C789E55A74 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_094731_972509_DA01401B X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org bootloader-backdoor-gpio (along with reset-gpio) is used to enable bootloader backdoor for flashing new firmware. The pin and pin level to enable bootloader backdoor is configured using the following CCFG variables in cc1352p7: - SET_CCFG_BL_CONFIG_BL_PIN_NO - SET_CCFG_BL_CONFIG_BL_LEVEL Signed-off-by: Ayush Singh Acked-by: Conor Dooley --- Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml index 3dde10de4630..4f4253441547 100644 --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml @@ -29,6 +29,12 @@ properties: reset-gpios: maxItems: 1 + bootloader-backdoor-gpios: + maxItems: 1 + description: | + gpios to enable bootloader backdoor in cc1352p7 bootloader to allow + flashing new firmware. + vdds-supply: true required: @@ -46,6 +52,7 @@ examples: clocks = <&sclk_hf 0>, <&sclk_lf 25>; clock-names = "sclk_hf", "sclk_lf"; reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>; + bootloader-backdoor-gpios = <&pio 36 GPIO_ACTIVE_LOW>; vdds-supply = <&vdds>; }; }; From patchwork Sun Aug 25 16:47:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ayush Singh X-Patchwork-Id: 13776837 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8D9CC5321E for ; Sun, 25 Aug 2024 16:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ueq56/ihM5P7UHNM9LExxz3BL+BrqPFaFFbdMDA7T6g=; b=sdutjZ9aSxyHKwZHTo3Rl/uTuX XFCnBM3+PpAzM+Lev+kmAGpx+FcmDnV/XvFQOvcL9bZpIBQK52v2Xy7rKxYcQrAGtJykbRx2o3y0+ Zl6ahbxcEyf2B3twiRU0T8CJVP3hirKA4P/nr2cmU2UsFDGhrk+cUvz6IFqvj1EzEgienkS88cmiG BX9X05cya56rOrB7cWoBhFCHAYqCEHGahVK3Sc4ww25p5KXgnNH1Uz5RHGSU2koR3XzMZDw88N3bK UBZWdLGUFlUiDvLPt/o1ysOUM0wGiy5x5+ARS9+uXUnzL0ze0CKCJTayNtaTchH90igpo8xs8ojcH JFg+An/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siGR3-00000004gDt-2C8S; Sun, 25 Aug 2024 16:49:49 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siGOx-00000004fkd-3tgM for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 16:47:41 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-714262f1bb4so2543143b3a.3 for ; Sun, 25 Aug 2024 09:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1724604459; x=1725209259; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ueq56/ihM5P7UHNM9LExxz3BL+BrqPFaFFbdMDA7T6g=; b=hp4LNWOPSraQIB/K3xKLWK5a+E40JeWvGa+ghY2hppuNVBrdsZUCkqgGPPUWl/Zolh aAJxnkt6oIHZipvyyp8l0Hi86iTtDAywX5FjpeDruji+7nHb3VWOffZc/ZTpdU/nHBrh 9KMYyE9mBILRdP+d+n7ktX05XHjmU8UDc0KgLlLZnf0MV0mOMjmJyRbmooTxBEq4N6T7 jx0BC0+3jTDfdKZyDWIOm7E+71JZWQfk/TEle6cZC9VX2C2/QNgN7Ko31siU4eULY6sH UTVRI/HcemVhPDpuH7ecZWUi8DbYYXDzJm/+E/UO3TdxydsVHVe9VVVLd6523OOHrBpD vwrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724604459; x=1725209259; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ueq56/ihM5P7UHNM9LExxz3BL+BrqPFaFFbdMDA7T6g=; b=uirtaDpALvGNDrLqhALrmFEdy+GrF+/4dsV7wgBmWf4jGDb3tRuiOvLre+hK8RBGF8 RSezKRW33ZQXnOr87Ndj/QovyObvtJ1IHxUgIT8k2IwK/vWG4mz7a1UQnZutwQtiBnAD wOqbZbTsepBfTbpM/3CdRCJRkkEL+jIHplW1bpBEK6KAaZgvr7+1xDqrPpEsYW22ziDg hI/EdpeFQt6MkOMQcVZ0nZDeTNg9tZNGFso+NaaRNV8vRgHS0IyhNK46JM+spn3KwwA+ nE+40XE6V6jUg2JDHrknyCKNjLyz2kHpELAjVV2qV1T3MWRf1t7eFdyZ+Tkeze/2UsuQ UMfg== X-Forwarded-Encrypted: i=1; AJvYcCVLI9XNk/CZsOfo5kc+hD7CK7dWdtDgfsi0oaN7W306RTpvyuYCLR8LapFqH/yyiZeYAxFEvwJELFMcbuNV7ffe@lists.infradead.org X-Gm-Message-State: AOJu0YwAF56OeyXg/IBbnyRuOo5abhLBRv0eHzGPOqAFisDd8oe0ISKL 1ua25g5wRhxObhl6bkHeiNqhKMMn5ECiHanHHuy+zncZpuMuVGZlW8PvFdLLRw== X-Google-Smtp-Source: AGHT+IF3wXb+mSv/UNa0ZMBw8G9xxwsqqc79mgqaYouznABo5fWpZP8CC5WQcB7qDSvQaC2AMvoPbw== X-Received: by 2002:a05:6a20:d493:b0:1cc:9fa6:d3a6 with SMTP id adf61e73a8af0-1cc9fa709dcmr3036937637.3.1724604459012; Sun, 25 Aug 2024 09:47:39 -0700 (PDT) Received: from [192.168.41.46] ([2401:4900:5ae1:9eb1:890a:6b80:a16d:5ab4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20385609dddsm55411465ad.196.2024.08.25.09.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 09:47:38 -0700 (PDT) From: Ayush Singh Date: Sun, 25 Aug 2024 22:17:06 +0530 Subject: [PATCH v3 2/3] arm64: dts: ti: k3-am625-beagleplay: Add bootloader-backdoor-gpios to cc1352p7 MIME-Version: 1.0 Message-Id: <20240825-beagleplay_fw_upgrade-v3-2-8f424a9de9f6@beagleboard.org> References: <20240825-beagleplay_fw_upgrade-v3-0-8f424a9de9f6@beagleboard.org> In-Reply-To: <20240825-beagleplay_fw_upgrade-v3-0-8f424a9de9f6@beagleboard.org> To: lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ayush Singh X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=889; i=ayush@beagleboard.org; h=from:subject:message-id; bh=9dsYNp252XCXLeZVdDf5E51difa2bgrBMStutB0fu1Q=; b=owEBbQKS/ZANAwAIAQXO9ceJ5Vp0AcsmYgBmy2ARetMtxhDBfPiDIaJ0ybvafr0n2xZc8i1BA 20ABi6GNBiJAjMEAAEIAB0WIQTfzBMe8k8tZW+lBNYFzvXHieVadAUCZstgEQAKCRAFzvXHieVa dH1lEADngrBq+XkavxM0bdXYdsYC8etGCl5fyTT28X573HMtRgT0Qfcr5FOWR48fLzVQRnmYvCo Fz9JVjKjbF/XVep/Qtm1XYlv0yXeB9buuWq1PJq6y93kHaPdJjSew3Miy7N4shjBmaap4ybYg+2 GI2pDdiNxuS2Cyujw1VWp4D1/qF7QIZCLCTUEUxhkhF4qHlOmVFUV5oumfuSVsaJ+PrID5N9bRN vUGaPWnVLAs/pjcZLnuBfQrPOT40Or2ft5jt1PCR0Ie7N3YXUjgmFvhs/qQ2sYS8Bq1aAHQK5qP 3MMKDJ4jKS5YSICw3sdPzZYk4oU7vyfQqtbTW3JKkrTiRRTBB86MznwyusGFqAMC54mc/sA+0/0 rFdy2AX0emAfUw5YoGuESI9V2hKkUIZHqCb+bK46/MYgG+erXBsydsT3r3SnW4vkisINzU+ElAv J7kWtWwjxGxYKIj9wYfaO6S1VcOWf/7Pc2JHk2NQyVLdBerLwC/V7K+1fQeHDPJ382sJlNYLZ30 YYMrC6ZnvKUybIdmGAW+RDsP0wxVUYEdN15QxJskPHze/tPsBy+/Y3qTl5qKzBuUn4GUdiN7mbr naNlHe1X5vYM4yMhw+vAJESKUgsvXi8CpqrW9cy7UPDR5H3Lll+yPwxcFsG8tMUdDnp45V8R7V/ WkSSQD2EW8xVHew== X-Developer-Key: i=ayush@beagleboard.org; a=openpgp; fpr=DFCC131EF24F2D656FA504D605CEF5C789E55A74 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_094740_041688_EFF1A289 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add bootloader-backdoor-gpios which is required for enabling bootloader backdoor for flashing firmware to cc1352p7. Also fix the incorrect reset-gpio. Signed-off-by: Ayush Singh --- arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts index 70de288d728e..a1cd47d7f5e3 100644 --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts @@ -888,7 +888,8 @@ &main_uart6 { mcu { compatible = "ti,cc1352p7"; - reset-gpios = <&main_gpio0 72 GPIO_ACTIVE_LOW>; + bootloader-backdoor-gpios = <&main_gpio0 13 GPIO_ACTIVE_HIGH>; + reset-gpios = <&main_gpio0 14 GPIO_ACTIVE_HIGH>; vdds-supply = <&vdd_3v3>; }; }; From patchwork Sun Aug 25 16:47:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ayush Singh X-Patchwork-Id: 13776838 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5655BC5321E for ; Sun, 25 Aug 2024 16:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HqKJOoYh+6QDm3mjDAuqJ+dWyDs9Vqx8ITMW9/hp9Qo=; b=3uuoK+L/WEtTEcB/8IvBl9tV1/ HE1DdX0cQg8ckZ2k+BMj3aVih3MYJ1mq/XhjEiMPCE6KHMcXrsv51Wd29LGvRtDgExL3ummD7MJHi LMKKNv/ryvA5DgqHALCxkem9/miY0WZKgsVrj5va74gEFjWrHZLER8XQ0XoV/PoTRJhoI3Gkr5vr+ VwppE4uymNMFotANfo1Hkyti8F0mHgM5b9TMDfbuJy+83Ja3UnAHLVJZVCfB7xVzv/Yj6yWOa18Z6 U1sAyyiz7AkqY96AQZa3XIe87ZMf1MAzWpxHGcbrd2TvLAAd7fjOM3lxLCXoXjaIvs2IySe0BV2DX dbrQ/lXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siGRn-00000004gKG-1Vd0; Sun, 25 Aug 2024 16:50:35 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siGP7-00000004fo8-0SHe for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 16:47:51 +0000 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-7142a93ea9cso2455345b3a.3 for ; Sun, 25 Aug 2024 09:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1724604468; x=1725209268; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HqKJOoYh+6QDm3mjDAuqJ+dWyDs9Vqx8ITMW9/hp9Qo=; b=irLzhrKxpIFrggnhfaPFHkt+sFJYe9VuD4qvPY6ovFJp8t3Mz+ndvGhWYeq6DSLNWl BVUu//FMO2ilaitD5WbDabbBOOyhKvNrE0xg99NLTd8dxY+R/OHgnII5fCmMy/KInx2j 2r3FQp2uta0MFT2FNYzzFISgOvuQySYYlRmijqSMNjRaJaCrm+0lhKZoKwcBYq5X+kUp GoEee3B0Km48xcJUf3gx2hZ9tOmWcFGTMH1WODDNAehzEuWvpZoST2PikN6vIbZ78J2I 1sbgoxVazuJzXnsFoO2AOjvyUpA0Kb4hQo2atwi4V9xOzlwcxjhGR8LX+yhP68zFYeVL slEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724604468; x=1725209268; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HqKJOoYh+6QDm3mjDAuqJ+dWyDs9Vqx8ITMW9/hp9Qo=; b=ZuuCLUbLA4ptVx+lLmpjQKgxcFF7jjh63REuv+rMV2/zT9ag7YtkYIcHm0J0eUsKad HI6ssf5V2jTfLGq2uaUfSuzg2+cgvTCKgcejh1Lfj/KZYSy3a+74KWxomgd/chLA6bX1 dbJSWxRetGPDRGcguS95CNWmmqS5uAOMy2nAYv5JKFbd+8wGlb5UXAo0QlGPnnr6xuv/ z3o5TVQxQYk8CXdHDTbp7cfRCDF+64QCcJN3h01uhATDmDEgOqxNI8CFZFI+V6v4/aAU giCgJtbD1ZMCqdlFBAzxDDET2nBwwM+JtENIkiFidzKaycx6XWd8bW0cHhyj/ic1RvLZ YxJg== X-Forwarded-Encrypted: i=1; AJvYcCXWorDf4dp5R3/eVKHP+L8C3i+kmMQXnOY1954MiJ4pekTO/XRmkim6kAOTi+P5hSgHUAosyV0EdakQwZGuXQnp@lists.infradead.org X-Gm-Message-State: AOJu0YzC4FbLQRdfwHCgN3ZG6JBAVDuHwEazGxjQreiGdc1XGDoEiIhZ elm9clcMlF/+hrQ12dt6uHw+W2vizU7AyD5s+qvNL8Ga5W8agyVU67C4T0lGaw== X-Google-Smtp-Source: AGHT+IHSE2nbY33FtwmcxzqEXHO1j70tS4H6m0teS2r/RePG63LhRbQ/xr/Q7F8+QVgIarEkK7LAsw== X-Received: by 2002:a05:6a20:9c93:b0:1c8:fdc7:8813 with SMTP id adf61e73a8af0-1cc89dbac1bmr8408747637.23.1724604467986; Sun, 25 Aug 2024 09:47:47 -0700 (PDT) Received: from [192.168.41.46] ([2401:4900:5ae1:9eb1:890a:6b80:a16d:5ab4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20385609dddsm55411465ad.196.2024.08.25.09.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 09:47:47 -0700 (PDT) From: Ayush Singh Date: Sun, 25 Aug 2024 22:17:07 +0530 Subject: [PATCH v3 3/3] greybus: gb-beagleplay: Add firmware upload API MIME-Version: 1.0 Message-Id: <20240825-beagleplay_fw_upgrade-v3-3-8f424a9de9f6@beagleboard.org> References: <20240825-beagleplay_fw_upgrade-v3-0-8f424a9de9f6@beagleboard.org> In-Reply-To: <20240825-beagleplay_fw_upgrade-v3-0-8f424a9de9f6@beagleboard.org> To: lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ayush Singh X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=23155; i=ayush@beagleboard.org; h=from:subject:message-id; bh=0I67kHfHcP6Y+hwrYr20Lj8j7TKIjwMeA4v2DVoqZwg=; b=owEBbQKS/ZANAwAIAQXO9ceJ5Vp0AcsmYgBmy2ARQ9eU4YWDUcXKkzSx9jLn5Fy95jW0R+k40 HX/zBUJKrGJAjMEAAEIAB0WIQTfzBMe8k8tZW+lBNYFzvXHieVadAUCZstgEQAKCRAFzvXHieVa dH+eD/wMJBEKBLrbodHl7EEq26YlwYObCZqMQ85ZOA5jSrPlktbZG2am2xzjm1Rcyh7mZRkbj+1 nRE0w2iUKMvAGzQQ2ZnL/HgH1Kdl62Tv3oGfrYINqQLo5rRIH0UxVjff2KTMsEIm2GMREwnJx0T 7hCKQ/vasX7+uW2uSsjfcelmI6595uO3NxDPExclRKc0QL88LeIXt3gQjUPd4+H3PBDuBUcKiz5 SxLFrNpE8CYZty2n3Z1WJHr6r3hW0w4Bv736dTFAOJJg70CzWFGYv3VRIOur7k9dBBWhYhplJUi vJNrGTZakdRQLfwuAjiFmhQzo68+1mfWZbuogOHKIWhtdZbDnmced3zVMLgaz6JJ+OnULWDt7Gc 2dr7x/0EpgM4MlcCHc2gkX6nkNRAs8LeFeLP1hyKRcuStfs4frVOezvI8ol2aOVsbJ+3AYXHlJz gT3KJeRvUqaY9wXK9GDr3pZ+GrUQuEJAQJTjYEyFLaaysz5p7OfXUBlz4IqJfApfrnW7NFcZPaX dkPU/+I/6+rqXHimnBP7nYT2M3IJXkrrktzIsQCibgyBgnqPWmh8QN+natfdRWeTd564OBbJuXC LINjuvi1yDWUSwLcwddZJBBWR4TJoRyGv/PjhgPmUhMRjawUK/yAVFPnEpFM1457TKzQweHWCVC 5xQAhyvp6kf/KnA== X-Developer-Key: i=ayush@beagleboard.org; a=openpgp; fpr=DFCC131EF24F2D656FA504D605CEF5C789E55A74 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_094749_205939_ADF64526 X-CRM114-Status: GOOD ( 31.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Register with firmware upload API to allow updating firmware on cc1352p7 without resorting to overlay for using the userspace flasher. Communication with the bootloader can be moved out of gb-beagleplay driver if required, but I am keeping it here since there are no immediate plans to use the on-board cc1352p7 for anything other than greybus (BeagleConnect Technology). Additionally, there do not seem to any other devices using cc1352p7 or it's cousins as a co-processor. Boot and Reset GPIOs are used to enable cc1352p7 bootloader backdoor for flashing. The delays while starting bootloader are taken from the userspace flasher since the technical specification does not provide sufficient information regarding it. Flashing is skipped in case we are trying to flash the same image as the one that is currently present. This is determined by CRC32 calculation of the supplied firmware and Flash data. We also do a CRC32 check after flashing to ensure that the firmware was flashed properly. Firmware size should be 704 KB. Link: https://www.ti.com/lit/ug/swcu192/swcu192.pdf Ti CC1352p7 Tecnical Specification Link: https://openbeagle.org/beagleconnect/cc1352-flasher Userspace Flasher Signed-off-by: Ayush Singh --- drivers/greybus/Kconfig | 1 + drivers/greybus/gb-beagleplay.c | 658 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 646 insertions(+), 13 deletions(-) diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig index ab81ceceb337..d485a99959cb 100644 --- a/drivers/greybus/Kconfig +++ b/drivers/greybus/Kconfig @@ -21,6 +21,7 @@ config GREYBUS_BEAGLEPLAY tristate "Greybus BeaglePlay driver" depends on SERIAL_DEV_BUS select CRC_CCITT + select FW_UPLOAD help Select this option if you have a BeaglePlay where CC1352 co-processor acts as Greybus SVC. diff --git a/drivers/greybus/gb-beagleplay.c b/drivers/greybus/gb-beagleplay.c index 33f8fad70260..3a1ade84737c 100644 --- a/drivers/greybus/gb-beagleplay.c +++ b/drivers/greybus/gb-beagleplay.c @@ -6,21 +6,19 @@ * Copyright (c) 2023 BeagleBoard.org Foundation */ -#include +#include +#include +#include +#include #include -#include -#include -#include #include -#include -#include -#include -#include -#include #include #include -#include -#include + +#define CC1352_FIRMWARE_SIZE (704 * 1024) +#define CC1352_BOOTLOADER_TIMEOUT 2000 +#define CC1352_BOOTLOADER_ACK 0xcc +#define CC1352_BOOTLOADER_NACK 0x33 #define RX_HDLC_PAYLOAD 256 #define CRC_LEN 2 @@ -57,6 +55,17 @@ * @rx_buffer_len: length of receive buffer filled. * @rx_buffer: hdlc frame receive buffer * @rx_in_esc: hdlc rx flag to indicate ESC frame + * + * @fwl: underlying firmware upload device + * @bootloader_backdoor_gpio: cc1352p7 boot gpio + * @rst_gpio: cc1352p7 reset gpio + * @flashing_mode: flag to indicate that flashing is currently in progress + * @fwl_ack_com: completion to signal an Ack/Nack + * @fwl_ack: Ack/Nack byte received + * @fwl_cmd_response_com: completion to signal a bootloader command response + * @fwl_cmd_response: bootloader command response data + * @fwl_crc32: crc32 of firmware to flash + * @fwl_reset_addr: flag to indicate if we need to send COMMAND_DOWNLOAD again */ struct gb_beagleplay { struct serdev_device *sd; @@ -72,6 +81,17 @@ struct gb_beagleplay { u16 rx_buffer_len; bool rx_in_esc; u8 rx_buffer[MAX_RX_HDLC]; + + struct fw_upload *fwl; + struct gpio_desc *bootloader_backdoor_gpio; + struct gpio_desc *rst_gpio; + bool flashing_mode; + struct completion fwl_ack_com; + u8 fwl_ack; + struct completion fwl_cmd_response_com; + u32 fwl_cmd_response; + u32 fwl_crc32; + bool fwl_reset_addr; }; /** @@ -100,6 +120,87 @@ struct hdlc_greybus_frame { u8 payload[]; } __packed; +/** + * enum cc1352_bootloader_cmd: CC1352 Bootloader Commands + * + * @COMMAND_DOWNLOAD: Prepares flash programming + * @COMMAND_GET_STATUS: Returns the status of the last command that was issued + * @COMMAND_SEND_DATA: Transfers data and programs flash + * @COMMAND_RESET: Performs a system reset + * @COMMAND_CRC32: Calculates CRC32 over a specified memory area + * @COMMAND_BANK_ERASE: Performs an erase of all of the customer-accessible + * flash sectors not protected by FCFG1 and CCFG + * writeprotect bits. + * + * CC1352 Bootloader serial bus commands + */ +enum cc1352_bootloader_cmd { + COMMAND_DOWNLOAD = 0x21, + COMMAND_GET_STATUS = 0x23, + COMMAND_SEND_DATA = 0x24, + COMMAND_RESET = 0x25, + COMMAND_CRC32 = 0x27, + COMMAND_BANK_ERASE = 0x2c, +}; + +/** + * enum cc1352_bootloader_status: CC1352 Bootloader COMMAND_GET_STATUS response + * + * @COMMAND_RET_SUCCESS: Status for successful command + * @COMMAND_RET_UNKNOWN_CMD: Status for unknown command + * @COMMAND_RET_INVALID_CMD: Status for invalid command (in other words, + * incorrect packet size) + * @COMMAND_RET_INVALID_ADR: Status for invalid input address + * @COMMAND_RET_FLASH_FAIL: Status for failing flash erase or program operation + */ +enum cc1352_bootloader_status { + COMMAND_RET_SUCCESS = 0x40, + COMMAND_RET_UNKNOWN_CMD = 0x41, + COMMAND_RET_INVALID_CMD = 0x42, + COMMAND_RET_INVALID_ADR = 0x43, + COMMAND_RET_FLASH_FAIL = 0x44, +}; + +/** + * struct cc1352_bootloader_packet: CC1352 Bootloader Request Packet + * + * @len: length of packet + optional request data + * @checksum: 8-bit checksum excluding len + * @cmd: bootloader command + */ +struct cc1352_bootloader_packet { + u8 len; + u8 checksum; + u8 cmd; +} __packed; + +#define CC1352_BOOTLOADER_PKT_MAX_SIZE \ + (U8_MAX - sizeof(struct cc1352_bootloader_packet)) + +/** + * struct cc1352_bootloader_download_cmd_data: CC1352 Bootloader COMMAND_DOWNLOAD request data + * + * @addr: address to start programming data into + * @size: size of data that will be sent + */ +struct cc1352_bootloader_download_cmd_data { + __be32 addr; + __be32 size; +} __packed; + +/** + * struct cc1352_bootloader_crc32_cmd_data: CC1352 Bootloader COMMAND_CRC32 request data + * + * @addr: address where crc32 calculation starts + * @size: number of bytes comprised by crc32 calculation + * @read_repeat: number of read repeats for each data location + */ +struct cc1352_bootloader_crc32_cmd_data { + __be32 addr; + __be32 size; + __be32 read_repeat; +} __packed; + static void hdlc_rx_greybus_frame(struct gb_beagleplay *bg, u8 *buf, u16 len) { struct hdlc_greybus_frame *gb_frame = (struct hdlc_greybus_frame *)buf; @@ -331,11 +432,135 @@ static void hdlc_deinit(struct gb_beagleplay *bg) flush_work(&bg->tx_work); } +/** + * csum8: Calculate 8-bit checksum on data + * + * @data: bytes to calculate 8-bit checksum of + * @size: number of bytes + * @base: starting value for checksum + */ +static u8 csum8(const u8 *data, size_t size, u8 base) +{ + size_t i; + u8 sum = base; + + for (i = 0; i < size; ++i) + sum += data[i]; + + return sum; +} + +static void cc1352_bootloader_send_ack(struct gb_beagleplay *bg) +{ + static const u8 ack[] = { 0x00, CC1352_BOOTLOADER_ACK }; + + serdev_device_write_buf(bg->sd, ack, sizeof(ack)); +} + +static void cc1352_bootloader_send_nack(struct gb_beagleplay *bg) +{ + static const u8 nack[] = { 0x00, CC1352_BOOTLOADER_NACK }; + + serdev_device_write_buf(bg->sd, nack, sizeof(nack)); +} + +/** + * cc1352_bootloader_pkt_rx: Process a CC1352 Bootloader Packet + * + * @bg: beagleplay greybus driver + * @data: packet buffer + * @count: packet buffer size + * + * @return: number of bytes processed + * + * Here are the steps to successfully receive a packet from cc1352 bootloader + * according to the docs: + * 1. Wait for nonzero data to be returned from the device. This is important + * as the device may send zero bytes between a sent and a received data + * packet. The first nonzero byte received is the size of the packet that is + * being received. + * 2. Read the next byte, which is the checksum for the packet. + * 3. Read the data bytes from the device. During the data phase, packet size + * minus 2 bytes is sent. + * 4. Calculate the checksum of the data bytes and verify it matches the + * checksum received in the packet. + * 5. Send an acknowledge byte or a not-acknowledge byte to the device to + * indicate the successful or unsuccessful reception of the packet. + */ +static int cc1352_bootloader_pkt_rx(struct gb_beagleplay *bg, const u8 *data, + size_t count) +{ + bool is_valid = false; + + switch (data[0]) { + /* Skip 0x00 bytes. */ + case 0x00: + return 1; + case CC1352_BOOTLOADER_ACK: + case CC1352_BOOTLOADER_NACK: + WRITE_ONCE(bg->fwl_ack, data[0]); + complete(&bg->fwl_ack_com); + return 1; + case 3: + if (count < 3) + return 0; + is_valid = data[1] == data[2]; + WRITE_ONCE(bg->fwl_cmd_response, (u32)data[2]); + break; + case 6: + if (count < 6) + return 0; + is_valid = csum8(&data[2], sizeof(__be32), 0) == data[1]; + WRITE_ONCE(bg->fwl_cmd_response, get_unaligned_be32(&data[2])); + break; + default: + return -EINVAL; + } + + if (is_valid) { + cc1352_bootloader_send_ack(bg); + complete(&bg->fwl_cmd_response_com); + } else { + dev_warn(&bg->sd->dev, + "Dropping bootloader packet with invalid checksum"); + cc1352_bootloader_send_nack(bg); + } + + return data[0]; +} + +static size_t cc1352_bootloader_rx(struct gb_beagleplay *bg, const u8 *data, + size_t count) +{ + int ret; + size_t off = 0; + + memcpy(bg->rx_buffer + bg->rx_buffer_len, data, count); + bg->rx_buffer_len += count; + + do { + ret = cc1352_bootloader_pkt_rx(bg, bg->rx_buffer + off, + bg->rx_buffer_len - off); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, ret, + "Invalid Packet"); + off += ret; + } while (ret > 0 && off < count); + + bg->rx_buffer_len -= off; + memmove(bg->rx_buffer, bg->rx_buffer + off, bg->rx_buffer_len); + + return count; +} + static size_t gb_tty_receive(struct serdev_device *sd, const u8 *data, size_t count) { struct gb_beagleplay *bg = serdev_device_get_drvdata(sd); + if (READ_ONCE(bg->flashing_mode)) + return cc1352_bootloader_rx(bg, data, count); + return hdlc_rx(bg, data, count); } @@ -343,7 +568,8 @@ static void gb_tty_wakeup(struct serdev_device *serdev) { struct gb_beagleplay *bg = serdev_device_get_drvdata(serdev); - schedule_work(&bg->tx_work); + if (!READ_ONCE(bg->flashing_mode)) + schedule_work(&bg->tx_work); } static struct serdev_device_ops gb_beagleplay_ops = { @@ -412,6 +638,195 @@ static void gb_beagleplay_stop_svc(struct gb_beagleplay *bg) hdlc_tx_frames(bg, ADDRESS_CONTROL, 0x03, &payload, 1); } +static int cc1352_bootloader_wait_for_ack(struct gb_beagleplay *bg) +{ + int ret; + + ret = wait_for_completion_timeout( + &bg->fwl_ack_com, msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, ret, + "Failed to acquire ack semaphore"); + + switch (READ_ONCE(bg->fwl_ack)) { + case CC1352_BOOTLOADER_ACK: + return 0; + case CC1352_BOOTLOADER_NACK: + return -EAGAIN; + default: + return -EINVAL; + } +} + +static int cc1352_bootloader_sync(struct gb_beagleplay *bg) +{ + static const u8 sync_bytes[] = { 0x55, 0x55 }; + + serdev_device_write_buf(bg->sd, sync_bytes, sizeof(sync_bytes)); + return cc1352_bootloader_wait_for_ack(bg); +} + +static int cc1352_bootloader_get_status(struct gb_beagleplay *bg) +{ + int ret; + static const struct cc1352_bootloader_packet pkt = { + .len = sizeof(pkt), + .checksum = COMMAND_GET_STATUS, + .cmd = COMMAND_GET_STATUS + }; + + serdev_device_write_buf(bg->sd, (const u8 *)&pkt, sizeof(pkt)); + ret = cc1352_bootloader_wait_for_ack(bg); + if (ret < 0) + return ret; + + ret = wait_for_completion_timeout( + &bg->fwl_cmd_response_com, + msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, ret, + "Failed to acquire last status semaphore"); + + switch (READ_ONCE(bg->fwl_cmd_response)) { + case COMMAND_RET_SUCCESS: + return 0; + default: + return -EINVAL; + } + + return 0; +} + +static int cc1352_bootloader_erase(struct gb_beagleplay *bg) +{ + int ret; + static const struct cc1352_bootloader_packet pkt = { + .len = sizeof(pkt), + .checksum = COMMAND_BANK_ERASE, + .cmd = COMMAND_BANK_ERASE + }; + + serdev_device_write_buf(bg->sd, (const u8 *)&pkt, sizeof(pkt)); + + ret = cc1352_bootloader_wait_for_ack(bg); + if (ret < 0) + return ret; + + return cc1352_bootloader_get_status(bg); +} + +static int cc1352_bootloader_reset(struct gb_beagleplay *bg) +{ + static const struct cc1352_bootloader_packet pkt = { + .len = sizeof(pkt), + .checksum = COMMAND_RESET, + .cmd = COMMAND_RESET + }; + + serdev_device_write_buf(bg->sd, (const u8 *)&pkt, sizeof(pkt)); + + return cc1352_bootloader_wait_for_ack(bg); +} + +/** + * cc1352_bootloader_empty_pkt: Calculate the number of empty bytes in the current packet + * + * @data: packet bytes array to check + * @size: number of bytes in array + */ +static size_t cc1352_bootloader_empty_pkt(const u8 *data, size_t size) +{ + size_t i; + + for (i = 0; i < size && data[i] == 0xff; ++i) + continue; + + return i; +} + +static int cc1352_bootloader_crc32(struct gb_beagleplay *bg, u32 *crc32) +{ + int ret; + static const struct cc1352_bootloader_crc32_cmd_data cmd_data = { + .addr = 0, .size = cpu_to_be32(704 * 1024), .read_repeat = 0 + }; + const struct cc1352_bootloader_packet pkt = { + .len = sizeof(pkt) + sizeof(cmd_data), + .checksum = csum8((const void *)&cmd_data, sizeof(cmd_data), + COMMAND_CRC32), + .cmd = COMMAND_CRC32 + }; + + serdev_device_write_buf(bg->sd, (const u8 *)&pkt, sizeof(pkt)); + serdev_device_write_buf(bg->sd, (const u8 *)&cmd_data, + sizeof(cmd_data)); + + ret = cc1352_bootloader_wait_for_ack(bg); + if (ret < 0) + return ret; + + ret = wait_for_completion_timeout( + &bg->fwl_cmd_response_com, + msecs_to_jiffies(CC1352_BOOTLOADER_TIMEOUT)); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, ret, + "Failed to acquire last status semaphore"); + + *crc32 = READ_ONCE(bg->fwl_cmd_response); + + return 0; +} + +static int cc1352_bootloader_download(struct gb_beagleplay *bg, u32 size, + u32 addr) +{ + int ret; + const struct cc1352_bootloader_download_cmd_data cmd_data = { + .addr = cpu_to_be32(addr), + .size = cpu_to_be32(size), + }; + const struct cc1352_bootloader_packet pkt = { + .len = sizeof(pkt) + sizeof(cmd_data), + .checksum = csum8((const void *)&cmd_data, sizeof(cmd_data), + COMMAND_DOWNLOAD), + .cmd = COMMAND_DOWNLOAD + }; + + serdev_device_write_buf(bg->sd, (const u8 *)&pkt, sizeof(pkt)); + serdev_device_write_buf(bg->sd, (const u8 *)&cmd_data, + sizeof(cmd_data)); + + ret = cc1352_bootloader_wait_for_ack(bg); + if (ret < 0) + return ret; + + return cc1352_bootloader_get_status(bg); +} + +static int cc1352_bootloader_send_data(struct gb_beagleplay *bg, const u8 *data, + size_t size) +{ + int ret, rem = min(size, CC1352_BOOTLOADER_PKT_MAX_SIZE); + const struct cc1352_bootloader_packet pkt = { + .len = sizeof(pkt) + rem, + .checksum = csum8(data, rem, COMMAND_SEND_DATA), + .cmd = COMMAND_SEND_DATA + }; + + serdev_device_write_buf(bg->sd, (const u8 *)&pkt, sizeof(pkt)); + serdev_device_write_buf(bg->sd, data, rem); + + ret = cc1352_bootloader_wait_for_ack(bg); + if (ret < 0) + return ret; + + ret = cc1352_bootloader_get_status(bg); + if (ret < 0) + return ret; + + return rem; +} + static void gb_greybus_deinit(struct gb_beagleplay *bg) { gb_hd_del(bg->gb_hd); @@ -442,6 +857,157 @@ static int gb_greybus_init(struct gb_beagleplay *bg) return ret; } +static enum fw_upload_err cc1352_prepare(struct fw_upload *fw_upload, + const u8 *data, u32 size) +{ + int ret; + u32 curr_crc32; + struct gb_beagleplay *bg = fw_upload->dd_handle; + + dev_info(&bg->sd->dev, "CC1352 Start Flashing..."); + + if (size != CC1352_FIRMWARE_SIZE) + return FW_UPLOAD_ERR_INVALID_SIZE; + + /* Might involve network calls */ + gb_greybus_deinit(bg); + msleep(5 * MSEC_PER_SEC); + + gb_beagleplay_stop_svc(bg); + msleep(200); + flush_work(&bg->tx_work); + + serdev_device_wait_until_sent(bg->sd, CC1352_BOOTLOADER_TIMEOUT); + + WRITE_ONCE(bg->flashing_mode, true); + + gpiod_direction_output(bg->bootloader_backdoor_gpio, 0); + gpiod_direction_output(bg->rst_gpio, 0); + msleep(200); + + gpiod_set_value(bg->rst_gpio, 1); + msleep(200); + + gpiod_set_value(bg->bootloader_backdoor_gpio, 1); + msleep(200); + + gpiod_direction_input(bg->bootloader_backdoor_gpio); + gpiod_direction_input(bg->rst_gpio); + + ret = cc1352_bootloader_sync(bg); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_HW_ERROR, + "Failed to sync"); + + ret = cc1352_bootloader_crc32(bg, &curr_crc32); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_HW_ERROR, + "Failed to fetch crc32"); + + bg->fwl_crc32 = crc32(0xffffffff, data, size) ^ 0xffffffff; + + /* Check if attempting to reflash same firmware */ + if (bg->fwl_crc32 == curr_crc32) { + dev_warn(&bg->sd->dev, "Skipping reflashing same image"); + cc1352_bootloader_reset(bg); + WRITE_ONCE(bg->flashing_mode, false); + msleep(200); + gb_greybus_init(bg); + gb_beagleplay_start_svc(bg); + return FW_UPLOAD_ERR_FW_INVALID; + } + + ret = cc1352_bootloader_erase(bg); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_HW_ERROR, + "Failed to erase"); + + bg->fwl_reset_addr = true; + + return FW_UPLOAD_ERR_NONE; +} + +static void cc1352_cleanup(struct fw_upload *fw_upload) +{ + struct gb_beagleplay *bg = fw_upload->dd_handle; + + WRITE_ONCE(bg->flashing_mode, false); +} + +static enum fw_upload_err cc1352_write(struct fw_upload *fw_upload, + const u8 *data, u32 offset, u32 size, + u32 *written) +{ + int ret; + size_t empty_bytes; + struct gb_beagleplay *bg = fw_upload->dd_handle; + + /* Skip 0xff packets. Significant performance improvement */ + empty_bytes = cc1352_bootloader_empty_pkt(data + offset, size); + if (empty_bytes >= CC1352_BOOTLOADER_PKT_MAX_SIZE) { + bg->fwl_reset_addr = true; + *written = empty_bytes; + return FW_UPLOAD_ERR_NONE; + } + + if (bg->fwl_reset_addr) { + ret = cc1352_bootloader_download(bg, size, offset); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, + FW_UPLOAD_ERR_HW_ERROR, + "Failed to send download cmd"); + + bg->fwl_reset_addr = false; + } + + ret = cc1352_bootloader_send_data(bg, data + offset, size); + if (ret < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_HW_ERROR, + "Failed to flash firmware"); + *written = ret; + + return FW_UPLOAD_ERR_NONE; +} + +static enum fw_upload_err cc1352_poll_complete(struct fw_upload *fw_upload) +{ + u32 curr_crc32; + struct gb_beagleplay *bg = fw_upload->dd_handle; + + if (cc1352_bootloader_crc32(bg, &curr_crc32) < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_HW_ERROR, + "Failed to fetch crc32"); + + if (bg->fwl_crc32 != curr_crc32) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_FW_INVALID, + "Invalid CRC32"); + + if (cc1352_bootloader_reset(bg) < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_HW_ERROR, + "Failed to reset"); + + dev_info(&bg->sd->dev, "CC1352 Flashing Successful"); + WRITE_ONCE(bg->flashing_mode, false); + msleep(200); + + if (gb_greybus_init(bg) < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_RW_ERROR, + "Failed to initialize greybus"); + + gb_beagleplay_start_svc(bg); + + return FW_UPLOAD_ERR_NONE; +} + +static void cc1352_cancel(struct fw_upload *fw_upload) +{ + struct gb_beagleplay *bg = fw_upload->dd_handle; + + dev_info(&bg->sd->dev, "CC1352 Bootloader Cancel"); + + cc1352_bootloader_reset(bg); +} + static void gb_serdev_deinit(struct gb_beagleplay *bg) { serdev_device_close(bg->sd); @@ -463,6 +1029,65 @@ static int gb_serdev_init(struct gb_beagleplay *bg) return 0; } +static const struct fw_upload_ops cc1352_bootloader_ops = { + .prepare = cc1352_prepare, + .write = cc1352_write, + .poll_complete = cc1352_poll_complete, + .cancel = cc1352_cancel, + .cleanup = cc1352_cleanup +}; + +static int gb_fw_init(struct gb_beagleplay *bg) +{ + int ret; + struct fw_upload *fwl; + struct gpio_desc *desc; + + bg->fwl = NULL; + bg->bootloader_backdoor_gpio = NULL; + bg->rst_gpio = NULL; + bg->flashing_mode = false; + bg->fwl_cmd_response = 0; + bg->fwl_ack = 0; + init_completion(&bg->fwl_ack_com); + init_completion(&bg->fwl_cmd_response_com); + + desc = devm_gpiod_get(&bg->sd->dev, "bootloader-backdoor", GPIOD_IN); + if (IS_ERR(desc)) + return PTR_ERR(desc); + bg->bootloader_backdoor_gpio = desc; + + desc = devm_gpiod_get(&bg->sd->dev, "reset", GPIOD_IN); + if (IS_ERR(desc)) { + ret = PTR_ERR(desc); + goto free_boot; + } + bg->rst_gpio = desc; + + fwl = firmware_upload_register(THIS_MODULE, &bg->sd->dev, "cc1352p7", + &cc1352_bootloader_ops, bg); + if (IS_ERR(fwl)) { + ret = PTR_ERR(fwl); + goto free_reset; + } + bg->fwl = fwl; + + return 0; + +free_reset: + devm_gpiod_put(&bg->sd->dev, bg->rst_gpio); + bg->rst_gpio = NULL; +free_boot: + devm_gpiod_put(&bg->sd->dev, bg->bootloader_backdoor_gpio); + bg->bootloader_backdoor_gpio = NULL; + return ret; +} + +static void gb_fw_deinit(struct gb_beagleplay *bg) +{ + firmware_upload_unregister(bg->fwl); +} + static int gb_beagleplay_probe(struct serdev_device *serdev) { int ret = 0; @@ -481,14 +1106,20 @@ static int gb_beagleplay_probe(struct serdev_device *serdev) if (ret) goto free_serdev; - ret = gb_greybus_init(bg); + ret = gb_fw_init(bg); if (ret) goto free_hdlc; + ret = gb_greybus_init(bg); + if (ret) + goto free_fw; + gb_beagleplay_start_svc(bg); return 0; +free_fw: + gb_fw_deinit(bg); free_hdlc: hdlc_deinit(bg); free_serdev: @@ -500,6 +1131,7 @@ static void gb_beagleplay_remove(struct serdev_device *serdev) { struct gb_beagleplay *bg = serdev_device_get_drvdata(serdev); + gb_fw_deinit(bg); gb_greybus_deinit(bg); gb_beagleplay_stop_svc(bg); hdlc_deinit(bg);