From patchwork Wed Mar 6 15:27:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chandrasekhar L X-Patchwork-Id: 10841291 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA167139A for ; Wed, 6 Mar 2019 15:28:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B20352E275 for ; Wed, 6 Mar 2019 15:28:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A56552E405; Wed, 6 Mar 2019 15:28:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 363092E275 for ; Wed, 6 Mar 2019 15:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UefdDtj8A7wGS+WcFwmnxa4wMmuq9LrHFSwXyUMsUvk=; b=TGcnJFvpEI2W9dyKBQntx1423Q 8K1KDmgzzHyF5US0ngyri8zPpS/ISE1/mxfpo+I4kCim0Uwf/RYn8Sz7q7Vj8I+MchPmkn+9r21+M U8Gfb5TX2dNi3aaORtSpmQlj1u/FUcUpRBCRvZl4DGA6fhZ3+27ODSu0VL182ccFEZnniOnBjOsx5 /RVCSxUf6Y9asWDknyrxlpTczlE3MHU/8SxI0Saqx1W7PvV4iS3vaxzIgS239kghTBI04Aw4ewyI2 2xk9tH9KssxyUeyFc+rClLs9+Ymu66qqxIwkcczJ/EzH4e3u6R4LI+VRtJG88vgUPIluQ4QcXSrat HYzObFXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1YTD-0004f5-S7; Wed, 06 Mar 2019 15:28:35 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1YTA-0004eg-JL for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 15:28:34 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8586960ACA; Wed, 6 Mar 2019 15:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551886110; bh=lr6xzu7kGN76YrY51OX5vOavA1Q3p7mxTgffMhP+ox0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=chKP8UmD7OoY32VvuonVSs6fzMfsTDljDXtZ19H5ENzRPTTWG9zUpGicTV4T9Yjzm NHaQbxDM3/KDAaZ/zp2cJMruaK5bCYlhcnScDR4KiXYCPwliE+FCw1rYs5VD3j5TwI zJTzmZX7AK2oIxtRtQ2ucz+HeTwMKJ2PDVm0ENgU= Received: from lingutla-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: clingutla@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 23CD9606AC; Wed, 6 Mar 2019 15:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551886109; bh=lr6xzu7kGN76YrY51OX5vOavA1Q3p7mxTgffMhP+ox0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mm0e27pQEdQJuqopTnGW1Bv4oOsAR7xsjC/BMwWPaIk/JrrR4GsoQTMgbSWsZQqsg daOiV/I6pRlHwGXTNe5NcP7b4o1pgfH3tCEpnAtHji79rlEA4aQK1/n7d5GAPdcDQq 1/Ig6bKBge2GYx+hvbhr/p5zC5OBLWcQN5DAbpAk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 23CD9606AC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clingutla@codeaurora.org From: Lingutla Chandrasekhar To: quentin.perret@arm.com, sudeep.holla@arm.com, dietmar.eggemann@arm.com, gregkh@linuxfoundation.org Subject: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only Date: Wed, 6 Mar 2019 20:57:53 +0530 Message-Id: <1551886073-16217-1-git-send-email-clingutla@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20190306152254.GB19434@e105550-lin.cambridge.arm.com> References: <20190306152254.GB19434@e105550-lin.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_072832_669853_735C4473 X-CRM114-Status: GOOD ( 14.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lingutla Chandrasekhar , catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, morten.rasmussen@arm.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP If user updates any cpu's cpu_capacity, then the new value is going to be applied to all its online sibling cpus. But this need not to be correct always, as sibling cpus (in ARM, same micro architecture cpus) would have different cpu_capacity with different performance characteristics. So updating the user supplied cpu_capacity to all cpu siblings is not correct. And another problem is, current code assumes that 'all cpus in a cluster or with same package_id (core_siblings), would have same cpu_capacity'. But with commit '5bdd2b3f0f8 ("arm64: topology: add support to remove cpu topology sibling masks")', when a cpu hotplugged out, the cpu information gets cleared in its sibling cpus. So user supplied cpu_capacity would be applied to only online sibling cpus at the time. After that, if any cpu hot plugged in, it would have different cpu_capacity than its siblings, which breaks the above assumption. So instead of mucking around the core sibling mask for user supplied value, use device-tree to set cpu capacity. And make the cpu_capacity node as read-only to know the assymetry between cpus in the system. Signed-off-by: Lingutla Chandrasekhar Acked-by: Sudeep Holla Tested-by: Dietmar Eggemann --- drivers/base/arch_topology.c | 33 +-------------------------------- 1 file changed, 1 insertion(+), 32 deletions(-) diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c index edfcf8d..d455897 100644 --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -7,7 +7,6 @@ */ #include -#include #include #include #include @@ -51,37 +50,7 @@ static ssize_t cpu_capacity_show(struct device *dev, static void update_topology_flags_workfn(struct work_struct *work); static DECLARE_WORK(update_topology_flags_work, update_topology_flags_workfn); -static ssize_t cpu_capacity_store(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t count) -{ - struct cpu *cpu = container_of(dev, struct cpu, dev); - int this_cpu = cpu->dev.id; - int i; - unsigned long new_capacity; - ssize_t ret; - - if (!count) - return 0; - - ret = kstrtoul(buf, 0, &new_capacity); - if (ret) - return ret; - if (new_capacity > SCHED_CAPACITY_SCALE) - return -EINVAL; - - mutex_lock(&cpu_scale_mutex); - for_each_cpu(i, &cpu_topology[this_cpu].core_sibling) - topology_set_cpu_scale(i, new_capacity); - mutex_unlock(&cpu_scale_mutex); - - schedule_work(&update_topology_flags_work); - - return count; -} - -static DEVICE_ATTR_RW(cpu_capacity); +static DEVICE_ATTR_RO(cpu_capacity); static int register_cpu_capacity_sysctl(void) {