From patchwork Mon Sep 2 14:18:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diogo Manuel Pais Silva X-Patchwork-Id: 13787358 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C55BCA0ED3 for ; Mon, 2 Sep 2024 14:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eBbwr8sUp6TVZt2DGhYafTV/Eo+QUMDygu3bpu04Rt4=; b=SuWflI4Px24X1A45OYrIOTjsOA DiMuuKaB/9+Lfrv3r5/1dt0BQCfTLU64K5O6DGRrI4k9wlIQpWpxFUJahLetBOep2zX/P8aHsVRFw U3vhUDjxX6RDkS65S6C2YbAnIL3L9k6dv0wNiWNoAZrR4k9gsA2t9lnzBNDLNmQvMAxp5z56q/oTk txsLUPRyQOdapKMvuXfh9xTA/TmSS3B1wXRO00+s/w1t/EtOoLwHmR0itIR5P33vjzvcr4smrHhnv djBGfdqNPVmKUNQL1jVY+54LxlUlri2/hoEksd4F1cheCkVh/RM/btxNy79PkZwrV3zGvnBGcjMNA vA84Mj8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl7u1-0000000EdRG-2Ynm; Mon, 02 Sep 2024 14:19:33 +0000 Received: from mx08-0061a602.pphosted.com ([205.220.185.213]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl7t6-0000000EdC5-1GZV for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 14:18:38 +0000 Received: from pps.filterd (m0278994.ppops.net [127.0.0.1]) by mx07-0061a602.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 482DWkAH016046; Mon, 2 Sep 2024 14:18:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttcontrol.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= s2021; bh=eBbwr8sUp6TVZt2DGhYafTV/Eo+QUMDygu3bpu04Rt4=; b=BnBo/M CDGbH/k1VP26c5r6T2Atrosumz0cQtVQjlp0Y37MJfK5NuDQIJ5fBonMwwrgog8g B4paqPgiM6lF9Xsw2HgJTnh5XXiDY+UARpRLF3woZk/y1kgXjTdjv38GmTg4Mfq/ yvhqdwHjU/KD2QrH+xgMeutNCdxvzfYQKOmwKr1jeyDzasgR/rzg+GyrTZnkf2g8 i6Du/L1ARvFQEOZEONqa7d9DZ/wVKEP4el9w+0hdlbu7gLaBpmRED1OeYqU6cc7x N6Gu1foRQR5oSI+3M1jfU+pMUlo3Pr0TtOixSU0dV67/kAFQKYsyrLDEQgfd9G9q F2zl6i/N1/RBayag== Received: from db3pr0202cu003.outbound.protection.outlook.com (mail-northeuropeazlp17011022.outbound.protection.outlook.com [40.93.64.22]) by mx07-0061a602.pphosted.com (PPS) with ESMTPS id 41brd0252v-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2024 14:18:13 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P8e/pKU+Si4J4zFuIW0stKZfhmPk2Re3C7UX7mNnHBU+gYGRLVY1Gwk1sKnCmHsui+9Nh78fDYaeziUgH8mN6Zdl56uAmM5O6lWf9cTk8oeKeWMg2bUTNHu4oU/X7gLHRrtJTQr1pl7YGeQ/PVke4UtfAaeJvt+RVcHWlrjOBz0QlhG3ZGh84S+zOeM5EPhkIZxuCgYyv+ol73NHeM5t8Xsf/QKMkyM6AJY5MDHA110pff6bfXgh5+tenggAPNNAK+fvGEoOvdeD1O1k3yf0HlSVqCuwfuQD4O/44I54c82tH/ZHUgPzLuQX+Wx6JpMV1KdjCrsSaUJP9Oik+8lrSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eBbwr8sUp6TVZt2DGhYafTV/Eo+QUMDygu3bpu04Rt4=; b=W5AbG/vpKyyENJGGYBN3HV/IFuko0tLIZT1oYXmdZfrgMB5zHHsyBEEuLtZVCDt0lLkaoRIExHl7qPuYh8400r3tZzVkWrWMeLP2xfEA1jgACtwPkv0v/BOBUAynmE7DGUpF5x2aaPIjpgq+yklfwjN/7QLSvXse+y5y3+zFnpRt2vPz6epWchyekzXpGc1AAq61qnwf7PyvAPEO6Nhye+MPwXn+u4QYKB98ujoz9+dljTW294igOjhMXYNIH+1je9mYrcGgeizii3TmyJu+RZlzuv378Rz8rIJgn6zc6QMxDy6UYIjTegNJssK0fVFjQ7OsCimzk2eTmycMONzeRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ttcontrol.com; dmarc=pass action=none header.from=ttcontrol.com; dkim=pass header.d=ttcontrol.com; arc=none Received: from DU0PR01MB9382.eurprd01.prod.exchangelabs.com (2603:10a6:10:32d::6) by AM7PR01MB6675.eurprd01.prod.exchangelabs.com (2603:10a6:20b:1a7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.25; Mon, 2 Sep 2024 14:18:10 +0000 Received: from DU0PR01MB9382.eurprd01.prod.exchangelabs.com ([fe80::c41d:dc9b:3f97:1ae1]) by DU0PR01MB9382.eurprd01.prod.exchangelabs.com ([fe80::c41d:dc9b:3f97:1ae1%7]) with mapi id 15.20.7918.024; Mon, 2 Sep 2024 14:18:10 +0000 From: Diogo Manuel Pais Silva To: Abel Vesa CC: Peng Fan , "abelvesa@kernel.org" , "linux-clk@vger.kernel.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "sboyd@kernel.org" , "mturquette@baylibre.com" , "festevam@gmail.com" , "imx@lists.linux.dev" , "EMC: linux-kernel@vger.kernel.org" Subject: [PATCH v3] clk: imx8qxp: Defer instead of failing probe Thread-Topic: [PATCH v3] clk: imx8qxp: Defer instead of failing probe Thread-Index: AQHa/ULwBX4QDqA/8Ua7zDhzNMik3g== Date: Mon, 2 Sep 2024 14:18:10 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6d12e765-bdb3-4a42-8d1e-507ff5c9fe67_Enabled=True;MSIP_Label_6d12e765-bdb3-4a42-8d1e-507ff5c9fe67_SiteId=5638dc0c-ffa2-418f-8078-70f739ff781f;MSIP_Label_6d12e765-bdb3-4a42-8d1e-507ff5c9fe67_SetDate=2024-09-02T14:18:09.837Z;MSIP_Label_6d12e765-bdb3-4a42-8d1e-507ff5c9fe67_Name=TTControl - Public;MSIP_Label_6d12e765-bdb3-4a42-8d1e-507ff5c9fe67_ContentBits=0;MSIP_Label_6d12e765-bdb3-4a42-8d1e-507ff5c9fe67_Method=Privileged; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DU0PR01MB9382:EE_|AM7PR01MB6675:EE_ x-ms-office365-filtering-correlation-id: da2f63ff-360f-429d-ed97-08dccb5a12b3 x-ld-processed: 5638dc0c-ffa2-418f-8078-70f739ff781f,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?q?s0wNOuSlY3ezp8zlsVF++0JMGw?= =?iso-8859-1?q?3l3Mq3Her3PWqqfFrScs3Zm9tivlS39ccmUHPSvOMHpKeUzctlmKoWO11MbN?= =?iso-8859-1?q?596lBHb1inA9dKggdJojpkpAwMOxmFQUYd0byz6qbH80deT844UI3DLJZcZv?= =?iso-8859-1?q?QEiqwSKLdPR52IYJLY+sqKFzq0cylA9K6JsNBCRImlPSu6hyQYWqa83m+uny?= =?iso-8859-1?q?BMiyqcX6ELBU254miPZxtMdJ8aR1fE88Oz2fmrKpHHvq+4qFH5+/zzBANUZK?= =?iso-8859-1?q?VV7M6qWicAgO0UlNlLw3ovRR5GxgfucDb3hj/5Jlgr0RqXxWet1j2BgcynvH?= =?iso-8859-1?q?nKkVjeOgoI3s1gIhoS8iOTRkvpvy5yMklgM4doJlMd+N+4rQ7Ru93+GhUJcI?= =?iso-8859-1?q?dpm7U/KbgyGO5SweCko3T+peGNEmUcN0nFBZf0oxM0/YDDudJp8anKwWPjnn?= =?iso-8859-1?q?9k4IJeEiVDEPhFspMIdjOx2mzyVeYaashynre0YVyElINC7U8NOhE8qoHQYH?= =?iso-8859-1?q?BQrdsQombyLnbcxcZg0/nzGZ+O96iPRjc7MI+uSmJeICAj9Jd4Ka3x4DV8V/?= =?iso-8859-1?q?Qi+iWzde1PsLrg+8r6W9fLRdq0NsF9OwaGx/s9DkKEOGO9sA7R41TBP3yvop?= =?iso-8859-1?q?NUtw0KAVb8/lkc/VUQuBrM7bStd9Gz3Si8GXwY1mtLCq933PiVxm3cpCAeiQ?= =?iso-8859-1?q?5AWE+J1l0SnezCgNmCeKJDIEZzrLWmjDHuuHJvL92hlapGYiHjZRZ8vfP1At?= =?iso-8859-1?q?DWYNXzFML+x7tZuG0Ra3o+1Ti0KYkpA5xvP3ER4e/CtbqZlDbNntoctIIDei?= =?iso-8859-1?q?wQdKn/JTwLA/6v5o4yyFH387PiWEwAPcZruS4fWI+fKiBu6N7DxtlXqnXXaW?= =?iso-8859-1?q?uPetQgAgsdPmq4DeeZBXH0zTd8/m+UWhMPFbw59gKWFQ+XxwSsZf3jX8rtif?= =?iso-8859-1?q?tF/gKX2c32mffLqWrMl8A0exIXk1+XiJB6YZ+BU9Nvxv8yhfjvzzLuSMhSqO?= =?iso-8859-1?q?w3lDdrZasC0Px09tYBLPZiVzeWx+o/qLN0k0xDxTX3Rf2wjKOBcnVBMD4bBR?= =?iso-8859-1?q?xUFmnKKesvLjxKw9RALJ/V6D2jjmJxN3Dg/Csb34ymwks8JzfJehLJV/WRv4?= =?iso-8859-1?q?sJL5VujJ19+4hdPNMeie6HFjxgNsKzUZUGk5u/1s9Vt3RX/Yo5LpfdrDT8+r?= =?iso-8859-1?q?frChMs/6gjRYW7PQZ/fRRTWiVR2Vr+wucxngXp/Tlzje6CyTevoMmosAaUSL?= =?iso-8859-1?q?1ZN+lZ6zG304+gbvvJFBy1bKQOPBsjSpaS8hb0yA5oNJlwnry2JIHL1n+GcA?= =?iso-8859-1?q?MNWUfptz7HQjGyJ6VX+3D0qyo7iNejVbeUVxCEe/+HRUEjdPAzd2ayl0fUvX?= =?iso-8859-1?q?5jDAGWDtMzVMCOV1+c7YzZFXLTMTU7VdrTlnAtWIP0F0baCS3vCMOwFF0XOc?= =?iso-8859-1?q?imhg1EgW1hpSfdtY2ZyDqN1w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR01MB9382.eurprd01.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(38070700018);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?ye8jV0BCoTK22Xd8J/mkE8z?= =?iso-8859-1?q?A8qWBi8CB143BP27pAZjOg2QqelpR4wLES93AQSjErQ/qqT81yIcPW6DmdMh?= =?iso-8859-1?q?PVblSaKvPmyA3TRkeCcLTYB+afls0tvMUOSGE3AwEpfGELdsdmZfyz0JT4b4?= =?iso-8859-1?q?MUzKNn+dB2AaQ89nydbPvdmn2fU1LSV1ocbmo0Uqk7xvS76/MI1WBLa/9wj1?= =?iso-8859-1?q?ga56HOom9spR4PCsMEarbuiN95v7NkMCb41B1NJwgaAvRGhP/cwN7jILPJLG?= =?iso-8859-1?q?V+KYK2EQjuGF2QYNRfDhrXxlWEyyL/Wb/c6li2/yy+jfuv+KPAod55ygBysA?= =?iso-8859-1?q?m7FNCh+CJjIa9sQ8a8FNY3o8e8nXf6IPbkgsrbXCocg3A6Fh8U+Iip6ifLrZ?= =?iso-8859-1?q?7iAkuvQR9Y7m9oiT8z2bm8S2rB37cT9HXH9hH42HLP2vh9pFN+hZB3a8Fswk?= =?iso-8859-1?q?FBBZ8rIQX3IUqiiZIK2w8hGuO52FPF15H4fgkE/nF7CyomLi71SrbhYpgnnF?= =?iso-8859-1?q?3NOlkKXnWCpxvsaaVeYSC1uuuZJ8luvMs0+pw/So0daMi5J1++Ey32hXTIhk?= =?iso-8859-1?q?JkpjVwrUIuqeu7YyyyfaCqiqda7FUYCGXKFmq6CyhygIxujoPjntiR7cTI5+?= =?iso-8859-1?q?HT7vnZOfXPIRmtAIXXAEY0680ZkcmFxzEfAjemTpZMA6N4tDDC8AZ/uyYESV?= =?iso-8859-1?q?OW2KhHfiX4acvVuq6s5upSkT4Rv7J/T/caZ9sqOC94j0y+t4c84+pxJE0CHl?= =?iso-8859-1?q?uRBti8HAlleHj3jW9PjHCzSash4xw4tpz9IuA6aKG4wkWjayeu9njbP355G7?= =?iso-8859-1?q?tQm3bBco8a6eG5fxKwmGYWeMhGLuFmLxBWXiCh5Hm7heeQm6DLfka+BH96pc?= =?iso-8859-1?q?ua6QFvJ1/oHncVKeGwGxaDQoq0u4sw5hjhG8xXUK9wGXuutKBPf1q1+9uUOf?= =?iso-8859-1?q?ACfDoOERQ/5OFQjWngLTPV8eVOeBscG5I8ehYFdahNK/Cgz2D8fvJKaDmyf9?= =?iso-8859-1?q?B2qGlv8HC1ra2y0IUbvnep2KULOVKhyvSH9her8uE42BQD70gMWTuA6Nf0pB?= =?iso-8859-1?q?YdTm+u45NHThxUs1B+lA0SJ78QTQkkNT82abUMmygmPksIpGWi1RSQfxpx+f?= =?iso-8859-1?q?yGeEi/v+3P+ly6oof1Q3K+hi0l8Slvz/9SBs6vl+OuRtkw11i7JGM6Nv9DGf?= =?iso-8859-1?q?CYPrzpvnt1QykqG03N5b0uUhXopGMnTcORgWbs+b9zGmHIRHuoUJqgYWxrtF?= =?iso-8859-1?q?/UVHYbGyNoWTwK65kxlzQavJx3nLEVeKFhm6S1M7iMJGoC3L6iTJ8tI6UjWL?= =?iso-8859-1?q?QZQjalbuytDM4biJhocXqJskDqxuzNMoCtX8vIQZxx2S9CMT1VOVmQ03gI6+?= =?iso-8859-1?q?nUB6KPJBq2+i36/QHNtA2BBNdzM1Jb7qmnUN1keMbntYjULQSrmDgpciPdle?= =?iso-8859-1?q?bgajctZB2bY90dl94eCrUeZEwrWPQ7z9ZMGy19/G9apB6T/cB/Wh2bkcph4I?= =?iso-8859-1?q?/Hakk4DfRRlBKSvnj00fi/54uyq1ROR0Th3uBV3lTbgxdBnl4dyY5AO41fjl?= =?iso-8859-1?q?hqm/5Bqo8fUg93lTbaF2fTZiPxOgMKh518x8u+Cp/2bKg4iCNADNSHCm16rR?= =?iso-8859-1?q?mmk3IRaGxWNdT6z+Y?= MIME-Version: 1.0 X-OriginatorOrg: ttcontrol.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU0PR01MB9382.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: da2f63ff-360f-429d-ed97-08dccb5a12b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2024 14:18:10.1004 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5638dc0c-ffa2-418f-8078-70f739ff781f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cSH9XGCPg8co14RXQz3+j6QbVYd7jL6AW9YaMq90zaIyBqkvwBYKvPbcTcj6iqGaDvweyqg1mCa72V7GvzKE0VD+dBdL+bg8DM2JF0Bdwys= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR01MB6675 X-Authority-Analysis: v=2.4 cv=C4i7yhP+ c=1 sm=1 tr=0 ts=66d5c925 cx=c_pps a=thxcoxaKSrYYC4Q79zeVCQ==:117 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=EaEq8P2WXUwA:10 a=9E89HhfwiosA:10 a=EZQmGfNXMHUA:10 a=nxb4IF0AAAAA:8 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=JfrnYn6hAAAA:8 a=IpJZQVW2AAAA:8 a=pGLkceISAAAA:8 a=rsmfmBjOAAAA:8 a=gwMhcH0e1l1swrN3wTsA:9 a=wPNLvfGTeEIA:10 a=muotpCzfy8uUhEcWaHt4:22 a=cvBusfyB2V15izCimMoJ:22 a=1CNFftbPRP8L7MoqJWF3:22 a=IawgGOuG5U0WyFbmm1f5:22 a=5SoQ0aNoiOvKt2feW1sf:22 X-Proofpoint-ORIG-GUID: PFHpBhMnNeD1ssGO8qq8bFEvvozN4oyJ X-Proofpoint-GUID: PFHpBhMnNeD1ssGO8qq8bFEvvozN4oyJ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_071836_967291_5E4C9556 X-CRM114-Status: GOOD ( 24.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When of_clk_parent_fill is ran without all the parent clocks having been probed then the probe function will return -EINVAL, making it so that the probe isn't attempted again. As fw_devlink is on by default this does not usually happen, but if fw_devlink is disabled then it is very possible that the parent clock will be probed after the lpcg first attempt. Signed-off-by: Diogo Silva --- v2: change from dev_warn to dev_err_probe v3: refresh patch --- drivers/clk/imx/clk-imx8qxp-lpcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c index d0ccaa040225..cae8f6060fe8 100644 --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c @@ -225,8 +225,8 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev, ret = of_clk_parent_fill(np, parent_names, count); if (ret != count) { - dev_err(&pdev->dev, "failed to get clock parent names\n"); - return count; + return dev_err_probe(&pdev->dev, -EPROBE_DEFER, + "failed to get all clock parent names\n"); } ret = of_property_read_string_array(np, "clock-output-names",