From patchwork Thu Mar 7 03:05:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10842195 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C46514DE for ; Thu, 7 Mar 2019 03:05:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25DC32EADF for ; Thu, 7 Mar 2019 03:05:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 196E32EAFD; Thu, 7 Mar 2019 03:05:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9ADA02EADF for ; Thu, 7 Mar 2019 03:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=g+HbRJoMjmUhrBVRZB8Q0C2OlwE3WLdh/RJ4UB1zWNc=; b=mqIvtuctKAGb9a FIvhPClkVBm9YR1sLGAOZ59X/WS3ibYcbKBNhB0282jMmXYyEPtMSMfBy+xWcamSOw2RCoOtP0gaG 9uW3oJD0PDXd0hwA7/Vmcd5GmaR4TXG7ZHEUyiGltcSYK32ZrUwBII4tEeymOLoUAUw/E9wjSFAvq d1tpPW1SmuP6Prif9D1JRyMZvSk/LA21hDrM91D5pEINR9M2t+bOuwUzkTcurn8hAV7d33dxHvfVq GU1PvGyTCc0gcsmngxGPAFYNqJNRWTuDmJ6Zi775kWV71w5DnflaimweCFX4MxFCla2qNI96YLini eZD/WV/bhec+SKlEaXfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1jLn-0006e7-Gv; Thu, 07 Mar 2019 03:05:39 +0000 Received: from mail-vi1eur04on060f.outbound.protection.outlook.com ([2a01:111:f400:fe0e::60f] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1jLj-0006df-P9 for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2019 03:05:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FiP2ezLpK6XSAsSiO5xQTjX6RmA2nf5oesAjR+S+NHg=; b=GdYw36Hvk2dOh6WEz8kKgPB96zx4N3j8zEYmUkQkNUg0UVk0HldXikEoGybtCGvRk8wUrFJwV8qPuW7PKsLQdSmHvYA/ZHgSy3KQPLfq5WLreelgO81iOlw4pLcQNRMxVqibRAnTRCKFW2HJzJIFz4N8k62WPKPQu3WzXs2mWLA= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB6354.eurprd04.prod.outlook.com (10.255.182.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Thu, 7 Mar 2019 03:05:30 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.018; Thu, 7 Mar 2019 03:05:30 +0000 From: Aisheng Dong To: "linux-gpio@vger.kernel.org" Subject: [PATCH 1/1] pinctrl: imx: fix scu link errors Thread-Topic: [PATCH 1/1] pinctrl: imx: fix scu link errors Thread-Index: AQHU1JKfgJI3MldPOkKmW1rMKvamuA== Date: Thu, 7 Mar 2019 03:05:30 +0000 Message-ID: <1551927501-14527-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK2PR03CA0044.apcprd03.prod.outlook.com (2603:1096:202:17::14) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 18a354e6-e520-40cf-5f7a-08d6a2a9c1ba x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB6354; x-ms-traffictypediagnostic: AM0PR04MB6354: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB6354; 23:UJa5tLEHyqCN8tKCpbAyi9+znmjHyg5Q5GV0+HY?= =?iso-8859-1?q?SuAFP6vt8EQBbxV?= =?iso-8859-1?q?WUgwmpS+Q72h5Icg/l+h0zVns+geoV3jZmJzk6y+RxB4UiQifMbPP+2o5/Gy?= =?iso-8859-1?q?qwhNn6I538WIynp7yfb+p89AhZjv4jNRe6NMFZhReKHRdnQ9EV8m3NlABpMH?= =?iso-8859-1?q?+bV2B16XyKJ/3NpynbWsKcc5mdnSjrSA3aT8EvC5ZINjQeugvcAhmQy/YYQy?= =?iso-8859-1?q?II7lD2Ha/SV4Xl71jlwuIzVAihxuZOJ5uA1Uc8VV5YfihRTJE1jlI17WEib1?= =?iso-8859-1?q?zc+GlYOU/qv4rC7dpug4dFVKgt3ao4riF/c43n07BPsns8e5lF38zWEjcJ4Q?= =?iso-8859-1?q?WuXKKABj/7yXAlrIQEidg1xpsaeutHxc39ibX1QkGuBEOJo+1a1dkTFZ9ZSY?= =?iso-8859-1?q?bGeYKFgL9ps1n2Veoe5y0WzStcRlpVCBLWin9srZUaLHNJct20eiEOp10dsK?= =?iso-8859-1?q?oozJTTVlxhNXPJbvGCVqW68610ABpn3NVkdswkgfZ9VL/k+OWCg2usYVxh2I?= =?iso-8859-1?q?PYs5bhVlvKYSbQ3vUq3EOtCjiDvCBFtdwrxLGkmLUerf1N5Pg6lDzhBA6p7v?= =?iso-8859-1?q?UKqZfG/lQunOtyOr5yPZalSiAg2x3fAdBsa7r1qBuqF0cyVZpr8pnED4+2XM?= =?iso-8859-1?q?SRBCSiwK4dwYTzeCwB31tibyQ67zdxxlfpfixzASv9NiHNSDMbP4tEYRzkGY?= =?iso-8859-1?q?brN9KFnM4s6eMUaREXRH16Ma3ZvXkfjGqAMtZNyavB6ft7xxYROJD1lRWzzL?= =?iso-8859-1?q?EXOiRvVWtkqZmp/ah3HB7U+8msk5TPmJRBF9Y10Lbfkv1dT989aPC3yk7kKv?= =?iso-8859-1?q?gC+NS+uPT7JRGpUO6L7lYzQjgx6tWkhidV70+y7MPT4TTw58cPc/cUiwGiUj?= =?iso-8859-1?q?XFIdQxVuMzgF2CqRlfdp1eSuVCaGu1MbIWofiX6aPlvHUDq2eSH/+tG7xoo3?= =?iso-8859-1?q?5RT0VuNm9SNE3nEnuX1eGIkBDqsaVvjSziprNeU6q5j5Tizar9Dwpin9Iz0F?= =?iso-8859-1?q?baouUGCr/lCZ77Fg42gJgz7h3VYrj9JivZV3wGTwuKmQRdA5QIuaLWum3XTO?= =?iso-8859-1?q?p/8b84LIOs1WdQXvgFneaDF5o88uDThUy45zP8/PrBpQTw5fyThnmQri4qD9?= =?iso-8859-1?q?EvZ+tSOZ3DSHrT4XHMeliimiDTu739KbTFXN0uMuN3xx6jfdGnMap26NIOuP?= =?iso-8859-1?q?UIl3IvNm++aMGmfDZyEkwd?= x-microsoft-antispam-prvs: x-forefront-prvs: 096943F07A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(136003)(366004)(346002)(39860400002)(199004)(189003)(478600001)(53936002)(186003)(68736007)(7736002)(36756003)(97736004)(386003)(2616005)(8676002)(256004)(105586002)(81166006)(81156014)(6512007)(6506007)(2351001)(6436002)(476003)(106356001)(50226002)(99286004)(71190400001)(71200400001)(5660300002)(25786009)(52116002)(2906002)(44832011)(6486002)(316002)(486006)(26005)(54906003)(6916009)(6116002)(3846002)(86362001)(14454004)(8936002)(305945005)(4326008)(5640700003)(102836004)(2501003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB6354; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5cL4AjIURlyN7DHtNlXnfIOnli/6duF2qXVhQswVs70Qt+6dqq2zfOzbRFlRTfuyZmHJzyZEKQR+hdpDYait3XocdTrf4DhylvfC3P1q9oBpg/RtJi5QH6pktesaYeee7s6x6TwzQV7FOcS19GosgDgMwQ6rA5PpXearUm92N1qvm41Ym+RbXdAJBjJpkP00eWcHhiFrR1lJ0ijx8RNE8tOa8AEITx2gU/jnOF0be9NXiKSuIV9upDMW37oZ89OkScZqb3c53LfB0Rt34xHtOroD+8B+YTjLt1kn3ONCS2pcuCeAoo7//O3tXnpmNDSgfYSMBuXSUGVioYwQQDeLDvRnlS8o3PmSK8aMUdQr/4r/966AGD5Fp0KVcF8oTQwi6nyD5xtIOZiaUmAClwU9jdQKKHbv0z53rehwBUGgsOg= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18a354e6-e520-40cf-5f7a-08d6a2a9c1ba X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2019 03:05:30.4994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6354 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_190535_868043_8B3E1B30 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Anders Roxell , "dongas86@gmail.com" , "arnd@arndb.de" , "linus.walleij@linaro.org" , "stefan@agner.ch" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Anders Roxell Currently PINCTRL_IMX8QM and PINCTRL_IMX8QXP will select PINCTRL_IMX_SCU. However, PINCTRL_IMX_SCU may not be valid due to it depends on IMX_MBOX. Then we may meet the following link errors: ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': pinctrl-scu.c:(.text+0xa0): undefined reference to `imx_scu_call_rpc' ld: pinctrl-scu.c:(.text+0xa0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': pinctrl-scu.c:(.text+0x1b4): undefined reference to `imx_scu_call_rpc' ld: pinctrl-scu.c:(.text+0x1b4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' ld: drivers/pinctrl/freescale/pinctrl-imx8qxp.o: in function `imx8qxp_pinctrl_probe': pinctrl-imx8qxp.c:(.text+0x28): undefined reference to `imx_pinctrl_probe' ld: pinctrl-imx8qxp.c:(.text+0x28): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_pinctrl_probe' Rework so that PINCTRL_IMX8QM and PINCTRL_IMX8QXP depends on IMX_SCU as well in case they're wrongly enabled. Suggested-by: Arnd Bergmann Signed-off-by: Anders Roxell Signed-off-by: Dong Aisheng --- drivers/pinctrl/freescale/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig index e6dff31..0d83878 100644 --- a/drivers/pinctrl/freescale/Kconfig +++ b/drivers/pinctrl/freescale/Kconfig @@ -138,14 +138,14 @@ config PINCTRL_IMX8MQ config PINCTRL_IMX8QM bool "IMX8QM pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qm pinctrl driver config PINCTRL_IMX8QXP bool "IMX8QXP pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qxp pinctrl driver