From patchwork Tue Sep 10 17:49:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 13799132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB1FFEDE9AB for ; Tue, 10 Sep 2024 17:49:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9379910E8BC; Tue, 10 Sep 2024 17:49:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="dWS5sdF5"; dkim-atps=neutral Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id B777010E8BA for ; Tue, 10 Sep 2024 17:49:09 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-718d8d6af8fso3758616b3a.3 for ; Tue, 10 Sep 2024 10:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725990549; x=1726595349; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XjTGqVxL/lXZ4Xq5oA9wMyb/w66vC8I8vd+hq2N9dLc=; b=dWS5sdF5ca9raTM50E7V7ZPq6NaM0ApM1R6VkIOztUmynFwOSQ+/bdk6uIzBFPRTUf GG2a9gEaopT4O5PS39tD2Pla1XH5cP5WxanynOJNgxCnpHVYl4fqnstmJ4LCPeqAdO9Q kNwCcoBQbtKoqrfZpMFD+v9q9NCNMFQy2N4PY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725990549; x=1726595349; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XjTGqVxL/lXZ4Xq5oA9wMyb/w66vC8I8vd+hq2N9dLc=; b=mzlf93Ad2R1EF+tFiy/sRjgaFbEMPw9eZBkYIix0bl0WkgQPH+5svVvetjQM3Co6Mo mLpnc9jCQoFh0aeeGta5bdE66jeLAn1WFUGHy2ZHFt4L8LCtLMVjnI6AX/sz7eMtVSWo PzzhyweJFrCJ9ANdJbxi+yIY7gwxCbALS5wrC5oYzYpYHCTikSpW5Uq6zv133Ql2biV7 17KzZSNWl3ZheGweHxyvdW7q1J1mmFElU31FzQJeufly5uBog+DedNGuYGroDh6XvqVP unIdhDr6NplWIQzqkap0tBGrQgYi++EegdRcN5zKjN1fIbYED008fNb9Qzk02+5teYd4 rcxw== X-Forwarded-Encrypted: i=1; AJvYcCXOMWy+/PxmIrdpN9d0VAEDTHirrl0GvjbxLLVJprksdi5BSAVSnENiEVMkRRPjhbzvYuJ4yPITa10=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyoPBlfQ36LyGaLY6TCzMoCm8Z4OLHPynej8mT4abLWJH2BI3F2 BisghTe4uVcPM8oPfYhGz+8gPmHP6taWydZq4xEdDZvxKlNXvo2rhGj01h6eRw== X-Google-Smtp-Source: AGHT+IH7ewLbjt6vpK16Q9MSvs4t2UHHLsqVCiuJv68f8tihw1AECgjvOqgbtRKJbxklGND7j0FnJg== X-Received: by 2002:a05:6a21:6481:b0:1cf:37bd:b553 with SMTP id adf61e73a8af0-1cf5e1ab920mr1717836637.46.1725990549167; Tue, 10 Sep 2024 10:49:09 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:a9f8:b780:a61c:6acb]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-20710f3229esm51179035ad.268.2024.09.10.10.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 10:49:08 -0700 (PDT) Date: Tue, 10 Sep 2024 10:49:06 -0700 From: Brian Norris To: Borislav Petkov Cc: Hugues Bruant , stable@vger.kernel.org, regressions@lists.linux.dev, linux-kernel@vger.kernel.org, Fenghua Yu , Reinette Chatre , Tony Luck , Tzung-Bi Shih , Julius Werner , chrome-platform@lists.linux.dev, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [NOT A REGRESSION] firmware: framebuffer-coreboot: duplicate device name "simple-framebuffer.0" Message-ID: References: <20240909080200.GAZt6reI9c98c9S_Xc@fat_crate.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240909080200.GAZt6reI9c98c9S_Xc@fat_crate.local> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" (Tweaking subject; this indeed isn't related to the regression at all) Hi, On Mon, Sep 09, 2024 at 10:02:00AM +0200, Borislav Petkov wrote: > Looking at your log, the first warn is in framebuffer_coreboot. Some mess in > the sysfs platform devices registration. > > Adding the relevant people for that: > > Aug 20 20:29:36 luna kernel: sysfs: cannot create duplicate filename '/bus/platform/devices/simple-framebuffer.0' > Aug 20 20:29:36 luna kernel: CPU: 5 PID: 571 Comm: (udev-worker) Tainted: G OE 6.10.6-arch1-1 #1 703d152c24f1971e36f16e505405e456fc9e23f8 > Aug 20 20:29:36 luna kernel: Hardware name: Purism Librem 14/Librem 14, BIOS 4.14-Purism-1 06/18/2021 > Aug 20 20:29:36 luna kernel: Call Trace: > Aug 20 20:29:36 luna kernel: > Aug 20 20:29:36 luna kernel: dump_stack_lvl+0x5d/0x80 > Aug 20 20:29:36 luna kernel: sysfs_warn_dup.cold+0x17/0x23 > Aug 20 20:29:36 luna kernel: sysfs_do_create_link_sd+0xcf/0xe0 > Aug 20 20:29:36 luna kernel: bus_add_device+0x6b/0x130 > Aug 20 20:29:36 luna kernel: device_add+0x3b3/0x870 > Aug 20 20:29:36 luna kernel: platform_device_add+0xed/0x250 > Aug 20 20:29:36 luna kernel: platform_device_register_full+0xbb/0x140 > Aug 20 20:29:36 luna kernel: platform_device_register_resndata.constprop.0+0x54/0x80 [framebuffer_coreboot a587d2fc243ebaa0205c3badd33442a004d284e0] > Aug 20 20:29:36 luna kernel: framebuffer_probe+0x165/0x1b0 [framebuffer_coreboot a587d2fc243ebaa0205c3badd33442a004d284e0] > Aug 20 20:29:36 luna kernel: really_probe+0xdb/0x340 > Aug 20 20:29:36 luna kernel: ? pm_runtime_barrier+0x54/0x90 > Aug 20 20:29:36 luna kernel: ? __pfx___driver_attach+0x10/0x10 > Aug 20 20:29:36 luna kernel: __driver_probe_device+0x78/0x110 > Aug 20 20:29:36 luna kernel: driver_probe_device+0x1f/0xa0 > Aug 20 20:29:36 luna kernel: __driver_attach+0xba/0x1c0 > Aug 20 20:29:36 luna kernel: bus_for_each_dev+0x8c/0xe0 > Aug 20 20:29:36 luna kernel: bus_add_driver+0x112/0x1f0 > Aug 20 20:29:36 luna kernel: driver_register+0x72/0xd0 > Aug 20 20:29:36 luna kernel: ? __pfx_framebuffer_driver_init+0x10/0x10 [framebuffer_coreboot a587d2fc243ebaa0205c3badd33442a004d284e0] > Aug 20 20:29:36 luna kernel: do_one_initcall+0x58/0x310 > Aug 20 20:29:36 luna kernel: do_init_module+0x60/0x220 > Aug 20 20:29:36 luna kernel: init_module_from_file+0x89/0xe0 > Aug 20 20:29:36 luna kernel: idempotent_init_module+0x121/0x320 > Aug 20 20:29:36 luna kernel: __x64_sys_finit_module+0x5e/0xb0 > Aug 20 20:29:36 luna kernel: do_syscall_64+0x82/0x190 > Aug 20 20:29:36 luna kernel: ? __do_sys_newfstatat+0x3c/0x80 > Aug 20 20:29:36 luna kernel: ? syscall_exit_to_user_mode+0x72/0x200 > Aug 20 20:29:36 luna kernel: ? do_syscall_64+0x8e/0x190 > Aug 20 20:29:36 luna kernel: ? do_sys_openat2+0x9c/0xe0 > Aug 20 20:29:36 luna kernel: ? syscall_exit_to_user_mode+0x72/0x200 > Aug 20 20:29:36 luna kernel: ? do_syscall_64+0x8e/0x190 > Aug 20 20:29:36 luna kernel: ? clear_bhb_loop+0x25/0x80 > Aug 20 20:29:36 luna kernel: ? clear_bhb_loop+0x25/0x80 > Aug 20 20:29:36 luna kernel: ? clear_bhb_loop+0x25/0x80 > Aug 20 20:29:36 luna kernel: entry_SYSCALL_64_after_hwframe+0x76/0x7e > Aug 20 20:29:36 luna kernel: RIP: 0033:0x7b1bee2f81fd Looks like it might be a conflict with drivers/firmware/sysfb_simplefb.c, which also uses the "simple-framebuffer" name with a constant ID of 0. It's possible both drivers should be switched to use PLATFORM_DEVID_AUTO? Or at least one of them. Or they should use different base names. I'm not really sure what the best option is (does anyone rely on or care about the device naming?), and I don't actually use this driver. But here's an untested diff to try if you'd really like. If you test it, feel free to submit as a proper patch with my: Signed-off-by: Brian Norris Reported-by: Brian Norris Signed-off-by: Javier Martinez Canillas Reported-by: Brian Norris Signed-off-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann Reviewed-by: Brian Norris diff --git a/drivers/firmware/google/framebuffer-coreboot.c b/drivers/firmware/google/framebuffer-coreboot.c index daadd71d8ddd..3f1b8f664c3f 100644 --- a/drivers/firmware/google/framebuffer-coreboot.c +++ b/drivers/firmware/google/framebuffer-coreboot.c @@ -62,7 +62,8 @@ static int framebuffer_probe(struct coreboot_device *dev) return -EINVAL; pdev = platform_device_register_resndata(&dev->dev, - "simple-framebuffer", 0, + "simple-framebuffer", + PLATFORM_DEVID_AUTO, &res, 1, &pdata, sizeof(pdata)); if (IS_ERR(pdev))