From patchwork Tue Sep 10 19:06:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Matthieu Baerts (NGI0)" X-Patchwork-Id: 13799254 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078BD1AAE13; Tue, 10 Sep 2024 19:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725995224; cv=none; b=W4v0lwwRob1y7XR9Z1ptHsjmoP8Fcl5PIxRzdy/WKt2Jz4ej7JpY1+Yu4c6okmDGOpH5Xrz0bFuWrvQ6qzbf9kiCsvNE/n45XN6eFcbARxKBj3YvQJ6xyVIrDpLYkeA7I06DW7hk2C101KRl6I4rS+RaDSMfRkf6pQJkS/faySU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725995224; c=relaxed/simple; bh=QgKZMPlAiI7k1oZ5ezpnNYoN7ULwe/z2ApzxqxNf/0k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eEbeOuiv9hlLD8e8vkEheLN+kXdxfgqu5h6Fxew9TVJ/ma9KI+E2uTvNJP4UPw381f4e6UulbznxoczctoqTQfquDv8EqOp02M3Ldw6c6rK10bzQU7HSlEF4LfnR97JV1CACRCIkTKFLimNNgkp7gQZ2Z71WMIb/N07P9E5C3nM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h0TJkimY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h0TJkimY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 086ECC4CECE; Tue, 10 Sep 2024 19:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725995223; bh=QgKZMPlAiI7k1oZ5ezpnNYoN7ULwe/z2ApzxqxNf/0k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=h0TJkimYyhkgI5uiNOOHMNJTpCPU+bFSyY/4StX3MGFxwIbYN/AGKeV/ZzfOYywHs mXHc2HqWE+dTkfcYWPsS5Dtg+shcmJo9gHglx+AZzeWTHccK+1E0J4omUntiwChAX3 dUsysIHD54Ut2OlIrzcrnqUIPBzG5bAECtb8e6In7/dtDQzLhMUIdhBf1wR/PUosA1 uUb0xQIqJr6cnasoEVBDHRnu7yXaqK103zWV1DxNnW8vt7ZApXso7YSAON02xHL+H/ z4EmJu8pvfoHECMGx9EZtIJuSguMS5cuD2P8PdxyqdTydEF+pvXF/pcnuTHsxkTxe/ gsQ/1jIyo5mnw== From: "Matthieu Baerts (NGI0)" Date: Tue, 10 Sep 2024 21:06:36 +0200 Subject: [PATCH net 1/3] selftests: mptcp: join: restrict fullmesh endp on 1st sf Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240910-net-selftests-mptcp-fix-install-v1-1-8f124aa9156d@kernel.org> References: <20240910-net-selftests-mptcp-fix-install-v1-0-8f124aa9156d@kernel.org> In-Reply-To: <20240910-net-selftests-mptcp-fix-install-v1-0-8f124aa9156d@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1738; i=matttbe@kernel.org; h=from:subject:message-id; bh=QgKZMPlAiI7k1oZ5ezpnNYoN7ULwe/z2ApzxqxNf/0k=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBm4JjRuPiBmqQot2XLTpRTMWhZfHmFpzO1y02Wl aCc7IshYiyJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZuCY0QAKCRD2t4JPQmmg c2XQD/0aHs+MCJEqg8v/bc77WNcibzjhtfoMGZ8abK9s/afUxzbz96vhN7cXXEVb/lpIFqr440R b7A9IfNNkqHpfb0lMfVu5dppXr1AGa23sqywOXLNdxsoDzkSe+4DJUODPxcy5774eEYRCHitikX sK36dwZ0/CfJ8I6KBd8Vyv9euSE9hnthfjK6cx97rFdMHMNo6VD5nuTOhs+qYAby3h/YOuADfEt RFrVCJ/Ol8wL9XOk2jPKj/kIQCTKKhsL7J3fR+t3hflJKQR79VZx3NOzVlELSBF2wyHxOyBJB4G zCMsGQfhh38Gy2QzKJCftPAlhnNhkGcK1xzxVN50Y3i12w+u1itCDLMEN9actcL9EQLRgEPjFKr kjh5rEzKlOs6XH+cb0KbA3I/H2rUUqkBs3V36tFnJRjBmmme0FWQ7LO9qmodQyS8An0GpK6c9Gv SDnZs8QrEIhUw27y0K46IGkpidDThJ9aaJ/hoviNLH8RDrb0sOEU410I8F/970BjozcM9P6uaax tPB060csTgsORANAy4VMEHpG+HC5ufvcOWvKrTv1CdPQbPXDhjhU2BDWhTVp4CqT666bQ7GIhky M1ro2FfEsinHSGAz/om5A4uGuu8QxYJZAjGDgLgIpvauzHwr8F3m2SpCNyvstEvioMCf0KTCcKH s9YoPlXmyv4bv2Q== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 A new endpoint using the IP of the initial subflow has been recently added to increase the code coverage. But it breaks the test when using old kernels not having commit 86e39e04482b ("mptcp: keep track of local endpoint still available for each msk"), e.g. on v5.15. Similar to commit d4c81bbb8600 ("selftests: mptcp: join: support local endpoint being tracked or not"), it is possible to add the new endpoint conditionally, by checking if "mptcp_pm_subflow_check_next" is present in kallsyms: this is not directly linked to the commit introducing this symbol but for the parent one which is linked anyway. So we can know in advance what will be the expected behaviour, and add the new endpoint only when it makes sense to do so. Fixes: 4878f9f8421f ("selftests: mptcp: join: validate fullmesh endp on 1st sf") Cc: stable@vger.kernel.org Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_join.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh index a4762c49a878..cde041c93906 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -3064,7 +3064,9 @@ fullmesh_tests() pm_nl_set_limits $ns1 1 3 pm_nl_set_limits $ns2 1 3 pm_nl_add_endpoint $ns1 10.0.2.1 flags signal - pm_nl_add_endpoint $ns2 10.0.1.2 flags subflow,fullmesh + if mptcp_lib_kallsyms_has "mptcp_pm_subflow_check_next$"; then + pm_nl_add_endpoint $ns2 10.0.1.2 flags subflow,fullmesh + fi fullmesh=1 speed=slow \ run_tests $ns1 $ns2 10.0.1.1 chk_join_nr 3 3 3 From patchwork Tue Sep 10 19:06:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Matthieu Baerts (NGI0)" X-Patchwork-Id: 13799255 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED8701AAE3F; Tue, 10 Sep 2024 19:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725995227; cv=none; b=WvSpF/vm13f9yRTDig5bYQYEer+OevbsLqMMhxtbbZ55libYqrvQTPo79bSSGkdynrh5vE8m8+xuQ9w1IgSWY+Tq3FCKMfptXqXGaHhDLDvs0sc/V/eDqlK95fRPgZWe/LTs3xe2Det8CZ5XShpf50G7/YmD2Rm1aXI8kjrk8GQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725995227; c=relaxed/simple; bh=qDdqHdcGxPDTj/mv2nTeJVub1oxQDtvYdII5/k1oFio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MpplXgCETBeER5DljTK3jmITLEQHAS2BlvhXwchDxFP6fKJwHK4FP8VdBhMVrxlDyX8V2McfxzRS7xZuJOvA0FAxslK10Ov1bc+sHSbYGLDpmw4MIsukCjK4YEAo5sdWqRYDPumRvFMycOgk9vf76trUk7KxD3EHHp9n2vDOjc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RM2cMH04; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RM2cMH04" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BDB1C4CEC4; Tue, 10 Sep 2024 19:07:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725995226; bh=qDdqHdcGxPDTj/mv2nTeJVub1oxQDtvYdII5/k1oFio=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=RM2cMH04h22dZOzYMS+2rS4ATooohzdO3/v5PoF0noLzA9SGei+MXiQ3VGUoKBDcT Q2AVIfpLZn5UIaBB/rI1Ze0B20aSxgi6lL5n1DVgBxQw6WxphaDGNW/G9QEy8ZzPGQ 84QJ9HEcLkcR28Eh/FeKpEaYU5OMcz2j/yATqG3gNk0lstUSMvPKicnYHHP+PcirAH bHLK3eesKp7JQQrBgSVj113SzpPLwshsViyK6gXsJMM4UzeLmnp5EAcyQyMgsduDl6 bocCTIJzv5pfjx5UoHMR3RUP+g0N610H/A1kPaYWmcKEkqGT5BaTAJt588tCMELB0b O+og18JhXniqA== From: "Matthieu Baerts (NGI0)" Date: Tue, 10 Sep 2024 21:06:37 +0200 Subject: [PATCH net 2/3] selftests: mptcp: include lib.sh file Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240910-net-selftests-mptcp-fix-install-v1-2-8f124aa9156d@kernel.org> References: <20240910-net-selftests-mptcp-fix-install-v1-0-8f124aa9156d@kernel.org> In-Reply-To: <20240910-net-selftests-mptcp-fix-install-v1-0-8f124aa9156d@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1129; i=matttbe@kernel.org; h=from:subject:message-id; bh=qDdqHdcGxPDTj/mv2nTeJVub1oxQDtvYdII5/k1oFio=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBm4JjRZQ24BZMu1h1QV0ZFxLUIY/bq73nziQz1G GMZAAiJHKSJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZuCY0QAKCRD2t4JPQmmg c35KD/9BUEvN905IXtVjRV2aziGXNRcfNcIk/UrdILqNuLyUMkz/Wgn6EjYV6366J7DrCst+fzT 9L94X4Vd/NmKSGLvPOfFpOnZYocfxGaa4cFqkJ4fKHdgK6aKFpovVRg+wc32UvWZmm8SBR5e3Mw 1BnBKl746BD8EArjD6k2h/VTngSHAZovxo/71JshFUgf1xlX57qkwJ35Aq/bd3PdAJOAb+Grrzv NBQvfJT3QHpHtyI4bOgsYj72dYBoln6qEdBvGx6qnY8wr3K+8MG12AQP0qaO3dS13nWz8vz55wy 5XDUGfWI0tXE50lGdM83FVohDJUO9sft7jhGF+NkThYTvdxeVbnwbhdKwTgvz+qdjuw/e9Th1pA sM6v0mbWB4ufNt/6sFXHNoD/VFQJqKFGko4K4j2UG4tQ9SiCxl72uAOvt36qgZv3/GDQqbzpyPe BkrQFkXU56haWnj9+yLLvbr9fNLKfL6I5cr17MD//YAMRnZX9+PjYGSvXlFcg7h+gkAO58N6BXa 84U0Cv3lM35i4iPDcqlkUNlPa7/7LWCG8BUrKmvdmeelWvpLMg9O9iq33gYSoyBQNnGbJHfgdhr vLiKZro1dbp/ZaWv0fPH37/fDadD/Vsatejr4fhGrqG5GDMKfPEc0FKgctjxxbNqosG4wI7oe4w o4RYKa3eVu17JHA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 The lib.sh file from the parent directory is used by the MPTCP selftests and it needs to be present when running the tests. This file then needs to be listed in the Makefile to be included when exporting or installing the tests, e.g. with: make -C tools/testing/selftests \ TARGETS=net/mptcp \ install INSTALL_PATH=$KSFT_INSTALL_PATH cd $KSFT_INSTALL_PATH ./run_kselftest.sh -c net/mptcp Fixes: f265d3119a29 ("selftests: mptcp: lib: use setup/cleanup_ns helpers") Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/selftests/net/mptcp/Makefile index 7b936a926859..68924053a1e6 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -11,6 +11,8 @@ TEST_GEN_FILES = mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq TEST_FILES := mptcp_lib.sh settings +TEST_INCLUDES := ../lib.sh + EXTRA_CLEAN := *.pcap include ../../lib.mk From patchwork Tue Sep 10 19:06:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Matthieu Baerts (NGI0)" X-Patchwork-Id: 13799256 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE27C1A7048; Tue, 10 Sep 2024 19:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725995230; cv=none; b=AgdoRLFKf3YmdyJ9ZUfBzaNuZdG6j+b5zLBzSgrRD0GCXEzsfjI5DpfIR22cTmU3rqhF0fksHpbCojk8Sjf5xUbG7B4ZG3FWLv9N8Tjmb363VdG0KMELxnJAwZnc0QhsZ2bKfJmhAiTijC+iDsYimMVNRm3X9Rd+vedV6Rzjo3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725995230; c=relaxed/simple; bh=AqPu88ul23g8vqXHRoSXpzTMwp8/lrE6zGfqa11fWfg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=khVv3ikrcxqjBtKeDtJ5AITHB+ylyzI7njIkW7TFlywXeCAXzCsUfmP+1FgH30WtltxtCZnFxqeaZ6eDK6nNmYt2XSHjr9vOnPzvKsI/Mojlp0a/SbLiLRgQWgDlTWfliirZ3zctv2JhywGtHkzyPTWKH3+jnN4/DVL5+2ReKB4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P6gtvCzG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P6gtvCzG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3B7FC4CECD; Tue, 10 Sep 2024 19:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725995229; bh=AqPu88ul23g8vqXHRoSXpzTMwp8/lrE6zGfqa11fWfg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=P6gtvCzGxO5Y0e2RnUdHCFSr5LLlSv72Sti7fTWVOcCjiyYu7Z3rE2JkM2BchUWyq ex0GOtesJtDIJgSqihW9VKI+41CA6Sv9vZ78fcujf5VPx4DOs1PxSbDXrW4iXDRhco lpjroNSHpdjyrD1Csw0i2ocNXdJ/x/Q4hSnN5RxdXw7zxSrwWl9nGOnrHwCWDqrhSk zgF6EFpMFIiK747wulc7srIf4RRY6UJIW/LlCt3D+2JWLePWeL/xozEBofhgrVv/tW YbBSMLLH6VHNdpl/fwN18ZH/KqWMDauqXIsIK6eRV4glLTZ4A31MAAZQSUPucXGVV7 GTZIrAVi42ciA== From: "Matthieu Baerts (NGI0)" Date: Tue, 10 Sep 2024 21:06:38 +0200 Subject: [PATCH net 3/3] selftests: mptcp: include net_helper.sh file Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240910-net-selftests-mptcp-fix-install-v1-3-8f124aa9156d@kernel.org> References: <20240910-net-selftests-mptcp-fix-install-v1-0-8f124aa9156d@kernel.org> In-Reply-To: <20240910-net-selftests-mptcp-fix-install-v1-0-8f124aa9156d@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1211; i=matttbe@kernel.org; h=from:subject:message-id; bh=AqPu88ul23g8vqXHRoSXpzTMwp8/lrE6zGfqa11fWfg=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBm4JjRLyUOkbW8YPrnCLArXrvqiNJsK74wn5pqZ 22BnQBxbF6JAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZuCY0QAKCRD2t4JPQmmg c5MAEACsaR2u56Kl4zwkCtHtRZoVuBNtTlAkyiz8Kd5q5r5VfGquW9QrY1vNnfWh75be7jiCbti zK74NRqcGRsd/Jn4Q13EDMx89iO9vN70/zrwyccUh8EkII8b2DaFSoP2t3fVnaPMrkyuzY6n/cc 35aOdBLHfLTSH1C9dqDe5ec01TWogsBQhUXVeLzXrOz4KWvlnQl7/AlNaJqxDCfluYzkjRat7Jv gGxg3X3BoFIAnis1dmsg22m4KaaCSLyXuxI8mkSkhfkbdTDHXf0/f0bK1NFU2p8ma6FYoztgodG bohV9lXpgfadEk/kGY6klDenQg9wNBYDQ80ScknfhZM29PoXtoF6ZO4hszgWyO9+29J7vX7cChY 0tuGew0vBbKUz4NMAzY3LGnBIH1bKPAzTXpr2BfCy9R9yFBk151Woi5tNUjaHW1sqGzAYkKM8/P u3zf6Eod9daIA1CYeJNAYX0SmmtX3xd59VIpEZ3yXjj9h/o7B52SjWQXf+2dHTsB9ruxvzlM6SU rMOkY7GDuxUiU7hltsMyg/AK+shRY7QuRW+9sKvoBQMnEfajS9rrn7P68qI21SHZzJjE9+AW6++ 299uVSaZB0NTPUNG+KwLokMHaZxGn+vvqQsflLNC3k0C5VtA228hpYMu+N6u7nyabKyGqSjbvhj Hf2SKyDyYpVaBcA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Similar to the previous commit, the net_helper.sh file from the parent directory is used by the MPTCP selftests and it needs to be present when running the tests. This file then needs to be listed in the Makefile to be included when exporting or installing the tests, e.g. with: make -C tools/testing/selftests \ TARGETS=net/mptcp \ install INSTALL_PATH=$KSFT_INSTALL_PATH cd $KSFT_INSTALL_PATH ./run_kselftest.sh -c net/mptcp Fixes: 1af3bc912eac ("selftests: mptcp: lib: use wait_local_port_listen helper") Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/selftests/net/mptcp/Makefile index 68924053a1e6..5d796622e730 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -11,7 +11,7 @@ TEST_GEN_FILES = mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq TEST_FILES := mptcp_lib.sh settings -TEST_INCLUDES := ../lib.sh +TEST_INCLUDES := ../lib.sh ../net_helper.sh EXTRA_CLEAN := *.pcap