From patchwork Wed Sep 11 09:10:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= X-Patchwork-Id: 13800082 X-Patchwork-Delegate: matthieu.baerts@tessares.net Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F66178388 for ; Wed, 11 Sep 2024 09:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726045863; cv=none; b=C2qLUJJoXcjrIGsJOxLu22pHMxHiA2ijhlqbfGAkt/5DzQvWiMkGJDGuut41mCufhcGvqCmoibgHy7cPKWo/rFC52uQh4fHRsMrJeZogvcP5le8TbUi66DpekPvXkQwvMVxR6Lw4dX8Vcw7o5snPK3jW+4+7crupeBhO0XG29Nc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726045863; c=relaxed/simple; bh=2c4w0r9Ea/sw99GyPYRVq+HtuWZK5k/qD607q5Esn7c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=SDQdOP+KTsXNJZwt9+1w2urIjlnwz+uN2i+AyJ2qDqzY+MkNWSOEGZI3zCsY3IkepFAhm/bfsYb3Pojvm7tG0yhVDWgXvmkHsFzz/U77PXeLWID9nucV/PHGg6XcqCtvps/FGomXsLrAZLE0m4UZrZ9GId1ODYO8yeAKdl4pBik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=IKZ8p6uP; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="IKZ8p6uP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1726045858; bh=2c4w0r9Ea/sw99GyPYRVq+HtuWZK5k/qD607q5Esn7c=; h=From:To:Cc:Subject:Date:From; b=IKZ8p6uPNH+WGC1SUr1bArWgX816/7ZRtBomcCytacFUZZD14vBSJR/EZNgxYoXsd j8UpHmlfnQs9yeZnydLSJ2mrZ4JdXQcS/v+HaeWgmZ5smbPBwX2jbwKKdWfcWrp/Cm 3xtPN6JogbLnkX6QYuBM7JkxDjdRefvtCrBAMTci2GzDt4VaoaBqEHv4/W7GVBITg2 BNK1CIMkrLEnIwkmaItunOwGDl99UhRH7DfcI4m+XVyuELtl5Vas7iefFhGqadWVp/ YNG9wl5uCQMQlLOznH2brBMAGDCkkkFqGePgIYPc9rBvhaGZZ3PGamskF3EiA8lvld 7dtfdEiMiAsPA== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 0CFDB60078; Wed, 11 Sep 2024 09:10:30 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id 979472017A4; Wed, 11 Sep 2024 09:10:15 +0000 (UTC) From: =?utf-8?q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= To: Matthieu Baerts , Mat Martineau Cc: =?utf-8?q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Davide Caratti , netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH net] netlink: specs: mptcp: fix port endianness Date: Wed, 11 Sep 2024 09:10:02 +0000 Message-ID: <20240911091003.1112179-1-ast@fiberby.net> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The MPTCP port attribute is in host endianness, but was documented as big-endian in the ynl specification. Below are two examples from net/mptcp/pm_netlink.c showing that the attribute is converted to/from host endianness for use with netlink. Import from netlink: addr->port = htons(nla_get_u16(tb[MPTCP_PM_ADDR_ATTR_PORT])) Export to netlink: nla_put_u16(skb, MPTCP_PM_ADDR_ATTR_PORT, ntohs(addr->port)) Where addr->port is defined as __be16. No functional change intended. Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for mptcp") Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Davide Caratti Reviewed-by: Matthieu Baerts (NGI0) --- Documentation/netlink/specs/mptcp_pm.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/netlink/specs/mptcp_pm.yaml b/Documentation/netlink/specs/mptcp_pm.yaml index af525ed29792..30d8342cacc8 100644 --- a/Documentation/netlink/specs/mptcp_pm.yaml +++ b/Documentation/netlink/specs/mptcp_pm.yaml @@ -109,7 +109,6 @@ attribute-sets: - name: port type: u16 - byte-order: big-endian - name: flags type: u32