From patchwork Thu Mar 7 15:43:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843257 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 288B2139A for ; Thu, 7 Mar 2019 15:43:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 195D52F440 for ; Thu, 7 Mar 2019 15:43:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DA282F458; Thu, 7 Mar 2019 15:43:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87BBB2F440 for ; Thu, 7 Mar 2019 15:43:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbfCGPnn (ORCPT ); Thu, 7 Mar 2019 10:43:43 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46873 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726296AbfCGPnn (ORCPT ); Thu, 7 Mar 2019 10:43:43 -0500 Received: by mail-wr1-f68.google.com with SMTP id i16so17958184wrs.13 for ; Thu, 07 Mar 2019 07:43:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u2lo2WEDRuEdyIPOfJAVbLGdfhu/OMhY0/4TDFAALgs=; b=Fn9X4aVX0GjrPmYbSQ/foBX0dMomjp+O8QAYRy6G1M8dRPYSFbvWxgGiITGrUCj9NG 4wuh9ssJFAHI3bedJ9sLOFP1f5ILTudQzhlq5T+655e8zIDN31DsH/ikfatC1JhS/9Jr i25NBgma3SWJ+ejgt1x2nVBIDEJwcZOHjopdwpsWU4czu1awAEtC5sGGjh1GRbF8x3Mj lrMp2w7bvIDHB/D3AAdAWGTVUq290TxoMpMnQuz1VnnSVedxFDg4OtUcty922qcLkjkT dEywh4nmY/zLtAmGKbtb3wDWws92mlBLQFIl1+/N9gPc3o5FyxP2ocYL3Xv7cdsLpqLi 4ehg== X-Gm-Message-State: APjAAAV4KmchCGSBk/WTX4wuTt3H3cARfORkVOTrZsp/LUNcWZyv9nRZ mz/PJ7Y3hHvUN69rdAtmOnQ6yyMEaBg= X-Google-Smtp-Source: APXvYqwkb3KRVFpeCvSTQBiSpHICCwGYhDHorOSD4ALKC6CIGeaP4yO/T5GcNoqxjx98ZDV0v8Q/og== X-Received: by 2002:a5d:6744:: with SMTP id l4mr2692255wrw.226.1551973421450; Thu, 07 Mar 2019 07:43:41 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id h9sm10081463wrv.11.2019.03.07.07.43.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:43:41 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 1/4] kernel-shark: Specify the OpenGL interface used by KernelShark Date: Thu, 7 Mar 2019 17:43:13 +0200 Message-Id: <20190307154316.19194-2-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307154316.19194-1-ykaradzhov@vmware.com> References: <20190307154316.19194-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We instruct CMAKE to prefer using the legacy libGL library, if available. Although this is the default choice, the latest versions of CMAKE are printing a warning message in the case when no explicit preference is provided. Suggested-by: Slavomir Kaslev Signed-off-by: Yordan Karadzhov --- kernel-shark/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt index 9460026..20ced14 100644 --- a/kernel-shark/CMakeLists.txt +++ b/kernel-shark/CMakeLists.txt @@ -22,6 +22,7 @@ include(${KS_DIR}/build/FindJSONC.cmake) find_package(Doxygen) +set(OpenGL_GL_PREFERENCE LEGACY) find_package(OpenGL) find_package(GLUT) From patchwork Thu Mar 7 15:43:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843259 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70210139A for ; Thu, 7 Mar 2019 15:43:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D6192F440 for ; Thu, 7 Mar 2019 15:43:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 519222F458; Thu, 7 Mar 2019 15:43:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 013D02F440 for ; Thu, 7 Mar 2019 15:43:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726508AbfCGPno (ORCPT ); Thu, 7 Mar 2019 10:43:44 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34005 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726296AbfCGPno (ORCPT ); Thu, 7 Mar 2019 10:43:44 -0500 Received: by mail-wr1-f65.google.com with SMTP id f14so17977841wrg.1 for ; Thu, 07 Mar 2019 07:43:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0NlPH1sx2DN6jL09JWk0KaQC0Aq8UtRh2ftH7bTprAU=; b=Q4hzPNDqE3kZaHj1mnijz8G5K0uX0W9bFn2Sn16cmMJ0sej8DdRrkA8dQ2yz4GL21V +PrAhFYbDhrxgMIiP8/KaF3Z/XNS+Ig1YIcDxoGfFK96dN5lz4zqhpp0BD1tKLgRiOaX Gk5SmJej72+7Q+500wu0V8QngJ49sNMsl0xf8bx1WkmT3P6IZqp0cmtL5xWTX8yfZfN7 lSaODsbWniyUmCZNITevMC9IEZl7t2vR68KpaXhZcXDDTcjzJRVNBJy7fINC+lG0I9DY 39SuI8kAITeD+9d5sn4xg1CjFgeai7xYBKua6yjDmW2WToDCG8J66XPdvDEPqDjlSRkF bvJw== X-Gm-Message-State: APjAAAUYfJ7hZufomcd9GUpzEohxaQaRwNo17kQy9TX44L1TXRDTUSkc DmGWpNH4ROjXRGVThlSWtHs= X-Google-Smtp-Source: APXvYqxva+ydjn9MwlGpgqoMc1vJkSzFkegpNofVY63ld6DQQCWpwm0a9VQhT8APwWbyFTZ28SoNlA== X-Received: by 2002:adf:ec07:: with SMTP id x7mr7126296wrn.174.1551973422773; Thu, 07 Mar 2019 07:43:42 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id h9sm10081463wrv.11.2019.03.07.07.43.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:43:42 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 2/4] kernel-shark: Fix a bug in ksmodel_zoom Date: Thu, 7 Mar 2019 17:43:14 +0200 Message-Id: <20190307154316.19194-3-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307154316.19194-1-ykaradzhov@vmware.com> References: <20190307154316.19194-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When zooming-in the model is supposed to avoid over-zooming by recalculation the Scale factor. The new value of the Scale factor is supposed to be such that the size of the bin cannot be smaller than 5 ns. This patch fixes a naive bug in the way the new scale value is calculated. The bug was introduced in f97e31f00 ("kernel-shark-qt: Introduce the visualization model used by the Qt-based KS") but had no effect until 94efea960 ("kernel-shark-qt: Handle the case when the range of the model is too small") because the ridiculous value of the Scale factor resulted in a very small model range and because of this the modification of the model was always rejected. Fixes: f97e31f00 ("kernel-shark-qt: Introduce the visualization model used by the Qt-based KS") Signed-off-by: Yordan Karadzhov --- kernel-shark/src/libkshark-model.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel-shark/src/libkshark-model.c b/kernel-shark/src/libkshark-model.c index 4bd1e2c..af3440b 100644 --- a/kernel-shark/src/libkshark-model.c +++ b/kernel-shark/src/libkshark-model.c @@ -648,8 +648,8 @@ static void ksmodel_zoom(struct kshark_trace_histo *histo, * Avoid overzooming. If needed, adjust the Scale factor to a the value * which provides bin_size >= 5. */ - if (zoom_in && range * (1 - r) < histo->n_bins * 5) - r = 1 - (histo->n_bins * 5) / range; + if (zoom_in && (int) range * (1. - r) < histo->n_bins * 5) + r = 1. - (histo->n_bins * 5.) / range; /* * Now calculate the new range of the histo. Use the bin of the marker From patchwork Thu Mar 7 15:43:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843261 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9AA9C1390 for ; Thu, 7 Mar 2019 15:43:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B36C2F440 for ; Thu, 7 Mar 2019 15:43:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F3BD2F458; Thu, 7 Mar 2019 15:43:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C6D92F440 for ; Thu, 7 Mar 2019 15:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbfCGPnq (ORCPT ); Thu, 7 Mar 2019 10:43:46 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36635 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbfCGPnp (ORCPT ); Thu, 7 Mar 2019 10:43:45 -0500 Received: by mail-wm1-f66.google.com with SMTP id j125so9756571wmj.1 for ; Thu, 07 Mar 2019 07:43:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b88oxwvPmWDVA/FBp3A71q2ZVukyxicVOA5F9lDyxEU=; b=PaJ8dFSKEZu321u4cn2CbNjGEcJtS3+0ZN4GRekkC9RvX7/+yZQQu77Bwjw1LQDMOW Gnb2lev7/08yp0AOYAQA0Hj5VPUkmrbJNBAdpPbztUcHhGEtYlABGwtXmIwzmYuQw63a oxJR/efXidK8m9dzqho1vIuGR3wkitnf9qdL4svgn31JmIsAIT7eowGqzujpoWfxwo03 yJm2emiTHKrECVwa9ZFObCLqY6v2/WqUx2b7ZeaMp2YHu1OCjvyxVgjKsgkKYV4BQaMx fLE9Xw/hSJ719S6RJyrcTj9vqy5Evih8e6Ayt5gG2J63fIErgIN++3JXz1mlXBahaPr0 vkRQ== X-Gm-Message-State: APjAAAUqy5QQgZjQ5RF+PaUtUrXQJ6y0QrOZvTLWIsAy9g1yKr4Ou++n +7kPHtplB4G72AtHqHHUKyqQ83YA+tw= X-Google-Smtp-Source: APXvYqx8stpBjFxn/6RqRA8ydCk4nHy3tBGQSjyignPWOVoNjccsaotXGdprvlhgHO5dHJ5GYcAlMw== X-Received: by 2002:a7b:c777:: with SMTP id x23mr6368897wmk.71.1551973424020; Thu, 07 Mar 2019 07:43:44 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id h9sm10081463wrv.11.2019.03.07.07.43.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:43:43 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 3/4] kernel-shark: Fix Doxygen warning from sched_events Date: Thu, 7 Mar 2019 17:43:15 +0200 Message-Id: <20190307154316.19194-4-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307154316.19194-1-ykaradzhov@vmware.com> References: <20190307154316.19194-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no reason for find_wakeup_pid being non-static. In the same time, because it is non-static, Doxygen complains about missing documentation for this function. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/plugins/sched_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel-shark/src/plugins/sched_events.c b/kernel-shark/src/plugins/sched_events.c index c52fb29..724aa19 100644 --- a/kernel-shark/src/plugins/sched_events.c +++ b/kernel-shark/src/plugins/sched_events.c @@ -148,7 +148,7 @@ static void plugin_register_command(struct kshark_context *kshark_ctx, tep_register_comm(kshark_ctx->pevent, comm, pid); } -int find_wakeup_pid(struct kshark_context *kshark_ctx, struct kshark_entry *e, +static int find_wakeup_pid(struct kshark_context *kshark_ctx, struct kshark_entry *e, struct tep_event *wakeup_event, struct tep_format_field *pid_field) { struct tep_record *record; From patchwork Thu Mar 7 15:43:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843263 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B9535139A for ; Thu, 7 Mar 2019 15:43:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A83EC2F440 for ; Thu, 7 Mar 2019 15:43:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C4B32F458; Thu, 7 Mar 2019 15:43:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 521602F440 for ; Thu, 7 Mar 2019 15:43:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbfCGPnr (ORCPT ); Thu, 7 Mar 2019 10:43:47 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55047 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbfCGPnr (ORCPT ); Thu, 7 Mar 2019 10:43:47 -0500 Received: by mail-wm1-f67.google.com with SMTP id f3so9789031wmj.4 for ; Thu, 07 Mar 2019 07:43:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eMAX++wxUEb3/+S1k0GjhXMPAUaZXGR6sOY/EpkRX04=; b=EdQnTADByO41qYgOobNtLLS7HyOx/fApc8eKJ6HeVB9DfGLwzAF9VdY69B/wCtyWOq DKaR6xmwxkwO7CnUbs/r3NF5Vll25AaDCNcIjw0O+dMEbxVDmEu/JCgq4g4Ri3MliHVA AvWjhsi1sTVO9a8VKYz7IuiZZsr4KcbKIcoCuBk1I/ES8WB6c/LPYOIGWXCPtKE0M997 e0lk9jGQfEJcy89beaFaaycRY2q+CXE9sr5F4896hdnOlHuqLAW7CCm3d1yaEmteeI8h l1AKiEPIvmxMTKTyYEMEOV8PCz9nxH8WgYzrtw1PGyeqwHh09RGucKDRHx9v4B9mDFVX k5Rg== X-Gm-Message-State: APjAAAUXT0w4W2dPzUHDLIdhes3vXdmf7W+9SDX2dEu2paaCz4RVnYo6 0mhVc3ZMpYUOFAMAfNg7OvQ= X-Google-Smtp-Source: APXvYqxyl9fiML/SjsUPY2J01jQTpK1MI3H9zZuLgGfdAS1531h84ySzdlrnlUrm4tLCFsgNo4CGSg== X-Received: by 2002:a1c:dc0a:: with SMTP id t10mr6182738wmg.101.1551973425140; Thu, 07 Mar 2019 07:43:45 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id h9sm10081463wrv.11.2019.03.07.07.43.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:43:44 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 4/4] kernel-shark: Fix a bug in KsPluginManager Date: Thu, 7 Mar 2019 17:43:16 +0200 Message-Id: <20190307154316.19194-5-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307154316.19194-1-ykaradzhov@vmware.com> References: <20190307154316.19194-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP const char *lib = plugin.toStdString().c_str(); This line is a bad idea because the returned array may (will) be invalidated when the destructor of std::string is called. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsUtils.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel-shark/src/KsUtils.cpp b/kernel-shark/src/KsUtils.cpp index 34b2e2d..d7b1753 100644 --- a/kernel-shark/src/KsUtils.cpp +++ b/kernel-shark/src/KsUtils.cpp @@ -439,7 +439,7 @@ void KsPluginManager::registerFromList(kshark_context *kshark_ctx) auto lamRegUser = [&kshark_ctx](const QString &plugin) { - const char *lib = plugin.toStdString().c_str(); + const char *lib = plugin.toLocal8Bit().data(); kshark_register_plugin(kshark_ctx, lib); }; @@ -474,7 +474,7 @@ void KsPluginManager::unregisterFromList(kshark_context *kshark_ctx) auto lamUregUser = [&kshark_ctx](const QString &plugin) { - const char *lib = plugin.toStdString().c_str(); + const char *lib = plugin.toLocal8Bit().data(); kshark_unregister_plugin(kshark_ctx, lib); };