From patchwork Thu Sep 12 07:38:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801578 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D46C146A6F for ; Thu, 12 Sep 2024 07:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126771; cv=none; b=D2P6zCB/1+guZFbHhe0/+SpK47ZNmbMWqjUvY/4PKqv+FHeKaAxnw7Yrhzsz053k/7EgzxmNBcy5atGHiQaUSQ9S84eEbbJi83oHmQsB8y6WIzz9EsJXpXDGwzqAr5UFyqZaAtyPkYScthjWRPRT+p1rjvwdkfYAoH9x6R5dwf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126771; c=relaxed/simple; bh=Ob7QVp9Q2nCpn5MMIeG9ms6CuNJdyiFbdx04hmjn9M8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=micuSh8ErJ7P785GiZpLUHftl980sO3AM9mYhoYDQ4UgT4aA2qEWZt3TGkBdrf2JcvWu0eMqGLbxeyL4W4CEVvyTEAc2TYtcNkJQVPzQNQQZNaiNBEYsMO7msr/usLLELcxPhqwXWlNyDqt2RgHlgARvHmIG+MgxdFm75AOXYKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oqoOuVtz; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oqoOuVtz" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7db1f13b14aso632271a12.1 for ; Thu, 12 Sep 2024 00:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126769; x=1726731569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IRV8cs5vGajAoqqaVP2CMnCi0idLbKzQEkk2XTwPdlU=; b=oqoOuVtzdBlQBc4TchpZo/xqhsA7GvbfXbCMPypE9KyHdg3yxYvqUXO4NsLgdnjusX 6qElGP64ZoTZoYjuJgv9Ds1rcFBcGpkKebL+YX97zNtOHTA3xzA/aauG7KM/LW0xxIxj psOj0aT2S//p3uSgCe7fGFfP8f9GsfhzFH2ev/zNlWVxaGyK255rcjSnQOJEyBymMt+D qR+xOFvmKzGKob37h9cDRfL5U1v+UKhay8AlytOaKy68hwu5cITpGfvjHoQ5qEhMUlfJ hh0lHMYrgIdxpzCgis/Sy2tNXpt6akq8H/5rBXxKdwsaDTNZzuT322SlwtzJCQaFJS3D VEnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126769; x=1726731569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IRV8cs5vGajAoqqaVP2CMnCi0idLbKzQEkk2XTwPdlU=; b=PN06RNfDVvUZAEC2RUZ28snmEMEzvjMGHHCTwd0abbWx1kVzUqKPCcgpKToo9R60rl tR1y40jEmoC/rMNozPMlIeES99F0NFhkCHGMsq8fzM0YUjkIaXev3wfDjV7hUI9aI0Ub RliPQ8+5dfvU8nH//vgcgsq5mx8LqJAM4uPXxENSX8c/GJos6Tvwl0iQy6Lrl/fxclSj LKc3N4oOV6Osh7EYjW+Ll7cppnmo2kwVYlZURc6mBDhtX+uwxaF6F0VFWGCvDOWoDoL3 mzlli2U/B4SNkGqD1kCJ14bSYspqWIJSNf66ubiGwMvcxKqmlXgjGr8f5IDTxXVZX2Gk GeKA== X-Forwarded-Encrypted: i=1; AJvYcCUHAEaD9FeedgMLn1z15TlJlUn7hwTOcGXOsvOpoUeIWiR6FJX7xisT6FenwvzU8eCOkgc=@vger.kernel.org X-Gm-Message-State: AOJu0YxuKXGtaf9ned6bP0KWW8Px2vy18ZpUuJQsGrQJJDN2GZ9bBvAS wxx3BaOMrYXR/nqcSQwQidR74HKd93yduNVvEJbHUj1hJBR50FPsPuATQDjQNcA= X-Google-Smtp-Source: AGHT+IELQJ4LN1eiiJh78GYcEX/xms21hXHkteEXLmVpd/6Wpu6TPg6l8or6duVIN2euH8mSyIIX7A== X-Received: by 2002:a05:6a21:10a:b0:1cf:434d:609 with SMTP id adf61e73a8af0-1cf75ec46b4mr3157664637.6.1726126768552; Thu, 12 Sep 2024 00:39:28 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:28 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 01/48] docs/spin: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:34 -0700 Message-Id: <20240912073921.453203-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- docs/spin/aio_notify_accept.promela | 6 +++--- docs/spin/aio_notify_bug.promela | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/spin/aio_notify_accept.promela b/docs/spin/aio_notify_accept.promela index 9cef2c955dd..f929d303281 100644 --- a/docs/spin/aio_notify_accept.promela +++ b/docs/spin/aio_notify_accept.promela @@ -118,7 +118,7 @@ accept_if_req_not_eventually_false: if :: req -> goto accept_if_req_not_eventually_false; fi; - assert(0); + g_assert_not_reached(); } #else @@ -141,12 +141,12 @@ accept_if_event_not_eventually_true: :: !event && notifier_done -> do :: true -> skip; od; :: !event && !notifier_done -> goto accept_if_event_not_eventually_true; fi; - assert(0); + g_assert_not_reached(); accept_if_event_not_eventually_false: if :: event -> goto accept_if_event_not_eventually_false; fi; - assert(0); + g_assert_not_reached(); } #endif diff --git a/docs/spin/aio_notify_bug.promela b/docs/spin/aio_notify_bug.promela index b3bfca1ca4f..ce6f5177ed5 100644 --- a/docs/spin/aio_notify_bug.promela +++ b/docs/spin/aio_notify_bug.promela @@ -106,7 +106,7 @@ accept_if_req_not_eventually_false: if :: req -> goto accept_if_req_not_eventually_false; fi; - assert(0); + g_assert_not_reached(); } #else @@ -129,12 +129,12 @@ accept_if_event_not_eventually_true: :: !event && notifier_done -> do :: true -> skip; od; :: !event && !notifier_done -> goto accept_if_event_not_eventually_true; fi; - assert(0); + g_assert_not_reached(); accept_if_event_not_eventually_false: if :: event -> goto accept_if_event_not_eventually_false; fi; - assert(0); + g_assert_not_reached(); } #endif From patchwork Thu Sep 12 07:38:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801580 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C95A18E349 for ; Thu, 12 Sep 2024 07:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126773; cv=none; b=KePd/FZTGxV3O6wydjMUGSJvXAcQA+bKJ3KunwJwofHEpvtdjKzlWaT+G038AaEJQYtkJiUdEaqudIf6SdrKu7NKpFZf+YihqMZt8gSmZmzzrulNYbim/mEIDnXlMMN48hLg9XgUwlEAdLzaaWdygMgompLD0/eHIiUPJi6DG1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126773; c=relaxed/simple; bh=rPFF0K4jLKDHQLACOaTVD86anmS8djMvLcG+jAZYsZM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QVWTk7UrS+Bd8vKAapNrcwSmx0VEIVs2rhlP5CoAHIxxDYjOjsNqUai0LfyW7oQeNNF/3irWCgMbWV4QLystwdMouRMISiju7gr/UOnj95v/6iTPq7nBnKjnDZuzfmWRIA7Wn32pAIB1nM6jdDLgmEeJLRpdu4ZJ96rScKwncl0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QIw/G5Yr; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QIw/G5Yr" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71798661a52so478425b3a.0 for ; Thu, 12 Sep 2024 00:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126771; x=1726731571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WKzkwMvjulowmVZuCJWvk+8fDxucMHovajiMFoHCRQg=; b=QIw/G5Yr5+cPJFI8gRqJVZbriBA0pRnl2z7g8zWlqHh0+HZgwOwUuO9NDTpPZqp5kP AXe3seDKJZy3dH7x904KySVen73+ZT5gDH05Cv5oyOAJZR45jRN4BT27SEbBkDFaVOtE giU0Amy0Bti5YiN7OYCE536igjVWFiTuKutJkEj3FfvGUWTI+3xP+lAjWGLn2ofGojWP BnsW0KXNOkmeQncGSOLcRnZ29lyN78MlrJwdC5XjRt28OuTdr6vXyGkv4FevNVDn/F+y tCjf21L+y7TrXKxB3U5h0JRXPpDEI6TCQFw0jWhxqwaAQ1CAcZa5Uskjqo3zUciIxYyn 3u2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126771; x=1726731571; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WKzkwMvjulowmVZuCJWvk+8fDxucMHovajiMFoHCRQg=; b=cuUiyAET+shsU3r9l0AyFjSWD22jjKPo8jjM5NySymmtjNkpQlrCKWCHJNlZFCDzvM 6x24w+fidcojJ+g0aHfnINMJX8RtKNQmmjdV/yWiR66Otc7gGVWJR7b6i6eI8AzPjzEf X825wiFzqdvKWGOD18P1ZCGQVHM0c5ely8+mS0iPurzYlGF1URpfTaw/THxkt5ZhAhBn SxCpx0nWkwE9z9aMn2NO7ZCGGquO1969stScAFeU1fTOo3TtgFskJkH2wPKCB8w1cSFa pqAel3KH44ay4BcoQs7hTHk79ySQH1x7xRGlRHWosbBDoJxMEpDzrMXXN2SpOZI4E6q5 lsSw== X-Forwarded-Encrypted: i=1; AJvYcCWwINhidE9d1kU3GhpNdfa4qs+oT0dRuTR5MIBWgBl5KF8QVYR3AfbNTl9xW56v5y1HA3s=@vger.kernel.org X-Gm-Message-State: AOJu0YzJCG25m43HCHyMsJuthsU76pnHlDdfM2EHlDnIBiONRY/Evikf dRCA0xO2W3oeOG9GkFCy/1LaU5vbADhZqQeQLQfrwhv7M4TnYpJyAMXNmOQ8GdQ= X-Google-Smtp-Source: AGHT+IFV73zYW1Waxu/aZZ0kavyu0j3iUea6gq5xe8cf1PrugnTCL4VeCsbqhbUloiuceag0jwjTVg== X-Received: by 2002:a05:6a00:1803:b0:717:9743:e4fb with SMTP id d2e1a72fcca58-71926456829mr2983283b3a.14.1726126771431; Thu, 12 Sep 2024 00:39:31 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:30 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 02/48] hw/acpi: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:35 -0700 Message-Id: <20240912073921.453203-3-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6d4517cfbe3..006c506a375 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -534,7 +534,7 @@ void aml_append(Aml *parent_ctx, Aml *child) case AML_NO_OPCODE: break; default: - assert(0); + g_assert_not_reached(); break; } build_append_array(parent_ctx->buf, buf); From patchwork Thu Sep 12 07:38:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801581 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7BCD18FDDB for ; Thu, 12 Sep 2024 07:39:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126776; cv=none; b=gheEtXY59gjvs9pf9D7zz8n7YRB2u/++z38ElcuU5H+HfGbXMgKrYH5jOQyjmcdgSv9h0+zyh7GCel79AGycZIXuPWhndprkbn4lcVPhUupcSmW7TBFrcL089DI9rFoBFClGYOuU3BG/fU8pNQvEDERAWurU3e8ck8LCSrO7hi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126776; c=relaxed/simple; bh=Sj7coItM62qUP6D+eQq9J9uYeGn03mxADiz4qcIcsrI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BOTLwGqQstYVLvNR0sjaf5t6KSuDqsIHLaUl5MZKwsWIrKc1bTjoiJoySnb+oDX9h3833mgeUzBGvSDWI1451nV/ivJpFSUBhB0KdNvweE7RQ9hT0JknxWhYdx4x7d1r6GX8irIUo1wftonQXV76RG94mbHeb2TJj4oa5wOzwYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jUXLxxsd; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jUXLxxsd" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-717934728adso468118b3a.2 for ; Thu, 12 Sep 2024 00:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126774; x=1726731574; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7ty7Rs9QHnECV8EUUJMzVINdjzR9zKkzYj9QmIBEPQw=; b=jUXLxxsdNPL8wJzpUGQLs6kZjyPMWkOu9rkYyEc7jN55Ovixt8Nkan971T26Mn9yCg MHm0xpRCrBTNQroGw4kSnt+1LYyR72h/MOGDem+Yf7e4k2Ht6H4PemY2PIwyj1lsyLpg DvoAiL3BZ/0agtCV/bAtQlLWvLkDS8xGkm2PO+/gM6BPjEPDL272Ub9SJ0XzxvuwscBw UKvAsfw4BBAnwGBcPIFFyhf3N3o2jG2pyFP907WeCsAML47lOSMPGOrRZ/QrnJv3P2XH muLGyPY7FgkjA1suAoDEetqvL18X/0+h9W9iafQgBwkqNEDqJ+eDMX9ueNmCwAPkxnNp yvPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126774; x=1726731574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ty7Rs9QHnECV8EUUJMzVINdjzR9zKkzYj9QmIBEPQw=; b=Enq5xnPaXB8Z3ui+nxsRQ1gZI2655V+m57gRww44w2RurfEOJjpFNjdkvU5g0jnnXN pyiKx6sPi3i/5rmzcksM2qOXhnVKftX+wNpS1ia/keGH568y8z91bo2KR/jBfk8IpjiU HmdroCAIWnFV5bIFCbokLgdoO5Yapb9vOwcA6ZvZ2f228QhGs0Fs4nshh1uTBZJVC8k3 /tOToOvSBEJTTB0Z9e2kU9514lgjKLNfYvNHGSqPKpPGe6FQDebNfMpt2J5DqeIuC9K2 Db2dBROnV1IN4Czk6cjCylSKPL99T+DChVRc3OHuJnqHVUilIWgnmRQunYpHt/ZRMqPl YXeQ== X-Forwarded-Encrypted: i=1; AJvYcCUXfOxY/xWorAw/eAvp/ho98w4UNZU/wH4fRf6QS39OBRyLtbF66l+Wu/gB15opF1oiXvE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5pWoCIF6LZYvLIYCVNwDN4gpp6a5JqTr0GdnxlU5Z1xgOWpSk RqyrqlxcVl+DKMs6rQidPG9neK5Kbni+sJ4YSZFAHZ3Vhl8q1AcqScw48kgAcLA= X-Google-Smtp-Source: AGHT+IGdy27o3NWIMJUV1QTbS6arySwH8o8Z7I8EmJsXVX+I+rG8YMWPvIhqlvjs8uvVetmJE6ek9A== X-Received: by 2002:a05:6a00:1a86:b0:717:839c:6838 with SMTP id d2e1a72fcca58-71926095e9bmr2094282b3a.14.1726126773886; Thu, 12 Sep 2024 00:39:33 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:33 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 03/48] hw/arm: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:36 -0700 Message-Id: <20240912073921.453203-4-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/arm/highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index c71b1a8db32..72c4cbff39d 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -199,7 +199,7 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id) machine->cpu_type = ARM_CPU_TYPE_NAME("cortex-a15"); break; default: - assert(0); + g_assert_not_reached(); } for (n = 0; n < smp_cpus; n++) { From patchwork Thu Sep 12 07:38:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801582 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D27919049A for ; Thu, 12 Sep 2024 07:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126778; cv=none; b=jyJTYgG8P6x3ARbpwt8Y+F+SThjPZFoy8JMQuPrB6I9BjNmlFgzLIdHir8VL//U6QL2QhOG4JwLY1AEJ1c2W9tEzQbcmKaxTHbZEKJ0vcI9BLfUmzQq/hrNH/7SbARIt1YgTDcuy57PLrpleMUZv2LuboCkLHDE+/TDQ9xWlxcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126778; c=relaxed/simple; bh=wFUSxajtwSZ+PI8d24ODT73aKq3TzMRPJaCjR/1QcNk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=hlyAQhA2Qie5NfkJKtZfYUZMjxn+HH+MFwZ0RAzUyk0Tx0dtYEKqYQmzne5QGynSsGmgQQGQkCZK6jTvRfuYHHb9sVjzVDT+axF1Z+64BVPNWWJsYd+9VnyG7aDT3rB57d3K1fKP8FWFoeStfoNO7xNAwKkhrwQNbjhev35Uy5A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XC52f7Ls; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XC52f7Ls" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-7cf5e179b68so509000a12.1 for ; Thu, 12 Sep 2024 00:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126776; x=1726731576; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ecO/hlC3v3MEosBJkifBisWZ7NVSSxAF5ju3ujjbozc=; b=XC52f7LsGIqE1il+T0AZ3odG3/qRLwZSveFy/NSUH+0DcOmY+UbrL4Med5549Y0vyq CprwykPruTanIeeJcep+j/cAmY9coTkCBfDnTU0bx87nv2HUk1Q30bQgLikVxZUzq0hf sYz3Zv/cr3XZmc3GPMORJ81PZyT0lJlVtyTYG4ej4NA52OnBmDFNekvlaF06v51p7Rnf QObfuntsZv0UxyuIA1vcaQ4H1lWnix/azEiZsZN8jVjC+zjrsPceWvZ3r2EuW8rCaSuL emMhhV0NoMR0weCZbvmxhigO2pPqd1BoilvrWph0CedpDpDXEGeqjJBoR5R0BU4wHPA1 zo9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126776; x=1726731576; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ecO/hlC3v3MEosBJkifBisWZ7NVSSxAF5ju3ujjbozc=; b=n6dfKk8BHfsZZ4xbKW+9dUPv82U2X6FbONn6IzKGZGEl2NMgjld7fhdfRQsrAZbBIS EMKk1wskRLs0tmhwndUgbd2Bip+f2R+H/mv0nE0qHlTII+9OMR4FacmPMX3mKttpL2QA Vj5rfxJR6KC1MQjRxbi81xLKC2KrhLs2SdRibCfl1hory3OCWqss2YP1DhJUV/m+XX9R /BqUJMSbh8o35626jPoz+dte9Ykay4gtTOAMgwZ9yl4g3lQOi3NfCSVdINuTcpSKo6Bi l2aM5/XEyLSXYd9TFJ5Sv3yAfnqGwDxAZFidy1jlNaEmhJUz21PEXXy9mUqj8wirxDE1 DGgw== X-Forwarded-Encrypted: i=1; AJvYcCUld8VG1vQ8yXWWdMao8DbFn344ju8rKTXsE97MXmGQ0Voz88eLGW90R/Xt+w51yoEPJX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yws4sz8IMRBY3hGWF8/9yf+h1qPsZq923Fu44XhCgGZxhvMSuMw XwtH+Jv2Ceu7byXTwjJKpn48BFADij4ald18Sj63922MIryJ38K2eskB3BgTnQQma2Dd1a5z8CQ v1QGpWW36 X-Google-Smtp-Source: AGHT+IGWOkQDiFo4ViC5Y6sElaFJqOWW1j8ZfDmO3I52qr0gLqmLrSh4yCtDTRzacjd0//JBuuxsHA== X-Received: by 2002:a05:6a21:4d8c:b0:1cc:e101:ee64 with SMTP id adf61e73a8af0-1cf75599a20mr3182576637.1.1726126776379; Thu, 12 Sep 2024 00:39:36 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:35 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 04/48] hw/char: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:37 -0700 Message-Id: <20240912073921.453203-5-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/char/avr_usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/avr_usart.c b/hw/char/avr_usart.c index 5bcf9db0b78..e738a2ca97e 100644 --- a/hw/char/avr_usart.c +++ b/hw/char/avr_usart.c @@ -86,7 +86,7 @@ static void update_char_mask(AVRUsartState *usart) usart->char_mask = 0b11111111; break; default: - assert(0); + g_assert_not_reached(); } } From patchwork Thu Sep 12 07:38:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801583 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9490C191494 for ; Thu, 12 Sep 2024 07:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126781; cv=none; b=jRKssODO2+LFuD/B5bXClxVrPDOj4fr4g0+E6OEC0et5iu2neggFLr7VKNmdL3etvTDU1NlYQkgO7D/Qsi43kEqPlvB+dnos439NGEv/5xf9XtwKBd95X7/fy/S9+loAiDoWX1H/PacADoZJqaTUh4rWBKzIWiijHEcNkeJ+meo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126781; c=relaxed/simple; bh=zzR5V7UsJxbXcCEbgxsNTaIMw4zZwjNRz5mG2S5uCN8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=MUnSmjVYetM6rwONOGTaK7rKenEmNdqxT4vzH/k3Aw9yMMF/AVpRH4lFS6y0Jt05yrWCnE9eQi10OSvxwmrdIFZ81l8a3ApVBOqI4vHI1W7XqrxIUYv4/mbWdiG9lZN7SdF5qO7jqoLuPb4AIbnbi6lLR5rEn+8fTede012x9H8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e9qH+d9Z; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e9qH+d9Z" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7191ee537cbso486247b3a.2 for ; Thu, 12 Sep 2024 00:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126779; x=1726731579; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fLMdbuNc1S53EAbOcoLtqlHcp4TS6A8Qk4ILSrig2co=; b=e9qH+d9ZpLyF+RitrQK//ujOX9juiQGSgIa07Vvk5QXh+4KRxgZ3wzAwsleHr1fnpm TnhbNBxpLlkS0Upcucq9tK+QyR/22aHJPfnjGwmEQjWu1CDEyGhsZ9I+0kGXHxgBxRHP seIVLCcFJsAyCigK3gchf9GP5IfQzLDNTaEYB+sU+v/HeE3B0F0tfi+JB+ZoHce/POxV dpIVGUvife2rdmPE3r0IWg3huhcNkCtrPjQ8hkbDtUjJQsC7kskj7Y7w5Mcil8UgZPVu 28L/Vm5sDRwPcSS2HnX8xgt/Y3jsATDw3pwomCggP4x1LVWaAr/RnI+1PR/v4UFU5DPh PWhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126779; x=1726731579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fLMdbuNc1S53EAbOcoLtqlHcp4TS6A8Qk4ILSrig2co=; b=wraRlrENyA46uAYJ2BUC/VaAKLjeg8sViG+e2cV17CA3tMKrSPSVAyyhmjw8B/i1vr K3qF2cabwd3P2gJk6RyD8LQZ31k/Q+qSWoB/lxehCnZjN9reewkNiPOtt5XIBuiEyAtg c2tPq3AidR1rqBYbV8B59SFkxVIkfolUn7eeo7Ldwbnm1C/qu/os4aAunRomVDhZ5Ye4 Rl8t65pwJ/qfRJdli5c89NYBHCaiS9UA7m2IcOOCd2UZwQEZTt7q2/PAx9r3ijU0lHiG fB1AKFw1vJQcn2VvewHIrIbJ8jAVfkX4jzpJcFshIyYUBSZ+bYFxPtfT2AAB2sf+MZc+ d52g== X-Forwarded-Encrypted: i=1; AJvYcCVaf3ROrQQjOUUJ1GwbQLg/X1LSo0i/9PlG2uidE6PPBeMOBysBQRsPL1pucjX0o4TGDlk=@vger.kernel.org X-Gm-Message-State: AOJu0YxdmUlTW8nioUB9Mkb6ijuorpyq1Htau/iK3fD9WJqxzS7Cj96D rAd4aTe+5XWFKrVt5K6pSKVlh043/xxNeD5wGah7GhU/vesjTMJP/B9l4VxIBRA= X-Google-Smtp-Source: AGHT+IGsYfpgGMtUkJQV3ZoeaZnVF1kzOMAI4k+7EcIVricIQ5VNOKh5dVOAemjBCE1kuSKrF+5BOQ== X-Received: by 2002:a05:6a00:1883:b0:706:58ef:613 with SMTP id d2e1a72fcca58-719262066efmr3042407b3a.27.1726126778888; Thu, 12 Sep 2024 00:39:38 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:38 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 05/48] hw/core: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:38 -0700 Message-Id: <20240912073921.453203-6-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/core/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index fb81c1ed51b..1b5f44baeac 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -380,7 +380,7 @@ void parse_numa_hmat_lb(NumaState *numa_state, NumaHmatLBOptions *node, } lb_data.data = node->bandwidth; } else { - assert(0); + g_assert_not_reached(); } g_array_append_val(hmat_lb->list, lb_data); From patchwork Thu Sep 12 07:38:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801584 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D427D191494 for ; Thu, 12 Sep 2024 07:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126784; cv=none; b=uxqzz2mZWn1nMWI++w8W4OZgmqMcMZZP05LaYJbWF2nCLNtsVb4OzBphSHmoUaaZ/9lx/QImo79lUX07tn0qmQ0TqSDGSe8cWXHuTDyzZs59BOv7WvBWGx+5Z2w+b7cDPSAzT1x0bAzJpQmlKqVftXsV2BuKbHVqnQN/OLrI0iE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126784; c=relaxed/simple; bh=qec+CJuKMDjkR31fKiK89xRG0JoS+ilGKT7Dl+R8qpw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nGpvyZGnk1yLY8EIepfEIUPZKiWO3rD1xt5+Y1dBKChGccKO5+lLm+tj99D5/FB0Y58EmuSe3mevU6pbpi8SueJUCNtAfxxgr0nHvUp+7KQenBkgmutaiYPbcCewIcWNiOer70setNtipgRvJ32D74agsoSje/97mCdOaHrZiUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rN8I4EP7; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rN8I4EP7" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7db238d07b3so384493a12.2 for ; Thu, 12 Sep 2024 00:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126782; x=1726731582; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L7GDoQxngJ1TTnmtNF1SclRiQsQ/Y8kkCXT3xVb7e1A=; b=rN8I4EP70UxcNVSOLMkDKY+UKKnGIBuZbBKEzS4zaeUCUHqJ8VEU5t8GbdAtHb+iun pX/LkQeXWxYTgqyDIXB0y04dip1dbJTOfOHD5lniBOLI3o1lNhRJtd+5SgyVwTpCg4Rm yhavv4vCiecUtTocB2esOkxuPlFXTm42o9YRyrL5D2x/0P/DNHVfa2iCUVO/kY6ph4yK rhpa5PmqHCjffJMpmfJHvZboPilocqUrEcuxiK1IDLbDK0EKM9EzPRmT1MJ0mhj71ZiQ lACuYsMgs7FHlC5H6MTyzWRcPIchzSakBjuTAa5a8cYhkpBQDlcV0KL5x0UcYDERbKVG oHUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126782; x=1726731582; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L7GDoQxngJ1TTnmtNF1SclRiQsQ/Y8kkCXT3xVb7e1A=; b=eUZ3yn0QuXTt9MVSQtsR2vPKiaErGeQ/v0kcxRUe2nVUVQ+1fuUKQj/FeLVJrzReSu eujTRdtDs/RVumgDdMmHMaqcTb6r3G1TNfivDngroUGYXPML0oDRZOA5cqI4gSrpWjJT XtSLsYUsfFzcIy7hB32VQ/sYNIeqQuu4iAM9PxIc64oqY/ZGp25RkyDMSLq3N1Q/+0OD 8INpEh1c/nsYak40JSBHTIvFgAaarAloUPa5TLyPbFdRTh8yctP92tRs/tDGCVKNYKTe CUuZN5++PKtiFH4f+Ki9gOuQUc6/AWUOvaoQ/DwlY9NNB1DeuMrrhmRZd13QL8nQ4vRw U3Pg== X-Forwarded-Encrypted: i=1; AJvYcCXj+mcJCq/TTLktnCGm+Tr1r2s0fnNblpFB4ghFN5FSaQb/8rVTKbmE/Z+swb56g3MgaBs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf/wgprrbo0bQi+Hy186Jhhnyg4/MdNOESv5fmHMgLTmYQNIJY bvJS96kWrvRjcKtVqSlaiyehhOKBwX4CDyPfEgaF+K+ZQOmOgl5ryEQBQyOgZWk= X-Google-Smtp-Source: AGHT+IH3UrYHsROVRFhqbmUT73S4ww9ZnrBNKPSzdT/xlKGzi9rQl1GCamlShW6aVRW6SwwZUuf8fw== X-Received: by 2002:a05:6a20:7b07:b0:1cf:d746:22d0 with SMTP id adf61e73a8af0-1cfd7463553mr949162637.1.1726126782141; Thu, 12 Sep 2024 00:39:42 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:41 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 06/48] hw/net: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:39 -0700 Message-Id: <20240912073921.453203-7-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/i82596.c b/hw/net/i82596.c index 6cc8292a65a..cd416a00ffa 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -282,7 +282,7 @@ static void command_loop(I82596State *s) case CmdDump: case CmdDiagnose: printf("FIXME Command %d !!\n", cmd & 7); - assert(0); + g_assert_not_reached(); } /* update status */ From patchwork Thu Sep 12 07:38:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801585 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBF4191F62 for ; Thu, 12 Sep 2024 07:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126786; cv=none; b=sDhHv0D7TFCRCxViWR9uYUR33NaGDwDN1EygVQbgBwPndUSXXu032lCKPXpgTMOaHPkTlqSgnkZfDI3/7RtMMr6PHgEo2NtNtfHvsXdBaXEIftI5RMbzfBbOLONxECNtewQEI9cBMsDGG/E52LhUaUM/gT2aqmAdIutbnZGu1es= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126786; c=relaxed/simple; bh=6qAb7sWpCn5TQZoArQNa7V4gZJlYhCAnXB3dvj26Gk8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=Ehugi+O5qpZFLcamVDHAKW+Chi8xUCKCy/EaFYSy+3QIn2OCRg3r7GP4dAT9s+8kfRh7bAlaf+szdByMT2HQEwnMcE3tJhK+TrFXle4G6tYdlc2ZaS2108bPkc4wMGXUGZtegrv6g9aSMhnK3TbdNyFO/rlLPE2ts/92ogZ26jU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EhUa8Z0G; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EhUa8Z0G" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7db1f13b14aso632483a12.1 for ; Thu, 12 Sep 2024 00:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126784; x=1726731584; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JPBETK2XAIe21YqE62iAjxbH8O1+L7jgUq9LFf3cER8=; b=EhUa8Z0G7L1DKtNBeTiw51zicv5ZB/10Xu8sCq6LhHn41GPn+Vc1QS+eEhVMpqj273 AFJnJVAiD1w2gjXpjw8ViDIFCAkXLGojC59K4vnPMh1ES4yybQUoc7LlDiX7sG6U+DOR fOIiNH2gDfyfrUW9iLs22vJtrilL32gqAdE0IRWrJGZ7SQ35Zba3PGJ77YBrX7Ce0iYA NskYwUUplGWs9/VnOkHRvJuAmF8xEaOrBZoiWVXTflCqxglNQk6DE0lNZPZZSA0WFYMi LG1EOZ0MeO/Ve0V8Fn6/l+ahD5KDjlKP6qOH7DoROZuXPWGQ3DCJlulSgXU5NFHRVAGm zlwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126784; x=1726731584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JPBETK2XAIe21YqE62iAjxbH8O1+L7jgUq9LFf3cER8=; b=m3iO9XyNfZo4sWmp0Ji8qFTfx346Un7+cTxoMdLDWirgq6mjDrxwubVOue+hFnwiju A6yTZrr+3uwNP4PZk2Zt3ZcOrpgIBmoOSC/S2qOylH4nQ5my0W4mtFlhu79x3t0kDJel sSqhnU968QRyPivowsDKisEymMe3u8DkxZE0D5rm4Gnyhl3/2M4WepMXUWrWp30u1TVG x1uly/o6sj9nz8CkQLwKUWVKIqWZDl/b4yApLhgbyG4sCrX1ItOaUW6QTtWse1RlnocE CCs++0vjIa4LoQQ5mTK9fYlUMap/2XAQ1uw7V6ifd9KMD+gKU1Rq9o4xKIRApQUdOlgO v1cQ== X-Forwarded-Encrypted: i=1; AJvYcCXPJ+18JVlG2T4eUYRrJBJc0Uz4UQhnHSKM9OSr2Y7BraqwppLPbZ3iUD9dTj/n0t2V4mc=@vger.kernel.org X-Gm-Message-State: AOJu0YwiJP8FQBcrGu++suUJyCssTMtyF/g4ajzbHlVf/Pp2F/TCf9yU j+Q53S5MmUihbvOAPkigFqhaZ1dl90iTuAqa+G/Y+LPryTbFmVkIqriayW0LwM0= X-Google-Smtp-Source: AGHT+IE8nod63m/5RXrta+YpJQqaG3YPkY5+/q44EiQGD+6nDtI41YYUwLPx+yvQ/t0TsoamRCJlww== X-Received: by 2002:a05:6a21:648c:b0:1cf:354e:93df with SMTP id adf61e73a8af0-1cf75ec5406mr2741834637.4.1726126784600; Thu, 12 Sep 2024 00:39:44 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:44 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 07/48] hw/watchdog: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:40 -0700 Message-Id: <20240912073921.453203-8-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard W.M. Jones Signed-off-by: Pierrick Bouvier --- hw/watchdog/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/watchdog/watchdog.c b/hw/watchdog/watchdog.c index 955046161bf..d0ce3c4ac55 100644 --- a/hw/watchdog/watchdog.c +++ b/hw/watchdog/watchdog.c @@ -85,7 +85,7 @@ void watchdog_perform_action(void) break; default: - assert(0); + g_assert_not_reached(); } } From patchwork Thu Sep 12 07:38:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801586 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BE37191F6E for ; Thu, 12 Sep 2024 07:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126789; cv=none; b=PHDTW1XBPz3Pomq4pWqfZx+qQ38z3a2KlMqQkz3ZozPtKSAW5vdA0LpdHWbN33bFvuKJm74kXLJerOsqeo3HX8JkVp5dOSlmRwfJayIbS5L6rsD7XPX8p49WZo4/alol0gH99ENyUnq2Bvec/f0B0m/R9q+YOn1cNy4E6K4ADSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126789; c=relaxed/simple; bh=XKcDNmn6XizW/gf7GqH5IzXaS1M/YG98kJBDWDnv8tc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ecmo/pg96hve4KJi8eJX5YqJmK96bQouZXgJnplUlZIMOKLHy5/j55zafocD1q7cwMIec5KYrlTlyTAg3vO3He9nxpuHD9g08ttME7wX8Zyv0fWWPy5iuAgUdd14/TJIVytPsYo7bRvFD0LBaQXhdvm777VmTrbgDH/oluKyAsE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L9j8Jerq; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L9j8Jerq" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3e04b7b3c6dso331498b6e.2 for ; Thu, 12 Sep 2024 00:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126787; x=1726731587; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KmOJONIVi8Rgmcdj3MpwvRz35OjK70IjJaXWHbl2cKY=; b=L9j8Jerq0UxADpGCC9maMg/zIrm/kLTGMQqZWAhCMCoEz24RThsJxQxzE1g+hcslFy nejLifeKUpLL0B9Evz+kGOkBM4P3axKODJTc9JHVlXBGFh5Sgula2VrhOjo+kPTIO+sV aeZcuERhXDIzxVpuhdxLkA+iy8zZ7JLwozSU8jRXDGI4sNFxeEEUJYdLZsFs8X8qlWjN ku7UuAg4fWB2VqXgU+RHfNOQibARPYkVJKAH6uTqPuDpaAcQhAF9iDuX+sXhNYcz45l2 Pxa9urIATsSpwBLwPCelGa0Kj+bpGuAWMw/9DWOHPXyRWP9ipGb9mra1JYjwVNXaVq4i WNBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126787; x=1726731587; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KmOJONIVi8Rgmcdj3MpwvRz35OjK70IjJaXWHbl2cKY=; b=XGu9dSCuldqcdo1f4hgAHDDCuc9bRp1NlLn35Luvj1RvqXhm2EAh/xdjhAkApy6YAf fSMo+TBH8YqCZzdFAhBIQMza3aLh6GQ+ZbM9iRCs4Djur62ATbUgm0NaEc/nKm8suheE FL6AE5x0vo7m7w6vy5S6w2kbNgUwkcv4SEDWoMQaaKmWKp4zhAUx2j4DdjQ4QaANzzDj 6kCO2gIy/pPe2gtWxg/x9sg4uE2kYBx1zH78DFkLumEc1AyVnhyjgF0psH+FPg5G9wKk U32moBSAhiZMx22Vg/y3ASjKXZLd9LiICWJGQgT34Mtzgai0pYC1QNoZwiYZfVvn6Rwu rmtg== X-Forwarded-Encrypted: i=1; AJvYcCWR7FvlABNyVyJWH4SRPJrF3ub0xMCnkYxHlRQ1HjS03cMtic2keBLZRtw23IssV4ZVOcY=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ1uI8RALjTZYHitr3eLXCzzDUpMUCPdQT9zallEKDsAFqoHsU wgQtzlvbqNrm49rdfFmqVRZPn38oRI9XdggkaKnZkZ6dnArFBhBJyt3bBh/JlaA= X-Google-Smtp-Source: AGHT+IHQmwwOBmli4W+UYIBuLgmtdhnhoMM/mefW6Mu1WXJhmB0TUFR0xhKaZNkIkcZOjB8bVSAq8A== X-Received: by 2002:a05:6808:309a:b0:3dd:3d77:2774 with SMTP id 5614622812f47-3e071b29035mr1047445b6e.43.1726126787067; Thu, 12 Sep 2024 00:39:47 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:46 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 08/48] migration: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:41 -0700 Message-Id: <20240912073921.453203-9-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier --- migration/migration-hmp-cmds.c | 2 +- migration/postcopy-ram.c | 14 +++++++------- migration/ram.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index 28165cfc9ed..20d1a6e2194 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -640,7 +640,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) visit_type_bool(v, param, &p->direct_io, &err); break; default: - assert(0); + g_assert_not_reached(); } if (err) { diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 1c374b7ea1e..f431bbc0d4f 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1411,40 +1411,40 @@ int postcopy_ram_incoming_init(MigrationIncomingState *mis) int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_prepare_discard(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb, uint64_t client_addr, uint64_t rb_offset) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_incoming_setup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page_zero(MigrationIncomingState *mis, void *host, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } @@ -1452,7 +1452,7 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd, uint64_t client_addr, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } #endif diff --git a/migration/ram.c b/migration/ram.c index 67ca3d5d51a..0aa5d347439 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1765,19 +1765,19 @@ bool ram_write_tracking_available(void) bool ram_write_tracking_compatible(void) { - assert(0); + g_assert_not_reached(); return false; } int ram_write_tracking_start(void) { - assert(0); + g_assert_not_reached(); return -1; } void ram_write_tracking_stop(void) { - assert(0); + g_assert_not_reached(); } #endif /* defined(__linux__) */ From patchwork Thu Sep 12 07:38:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801587 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E22191F8E for ; Thu, 12 Sep 2024 07:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126792; cv=none; b=TB1ev1eVqkJHXokCpN+/SqOHSK8sDY70S7BWSjlq79XC+QH5BKqjFarZiupX0R4cLTHaThOF8Xh6FTRJ5jDYEhHjlDD3N5adaOBBOHSOY+OPe7bevMrXwEGm5eU0RlniIK953IQWUdNSRY6Eiw7sxe+fO4AYdEb4dHg+twiVsQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126792; c=relaxed/simple; bh=UYtppdslI+bYPL1y07sV7UHsm9O1TPNWp1iYCz1LPog=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jejt1eJMIzrLMc4kogMCyIVfIU4pW/gr8fMfWWwv4NN2pejC7DIzToZlOnJulazNFNwy60yhbuZggBI3gMQbvxhz6uBpxaZ8BEAkfBdzoDF0cUatuI+3BECsko8BrVUrAQSvpUE2aWx+7DPorucV5p2L6ecC13iFFGicQZsz768= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gvS1+ZuS; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gvS1+ZuS" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-718da0821cbso489793b3a.0 for ; Thu, 12 Sep 2024 00:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126790; x=1726731590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CoLCWKN35Kx1zze7qPnMX6nUM44hrew4lUqaYQU21Hw=; b=gvS1+ZuSFylJjMLDvztog/HBjlRpYNe6Z5RyL1F/p1iz7ohyqyb628tdHdK1zRhNPP fkG38Q6I0VS8LDgI88E64Zb0LB5PWvkuFRNk0YpV54xRU71uvhw85pK5dgqIbkNz5DN0 WYUDyOyvpEuxtQhJWUjVY3Tyx6BQlXokrdGwViSUw5pajwm/fd5qe2Sa63wloqtwUFju NCzMT6nOYLVu9k8PGlym9tL/CpWw6kPCCU0vDbvX37MTltWTOqDqwZsak6Y5GqLCqaMq 5JIlWxraJhyFt+7AE/puNXkynh9E4TDyusCELldXW5q2bx+CUG6/9sUI9xTQzQIFrxz9 H6eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126790; x=1726731590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CoLCWKN35Kx1zze7qPnMX6nUM44hrew4lUqaYQU21Hw=; b=KUrJEwPgTR0T1rMG1lUPalWv1vG8rjd19wc5aUGBkONmrfKcrBecEME7nePpt+/BgP IgFB3rIyhArqdNNgqzI1uceQDq2MmI6jjphvB+bKIWEWDBH8ZkuZpNygaOvdDLuN4cnv LqlVfsk0mqehl/Lm0q669cA/WmRu3i5APcFgHdO7pvTo+jT5vV9rZJN1CsX5bM3T6sZu peeTW4Agvx3rcWD1/rq/7ThJnCTzlZcqD5AwAbB8fcPgwY16sDSlp6eCJTpTkcX6nz0W g6mekga2yjfwKVas9xeBWe78RFNy5biKXB/5CMfVFOsF84qwhEfT0eQ65CllgKP5Mn2q C01w== X-Forwarded-Encrypted: i=1; AJvYcCUJJS8ihPavqZgOCKww6heRzg0BoDXKIcdS68L9ooZiHhX7Cp/tPBseMDI3u0c1aoRih2Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy+DTUlftyu95qwlL15c724eWiP2KGgase8LUjx6JqieujPHrp 8vQAbT5K8Apyg73QU00qJVZm+Bzn3+sY7llKYiE4Bjz4SdN/DAI9izBXoWIZYS8= X-Google-Smtp-Source: AGHT+IE0w+LZngOafibQdFlnRgSn7EWh+CAdX4bvMvefU5tar1r2kJCPjwqFlGTA67eF851XZaN0PA== X-Received: by 2002:aa7:8895:0:b0:718:da06:a4bf with SMTP id d2e1a72fcca58-71926067e21mr2772666b3a.2.1726126789771; Thu, 12 Sep 2024 00:39:49 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:49 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 09/48] qobject: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:42 -0700 Message-Id: <20240912073921.453203-10-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index be8332136c2..a62865b6423 100644 --- a/qobject/qlit.c +++ b/qobject/qlit.c @@ -118,7 +118,7 @@ QObject *qobject_from_qlit(const QLitObject *qlit) case QTYPE_QBOOL: return QOBJECT(qbool_from_bool(qlit->value.qbool)); default: - assert(0); + g_assert_not_reached(); } return NULL; diff --git a/qobject/qnum.c b/qobject/qnum.c index 2bbeaedc7b4..2138b563a9f 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -85,7 +85,7 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -123,7 +123,7 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -156,7 +156,7 @@ double qnum_get_double(QNum *qn) return qn->u.dbl; } - assert(0); + g_assert_not_reached(); return 0.0; } @@ -172,7 +172,7 @@ char *qnum_to_string(QNum *qn) return g_strdup_printf("%.17g", qn->u.dbl); } - assert(0); + g_assert_not_reached(); return NULL; } From patchwork Thu Sep 12 07:38:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801588 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 779151922E0 for ; Thu, 12 Sep 2024 07:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126794; cv=none; b=pH+/CbCRMjg5CwCYsbf1SYUjw7uIh3bmggJXhcAa0gJxBeJAJPIMGnLA0TaZyX/2wZwB3MgLyE0E4AMK15iXtPwLZ0GUa0B7TESqIeMkSG2Wkr8fADWlWTjRs1bL3115YokJheuEYb9oGD5fue2OWJV2vk0NfOckLoRplyynemU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126794; c=relaxed/simple; bh=yhNry/CHODzz/FBsWk1vpsMIAXL6cGf+oMKxPRAAEVM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=jYWdnp1JaaxU8AnGjOMfcPSdQqzEB9iHqBQJ+BR5uASbCwiA88a//eW42h2AqbcwWKwVEBNP+UPWo/+1AJf6vb0DiMwsqr+yCsqfpg2wG+Dbcn9tzRZqYhgv2qNhYkSm0rD/bbpdpXWYmLWJTfG98zzmI7yBjm+02uwq0DIw7rs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oeQVgxNX; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oeQVgxNX" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7193010d386so92493b3a.1 for ; Thu, 12 Sep 2024 00:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126793; x=1726731593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1LH7RZDNr8Bem+cpDiAWWDNCRvN8aqG8ZgQstwfOCIs=; b=oeQVgxNXPQJ/hgSjrz2hX280ttk5lQDtTwajX00eUJheT/o5/v2Za2aN067QREXg8E nI0mhYXfcH5bg51A5swJhmAVUlg8vVCdo67AoKfwLY5F7xh31ww/MafwEXO6tOcNChFj 7UzLfLblqd8Gbs0BfrTMqVsMZCTjCTLsNEqwVkiV8j1B8sAGAy61o/q46Fl8ZUhJlmyY Se+RN+q5lBW/CY6pMB5toWGXzZE3AhREa3OulFGdCw2Sxx//Aqp+7qNmk3+mxt6iiV2K sgJKuOpGGPls03iae6i4gCpK9mrbQHmYDVUxioWh9siscg3yCyTlqCgCPEA50qLx2yMx GuNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126793; x=1726731593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1LH7RZDNr8Bem+cpDiAWWDNCRvN8aqG8ZgQstwfOCIs=; b=ozWDS8Nk0Nfx1GAZGL5koXfaPo0+KMsJYDKuFAuPLFG0oLsSuL54m2xhWfsFEYVg/a 8BFMJOKXWGmX34pQ8PfB2TMwIwGdu0ipqzsYNraQTAG911gJdiTKgWze1EnfmOjxawm5 pgTNN2MUxD4umNaaOmtKxBAO7gxuHLBE8saRJn9pwRYOK1e4aXQxZILv8LhjUUFzCG9r /BKVJeKu7JFCTDtrAaQPPK2yy6LNe3h2JRt3CPuZxW8YEcBP6zq5h8pO2yoxGKRvwsUI CKRIJPKaDvBG/ARvYz0E85czWmPdBmFY4BrJhh+liZzuGBv76RBl8mWotyEmAj/4hsma bjPQ== X-Forwarded-Encrypted: i=1; AJvYcCU+Z8cyERFOanNAiIJ/YGkhU02Q5xvtGkq8TmXtLd4YzEW0Vouu1E1FpR9l7yez28mxL9A=@vger.kernel.org X-Gm-Message-State: AOJu0YzMPvwB2g7xSLsNdAzpSCwuXXAHCxZ0n2fTLwyQ1irBlqsVU0CV aZWiSrYhAEGk2OcIdpxP8CUkVmsqQQrpWEA4LlTo9mxbQ07ML7MeVfKOZ9ApCH4= X-Google-Smtp-Source: AGHT+IHO/OYYyb0vxtmPEDD5VDcNxDdhzKA5t0NP0cSnDTfGGp5wourxXyyoQSgKxB6gKjLR2x0CeA== X-Received: by 2002:a05:6a00:ac2:b0:717:8cef:4053 with SMTP id d2e1a72fcca58-7192608fd96mr3206049b3a.14.1726126792521; Thu, 12 Sep 2024 00:39:52 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:51 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 10/48] system: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:43 -0700 Message-Id: <20240912073921.453203-11-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- system/rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/rtc.c b/system/rtc.c index dc44576686e..216d2aee3ae 100644 --- a/system/rtc.c +++ b/system/rtc.c @@ -62,7 +62,7 @@ static time_t qemu_ref_timedate(QEMUClockType clock) } break; default: - assert(0); + g_assert_not_reached(); } return value; } From patchwork Thu Sep 12 07:38:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801589 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B261922E3 for ; Thu, 12 Sep 2024 07:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126797; cv=none; b=IzjqKDFOKeRbRX5ACJFeZnrv6ZnwVwhfHuPfifb5CWnE319INgBJAhHYlOKvvE2pHQ7wER2Of2iFgmgyKElMXXLdfdP0dD1ypl91rBXXYXPHafiuEAyAhEdbrsqK1Dvse0ekFBUkW9S0RdaBNuhfHzf8efV+qmvNLfFc4BG3xqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126797; c=relaxed/simple; bh=pj3bjl3Vf5F9ih6rboeaqBqp2b5Xf0xp4CoCS2JVczo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CRJoiXKTZlcjZj/zACyKaNs6x7eo5taBTvtUXi6ntpUTmDvv/vvd9oajN0m5eQKt1NEPKndKSnWR2IW7AvAf2kQcaLtn1qnBDkoGUH28OH4i/lkEn2tvBiYejSoXsObnZ6/WMiS26NCgrUsPA08PFmlyWnU3oNI2VZ7ooWkOuuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VFMqX8sz; arc=none smtp.client-ip=209.85.166.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VFMqX8sz" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3a043496fdeso2521505ab.3 for ; Thu, 12 Sep 2024 00:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126795; x=1726731595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gl+JcJWeB9n4U9owGQI4EbvNVAnzvdcJPjSOFH/LTqM=; b=VFMqX8szMpbxOfvzQM7ClVOsJN8XTTvrzJZXxwn+8mRPYmzIoFUJjw2ErznswgfJZ5 6Wm1X3k7VKLhRZxLaG//U2YYpOnqmnnJN8AKej2mRpQKgupl4OgOeC9ANAtc5ae3D1+F j0OuWE60MdsGB6EhCOidV4HiUjzLQyUYyHvriS8LwX2uKMiYMpxqSnMjI8f59F8fzarW CyI12CTD33KeENnFPIl/C2z4LLsrrJR/ZA7qKkODgF2cI0sBzujZBjx0fPKHQqiEJIFP +lurbUKGCiMbQufFAD8pQJmbIYrFb6G6doStIm4/3RZNGxc5WwJYHkOGcYzAeJS0Gsa2 RTIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126795; x=1726731595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gl+JcJWeB9n4U9owGQI4EbvNVAnzvdcJPjSOFH/LTqM=; b=aJ9i1/rAey8AfTaEc9V54nRY+OpZqbxoUtR49+Bg8qqQIDo/ZfYFBVLYuRn9MyMK4k 5UZCHhhlorwHuxy3bKEUCf+1ldVjHF0zgNOtoIPcILXk2PrrtJHQjBYLm20e/Qkm7u4d yx+lVhp994MFb1iZjnT2iMjnq26RDaCUCVfZwh25HXYJxxOkGekD/KkayhbahtwLkcs/ frCX2fLkH5RFXuE0A2spuTdwhUVDMYSjSNUzvS7dJ7R3Gw8z2HLniO5JeBMY/3EzDNCa dvPOtH17buKEVF0zq+qjwWGNPCuIa0W7Bd9Dfdg5RR8RDXC1KQ/s8OeMSrwYM7BmbbXz 1I2g== X-Forwarded-Encrypted: i=1; AJvYcCXw4BTT7INKB/07BiILU5+BxwOZgS+liDYQOnp/5ol2w4zUbd2uaCBftn45M0Dju7dFCNM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj4EOEat9BHrzR/cmhfZlw43MdGyjhD6tlI+/9IHtsjdjrVg6v UUPH7xViTffvp5EpxYP3aZ/yzu8mo/4A0dOEVJAdWGXnovWwVbcASApKcxQP68g= X-Google-Smtp-Source: AGHT+IFc2U5w+P2/p0zo+AVbvStN+97kW37ZvG1bComHgG1CrEqJE1viLz5YY6RVesmsw9//+xNbnQ== X-Received: by 2002:a05:6e02:1806:b0:3a0:1828:31d9 with SMTP id e9e14a558f8ab-3a0849736d4mr17121295ab.24.1726126795091; Thu, 12 Sep 2024 00:39:55 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:54 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 11/48] target/ppc: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:44 -0700 Message-Id: <20240912073921.453203-12-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/ppc/dfp_helper.c | 8 ++++---- target/ppc/mmu_helper.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index 5967ea07a92..ecc3f793267 100644 --- a/target/ppc/dfp_helper.c +++ b/target/ppc/dfp_helper.c @@ -249,7 +249,7 @@ static void dfp_set_FPRF_from_FRT_with_context(struct PPC_DFP *dfp, fprf = 0x05; break; default: - assert(0); /* should never get here */ + g_assert_not_reached(); } dfp->env->fpscr &= ~FP_FPRF; dfp->env->fpscr |= (fprf << FPSCR_FPRF); @@ -1243,7 +1243,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if (decNumberIsQNaN(&dfp.b)) { \ vt.VsrD(1) = -2; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } else { \ @@ -1252,7 +1252,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if ((size) == 128) { \ vt.VsrD(1) = dfp.b.exponent + 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } \ @@ -1300,7 +1300,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *a, \ raw_inf = 0x1e000; \ bias = 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ \ if (unlikely((exp < 0) || (exp > max_exp))) { \ diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index b0a0676beba..b167b37e0ab 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -316,7 +316,7 @@ void ppc_tlb_invalidate_one(CPUPPCState *env, target_ulong addr) break; default: /* Should never reach here with other MMU models */ - assert(0); + g_assert_not_reached(); } #else ppc_tlb_invalidate_all(env); From patchwork Thu Sep 12 07:38:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801590 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9D9C18FDDE for ; Thu, 12 Sep 2024 07:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126801; cv=none; b=TNX5i4rusQzmgRggPAJJWgMwI/RfdP3nU4sgcbrclKTsPS7wuYkngdbVZ4CAMJdhNW+tiKZk56Nkqu+4u2NgiabvokjOcLUm/u9w4YQRzm5AhKkuwrGsemWLutiOXPf1OMLOHFwq/2TMFOayNANBS9nGPpl2e2jupCqeIvz7zMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126801; c=relaxed/simple; bh=PhZK5jB8AGwL3Dlv0BhUdpfkS+HADWChfqJRb4K3skE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tVm24yXcL5WwCmAfEAPQdFgpp4RwfNpP+jTh8VXm032feB8o9lsxikTfPYLkKetswadA4p201cpP09V9AzAFIO9zm6yujhb8YlUkNw0Nktr+I+x8QCgZE4BsJHR3K1lwJnTHLAG/ke+jzHK8EiCaGJZFE1zXOuTLuQopetM7D6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=j7sV1Fqh; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j7sV1Fqh" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-710da656c0bso235536a34.0 for ; Thu, 12 Sep 2024 00:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126798; x=1726731598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/E70KJJTPx2V75BYTTVlugDcxiGJ3PzFoLEiBX1aDhc=; b=j7sV1FqhTE4Nqy8h0xrxGU9XgX36n42LWilGltEUisefnL/LzDL7uCpr/imzv4O2fU fG4bgwND/HV/yYW0GpmkCGMB2vGxURVVrlik53cgatEPqOq6Ho5+SSUTLHb8jng7M3uw DClzoevD6eyhk4ybCd1mHPGQHmkV1te3MKVdDKx5AvP9MeH/sMazGCnCvehQVec4curt r+BYKcC0/CIYETm/mpmd8+bcUODDSSemrIz/TTnv3utHkeq+ZT0I0pIU6s0OBcbIUgW5 Ko+7vAd+0hAvqKSupb6RNq6nPVhmmKGfHGhDsOARxvSv8r+9kRqQ7wRs0ZywpxyQhJn9 4WLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126798; x=1726731598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/E70KJJTPx2V75BYTTVlugDcxiGJ3PzFoLEiBX1aDhc=; b=V7fGEsZRiKIs8PSaReMrw6ln8Hv93MnMs8jVyeEseFgPah8OwsqcX+qPVqMM7J/Z9R ghc7eu/B/ecr5hrlO1RIeMLxDjTIoZVw3JVs2eTW3nyv1H8rvnXE71OyDZMwkgAj38IZ mtb9xW6JEwN4un0Y8EHrazLxpptUqbt9LeYOwA13qYCIeVfxhq8hmLaaOe393ux1QWjr HA41CBTWQBCteSFUCLaA/VM8MnFKGjb1tEp6xJANxq5xG4OOIUZ9VMexdxENjyr7uwBB Jv4DdQR1/dC7AY9X6kZCCg1RixV/TbXnhYAcZuc/zs3OZtqGqU+uZoRlnk5eIVPufALU 9akw== X-Forwarded-Encrypted: i=1; AJvYcCXc0MswY6LoMP5phdFV6gGkouAks1GiEPi2EupTxUt5ij3/JIQ8f9bI6+Sye5ssYR/35Z8=@vger.kernel.org X-Gm-Message-State: AOJu0YwH0SminX3quqDyljvdZostGRAwFGjhWQlJbWDbLG9EVTF/YvM/ ptu9f0lJI/tvMJTKewuutsTXnbzNPG9u5xGj4MmQK3GWLJ3Q0HVL6P97xtiA1hA= X-Google-Smtp-Source: AGHT+IG5ne8GTfzcAIBppwGJ8l4Yooy0KY6YC3wG/455mCNEr6eNEp84R9bb0cy5D5sMvEwevLyaeg== X-Received: by 2002:a05:6830:d02:b0:710:bffc:a28e with SMTP id 46e09a7af769-7110949a084mr1707232a34.19.1726126797795; Thu, 12 Sep 2024 00:39:57 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:57 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 12/48] tests/qtest: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:45 -0700 Message-Id: <20240912073921.453203-13-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier --- tests/qtest/ipmi-bt-test.c | 2 +- tests/qtest/ipmi-kcs-test.c | 4 ++-- tests/qtest/rtl8139-test.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c index 383239bcd48..13f7c841f59 100644 --- a/tests/qtest/ipmi-bt-test.c +++ b/tests/qtest/ipmi-bt-test.c @@ -251,7 +251,7 @@ static void emu_msg_handler(void) msg[msg_len++] = 0xa0; write_emu_msg(msg, msg_len); } else { - g_assert(0); + g_assert_not_reached(); } } diff --git a/tests/qtest/ipmi-kcs-test.c b/tests/qtest/ipmi-kcs-test.c index afc24dd3e46..3186c6ad64b 100644 --- a/tests/qtest/ipmi-kcs-test.c +++ b/tests/qtest/ipmi-kcs-test.c @@ -145,7 +145,7 @@ static void kcs_cmd(uint8_t *cmd, unsigned int cmd_len, break; default: - g_assert(0); + g_assert_not_reached(); } *rsp_len = j; } @@ -184,7 +184,7 @@ static void kcs_abort(uint8_t *cmd, unsigned int cmd_len, break; default: - g_assert(0); + g_assert_not_reached(); } /* Start the abort here */ diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c index eedf90f65af..55f671f2f59 100644 --- a/tests/qtest/rtl8139-test.c +++ b/tests/qtest/rtl8139-test.c @@ -65,7 +65,7 @@ PORT(IntrMask, w, 0x3c) PORT(IntrStatus, w, 0x3E) PORT(TimerInt, l, 0x54) -#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert(0); } while (0) +#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert_not_reached(); } while (0) static void test_timer(void) { From patchwork Thu Sep 12 07:38:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801591 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4380E190047 for ; Thu, 12 Sep 2024 07:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126802; cv=none; b=H0wwyd55WMdLvC13EKR4j66LFy2ggwsB9FZlI59mlq1Hd+KHKNiDykiehspmQYxyeE0D4WLvWzq1hMpzc6cXf9zPd0mrk+a3TYwsAjKRa3Y6v/5KH14unUY/P/V6mgtO/+1GixMM3NnfG5RwlVYZesqj3kDJ+ImSetM+KmtoDfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126802; c=relaxed/simple; bh=rGwr1vUCHvqHW+ILBB/ASnMP3I3a3rFp9bAatKHlp2c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rRxVLlBIrd080utu6dO3EhPfzh2LMUgOXD4hmXkzpDlLK1Mb494tpYzURJrbItusC9Xy99wrZc5Yq4eHkh7x/C7an6gbxfG4VmNOgnnVH8GUrWPGmCDpwSIh8pBkUqUvcvPjm4nrURE2Pa/s1sSaOma2zht1JERIFUjWptyvsRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Pm2CMFAb; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pm2CMFAb" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-70930972e19so185995a34.3 for ; Thu, 12 Sep 2024 00:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126800; x=1726731600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F+rVp3/BLJYyjxO33P6GwzzAqjbQ85NDH2br5JtXUaQ=; b=Pm2CMFAbgs9nRVC4e1o/NmmcButdVZgIoB/V2Zyvn57HrTvmgEVs9M6pDavNCJ0qjH BCSKdn0n0b4ZHlLM2ZQ2Q6XAvuKlhZpARBmh15yO0fea31OjlliOj6h6CsQLpzmM+Tn0 RxnqE47ESAdPRcvVd5/hy3cD2jrknuH44A437+7CVQ3GmuSHQ0hA52ADP5sFEgoSSoCl 9OpoWLlHpXEx/uCtlej9RtQIXED5AXSQyRC6oEnoxbcn9HTD0hKRis9Y+G90taTiZmZK P0bBgXhvytWaG3O6yM3W7/DyhxyRSS5Q2cox9HbTnjUHQJhP0asaV7Ex0YUjPkoueG8a lJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126800; x=1726731600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F+rVp3/BLJYyjxO33P6GwzzAqjbQ85NDH2br5JtXUaQ=; b=N+dUzA461DhwGsM5IqtmRSn+gJJZIgnCluUL7FVITtZv/jpFWs+Dmnf6NTuUX5m67S jT9B1Hm97+XoKZ/kTIYjx6s3b4+fpy+0M2YjYhqz8nVF37RarYwSjjs1obgBQDhF5GJH 3Mp6P9fHEywO50AuRg+vP+H1lboR+vI6krsrKBner3mZ8s/puSiXGI9U+i0QW/P7RW8K vQe3Yxp955XiszrTPXFJJRM9+e5yYqoT1Cpy7AcnO0uCbWM7gjCkyVUOw8iUk0pK0MPz 6fFk/eITqZjv6fnfLQsiMAXLEsglpW0tg59cqPsTCu4bvt6x1fnky1yOeXMi+2vUWCrj Xx5w== X-Forwarded-Encrypted: i=1; AJvYcCXSN+3JfC2j++YdJTUxRre3hxmXSTgqNXuanQZ3HDuLWJLA4WXpQLP7Roz3d1dDtHt/PqE=@vger.kernel.org X-Gm-Message-State: AOJu0YwkXAaittE7YFOOeKrPNaW2MKMNp0UKeyrDbWlw5T1s7cdB8CBk VXo16H9ylg6dL2sXlb/8YvrzriQY9KU0/B0tLRFFFz9ojUWDgM+dNDPhMq2BXgs= X-Google-Smtp-Source: AGHT+IG6+n9GSh9VOQuGu9AiTjxnE8dPu+UEy8HMFEQWjdljbFKlQEVbTyzIuHmcncyWJBtD1Vjx6g== X-Received: by 2002:a05:6830:4994:b0:710:b19a:cea3 with SMTP id 46e09a7af769-711094727c0mr2302235a34.13.1726126800291; Thu, 12 Sep 2024 00:40:00 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:59 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 13/48] tests/unit: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:46 -0700 Message-Id: <20240912073921.453203-14-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/unit/test-xs-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c index ac94e7ed6c2..2f447a73fb8 100644 --- a/tests/unit/test-xs-node.c +++ b/tests/unit/test-xs-node.c @@ -212,7 +212,7 @@ static void compare_tx(gpointer key, gpointer val, gpointer opaque) printf("Comparison failure in TX %u after serdes:\n", tx_id); dump_ref("Original", t1->root, 0); dump_ref("Deserialised", t2->root, 0); - g_assert(0); + g_assert_not_reached(); } g_assert(t1->nr_nodes == t2->nr_nodes); } @@ -257,7 +257,7 @@ static void check_serdes(XenstoreImplState *s) printf("Comparison failure in main tree after serdes:\n"); dump_ref("Original", s->root, 0); dump_ref("Deserialised", s2->root, 0); - g_assert(0); + g_assert_not_reached(); } nr_transactions1 = g_hash_table_size(s->transactions); From patchwork Thu Sep 12 07:38:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801592 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B571925BC for ; Thu, 12 Sep 2024 07:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126805; cv=none; b=Oy9S5omBBsV/8EvHT6Z4IW49GyfcfsQMmGTS6exTlw8b760I+qqtz/2DBtEGqU2kG5tPIYyle7IAl0dq02H94AszjH7AxeU5ni0bAsuiXVwfYRm3TPrcBG3QAXXSoxzE0uLaQMk8x1MBbqonj/MvZ1kikzvYRqdeXuPPnSwKMNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126805; c=relaxed/simple; bh=Tsn24Q2zqOITbsqWB26jmhxj+NilzFUR/Z5Y25b5X5o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZfE+lcqwb9UACyo6M5bEjK4yb4bu2UNwZG7RT9+CFzOgIg84tozjnFdSfgV3/vJPWWxBrO2eEk0Bp3Gn6BiXIs7VYELKDGBu6Ay96RAbTz7C+Xtc342wqe1UrzAaf0EVAz5s8IL0ucTu3blZE/P+sP9BMu/G/Vr272p6BClsCh4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PCBencC1; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PCBencC1" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-718f4fd89e5so549283b3a.0 for ; Thu, 12 Sep 2024 00:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126803; x=1726731603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cfrMTIgk5Q+XEJO7A3FTmtoXD8cfHvhd3vsooDA9mV4=; b=PCBencC1I+Iys/e01Vp3XG9yQk3dn+QxHFRXgtcWfM9aR3jqyKd6kP6G4DDikQpSJl q7tbJsRx/3on5M8DRZz5Ivq/wvasclRzhVVtrAHnGYhLsxkTebYR2YK5qH4dT9VPNjYa Dk6yQ6z4PjpiWy61EsTkNlfR5L4WUnCTHEe6vIoVUeNxMXPeF05T0j7O7rSwGexH6JVj 9yqpsZouxmbXDPoSXvFjBoew40mwBjnsbX7q+aLjW4qS5wJ429yNluaueDcuOxjeN/1H rBJKL+XLmFU32LAzUe+gI2iEBt3BQXqyEODsUlXakYfJ/gZNZLBnLmDwhvI2MVpx+z4T VxDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126803; x=1726731603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cfrMTIgk5Q+XEJO7A3FTmtoXD8cfHvhd3vsooDA9mV4=; b=wjcv6Hw47CwgygnWQD9+8vTyiLFscKGaQPNzeacuLy+eHavfoI+3WOCN0boIHb7lbj 7IUtA/9nuazM2UHyXB8ekDsKD4t9+cdj//qiyFgiH31Z/7+MHCRcrhjhLrpocHjPH77i hnZ1UV+L5qT6V4A/1Dm0kv+/a6CmncMZz7mU+Vyb0F1oRH3RFQJ7dG6U9rhe7l2XNcYe HRneh/U6Tvm3I6zN5FHiNxb0QXpZV3YesX/69w/gY6g6CHA38pEHAjjIXQCe6hd73reT ip/8QMhFhEQeVrjXKTSj+4xyMIvrwP9lfSOXfFfWXHOC9gNblkTYTdFon0AVcGRbMM0V MAZg== X-Forwarded-Encrypted: i=1; AJvYcCXUKecJK4biT96zDFiGJkE3kajj5cN8MpzKEGzMB+jdwsnT15zGS/u5DouTIFnhwc/I+Hw=@vger.kernel.org X-Gm-Message-State: AOJu0YxfmRIhJMisrLqDSmCZvufsryeSG22LR88s+Gy52+E7ESa/3kPa qNSp+xbG2GrVyPH2zOk+zQe8VJ4nOAdNQ8QYfoSnaqlOgljN8nrAqDSnedGaSoM= X-Google-Smtp-Source: AGHT+IHWOaE7dY6tBiE9Ghckw7hSP0fZD+0ZwcWT4soLCd5pY4NREymaum+9biUNdbtqFJkCdDcI4A== X-Received: by 2002:a05:6a20:8420:b0:1cf:d745:d641 with SMTP id adf61e73a8af0-1cfd745d677mr1281589637.18.1726126802834; Thu, 12 Sep 2024 00:40:02 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:02 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:47 -0700 Message-Id: <20240912073921.453203-15-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Reviewed-by: Eric Farman --- include/hw/s390x/cpu-topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h index a11b1baa77b..9283c948e3a 100644 --- a/include/hw/s390x/cpu-topology.h +++ b/include/hw/s390x/cpu-topology.h @@ -57,7 +57,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms, static inline void s390_topology_reset(void) { /* Unreachable, CPU topology not implemented for TCG */ - assert(false); + g_assert_not_reached(); } #endif From patchwork Thu Sep 12 07:38:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801593 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A16B192B8D for ; Thu, 12 Sep 2024 07:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126807; cv=none; b=NGNw8BHhjh4/M9r/M8VOWrPrqBbWGoReilpgwZd/Dm7VCeR6v6yvv7qiv8qr2469I9VTuMRBe8fXOQSUo9fH9CKwQc2OgvLvDN9sQt9pJlcGP8dG+virXJ6yCpDtiYWfXFdEr8k7FiLdqC5e7/gAI1x3pIK0vyMwjonGz9GxuGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126807; c=relaxed/simple; bh=yNmoBMylyOucZGz0kA77fXTBlKvOobO732WuHrRADpc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WirB2uJdeTw55mTAj/km4FvBFvnVz2dX7jtfxQ3Hu3f5ZDyaBiRI+0hmQ0KJFiYxmW0yMEjazivKKM0xBbxbZeSSkIfDiZgS7UYuYMft/Kwzxg8DC+MI9QLw82Rv9z2lf11NtskLQFc5Ti+g3C2YkQ7XlowUwf88XrSpS/aGvbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FxGeW4LE; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FxGeW4LE" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7db238d07b3so384810a12.2 for ; Thu, 12 Sep 2024 00:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126805; x=1726731605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5zF+jA5qLmLbmnQj5+SFXwtuz0TNrysgMomjB+iiCqE=; b=FxGeW4LEfYC29DC/05jVjWUJBG751UT449YrO/gAVV1DjhTkGQcFqClPBuEV8JUcNX xe3Uyof80UAGuQsV0iEUjI5kuteM5kyP//lgK3wQq/46LejHuBKtZh6GGNDURPLpy0qO Wv0X7j4APXlEqJujxCCTifkR6gWSJ+OMF/X6PfYtctjZxyhJIVp7LGUamuWGpeK5f74V zAh+4DG51tTbQLMPN9tW7g75xDDmEX4fcG+zs/IBoiAiCe/i2/zxQvvQ0fSq+TOO6cCE LUU0OGfn07nXhKjGx8HqazYuRBA80F4u2iLkgVby5D7/DgrRR13emI6biZ/E84hiGRPu t0XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126805; x=1726731605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5zF+jA5qLmLbmnQj5+SFXwtuz0TNrysgMomjB+iiCqE=; b=iMNC2q4jDT+lEtIbv/W80ArKUrNXI1V1m24xFvVZ4Pgw8aqWU/k4LlJPLa9raCyeqy S2jX5JNOy6FO2TqAx7fourC2dZMkeRz4LggxHWm3OxLiXMaqfx/j+v5OkPsmRjAJNyJ+ 8GL8XS/w5DslLc2qTpat9R9Me4p/jxikMb4IyZXfJz/uZGAicWD6KYKUwxQ59/Kgqye+ dX/yVvHfanJ9BhV4UhBZpqFReF6ok8ioZMM2VbqP2OezfFGI0GbCJKxUKxmhB+eGBVK/ BNhXm3MOxdPgYgPobhijzgAjsEqe7ifqPZDR/LoPTnSF5f7yo1Rz9hYmGv+BAdvc/Rge jKmA== X-Forwarded-Encrypted: i=1; AJvYcCVCUsUl9hMLX2D7uA8fuZZ/8Qz/fB+aZMDZUg7MPvgTqSPygPIki1CoBmpgj8Yisb0mWUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwaUoDNO4KJMPoMA/rANn9xPUKmHLeppwg4KJjIuI5UyduqhV8f TH0zFyHj4UOhk+03zU1E5T9ViSqRuXnLrp96tbUZJxm8J+6ieg6eV7BnsF4bOFk= X-Google-Smtp-Source: AGHT+IHDXrX+NbUP9NtxGqG8dJEo0gfcy7xOv/m7ynMdOyBHgNq9WtYD8rjvMD0vL3Bh2gbeHd5Gyw== X-Received: by 2002:a05:6a20:1056:b0:1cf:9a86:73e4 with SMTP id adf61e73a8af0-1cf9a86a035mr1164601637.14.1726126805353; Thu, 12 Sep 2024 00:40:05 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:04 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 15/48] block: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:48 -0700 Message-Id: <20240912073921.453203-16-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index dd359d241b7..803ca73a2ff 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -5299,7 +5299,7 @@ qcow2_get_specific_info(BlockDriverState *bs, Error **errp) } else { /* if this assertion fails, this probably means a new version was * added without having it covered here */ - assert(false); + g_assert_not_reached(); } if (encrypt_info) { From patchwork Thu Sep 12 07:38:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801594 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E5E919047D for ; Thu, 12 Sep 2024 07:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126811; cv=none; b=lR4aa/4JEWXtg86XElw089o4FEwQPbPZULcE8uJb+sXgU50JMfiZq1zN+3sgl10yTqXy4pbMYYVs05Yt3s63qea9Fal5N5kTXdr8ACF67QuxbmDmCJ90IOjIrpMD4KmOLStQ5vzIZKes/aI6jO8sBtJCstdT9GaCQK7O43+SK7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126811; c=relaxed/simple; bh=dgWzymuqhmUePNSYVALxLYItS2EOTNvUEBajuEvTDVc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BvufgDpLxxPFc4O7VOqIHbrJOEIA+Vf9SZZVzeUJyZk1zS5S80S9lQxdQ1jI7zTbdmCg2KntWBXRRj65eZqJs8N0eEnlPqh9Xlv2QlCwRizsxmUuccx5J+3iuG/kqEF+7PaiVBaaQHCpZaR9lYoC6Ta8QigpdkVBllUeM4wky4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XUV/PJXh; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XUV/PJXh" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71911585911so521673b3a.3 for ; Thu, 12 Sep 2024 00:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126808; x=1726731608; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P59BoCfpfnoUAXReWsDYStuySlGSOxKrMipSHR5f/PE=; b=XUV/PJXhpCGKKQDQzynH0u9G0UlX4MmyXs/gP+X1tIQgnxHS490UlYli5wkjgiGKDZ Z/ZUuBzLg9Z53b8nrOLhYBiccEGkFF5EFSheuD7Td2haKwkVlMGGKJXQU7rSdbOQZUSk qtz+oFtVXPvuiwZRI5+SPCnNmS5MZVUorMtLUYNWcwgayj+Gkky7gQpkL3XMijebi/V4 vluv3GxekiKU1NqzHoDjhKIWnH1xEWqBnXDaQ0PYcx3zhuIdkI4pDENCWDNaC8HFK0gQ WpxJY3hiecyMtBPdiXx8igPjRyVBP9drJO1Tt+1BsMaC1f71HLSnz7FlB3mYHGf3KlHC bi6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126808; x=1726731608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P59BoCfpfnoUAXReWsDYStuySlGSOxKrMipSHR5f/PE=; b=okFR3gN4VuSrSaieQbO8TX8GgsavAC7V6KsAcK6tWy4wnGkMjlcqJMNL1jrkIhsQet s+FPXeFn3xNcPTzceX06gKTpGB6M5P7+M+b+82kS1v7phhIs5Md+zQ4MRtSXlb0lkrtK n33eeejmE8JSyCnyamdRdGj6L7vxc0BNrJqZslfEWLm7vyqivjLY1xsFM4FzjJBw7xbS ngpjv+psvGPpX/9CF1jO+JtuL2qLgJlgewdMhuv31XhLSS03VfA7uF9Zn4HyLdLtcW3o 2bFx4AyVAyNCgcyJqMXA8Kq5ZynaXnDGOUZ3uRcwZskbTR8iAOnDVbpJyIReLQ9voz/h xfGg== X-Forwarded-Encrypted: i=1; AJvYcCUIDFgKxX1Ox+trrpnNzBHR3/K6AzhnxsZtomgrcVKUh8dPf5uZzxmSMLR8XQ42Ro/bDXs=@vger.kernel.org X-Gm-Message-State: AOJu0YzzXDTVsCNuMgB6499vFE1Vat2amUkSrYrsN9UbRYF0Nrbc9JXb WTZB8nmOhaXnWpJvT457a10Z9afAiCfebGBTL58Sq3jQyw9cj+6huXiCDh4xYo4= X-Google-Smtp-Source: AGHT+IHWrcePIqQHDHOWlFI4nJcx4ZMXRIsFR9KI7njLnd//xW7SZTBR6BsOUNPJAp3rZN3BYPs/RQ== X-Received: by 2002:a05:6a21:114d:b0:1c6:ae03:6607 with SMTP id adf61e73a8af0-1cf75ea27bcmr3064643637.6.1726126807996; Thu, 12 Sep 2024 00:40:07 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:07 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 16/48] hw/hyperv: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:49 -0700 Message-Id: <20240912073921.453203-17-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Maciej S. Szmigiero Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 6 +++--- hw/hyperv/vmbus.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index 9a56ddf83fe..ef50e490c4e 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -88,7 +88,7 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, return sint_route; } } - assert(false); + g_assert_not_reached(); return NULL; } @@ -187,7 +187,7 @@ static void msg_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static void evt_conn_handler(EventNotifier *notifier) @@ -237,7 +237,7 @@ static void evt_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static uint64_t hv_test_dev_read(void *opaque, hwaddr addr, unsigned size) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 490d805d298..df47aae72b8 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1874,7 +1874,7 @@ static void send_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_create_gpadl(VMBus *vmbus) @@ -1889,7 +1889,7 @@ static bool complete_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1931,7 +1931,7 @@ static void send_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_teardown_gpadl(VMBus *vmbus) @@ -1946,7 +1946,7 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1996,7 +1996,7 @@ static void send_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_open_channel(VMBus *vmbus) @@ -2020,7 +2020,7 @@ static bool complete_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } From patchwork Thu Sep 12 07:38:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801595 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 455DF19048D for ; Thu, 12 Sep 2024 07:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126812; cv=none; b=DJ8ufb2sfyYMbhSYHfuFqV23H+JbaAMxRR0P0X4xQ9FZsF/0No+9GMA0OU7ZDCMkxerxEy2tgdSZba+l+AzxKk9nBuot2Io+4D9Q1BbDkZYJn5+piRB5VKt4hbhrJqrf1ooORPN3qDvxIue++hPiQI+JVng8KU9R3PEdAJBlvzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126812; c=relaxed/simple; bh=63qh8GTjzyrgkl1pmQ7psE/kkGXVQaBj7lRwT0hNclQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F1dS3f0jkTw1+Ysotzu/KmhFeMTaQlepl9mlq8PJfHGSrGoSIZvko5j9lx3yWb2+sG58tCGJEwH/KCMXzVxTFCPOqK+PSGiJZe367QS+MzKD9VmO2djTmHPg0ecSc8UM3qxB35Ocggzp+jZ1pR20Eb8zJGQuBJul5Ny2oC9ekaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k4/oJj10; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k4/oJj10" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-718e9c8bd83so1274151b3a.1 for ; Thu, 12 Sep 2024 00:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126810; x=1726731610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LUkTeAVAzR9AYc2U0wxTWgfR6a0KVPFNlmWMjsS+ujQ=; b=k4/oJj103LDiC4rKtR4+i0/eZy7b4eGCSl03N1HuGLJvcv5LBN92cAeJTQWd99/v0I AOnRSuT1VIy/RFNiT0Ib3GB1AlqmjQZaAnykWV5/2V5BATvun/KPDInJkcetoQb2vyCj sA5VfbU7gQjGcpXU5pNvX0xw1ns4ghvNOMLEviPyr5kvdZdzHhZ+vluN8EZy/cb5B29z 7srC50n6sOF+hQR7zMtDWNLX2Q330VnkwaIVo/doXTS2lNrPotcy2yEVSs56FLslmZFf qbU2+GFE3VHz366VMs/00+EHg3s7dR0LjwLWwEilaxphbcAjurvtzfGJHLgQTnwc9OQU luhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126810; x=1726731610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LUkTeAVAzR9AYc2U0wxTWgfR6a0KVPFNlmWMjsS+ujQ=; b=AeWDOCibEbnFwtQmm2Ur23WuGTB3DyzMfQVm6nhOZlDXPC+wlP5DLDN5Z1A62B/cK7 S5t1geZv6Ng2KUiyYcrBtK88PHKKGOLGF9K0A3792nVxBuCkVncIK9tj9Sz46NWShx1A l+UpvTcj0EHQuYmWVgtSiVGqy9c7PKql0xZqVulfDQMovb46tshrRFtkA8u94hLQMOkk oRmTrznHB4g62wkOlylX3/EKfblezwT2LlGgkjwrRwNxFzK45LyYCQkcVr8fyzNS0IIj gr2EP/uxkkT2jnITG3ltv/G04AuRUT4fc7ECbj/MD2r6G1OspZQyXAgsulu+KtqXF43/ M0+w== X-Forwarded-Encrypted: i=1; AJvYcCUnr2wnFQDIKDuoNegmT9lrFHGFL4hJNFUSqVWFovdSubJzCzbYTV3iLQrnFltgAEWZ5Bo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0N3vZITNN5vnSsQQVjrYzHh/XwfO95IfsJjXktOB8QMUL6nhR AZujduLMWXsLKc7u6pRfJ54LN9HDNgidqcXvJnv1ICXCygoK9pvSq33l3aiDfBA= X-Google-Smtp-Source: AGHT+IEm1qfoJyiyuz3pPbRbsIvSjDeyET4AF6g6lnz2NNR0EVNyE3b7nhPetB5baWbyDfCovyWvGg== X-Received: by 2002:a05:6a21:1798:b0:1c8:de01:e7e5 with SMTP id adf61e73a8af0-1cf75616bffmr2800213637.15.1726126810532; Thu, 12 Sep 2024 00:40:10 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:10 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 17/48] hw/net: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:50 -0700 Message-Id: <20240912073921.453203-18-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c | 2 +- hw/net/net_rx_pkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 3ae2a184d5d..248381f9766 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -561,7 +561,7 @@ e1000e_rss_calc_hash(E1000ECore *core, type = NetPktRssIpV6Ex; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index bcd5f6cd9cd..6be61407715 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -397,7 +397,7 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) type = NetPktRssIpV6Udp; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 32e5f3f9cf7..6b9c4c9559d 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -375,7 +375,7 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, _net_rx_rss_prepare_udp(&rss_input[0], pkt, &rss_length); break; default: - assert(false); + g_assert_not_reached(); break; } From patchwork Thu Sep 12 07:38:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801596 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75D9118FDDB for ; Thu, 12 Sep 2024 07:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126816; cv=none; b=pcpy7nWQEPtdr2RucahrbiCCud/5JJWj8t++61JkIRZYASOf/DfjL735CwEMKeZPrB4c/Rw4fCxr2mNp6UdrTH0iSQuVjL2qNi7bHxlZB4Kj1jS6s3FwAvA+AGThDBO8sdN9u+iwWxgvF2xQXA7L4pxu51ijCVranf8tRPoXNhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126816; c=relaxed/simple; bh=eEnFhXW8TKgilQt2LSiJkpcgLzb7JOAcTjQeFy0AF6I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QPCu8CFeYbVRCsOcADZD4BbQ6GfCn9bdmhCuEfh9C+AJEVapGW4+EBY44YuWTYiK1/NUo/P0/gkACgqcUcgri6Ahi0bl7u5+V7HGa+G4nT7RAFPVf/avTnuf2tPreow9jqLznyP6n4OXboNqX1BwQ5TdDtjsz0EyUpn1CGmTE9U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qRDUt6hr; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qRDUt6hr" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-717911ef035so416312b3a.3 for ; Thu, 12 Sep 2024 00:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126815; x=1726731615; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TcrlVQ2BBzTTTXSH1b4iRRRxuNhgYzpbZvccV8dHuB8=; b=qRDUt6hrbjmONQqQLDuBshCPjfS/SMY8B/XzDzz6Kizv8HHsR1HNrPa9oA+ugfbrLO UusY0Um4evhldk42wGrbClxVNpdtEOIT5YrMwIq1KYfvLEzZs4cv0Yn5jfLS+ihC2v/0 Ei9Aiz67sZAyzxEzejHLQkWOFd+SKjwZWCNZuQYQrU/OxmRC73tKWaegxk+zblTL4M+Q xlHMfOFI0WXabNJLApaN/l/TAYZqRcbfTCOJgmP4fpgnUgwAvTWpihVR9uw9aM7u520U D2qxLOvd1W6yTLMrWOa1HzrFe5whQIjoc2eDUPNSoK17A0NFicaa8JxgSv14orj2Yt28 KhDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126815; x=1726731615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TcrlVQ2BBzTTTXSH1b4iRRRxuNhgYzpbZvccV8dHuB8=; b=KC288Pgrvzy6faOCiVHB2c9ZFUGlWh7qg8Rdbm8l8KNZHEERfa9dKNk18OlenAfGjt Q9zXEHRqNiDsMFBVvnN/9HBi1YBESBJkETjtfiQ5ouMfhwS8IIHA0Os+ytgNxTFJ3ntI k2WokTsAKp5KQdecyiV7ub9Ek1D04FcQk4/T6IC27TyLZzHzytVrptSi7/CyEglZWXSm DaMa4aWUHTg1tPgCQLZTCEJc0xZBPL0fvMDzmifzyYvxImiYV31/wvtPtSxkJACtE9Dj kwk5XPVYTnqNXvFc8RfIrvrsfDvq1ic5zKnCoXUqX4yeS+xgOtmj0VzgPOm+THOvhMbf rsVg== X-Forwarded-Encrypted: i=1; AJvYcCWlvsiB5qK6/f3jNydYx9ZvARaW4qIefUQVZm8aFersgExHnQXlFB2YzVy4Kpdc9IButIM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh4wSv6mT/mGfREefiasMyH1zSv/Z3tRJnUKKzI2QjeuvMrkv8 rXSDgwntFsw7xjRiSwDRg3nASCDUZ5dwT/Uhu7zY1sxyyD53CLci5QeZsBXe5mw= X-Google-Smtp-Source: AGHT+IFAZ1Pk4eCCVsZPvVoIoG/IsRq4YVcZJLHNGvieq8Ne31Y/ZKtRMM5/ZNOtWgduAu3UbqRH6w== X-Received: by 2002:a05:6a00:4f90:b0:714:1849:2503 with SMTP id d2e1a72fcca58-71926055cfamr3299082b3a.6.1726126814532; Thu, 12 Sep 2024 00:40:14 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:14 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 18/48] hw/nvme: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:51 -0700 Message-Id: <20240912073921.453203-19-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Klaus Jensen --- hw/nvme/ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 9f277b81d83..fc3b27c031e 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -1816,7 +1816,7 @@ static uint16_t nvme_check_zone_state_for_write(NvmeZone *zone) trace_pci_nvme_err_zone_is_read_only(zslba); return NVME_ZONE_READ_ONLY; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -1870,7 +1870,7 @@ static uint16_t nvme_check_zone_state_for_read(NvmeZone *zone) trace_pci_nvme_err_zone_is_offline(zone->d.zslba); return NVME_ZONE_OFFLINE; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -4654,7 +4654,7 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_CMD_IO_MGMT_SEND: return nvme_io_mgmt_send(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; @@ -7205,7 +7205,7 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_ADM_CMD_DIRECTIVE_RECV: return nvme_directive_receive(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; From patchwork Thu Sep 12 07:38:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801597 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06BB9191477 for ; Thu, 12 Sep 2024 07:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126819; cv=none; b=koptAfxDw/ViWUc5s5uyWaCymfY1a9b1hV0VJ2+iAAGTlgKWu9K8rVLApbBvQmg/mwGekmo1qinSDTQ46TwGTNqwJhOh0/5Ov2/5dGzB9/wtb8offU+l8benJTccMTLYxgxwHWH5a9XcMt8uD6VzzHlgvQlQHYc7BbzU9hEtsDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126819; c=relaxed/simple; bh=QwIT7hjUUVpIm7wW7pa8dcd4MWifd9MGeiuQY06Qv8U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q9GweynryZFKiZG3O+/JvOILTBzKrNekbMwiXbYotT95Q5GCg34SaEI6fN1/zyGGVYX69IPArqs1NNEsqWFCQsOssQYB+UeFoceZhacXaHhMAot8XYUV9uqDeOM7LZiDChjbLodKLOyuIp66TBvXmaWge7Nrye3JTgjd7V7ppoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=joA2yG6N; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="joA2yG6N" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3e04801bb65so366235b6e.0 for ; Thu, 12 Sep 2024 00:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126817; x=1726731617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=THAU92UrM0dCOcON0qgAWJPM/1rIMc3WLepZV6d4U4w=; b=joA2yG6N6WdXNzCsJxHu8p54ZlO9YIdfLoYh7z27mHHHPhMO2xdX67VEInz4bqmYB2 41UJatSme1F/bs9WZl5u3L0/j8T7b0J9WT5osdPoYjVCQsOepxbrmLnZSKhLSrfXoZA9 B6IaHDXUqnYqh6J7NsJpyEPjUEJtY6+ANk2hRg1XzRXIpUcDU16V2p7LZD6ogvdlE3DP ePGtlE2r3WYpkBpM8S3aEAp/YxQREw5wSpH9goP5RPCM6MsO3UPIvGzeZZmCNloH51dG M+CuVmqsLAoJy1wfTHVvZY7TLrDzfk/GxkPttfRZwBAmQwpdAu2kHuWmlszBCDNcKKsV LsZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126817; x=1726731617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=THAU92UrM0dCOcON0qgAWJPM/1rIMc3WLepZV6d4U4w=; b=dTuKLIx8Qdqc5avjttwWp73SsccS5cDOnl9v5WlXEfnJUWcyornj7nH1A+Ptp1ajX6 nWbc17I8CaPWKqSkz/lO9Afv4OhkW9FjNuXnwX228VjyU72tHVSqLlQkwRVMuLiC9jh1 XbDEHkwmvepnD0Rcd4jIQWREaEHsU1vwWvoSrDVnUdIEnBTASzpYXkkUzsB0fcGge2au JC0qEdLvE9PpacxPqFqwzIUJ7XwBhW1VBGpNBn6WIl83nfTvrX/ubrxRisSqvyeDSRIe gFydzY4QBcMlpsWb9Gedhdm2soFCykxvVy41mkuxqxGpfeZGUmmYoh5aEks/G2vAZCVe b1zg== X-Forwarded-Encrypted: i=1; AJvYcCUFKdW/HDD7zM86jW73a6VBcFfBLKUx02Y++F7VZsEMbF0gSc9Rjn56eoXF31FUs72ag1w=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc/D/7xDOpkj2GmkqbbxFYiBcDBXntbJHsB/NkDOQwnmVa4Yed atayleBkgY9yz6D2fLm6/HqM290o9qMAGNNd3+NVFV0aiSiw0kx/aeBauyEZKt8= X-Google-Smtp-Source: AGHT+IE18OQNSYCTciWDcZ2tARjoD9KTkXd4QIX1a/2fI71lIh2I9Gute7KgIxVtwws+/7Dh8z96lg== X-Received: by 2002:a05:6808:23d5:b0:3e0:45ea:7fbe with SMTP id 5614622812f47-3e071a97f6emr1220176b6e.13.1726126817031; Thu, 12 Sep 2024 00:40:17 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:16 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 19/48] hw/pci: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:52 -0700 Message-Id: <20240912073921.453203-20-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2b..c6950e21bd4 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -46,13 +46,13 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) /* kvm-all wants this */ MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { - g_assert(false); + g_assert_not_reached(); return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { - g_assert(false); + g_assert_not_reached(); return 0; } From patchwork Thu Sep 12 07:38:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801598 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96B819C54C for ; Thu, 12 Sep 2024 07:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126822; cv=none; b=rRp+GJG4nUnsaqfPD/auG/I/T5QhS/4q7MezfLbmIkrMWMkAsR9p6h+dzrIvbmT2YZ1NfymoAG6MlFQsxJneo7hvXlyIjsIBDPElWlb9NgphnUARFTrMsL27PlKGbtnfOlW7F8WEw3yWeiUzQRM5ixlOHt7jdfqNUFjSJjlM/zg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126822; c=relaxed/simple; bh=6n8Iu1eagLaf2nrikwLTKltHnnsvygVi78492lc1fYo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WsI452mdoOvRTONiYauZyIFCcNoulEYXfvmJoSblC0mKK+pOapl62/tL1EX00jQVQOFCmrpOEFEtwQ7sJ8U2GaCBneZthTdiE1uxOaCekV2/aSj6dFUAnngrxENTlsBCc4ODgJz0vtwbF13STZ1iovn0OkptLY9XtTsyMHo0R8w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sj2X+unp; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sj2X+unp" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3e05a5f21afso356890b6e.0 for ; Thu, 12 Sep 2024 00:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126820; x=1726731620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QDay2TYnrrMfur+0/EEHZALdjurI2FyW1zrkZGDuads=; b=sj2X+unpHQqrvhzStvjsXza9lWpErfSyZWgAI2y302JATd9vetXii1LevxCgAb9Y7C MWerXJsdi2qCkm0vYWcABGCWWnS06RyCbgK8ylbSE8XuY8hRsmHP8LRkoNmDWK/8Jtr8 epaBIWAvsZxm54fNhNbYxKgn21AaVyoxLR2rJBOcr8wqWxHAjvzmNOxUqEdHrvD9fC9c MQVtNVVGsumDawD7V+ji+q0mRQIyjNoID6FhM8+4DM1moqUefUWR9mOT7w3eVcwBtwI2 Kb6VyOuRrgclMW6sPjuoiaZ16rS7donjuqzY0i60W9t9ulvxElAb75EuAtX/1NI2Ya8j qJ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126820; x=1726731620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QDay2TYnrrMfur+0/EEHZALdjurI2FyW1zrkZGDuads=; b=mpzXzInNd8l7MID9B1wWqf0oo++Ejf45Gc67veairX6WAZGz4FKJWWjYRK+BNTWM9G r5rQLwcpPWRVOtQj1BgnRzDePL58Z1NPc/u2f2hafOBFpR2TtULs8vP8MxahAgooXGzN dqrQRrazyinVfYsl9uOWss8jF1i9kyr10MDYGBy7QolvReJtZYcHKRSGddzhnVzRrRFa xXgZHsQO/ZJ/EJeVNRJKJKZBmCMosswTWc2Sp+OECFJFcQRZmddDA8fFOlbP7bQ7ZYpt 1iM4CTJefaKetKH44mpQcd9NVZo1j4Z43jVcoxIK7MYI1/tt9/05Bm5lOS+TYfcVe5D9 HMfA== X-Forwarded-Encrypted: i=1; AJvYcCXdDAVNycEHVa1YB5ZhuiwssT1ygU8f2JNpx9aFs3woka+DCtjvunQa0t8sCGADsBhyMqg=@vger.kernel.org X-Gm-Message-State: AOJu0YzjePw4eM/dB6TTYVuya5GCni42FI+mgGCV5Jy3Yy0J3c5gP+6g HwU+N5ihkxVa+wVxQNLr9+/TxtDS0Ot77mO9mI03YzVBViCOSDFKuz0YQUEeBJg= X-Google-Smtp-Source: AGHT+IGYhbpRKjr9LXlf6ua3NjBjcAj8nIFkkfD9zPLBPpLzylMLlenLFQR3rSDBD4RdwwuqK2vzTw== X-Received: by 2002:a05:6808:1290:b0:3e0:41ca:1443 with SMTP id 5614622812f47-3e071a9a491mr1814477b6e.16.1726126819675; Thu, 12 Sep 2024 00:40:19 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:19 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 20/48] hw/ppc: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:53 -0700 Message-Id: <20240912073921.453203-21-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- hw/ppc/spapr_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index cb0eeee5874..38ac1cb7866 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -645,7 +645,7 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, /* we shouldn't be signaling hotplug events for resources * that don't support them */ - g_assert(false); + g_assert_not_reached(); return; } From patchwork Thu Sep 12 07:38:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801599 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9B2C19C546 for ; Thu, 12 Sep 2024 07:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126824; cv=none; b=EzjwgkU+bMWCYSaeXTPxoY1VFfH/CWG4yQoB9jGjnkDFyjwTi9U5Au67HZRfdzEFgv9WWma5CjsNiHQ3u+qrwnxdY2b2QbXZzAcuV46yt7iAeSnh76Eo+Vo4pWxoHrG1mXFRqGS+06CKFpIFquw4c7sZD75jsp9s8tOJf9Hj/uA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126824; c=relaxed/simple; bh=Zy+NNmqLkllb7WFjw7V2Ohgl5LvRWnkwSMJaELSfqSE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OKtO8BstEknD7I9/XyqwGQ1nc0jF1M50upR9eBUlxgPE8cvJu2famz1ddOVbIxxOH8O0U+k1s84f3Hj5GE1Ag/5QKAX7n1xoYiVSCjx7AXWVZjiMTbeIcYqSVGstWWerBxd9ViTecmnBmyKuME/5mYN3KgV9x4SgyYHa0c0APq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZtOogOfz; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZtOogOfz" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7db1f13b14aso632958a12.1 for ; Thu, 12 Sep 2024 00:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126822; x=1726731622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MAqUDAXH2RLxvOYkCD7ynjvzkI7+hLAzyNaEnllXZKU=; b=ZtOogOfz0shZDvCxt+Hyy8luAz7xt4uCoD8hn6sgVQOTCxMTQe1pd99PHCL5Xl3nrs JGs0MpuHpU0DjFAWrXyollQ6fgsTJ+9pAXsohnzwNXGIioJyRlnpXmnDWiVF8IBMTzti Ktli1ZB8d1YTwmJeLFFegdfv2TXEBKeHEF45RTtVk5S89OIYSc31G/zBJ4kIsG0JAkXb 0jSAniQ8fL3gf8Y+XcNe9TMnMxebgZdxtRT1MuioXxxdcjMe/F5dMK2JOG+jnHAOSfAD CTu786aEpmjCOL0RacSmk5HVhG+4Jmt7HxC0P+csjZkBVXl0p50uD+URh1oJ64ptoL8/ yBQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126822; x=1726731622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MAqUDAXH2RLxvOYkCD7ynjvzkI7+hLAzyNaEnllXZKU=; b=TESvvm3euw9Q9D48PKoZrK1vkeSLREWb8w5hCDudFBRjnjnLeECio30nRxPOFDIhsC HKDrjKLolanYeUYIRqaldnKBho3khBy2AgjhbS3gnnpdZ0fBuBryMlntl10Nm0n81+M3 hqHarW85JekWGeruBRFWgoGcu3l1nBaeONiBoON2BQtfDDUIDuoLnTZpm5lxvWyZeA/8 SAZOrtcoOD3B6YiP34la3jlgJAA2ynFpRTKsWY1mpHlFy9Z6aNo4YZ5vXS/hoznRFUjE n+fe54ButoTGkqCGf+xgxpIRT4dHx+XUAePprhmVZsrBD4djgdthcCeTk0l7OFEgi/qy IHlg== X-Forwarded-Encrypted: i=1; AJvYcCXJ/c9aNjsKdGZUe+vbxEVEsIPt6CdZx6k9n6CaaiMXg6CdMiHJ7jYQb5mFG5mIZnWPzDw=@vger.kernel.org X-Gm-Message-State: AOJu0YyYsrZ8IkT8MbE19PI72yeu2mvDABHdTwOxPwLycE3HXhBPvlQ0 SFKBHOu913kA2fJY4EAraXOL2JexsVDSqeBVr9DsGw5kQ3Ga3PmCbiyILkTgbso= X-Google-Smtp-Source: AGHT+IE8CKjJgw0N7WrqC34he8rsJ6HMZ4DWnrxVglrTgBMS33CPmFB26J4BB54F9WE+apv1XwnjUQ== X-Received: by 2002:a05:6a21:3982:b0:1cf:2931:727f with SMTP id adf61e73a8af0-1cf75f005demr2867169637.18.1726126822148; Thu, 12 Sep 2024 00:40:22 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:21 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 21/48] migration: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:54 -0700 Message-Id: <20240912073921.453203-22-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier --- migration/dirtyrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 1d9db812990..c03b13b624f 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -228,7 +228,7 @@ static int time_unit_to_power(TimeUnit time_unit) case TIME_UNIT_MILLISECOND: return -3; default: - assert(false); /* unreachable */ + g_assert_not_reached(); return 0; } } From patchwork Thu Sep 12 07:38:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801600 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C8EB19CC16 for ; Thu, 12 Sep 2024 07:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126826; cv=none; b=d0erP949vG3kB2fzXPpwwAyPxNRI4GgtDiRBSE9/xLlW+9yyZgUKmL8j9X1w0RqkjM2yugmzQxf+d1yA3u73RAa8EoidtLnWF+moieSTj+xQ+4+FsHGum9D5ZSOE9nbaYNPyqw2/37m/o3Yqi80QrmTO4OiH/oOBMWBuTAUsmO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126826; c=relaxed/simple; bh=AzrkcLS00WBc4gOKuIeTo6QGCcoCTXlMeNml+68ZIGs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=oV6MHFbcHYiTa3b/K5yqcwEKtj6Yc78DMsZGI7PQtBbR/0+q6DbQArI4WLhyr30oMvTROML8HWe8BzhYDIDvXdG47WcKI+hG61wrngPGc4tFiPPALcFVZeRLwF1L+P1VhpzS04ZAu4sIAnZkQeOlS7u+Oj/vvCSidaBTK8rCr3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bqNC9VEO; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bqNC9VEO" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-718a3b8a2dcso410183b3a.2 for ; Thu, 12 Sep 2024 00:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126825; x=1726731625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RMRZaTd/BH/1FKFl6y3cyJgui1+s3Png+hpoiCgGZ2o=; b=bqNC9VEOp9uCAwTRT9RECd6Ypdnc5UC+bhg7uvDKHa5D/Xaa/zMyjkOm9LwRFxMCFb PAfZKEe2U+PU49UlWF+SJa077kBRx6ONaH/i6YYXNFE3kIP5OqC/y5EN7FqM0FMfX7vZ iNqam3r1t90oxzbsU4hbie8OWdpo4XekC+/ZABjjINot5lwgycpNYEZp0gmQZ0ou4VHB H07bOmQcCp/3/uQbpis+LmAj78djinSHwNJZ9ao+lnA/9k/V70rYJvFnMqHgCFzOiMwP /Dp/NokYNMwBMD7XANBymIdbighsqXipZAG3ZbmLY2T05PTBnTDm3A0Ctslz6QjW+Gxh JG2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126825; x=1726731625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RMRZaTd/BH/1FKFl6y3cyJgui1+s3Png+hpoiCgGZ2o=; b=A0ps6/LY/dTfb/+wvT3YTSufDgwB/YRe9/1a6l5bYnAg7XwWpkg4DSSgHDM+k4+Wo6 hP9bWnQcEPiA/moFedT0ETd4Q3FmXspTqiZABh8Ez1NbUWOFtHmByI1hlDHdAoCWshM5 4ienfFXWod/e9oRpK6gyGSZo9/QGJYHYQJ6ychmKzJ1xUlip8VKN8ODreuPRjtXODeqH Yz3YJdLEWMrDT10yz5PYOHROcy0qbvI5UhzdUBXHxMs/WTs+oNiL0Zxvk4nvR+B1clW7 d1dIE3EcoVGbe4S4Hh5Mmx68/irL5GFhDxWt0HCzY8UsUo1zslUUhMDgeAeHW5I0PxS6 Oh3g== X-Forwarded-Encrypted: i=1; AJvYcCVuhwgvpTLAVsHYnnqJBXJGSnCy0tfu20f6WarxTvXwVSF6AxZoNVas1zbtxURJLuSLzac=@vger.kernel.org X-Gm-Message-State: AOJu0YwgYdzcFksOpCMf2F9jXcN9QUjnoJM6f/CeWzXx6upZj8q7K+oN gnQ6RYRC5QC1EA3Jex7erFswyQmVpckveErS1I4UNhcbu8EMmBUrJd38YwZieOU= X-Google-Smtp-Source: AGHT+IEh7gXd2tJ0hOhx7ECr2lFSn+He2Xm0+RoHd0qt3Za4kg2n+HCrillfNzzhgQolscqSmg6E/Q== X-Received: by 2002:a05:6a21:1813:b0:1cf:6c87:89e5 with SMTP id adf61e73a8af0-1cf764c2b90mr2176703637.48.1726126824706; Thu, 12 Sep 2024 00:40:24 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:24 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 22/48] target/i386/kvm: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:55 -0700 Message-Id: <20240912073921.453203-23-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 2fa88ef1e37..308b0e1cb37 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5770,7 +5770,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) @@ -5789,7 +5789,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static bool has_sgx_provisioning; From patchwork Thu Sep 12 07:38:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801601 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3599719CC27 for ; Thu, 12 Sep 2024 07:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126829; cv=none; b=S2UWXun4VvLw/0ycp3qEE3OWw/ayjlDpZ9llhXlkLIfq5Yufnno/tA7GSFAK9lJipRHUzUn+NfPQWhv6abCHun66vjimDW3P1tax12j1RyHqkJg5YdI84afXUwsiTK2y/Fq2io4IW+IEkvwwQ33ttD/hU8511jT/USuEqFr9YFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126829; c=relaxed/simple; bh=yWaiHO1T3K5f5K/f20tS6mWPHLpYj2UGrmuZsyu5VZw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cbqNWzZHb0XJLkWSLyWDSNqVRBmi8QURECerXiSR8VXwy9CBA4GHlSogH8d+MfcMLTayO3rA5byBcqo+L9eNmGgXYGOJSKXknev0ZfQF84d1q12WcnQ+Iere+Vic3XAOSTDhfgA2Vf62GyUmVcpaFeiO+cZAkVdSq0ysEqfFGaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OYT1SbNU; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OYT1SbNU" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-37636c3872bso2430285ab.3 for ; Thu, 12 Sep 2024 00:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126827; x=1726731627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lAgxsGkzSX6UIjZ+akO+9hnbz8NplQ6SsHLnjF/2omU=; b=OYT1SbNUNtwGygmmdkUj+Pgy76fjF7gvamC9VNX1ufiefNtDlmzzyLfMn/YF03IDEp Td1ngKJSbR6wtgZz3GjXz5GY+wZD74D9eF+mdhfmeIaNdbi74zXiiSEfCOMEBJN5iFdJ 5tNjb8La3HkH1GjB+sxkWYuI1GGz6FkiWzDthXw2sD8SGsWnuyysqZWK8sHmS+DviNqW 8/2GFKZzfcKCSHttxShSMQxai5umE6smse/igDOq+7J559k3P3IjtH8pQUS1P/XRD2V6 OH1Y8nZwZVjtYeNmTweXVhnVr8PcoOM4fOoUxipbb+72WjKD3HdARaODpXGnoxJBfI29 //pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126827; x=1726731627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lAgxsGkzSX6UIjZ+akO+9hnbz8NplQ6SsHLnjF/2omU=; b=wQKda6YergitwwrwtvrAryNT0OhitXWANRiAKauWwTdvOau1OPT5V2CNybuSXDfzv6 FtT0OcdeiERerI6NlzvNuAWgcZrEPOWhF8o5LvuSTb/QB7gytnmiuDFjSR0V5BIorncv eJsKOoez3mByJ+4bdtOJ1fC/5I5ICuer05wqpBB80FhPn8qSJUmwccDhsqs2r2qOu2ds 0GDSVENntN0jEv8Rkgc+y2gqo7hVlr4xwQ+Kq2iYKJXsbW5JwUWf0zSjWOgtHzPjgHsD A8Z4dtiugn7bGXcfe+BRZiQXaar5T/Mm3SWlTEPj/SIPGRGt06vtHxMkxp6jxpvYZT5n 7ptg== X-Forwarded-Encrypted: i=1; AJvYcCXLrMwQlpRaccVs/Bpk0wGkdP8j5o34rXBP6ONUjlKshT/ALQ36TBCUGzUGDEKJTayo+Ug=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7XpKpyHvXfUdZFJIE6R6lgVzlkGhHXieFfDAlrY6iYz7323YX Qkfg/FeVclJmfmBYmPiNg9EO7HSfkBEDiprPDWy1+YjVNgw7m0zfQvl9gCctOh0= X-Google-Smtp-Source: AGHT+IEyvhxwwfs3O4zBogJKiJanB1/6FwZWrxSk8P1iezRQ+YaRZrKbsv+G1dKwphxUzMpD10O4JQ== X-Received: by 2002:a05:6e02:180c:b0:39f:709d:72b5 with SMTP id e9e14a558f8ab-3a0848fc3ddmr16439855ab.10.1726126827207; Thu, 12 Sep 2024 00:40:27 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:26 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 23/48] tests/qtest: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:56 -0700 Message-Id: <20240912073921.453203-24-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/qtest/numa-test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c index ede418963cb..6d92baee860 100644 --- a/tests/qtest/numa-test.c +++ b/tests/qtest/numa-test.c @@ -162,7 +162,7 @@ static void pc_numa_cpu(const void *data) } else if (socket == 1 && core == 1 && thread == 1) { g_assert_cmpint(node, ==, 1); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -207,7 +207,7 @@ static void spapr_numa_cpu(const void *data) } else if (core == 3) { g_assert_cmpint(node, ==, 1); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -257,7 +257,7 @@ static void aarch64_numa_cpu(const void *data) } else if (socket == 1 && cluster == 0 && core == 0 && thread == 0) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -305,7 +305,7 @@ static void loongarch64_numa_cpu(const void *data) } else if (socket == 1 && core == 0 && thread == 0) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -367,7 +367,7 @@ static void pc_dynamic_cpu_cfg(const void *data) } else if (socket == 1) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } From patchwork Thu Sep 12 07:38:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801602 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D8718E04A for ; Thu, 12 Sep 2024 07:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126834; cv=none; b=Rur56YroohiELAHvhxUfGDsD7rqFfLp/LuHwpxtKBnuev1+vcTwiKiJ8tmKNxsa5w8qz1Giz7HCKFeXqjy+OgvFyhAp03v8XyNPhluyJN1o9kihIyBNrCS7/O7/gUmbwaEHciwVsb1/sF+s9KxzY4g/Jd3vFVnVoNEr0uH8HmdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126834; c=relaxed/simple; bh=+9r8rajTU9SwPdjh7W+mWMz+ubk2p7B7CO6CHoco8vo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hOX2P9Y44BwGzQAx0Y/+8HwViLYmLRKRTwP9pfKZqLuU3lLhAAaFJp+3y/dRw5sjpPa+GHGOpRxOT381yye0Z/6MUZrJBGnpYZnpntPLeqihdZaIXh4yabaWNgfXONDHeSc8xM2UgvFJW6WDWYX5Mz6M5Wbnm91/WOc2zkbzUCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PnC14nyQ; arc=none smtp.client-ip=209.85.166.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PnC14nyQ" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3a056727fdfso2448685ab.3 for ; Thu, 12 Sep 2024 00:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126830; x=1726731630; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sAFROPRNfnjqKGInm+avpv2FlUZT8Lrw7bfqM3cunwQ=; b=PnC14nyQnGQmsL7e19B4QpSJ42w6OdgWr9UwHVP0MrDgxN2Fa+BRXDUYosm+ETJ0gK 4YGo5+sCagpgw6gBuTTgeaavIN5hOd4K4XvYn3MZGMVAzWbFUQ+wt9RSnZaQ4RM1o407 vFhO5E/C/LrA+wtSZ9bRocj6QS+UpN0B9RGS17M1FEzcnteWlBvDDu6QSdA8Ac0Zb+0J OmQWaIKt6Mk5LSaFHimEYcTic69IcuSc+LUA2HtNHSnNHD89Z1P3hGDDUwvyDWfIqFT5 wjb4ee63Z44voITDojIW9H4Db6ny+MKMj7NJvJLKJwJnTd+FWV5o/bKrgjJ1FxgB62B9 ZSvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126830; x=1726731630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sAFROPRNfnjqKGInm+avpv2FlUZT8Lrw7bfqM3cunwQ=; b=TXh884CgHdj1/Svgario9wXlC0hlcsnZjVjzb/db/AzODrRm6wF/tfW6N/CxJxNfzo jBy2uOjtOKnWhKKEr3+8dfAI4zgJifg2aqSoJL1mopM4npIGlcoIvqgNdbHj8VMQlkEk twgpf63bmOnBLs+rYl2PrCAICjW8INpyDl/DAUrj489ICtqjgSZiUDVPcJ80+7rv6UpT WWx0qr36tMVvBDwXz0y8+nTPAU3ufTfEV3kRkPoI9PjTUAUolFKlQzYG5oJbBEmfS5Uh nJntmRw5yxJdqGP8iH+2O4h7gqKKjj3HobHy8Z48vZadowDy+wcHgabeMI9PT+E8f3Xx eKBw== X-Forwarded-Encrypted: i=1; AJvYcCWkgCSmyzT/IM6MbKaONY4vdQKnBcxob5ZIVjhLT2dJnbCivMPrJAoV5LnBkp/IHHgT/0g=@vger.kernel.org X-Gm-Message-State: AOJu0YyA68NwomIOmze9Fr3tp/UeuYhi6lj8mzYQ/uB3ye6fh5PAspUv uFN2ndyYEXDXRv/fnWypxGHRWY3I6QWNptR1PPQi+lhyMlRwiODHFqmnprG3DHo= X-Google-Smtp-Source: AGHT+IEH81pDNJI3FqeUIYeBUH1XaZ7gixSvfp0/bKQHU2ae/DBaz8G+MQhE29wWc5KRqiqKpbOJOw== X-Received: by 2002:a05:6e02:152e:b0:3a0:7687:8c2d with SMTP id e9e14a558f8ab-3a08495a790mr13830495ab.26.1726126829641; Thu, 12 Sep 2024 00:40:29 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:29 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 24/48] accel/tcg: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:57 -0700 Message-Id: <20240912073921.453203-25-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- accel/tcg/plugin-gen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index ec89a085b43..2ee4c22befd 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -251,7 +251,6 @@ static void inject_mem_cb(struct qemu_plugin_dyn_cb *cb, break; default: g_assert_not_reached(); - break; } } From patchwork Thu Sep 12 07:38:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801603 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC5F81917F3 for ; Thu, 12 Sep 2024 07:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126834; cv=none; b=qAQcg8PoUWmaSdCWHg7ZPu38wZzojuIJbGSVpXGE3ztcAeUEUlbO8aOv3qVr5oKNk2L/D7SmJtM3/usFBhMII2Tdsgmt4qBUYilZESGXz/Oz0CQhFjtrCE3Pxi5KqksqCz93LhCIrJtV+0auQuvPv0sAj5WzvB/siu3g6rR1jCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126834; c=relaxed/simple; bh=OSiHM9Y95U3nvYA2UO+zDt+BjRM0r1ZP6NzbmbWPOdg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I1ljGPHEDDYqmaVwkb97G/5L5hxkydm4jI3s7SK2P2Vrq8daAARb2IDr4bwzTnKK3bHZ7qKIQ5+Ifm3f2qBreQ1ChLZ07SNVl3zPAGPCiSEFt+Pg9rTNZc7/IK//oUqFywJRQmPkgmLr4b+SVhznpE0Q6i84SHC1eHBFhtNpTDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=X8g/5Qzp; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X8g/5Qzp" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7c3e1081804so358710a12.3 for ; Thu, 12 Sep 2024 00:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126832; x=1726731632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IfzxXhYdexHV2ki07pmnRNhBL9e3UdCDUhFFW4Nxwh4=; b=X8g/5Qzp18ovF83IVPsv0gdXkrDiZptAjRI0JhH5L24z6p3cwKag5EYgZZ5XY+37oq TqQN42LqQobKlgzPUf/FauTafPn+9wRGPgE/Mno5ujN7jhoFMQDD5zFz2S1/jp7r69+/ vT1bL10xHm4boMhwnuP8xh/7j2xN4/k0j58CyFln21Sy7paDOcmhi9HSUMyhpbch2iHr Un+UNeblFJ0ydbLQzqlaeUmOIiuzvpbwgHPGvkGfVP3PVhBzgNsPzwVdtbJO5gr8PbU6 iUIapVgjWIqFFb6EoMuLCbiNahXjBR50INogBaY4X6dtlsN61IVjFPH269jnXsc0EyRK V20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126832; x=1726731632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IfzxXhYdexHV2ki07pmnRNhBL9e3UdCDUhFFW4Nxwh4=; b=aDfAR4JgqBL+RVhobFRFxefC8GWkWaw4zZbREYaLspWJiSxj6AjXQykN/Ybhy5Q6QS iKgfL1IBCy4c08DtFBTf4zkI5qO2R1DQpVsFoMEGFqrjt7F+4FD/F943uaSxO+v/J0y+ xR5RC1eK3lpccu4dTMu/KJudu+g0lMlKYh8bNPMMjlL/OszCfe9fRQ//uJ57fh381iUQ 0M5f4N/5AIyIQ95mCLVfZWMy4ER3s3Uy6+4wi1GxRUktNGEb4mbRQKm49HY0hZEIARIz fHsDTJBh4vkTsvagbsEP7Xaf+Okx/LFeOOmse/uw40gjOI+HNnKo5RcuiL0QZenwGR7L cHRg== X-Forwarded-Encrypted: i=1; AJvYcCVwZfJwoTkorDMm2CWcbSZ7mKtUl9smZvRQFeYSbp4s0EKxQgWw0uY6Xlf45SEqnUwlubI=@vger.kernel.org X-Gm-Message-State: AOJu0YySnaEW4gNab32y2Zr7dyFT0Oi6/m/Fbod+Pc1pKbTb5ceyc2Bg Vlg2SlQu2wmP03D2nOoe0ml6qS/r134gfHv4A+qbaTwe7jh2h/ZgKn+M5KC5uRo= X-Google-Smtp-Source: AGHT+IG+6sarLCJnrBKoRA745sjlTCC47Zh2hr0Oj5OjLFhFesKWWQAzOCLBOFG+diDbRtfIiv9TYQ== X-Received: by 2002:a05:6a20:cd0e:b0:1cf:6c65:b736 with SMTP id adf61e73a8af0-1cf76358fa6mr2638356637.40.1726126832155; Thu, 12 Sep 2024 00:40:32 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:31 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 25/48] block: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:58 -0700 Message-Id: <20240912073921.453203-26-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/ssh.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/ssh.c b/block/ssh.c index 27d582e0e3d..871e1d47534 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -474,7 +474,6 @@ static int check_host_key(BDRVSSHState *s, SshHostKeyCheck *hkc, Error **errp) errp); } g_assert_not_reached(); - break; case SSH_HOST_KEY_CHECK_MODE_KNOWN_HOSTS: return check_host_key_knownhosts(s, errp); default: From patchwork Thu Sep 12 07:38:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801604 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBBB419E982 for ; Thu, 12 Sep 2024 07:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126837; cv=none; b=mxYdT6bG1UKwnoF4CW9IC5U9bUNox97hBPWMYPwHraIbltyQvlj/WopvYPDgDxkWwUPI4w5ccqht7tHTQS3mA88Sk8keGuhEO4gecs+un5S5rOUX+o7KHtOrtnycIvNV2mYM4NWzgb+X3/vaXTtNAGhnrZOQYzS4C7Hhz3new3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126837; c=relaxed/simple; bh=rf0i3YxuwZDwdGspRy1Xpx8uuAemLk2xKQyv9UQv0OE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K1psn5/zLm5xX9WVK5PxndIE+kerGYlI7Zp2uXWZMH6cZd+l8bH29U8g19FPEjmF/IQpVndTwgy0odAXqRYhNsBs+i4922TogZBDB+liJirPzh2dL1KCR/d+oBF3+wxAOs+Lq54hVZXHy/AV5DHrqLOlmTs8ps3J33o5+OiVm0M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x93+dGY8; arc=none smtp.client-ip=209.85.166.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x93+dGY8" Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-82aa8c36eefso34512639f.3 for ; Thu, 12 Sep 2024 00:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126835; x=1726731635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AEyQ2xcAnmhK9ml4jXR52VoKIjk53wwLwPkspMKdJxw=; b=x93+dGY8GwiC/r145cnDRr1HoQRclDtx/0o0vI+jUAK1dY6d5Ub3pVPGwn8G5gakCS nFqSFJQgut8Wp61fRqq7pnAtzZA5qP0E9PEU25EwUMEyudWFis7XBHDxsbZmPI7hbvwH kR5geT8x669xoYm/daYoedlj33Ec6zNbANMP+xeEg5Oel4yPGUz7jREWzdb2ou8iria0 gXlsGz9c97OD8Za7cd4/+2l+9Shf6ZsqlSN+HvqzOv68by5PR7JOjDXugLreZfYwO5WM 5Q+2569MGZsEeN8bsk1qIP6fVZ1XrEX5DA0mvR/n775OC4HZ3EGa+Mv0/lA9QW5v/Ry/ 7vcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126835; x=1726731635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AEyQ2xcAnmhK9ml4jXR52VoKIjk53wwLwPkspMKdJxw=; b=kih7TJeRIkayOSWr6dO5WlODBzHzZMypIQf+lV5ty7QfhTjyvp2K387ZdTwR/0VjzO Nc+VOp1iMlRgvEMUumUq7/UE9a7MCd1r0h0J89kIGB5I9ilxDt5TwViI+qKmc0fDKHKP ROdEya2GTw5Xt6l0Iyq1fJvJ6lBxVib/5lGT0ul60c/PRcVO9mMgbJRovfvGKL78fZpD RrrD3oL/DU4hGnwPTp7fn6nHN6b36GNCczILwQFLecMMZ+tzMAdVK0YULCCl7ZHjjc+0 hD2IQnePZFEimrdEA1R2ghpW+P34pAHAJNApspydoi1yc1dolZXLqS1tMdNA8L7Pr9ue N3QQ== X-Forwarded-Encrypted: i=1; AJvYcCUPoTopUCsLjhpkCJIPYkZKCKJVpJU8Yth+EE9d3X0wjSs+UKdj8rMV+Bjpb2l4UsH5dI4=@vger.kernel.org X-Gm-Message-State: AOJu0YwHtimRgvhox3RUZgiJLm4AvFd5MehP/mMHyaQDuxxFICgleczb pzVssIwLwbGwffuAEMbykY9jxVghUI6rgkqsVnuzX8GVBmTjzP0FB4aXyIYQ6ks= X-Google-Smtp-Source: AGHT+IE1ZM38e31F8YJ5oP22VNGbpDaEZK1YoPHZ70nspmYJNabyI5hv8MwCmiBG5cRfcCe0ROr/ig== X-Received: by 2002:a05:6e02:1a81:b0:39d:2939:3076 with SMTP id e9e14a558f8ab-3a08495df72mr19677125ab.25.1726126834897; Thu, 12 Sep 2024 00:40:34 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:34 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 26/48] hw/acpi: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:59 -0700 Message-Id: <20240912073921.453203-27-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 006c506a375..34e0ddbde87 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -535,7 +535,6 @@ void aml_append(Aml *parent_ctx, Aml *child) break; default: g_assert_not_reached(); - break; } build_append_array(parent_ctx->buf, buf); build_free_array(buf); From patchwork Thu Sep 12 07:39:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801605 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193E418EFDC for ; Thu, 12 Sep 2024 07:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126840; cv=none; b=KZnXZd5WL+A5Eu5eXlxwHvsn5Wx2fTU9+OmBiJLdNYUvk1hftiOhHLCKWVKbSK8TbZJOiDS1d7a3Q6GdyibkMhRUNub2IfN4vBHEKyltQzXUWaB98nFPLc2V41RkVpNtrfC0BqGYby2VPi8sO0g2yOtLFbOb3C5DAvL8fhUwKB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126840; c=relaxed/simple; bh=mu69ZBumLbFFvRRxjSHST2u4HDWiZaAYs3CFfCmkv90=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=PNoBqJcIehIE0+01LVvylD15269Xg1JbWD1C9UICxWAv0qCOGvhB8M5AvA+nRvlhAoslSNik/S2rdDeBay38/5H3WB+VARbcw/IrPfIYKlqwVZcN8o9EKi2SbQrnHnmsvjUI7Xe3kDM5YVC0lvN6ocHh7DpWz1jlh+w42cnyaxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FWcgFIhS; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FWcgFIhS" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7c3e1081804so358823a12.3 for ; Thu, 12 Sep 2024 00:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126837; x=1726731637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T4cUmRJxiWI+4P3xFKTX4Sejqig+SO3wUE6UW4QGJvI=; b=FWcgFIhSFQEejquGqFhurpoB3YK4HsP7ZQmUoCSfUfRT6Tjz38PSD09DlntBgxCZ7O gKR/14TzalfKtJCNIXGS6iYAIck9KmWgFrC0azZmADhboTs17fplBdmUosgR1x4ZGtuo GHMvLKVM2ICIWOp7CshRoQzdUDrZc0WVCTdJpUT9dhWsFOXA84c+zdDdyE0slFdPtfYo iF4UMormKFUaBUxhYO3IXq6nmQBEVwYgr+yGB/Eeu+LzF5Jee2Y6BmFYwyFPBmuJZF53 WIFOF+yWvvfZmNO5e+AH5fmJ8BteJ8AWHnYe+rkjsSza6Q+RibWdhHxXO4TNysxnGn5/ BTDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126837; x=1726731637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T4cUmRJxiWI+4P3xFKTX4Sejqig+SO3wUE6UW4QGJvI=; b=Mw4F7I8hZIUp01QTT/iFzCDPdwOSXzb49/tompTYsss0gXk2cZDeA6K5A21/kUFK9o jhJ7rn4fpw2ZxwRUZp85ct5lUtU+hxoIqCVMxWeK0I1Ovnb3cIQVDEzaI0vvxTYjxAlA leZpiUmRmV6jZwtT8C9nqqbdMvvRG6eKqBzsYaiIxqHTRmKN+LjZdeQMgokv/R+v7II0 WBJaNW18djCFZS8OkU3VrIBT/ddnJZN6+qXk9LQf1FqceJyI8wJ8ipWbdBKlsyCcStmO HaRYbU/V1Pw/I5iAhlyUw+fIG7R2+60I7q0VqQzi19Ch6nAtDvPgNKVN1aY3Vfzvi7aH eERA== X-Forwarded-Encrypted: i=1; AJvYcCUsrGhLkJCp4jVNO4c1QVjvVnYghHMu+wYHVtoymk9vbzQ+XR/6XBSEz3isOyZykefEUYE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+Ktb+cYG6NF6pLRCUY1Klih7CCyityZmt8XzjSP47ren+X93F JIix5SPKyp/IwlimwfGGvmjlrrFKhorBkoBIvxufrt/WCPb3BuINXPcdbX43Xxg= X-Google-Smtp-Source: AGHT+IHas1oukAOaDNvjAJwoGhr1NcYPZnCTY9G18MbXXKsVaftCFarfJ0eM/UXI1bph8rnTKBJZdQ== X-Received: by 2002:a05:6a20:c6c6:b0:1c4:9f31:ac9e with SMTP id adf61e73a8af0-1cf764c2648mr2589519637.42.1726126837349; Thu, 12 Sep 2024 00:40:37 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:36 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 27/48] hw/gpio: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:00 -0700 Message-Id: <20240912073921.453203-28-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/gpio/nrf51_gpio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/gpio/nrf51_gpio.c b/hw/gpio/nrf51_gpio.c index ffc7dff7964..f259be651e1 100644 --- a/hw/gpio/nrf51_gpio.c +++ b/hw/gpio/nrf51_gpio.c @@ -40,7 +40,6 @@ static bool is_connected(uint32_t config, uint32_t level) break; default: g_assert_not_reached(); - break; } return state; From patchwork Thu Sep 12 07:39:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801606 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E60D2191F64 for ; Thu, 12 Sep 2024 07:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126842; cv=none; b=EBEvfEGOmNg12L6Or8F+PGvj8gsWtmyogifuaif4TsYJbQW15XJ4MZoUCk289Djn5DXz/kenP559UbrnsDVROWAgFNtIoXx43mntyDnsp65lBx7LIujvU9UovNNLEqyxNa37/MeNYKgq2FCi+9rAEhD9b2miisnLhIQVThSncvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126842; c=relaxed/simple; bh=7aF564MlKMlP+tn7TYfgvThEYzDqQarXuAJQXDIdP3E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=QUxMxo77nea4bRcKLlJ1fvn2nR23WmV4wO8OZ4z9+LVRT6CR8wRsbZYo9pu6RdkhTj5aRWmaZ+bKxQr2I5tVONWb63NDBj/vCxVee41RXeeXJMDZ8+nL4g5YqH3e12nTmsuhGK7SgnWXEN5A1IIFosFxUseaq2ojaU+3WZKdYnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f4DbkHQr; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f4DbkHQr" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-82cd93a6617so24113639f.3 for ; Thu, 12 Sep 2024 00:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126840; x=1726731640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aWS8WcyTWapQPcbM+bRD40JZ4f8WdoLt0xgMhn2PBmc=; b=f4DbkHQrgcumxNibsRDlufLGBWwFD61WGBqA23Ryiu3poE7eYyJzopixlcqjBpSpVn 9l/1T2CadaVXBmpqeSu+cGWHrBW+Vco8rB0CCCaqtS/4AOX7Y0keKRuUDtknsIkiKeSo dNkVvGaUHTq2bU3cJ80XRmo9aQDAsOxsa9qGCn796DqbLSz3vBRaIkpnNk3hpI4u3WP9 mWKFSEnH/qTY8C0l87KnfKzFG9wfzxWOE0Ddnbh7hXJqGLUsDi1avPH39lSLVGBkNgpD vhkcSjZdJOwwnA54mfNYyy3YukmRNeZ/tu9pLRmYvC3l4YkB581b/1q7OBt4TxwNh+5y WvBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126840; x=1726731640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aWS8WcyTWapQPcbM+bRD40JZ4f8WdoLt0xgMhn2PBmc=; b=lFubUkS8pSEA8eg41juOneXiEbDmq8x4tyiHiZ/0A3QadrzYEpYu2Z7fHS8HIaDZGZ o/c8sMf6/oA5RvgBxFk97BSvyEw0WDc1WE/QRDTc6du7Oi8Z6pcOTcw5il6KylgJAi7Q rTFeZ2iKnMjrbfIQ/8OughzAPrZyzCIAYwzsnR4+SPT8mfKCZibygZf+5NH6HDWUV3sQ f9o477bGwjmVMkW9rfA4rSLHAadbBYhEcFq8wp9UIU3aqNcKqhiWAJM+CxD1FT5ftaG4 ho4w/RHEAfJ3VQcHrzCK3t3bpovOd/iuiChT+K/I3bzwatKs2N0ZLIxbmZECdGEY1XFv SQxw== X-Forwarded-Encrypted: i=1; AJvYcCV9D+74i5WMCTRf0kylh6RPgQM72XAgqcXl2pTLfThOQqYgBD7px1BQBgQ0x3PBhUuE9ZA=@vger.kernel.org X-Gm-Message-State: AOJu0YzJoNuf5OYRVzyfEP26zy2VjhBhMV7cXnAGk5oMStQkXBQW1HFk zydYRC+6PXI8//o2Xukuu0q6yvjZQ1oG1OfpnvR/OXgwbaBrk6NowGuodEa82oQ= X-Google-Smtp-Source: AGHT+IFYzQhybkxo/re134Wva/li7Du5eyOeNHQCOj8YeNMIPHFJEF4Fg9V+twS4J8sKDv4Qe7CqZA== X-Received: by 2002:a05:6e02:1383:b0:39f:5abe:ec25 with SMTP id e9e14a558f8ab-3a08495478amr17127215ab.19.1726126840002; Thu, 12 Sep 2024 00:40:40 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:39 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 28/48] hw/misc: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:01 -0700 Message-Id: <20240912073921.453203-29-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/misc/imx6_ccm.c | 1 - hw/misc/mac_via.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/hw/misc/imx6_ccm.c b/hw/misc/imx6_ccm.c index b1def7f05b9..fd5d7ce4828 100644 --- a/hw/misc/imx6_ccm.c +++ b/hw/misc/imx6_ccm.c @@ -301,7 +301,6 @@ static uint64_t imx6_analog_get_periph_clk(IMX6CCMState *dev) default: /* We should never get there */ g_assert_not_reached(); - break; } trace_imx6_analog_get_periph_clk(freq); diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c index 652395b84fc..af2b2b1af3d 100644 --- a/hw/misc/mac_via.c +++ b/hw/misc/mac_via.c @@ -495,7 +495,6 @@ static void via1_rtc_update(MOS6522Q800VIA1State *v1s) break; default: g_assert_not_reached(); - break; } return; } @@ -556,7 +555,6 @@ static void via1_rtc_update(MOS6522Q800VIA1State *v1s) break; default: g_assert_not_reached(); - break; } return; } From patchwork Thu Sep 12 07:39:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801607 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A734B191F92 for ; Thu, 12 Sep 2024 07:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126845; cv=none; b=qUTMVWsGNMMp/lTwA0afa5lXhfebheKZ8WOuAqlGjqG+7+F2SVUonS8XPingfQq415YWoxnV+q+JZVKel/n9OLOWRGQGzUHZA2X3dWjhT1FWQiVdZkd8kDFMVgeU9K1z7a0rK0VDO1Yvpyb+O/+/8fIwTHXhJ/6OkfbHVMhXiM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126845; c=relaxed/simple; bh=qC4wKnukB0flMb5G8CMBXNITeBvXE1SgEbkmGnnfXeE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iYHC7D2ZANT8mm/CKDHRrR1SZJCp4cnYFdHbT5tw47z36bw/uOJCMI1+UjFetxtjm47wkYuTQpwQ+bFLZCwAq0nZlpko6V4R+k2QZMYZXJDGpVBsZy5U3IvVGVX3SAwDU73tRdsXI/8RwNefXbeBiMF6XnO6O6LBrher1icmTxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xxZ/kTdc; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xxZ/kTdc" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3e03f8ecef8so373652b6e.1 for ; Thu, 12 Sep 2024 00:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126843; x=1726731643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MrI0OydCanDe4oYc5C9zQMsS9yO07eCq04VfB2/4Bq4=; b=xxZ/kTdcZruCuDQkaNij6s+j3CMR6nv1+R6CVwPmn9AFgLt8zrDgieK6Cu9VGkAdRN Ta593sOqlljaK1h/S3JaWGLTDOxFa1Oqs7ytRTBi4kTN3zQxNnuqC9H8YAW1kGsDsxoI poUbtyt/tZiZUjtJc8j3aF6n+u7+FvStj8A7SIZDKTQrkborMNIZsKh4NdG7RKDTzafz G8Sj15IJ6aSiOEzd7GAqL+z4wZSMMSt0iKY+QYMKjPoVAPKHDr5pnuEYYdInWgUMtmqS tKtsccTEhfKmC30P2loVaTEnSkpXJ7H4MTVan2vMXNfcIA1/T4pYIgoXWz/vtHuyim2+ KPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126843; x=1726731643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MrI0OydCanDe4oYc5C9zQMsS9yO07eCq04VfB2/4Bq4=; b=vDIj4zSxJ4/X00vVjHx152aq05KQU26hWOgZ7NoTsrzuCsZ5ADF/WbtY8WBzK38yTY j0mhmnTaNx3sR30cGycc4pR7YSspcW5I9HCrShcmHsmP/oYnIBCPazbt92PgHcaF2YPD VfOJuSV3OdwcNFG4i0+qqmlbhe3Ij8sTyyXcpSZ0artYrZEHPFVBg5piz0E8+FMBS18C mr8DKZOL3b3W+5uuo/cz6AH4Re5fdADR37ysXESRKLnUY7otVmOTealq7FpfF/ZXQgYT rJb6YxXvLU4kORlPylF0BTT2nojShzPaZTPtJiGU5Uk0doQNK+0o2qpNgid5wdyZIv3z UWPg== X-Forwarded-Encrypted: i=1; AJvYcCWnXnXfm0yG5MuT+wTQDa7YLaAScc7gUC8gN+wVVX5ZizvzLJyOF0RQav6k7mXrji8FNP0=@vger.kernel.org X-Gm-Message-State: AOJu0YxXfx8psq2nZMpbVXn0DNMjTN8jIy1iGEKMZe927n7cKpL2Hb/D 7wzLO20FGOFmyh031BW40BU2pUZo5qBnY5PVXdw9t8wBVyiivJRRBncreh5BdIA= X-Google-Smtp-Source: AGHT+IEML6r9h3ccLEXSox/u2udrMxmikArR/M0ZN/wJcIkH+O7ao0M/eUBiNS4fvB7hhlhdN9XfxQ== X-Received: by 2002:a05:6808:1594:b0:3d9:27f5:5251 with SMTP id 5614622812f47-3e071a852a7mr1675735b6e.5.1726126842725; Thu, 12 Sep 2024 00:40:42 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:42 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 29/48] hw/net: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:02 -0700 Message-Id: <20240912073921.453203-30-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/net_rx_pkt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 6b9c4c9559d..0ea87344745 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -376,7 +376,6 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, break; default: g_assert_not_reached(); - break; } net_toeplitz_key_init(&key_data, key); From patchwork Thu Sep 12 07:39:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801608 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A5E6191F80 for ; Thu, 12 Sep 2024 07:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126848; cv=none; b=rOYU96DRNVoTJVndDE50h4inZgp9j+8LaQZh+V6kJMYfAiMrBkYGdnXzdrEHKJZImAUwMST0ARcCfbB3GEVMpEuepyeOntVnYpUAo5QRtxhG8mm7q2sKTsWUUE7/ZRfTknZoil6pv85cFT5y3Z4oy/cguy0jdlOCvsAepxKXYJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126848; c=relaxed/simple; bh=6IxNtV2pSABUGEVqYotLXDo3F9afyAR4ukMpE2TbNdg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=hy4c9u9T2Rkn1yxBMpTmGqbro5SQIytSYlQ17spSxQEfBsxEbt3BjlST3rVDPB2t9UGd706B+xrwC6fauGYUrs1CLnxM2aLar8FRdPdfS7fJLH8/aHB3ByjKdqPZCJF01AGtCvTArUyVWZzh6sd6dczlDR68sFbLA+udQ/4jtTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IvhtMO/B; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IvhtMO/B" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3e0510b6647so258039b6e.0 for ; Thu, 12 Sep 2024 00:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126845; x=1726731645; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G15/cfLWuhy58D3S6VTY2yyYFPoVOBpPVm7OgoLv/9Y=; b=IvhtMO/BHVqdK7MjPrRW5nr2C78T7/G/rz6xtOOGbE55V/SHpAXjqmgGnE3lQtSWad BFbCU2ifv9pPLePJtQbMng/g4ExZKYhFYKbFrNByYJxpfaUEZQ4MvrSJC3sfHCNWHJMW IrdKuPu9BZdwPjupLwZkECfr0PHgAoG0dZkKZ/bqSPy6mhr08ksDa5XLlwI27vi8tXVW nxVlsuiUsHteqNl+QTSS0cfKou4x3xq2vmOi/RfEZB8Gy+0ODy+3tJ2KMbtocnypv+XP YnwnMEyRYEZsJOeowArpjeiwS0FCYTbDSFn5G1oPbmjWraP9tLqXKAUfNUENfDU0L0Hv Ir1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126845; x=1726731645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G15/cfLWuhy58D3S6VTY2yyYFPoVOBpPVm7OgoLv/9Y=; b=b5wqAENDOSUta1a0whl2qSp63zSs4sIdEfqXryeDTFvOR5oIdMba2AIs1/AfJQgN4i BvfBFXI/kT1wyJg0KXlvsgJ06uCMrkm+qGSgHzI6c3ATOFS/1tisFWSf8XQKbIgzhx3B dpyP/2n3XLoqjUlAqAHON8kwkjLV4b6VTKHHfMOSzNJ6EtkdcA1Y7kQpNDMKuhvf53+o HsbQwVl+jST6/X1843Qb2q96hCEzhFVfoPLwhmH+gmd9JvGTZHIPLX+ACaB4wDabpqJo ejVTJuHfhgBComc17rfckk+I/Nkxj5huDlYAo3DNNKPXFKVz94bD/+GhOHuXA0xA/bnx MFaA== X-Forwarded-Encrypted: i=1; AJvYcCVdQJvKKBVuHHTjZqqr3Z36CxXDlp7eXjfhEx6Yf9/CAxDSHcYagHMB4wh6segJPtw0jfI=@vger.kernel.org X-Gm-Message-State: AOJu0YxwbtjY4+x/syXD9A1Z0MxoiFOFMRL6pUNzT0Kurvgyk7AQJj3N D/ih7NffwHIV1Msib3Bt/5tk+iA7UI1Zw70a8E8P9khxPP8iWPkAMkI0k7kLT88= X-Google-Smtp-Source: AGHT+IETN6rcEOkN5n0lmGk313YArCk9WXbSbiIwWQ/b2J6sYsWxK5jf+hG5cA2W/PAz8ROKcimuCw== X-Received: by 2002:a05:6808:448a:b0:3d6:3450:7fe0 with SMTP id 5614622812f47-3e071a835ffmr1063495b6e.9.1726126845522; Thu, 12 Sep 2024 00:40:45 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:44 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 30/48] hw/pci-host: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:03 -0700 Message-Id: <20240912073921.453203-31-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/pci-host/gt64120.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci-host/gt64120.c b/hw/pci-host/gt64120.c index 33607dfbec4..58557416629 100644 --- a/hw/pci-host/gt64120.c +++ b/hw/pci-host/gt64120.c @@ -689,7 +689,6 @@ static void gt64120_writel(void *opaque, hwaddr addr, case GT_PCI0_CFGDATA: /* Mapped via in gt64120_pci_mapping() */ g_assert_not_reached(); - break; /* Interrupts */ case GT_INTRCAUSE: @@ -933,7 +932,6 @@ static uint64_t gt64120_readl(void *opaque, case GT_PCI0_CFGDATA: /* Mapped via in gt64120_pci_mapping() */ g_assert_not_reached(); - break; case GT_PCI0_CMD: case GT_PCI0_TOR: From patchwork Thu Sep 12 07:39:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801609 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3FA918F2DF for ; Thu, 12 Sep 2024 07:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126850; cv=none; b=FlDLLPgpQtAfkVrT2ku9K3R+c0a18ZhQxGgCcvAeMRlqcj7HCpZzR9TxqOWL0plXYvxThirCDr+HNdDA0NiEZOQFDzz7kYDzIm17CyxkKpLopYp7gYOpZjWFVladdcwbGbDLAnWar2L1YBjhCW/T5KdCn8maGEixMRPsBvhqWNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126850; c=relaxed/simple; bh=ZFp789VAva/F0U9wgHfw2gutxCS7yC4LhuLCH+J497w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cGWLIlSvKiLIamEay6BW87/yUNna6raEexVs45LRrvA506ORTBE4+Z+TF1ahl2Fs19+EkhLHdrT6FLdEukHCfSo98ahikAfs/Crtr8Yl2zWj8Og3N+S5vthd+anzA0j87keXI7hJt4EI2J6d+w585FdKUwkHuZnk23wf+chM4Vk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tdMZKn2t; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tdMZKn2t" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-71788bfe60eso454878b3a.1 for ; Thu, 12 Sep 2024 00:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126848; x=1726731648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PpoFW3JjD5zeg9AjFjAz2aaQ3UrReIS3eTyx8szr/r0=; b=tdMZKn2tZWJjDTrG8Wf63db6GxQGyx74vXYsJYS7Uhwg6gUBEUdRXC76kBWp92cXyP zVhm5JKT3Otx0ntmogVI/G+Bnv51hDWPs9RjxcP1DRADVHTYFlI8WmN+c//DbPMcAAcy pW9n9egrF53awZBUIFlFtVk//LBrrGxFLu+er2z9Nz9dBCjk/YgOe2xCVb0MiC9Qe0VR DquulfZ/n8KCKlUWNxQaKW3WrkY1pqFjS8KjKpW/tJIFHcaIZJ5apY7XpnDyB/71Q7cF A4dcaoE14XTdyH9AmBbFXrmG1dtkWECNpG8vkyuGrrxr7Fk8YkLKz8GJF3eqP8ev/ybM 8DzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126848; x=1726731648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PpoFW3JjD5zeg9AjFjAz2aaQ3UrReIS3eTyx8szr/r0=; b=Ythrk5D7V6UYh4qCjRrg8/7uw/G03jwa3zUuxtGbrLZ5aZiNPwwQb+EQh7dGZDC2+E Z4f02WXsI9LRQu7EumlCH/bdGNbBdRhhs2vnyMpLnBxLqEWDWY0SBiapSOeHyXKajYkW jGbvIX3UFeptd3V0vRQNQdxfn0S2rsCWLagZ96e+0lcPRZkqf1jDR4j8Jd7IGm/oMSGV 11XSCrU+JceqfPJ6Z6JoLKG9bOAv1/tCIePCI+VZ3wNFXthUsDjeSrXeAuah8S0UaX1Q zDP6GjDVlIs9xbEuwHRUjDYY0pQCvrkOe3lsYOew45lRRGeOzsn8/CAGY3ZiAmB63uX3 SaGg== X-Forwarded-Encrypted: i=1; AJvYcCWkBmF9I9yJ03lnWEBpVLM951Bzwd/7rVCJF9ClVFx7goPbotDd8cKb3ZFhKv4QZ+dkK/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxNiL9CtKFZV58I/YU3RdmnVN8hl52kkFXoeuqlK1mwT8ctNtUt fwX79n+U7l+mCRrjY8bseU5Nkxl2C7Ut0Vh89hKQXhFyMpMnHgr16lY18C9BWOw= X-Google-Smtp-Source: AGHT+IHrNzFr8rAxfNqGUQ/W4jAVrPS/G+v+L27QxJD+DkA0TVwS9jjC8lWOw+J53BlKzThCp6mjqQ== X-Received: by 2002:a05:6a00:8d0:b0:706:5dab:83c4 with SMTP id d2e1a72fcca58-71926087f29mr3097493b3a.14.1726126848124; Thu, 12 Sep 2024 00:40:48 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:47 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 31/48] hw/scsi: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:04 -0700 Message-Id: <20240912073921.453203-32-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- hw/scsi/virtio-scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 9f02ceea099..6637cfeaf51 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -357,7 +357,6 @@ static void virtio_scsi_do_one_tmf_bh(VirtIOSCSIReq *req) default: g_assert_not_reached(); - break; } out: From patchwork Thu Sep 12 07:39:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801610 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 590DB19F132 for ; Thu, 12 Sep 2024 07:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126852; cv=none; b=KEXmQPHJEQ8oRSvjT5ewxg2qxfRZZrMEzqpbGOwvT4KH0U15/on0VVvHEa1N0GcZ3t0m644Y+Xd/dEUc0I+TGCe3Uv0RRcQvLMggJeZOXpW1F4NWUcICi9cOzoFNSYJoB/uuOjdtpDlAvNBdtXMYbfiOemajLF8DS5pP13f46jE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126852; c=relaxed/simple; bh=iPFi/mpyhuW5OJTeNuwRNlqh7FyqXyl7xKSZqYwXCio=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sWDCaNcglk8KqRg9zgEGD3wJrXN/40rVeZtUSOE+X0srFxHLOpwmOa4UtlrqAUkAYnhXZKppZD0CVsaWZLzUIh7+qhOacM1mcyr5NXSX6sZEhkmWXMiJ/ISOFS7HFETvHjUkqh5r3vUyAds7ICucg0mEu53Ja7CxFFaDi74rOP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nFRqFEKx; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nFRqFEKx" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7cd8803fe0aso508010a12.0 for ; Thu, 12 Sep 2024 00:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126850; x=1726731650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rh7of/t1MbINnko2jvt6jPS7AWm2aGYUlEka7psebCY=; b=nFRqFEKx6WvzZXAeBAMX/ga85p+jEzP8EJiTpazu6rPYXKB635XP9KELrg8Wm+C/gI fIAJ/8amRqXeHQ1UW1QM/T5tnceCzauY1I9dmoKQ5NdnuMcx8ryodttbrnJUQVc8FmBg +h6PTde3eI43cZgh/1jSJSiXduxn4unk+LvpfyM6BXc7Hj0Vd5rd5AMCDZXvoIVxFFLB IMt9+5BH9kJuEH7MZwc2sx+D/eAT5z36GRFh3K1KwySV122/+cUSaj8roAMXt1rQEilT t9kIs8eCcKGUWwusY4qoAVOskZpyxHJ9LtW+UvmzJUOqVvL3GAUnKGM/eHPKjzbT47ps omGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126850; x=1726731650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rh7of/t1MbINnko2jvt6jPS7AWm2aGYUlEka7psebCY=; b=VNGOtRdYF/sOMShPu+moObi+tCOMzL/0InTJpi7L+42BrX4Xyx5ykn7/tXjeW1rVEY trlMxpkewZXElgamOvDjQ3IDKBzlQB5iCnJ9OMAy0RM9u2/UhB1H0+XyJSr/qxmFoQ5L KPybwrQohbzKrGOLkLdVrR71liYlKJwg85R/a4u/y4z885FJW47BHX8yPt9s9cJKUXDe HkvFO0FyrqG7fm32SKdDgngSBrBdY9DkNxu0S+qWnVyPongFC/PUXK/FVtdDT8XRXP2w He0O5NU3ziIPFXbHZhoAa90t5ogyzbvNMlnS45yy+u1b6kqCeS3hirKJycZGHqtm2EWa uAMA== X-Forwarded-Encrypted: i=1; AJvYcCX6EFc5+ta/toew6yJQdRq78gGbEZZupyzqqVKrhG0CvN7r3IFYEOfyG7KFMeCrIbl2VcA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx71R9BNylaqL7ltvoioUMu3T0VURwmnELdvThXTZBYy0UT2By1 +2MCKls5JuJht26A1WTjF2VbnTAuaJpwK1O2TzJTUpjn6/OA6qhig1aVKoJBAds= X-Google-Smtp-Source: AGHT+IE/Mzhsmhy28ucIa8utEKYRtipx+MoivQXHJ4uIjGCaMxhEkc7uFeHW+uTK+aUE2aAYgUkm3Q== X-Received: by 2002:a05:6a20:2d0a:b0:1cf:2513:8a01 with SMTP id adf61e73a8af0-1cf75f0f0cfmr2364705637.26.1726126850599; Thu, 12 Sep 2024 00:40:50 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:50 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 32/48] hw/tpm: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:05 -0700 Message-Id: <20240912073921.453203-33-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/tpm/tpm_spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c index e084e987e6e..5f7a0dfc617 100644 --- a/hw/tpm/tpm_spapr.c +++ b/hw/tpm/tpm_spapr.c @@ -206,7 +206,6 @@ static int tpm_spapr_do_crq(struct SpaprVioDevice *dev, uint8_t *crq_data) break; default: g_assert_not_reached(); - break; } trace_tpm_spapr_do_crq_get_version(be32_to_cpu(local_crq.data)); spapr_tpm_send_crq(dev, &local_crq); From patchwork Thu Sep 12 07:39:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801611 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3277319F132 for ; Thu, 12 Sep 2024 07:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126855; cv=none; b=m/aHYy6XOc0J8VOz4+G/fRLW79xIT9IUENZRXZzNkkx8oTFolCaKzz/wA9HgHusVWRoPaasK6qbFQ42So9O8yI8hq3XuwkIfIdPJdyRzhkCpeavrMSAohvADQ+/2tvhZkEV7SWOwLqKHTZmi3hDSBRtM3DIyiTdXIzyOwgm9PZc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126855; c=relaxed/simple; bh=vUmggebk6axfRoX4t5h3002427da0v/xYYZvwb3DU+o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=k7tgKe9ppDshp1dH24brB6Gx9xqlZGTXWiGZQFmnMRDFnDn7uskc7C5BC3OyjjTXcuxTpb2oMIvLD0WuBa947UHDozkkGeoz4SSsGhXx4bod6UNtFJMpc8W67exbe4G1rOgB9I6TDAPeIpurXrBtpJRYSdYAk4n7xCnlZuc+xnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ko0X4Yst; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ko0X4Yst" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7c3e1081804so359139a12.3 for ; Thu, 12 Sep 2024 00:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126853; x=1726731653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZcvwE9FJNxmdIVPlBQdfypY65+b/8lDno7KQ7aDgr+A=; b=Ko0X4YstiVV7VYalXNGevEEtmqCVzSfeT5D6c4CvJp/mHQGfcBb5x3fJZ+1oPyk3Pc YEg8oDMNidLg1YTOQj8W1rGn585NlOjKDFVf33c/+OIPlzqT34lswBicD9jhcuCdwVmN SVyJKt8unDgy+EeZvkgma6/FmYV1FRvULZ+EIQishVKpjQtm4/f1ox4rtvfcjHKaGXIa qA7qFydEEMCLdHu/Op9oQSVWKjVVoTeYX8SyRhOSDW6cOBxO1tRv2ERO8RF7NYEc24uf 3C+uKN6mf9D5XZRfZAiK/QL2i8JDKhi/P2xflCO6QRVFiaGgPZpDdfqmV/14OheHImZt DY1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126853; x=1726731653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZcvwE9FJNxmdIVPlBQdfypY65+b/8lDno7KQ7aDgr+A=; b=gTUUQw2CyOmi/aAo7+GXKIQIDxWeQ0BAm4Bl798JbGyzv/FapDm0yXdohyS4K9Bwsz mlMdT60SZct3iQ9FxH2voHszH1MjdW3yBOgruAkUzoYDGKsIAcC41Oykvd9gNUdx5dl9 BPQ71MGlq3cV3LNfAM5q0SSak2u5871dUrDfRNpFUynJctCtO3lpj0cSEX8o7xPPlKoD 9WIA6lQ5vwXFa7sZxmCwzgJO5n0F5uttV4YJ+jfxF3uDtc0JY6uOZnxLNz55yEvTVBcp rSSQ4CBBd8kfZvCc6Qq0bdJnJVGGYwQ5XoMmCLJRjaI2wPtGJ+eepv0ptVLUoUc2bF25 oCWw== X-Forwarded-Encrypted: i=1; AJvYcCUnt2RCuSx6kFuP37m7JSU9Ud0/8laBaNuNnKibaSXlvYGJFabAH7u7uozQ6wfD0/JGdgA=@vger.kernel.org X-Gm-Message-State: AOJu0YzLkPBo/e2fbkAnt+0wP3CBGl4CqszdQZgOHHbx6BlhM6/5ulHf Y1/HzZIw+XI0yQQtjP1EXfEamBJHpGZfOajTx1JD226L9XH3zQVgzHKBYRwYzQU= X-Google-Smtp-Source: AGHT+IF+BwpPE4A3M7aIxv++xh3a9Ty8RvQxhzK9f6I85GUgpXeWj/nLy6PCJ/dYfr1LgiyAJ779DA== X-Received: by 2002:a05:6a21:a34b:b0:1cf:6b93:5622 with SMTP id adf61e73a8af0-1cf75ee4d05mr2672158637.14.1726126853641; Thu, 12 Sep 2024 00:40:53 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:52 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 33/48] target/arm: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:06 -0700 Message-Id: <20240912073921.453203-34-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/hyp_gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index f120d55caab..1e861263b3d 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -158,7 +158,6 @@ int insert_hw_watchpoint(target_ulong addr, target_ulong len, int type) break; default: g_assert_not_reached(); - break; } if (len <= 8) { /* we align the address and set the bits in BAS */ From patchwork Thu Sep 12 07:39:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801612 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1943D18FDCE for ; Thu, 12 Sep 2024 07:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126858; cv=none; b=MNFyGvTpZnQkl2csEdaxOpKvBYFF6VSfZ5w1+hy/ejz5dSIU2QRJe8zUZ85NTnZ2NHN9AoXcYdj/M1H/Vrg7JW/5fgfwRyUPZR79ZefTJhybinzkaKOAiZ5ld5YvjS2NmF9sryLUx5Zy6UFqLEUgobtOwtGP21aNZBX+GGmu8yE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126858; c=relaxed/simple; bh=ixD//SETRDc8qYWsGCMhl5yO9DlMKyy5wk9p5v5F6ro=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X2DlSoKJkjUKK1LyfOqLEogz+mN50qDkIopltEzLPd7107vmS7saPyAk4L+yNyaHZtyz6pyBAUwn60CblkJsm5CCEvsHr8VrDNokMbsx+c65oQt+Hkwba9ozFq6fsdTAzCR3tP9hVcKjpAos0NB+j8n4CZwCPoEdos6vfY4ExLA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qIjccIbM; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qIjccIbM" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3e040388737so300793b6e.3 for ; Thu, 12 Sep 2024 00:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126856; x=1726731656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BNLX5DGEYX2WSxoAnBw7IllFC2g6NKBNnAohuS36caw=; b=qIjccIbMyMO0LHSgCSGlsQ9XQtluIp6gpFTGeRW9/78r3gKjCtSUx+4qO2NemBDVnP Ww72XAs3ANpStwI3WbPRZZUBmh/PAbqQ2eQNzjGf8dZmzefbr0znEQ+LuUZ9RxSsSAqk iUVCZyb1I9OuHm0KQ8rwZwD8ggIuUuBg+XBd8h0WiqHfKZX3I5aLoGTAtlgasFIMTvul oWGzeDFELBqLuLOVcKtUvO0xIkreFC+vBo+nsFLIDVcokThBd0aFdJl3WhN5hCKT/jMG Md+oCsIJHYq7yxHgeaYrEiOAbr5pNSGSSbXo8rsgJ0Zz4s89dZ4SWK1/cf+of4tnggBc oFSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126856; x=1726731656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BNLX5DGEYX2WSxoAnBw7IllFC2g6NKBNnAohuS36caw=; b=NkbILEXpEu6ORzQhbtJld0d7m1nYiIVR0Z46NXjB99S5RIwgIi32AsU9UVJ3Oxn8vi 6ieMqQRlY496VAKZuD4H8l4giZSe1/+JmNBkgYZDAxHUFSpuJJ0MgN6jmfKdohI5Y/X3 wWLB9uu8tljiLQSRVgnPf8K5Y8PpVyRAfB7Z6lG54UDG0RkpDHpeOXuzYHadKiNlauW8 H0lesl3wZxjfeZEX+K4LIJvmOz1hYszi+QTfzb9w04/ZpGJmWQJrFQhELYHb2f4mLwCB lFQVZ9p3n01Vy22RVtYrbIyihSq1UW8XWJEzjn75l8Bqa+DOCKTTkxWOGm99PKLcg+Pj yGHw== X-Forwarded-Encrypted: i=1; AJvYcCWWUOM49g2HBtY+8WeQGuq5qC3/UIkXTrWE2PtSjTCeOjhY86/XvoIQkz1rXp6vORVT8a8=@vger.kernel.org X-Gm-Message-State: AOJu0YyWsErY1SgcvW6iXBAnbJtX8ZIeY89jGPTpp80H6C8bAbv6oxlG ICKmw9dhOvdHrJ34XI36sua4ZJlNyJF11uyogPR8KttbjwXzedjO4gLcaXJ+SPY= X-Google-Smtp-Source: AGHT+IH+4KhzlZ0oxHJ+Uh2bqKlcjrz6JC7PesfrNFsLZGD4kro1D7yoRsRe4Wd9oo4If8anPJmXNQ== X-Received: by 2002:a05:6808:d52:b0:3e0:4aa3:73a4 with SMTP id 5614622812f47-3e071ab4fd3mr991972b6e.16.1726126856074; Thu, 12 Sep 2024 00:40:56 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:55 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 34/48] target/riscv: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:07 -0700 Message-Id: <20240912073921.453203-35-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/riscv/monitor.c | 1 - target/riscv/insn_trans/trans_rvv.c.inc | 2 -- 2 files changed, 3 deletions(-) diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c index f5b1ffe6c3e..100005ea4e9 100644 --- a/target/riscv/monitor.c +++ b/target/riscv/monitor.c @@ -184,7 +184,6 @@ static void mem_info_svxx(Monitor *mon, CPUArchState *env) break; default: g_assert_not_reached(); - break; } /* calculate virtual address bits */ diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_trans/trans_rvv.c.inc index 3a3896ba06c..f8928c44a8b 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -3172,7 +3172,6 @@ static void load_element(TCGv_i64 dest, TCGv_ptr base, break; default: g_assert_not_reached(); - break; } } @@ -3257,7 +3256,6 @@ static void store_element(TCGv_i64 val, TCGv_ptr base, break; default: g_assert_not_reached(); - break; } } From patchwork Thu Sep 12 07:39:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801613 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B00FE1922F7 for ; Thu, 12 Sep 2024 07:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126861; cv=none; b=WCehbeDPI3ZXvNf/TkBX6ZNJ5njgGv9HgwRHitc8+7+52V6dPiEmWP5W5aQSPy88GhpzXLUgQz1p8dGS3nsL9bk2med3JwTFVO37WBWAuCZNj+8KJWc995ylYvmRtI2aZq+8szmPTDh9+6H3TLbGaIrUWSvuyMYM8f0cvbihgSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126861; c=relaxed/simple; bh=lL5ZkXGgK1njnARcmjFUFsniCJVNlmy3bhgJsBvYxoM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XnK45Ut6o/QGX1mz4rG7KzqkOYmOjtruPRbC7rb4xv2DUHsAgD3arkgwClyxyZBtE49p7mTKrn1FJu/5VUjXCkZrh9bsoQs0q+/tl29Co/3qtoc3K3+KvWrWcbiUHnmcmHfzeNNCXT71LiwQ7a/O1hd0z5DZtmA8erhlj13x8eQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CsklWBLI; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CsklWBLI" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-710d5d9aac1so264769a34.3 for ; Thu, 12 Sep 2024 00:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126859; x=1726731659; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UU43OuMIYQY5gzBd9N0OsX2nGrNJ5ON22GSd3bl0bUA=; b=CsklWBLI1SnXO1XG/Dx1uRLQm9GLkrjfgVO+kXDwIHkwYlX0FJGm7V93malWYwASgN hBzuhs5cgbFscNPD/mLahPRg7ya+6+fUsz5hS9dJc1H1CCX43HI85wjPBHljCBT3WM5I St7kuzNvOaEXljKBtQELpm6Mj+Dk1hIFCerL9YmgE+rEWIkNaBPspfBioWwMq0oFx03M 1DTQgZyO/WoY75Gnl7Zml/jz3TZIRczxTTohTka8dFLVNj8fYzvx5l8RYrrIGamqZ8WO qo9Kqx3sLBWqVhsKvXsG1ZR+NjkRmmgVBLA6Woo+YoQQyJGgF9zrM32kRwpIufntLiJw HqtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126859; x=1726731659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UU43OuMIYQY5gzBd9N0OsX2nGrNJ5ON22GSd3bl0bUA=; b=dh7sMcK7IugZsf7e7URmdNoa8cjRzlz4nxuCkfR7w95Bhi1tstvNaF6NCBhQRUKT8N X/4ZJo8A0eHOrZTnCDp/gIdJZUCNLXykOBx8J4+icbNUgJYGDRkWBUBcTJ+u7dI2sh3T coQA/sc76Al5yt0ITMfY83PkqvAVeLi6IaoGkrb+p7qw9yltVQ04MV96QXZLUsYNMRwz 4pCG9Vg5omhIuFVhYRb/dwswi/KSeOZC5I/NIVKaKrvlL47glkkvj3yTq0PqkKSnHlOp LoeJO0xoZOygwgwOceFEEVI3lYy0eqcWT3N9W7IrUsSyQ8/5MIRP5IBNM8pot4NCRrt/ To4Q== X-Forwarded-Encrypted: i=1; AJvYcCV5S2n35bWdHjP8LQxpzmipN4E0DGWmek7blWptbAEHFwOJFDGAjdtEQOvbty2yLjAaLEE=@vger.kernel.org X-Gm-Message-State: AOJu0YzSf9Oug9rrr8HqwCAr1ECKtlLLRpkajWDMmmz0Y0HQgaB/cQA1 xXQVloL1iEgWmlmEEKoNyENIbLG+BTfksHXFhAgdSQjwawFwyTPJLH2oxrJ8v5U= X-Google-Smtp-Source: AGHT+IF2wNn0ur0oT/D0x/ryrXGcpmcSlu4jLOalBhzoC7Sb43ZM6r5tgiThqhwY6bCeeW8Z+2hNyg== X-Received: by 2002:a05:6830:3107:b0:70f:36ff:ed09 with SMTP id 46e09a7af769-71109571674mr1236876a34.28.1726126858602; Thu, 12 Sep 2024 00:40:58 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:58 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 35/48] tests/qtest: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:08 -0700 Message-Id: <20240912073921.453203-36-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/qtest/migration-helpers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c index a43d180c807..00259338833 100644 --- a/tests/qtest/migration-helpers.c +++ b/tests/qtest/migration-helpers.c @@ -76,7 +76,6 @@ static QDict *SocketAddress_to_qdict(SocketAddress *addr) break; default: g_assert_not_reached(); - break; } return dict; From patchwork Thu Sep 12 07:39:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801614 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1417619F409 for ; Thu, 12 Sep 2024 07:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126863; cv=none; b=phRyR/PjtvFt5/wcFFPGkrIN0Lx9kbQ6yffN/E+Ip9IoHpLhcfo+N3i7vPsJWcXnRA41fkUeS1rJyW1k1pMlVPJWaSX8fxjNRkJToHy+lxR8MJM2PvKgUKGSJiEB5fKw6FLBa2tFCz6nU22Fdf0WhIcTKNFDpZ8dVCDCCNuWtMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126863; c=relaxed/simple; bh=8H1/OH4Br3oIzvlrSG/kOWgIs7zGZjCOJy4WQ3GfVPM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=Dl51TMV/woq0j05UnFASnp5z8dIqb5leuzL9o8KEnZ6ObTurlXjEj/xUpdiu5SOgMy6AtoTAOna6rEEHjqEGinS6DKuhkN/7ExwPJ3PM7+txgVesRluOp8u/tbh1hjbenzoFq6MIK0EA9nwpPSdPbjEzVAO+lSx3CuLGtxq7vrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bUm3sKaS; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bUm3sKaS" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-71790ed8c2dso507458b3a.3 for ; Thu, 12 Sep 2024 00:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126861; x=1726731661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aRhqi3ndGuxNd7tYiOTJthgyMGQ64hBDEtZC2U8BXx8=; b=bUm3sKaS7Gw/QLCdg0DoyvYDH2H3wnDkTfvLyPm2IeKoczjyDvt7IeHlS34An7lVMa CHUUwvtE2vH9t2HD/0fn/QLb+dDPoaED+EYGBixRV2helGCXmjoG0hDJNMC9EsjxVF1C XP48QASUoyONsfd0vxzpmtfB610i/xnbvppMaLJxlGTyMy/3GJ2td42xmS8S88BCos3M VSj17Mr73CUzokVfvB5l/ThXaXrh19u0WhQvvCZqzpj/dndEUkEENDoC1Ls/ItlrsNDE M8LtwHvxutXI+w6jPRykN6GTIONOUPciL2/E5LexCEIELWC6ilC+CBVbkkCfg1prusgB yiyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126861; x=1726731661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aRhqi3ndGuxNd7tYiOTJthgyMGQ64hBDEtZC2U8BXx8=; b=uvSnYBfBoOOEH1/vwXqANYboRxNW9VP08umt2SgsuSaA543bQljz8aa+1gLSrzRz2y YeONLOGe8C3LjgctnFsXC3Ux/MEOLDzwLxnCBCsslWmhPZLWYv6t5umvsRkIqXcsvI+A BoF2UWGxWDCGo/sCoKM7udCcQQD/sYppIZFy98FSVlamDb+iGpXak09klnq+0QaUDrKQ Mpfe4didoMQmqKsAnLp8O3HVCGJ38CkMQrZdV6HyAfu2B8DSA0wMFAoOHl5wcVyPLrHN gKDhIXwbHy5gsFPXRNzu19bLOqZ1xZ+94lXreYlBMudTPbXiJXkGHO8XON+TLiNWKScy kgAQ== X-Forwarded-Encrypted: i=1; AJvYcCWFhSg3nX2LUY4Dc4SWHBYLNi5LFgFe/PRql2+8RtVIyAYJs2LQGRaWVGaoENv8SwIfNfk=@vger.kernel.org X-Gm-Message-State: AOJu0YzgqrU0MF3SUoJjiAaoZTqNaPrggxOc90cENM75DC0AisYTXR6c 5EgQvzNEbYtD9R0yxsN5a2di9ydLe/RUQ0pqmZ8MHRYjKm78WcbHUL1ACNEhQhU= X-Google-Smtp-Source: AGHT+IGvK/n67vexDNSV79VALisw5Y++i7pBybF1QnzpQzK+oXQjb+Ja4u4bg2whNjS5JPChzGsWuA== X-Received: by 2002:a05:6a00:218f:b0:70d:2892:402b with SMTP id d2e1a72fcca58-7192608123fmr2966919b3a.7.1726126861203; Thu, 12 Sep 2024 00:41:01 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:00 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 36/48] ui: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:09 -0700 Message-Id: <20240912073921.453203-37-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- ui/qemu-pixman.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c index 5ca55dd1998..6cada8b45e1 100644 --- a/ui/qemu-pixman.c +++ b/ui/qemu-pixman.c @@ -49,7 +49,6 @@ PixelFormat qemu_pixelformat_from_pixman(pixman_format_code_t format) break; default: g_assert_not_reached(); - break; } pf.amax = (1 << pf.abits) - 1; From patchwork Thu Sep 12 07:39:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801615 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CAAC19F421 for ; Thu, 12 Sep 2024 07:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126866; cv=none; b=bToCfs/fx/6yKvqZDvbJfR621KVPfwP8xokGtoWWZGx5VoBhKbUx+Q9+ff9pkwJictFu/HaBlb2vA8uSoFzNv6lynMLUYCiuE4/GStQvBDIcFIuPds21Lnkkt3ypxOXdCBdDMIh33XrZqTAVfZoHgydLP6YDKXiaMYN4/THTbAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126866; c=relaxed/simple; bh=HrHbnun+u/bmxsIePQYlhoGaJlifFADrvQZjgjBn4J4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ajcG+IJCzAleYjx2Dz6vmMXjoIqszB7fU1E8DvyzOeMvjpoHMZzGuO/ZdbOmmWJGutu2NVNoqibfO1U2llfWFlJkq+eMrJ0pTGfRGOCd0gxT4J0ZRnEEM7+HPGx1xm0tPL1K23MpzHCvwWMrhoDTFApXEEp0IDwSP/X0o9q/rlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pGKy9SIW; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pGKy9SIW" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-7cf5e179b68so510036a12.1 for ; Thu, 12 Sep 2024 00:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126864; x=1726731664; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i5xGRLzZJ2Qth0Y8TPzSfuk2uwuhTRJtRDglckHUSQI=; b=pGKy9SIWbAoVFb7VUOTzdg7lGLpwLkY+2SpKRI+W3zwtXs1VEel7hK0a+J61c4ptff PwRXxNu6eEXmlkudIGrJ+ezl/jHYiAtX0Yzl+4rYpnxIY/a8psJmviwz8OsSOUtsQAXt J3rNu2uIAP+hBWjOzslSQ9B+jEvh3fnDjs+RuPhC9+BUFoL8msmulyCuslFtOyMN1Xt8 akFfh5kBZT5jcqE3D3SoL+MJGCiUwtGasOFzOKYUBFgOW4e/vL1gw8xG3Pa6AKHxDhyv b28wLHDA06A2WsmCRPVnpRDdah84owqnK1rdT0NBFsh4CcH41zBJXp5i3fpgiQyqkYF3 OPqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126864; x=1726731664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5xGRLzZJ2Qth0Y8TPzSfuk2uwuhTRJtRDglckHUSQI=; b=djmAhNRI4ws//Rbb0zof1/99GyTtUM14Vm9Bt3IajNOBRXGvHdgbSqLaqB4pbtkj/k G6ZohqxIK50HK3cIsENhObjt8YUQ4SwwQtTRcfFLW0yWHpx5IjkEdMbtSTUVUxLBolUj IL5vmuJZmypG2Ae+VBsc/fyvSdi/5/fYrpP3g2REQegK8eZk2/+RLOUfXHUcNJatqGWP YS7aeyGMM/59wazLrIa2fOwu6ds+Lcy0JZWVJakAQdZAEI/xvtWOldJyVJz6Mai1Xdiu yRMP6eTe18uSjnsl8S5UbLT97S203q9imBvhF05dzMltnIq5HJlLl5CpeYJeq4Gt8zBt 2Y5Q== X-Forwarded-Encrypted: i=1; AJvYcCXXj7VEwRYdy7Aei1V1oen5JgXEm6+TxJGovN5g/WtbQXcNhUGHh/MSsbnwDdikmc/IvZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyvmCrLqYukXHwYdokPF64umx/t4JA5xe7XXzK0wskRSUcmrQwU NS+qqxJicnAy4PUs98h4kx6tgT022v3Iw2KeVGGz8JgicGeUKwZX3eA/adKKxE4= X-Google-Smtp-Source: AGHT+IFnNdPU1Iayk5BlkwPU/oau5e8ev/a0NTufCxY914fq4JD3TSW88aC8vWC0gINkb8p9bG5UDg== X-Received: by 2002:a05:6a20:8714:b0:1d0:3a28:7d2c with SMTP id adf61e73a8af0-1d03a2882b8mr604506637.11.1726126863874; Thu, 12 Sep 2024 00:41:03 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:03 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 37/48] fpu: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:10 -0700 Message-Id: <20240912073921.453203-38-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- fpu/softfloat-parts.c.inc | 2 -- 1 file changed, 2 deletions(-) diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc index a44649f4f4a..cc6e06b9761 100644 --- a/fpu/softfloat-parts.c.inc +++ b/fpu/softfloat-parts.c.inc @@ -1373,7 +1373,6 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b, break; default: g_assert_not_reached(); - break; } switch (b->cls) { case float_class_normal: @@ -1386,7 +1385,6 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b, break; default: g_assert_not_reached(); - break; } } From patchwork Thu Sep 12 07:39:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801616 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B17419F421 for ; Thu, 12 Sep 2024 07:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126869; cv=none; b=oYknoPAYHcu24gU05XpRDjMp7V3Rw3RI1lxAlD2hEfzlSqTWZclaKqMTFil+gxedvgXzaZ9K1VfqA6l+AXvHDT6RfaZ3gfhE00tkzwVV1O7ndsYkgpIqRnV+KHb4V+LN3HQXB0OTpvq2xTdW043ESSJ6ucQv/w84wiC/bc0wzpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126869; c=relaxed/simple; bh=9cCgEKRA5DvxpgLapJwiNzaItMGs4Azztj8O3oNdROE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mMp9JP4L5mpYhlXkDAJdrKaWym5Vo3LYud+MHDQ8GCtHzq9NWKAtvs3Vi9a7b2QbYLz9ZTNklsyP3Aqpv8AhY3SGezO6l91YrvNTB8sh0kjl/Wd+270oNUu5s9+IAKhaU1aTtGWizVC+gTPOeWoKsf0yvX1qCC7F4eOU9M6VcQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x9cTmyWi; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x9cTmyWi" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-710d2cf2955so348893a34.1 for ; Thu, 12 Sep 2024 00:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126866; x=1726731666; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e2xm8XElPGDNfZprtVH37Ayr0VHkHPtJKuU1ivlIVl4=; b=x9cTmyWigSqED9KviG4Mb91LHHWbb8mX6bgE4bDGqQIYd7sCOnBwQ/ZjJpW8qle1j1 STOJ51gX4163uR6vMLuDQKIWDNJxGnZAl7DwqT57DmFrJt46ccqCfcT2CFj7KFTM6M4W ttcnd7KOFXrj6wQi5o5sCnC1Tkf8Vk3cjl2satG/jyyESwXvplf0OIF+6+DAHZiFOetq k1S1YcInM62HSSqYooUeoboT4XdDweE9GlyTg7fEl5xiZONH+xSRqGIUENWxUp+6yEsB WO7pQrqR0jY0k6IshJmYZicohfpuDpa4fe8AbnkrwlxFGWIXIaQ1WBP97azDEJxoGZZY FBNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126866; x=1726731666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e2xm8XElPGDNfZprtVH37Ayr0VHkHPtJKuU1ivlIVl4=; b=p6jEr66toPqrlwZ/daROtGKe566z/humNYaHowFP8mkvLygBnRd2fWqvAQvxwkp1v4 ey0iKgWTuzkgXoAl2sOZkMCRJX/7UfdXC/3b8bhQ8z8QtSOFJotYhav0MAa/jf3b2BLQ nnLT4cjyqhHuN35PvmplsRSTSHljj70ObfWrEfKaOX9s6H95miE+xJ+kVsg5ERPzoorK SBsNDEZMXwrPr1DgZ9S7b7dlv+5WltWpHXNlzB9bVJneD/aWBsYKHtNvin+zst4jrP/v 4dfR/oTtCbYEyF0AcMJgNiQqP8TVMlyxTbEYfQR6/slADrfcTa/AQgUYbUuCDTiASGIp MGSw== X-Forwarded-Encrypted: i=1; AJvYcCWNPrtBOjfp0p6pj8tizpe1vvYlsLyg52c9S6ndcvBLrh4/OTmuXvDLtGpi7lS8UojuRmQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe4YJM1RcYgWe0/SWILV8RID1xMXxJUASayKkTIOfxONdDmHv6 pn/gRUlN+omGMszFYnmtfvqD+jg6BnJd6OSjV14A0PsKTSG5O1rERr+g0WDfoRo= X-Google-Smtp-Source: AGHT+IG2bps8N5RHQbEXbK5LIaAzGTJ/B29Jpl6a6SJzD8g0CGD/dFT1EoXlmzuLP4NSZ0I+DvMqHw== X-Received: by 2002:a05:6830:6e89:b0:710:f926:708a with SMTP id 46e09a7af769-711094be6dcmr1645437a34.31.1726126866494; Thu, 12 Sep 2024 00:41:06 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:05 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 38/48] tcg/loongarch64: remove break after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:11 -0700 Message-Id: <20240912073921.453203-39-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tcg/loongarch64/tcg-target.c.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index 5b7ed5c176b..973601aec36 100644 --- a/tcg/loongarch64/tcg-target.c.inc +++ b/tcg/loongarch64/tcg-target.c.inc @@ -650,7 +650,6 @@ static int tcg_out_setcond_int(TCGContext *s, TCGCond cond, TCGReg ret, default: g_assert_not_reached(); - break; } return ret | flags; From patchwork Thu Sep 12 07:39:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801617 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFE1919F42D for ; Thu, 12 Sep 2024 07:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126871; cv=none; b=HtITvvC0gvoFgCyjEvQlIKb+mrVytMfYzlqfKFvNqjz0pARdvMQrWE6Gi2PoeIqMrOSyAQ/7Dxy+hDgtGl5ikGVp0y5uwicU/6tndHDDOuEikPEt2Ix2CSlZm9gqPBK7MV7tQFaBiQPNh/lYpHtTbwhMCIubQSD4ygRx5DQ+sHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126871; c=relaxed/simple; bh=E1Pu0CO5CUPU0r7PLYod3ULL8E40Kpi0/doRJL/zAuU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rC1j5BJ/ATsMIBVlRjKb4NUG+VtJwodfq1KR9Nb2PPUNB65tL0uMiudzff3qjmQjm6gB1uQ3Ux0SQQoMuV2xfOwJWLsIVfpqWPa2t1amySubrtLzk87nB0DhpU/7jnLlnQImeHHQovmn4nfmiSzWBrpTThih2xQGHz4TfuGvYxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fIvIiFu/; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fIvIiFu/" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2d8818337a5so1298245a91.1 for ; Thu, 12 Sep 2024 00:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126869; x=1726731669; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QSalypF+pMQKKa4uNxhVuqSrJY5QTLcHY0WTppEbuVc=; b=fIvIiFu/zSbfJ1iN6cXiUZEZTvCj5r2rySDJfOEwBjCToTUH6Wli7DjU2bWwj7AdG6 0aVb2J5tFyVPbVjTQs5E2gFdKqt31XS96GiLLDFxgWW6I7S70G3LYB9/shcb7bJKTDd/ 9sh9G54Yi+LYrzjYGA9hgkCw67en3txYIWHz4ulaY6igZncoj4xQfNZ0psHpWL7gJmvV Qpu+xbLQ4IW3f9QFkeWkhHrtJScmbX+O4FUNFzSQiweX6Uu2xyAnVk6DBxtSUKEiy7p/ 4jOR41xgFS6ji10wEBjJkhxmuxNnPQQOE2ZPlCik8a7W30xwXPlMUFza3qagCJ7QDP3u DPKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126869; x=1726731669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QSalypF+pMQKKa4uNxhVuqSrJY5QTLcHY0WTppEbuVc=; b=AVnXt2kB1+5MpJ3Mmi9htpIfCTeHScOUagS7qy7lNXxyxjMLISzDbKD3RuHcwu3hWo uw5lChD56KWI+Y515QNuNgZklgr4p/bzGps9ctmdUCnd0FPouKeZ8blS6Y1jcBUlaXHA kqJyJ1iAlLG/gfazmsnjrMCAd1djvY0fqUA8Byo4jY1AdPAFHmHcT83FPFDuEike9Zu6 VttGO1cxrXT44vMjQUSBUoy9qBNGiHIYVYqj2+taaSTRin1lCRlZNS6dfPr37XvvwJl+ mlIhLyc1GuMJjlHBRVuje0v4dfV7xeUVadkoDj2+r0I0nhphtTPNBEeKV+ll64p8ZJ5P mryw== X-Forwarded-Encrypted: i=1; AJvYcCULSrkb8Rz/1IuWKP/ZAkzzTh1CB19MRpDjAXftcU517/hOK+3tzUYQd4StxwmronN33Oo=@vger.kernel.org X-Gm-Message-State: AOJu0YzamZ1jSexTbDpTKvxePB7tBUL4N5lfOgtmivx+94hMTyN+CELT +G49pzA/NTtowdnF8CTQBDevvOA6VZLou+McWhO7xiort48bEX9tZ8aV3RWB4ik= X-Google-Smtp-Source: AGHT+IF1YUkgbI8Z5QYhP8g1gpLzhK5aYcn1/M3ZoEOkopdJCnHdCRszwAZ6uD2z8SDokzvFEDBk7g== X-Received: by 2002:a17:90a:8a14:b0:2d8:a943:87d1 with SMTP id 98e67ed59e1d1-2db67211d37mr14855931a91.13.1726126869060; Thu, 12 Sep 2024 00:41:09 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:08 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 39/48] include/qemu: remove return after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:12 -0700 Message-Id: <20240912073921.453203-40-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- include/qemu/pmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qemu/pmem.h b/include/qemu/pmem.h index d2d7ad085cc..e12a67ba2c0 100644 --- a/include/qemu/pmem.h +++ b/include/qemu/pmem.h @@ -22,7 +22,6 @@ pmem_memcpy_persist(void *pmemdest, const void *src, size_t len) /* If 'pmem' option is 'on', we should always have libpmem support, or qemu will report a error and exit, never come here. */ g_assert_not_reached(); - return NULL; } static inline void From patchwork Thu Sep 12 07:39:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801618 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6153819F43E for ; Thu, 12 Sep 2024 07:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126873; cv=none; b=sCZxp3oLwzgNhlu2jXz1AOjXU8LsqaVPLtlA9cpZhD3JJNb2cZXv0S7oaIDAOU3bvqcoLvqX+XSrNViViC6C1FkDmeDww1StPWJEtzX2FcYH2M1v9lpGw3r1LR4zrx8cewzRC0ySjzG1a3K0cICSWESLQZItpzwgL+WYuKwSGRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126873; c=relaxed/simple; bh=oa5AL/HwdyX7y2/urQTvAYAUXGLIjF8e/GVGt6+JtKI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nd0ZkPq5Ed0O1qAZbGV28kN6Sid5wEI27flPRdO0UObqX4cXKZ5cXX78FxutO0ahPv/lliZxmCma/57dilNLjilK5WrEhKBZ4Vv+B5CRayphQwrxnt6lBtqf6e/T3CxTh6gIvgRsZHp4jFpsI9G23mOyrl7FLJVFzgCTeYdJKEs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wdCk0uyB; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wdCk0uyB" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-717849c0dcaso595274b3a.3 for ; Thu, 12 Sep 2024 00:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126872; x=1726731672; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0Q1mMHu0qY1Mg7YdLUybGWIueKQg5CpgXLD+/9rtI1o=; b=wdCk0uyBWix1AI/QrarPqQEsTUKsuCfEXQeEphJCQi4ip8XRkbzx85Si6iT4OXyzzb tytOa+gZUm6zwW2rAhYWgmyji1Ujo/bKCULg4EZ0fS/ewPq3xMlVfDZHlm4CjhPdWz3F o6mqApkkB/oMy/4d102JmTmHpA/QaxH1Rao9lkUrn1coApIdyiBIWHWXFZe25GkS2MT6 tKg2U++4LjA1Ak8web5rTh7A8oH8ASwLXlNDxb0ufz64wCGIutjt3B42ge+qOdHJE+uK qf6LsfzaCHOsRvAReM2Ipe0z7O3ImU9Euu3d1Sncklt8hIJFOFCWEia12hcUR88BzHSA aRDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126872; x=1726731672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Q1mMHu0qY1Mg7YdLUybGWIueKQg5CpgXLD+/9rtI1o=; b=N0wz0xIIMtcJ/I1kWy6Z+6CkWPl97/ODR/GOov4IvMOm2FYyyTJ/eMfBDtX2OEniCq ZliVkz4Woq3bAa7BNvtAruHLLEc28HacxIumj4jAIxCe3ePqjtAGQ6ifVDaAar1Se0M0 /UhI4fCDUHHs3Frxl1e2mVK4ESxohB9sVqjrcMm41iF1Tks02FAi63dRgLaSqpNmv1eT Clycwu8sHdls4kkqB7s6fS2NV+8VDkRD2O9JbeSJYjDW+gbf/L704fdRotrADKA1luMr UT6cQZn58xYW4CDVhB/rh/3h7xOHpQYv+z4RfUCzQuCTd47nrYxPU4TnGSR8owL3goJk VqWA== X-Forwarded-Encrypted: i=1; AJvYcCU0Flo00OOE2KnjDSmX+M+WI8xxH1lvvg+7Bdqt13R8502P4qb5LWe/15hKnb77jQBe16Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyZyIjmR41DC/gQRQG4xucSCN8s0mndKD4fSnQtQW/HARWil316 6/eM0dsUb+EmCRsOYYJDPJY8Wxw43oTc5brUQDwVk9hTCYVXJ4QEjGAG5qL0Tg0= X-Google-Smtp-Source: AGHT+IE7t7Xs2KH5JUIaVOe68OuWPwNTouEEYSj6TZqCiSQvTjYgxD2YaXeBSDQ2jSGG5jMqgQ5hKg== X-Received: by 2002:a05:6a00:1906:b0:718:532f:5a3 with SMTP id d2e1a72fcca58-7192607ec83mr3028275b3a.7.1726126871623; Thu, 12 Sep 2024 00:41:11 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:11 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 40/48] hw/hyperv: remove return after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:13 -0700 Message-Id: <20240912073921.453203-41-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 1 - hw/hyperv/vmbus.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index ef50e490c4e..a630ca70476 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -89,7 +89,6 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, } } g_assert_not_reached(); - return NULL; } static void sint_route_destroy(HypervTestDev *dev, diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index df47aae72b8..be7d3172c4f 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1890,7 +1890,6 @@ static bool complete_create_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_gpadl_teardown(VMBus *vmbus, @@ -1947,7 +1946,6 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_open_channel(VMBus *vmbus, vmbus_message_open_channel *msg, @@ -2021,7 +2019,6 @@ static bool complete_open_channel(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void vdev_reset_on_close(VMBusDevice *vdev) From patchwork Thu Sep 12 07:39:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801619 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 209261A00C5 for ; Thu, 12 Sep 2024 07:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126876; cv=none; b=lJ67hQI+sX9JJZgcpM5A8CTAhuhH4cx+wzf/JfQy+MVi6BvB2KEZYrHbjcLHzHeQwce50wFSggOlP/gu0X4xm1RI67HEGy8kuAp1M+59ONy+B8WhcCnFGrX6DYszL7MUej4PB+hrEy0vBOrPU4j4dmOq2NSEj0pNCa7H9nQtc/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126876; c=relaxed/simple; bh=a3+097keVJCBLEwyt/Rda1DG1GjC6WhYPgywdLMfrWI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rmVFRBC9u86FYmRE9k1nGeCn8ZabzDIQ7wKAw4ucC+XRWWJEs7aUSzLdTSvQJdjKNIa+HGhPJQgdw2FLjmEVHxAYPrNrmx+0VcRZuLLnh4olRKmFLFSyJ7ajh61jnR27rG0kcIjE8hIiUtK1JrEfYBgBcSe1Qsb3/TgzTlIX9iA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DuQp1Hki; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DuQp1Hki" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-6bce380eb96so444881a12.0 for ; Thu, 12 Sep 2024 00:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126874; x=1726731674; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4vXYJ3kbU9hsr2ebFSyiWuonl8XOv822rbyHItwqNMM=; b=DuQp1HkicqpizgDgQsbNJasTTbs8gTw9ElOvo8nLMTJz8uOBNLVapBwHrXByvwWRBI t7fzgTKEJmySVEddpQ0NxTvEyd9cPqqLDPVJ+VVec/7pCWvN6FahSfL87a6Alb3XDa41 Roc+CWynx2jmV6WF0pz/2OqDY1jVt2UsvByq8FDjjwerYKMYipSNrZqFTHvCGuhDemom FmwM2sfn5tieV0yg9VkPEt/GoRkamqkSlCYKPlUxz5k2TMkcPCGYVLSBNbrD9Kzq+2hL YSAzwFitZ9YiV/jw74xpnbvlZvwtwloGFgZ8+Rru/bSfKhP3flZKBM8vW3s6MZ6uJuLE Ockg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126874; x=1726731674; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4vXYJ3kbU9hsr2ebFSyiWuonl8XOv822rbyHItwqNMM=; b=RoKZwnEZ0O2sRs/ty7Y2TcxeyWjZVcFePrFOfWVFUFF8i0Fp+uUIx4/JVM2Zr6APFd 9O8xI2q+AxF8dCmxqEOFDyB8TSqm44Pa57JvKQOAQrCFdKwMiVLoTuDE/x7keynHAfy+ xTXA258/mOnRvvfmuxf9SenuaEDetXo1Q7O9jYrLRbKceMbKNxc1mnKVxlGc84g5dblc 7+JReOBcbIcIZCnp9rSs5yKi4YhoRDpmVKHXJc600bps6EB4Rw8AQcXXXsuX1DnOlo9F 4Q00O1e6OwHeSTkQ6YvhTNJZpFvix3ZSOott2dixIw11lak0S9j4V01TaFWflgXUxTXe lrGQ== X-Forwarded-Encrypted: i=1; AJvYcCVSaJP2AJGlSyejhcw9FqHTB2zUHfrdzVogcBQKACkaYOeSEX+JWNJtLPgYTNJfNbgpTeg=@vger.kernel.org X-Gm-Message-State: AOJu0YxiAAcMw1hIE6L++aORY+wqUvm8s8MEdIvCPmgyl6QHfc/zOVCr Imx+HP5hY1at+r/5GsGBRkfaJQRoLzVbVXhvNmAOA6cP5AncgZcdOiC2Xh8FG0g= X-Google-Smtp-Source: AGHT+IGfovdnAqYWOwtqmXfs1YlWNLytry27KoN7DkkE+JMDdDN0epVDte/LII/bTeQGg3HedxA6ow== X-Received: by 2002:a05:6a20:e30b:b0:1cf:6d67:c078 with SMTP id adf61e73a8af0-1cf76237989mr2787587637.42.1726126874107; Thu, 12 Sep 2024 00:41:14 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:13 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 41/48] hw/net: remove return after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:14 -0700 Message-Id: <20240912073921.453203-42-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 -- hw/net/igb_core.c | 2 -- hw/net/vmxnet3.c | 1 - 3 files changed, 5 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 248381f9766..2e4c50ddbaf 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -562,7 +562,6 @@ e1000e_rss_calc_hash(E1000ECore *core, break; default: g_assert_not_reached(); - return 0; } return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]); @@ -841,7 +840,6 @@ e1000e_ring_free_descr_num(E1000ECore *core, const E1000ERingInfo *r) } g_assert_not_reached(); - return 0; } static inline bool diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 6be61407715..5dffa12c64b 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -398,7 +398,6 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) break; default: g_assert_not_reached(); - return 0; } return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]); @@ -747,7 +746,6 @@ igb_ring_free_descr_num(IGBCore *core, const E1000ERingInfo *r) } g_assert_not_reached(); - return 0; } static inline bool diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 63a91877730..6b5185c707b 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -456,7 +456,6 @@ vmxnet3_setup_tx_offloads(VMXNET3State *s) default: g_assert_not_reached(); - return false; } return true; From patchwork Thu Sep 12 07:39:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801620 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FBD6192B73 for ; Thu, 12 Sep 2024 07:41:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126879; cv=none; b=U7LvRjNIhIfLn7tGzgoF5RTTj1jUZJRWU6nEhu4ygbbK4qRm7SkgfdrLJkTvzyw2XBT2tVjK/J9SgxdiDaiLst9f5CKB4umY+WJJTtQ/Df/OYeSInsNUU7TrBU8UXk9i44HEsPVVMZQAD0t5CpnnyEnZ7uwkQQt0Kjct7nPn2to= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126879; c=relaxed/simple; bh=spC06ZvIThumQY77OYpdAPyZuSolKTInQltg38j+/3s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JqDEHnOsKFSQRN8huAU+Y2o77TlH6pYWjT5GoUtr5ToF37kAuVU6Tu/23KhvgbkkFS11m6dNplz8/iOgsSV0jL6vD8DhTKF1x3XOvOB3sGFWJ/Vxj/OnsoODxGKXZO6a0qZNSlAmMCjJ02aeYevXHsC+xwE1F8lFZoGGaIjbQBs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xs1UShTW; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xs1UShTW" Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-82a626d73efso23665339f.1 for ; Thu, 12 Sep 2024 00:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126877; x=1726731677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pMUYyvkrsw4WRnt3KKvMbrVUL0nLRii9ZhUC+JLdWEA=; b=xs1UShTWN8WZktriLr6BskfMTL248mcDWfcgjdI++v55j52jB8KgqoW8pS/iUYGh2w p7bkShayqbrDaE9pDY8NIBRpYXPl61nfLuSE6d6SnWc0Zsmdrovx9kRKKNrjT0TTw/eb b/kZYvMgCI+jTQr0V5KcmXkpaESiQafODOBeltr1Rh6bcqWpOCLzB7ktpBNZCTybG/wj +2vRAKzZe2b+sZbo0C6Tgh2bKQprcY2j/seVwZI5tXaVKCx3Bn3pduI/zl/ZMS2kT5M/ 7tvLpEpH5ZohTnbX2ZJHuytdnJYaS2YXJZOlKOt9peZZ0OKCPV8agtthioIgE3S3DIYb rj0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126877; x=1726731677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pMUYyvkrsw4WRnt3KKvMbrVUL0nLRii9ZhUC+JLdWEA=; b=wsXygVQRPUyG3UMN3D9besWDLgaanyJeUy/sunUroAJDWrFLcIQW0G6Ksiv5pkAv6v TKkSbdVa5rO9F6kcwzIlsOtlZZJZ99SDwxhAdddOZfapQYNMVr2hJPNrfixkXMx0kfb9 B95kNqVCfKeVZK6y/NlHzurJThKt/mdZ6tqvzXuroxS5jN7LQifMyA0jiVUU0H/hPM+Q 6iz2EsoFOb348deNXLL9NZ2I1nj11k7sUpImQss3EQJxf48IO0UcodZGahDuOkfd/XFW 3Gc3An3osPUWsfOWDOpzd1Vugw8k9kH3YnsKCFjwPA1fVPskfvU/BiP1W3Y+CaZVKOmn C78A== X-Forwarded-Encrypted: i=1; AJvYcCXHpLRBZplHTFh0fAPU964zqUoM1tmno1yDED2LCB5bEsqFO/hbpXYSQEVzPcxItX8LA+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3nNeHyXd9i+rCiryOVqnz7kJ/q79UW3oQ6DOTCtIQIpmwpoPn /TZDkWjBkvCvW6Bj8ObUOZ2LtkL0rt6Dp2E+jTB+IaUASdIXoQqmnDzHIDOo/6M= X-Google-Smtp-Source: AGHT+IHzePrHc9NvGdqaAhT6SIBTHUep9YZZsqe6VCOInwH/5gPcwLaBPPH2x/wVY/X1vhjYzcDUGg== X-Received: by 2002:a05:6e02:12e2:b0:39b:20d8:601e with SMTP id e9e14a558f8ab-3a0848afb8dmr18701325ab.3.1726126877432; Thu, 12 Sep 2024 00:41:17 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:17 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 42/48] hw/pci: remove return after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:15 -0700 Message-Id: <20240912073921.453203-43-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index c6950e21bd4..3397d0c82ea 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -47,13 +47,11 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { g_assert_not_reached(); - return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { g_assert_not_reached(); - return 0; } /* Required by ahci.c */ From patchwork Thu Sep 12 07:39:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13801621 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B541A0BC2 for ; Thu, 12 Sep 2024 07:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126882; cv=none; b=hWhn3/VwFyQwQffAvVTP2/wMc0rclxFAHN6xEBE0FJntiSlUMlK4lBg6Ws0/oIOZqiZkb55fF586Cvc/xDVO2D4AYEqfw1G6sfQ5IrH3jR0BS7HTaDzdB2m2F5B7m8le122I0+dyRArEM/L8GFa6DzCpKHnYH8PS/c/ugvpa4wI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726126882; c=relaxed/simple; bh=NQ1Zt4vBB9ezlf/RurG1vcjVnoZ5wH69J+1HyxHdmmg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gPkeQG6Z+6ZBTnVYrESONmXERu4irqe26ZHtzywqWSzjNwQFeuCHFbdNIVfDOogEktG9HVn9lYrxaWTgFBaOwGZSxpJy/Gl2xT9n33/MWkBZtHjLdr87jy1MRhXbMPxMVWsaJwr1OSCChMY8wWJSo9IKU6Lhv3RvNqmHA/PBh2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q1P4Xz2E; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q1P4Xz2E" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3e0438e81aaso388887b6e.3 for ; Thu, 12 Sep 2024 00:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126880; x=1726731680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ufez9dB+YBOc+7iflBPh4kX/ooB3/U9U7kq4P7lOFRo=; b=Q1P4Xz2EcDqvSJjHpWvrZIULYlG7fTXTLcbOAWvgEd/JIGn/oyqBhGlNDjGujLfnSj pWSSHcvis99Tjc9aT8u5Exmpco7ZAzjYjwYzDe7PoO2W2pEQp18kemf1ndY83lf2fsg7 5of0QpDv9Cm6WBMFVJI6DityGSykvcwHLa5U8KK+40l72xsKofrsEU1b5pSydGAa9br4 WPYQTmD+Tl1O5MBKmQ9GJkBJgxuHD5LMRMX2kUi0TQ9IWLdSpVtfp43XeXWAuhPGFVb8 i15an073kABBAgOJjNN21pCeBRbX7+QbATmLGmmPfJz0b7JgO30ZW1VQFtdz1s2epUjF VNIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126880; x=1726731680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ufez9dB+YBOc+7iflBPh4kX/ooB3/U9U7kq4P7lOFRo=; b=oCT27n0I8VQ4kP15Se0GPemJxBJXv/GVmvdX/i3/M+SkCWD+ZOzteLGmjJUMnZCc0J LhTDyj1KgIN3hbaaQF90efS3lzuyxiM9EX+Frbto2RRx2oqRmvVj6689NROg3epGZ3MO 82WOw8M0VoUFee4Jm2M7rcPaMHsUncFGd6kkhu2ifyUGXyzXHXAcJxc56qg0vERhIbwh p4WgwG/ycx8l6kDO6Di9vgEUWTho8cBj6rnFJz2g2LBoXQU2yQvC2wMNeMtAYQAG06L+ zG5pK70eveLraIW6KcKFc7nICmM5G9N0kIAyi0BgDxMH4saNDTxAOXIvdrOsMuIxepED PzNg== X-Forwarded-Encrypted: i=1; AJvYcCUPRgNq3g1o6pEIWF1zHPJEPAFNlghxOEVNWBWBKpbtpfrM2A7Z33ItJZyIykOIMHbqFMc=@vger.kernel.org X-Gm-Message-State: AOJu0YzhfBKLQneJ4DTa5+BQyyAGdht1N7Rn4ozyzq1z/3fclbACnSGV ivc0cG3q8z66RMNmv69+ZHSAaesK4jTdV0HQOWQZnAcxvjhngOilmbhVCR3OGaE= X-Google-Smtp-Source: AGHT+IEahP6jvi2FuHplutVqQN81TXossfZA34JXn70LhsQgJakrG7hFdv/bnJa3CeA2ta6y/uKqJg== X-Received: by 2002:a05:6808:159f:b0:3e0:4faf:242 with SMTP id 5614622812f47-3e071a9a5fdmr1180584b6e.19.1726126880116; Thu, 12 Sep 2024 00:41:20 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:41:19 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 43/48] hw/ppc: remove return after g_assert_not_reached() Date: Thu, 12 Sep 2024 00:39:16 -0700 Message-Id: <20240912073921.453203-44-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier Reviewed-by: Cédric Le Goater --- hw/ppc/ppc.c | 1 - hw/ppc/spapr_events.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index e6fa5580c01..fde46194122 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -267,7 +267,6 @@ static void power9_set_irq(void *opaque, int pin, int level) break; default: g_assert_not_reached(); - return; } } diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 38ac1cb7866..4dbf8e2e2ef 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -646,7 +646,6 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, * that don't support them */ g_assert_not_reached(); - return; } if (hp_id == RTAS_LOG_V6_HP_ID_DRC_COUNT) {