From patchwork Fri Sep 13 21:32:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 13804101 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1074FC6172 for ; Fri, 13 Sep 2024 21:32:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DF5D10EDB4; Fri, 13 Sep 2024 21:32:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="ffb41vkI"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0F3F10EDB4 for ; Fri, 13 Sep 2024 21:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726263174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zq/XGfhuxnu2xqsl1VfuSOlwQfCDeWHk07eSBLjaxgY=; b=ffb41vkI/wFdwPy1rzUEHi8MGKIXb+XI0XwWXLR4Vn5z6U7KdHJ8T6uhWHztDr2e/mefv0 YMTDtovNIwWRn9Mo45Q988zjxVHzLBEB/d+NJDveHSqvOCaE6z6j710C0K0lgm+a+7Njie NO3xF6cwwnUftu7ii6r9hMHMWJuswBE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-TQ1hzolNPg2J_mA_2JKfhA-1; Fri, 13 Sep 2024 17:32:53 -0400 X-MC-Unique: TQ1hzolNPg2J_mA_2JKfhA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-378ab5b74e1so681986f8f.3 for ; Fri, 13 Sep 2024 14:32:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726263172; x=1726867972; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zq/XGfhuxnu2xqsl1VfuSOlwQfCDeWHk07eSBLjaxgY=; b=jUkFmCuZsMnOgOfhDzIdevoAkwhtFFUa7sfom1SJdERItGg6RurgfWxfskVNJ/1uSY U+PDldKfh6AtsxjafGiVzLHTeY4dvmjECAkbwvswWCpAfAXyaZyRNlzlD9GNRVj/slNZ BLZFdggxgYCgk7rg7I+oVblQ00vPNqGZzWVtGcGMmfhvSsuWyniRyOTIjEa7C09Yohx/ cxS9s0xaaOLKUd+zWelnxeOaNznAfWAIaGuPnGW8PsJUv2kYekzQpWm5rLEotztWGz2C 5DfzHXNRPIsSWStUbT/DZeDLX2LLPG6Oqe8JYGXqsCWix/hFa7omPXlUMLYQUvptE/zG +NEQ== X-Forwarded-Encrypted: i=1; AJvYcCUkimJ3+a/IFaOuoeU6FGskK2UXy3knwiikfK+lYzZuTpxv6rps9GrsNSYISMIFz9RyGIf1b9Casjk=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwxDaF+jNV9Itvtg7XOvP8oy6GRdbjQI+MKm8n4zM8gCj8WLfhM JDGCuNmLQcAHQZQDY2O4vz/R6zxMwulCTTlxWqp+ooCfkYwW4adG0ACcCyz+Aa48chL2ByRJrub JEYWD+TgVqYm5b94b8yJ8q64lt6Foqd7o5vSemTL+SqnL6VJJ4lgMzxVn9n1XHhBiE0J08h4BtQ == X-Received: by 2002:a5d:4388:0:b0:368:5b0c:7d34 with SMTP id ffacd0b85a97d-378d61e2c14mr2554799f8f.22.1726263172214; Fri, 13 Sep 2024 14:32:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEyVfX5FD6HqnGhKNhramC2RAHdl6F32DVAZO0vkVjMaGBuk7aa+lbQRZkWnexB34MoaO9XQ== X-Received: by 2002:a5d:4388:0:b0:368:5b0c:7d34 with SMTP id ffacd0b85a97d-378d61e2c14mr2554779f8f.22.1726263171717; Fri, 13 Sep 2024 14:32:51 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42cc01a8ee7sm142234035e9.0.2024.09.13.14.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 14:32:51 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Julius Werner , Hugues Bruant , intel-gfx@lists.freedesktop.org, Brian Norris , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Borislav Petkov , chrome-platform@lists.linux.dev, Javier Martinez Canillas , Tzung-Bi Shih Subject: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present Date: Fri, 13 Sep 2024 23:32:29 +0200 Message-ID: <20240913213246.1549213-1-javierm@redhat.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On coreboot platforms, a system framebuffer may be provided to the Linux kernel by filling a LB_TAG_FRAMEBUFFER entry in the coreboot table. But a coreboot payload (e.g: SeaBIOS) could also provide its own framebuffer information to the Linux kernel. If that's the case, arch x86 boot code will fill the global screen_info data and this used by the Generic System Framebuffers (sysfb) framework, to register a platform device with pdata about the system's framebuffer. But later, the framebuffer_coreboot driver will try to do the same and attempt to register a "simple-framebuffer" platform device (using the information from the coreboot table), which will lead to an error due a device with the same name already being registered: sysfs: cannot create duplicate filename '/bus/platform/devices/simple-framebuffer.0' ... coreboot: could not register framebuffer framebuffer coreboot8: probe with driver framebuffer failed with error -17 To prevent this issue, make the framebuffer_core driver to not register a platform device if the global struct screen_info data has been filled. Reported-by: Brian Norris Closes: https://lore.kernel.org/all/ZuCG-DggNThuF4pj@b20ea791c01f/T/#ma7fb65acbc1a56042258adac910992bb225a20d2 Suggested-by: Julius Werner Signed-off-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann Reviewed-by: Brian Norris Reviewed-by: Julius Werner --- Changes in v3: - Fix coreboot spelling to be all in lowercase (Julius Werner). Changes in v2: - Declare the struct screen_info as constant variable (Thomas Zimmermann). - Use screen_info_video_type() instead of checking the screen_info video types directly (Thomas Zimmermann). - Fix missing "device" word in a comment (Brian Norris). - Fix some mispellings in a comment (Brian Norris). - Change error code returned from -EINVAL to -ENODEV (Brian Norris). drivers/firmware/google/framebuffer-coreboot.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/firmware/google/framebuffer-coreboot.c b/drivers/firmware/google/framebuffer-coreboot.c index daadd71d8ddd..f722292e7684 100644 --- a/drivers/firmware/google/framebuffer-coreboot.c +++ b/drivers/firmware/google/framebuffer-coreboot.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "coreboot_table.h" @@ -27,8 +28,10 @@ static int framebuffer_probe(struct coreboot_device *dev) int i; u32 length; struct lb_framebuffer *fb = &dev->framebuffer; + const struct screen_info *si = &screen_info; struct platform_device *pdev; struct resource res; + unsigned int type; struct simplefb_platform_data pdata = { .width = fb->x_resolution, .height = fb->y_resolution, @@ -36,6 +39,20 @@ static int framebuffer_probe(struct coreboot_device *dev) .format = NULL, }; + /* + * On coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry + * in the coreboot table should only be used if the payload did + * not pass a framebuffer information to the Linux kernel. + * + * If the global screen_info data has been filled, the Generic + * System Framebuffers (sysfb) will already register a platform + * device and pass that screen_info as platform_data to a driver + * that can scan-out using the system provided framebuffer. + */ + type = screen_info_video_type(si); + if (type) + return -ENODEV; + if (!fb->physical_address) return -ENODEV;