From patchwork Tue Sep 17 12:34:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 13806155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83B79C35FFF for ; Tue, 17 Sep 2024 12:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:From:Cc:To:MIME-Version:Date:Message-ID:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=AR+2QbPAYHmh/nYYxodXBMvQhRocE+1jEAfAlV44MUI=; b=ElK3XglYIHcwaYdnsWdDyaGoPP evVv/CI5OSZiLi47r56SVOx6tbUHQ3947sUgRDub9Dj/pUyGlyB7sjiqf0RCfBxdV/39jrprFePSp 5mDPop5b26kCKRgxlXGPjFgId8a6ilQeA+TR/zz9GCp2w62Hqe+tVxoBM2MKkJTAG7mdG7XO5lQmH CHDQnFU2nSIAkrvpTiiN3Q8YJfSEltnn/pJHxz93XLz0dFbALIV3QSVb8yrauOXP6c6nhL7qscaXQ bRcGw/c9xjr48QLChIudOFN9gRow9+fcrz2ICRxl0jYgLN06dWoTiWW7HWX+xi3C7icgShu5Zf2Ce ZIy1WRFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqXRE-000000068Ul-0ZU7; Tue, 17 Sep 2024 12:36:12 +0000 Received: from mout.web.de ([212.227.15.3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqXQ7-000000068O7-13qB for linux-arm-kernel@lists.infradead.org; Tue, 17 Sep 2024 12:35:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1726576495; x=1727181295; i=markus.elfring@web.de; bh=AR+2QbPAYHmh/nYYxodXBMvQhRocE+1jEAfAlV44MUI=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:From: Subject:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=TzwY6rVsElAo9g99wh48sBhvrXItzrzO26bekGfAKxxQP5HHwyp3eR7Th7lPXHR0 TUzpsENv3Wx518lXyFlQKBrlPyfkeJPe2tnmwHDBDPlgGV7jUJ4bGLzA22suQ4Etj F7U0nRtINSWMPfoqkMTKLsE0BpFUJl4V7jSWc/cLJ1UvhD0KDYZwPFS0rPSfseZkC EnmWFkvYiOA8S648oRQ4VmsNjn6YgSta0Vuq2N2+iSrzAZ42UwIjM7oPBPyjp11yq GVkysc/xgb5NHV2NsWOX0mMi34N4AStcfrykgcRq+od4LeXUyrVwuMgnK1evKYshR yY9s6HrT+szn3duRgA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M9qgz-1svjx41pkj-00BpVp; Tue, 17 Sep 2024 14:34:55 +0200 Message-ID: <4a82fe70-b07c-4878-bd31-6ae07b61f522@web.de> Date: Tue, 17 Sep 2024 14:34:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Claudiu Beznea , Michael Turquette , Nicolas Ferre , Stephen Boyd Content-Language: en-GB Cc: LKML From: Markus Elfring Subject: [PATCH] clk: at91: pmc: Use common error handling code in pmc_register_ops() X-Provags-ID: V03:K1:PZWjTGhf79w7fR4r4mZCkzhToXuovw4nJYNcXGTM43TaQallncl 7PldTylJyEVnrdFvnOsGhrxgYx70UAN0EfVDwccCpkt8AhlmNnDQbmJero/vz0SrUZasyqg zD6mMb00eT80nwDLVdYZ5ioTnH+M5vQj0GLbaJQcLKObPzcqNiR5VUJDUCC9YxQYkx/Ezh3 ghCrMDRpWqAl6i8pOohHQ== UI-OutboundReport: notjunk:1;M01:P0:7hq542Msv1M=;uoDC2VziJexpsDnW81Ls1kOivCP KYyN3yuQJECp02zXqW2XUhK3o59auhNUEwGCnGDOIeb6+3LOM0B6Diw1L/onEFHcRz0mn9o0r 1nZF7rM4DKEaB9Mb5wBSzehybSbvqJ9Mj0ALXURL1zUnw0ZT7cW5gd2C1nn784eJAmXnTExVW x+ddmAwatzO6OUx7TeySjCqO8cUDCC5Bed/woFe2b/xM+w4r2HcFkdLaP+a6oxk5OEDzRZyje 6UVNJZBEI8tdMyMjKFELWN+lDhZt3bH5mwDepEEBTEonZAyw6NoK2NLtzcZ1+kMZfhJclBp/Q iER9fCTN3beZKWTk0gkst/30Q8h9nxKTljJyvgHuh3P/fuBiGplskUqcPBJSknbQFlt8ZafNn hrCJFCX6IlM3Gfbse9/bnhfjZKcNpcBW/bUwHDfmdDJZ+bcsHtJ9E6UNKL+cjkPKKhcq/LYR1 pHzDPsteD5lnmx/uEwPHL+cYHkJHi2aaEXv20RiKF6TT8lQUl0Y9cCGvsfNtuIVd/RjAa+c6r mZIVqpzAEeggqd+lzZVUE3IT/Paz7ShWLY7e0jHV2IMDNBGFLKnK36dfc4QH1MqDMnntCFNPX oCk4e+JJa7yx4pYcgwXhviAoHxY/QGW88umN/5sg/HpP4gW475q+iYOxfYh44sSWKMGbGQr02 7epZd9novJV+nCq/5kJb8mEu1iEXYV2vOqB/8u710wyxk298kef8DtN79MI1k91jaiYyJrcw+ gXavI6847POddfiRm15Yxy+8fwsBLqKD9xuuKMyNeMI+gUOySG4JpqMJYvJZh8OMK7vbcNSfj p3GMHe/yaLG5ERxqsRJt5aiw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240917_053503_609232_3FF3141D X-CRM114-Status: UNSURE ( 9.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Markus Elfring Date: Tue, 17 Sep 2024 14:28:22 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function implementation. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/clk/at91/pmc.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.46.0 diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c index 5aa9c1f1c886..040b70e1ffbc 100644 --- a/drivers/clk/at91/pmc.c +++ b/drivers/clk/at91/pmc.c @@ -162,20 +162,18 @@ static int __init pmc_register_ops(void) if (!np) return -ENODEV; - if (!of_device_is_available(np)) { - of_node_put(np); - return -ENODEV; - } + if (!of_device_is_available(np)) + goto put_node; + of_node_put(np); np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam"); if (!np) return -ENODEV; - if (!of_device_is_available(np)) { - of_node_put(np); - return -ENODEV; - } + if (!of_device_is_available(np)) + goto put_node; + of_node_put(np); at91_pmc_backup_suspend = of_iomap(np, 0); @@ -187,6 +185,10 @@ static int __init pmc_register_ops(void) register_syscore_ops(&pmc_syscore_ops); return 0; + +put_node: + of_node_put(np); + return -ENODEV; } /* This has to happen before arch_initcall because of the tcb_clksrc driver */ postcore_initcall(pmc_register_ops);