From patchwork Wed Sep 18 13:32:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13806899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4463BCCD1A7 for ; Wed, 18 Sep 2024 13:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B36ph7fHV7svwBi96FN57LV6a/05y0uCMAofqnyM1vI=; b=13MvZz8OorXO6sYi8oQVRHJ6tv ePIJwjN9wG4vBnbjJarWOA6PH55X/vQB43VwlOdEtoCEb3xta7yLu+bVZV5BorBs9XA/fYwCNKH/G ETAQyuqdtKPSD4BRkBqaF4znO/LyFL+L6I5ITMbJiQT6FGwRSezCXeOR83FFwi+sckptAmw8iCXO9 +WwpLeXtXejBBeg3479Fuu4fXVV+XJtXdj+861VA7w/r0NdnwlqQDMbOjuTMPWHBFJoU2Q2zfWZOw vpGDD6IvwphzwV8IagvHajgFBKLV6Ae7ZhT4/OTo6jFuFoZ5Ps/BMEhMDy6wpPsBx2TDr2GOnCAnk oB2Rt5bQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1squqA-00000008LGc-2Ox0; Wed, 18 Sep 2024 13:35:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1squo1-00000008KzZ-0UtT; Wed, 18 Sep 2024 13:33:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9F1645C5C9E; Wed, 18 Sep 2024 13:33:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE951C4CEC3; Wed, 18 Sep 2024 13:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726666396; bh=YM8rwaj/aKbxGALsmKPe+zv9CAIkByMtZlqjj6nmxQM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=X/yeiXWQf7FpiHX7OIzvElhyAsD6h3GQIxr4aY+vOwbp04NamkIJ1eC+vwhiBkzpn lD75Ha0EwAKGwy86zADN4ESkdduTjYW8EniUFHAUhu6D/0jp1RPqRQg1W9MMrLXHar aJ9UV/KRlJdnWlpi+R4xkFK0gUdZWqW0/272IqLlKifqT2q6vn39UoyEb9NCWclc2z 7OMBVf7PXmheQU0PGksPqbOB1G6G1Z5h1qemydL2s3zOp6O5tVR+9iCv7NFX+0ze8W syZ5XXd9aTrJ29rpO+HC+8oMnhKrDqWEoWOnQsyxX+amtkqloqnzzhNuYxE5paTawJ 1jpVMS6ofG+oQ== From: Lorenzo Bianconi Date: Wed, 18 Sep 2024 15:32:52 +0200 Subject: [PATCH 1/4] phy: airoha: Fix REG_CSR_2L_PLL_CMN_RESERVE0 config in airoha_pcie_phy_init_clk_out() MIME-Version: 1.0 Message-Id: <20240918-airoha-en7581-phy-fixes-v1-1-8291729a87f8@kernel.org> References: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> In-Reply-To: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> To: Vinod Koul , Kishon Vijay Abraham I , AngeloGioacchino Del Regno Cc: Christian Marangi , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, upstream@airoha.com, Lorenzo Bianconi X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240918_063317_264163_80B6B104 X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix typo configuring REG_CSR_2L_PLL_CMN_RESERVE0 register in airoha_pcie_phy_init_clk_out routine. Fixes: d7d2818b9383 ("phy: airoha: Add PCIe PHY driver for EN7581 SoC.") Signed-off-by: Lorenzo Bianconi --- drivers/phy/phy-airoha-pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-airoha-pcie.c b/drivers/phy/phy-airoha-pcie.c index 1e410eb41058..4624aa9dd712 100644 --- a/drivers/phy/phy-airoha-pcie.c +++ b/drivers/phy/phy-airoha-pcie.c @@ -459,7 +459,7 @@ static void airoha_pcie_phy_init_clk_out(struct airoha_pcie_phy *pcie_phy) airoha_phy_csr_2l_clear_bits(pcie_phy, REG_CSR_2L_CLKTX1_OFFSET, CSR_2L_PXP_CLKTX1_SR); airoha_phy_csr_2l_update_field(pcie_phy, REG_CSR_2L_PLL_CMN_RESERVE0, - CSR_2L_PXP_PLL_RESERVE_MASK, 0xdd); + CSR_2L_PXP_PLL_RESERVE_MASK, 0xd0d); } static void airoha_pcie_phy_init_csr_2l(struct airoha_pcie_phy *pcie_phy) From patchwork Wed Sep 18 13:32:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13806900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28D46CCD1A0 for ; Wed, 18 Sep 2024 13:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EZOePHgRPPIBRPdEKtHvCNsW4U9fRr1EJPYkSeBMl9Y=; b=UlIAs3dAuj3w0vY0UjBcmZiIua pVQjpN03uNTvBaD81eeNfjvnITMjC7Pq1YI8B7FLzT0o4mrv7hJKpiQrvbw+c6sCYJP8hIcoXZuQt d0Aw1CyP3XshUPfdcV0GsTjYHwQyYm0L7LRatJBUcwzg2fWzVc6YxazRGARAMRhFacSDkcB7o12bq hmgW5sSz8xpozTmWkmX2YqvY9KePAwq/ADjz1FcTOznGWjx5vlo3rnu/3saYgPyei+Z05GZZD7rIP hH3JIsmpQw5qmE34NeJTOGiEm/MouZjiw2ScEQ+i32nRiU1MJ8HXxcX2nyAdHV7beTKTzu1+2RqtU uDFrE8fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1squrE-00000008LQw-2ET7; Wed, 18 Sep 2024 13:36:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1squo3-00000008L0U-2uiM; Wed, 18 Sep 2024 13:33:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4396D5C58C0; Wed, 18 Sep 2024 13:33:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DCF3C4CEC6; Wed, 18 Sep 2024 13:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726666398; bh=P2ayhFCWSFoH0zK/84T8wa3mB/EO0EfDR38Tso3+BQI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WpDaFq9mEPqWyDUSZJ+RyTMbsbHO6MxhXhego8fmHpB/TUnO3TSbaKBwoINBkdJHb e+k47YzoJwNs3Trkw+obWG/t6401swMnm6pQDGh0cnpH92zGTzm1YxKgZ4mIT/bxw2 RZIHQLJiPZ02bw+ofIWlDcVslzkkipPm7orPAS3Xt4QAiMFOdSVn2cpLK6IfuuhgA4 2WrUKS2utqnJ5Yoystf5bwAWDSw0cpQZT1pfw01D0lbf1jWQdl27TMr+FJ7mPjFJxw NaNVYqw86NcdIVx4j0Rr3Kbr2InXUhOlHZyK0J79kPP6Lm6LPIzuP3eSQWwkSUXqWl IRp3vQNjVUfKw== From: Lorenzo Bianconi Date: Wed, 18 Sep 2024 15:32:53 +0200 Subject: [PATCH 2/4] phy: airoha: Fix REG_PCIE_PMA_TX_RESET config in airoha_pcie_phy_init_csr_2l() MIME-Version: 1.0 Message-Id: <20240918-airoha-en7581-phy-fixes-v1-2-8291729a87f8@kernel.org> References: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> In-Reply-To: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> To: Vinod Koul , Kishon Vijay Abraham I , AngeloGioacchino Del Regno Cc: Christian Marangi , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, upstream@airoha.com, Lorenzo Bianconi X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240918_063319_833821_19C276E7 X-CRM114-Status: UNSURE ( 9.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix typos configuring REG_PCIE_PMA_TX_RESET register in airoha_pcie_phy_init_csr_2l routine for lane0 and lane1 Fixes: d7d2818b9383 ("phy: airoha: Add PCIe PHY driver for EN7581 SoC.") Signed-off-by: Lorenzo Bianconi --- drivers/phy/phy-airoha-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-airoha-pcie.c b/drivers/phy/phy-airoha-pcie.c index 4624aa9dd712..9a7ce65f87f0 100644 --- a/drivers/phy/phy-airoha-pcie.c +++ b/drivers/phy/phy-airoha-pcie.c @@ -471,9 +471,9 @@ static void airoha_pcie_phy_init_csr_2l(struct airoha_pcie_phy *pcie_phy) PCIE_SW_XFI_RXPCS_RST | PCIE_SW_REF_RST | PCIE_SW_RX_RST); airoha_phy_pma0_set_bits(pcie_phy, REG_PCIE_PMA_TX_RESET, - PCIE_TX_TOP_RST | REG_PCIE_PMA_TX_RESET); + PCIE_TX_TOP_RST | PCIE_TX_CAL_RST); airoha_phy_pma1_set_bits(pcie_phy, REG_PCIE_PMA_TX_RESET, - PCIE_TX_TOP_RST | REG_PCIE_PMA_TX_RESET); + PCIE_TX_TOP_RST | PCIE_TX_CAL_RST); } static void airoha_pcie_phy_init_rx(struct airoha_pcie_phy *pcie_phy) From patchwork Wed Sep 18 13:32:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13806901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60CA9CCD1A0 for ; Wed, 18 Sep 2024 13:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kiUybwixFjnOjfUF/lb1UzxAp6rs0C2ZHMYCyoOJMKo=; b=fxNQ+o0D0Y2ZDQfy6lUpyOoP3I 8bwzuuJ/I6m6lZ43mYXIECR5PorsIjbyyjXb9erekRfFMFOcpUv+CGmLI4T6Ru1Ba8icklFKhAETc RvxfTJzNEB+4zEzz4oAgWQ4TajaThpoI9rVyH2O3aRz+UfU1dNAfYnMTFzZaWMz7xt5Uy7LixVWVA rfr356M4JV3Iq0gHfPRP/eFIOGts9ZgPmL9Lljd0CEePWqHfQrdc4wSweSG0HCknH51jRL7qOGFeb 9Q593t4zD69mU1GFKMlyh9/sB68r5JHhgNzvKQ1GEoYOeB8h5yXYOeW1vznhaW6ayd3DCY4MNWcVZ B3ue3SKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1squsI-00000008LYT-2gy5; Wed, 18 Sep 2024 13:37:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1squo6-00000008L1A-2UpZ; Wed, 18 Sep 2024 13:33:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 23A075C5C9E; Wed, 18 Sep 2024 13:33:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22B4DC4CEC3; Wed, 18 Sep 2024 13:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726666401; bh=fnAKNf1YgRllmWdnPA9TSA49da0qGhW0KtZKcpCr5wc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=I30f/Y0M4kPGUVVS1Vx9xTW9WnWLfsbuQnbMyAjz3BxtuuJltNAQy0jr8hjBuoqlJ 5I689IYNLT2nAB6EyUbSEB2CqXB5pTAgjCWt6QSUZoSTESDObANScrXV2MkIlIEmMX 4pIXxoPubaaxQ1vmSL+9GklaWx34K7hkYA75zPh35vVtN+ItbDhc1PuBSR8RQPXRkp Xb3O9dqkLWSYbtnxRt+CT574S6UAj9N8WMaYN+C3hf7PKwuPe+Kks3q23z7J2BqMTC MD3B+4PVvGbMmcihrcp6rLfkdJ3Hg+zeyiwA/BMPDUECXwvNpTvnicfFpsPU9efdoe llf0+uWImYPIQ== From: Lorenzo Bianconi Date: Wed, 18 Sep 2024 15:32:54 +0200 Subject: [PATCH 3/4] phy: airoha: Fix REG_CSR_2L_JCPLL_SDM_HREN config in airoha_pcie_phy_init_ssc_jcpll() MIME-Version: 1.0 Message-Id: <20240918-airoha-en7581-phy-fixes-v1-3-8291729a87f8@kernel.org> References: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> In-Reply-To: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> To: Vinod Koul , Kishon Vijay Abraham I , AngeloGioacchino Del Regno Cc: Christian Marangi , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, upstream@airoha.com, Lorenzo Bianconi X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240918_063322_709379_D9C760E3 X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix typo configuring REG_CSR_2L_JCPLL_SDM_HREN register in airoha_pcie_phy_init_ssc_jcpll routine. Fixes: d7d2818b9383 ("phy: airoha: Add PCIe PHY driver for EN7581 SoC.") Signed-off-by: Lorenzo Bianconi --- drivers/phy/phy-airoha-pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-airoha-pcie.c b/drivers/phy/phy-airoha-pcie.c index 9a7ce65f87f0..56e9ade8a9fd 100644 --- a/drivers/phy/phy-airoha-pcie.c +++ b/drivers/phy/phy-airoha-pcie.c @@ -802,7 +802,7 @@ static void airoha_pcie_phy_init_ssc_jcpll(struct airoha_pcie_phy *pcie_phy) airoha_phy_csr_2l_set_bits(pcie_phy, REG_CSR_2L_JCPLL_SDM_IFM, CSR_2L_PXP_JCPLL_SDM_IFM); airoha_phy_csr_2l_set_bits(pcie_phy, REG_CSR_2L_JCPLL_SDM_HREN, - REG_CSR_2L_JCPLL_SDM_HREN); + CSR_2L_PXP_JCPLL_SDM_HREN); airoha_phy_csr_2l_clear_bits(pcie_phy, REG_CSR_2L_JCPLL_RST_DLY, CSR_2L_PXP_JCPLL_SDM_DI_EN); airoha_phy_csr_2l_set_bits(pcie_phy, REG_CSR_2L_JCPLL_SSC, From patchwork Wed Sep 18 13:32:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13806902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FF04CCD1A5 for ; Wed, 18 Sep 2024 13:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oh+QKS8xkzmqewqty/YVjU4266/4pCS+11rBOsje884=; b=Sk8EeeBnAi24ITTqWCYjJpdeDO onUqdV9R45g4beDTDbyoSNWqmy2GD/KXZGJimsYJBUA1SisPd+HmLY6xJ0puhr5x7sni93mUGtHRt /elch6dY/tZmo/5iaVtWa3IXEKjE806u4vZpNOrH270BJRyOy7E0ICVkeyAn/qOiuI5KlaekOf8wJ iyQvsYCkSxQj598iCXRvLfD34UIIQhyUzVZajfTuGK9LHyY2Ls3Lp2oH08yPoywrEBiHJvtl/+r+T rC33q+9fW/uZXkdwAhdMUYBMgOCjURcM00j1HtrQi9ltPF92kMBUDvmE6I+iq6rdCLiaIAkcD4hKt 3IEOMgog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1squtP-00000008Lff-1vJd; Wed, 18 Sep 2024 13:38:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1squo9-00000008L1X-0EXA; Wed, 18 Sep 2024 13:33:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BF6C25C5CB3; Wed, 18 Sep 2024 13:33:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBA8FC4CEC3; Wed, 18 Sep 2024 13:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726666404; bh=DOm2BG6AMxdE927gikbeKZHeNqkczmwrGnj2NOpTHwc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=P0+98eD0EYLxkd0RxjjjZq3Kt89O8hWXJ0sgWOLzRKiW6OkU3HJatu5uEjnrL+zj8 OIbZrpPbpJk/2M8wKhy1que2vHAZU+ZE6fmavMcMlfstblvL2x4Kkc2sc8RmC80tws NtV0rXTkt4OZpsJ8umEl0hnbmU4EAbbwEMOYB6JRqWZA9GIt67gGOxSHvFEx9gnGcL Kellz5L35WQ7jrzWvk8UzK9QLD0oCquByU9gzUj/H/b/xu4eZ2jxrJFhVisKtrzKsA aST5pRkwsXcJDYnNY9c71YAAbEIkbTCcwOPD/zCupEiF9L267g94f66Cysi7LfYWqI 7Mp0e8lfncunw== From: Lorenzo Bianconi Date: Wed, 18 Sep 2024 15:32:55 +0200 Subject: [PATCH 4/4] phy: airoha: Fix REG_CSR_2L_RX{0,1}_REV0 definitions MIME-Version: 1.0 Message-Id: <20240918-airoha-en7581-phy-fixes-v1-4-8291729a87f8@kernel.org> References: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> In-Reply-To: <20240918-airoha-en7581-phy-fixes-v1-0-8291729a87f8@kernel.org> To: Vinod Koul , Kishon Vijay Abraham I , AngeloGioacchino Del Regno Cc: Christian Marangi , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, upstream@airoha.com, Lorenzo Bianconi X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240918_063325_168121_BED0D2C6 X-CRM114-Status: UNSURE ( 8.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix the following register definitions for REG_CSR_2L_RX{0,1}_REV0 registers: - CSR_2L_PXP_VOS_PNINV - CSR_2L_PXP_FE_GAIN_NORMAL_MODE - CSR_2L_PXP_FE_GAIN_TRAIN_MODE Fixes: d7d2818b9383 ("phy: airoha: Add PCIe PHY driver for EN7581 SoC.") Signed-off-by: Lorenzo Bianconi --- drivers/phy/phy-airoha-pcie-regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-airoha-pcie-regs.h b/drivers/phy/phy-airoha-pcie-regs.h index bb1f679ca1df..b938a7b468fe 100644 --- a/drivers/phy/phy-airoha-pcie-regs.h +++ b/drivers/phy/phy-airoha-pcie-regs.h @@ -197,9 +197,9 @@ #define CSR_2L_PXP_TX1_MULTLANE_EN BIT(0) #define REG_CSR_2L_RX0_REV0 0x00fc -#define CSR_2L_PXP_VOS_PNINV GENMASK(3, 2) -#define CSR_2L_PXP_FE_GAIN_NORMAL_MODE GENMASK(6, 4) -#define CSR_2L_PXP_FE_GAIN_TRAIN_MODE GENMASK(10, 8) +#define CSR_2L_PXP_VOS_PNINV GENMASK(19, 18) +#define CSR_2L_PXP_FE_GAIN_NORMAL_MODE GENMASK(22, 20) +#define CSR_2L_PXP_FE_GAIN_TRAIN_MODE GENMASK(26, 24) #define REG_CSR_2L_RX0_PHYCK_DIV 0x0100 #define CSR_2L_PXP_RX0_PHYCK_SEL GENMASK(9, 8)