From patchwork Thu Sep 19 04:46:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807327 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD5217740 for ; Thu, 19 Sep 2024 04:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721211; cv=none; b=kWvJAtNL4ASfA9nvrzo0SY4VOwriL+AJxaM5vBM5DKQmtuYX7EfTM8JRZW40RWWNxV3sd2pwgV4kgOA8V27Pr5HAkAPTFH9CeXLYLDEodtSTC+OTIIPGT6O0DQnJbv0msONIEY0Z+zqVY6ocSkVFMYSols8ouj9jZilvJBsslXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721211; c=relaxed/simple; bh=IoqNRBXFy/wI6A8Da5gsnsZfUt5toPKUe8IBwqqaRvI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IEXCktFlnY9Vgdg6WJ/sA0E1jPTQiI/pxKkbjKMCO18sgTX1fCGOZg5E7NLe27seXVtkccogKSErLt640Nz8EYBmthealG9pSQq/ZFr1xB4zRH7THI9yedmK5QHk2nl7/4Jehd/YeuxDI7yiM4c8PyqLYCcTLOhk/Vq3l5h9hDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ke9j1pCH; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ke9j1pCH" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-71979bf5e7aso286032b3a.1 for ; Wed, 18 Sep 2024 21:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721209; x=1727326009; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bKE/FaSnwekzuSHN/DiZj4HlusD3QhW4e3YSU1WvaKE=; b=Ke9j1pCHAbOOkWfKFaULH9CT3c8K3sUuL/Fik0s1tEB7HkZdVvupwS8e6JKn2rvlxG hP5prvJHCg8iaONy/iGhxGcXZ6hGuNeyleABGpz5ufc058UMd7Y/m0bqDWssvzR1P3Wb 0YuIu60fjELswIuaZMwJhjOdliZGFA/rY3ZJDQhq7bzcg9MqyoyHW1e0CczQhWO2q8Ou 3wQjE/QVlCnTMkM51AL8CrzKZ4kPVrhaO/JOLGRPIFpjZgB1b0clyZmu8buCtpNqBzxQ Q3ukv1kyQiVZFbCf+0uS7hQkDUruMvW47Xc9Y+PHN3OmkgJAQOSd05GNzMoEtCaxys/+ xyaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721209; x=1727326009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bKE/FaSnwekzuSHN/DiZj4HlusD3QhW4e3YSU1WvaKE=; b=ah5dauXuNb/vQPJ0DOIVsTmHloJj78mHsMeNQtAfDVpD/NhACOcQrKpj5CODMOzPOE J9NS5g4OVv0kEz7HdHe0/UI43+lYqndG4XJwGlRGyweajcoMunO0bq+dN+rLQdcGXQ40 3e11bfPxcjIUJxr4Mlv4+2opNy7pcqKIzLHirFK+XE4MNvDReZIwhArq1Zk33lmNsiJO jaav5dZRbAzRvxAudQx961nQYhZ5aAuBawXwOmfisLXL0TAZkP4/b5DMpew/7xG8CaP8 gvqS3SJYCs7DVqFyYIqFViWGaKXYgV+0t/58xjHn5vW1teYdV562x8RxqhGDOUtQbxp9 OfFw== X-Forwarded-Encrypted: i=1; AJvYcCX7DopVSJfmAsP01RvNSgYMhVKKJ6TmEhRt9MrnELsbveM93OTs/ANr2SOUKF6P33ES7fs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf2q34gjs08rthfu/5sBKPMmoZhAKa6zRyp59Y1arO/YrbVkvf bAtfkhI1dKNs57tfcAWE+J4OQSNFduIAEomSWVHBGsqEKQPUr7tzZ/IW3mwu4o4= X-Google-Smtp-Source: AGHT+IFSLpGq1tdAK7kcH0oPXH2ipnr8o9jAFjv4J5HFm8vaiwaqPv2XJ4VGf5F1OUzUb1F//zn0vg== X-Received: by 2002:a05:6a00:2389:b0:70e:8e3a:10ee with SMTP id d2e1a72fcca58-719261d9b0dmr36234028b3a.21.1726721208838; Wed, 18 Sep 2024 21:46:48 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:48 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 01/34] hw/acpi: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:08 -0700 Message-Id: <20240919044641.386068-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6d4517cfbe3..006c506a375 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -534,7 +534,7 @@ void aml_append(Aml *parent_ctx, Aml *child) case AML_NO_OPCODE: break; default: - assert(0); + g_assert_not_reached(); break; } build_append_array(parent_ctx->buf, buf); From patchwork Thu Sep 19 04:46:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807328 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DB1C1BDDB for ; Thu, 19 Sep 2024 04:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721213; cv=none; b=ov/BHF/Y624PcjHh043x3D0trbe9sSBBSv8axWkkeYWt/TjZXt+Mbgm+Ih9jpOW60hJDHnSmdKT8hDaOOst3m7bfhLukPb4ZoR5BP0B+GX3pVtkSfZD43OUOzjdG1msN8isIDHWFRoyMfLD7zRYteSRrsDgoAv7LfY+bd9S87Ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721213; c=relaxed/simple; bh=FClGeodaFTPTQ/kJ4c+VnhoYNpE0LBA7sz54iVx7eK8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HwI1Wk4drPOvZJBfh/pVv7VFzHjiOheoqN0qaQJ0xMTLsdt65zhjWtwl9GNsISuG24JIoyfzva81wbCMjn24BsEDQLSCzb39k3E/jio2CQXG1w0rWIBOykZeuQMdeGh3ETt7TN3gwNhJ/rR1fAajdjKL0EHHW7glLGeinoKFUB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=J4l9/fnN; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J4l9/fnN" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7198de684a7so264976b3a.2 for ; Wed, 18 Sep 2024 21:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721211; x=1727326011; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OThPa8+cW/n1sVdbzQjJCeNQGruzF8/uwJ+qJfwzSeE=; b=J4l9/fnNxwR+7A9jtDp2bURYNyJbHWOwNAQGj/ltTScvfwE4lIv/2mnQN42RHSnjIN Qg1S3NwXmgswjlR0pXDMQQvTW568eUWXa/KqJ01g1NxLS/gsf/1OwqQuE2e9scfyJLnh OSkwqETqp6YyLmfJHOKS4zG88FCyJfZZ6RyDD+spMcrTts7NsKHCb7nn9he1uLsypUAe cWfF2TpaEjpoznmMBryScxGa/QX0o6ARv5h5kKuiivJ4gcaKIpYRkhc3Dd4ajkO5Zyld iq+T8Ch6/l9qPl954nr4cEMVAAHkuupCzIGtnzdsxxRTtQKECIkWaL3MtF8SHxg/4TpH Sckw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721211; x=1727326011; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OThPa8+cW/n1sVdbzQjJCeNQGruzF8/uwJ+qJfwzSeE=; b=O9Q4JRpAfB+a1w2IXtaAL573bqVxBVvyOKEHjSk54o21jbcNSNJSHPGdVv9X2K08bb vnkPgmEEpzRWddQwt0dXqsw9aWS/gcCbgUpmPWywp5/CVstw7HGE9ZmuFBHO0gQGYtkp IV+aw/9eUIkqtvnjOBSqDKHQNbxGQLazEDIeQQuEgwfInbMvCFt+n/whV1Wv6+E9kncT Q30KnugBMMDI+TJpdZAKZVWxuT5DvCv6uAxNdNlIDjbWguaYXcBUffxJRTH4C3zlcm4n QBw3YiPEoswbEMAQHKIAh5dcc8W3jyld+l/7MJ5srPvPxFEW4MIQFLHrBTkFYQxdVNC/ NTMg== X-Forwarded-Encrypted: i=1; AJvYcCUP8CnQAcaBHodGaRRF8kb08OzMXGyGCUS2CFvFc+0xR2z8G3NlNlcj6PWS3406rqIxmek=@vger.kernel.org X-Gm-Message-State: AOJu0YxSBrzyem8SUHllG+7cCUo8809yNQEQcV2IfB/3dLVFdiTGxaRn nmceJ4V0wUJ6wGUMugH/ve/1vaFc+7aAftVAaxBEjCJsgOy4l3J4HWaslUHTnL8= X-Google-Smtp-Source: AGHT+IFQfcPKl3bpJHPW6gITFiRun3OBAH2WiwA3N0tnHOExmulwzhVj1BKzCqzynDuxHz8GGaT99w== X-Received: by 2002:a05:6a20:b40a:b0:1cf:3838:1ec5 with SMTP id adf61e73a8af0-1cf75c7ea5cmr35256921637.5.1726721210847; Wed, 18 Sep 2024 21:46:50 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:50 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 02/34] hw/arm: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:09 -0700 Message-Id: <20240919044641.386068-3-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/arm/highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index 6915eb63c75..f103921d495 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -199,7 +199,7 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id) machine->cpu_type = ARM_CPU_TYPE_NAME("cortex-a15"); break; default: - assert(0); + g_assert_not_reached(); } for (n = 0; n < smp_cpus; n++) { From patchwork Thu Sep 19 04:46:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807329 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B0A81CD15 for ; Thu, 19 Sep 2024 04:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721215; cv=none; b=XYkYMPkD4rqmYGbfLSv6N3oW/HK/5uaL/6z882Bp3nkJ49DPkHpYrNL2LrHHQI8u6XNzrgicrzC6y/riOzwbNm3F+Uh1CqNEcdPbuyJJOmQNiIwq1tMxcfv/A7pP6xwV29lpTw/JG6ZIpQ8+yDAZrWbc9ivVEnqvOTOUycX12Q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721215; c=relaxed/simple; bh=W5aWB2iyXXQuxV7o2KmXYYCNiRPnXk067barVEYx0UI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BpJqUDU9TK7A+wdz4WMitIQbhSwhY9f5+y6LUrwZzdTIXhnfJN9vQDB30fhlmXBEVnUfQcwrAZLQz1X2Tx1uL3o0RRhjJDKXe/Nez+pIKcnR6KuHeHMSXlTgtIb4g5/yPxryb0NP5Ilh6ak8esyeKEHRErdOBt0cULLeCZdtyfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=chOe7lzQ; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="chOe7lzQ" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-718e56d7469so301340b3a.0 for ; Wed, 18 Sep 2024 21:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721213; x=1727326013; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0/2IU4UYdfrAjMX4NizJG5E5V51UHXtFH8CwKGzIrQ0=; b=chOe7lzQeMQ+Gvnukn5Zcm48jaeUc1pqvnXT96Zc30bB0aslyo3SvzXcSxrPIx19XI 0u+jBV73MOxDs7arVQIz5eJx/c9RD4oWRY5LuWlASbrJSOGpQUyI6vJj9DhQE8V1KGw+ oSJjXnTC+EyspO9zue48+WmMeCkXODCSzsNaMdGXw/0ZwZQU147kIuwTvzLi5qhr43Jz CNDeEF7I/hFkIrpdHPbfViG7fyVchGYU2hUFD78w7haELatY5jpHySiuPm54QSwJaDHL xK1yCudFORPbkOYScv/vkHs+9LE8QxkdgUrg3sqpxkhBlwq5IUNTKeejGt5B8do6n94g bhjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721213; x=1727326013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/2IU4UYdfrAjMX4NizJG5E5V51UHXtFH8CwKGzIrQ0=; b=Ue/YYzXQNvbP2U6Xmjn7J+oKmD9KtmnxF3QndKozLpcMh3VyvXqQ95uBydvXMsQxU6 0Jlol4mjWCLuLpUQVymSWeLLogQupI6iLVmZPbgonjUv8EjW0J4KMzpEbtQXQW0PdJyV 8ixFN/+iPJRemEW48v2iI3+OAOfoN+VOWAq3txh9lYxW2ircJ5a+Ibv+j57vD/hYzz5J QcNQuSFi1JEBkGTwTA9BrvABfUkof6N+DP9NKsSZ5zTpu3ge9JWt1yWUWL6LyAcjpjmw grxv6J6yQUBuxBs9ySdZRpgJYKeTLOXE8dlVN7xqbSJPzJ5OiFGUYOuK3iD7mFXU9TOF DU3g== X-Forwarded-Encrypted: i=1; AJvYcCV3oAyeLQPTfUqf4w8oIZjUSZpl3wcH8EcpIOoRrzzTpngcB3FYPJAKzhxIV8a0q6PhT/o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5TWNoNeJIyIubYgDdXEpDXLR1DI607uOMYMVRD8KFbM5z07Mp hFdF0j6Y6lUpI6tAzty4/nfY0uGuizPleKUj+8vs2VYtBuLhpSXDKPQabpzbHP8= X-Google-Smtp-Source: AGHT+IEcE62Tv8QknJc8pTjVPHSXUbymb6AaYmeRJfTOhBz1uvzhH2wZstAOj+tMDYx/X/qUzXsWew== X-Received: by 2002:a05:6a00:3c73:b0:718:ea84:3e50 with SMTP id d2e1a72fcca58-71936afb98cmr25001957b3a.22.1726721212760; Wed, 18 Sep 2024 21:46:52 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:52 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 03/34] hw/net: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:10 -0700 Message-Id: <20240919044641.386068-4-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/i82596.c b/hw/net/i82596.c index 6cc8292a65a..cd416a00ffa 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -282,7 +282,7 @@ static void command_loop(I82596State *s) case CmdDump: case CmdDiagnose: printf("FIXME Command %d !!\n", cmd & 7); - assert(0); + g_assert_not_reached(); } /* update status */ From patchwork Thu Sep 19 04:46:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807330 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 819A51DA5F for ; Thu, 19 Sep 2024 04:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721217; cv=none; b=B1jN1dlpsKkbjH+PADeu6X1LT12hGDWp/dQ4o7gPBsyP0gtg/ZyLK+Isvdkw29io15tpN24ccxMI1tVBXug/jOLZVE7wIfy33RCTfjxfUNRvdLR2CNC1EqN33CzVJ/vRyUZPo1VxxU/THAKUXnY+DG4C2MYjWs41VwkEpsLgPzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721217; c=relaxed/simple; bh=N4L+nfwNlhn3xOr6sW3FA2aKkKmLjJrHCa14wWzSry4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZE/gaZU8bmjZDauyhYK3XZkIxzU7nBgaweJ64UUJkOOzrn25vdh9e6qTUAwtvSo9Mrl4nCBYpiHc7yY8/fSor1UvXR1tQWI49DP+ONgMX8MXVFdFgl8JvTHeNEHiVRmRsVLBm5CdEpfcdv4pRGQhd1LahTEfg+m1aS4axqLlUoo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xX9UxqYP; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xX9UxqYP" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-718e2855479so288654b3a.1 for ; Wed, 18 Sep 2024 21:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721215; x=1727326015; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Azxsm+D4GnAmylef8kDOF8WcNEX0H+f5CVUHICifCkU=; b=xX9UxqYPT1n4Z+3ESdCX9C82AVkg2eqq/HGo1DGT9eEqGeGeZf5x0ZeOA9GG6/j/mv 1A1urVgPYAScTdCv+nKWybJ+l12Kbt4I+cz5z9fpkG0NvaXgPCo7w+7EuonYDWmDDTN6 UjEZXRRXgqZ+LsrEul4QyaEcg6keBO5/SGA5jmbi0tIJFbkHcmIU4iGsLyw44Fq7IEUc 8lOggN4PGIOfqjq7kTMAFi4sybNq5948zEJUL//pitDQZvkNuCLfnAKHsTKOMLNw4ej4 0tJWx+14OA4ktxCl2ROjhDHyonQxGp56I5Iidsw0nF/sJTiLB70NhOT5wDPiPBmDtekf 4bbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721215; x=1727326015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Azxsm+D4GnAmylef8kDOF8WcNEX0H+f5CVUHICifCkU=; b=RMDTF1dgkK7reBgxj3EJXOafiuiVArH3CbImOJLbLc1erv6OSSUs1whMxPe0GyNgiZ S2JK0LP2JhLOT9P4l8ePclwUF52PaF26RfHSCoK/5ldEXPPY4eEALxUgv+LxSfu7FSyq Yd/G5XMRIm7OJyvsO+ceaxZUph4Z6YX+7iHI4hkSX1v9+qSMvfxCfCKi/qp6eMoDLcmy j554/J61rC4QaPb8ZmzoCCWHrB26p4KTcQOVBM+zANBssYbofWJ63f2BKxHzPHkkv3Wo VPGjx579ma/GPGwX4Kahz++CsGtB2dDxvhLVIvYq3gNJgHrd4vZEfHPP5v7d0bw53LFP cqKw== X-Forwarded-Encrypted: i=1; AJvYcCViQp25zmzhSBnvqcAJADCNqBMAQtPPFz4sdApH7gSuxQQ/nf7uOoNmnBSlW1oPqyWgR0A=@vger.kernel.org X-Gm-Message-State: AOJu0YytYgonp7ayB/U+9X21L8SyfQ8v27tTBIGl9TKllG9Rj6PHeldX 253/gcmDKW5ZAZGDzXMc/XqtqGxVfHIiXcResN8fCXSJNutEe6WvnLw5Pm6iIfY= X-Google-Smtp-Source: AGHT+IH8mpWfLmu3//R/SRK5Lkyxtdl1U1xPXKHUsLRMNU3Octj4owEwLu2zdVJDZekcWXpKcQsdUg== X-Received: by 2002:a05:6a00:4f85:b0:717:81b3:4c7a with SMTP id d2e1a72fcca58-719262060abmr39788484b3a.24.1726721214659; Wed, 18 Sep 2024 21:46:54 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:54 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 04/34] migration: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:11 -0700 Message-Id: <20240919044641.386068-5-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier --- migration/migration-hmp-cmds.c | 2 +- migration/postcopy-ram.c | 14 +++++++------- migration/ram.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index 28165cfc9ed..20d1a6e2194 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -640,7 +640,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) visit_type_bool(v, param, &p->direct_io, &err); break; default: - assert(0); + g_assert_not_reached(); } if (err) { diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 1c374b7ea1e..f431bbc0d4f 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1411,40 +1411,40 @@ int postcopy_ram_incoming_init(MigrationIncomingState *mis) int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_prepare_discard(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb, uint64_t client_addr, uint64_t rb_offset) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_incoming_setup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page_zero(MigrationIncomingState *mis, void *host, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } @@ -1452,7 +1452,7 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd, uint64_t client_addr, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } #endif diff --git a/migration/ram.c b/migration/ram.c index 67ca3d5d51a..0aa5d347439 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1765,19 +1765,19 @@ bool ram_write_tracking_available(void) bool ram_write_tracking_compatible(void) { - assert(0); + g_assert_not_reached(); return false; } int ram_write_tracking_start(void) { - assert(0); + g_assert_not_reached(); return -1; } void ram_write_tracking_stop(void) { - assert(0); + g_assert_not_reached(); } #endif /* defined(__linux__) */ From patchwork Thu Sep 19 04:46:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807331 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B3E7200DB for ; Thu, 19 Sep 2024 04:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721219; cv=none; b=KYXIRjqn71wy3qdHAuAURz5cPdfSIaI9pYg9Jc4NCeBW84GVEq4mOOSOZlMOep/4xfHulfekc1Payn5hxsctswOYBMoQZZARFWXBitGhpK+wsxjeI7ikJsVxfR2DjsHS3tZd5lvYmP81Mq/AXu6yvgb2Kkq8sfaG67Qbr44TjhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721219; c=relaxed/simple; bh=tBeGrz6uXuOASALerxc3vtg2PDwHLs8tXRn/ggYzN4c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q2NkMvIae2vb0NVULxaEF5ikRpi7clxw+fbr3WmJIx+eC8/qxiaakEl8HHsDMQbVMnwE6Gg5yTcDpa2Nk9P0pRv25D7sjwQFcVF26RAqCPdYE0R5RMR+vemE3SmILzodZboQ5/xenuEgSJTbM9i0WmKze0+Tf296Bg0yjsP1tPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YUkcFh1d; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YUkcFh1d" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-718e3c98b5aso280049b3a.0 for ; Wed, 18 Sep 2024 21:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721217; x=1727326017; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KJkmiG3PhPpYsgMJ7XkEBDNaPQyoDU9Xw+XJyRk65WE=; b=YUkcFh1dTyfWiWevuwRHHuVnalVpBCm3JevuvXTRwBC37K1kIzxXJeuPAqbro4S0z0 UWxvOdA5nBRuLkcdgiDB9nhSn6yB0WULGf6I2xrUTMG3eMopxaQYW83u6P9lgTGDMFSH 2CtxzZLCOOO6DKpTW65W7yMMZ/NDcSpFInkN5ibIE+aLAZCMmarME7rYCgAkBeBO6w9w t2KJmXYgmnddkcq7YbvsleoB6UrpSawqotDamYpcvDXt0lStk1+71nX0X78tFdB1PV9n 6jT5un3ZuznHdBzEHYFBVgpSqw9m/nCndovS1F7/WkqU4dDYb4ZBS0r85TQcQrK4SHZU kDcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721217; x=1727326017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KJkmiG3PhPpYsgMJ7XkEBDNaPQyoDU9Xw+XJyRk65WE=; b=iS4JLLLlzGUhOv7jdFRzPotnum99rQP4VD5qqRW/FZg7JcoKV1/jLiuIkkxd3KJLJq HEO1XXrwrYqggU1HGweajdo4jLY3XxQ2ydLVvd3XEQaEPx9O6c+WX/PEyBZxjcflOIA/ LFsVpNAnx60bwWMss0m2htw+exI5ph+fORnG75QVNkOYLFqO9ImyDF8K4vAn+OTBGN+Z CIBzrh3PSg7RzvqXlvsv+WV9skb9TYHDU3PZ9m8vGHT2NvyyoxVXx1CaTgUPD6T9eCVW bK1Drgd7AqXwA933h3HLH0EtzJMg0OcJZRmcbhPP6WPjBqrBnei0+QOE6GRM4zzG2Ujn OaIg== X-Forwarded-Encrypted: i=1; AJvYcCUL7XRkT0EBuEUC6/NoDbcUq+V43+lbSOUc15sFBpGRSSLC5EUkvPFF+tMlqJUcgjoJHsc=@vger.kernel.org X-Gm-Message-State: AOJu0YwWFeEiKPRbRrsaLWmULGQb2/V0USIddVoay60XrCVE+Jylr9tR fZ0jBRgsmejx4B2tBCuY0SGddTvLRleWp371Ox963+SX8/LDcvHIEeB5zpIJapzVjKfqP0LNRgd sVqw84A== X-Google-Smtp-Source: AGHT+IFI8OaToJZDzbcw+Y/dxaLu3fYE/OJ9AAnzLLztALk/zezzILuHxXxJLn5xpki0Ylem6dbZgA== X-Received: by 2002:a05:6a00:2401:b0:718:dd53:70db with SMTP id d2e1a72fcca58-7192606c438mr38378490b3a.11.1726721216563; Wed, 18 Sep 2024 21:46:56 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:56 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 05/34] qobject: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:12 -0700 Message-Id: <20240919044641.386068-6-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index be8332136c2..a62865b6423 100644 --- a/qobject/qlit.c +++ b/qobject/qlit.c @@ -118,7 +118,7 @@ QObject *qobject_from_qlit(const QLitObject *qlit) case QTYPE_QBOOL: return QOBJECT(qbool_from_bool(qlit->value.qbool)); default: - assert(0); + g_assert_not_reached(); } return NULL; diff --git a/qobject/qnum.c b/qobject/qnum.c index 2bbeaedc7b4..2138b563a9f 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -85,7 +85,7 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -123,7 +123,7 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -156,7 +156,7 @@ double qnum_get_double(QNum *qn) return qn->u.dbl; } - assert(0); + g_assert_not_reached(); return 0.0; } @@ -172,7 +172,7 @@ char *qnum_to_string(QNum *qn) return g_strdup_printf("%.17g", qn->u.dbl); } - assert(0); + g_assert_not_reached(); return NULL; } From patchwork Thu Sep 19 04:46:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807332 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E401DA5F for ; Thu, 19 Sep 2024 04:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721220; cv=none; b=kKvXbjd8evGvE4//QVdOfKwRKcqph2icCKwUH7eMDogLdMXHM63rV8OnfRm6no8NUU054Mf/crVX/5ojLhaajnDsAQTIAjUel8lz7pFwZZu2vdRseg2nVcPkj5v5Bu2QMX7p2dRaL8vCZPZ7AurZ1uQFtPMbucgXkPA7gLb4UTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721220; c=relaxed/simple; bh=TvBkxl3sPyM3OkZIVOPBq7un0pBRgonA2CllyHWAgfg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mhCSCGisqwASsbxeZ76JclMAWoBSrfbIi/Yr1NZG/MWAqWIavaSUbb6CAi/pUuT+9ZyqB4TBeFVfBFjhWgxDAS1wr9X48Bp4XbRM8N2VpMnos6kemg+X+3WhIJ+CjuPwtKIsUcdeaXA1DGXTtdKQdd4R9UDLE9JtvTB46DI5QYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iSkOo2ce; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iSkOo2ce" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-718e11e4186so381548b3a.2 for ; Wed, 18 Sep 2024 21:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721218; x=1727326018; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qqlshtAdWrkwK7VFTA+7O6AV+UQemh0VvOj30SlF0fo=; b=iSkOo2cexh8ntC+NjUkudjt2EU5iRJHSz2topYUtNjP8bbcgzC6qaDZBbG4U4Dwro8 zB9XRjNws+Q6VWa9/G5mPTkI2xdyEIYNmVOQ3EUh1WUW6cWZ8itybD/9AA9eecPp1F0+ GPia5xJCARHK/RkGnpG6sy/P3w6Q7Fvgm99c25UMQiLlhddJBF+MjmLk9X3hikd8akeP 7soeS7vhGADV6BhKzS46tXfH3QLxgfuV+IZ4pfo6P2ZbX+UbHJumKdL/PbIVZF82TcRj 4KR4Yrt02K8jonovg9r6ENa4/ihcF8IlTnXMfSWwcuvTkY6KN+nZqcsg3pvAHc8lxptz H94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721218; x=1727326018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qqlshtAdWrkwK7VFTA+7O6AV+UQemh0VvOj30SlF0fo=; b=raur8Dp1dewYvPLC4QwTwgQML+vXLjM1NutT18nWgMhoIxEBjv59rkwm3g8HzL3P8Y P4BgiJaVMOOW15YH6gd7mCKvVvqe1zkdUAIuUZIagQajBbsUWf7XwsEkvrJZKOpzKXBX LkkOy8G7HeaZVR1LMoosmIIWflImIhHlBmBRuxvhLcG7XueVMiAAe8CbY5Gv9udSn6p+ InrE1MMf8ZX87GPJP5VXrhwWMzQlHVRkrqgU9du1WcMv1AgMCABb6cTIqChKRdPyTVyy jCRcsioewvV+qRHBj5AOaxOkVkQwkF+QUI/QG+WLwAZvZKjs88hFDO1HJwB3x4WeThWk kxBQ== X-Forwarded-Encrypted: i=1; AJvYcCUQfibZ+vCduTDwlTlEPRha6zqUaNNqivZD5nMWu1s+Fk958h9+37UJSKMJ9em0TVeRflQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyteFfmcqcKK7dA42wB0h3hS3raHgbRM+IGRjSpcppmp4PtmvqV hquzu2ufiDAv5MtbVhbHrpbTsAkXQFqyCpVVD/zh5Bc4a3gqqFokNTiOycVQi5w= X-Google-Smtp-Source: AGHT+IG0bmr1+1NNMTp9lkGEAqdgH7QtfGqFeAcXE6p0/9GQ6ISEzkrmQKWYgaOl03thN+dHJUIl8w== X-Received: by 2002:a05:6a00:2d11:b0:714:2198:26a1 with SMTP id d2e1a72fcca58-7192620d8d3mr36118214b3a.27.1726721218493; Wed, 18 Sep 2024 21:46:58 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:58 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 06/34] target/ppc: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:13 -0700 Message-Id: <20240919044641.386068-7-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/ppc/dfp_helper.c | 8 ++++---- target/ppc/mmu_helper.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index 5967ea07a92..ecc3f793267 100644 --- a/target/ppc/dfp_helper.c +++ b/target/ppc/dfp_helper.c @@ -249,7 +249,7 @@ static void dfp_set_FPRF_from_FRT_with_context(struct PPC_DFP *dfp, fprf = 0x05; break; default: - assert(0); /* should never get here */ + g_assert_not_reached(); } dfp->env->fpscr &= ~FP_FPRF; dfp->env->fpscr |= (fprf << FPSCR_FPRF); @@ -1243,7 +1243,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if (decNumberIsQNaN(&dfp.b)) { \ vt.VsrD(1) = -2; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } else { \ @@ -1252,7 +1252,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if ((size) == 128) { \ vt.VsrD(1) = dfp.b.exponent + 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } \ @@ -1300,7 +1300,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *a, \ raw_inf = 0x1e000; \ bias = 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ \ if (unlikely((exp < 0) || (exp > max_exp))) { \ diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index b0a0676beba..b167b37e0ab 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -316,7 +316,7 @@ void ppc_tlb_invalidate_one(CPUPPCState *env, target_ulong addr) break; default: /* Should never reach here with other MMU models */ - assert(0); + g_assert_not_reached(); } #else ppc_tlb_invalidate_all(env); From patchwork Thu Sep 19 04:46:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807333 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723B7225A8 for ; Thu, 19 Sep 2024 04:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721223; cv=none; b=MoJEGVCZ3gaJ1IAG66zETPtRDeEZSvAwTa6dvIR4rZQEWuSU0JUsRUXaIA6Bz8SCn+VBjKPb5yC/q+FdsyzPXQ0A36THArwfbFsCNzIZUuujqOvk/PajcSB4z6qvdpmmPEF/eLg1LrvtlOsdBSyHcGu60WLpupQZaFuqHrQRE4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721223; c=relaxed/simple; bh=SDd/Jo9OZze1Z8uYQ4b8OezfkU3/I1UkLZARNNEkawk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Y0gXqn55XAe0qrhJx8SiCwojOSjQyaodhaGaFkEMDdloo9eM4Ipckw4USWXtBUjtwKaA4WaQZSZOFYv7BKzK6FG+iUIa4MEN/jDCMWy+8oYkYNS6x7qRxPn55yGk603rArxAaU/VgaZH3KRlN9STZcrxQdDx0H+8e2oK1k9A7Z4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mze9w7Ti; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mze9w7Ti" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-718d704704aso333939b3a.3 for ; Wed, 18 Sep 2024 21:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721221; x=1727326021; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mQ5w0lQctWZKvW76VfUVnQRwnSRhyDW+QKlbN5pvMwc=; b=mze9w7TiQ/1sB0xzeIvrWq9jOZEIHbedmCrNEF7GNQss+aUwcgPUx2FXu1R5LWfnZ6 vWFzZQtAHjk0eAb9i9ueP13ZnoWcgDhHY+FBJjywq9EnI4PUW2cXYdHSSLg/MPxvXNEG xm5Seiq6KcPsXQz5ej6rlWNTZgZQlX1etk7wJQJaUjkLWYjXOax2lVluDM6ye8pchI+V yNNl6hhKX7gH0LXNIp33aN3UwpAF3StNVhZjfzhLxsy/8Tif5JAmF13afP+gre90y1fq eaZtc9JG0/JaknnLBd+1cAtj/g2koDctoRfvO0m91SwXolTy3pp3wG4tjuS5q9Dma/IC 6gLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721221; x=1727326021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQ5w0lQctWZKvW76VfUVnQRwnSRhyDW+QKlbN5pvMwc=; b=FluEyC3Ms43k67RWzkYMZoZUVniYhG9NvBJH8oq33Yjio3RVuMaELZ7AmFCMiwvtQS bJOzlHpXx14tscCx8Sn1m2LGZodnZ9hT9xxmpR1iAczYzS2T0oZT1Vmb/NIyd/mQc9pw 0bGC4bwW84wv0LMzarNlC6R37LJsm3YWv1FKOB1LEK9NIrJVZy1nzpSSRxFR+7gW6rXh uWi26q+zyOZhFYaL2zZThA7nXEh1XUKff13TLQqWxswcjk3gSW8qYw4KdMclD7ihC9Nc KFvIri/er/8j4ZsF58kVX9dZWxhlEP3NrxLCYKWn05M8UsiMBivgj/u4EO89xBXdnxos It2g== X-Forwarded-Encrypted: i=1; AJvYcCW8I2/8k/I+iY446KefFd+aUxJ3tWpn26L7GjRvSUteRZqyI/vUKEwVTZjTbFj/z1WAXAU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/ludwDgrKvAyp+QitK5Bgmz5tunFUJk05k51sSuc5CH0V1g3v l/3zN8S33oO34BFm2X35QB/CLAF2zR35UR2D7kr2J7C9PZxD++lTuww3hFw7YMg= X-Google-Smtp-Source: AGHT+IEAmbhCRhYWmctGVCjASbSM7CCQw3PaPgr2ecmIRqDI7EbS/ir9wSwBUY/hOvsMNKhE4LWwDw== X-Received: by 2002:a05:6a00:2e9a:b0:719:1df4:9d02 with SMTP id d2e1a72fcca58-719262069f1mr36784043b3a.25.1726721220565; Wed, 18 Sep 2024 21:47:00 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:00 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 07/34] block: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:14 -0700 Message-Id: <20240919044641.386068-8-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index dd359d241b7..803ca73a2ff 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -5299,7 +5299,7 @@ qcow2_get_specific_info(BlockDriverState *bs, Error **errp) } else { /* if this assertion fails, this probably means a new version was * added without having it covered here */ - assert(false); + g_assert_not_reached(); } if (encrypt_info) { From patchwork Thu Sep 19 04:46:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807334 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3236B1DA5F for ; Thu, 19 Sep 2024 04:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721224; cv=none; b=RuBVEMB915KPAjtSrxN567UMZCeYl5CqSLyaolA+E3TJozNt7W2kl/ryh/T+NJM6OEr+GvDaQ0mXC5RkkI2reeA9Q8PSexwL4WD/VWxKHTPR8YlpI00uNzLciESjzy5OJj6Kt+70+xesr9BGD5UJhd6H+brAFiRWwfsRSVlvVmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721224; c=relaxed/simple; bh=+1cxAY4vPUO2qYxMtKRnkMQkjtL/nq8N06784vwiWEM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pQ0si0a330X234/w749WDNbZIWRudIT8nUiPSN+LWw76AzW1RaLO5CvlScxks4HaCuzwE0OSfRASv5Y59CQmlOqRUP2wFwP7Evhtv34pNwgZ/WXxBLepmCF0+snS5UCo+KLBCI9DTCJ29m7fl9lNjI/KoJkVs54NXsoDBaEhvZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BN2+yPI3; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BN2+yPI3" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7d4fbe62bf5so218891a12.0 for ; Wed, 18 Sep 2024 21:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721222; x=1727326022; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=De4sKLPybVhT2+Pc9xtI+CTmpF8ivUBlmtwhnsMRIOQ=; b=BN2+yPI3ajWSrDko5uylqj/ZzvTWkhW2ImKK8OsGqpIdQKulw/cdSuEt1TvCBflGWS LMYnNYtFyEWGi0uwdX+nEpYNGbe6Zwn0MgS7/NTRN52peR5XSX1CO2y05Uz9U3pHQtIT KjN88em/Oo+aiW/IR9TfhMM/aeEFkpC2VjrwKsaTl/V/AhNPv4D6GBWF4bNyJR/UB0f2 xc/fEWXdVTrr/HfFfKcEXpQE8PidzOxE52RZPf6Y+Pk5NACdheGsaCf5RKvazbJM52Hp i1qHo/AGBhUSXzJ1SQ0tDRMzgrdF0HEMXZgec0IttXY/vItpDL8Udu2O23ZMqr/HsOWb SRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721222; x=1727326022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=De4sKLPybVhT2+Pc9xtI+CTmpF8ivUBlmtwhnsMRIOQ=; b=ZFdRLMZBC1tLfXAHiAkRUcYVmAzX873/o9i7Q5C8U5UbiBymZ4+NHZlnk+CVgKu7qT DKrnKNg+czF96QwOOX6jb37s7TBdiEXr8PG1Vf8sYxyo236i3y47CvoxYTMJelWvYBmu fLHRz3scaeko67njdPxO4jUVZFsNQb5lbMT2IfBUwdmwH803I8wwSSlf96ItYS///N+k uzJWq3/Phrozvt4DhB3AnOLBfAk/jMOwyCobp86/u1LeNFoJeuh++KI9rnXa/QVScbFI iH6IrRzL4b4Jzfk2/Pgo03x87yIpe/gC3CwO+EyJYSmx1LUCAOWEe79Wq2ADUCHBP0QK 8NLA== X-Forwarded-Encrypted: i=1; AJvYcCVqF1EzPF2qXvpOi8mlV+dGo2u+p6biRS3hdNvbpEizdQdNlINXGCgik4o1dTimL+l9ANw=@vger.kernel.org X-Gm-Message-State: AOJu0YyFt1zuD/UAjr/97LO6d9JmbDokhizuZYd3k4lr3IjYt/SkBuhT VHRj+pNiWwlFJ585bfm7viaaOaDRTWxjuoelQuHetD+nhC63PVeZCRLwZdt9TgI= X-Google-Smtp-Source: AGHT+IE2Y81B/LKedghyO/XIB5KqiZokca4F2Biq0KEcZsGPJCLDi0vE6MjHgWLkzwtVTNzR2l7/8A== X-Received: by 2002:a05:6a21:3a87:b0:1cf:4326:5602 with SMTP id adf61e73a8af0-1d112e8bf15mr31788153637.36.1726721222472; Wed, 18 Sep 2024 21:47:02 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:01 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 08/34] hw/hyperv: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:15 -0700 Message-Id: <20240919044641.386068-9-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Maciej S. Szmigiero Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 6 +++--- hw/hyperv/vmbus.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index 9a56ddf83fe..ef50e490c4e 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -88,7 +88,7 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, return sint_route; } } - assert(false); + g_assert_not_reached(); return NULL; } @@ -187,7 +187,7 @@ static void msg_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static void evt_conn_handler(EventNotifier *notifier) @@ -237,7 +237,7 @@ static void evt_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static uint64_t hv_test_dev_read(void *opaque, hwaddr addr, unsigned size) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 15e0d600c7f..03f415bf226 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1874,7 +1874,7 @@ static void send_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_create_gpadl(VMBus *vmbus) @@ -1889,7 +1889,7 @@ static bool complete_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1931,7 +1931,7 @@ static void send_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_teardown_gpadl(VMBus *vmbus) @@ -1946,7 +1946,7 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1996,7 +1996,7 @@ static void send_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_open_channel(VMBus *vmbus) @@ -2020,7 +2020,7 @@ static bool complete_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } From patchwork Thu Sep 19 04:46:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807335 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B22A23775 for ; Thu, 19 Sep 2024 04:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721226; cv=none; b=tqBPoAXTjVlP9umJTmyvrYbpFuqCpV9xS9tQ+J1Edmcu1PVMMyKrR/0Ej9OEqeJ3jnvfr3D9Aw5roEeNIK2+cD/SKjihhB4jqyjRO5ALDVoO9hhkrF6jx6cKq+zvC75TmDdbNupRQC5ge6TfMv4FChQ+itd+eMs1+GGufkiSsDg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721226; c=relaxed/simple; bh=13RnyaHBVHON0a43aIFGGWd9STQ67b+kyR330rcN8D8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JpLtHj3smd2XxNpd+HATSyZ6D2ClgenLxmUEUZQUlilTBhS2lyx0ojpI+R8UUU8i6q9Rcwu0gmle2PueRSlOOh1ErOQxRSMdT5if29DmpMD6vObBrkxTvOWQbNBbXNIQkHVgx/dv0uI1JQh6ktCgATGijB7Cb6hYsmux8HfIzrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BkrLpYjy; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BkrLpYjy" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7d4f85766f0so296100a12.2 for ; Wed, 18 Sep 2024 21:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721224; x=1727326024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HfkyjDHktRIdC53aV7jz+MEYNAmpLLxTbQ4xm76fWo0=; b=BkrLpYjyC/MgpDmqHMkeJlCjPLP053/rgXSLacXLRNMoRW+CEYqkFfRUZg6XwNtEqB NAxHl+iB6HmLjCKLGJtH5jua/EdkXR9hOfQTDbrkMv7fce6UvkFCVDoeClacvGp5gBKY TsEQWLrZ3VBBl0QrfH8+rReijF1TZqnMGwIUjxNkd/0OQJBvxl9is+eX4fvIv2kthnpL DZDj0qvCa7zhraQ3hizX/5VzzGJUXrGqegmCuOKBqWCVnooiwtWnxZ95rUHcZ4+q/EjH Jixlw/SNFYThoq4RjbT7V+J0vi7b41rchRRBE4GheJz7DcZW2iqT+BJGnb/b2l+0mFUU ZPgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721224; x=1727326024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HfkyjDHktRIdC53aV7jz+MEYNAmpLLxTbQ4xm76fWo0=; b=vSRKh9eq29nf1kPgSPDVP71slyQ+e9+qBW0CLPnk50wshUNasfPyrbt/jxai2T+8W+ b1tWye0d67Hz0yNEjQoXhTR+Ql0OVlxRmvDviCaymZtKnbw9KvPs58DwjBfRuaR7HSS1 fz1zJHkc6xEAgv0gguz3eTB6d5GOnQbEPF37aGTx6h9dmRgTuRGBRDZkZuKJcF3a9alZ C7tbcB63lUN3890ubouNJ4O991w5QGbX08X3A3ae6RltJyzRCLc4PIc5NtuoUahCYs8M dRv9/HU4wvJhlxOCEXvMUSLUaVd7KWp3CxZ8Za95DzbYMh+ZoJkGxI6ZrZZ+3EHkBdfI KL6Q== X-Forwarded-Encrypted: i=1; AJvYcCUfaw/tEUXO4t2dvhuhXfxONh9tA7clHKInC6Y3S55FwUZUsRp8Iih4utAaIGg9LUO1Kxw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0+xYEWkyzBfpSAcyCwkKOCZZLDQ+Tw7KuX3nc0TTGL+JofIbk gIE4jbI9sUSwKiCS0hyPf3gmHmf8I/g3qn7lAPeUJtApbfwCKwPNrSLtz0UDaek= X-Google-Smtp-Source: AGHT+IFbn4h/5fpDdM1su4Z9mSEZxrAAcU1BwZZyKC3gnrGjV7NEGzkE2iqfTaMdogn2HPgRWiWmww== X-Received: by 2002:a05:6a21:3a44:b0:1cf:2ab6:a348 with SMTP id adf61e73a8af0-1cf75ea1dc8mr38949451637.1.1726721224333; Wed, 18 Sep 2024 21:47:04 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:03 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 09/34] hw/net: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:16 -0700 Message-Id: <20240919044641.386068-10-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c | 2 +- hw/net/net_rx_pkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 3ae2a184d5d..248381f9766 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -561,7 +561,7 @@ e1000e_rss_calc_hash(E1000ECore *core, type = NetPktRssIpV6Ex; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index bcd5f6cd9cd..6be61407715 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -397,7 +397,7 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) type = NetPktRssIpV6Udp; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 32e5f3f9cf7..6b9c4c9559d 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -375,7 +375,7 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, _net_rx_rss_prepare_udp(&rss_input[0], pkt, &rss_length); break; default: - assert(false); + g_assert_not_reached(); break; } From patchwork Thu Sep 19 04:46:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807336 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37EA25779 for ; Thu, 19 Sep 2024 04:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721228; cv=none; b=jrn6Em3vWgPG0QFJJfrMsH7uDFU9QNK4dFb4BqfskI8WDbWHMPNMmOfB4Ro1QA3RHHUuPZxLjcNr8LyoBvKu3/B7U+4JKvMzEzYzOTqIqTVQx0tIc/Y6hSO1taLbTKHGSoS0RGePgmoEcGygBz+K/g1VVhTNKjn5tFj4HNP9zKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721228; c=relaxed/simple; bh=RNTk/qmECFkTEx44xc+gELcnq0ftFvyRfHIqoob3R6c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M+sVued0TkZgSrgrNccuOuAc25y/COeUD9ckKKmUBZFXxNQ9APT1EoGtEMOR77WW0eOD59fITHF1uraKS9W0dAdGIA0LbbIuFbmn6oXk7V2QVg/O4D6xWmNCRkMWZ7vjHbBFaFsSa1V1Sz1/BcT912Ud122FBIF5PgHp7pP1NPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mRiMs6MP; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mRiMs6MP" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7198de684a7so265083b3a.2 for ; Wed, 18 Sep 2024 21:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721226; x=1727326026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J91xisxxghHlg97TfgBUUF7cBAztIX0LnTXW2HtCgj8=; b=mRiMs6MPAejFODSnFf12DHDUfIccdOn8ZTs3QcDwet5bTQVCEe4nDvyLfAOKXHYAt4 YmXeQY/pzuhhdJEmyUTuDFUvzibiK/vklAF4dUF6m4uAbO+hIQSECqEAjDFP69FFGh3R Gpj02WtuoHf6se1E2fzR/itzJURFLiILBFCrf4mVWg65ta54ZHhiP1hp3y7V8ELMd3gm v2r7/cIcSto/URxFLvWLlNxVDyhC/pszSOvGVDexlTlzmerBOfX84dyIBYlFF12r6C7k LWTJbdD8vwvUzedB/YhIE4hCmRnio1OiAVaBT9USIVaaPL+YHlDRs7+diyrqRVqQ54Wp QW0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721226; x=1727326026; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J91xisxxghHlg97TfgBUUF7cBAztIX0LnTXW2HtCgj8=; b=S2RXPCM4dkL0wUrtM+jE5SYzthMm9V1iazCMRywvuizACIoPVRViAZFOYhkyCxOGO+ WbOBT4vmIrw1fivK0FEBKQFTfTgrUFVrddz1McJFr95bJJOHIKNWwqDy2OL/ig1W2bSu +ot9i+KeeCnigvvKSNG2rcrNX1DA2RtCBxWEuo3UmonJMC047aKC56eXA6UWPryAqWSw TM+EZBJCf5oNW0gkkAKS8F1RIjGlSioQAkdJ/DX/QqKGiBCl+LDwGIsMZfMLLoHr4mv3 nmxWKIOwK5iG3cOHjlwDjg/Qffkt1IcucPpO8zH1oGtsaLSFiWfUKX0YzSgVlYW/KrSP 40hg== X-Forwarded-Encrypted: i=1; AJvYcCVTQGIeKrUOittwtghWt+HuEY+gSkmQExnXGzlojKMOA1LNkOJ57rDy0RFz3DrPkZtUljA=@vger.kernel.org X-Gm-Message-State: AOJu0YydHAqKmwPD8/2P4vWHNJLNikBlaqxtjVKPoJmO0+fHSSR0mJYH 4wfSqUhKXv6nnkc60DWWuISw3NYZjyVxzZaPAIwmh9HVOqTtLqSFhVfX3raOKuA= X-Google-Smtp-Source: AGHT+IGCW5jSj35sH5O5IBgPKf4Npc1WOdLbOOxXHUFlvIY40aSfwB5Uf2VB8797RC2mgCqAOWZcNQ== X-Received: by 2002:a05:6a21:3947:b0:1cf:27bf:8e03 with SMTP id adf61e73a8af0-1cf75efd46amr36339625637.26.1726721226274; Wed, 18 Sep 2024 21:47:06 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:05 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier , Klaus Jensen Subject: [PATCH v3 10/34] hw/nvme: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:17 -0700 Message-Id: <20240919044641.386068-11-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Klaus Jensen Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/nvme/ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 9e94a240540..2589e1968ea 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -1816,7 +1816,7 @@ static uint16_t nvme_check_zone_state_for_write(NvmeZone *zone) trace_pci_nvme_err_zone_is_read_only(zslba); return NVME_ZONE_READ_ONLY; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -1870,7 +1870,7 @@ static uint16_t nvme_check_zone_state_for_read(NvmeZone *zone) trace_pci_nvme_err_zone_is_offline(zone->d.zslba); return NVME_ZONE_OFFLINE; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -4654,7 +4654,7 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_CMD_IO_MGMT_SEND: return nvme_io_mgmt_send(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; @@ -7205,7 +7205,7 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_ADM_CMD_DIRECTIVE_RECV: return nvme_directive_receive(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; From patchwork Thu Sep 19 04:46:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807337 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB79E2AF1B for ; Thu, 19 Sep 2024 04:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721230; cv=none; b=slcXz5z2EapANulVhOXTVJzAWJqAzrrYFR3QIQ4Q2jD6l53ZLjzMJGa0kF4EpGj/NGGmzyuoBdR7MDZ8qufNiBJdEJL8ctshpRZBWmJhR8E7hZSWKnTmAgrqUGfRcPdL9jepPzmGd4fW+m6SjFa0uDg1UsqcRpaOxD4D02A24kM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721230; c=relaxed/simple; bh=lkULxEsAovLGG+eRqYN4iW86DH45flQJoKsBIg/reyw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=N/UatgEJIpzRjvqSmOchb6Yj2TJv2EvBwPTXteQp7xjeEGpCx8rDNS2G5wqqbqCgAqDOQl8nmw7X9Cj7qjAPAxhS7o4yqda8m6vBlJf5lBN6/uNmgcj9vxN7oHC6zEDpQKiczqiEEV8+56A7SszzBKlPsk4JY3L374LZcBQXmTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qkyaT9yI; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qkyaT9yI" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71979bf5e7aso286153b3a.1 for ; Wed, 18 Sep 2024 21:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721228; x=1727326028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=la0dMEWQk3jt41a1BnPVKduxSUDoWih+Jb1d+U0bfqA=; b=qkyaT9yIAkCjdfkwo7MhAoCh7OqSbw2q3NNWlf/QIPZVarQXnj9lhk/EX5YZtozocw NwBO1blUvGayAdzqvwk2XNsGsl0SrXbLMMB8KKUOMNfeyq5539QNqfcKjYtUVFOmH8KM d/XfMstRHZNUrX37kHufIM07lYuji8ZXMdWdTZ8++tTXMTuhHc382E8Oa8TT9omqUf3B 1COA2hwBGPcY8Xr6vMFH0qpKnGQgW93cre5fWKkVM+fzzE3XLheAVBNWwCRwx3wFbcY4 pZY9YIDpnTV8+K1qTla7cuE/FdMFRC6TcL4mokPrEBee0AZQBUKB49dwcfGjdhqbaOyt zgJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721228; x=1727326028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=la0dMEWQk3jt41a1BnPVKduxSUDoWih+Jb1d+U0bfqA=; b=FrB3yBA5b7MNEPryY925uAyt85W6JVPITRwt4bXU4TTrifQjg3gHmr20aSDgD/mNtx KXe9FPU11ahNkOVCvs8wL/wvPYfDO8wcmk+P2c5k0E4Ah0fK54aT+0iNM+XAtHerpnlu mxNWtqFyGP4NU9v7imYQRy97rBZA62xfmFpQDKNWu3zp7g/y9/qYy4jLQg/+wRphH6AL blltV/8bjSFzj4url3ugZGMLgQ9wjxrWQw6cTjJXCQVVLhKiy3eymA9ckUCMYoXvTj4d amfSYizslYu5oEH9acdP8w+ScfdO9whoQ66yXxVGKG7NTadSARR8TAks+EOvAowDZcGG 09gQ== X-Forwarded-Encrypted: i=1; AJvYcCUfN/IV6QQ9UyMBv6Xg9v/FOwYsP92/p1aP+9n5HCzHN6ddB3ve+rpduYGz+0eewZxRSNQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzllPO1OzLOvEVNulHD1X5tLrLDcJxA44o8J/v1zaWThNWTEdig c04rcl9CtDA73lkKNojifPfP52BC3cZqeNjGzkYRgjmCCWgS0cYY/qT5la2RW38= X-Google-Smtp-Source: AGHT+IFO8bGqNik5TI7HaUtD4Bw4p0cKBe+nMmhw2c5B2Y+i3tMDnnj5/Vu2AHTpiIf90gDt5Orsag== X-Received: by 2002:a05:6a00:2316:b0:714:1fc3:79fb with SMTP id d2e1a72fcca58-71925f9b26fmr39873231b3a.0.1726721228183; Wed, 18 Sep 2024 21:47:08 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:07 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 11/34] hw/pci: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:18 -0700 Message-Id: <20240919044641.386068-12-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2b..c6950e21bd4 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -46,13 +46,13 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) /* kvm-all wants this */ MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { - g_assert(false); + g_assert_not_reached(); return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { - g_assert(false); + g_assert_not_reached(); return 0; } From patchwork Thu Sep 19 04:46:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807338 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A581B381D5 for ; Thu, 19 Sep 2024 04:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721232; cv=none; b=TPmgCXJ23wo+gsddlbvtJKnp1or34xknkrKrhLqtjJHbbvg6p5LYYspIE8DdKaa8tY7TGT8kKGPrI60/56Hv4pnr+8bNTH2q0uM+LWoJX/9hvgTYRoIpmI1UV9ysoVunc34GvkLrtQCSmsupScwqoCCqNOhW/l8Z0SuvCgmjy6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721232; c=relaxed/simple; bh=MA4psclHk2mo0EvDqljV/Hi2LnP/rFStdZUcIWQbY58=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Iprr1rIl24b5ntJ6zBp0brFII+lvypDyITO1wy1QQSYIYzgGZqhULMK0Xyl4t0+A7gGF64HaFyc89maVsiyMWHP7s3x01FMFCNqgruV+odcjE32vYY94tfKyFUyyrR25IvS9QqLQJMxWfJ/Vl/HeWESHQYGJzcHYOTkcveEHG30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UIWoIAyb; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UIWoIAyb" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7d4f85766f0so296174a12.2 for ; Wed, 18 Sep 2024 21:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721230; x=1727326030; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CjdIkjZ1sAe4H4BC4R89ohVomEGFONKXxXhMv5Uru1o=; b=UIWoIAyb5Hk3qzocSyIOMnqW1d7xBlf9zIo85bbUMGnqInT+RGTzqmOAhg/+Cg8VfX 2q0COhRoOxF50j3sdMiPFJ6P5JAnLsIb6Ccf/PWE8yXN3PXoycUpSLWtQ9qkvHTbeUMp 0U12kmr9szy/tPUUFyjh4zsSRiSP+ojYtwttSfYHXB/vsNb7lRKNpzevv9FPteu80giy F214ZO8SeUz30aiNmA1FSNk2wP+meSNOOD/aKfsWW0m0AQouOahI7xh9r9kPWMpKU5uN 67NdIyQZ3XP/YLqSlFgL5v+uuXrx9vOdUY9Wo7hA/bMCqAuDtq2QvQec7n4yJg4bzwER Zkqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721230; x=1727326030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CjdIkjZ1sAe4H4BC4R89ohVomEGFONKXxXhMv5Uru1o=; b=ppN+m1PDFZr3pXGl1DkUhNrDU8UeRNv+Xw6hIdLvLeIw+llukKYuJWakt+17qWfjrU +KRof1e2J/RPMSGapBc7zI5M9d5Qc/71rgpiagvKgsPMVlgsq76daKyHkprNpiz1Kl04 ef/nHs6XEdz5/qAn0c9fodOhJde2NL+NLlpu5G8ZiscsdFF+0+wivPpM+xRCaFAOOa2Q oRx9AQnfDN3gIgw0dxI2vm7Dyp2HSIbv2Do15luJTbw2Cisie4Ji01QoKoO0V0Ves+px lnr6lsZ+djIQLihuGGfaJOnuSuFp0OBLRvqKR8m4yiPo25SNhVUZlotnAvLZslbF7GQf 338A== X-Forwarded-Encrypted: i=1; AJvYcCXCCkPfQ95SyXrs0lobglBbDdWe6elXth6gjyt6wcqQyqX46XoOp5RbHZnKRaq2JHo83Tc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0Beli3jp9/HmPWbxMp6gmFRv+mdSlTiic/KH2wfisxNPR9wVy FA7lrUGSQ8dRsIx0LVIdL7i1cYl+zMXV1EwyZWgtYhAiO/iNFOJBHNDNr9toEwY= X-Google-Smtp-Source: AGHT+IERhGsxI+Cf/AQ9eoxDwuPeIw/CBq8x28oXvdQRfLJHCxXd6tJwjKv16QtJVSkDvTe4ScWRrw== X-Received: by 2002:a05:6a20:b58b:b0:1d2:ea37:95f5 with SMTP id adf61e73a8af0-1d2ea380ceemr10245819637.11.1726721230050; Wed, 18 Sep 2024 21:47:10 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:09 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 12/34] hw/ppc: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:19 -0700 Message-Id: <20240919044641.386068-13-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- hw/ppc/spapr_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index cb0eeee5874..38ac1cb7866 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -645,7 +645,7 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, /* we shouldn't be signaling hotplug events for resources * that don't support them */ - g_assert(false); + g_assert_not_reached(); return; } From patchwork Thu Sep 19 04:46:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807339 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F47383A1 for ; Thu, 19 Sep 2024 04:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721234; cv=none; b=R0qX0WG/q9EjpeMte2PMI+N3WE/GZn6clZ1f6NB1yirz0TovrSLa3t1SN/7LM4yoCcQoDzS/FdMtp9BD/K7wnFRaoShnA5dcI6V1fSI9dWneGzkjBMTJ/FfrITWCDXJCKqjzTcaeoYYrCvz+MT7Kltm2A/2J33jUPlXCFH6o7uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721234; c=relaxed/simple; bh=opM1fuP4B6hYIxce6wrCIcsQth4x5c32Od/9tnr8SGk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=USUFyJem1jRplJlH5YMf2Z+jcmOC39sBfrc2Sr2VSCqtORsq0nWIiEaQRpPd+u9bbPYktztUboqT6uEzijz3LH26XcRASzhCzX0PnGn/fxEzeflZ1upatMg55Bm/sbv4yxYPnYOiiTIexLIp8BahTefjEr8rNFOBIizhXUjmsNk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LIFwYD4j; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LIFwYD4j" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-7d916b6a73aso213519a12.1 for ; Wed, 18 Sep 2024 21:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721232; x=1727326032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BFDTm87nVz3V5/Slt3dbvL2tTaVEGEVOzfLYJ3PuoMQ=; b=LIFwYD4j6B+0CPzcmP6heMI4BPR/l9hW+aixF8hwL71OFO//ILuQ+7kA3S2srTI+oe 3WDaGGbUzn1e6eIg9J24pOEDq8rMG2r8ZZT8YamlbagbRytMlRualLFf5vOXBsFNvtqO tPCpRVW0hDz592dWsTBmpDAH2lqMWxjKmanZucX2LOqnvkC5fCZ6UnGCdncNpaCesdjG h4NvNTt0KUh4vna6VXsIFh1N4CUsR0wbJk3XSssB/G5NGNLLVptunDlPWSDhICziDa66 /Ks90gVlCGFPnsMuqk92pq1/v3oisb3To3mJAAft7BddmA1BgZ/lpZq4YhNDBPjnxTlU lL6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721232; x=1727326032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BFDTm87nVz3V5/Slt3dbvL2tTaVEGEVOzfLYJ3PuoMQ=; b=VQEAkvld2bpOaRhqe2bRADjVvPVh18vMek72MbGWeyR+RfAkI+k9VDQoT0DfSyRl+G SqGV6apF2/XuXfkRDxE5B5MfoUVft5f1E31rquslMow4kVGxXfmS2bzrSkY23NWIEqHs 6n5G1KXY9b6HBlxq+0DpJCQuGrl1BeFg4ZnglWumPTKDPPQ2Nn5H+Ts9tN2xo5tLVxy/ sLy0jke4RBOf0fk14qn/vsMHPJdl3ME8ItavLRGbQI+Mrmoo6NpCfrTSG/qTYP//Fe/Y TMl3iUIXj9T9E+BkA3S4QMrpr/OTD1XM6W1GSNvRJbS9i5keNvZz3fjwXSb1balGdpkV rqbA== X-Forwarded-Encrypted: i=1; AJvYcCWcGy/8yhqexiWVmmBZI5YeowytAjOBzCK4ZC7SFKsdCkc72SIxJArV6Pib1/XOLZkgwZg=@vger.kernel.org X-Gm-Message-State: AOJu0YxslJZt2q50Q6c7CIsYGDAz+Rr7AO7O/Gbna3aWTGYGt7Gct/zx jmlldc4EmWMcerAhseePxgae+nFpkz/+7p9zXyYkgcz42nSvUXs22UAwv5+NQR8= X-Google-Smtp-Source: AGHT+IEyMy6V2A0OtvCxf4O48p53ASfDnJYGmnLQMeZ/04wkCNDXNGA3OfpgkgUg92nhjq5jeesYvA== X-Received: by 2002:a05:6a20:e30b:b0:1cf:3402:6e9d with SMTP id adf61e73a8af0-1cf75d76b46mr35535691637.2.1726721231866; Wed, 18 Sep 2024 21:47:11 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:11 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 13/34] migration: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:20 -0700 Message-Id: <20240919044641.386068-14-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier --- migration/dirtyrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 1d9db812990..c03b13b624f 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -228,7 +228,7 @@ static int time_unit_to_power(TimeUnit time_unit) case TIME_UNIT_MILLISECOND: return -3; default: - assert(false); /* unreachable */ + g_assert_not_reached(); return 0; } } From patchwork Thu Sep 19 04:46:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807340 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A187C3B79C for ; Thu, 19 Sep 2024 04:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721236; cv=none; b=PRHyNtKOSCbKf0aGTsbY69sETeTz7CSfKQMf6ca4JyUskH1erRixrRM048xK1R6UGNkr6bc53ysVnvWZYkN51UXXAc4YQyOnXOAsZulPF1IPlM9ZKrTnJeGUCZmVwshq2uh2nKcSPgd6V6ilezusTihw6/RwFUYA0P60eIDpAs0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721236; c=relaxed/simple; bh=L03cMnciaXv+Tu1dHQm4msd/v7u2MEWZ2b+KhDe0RV0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=Aw1gBzV/b/UNq8Ae+JXWtKFbg1V+Lvjnv+m3IB14oEMJzVI2Q3Rpvgv7nlyVI9rAS4WE2GNnHAsPRk5YgwSWKDQnN6EsmuJEP1cOhbHUvAcfOjT42ptzPi2d9+JQUUDHz9P3TvdBi9ySG29cQfJbqsyHtPUBLbdBQI+El6hP8Yw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Xg8iB9RN; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xg8iB9RN" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-718d8d6af8fso288055b3a.3 for ; Wed, 18 Sep 2024 21:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721234; x=1727326034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7PZhVYqzq4kADvRMhAIMG6rvS/s/Gp2LRBj3c7uTV/4=; b=Xg8iB9RNTIr8NP6JjBGg1UY1cXl6WTO4zJiQzSQ+8EtJiATcHTvi8fq2LhUVHXGWXe pXXeVo8wHLcTDy7jvUabT+smGNS2RSJMOGID19iZGFZOKq18jzM42JfZkZLdBkbktND0 0F/4+a2KV2MHLzTiJaKbs0TEhUFhzpm8nWOA3xN0nFNzSvp5wt7IAWXykiCC+U+gr8Zq sQ9vZHE15vPQiskPRXemZu69pSzn0+kLGSIeLWz5MzJwePsJlHKJGGwGUeHeCzcX7KYh I3JEHm8UM7fBw76zwku6t5/R5yTsPDatTmPwiATbOOePrbuB+Q4mhceLV734CLrxRzFX 9MVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721234; x=1727326034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7PZhVYqzq4kADvRMhAIMG6rvS/s/Gp2LRBj3c7uTV/4=; b=tnrjzyCaygh/p3FqbY7H2xcSVpzrk31A1CaquxHrpbA2qBdRf6dtg0/ecQ3/m8V3+W 5wkWK/oP/j8moe4cpsDxF8ctcEXB5mFd2rh8tcKwDIi01Ja1PE7Ulw5XOcZ1jD9Ex2Ca eiLNjnDhq/hv5JozFEIyzL9d3YAecymSswTGxweK9rEI5oKo9/lxgh2ucim6opE8WCEH F9YsIPoSSrX1KzDC5IpcX9BN3Izzlj7nsEU9UUwjNuby6eg7jCAMV3IOfPvCnfil2cuo AzxjP3Boffzn0aTuEYiKgaAcdXLrBqV04JwYyKJPWfXvKMq2j5IFi+p3eq4vojgSqr4J GKiA== X-Forwarded-Encrypted: i=1; AJvYcCXdysEYjyw8/pKPY3WRbfK5r73WwGjlaIJzgBWXWdSzkUcuPEphANbn2MQ69zLbRVYCxlk=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ0Tdkubc9LHBDXj6pmVMlmWDZxR4e9Al7XVfxNqE/sej7KDj0 TFd4NOwzFdsqWKLvLzpkPhdyMpqGfD8hhVu4c8TbX1EXCQgdXAs2V1pXvDkMzyg= X-Google-Smtp-Source: AGHT+IFRqXUQzeifeEouuocTRosW9D+grcvLtI1xOR31wi5/CcwZDxPvsAI1HZex+byGlUmwqu8pKw== X-Received: by 2002:a05:6a00:2d91:b0:717:86ea:d010 with SMTP id d2e1a72fcca58-719261edaa2mr33169557b3a.21.1726721233871; Wed, 18 Sep 2024 21:47:13 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:13 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 14/34] target/i386/kvm: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:21 -0700 Message-Id: <20240919044641.386068-15-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index ada581c5d6e..c8056ef83d7 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5771,7 +5771,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) @@ -5790,7 +5790,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static bool has_sgx_provisioning; From patchwork Thu Sep 19 04:46:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807341 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934A14206D for ; Thu, 19 Sep 2024 04:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721238; cv=none; b=ruORDNKjgkq8dDY1kPy70j5wOoTTPOnDy/ZnTw/Mbaei76uv0pMnRD50tMyqke8PykviO0ag9dF8ZCdDLLDIWWDu71F128BbnalDL1UvzlU7YiaesB8gakvBHSwxoxpBbxCaNrNPx1ROYKPKOZFPfEIGe7PCxnegYrMS1baqrC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721238; c=relaxed/simple; bh=yvpumS8T8+RP59x5A8bfw9cg1+WDbsrkKy7pql26upQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jDTv+DesVwZjm4GXHs1epzz0/bo2MNo99o70MwdN5QgbBCHZ5EFh68Kclb2UwG2auuhWxwxHrRSp0GJUw9BjD7080wB04DGhP2u6DWi6rli2+eRiXFoYYBAkruYzR4SILyuNXHz6CbqG9q2uHgP3kd4mbe00+FharGkpH5caQIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aPLYOVVH; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aPLYOVVH" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7191fb54147so271831b3a.2 for ; Wed, 18 Sep 2024 21:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721236; x=1727326036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=volzZG+VvX1cjCtnHdp2ianv+4MCm6slEtRN/0TB/Mc=; b=aPLYOVVHpxWT5n7kpfPFjEEg/6/+ocSIvLpoXFmg/Lta3wRc6AiDnTXiMZF4fitoo+ ls6FLeeT9wDGQdGBaTMKhUfpMwSMgZRzoSW4YPP3f5RIyTq3kylfZ8gWTnH6QNH+6FRn RLUR3uATYP524nP8aEPOExB7fgJKA+Ju6JjtKe9lOO3wq9NWiYI2wTaQdtmsMctvGotJ UfiT88hlaTSzdk7c7rbSFUQEGKQQBXx/ST9RgvSJaXksqN1b5q7uZ/NPnp7Ql6VV60N3 D8BucPZ+THQumdEriZiHdpaKKfC3ag8dOuNIYXL0cr1MGEaie0lv9uS1AojEX0fDF7k2 SaeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721236; x=1727326036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=volzZG+VvX1cjCtnHdp2ianv+4MCm6slEtRN/0TB/Mc=; b=T+voDAEpkIZqIjPm7T2+G6LYxxMPcdMXKh/y2pNl5tlZU7DwAXavLxdkLXf6WHkHFs poggF86j6dGCduAOhcgtBTB32gVaTpzsw/3aRCDUenxmnK+oxcEfBCJJArhA4WsN6+jE kFGBtYd3MnpMOxO4anjcoiSJTtaGensEXQ/qmDOSDIpCeQZyOFdIQ9BLhTTiYW49ejea eP0GHS3OzIM5x6mW7f07UJ6HQq/r2sGczGLb6cBZaD/3+nKNYBJgfIehPN2lx2kMkLgv dAEQnOS2XX4EbGp88AqsyMdbWWSGWOuMX3Js09pF0oWVszqmbeGvkfA8loKLWgvUk7ax k+Zg== X-Forwarded-Encrypted: i=1; AJvYcCXgy8dB7HHpa9esOZq3+3MpIeD9Zhq0hwd7cOe4E4XoszxC6wLjGdK6Awxq379nmf+YK9k=@vger.kernel.org X-Gm-Message-State: AOJu0YwGbAiAn1nzfEZvQskUdR7Rs7rfIdlPVygFf2e9IYogp+wPjlKR LFNkl13Bv6UkFxwHvaYcHrTz19fGGMgw2nbFdX5x6UtMTnF587qRj73j7LVR2tQ= X-Google-Smtp-Source: AGHT+IFkwdx7PRwXSy60OR+EcQ83hvrfwCo2zu+BZr4pCRc3QVrXN1huxPQ5BQ1Ng2g+CQtBhwCssQ== X-Received: by 2002:a05:6a00:2352:b0:70d:2e24:af75 with SMTP id d2e1a72fcca58-71926210c2cmr41850428b3a.24.1726721235916; Wed, 18 Sep 2024 21:47:15 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:15 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 15/34] accel/tcg: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:22 -0700 Message-Id: <20240919044641.386068-16-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- accel/tcg/plugin-gen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index ec89a085b43..2ee4c22befd 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -251,7 +251,6 @@ static void inject_mem_cb(struct qemu_plugin_dyn_cb *cb, break; default: g_assert_not_reached(); - break; } } From patchwork Thu Sep 19 04:46:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807342 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 763DA4436A for ; Thu, 19 Sep 2024 04:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721239; cv=none; b=NP/cti/xyI9YFcDhCZn7dGa8EN31qAgGdVGH3c1pJ3h+3X+D/XEkBejlAbxENA+geKbHDc/5mcvHZYr9wrnzHDbuZ3XDVxdiDgHmsFxyyJbqoONtwjQmKPB35PlGhTsR0NgqjQM4Ca/c8rZVSX/sSy8cdz2xz0eiz0ZfAV33NtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721239; c=relaxed/simple; bh=h1BQ1qfXStKpCFJlZi6Zn0TVFFLfvOkQnEdWt54KZLc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AN42ZHpbYJLX61SiNlALX+H78AAcEj2dbKlSpyOerGZ7P9NxrPLFBwiIVb+HUmg5giNC3v0KxCojqmJ7H12FTtKit1ZJn0gQFQF+GBUSA7SgRg3VygEb48o15zsv+W8iN5HZ69u1p+QpVY41ALi4AOAeUzSm3dB2O2XkhF83E+k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LOclbxg2; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LOclbxg2" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2054e22ce3fso4771635ad.2 for ; Wed, 18 Sep 2024 21:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721238; x=1727326038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3PbYSPAJ6rnlNnfP+6+lqxv7ue/rw4dEH/6Q+9usd0U=; b=LOclbxg2fe37awpHnXv9xjUBuCmdshO5MOLhHSe52UL80TjDxGfOuEGpISTiQ7gvpi d8OWSET9V51Ja4iTxzQWRBBHF1lWRxN/Sldql/tNxVj6bOIGVPrgoAmVJqeQ0UhQt6v3 xtcWb6WQpYxuqkOUZLFip2bvOUcchyyQsu+RJ+1QS/Kh+YVyirdNdGAD4Zz6HEVorxg/ XBoWPBVt/B/hGqBsV5QzfIuZcDzcyoWWu2kmqpEfGfw+6vSZE0rVReDcRPp/Ab8K811/ lZ9AIiVn93x4xm77t0brjOP+dTM4UILWtr/EfMEdU1A7vUsM7FN9DEg1Y93Q4HdPd+A5 2UtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721238; x=1727326038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3PbYSPAJ6rnlNnfP+6+lqxv7ue/rw4dEH/6Q+9usd0U=; b=GT2XnYeW8i3hecLBs106rvwsPXeIgEDaVbSBDstb2eOwCXeXYKuQRRHwFMBZRXKNQ7 NuPCbGXxrdrgf1R8z3kKxlfywIpQVgTAy0e3SY94JXDDoyyPnDR67uncR6zh0vcqYTop gbWQbj9cr48iBmvZ3BlQHM1cp72u89CwfVSxyI3+BCLhZu+7ISBuBHlGMkJRwQpYdHpK kdVYd955cuGKokkhWLXuLws/iXr3YBcxKSFInyQqhqHPH56tApDPVsS3RdgL298c9twx 3U/bdrELYHgq2qeWiwr2s255fw02xRDky7/CkPf0w9pH2XWpZaHnT+sd2bVFAfO/y0zF rZ5g== X-Forwarded-Encrypted: i=1; AJvYcCXtr2Z1XCgLF0VjBrOqApNA2IMK579aYzLUQ3xEeUIfq9fblNqnvKxqEWWzgyudW0gz27o=@vger.kernel.org X-Gm-Message-State: AOJu0YwLKOYAFUvjW7UlDZs1gYjzntmlsEZj8deSAsLpxxabiWLBcVbM Y2hFP/TQ6wyvuhLMJRmx4GOk4YwCU/xxbvg5UMh+/TZPa0kjSSp7soj0tnc0zNY= X-Google-Smtp-Source: AGHT+IF3mDmH9rpxImg7I9ZiTJydkdGhhv3x9u+IP9aPf7aanW6JNd2XCY8CeZpnshOcXFIkUiIf+g== X-Received: by 2002:a05:6a20:43a0:b0:1d2:e8f6:7e6 with SMTP id adf61e73a8af0-1d2e8f60a4bmr8759330637.13.1726721237824; Wed, 18 Sep 2024 21:47:17 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:17 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 16/34] block: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:23 -0700 Message-Id: <20240919044641.386068-17-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/ssh.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/ssh.c b/block/ssh.c index 27d582e0e3d..871e1d47534 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -474,7 +474,6 @@ static int check_host_key(BDRVSSHState *s, SshHostKeyCheck *hkc, Error **errp) errp); } g_assert_not_reached(); - break; case SSH_HOST_KEY_CHECK_MODE_KNOWN_HOSTS: return check_host_key_knownhosts(s, errp); default: From patchwork Thu Sep 19 04:46:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807343 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB81200B5 for ; Thu, 19 Sep 2024 04:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721241; cv=none; b=KDmI8Qwr0tVL9Bpv+p5y2yJpGBukrzFbW7zo8lBcjjO5IYtljl1QXST6bBqxmlG6e5pGmudXvI4eqxcYB/i5WQ7jOqheTfPaM1IgZjMI6SxczIrijH2Mz0ImIHOsvrB00B0josfLNKMfdZbLmUGg6FicwU7MzmqDlRins+mBWC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721241; c=relaxed/simple; bh=/ZFBn3QeKRgM0EwmDs7R1QyKAH3aMW8o/bGJD6Yr388=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ePrVOchNv+hW7lfw9xfAu+GD72vPoYiarI1kgVq95msJZ2ENVj4rMgmr0eM1cVMzfWx9ufhCCzwGnOcEFrUXUT6EPwuT+Vxm3ZK9QhDUYxZYDyvtebtAho7VUbf6jJkb6lK7OTxy6KfIAggDDNowgdQ1k7xQ4YrTXxUop5XxuK4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cyoSpCsc; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cyoSpCsc" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71971d20ad9so305580b3a.3 for ; Wed, 18 Sep 2024 21:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721240; x=1727326040; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P31I3C44WXD62nQdqJ/4LHYU5tGPmQzloTc3BsmhhAw=; b=cyoSpCscPJ7LuS6x0y4xH4LJiXvJmyuJ+EdpOeisqA+cqDgam3Lwwl8QeymyQ05gwj S/IYSEQDGzNl4k5HzdcFDcVtxRSy+kFBcHvUBRamxwkHUN6EIumkWLFU+U3pmnmAMpEq bW5vXeGNqUIQpC7c27nTKHMvOkRzfnGZiv1GxapMaj3a1Ut+k2YHgoZXU4I3zcJK6YiP oO/00qwrdblnqroTj2nfQeuiGTdPFwFN8SBfBFaZkj4ypMhBA3OESvcVJmk/ImHoDg5f lbbC+lNhQvvGnTgTd2Vp9XdXnGRd6/6KWIKfhPhNOm99lq2CMuFhACxndtf6sGjBC5h5 bIBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721240; x=1727326040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P31I3C44WXD62nQdqJ/4LHYU5tGPmQzloTc3BsmhhAw=; b=K/7NdcHXI5siRna5+X6x/W1geTatcrULQbKoTOHeJf4P80lPBFB4qpUfw/ekCZ43gi lrr4Npl42sPeMwyZOgzGsFL9ENHYdc16hH8nTgi/jrDO9ul4d3dMxV2zcjRs/mbgT1JG 43CJiJZv0IY57DYvclqo3rlLu3QfT8wHKweMvKzwwMZsJH+Nqy7968N8PDpVWf4sZZjB tvfgqURgJ3voEehNxYo0Ai5EuhEPWVtmR2phrnmTAg9f++u00sQt9IvTj1iNCmMiAFVN 4QpM5I7LVU9dqFW2NJuRDnHqu5Gl/v6sU65kFRBJ3Si//2QBXena3Zl9gPMk9bxh/Mn5 SLFA== X-Forwarded-Encrypted: i=1; AJvYcCW8S5dvDhScFZj/uhgGdImg3kntfelyfcmigqHuflmqObaixhhJNytKmDzmkQGA87tm+gU=@vger.kernel.org X-Gm-Message-State: AOJu0YyFEpeBnQ/t3XlKSzKHBYxxaSnI5teETlJcxco3bhK0pEVJj4KW 9PoywalT7aPFC7qFFgsTleAVx3jXxw/SWAExEWBBKTuezMaBU9R6Uj8YBQ1lVsQ= X-Google-Smtp-Source: AGHT+IE2vIINUcW+zK0eGbTcjS/rKf9+2RXdS9WcQeduP1VsjHVzuUVVefnTsjBWDqx5B00zhv9fSQ== X-Received: by 2002:a05:6a20:304a:b0:1d1:1795:4b43 with SMTP id adf61e73a8af0-1d117954cb8mr21768562637.26.1726721239845; Wed, 18 Sep 2024 21:47:19 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:19 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 17/34] hw/acpi: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:24 -0700 Message-Id: <20240919044641.386068-18-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 006c506a375..34e0ddbde87 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -535,7 +535,6 @@ void aml_append(Aml *parent_ctx, Aml *child) break; default: g_assert_not_reached(); - break; } build_append_array(parent_ctx->buf, buf); build_free_array(buf); From patchwork Thu Sep 19 04:46:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807344 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D87354D8A1 for ; Thu, 19 Sep 2024 04:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721244; cv=none; b=EmYUToyyHZhzoxNUSphGNA3yp4ydGeSjFPpRM1kjAoV9/D77hny3VnJwKFPBbGPsHw+eSAyqnwjfS/fNvOn9OjuNa7FhtvVtd+X4cExdVrcwmh19+C/dQYs/rSHllDgW/Qz6SocxSaFs3DHYqDs/qKGjvkM0gZEO1tLI32cvZ0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721244; c=relaxed/simple; bh=Avahiy2LXP0vtKirKz8lxo6CVy91LQWXSnvIbQLzopc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=omanr6SLOTO33NgnEZaozr3xEToIciMB/s0//WXAnkvVdwybeH/quWy+G3bBPOaSmLTrhSTHE4CNerTQfdnMWZJZiAtWkAWXfoiaOMV5uAkT+YRI6DnkkFm2sesp+T1wH42KUHYzNch3ji8aZcyLJnUTtyMof/J5F0T+6P45+7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fsKrkDFE; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fsKrkDFE" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7179069d029so297642b3a.2 for ; Wed, 18 Sep 2024 21:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721242; x=1727326042; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XTfod+luVyICpEfgZ8Uh3DA36M6kM7v+mrR6MBDF7uk=; b=fsKrkDFEUP+bTlgFIAdt8eOUr0LvHg6YbuHfQh+TR1b1olb3DrocrWW9Ba/aEXNDzc aVExWQvrXZ8Wb6IzeRBI/2JUbMVH4F7nn3z9ZKLVbb+LiJwX60xY5pxw74tIbybVMGlX 2DGEH6KaBGmUzEjbJ+A2TDCPFYr6sc3Vr0rncXXmkbwwn3HQ3JWxEAD6vYo5KbhfLuzB sAK0nbenAriLF9mtI2+4BiNg/x/UcC2Am9fCg29Qa5SL4fP4TUz+NnZo3O9ywapkOpA2 gVVexHFmNjCdF9aC//dlNUhBSXTmQow4RrZupE+JkjTbQIGsRrJoubNjkWGZSfL8SKg0 WIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721242; x=1727326042; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XTfod+luVyICpEfgZ8Uh3DA36M6kM7v+mrR6MBDF7uk=; b=BXATiPQ71+NAhrhzb1uf1OqEAe4FXqD2OVmxbNjPVBErH98Wb3Vu9RBrVGRbKvsmw6 FXWrYHyeQmTfU1RN1dqSH2kmEpy0oKTTwPuRNMN0SvjpCnroveHi3KSdUN1zA6C93P97 7EXfHxuam2ET5ufrILmkUa204h856riBXZDUBb3aPqdWfrXm10M02JvCkvhGQnaawm52 VNOB4LIdg4rOVhY603O7rwSnHdlRzr/CxLX/Q5lN+NOJ7kLsOokf+95uQemr6FTAjku1 cjwxduAuu4VnyC35wNaKDV+vwep68sn8Yt3CsGVxpB+vQ44btksYVKiYGC6yAgYusC/M igRA== X-Forwarded-Encrypted: i=1; AJvYcCXNOklVHeO+XCO/UaLHHI6QRafzgzpqeAwME5d2t94hT05HD976MU3Uatz8f6yQKSfHKwE=@vger.kernel.org X-Gm-Message-State: AOJu0YxD88rfu8ZnUTvY+x3U6T5lAZS2HsMFwzQH/lWWYAL6+yePv9WZ Gfek6FqK4xt5MKFyGjaebfjdNeoTOZr7wXASjzukA2mED3ieao8mudx/XCPrW70= X-Google-Smtp-Source: AGHT+IENpGOMxkAxVpBEbVxwqYg+XoCNj0Y+tup5K+eTLr6T9UQRMpy2wwxVgVE7FTWLiR+Ma6cVKg== X-Received: by 2002:a05:6a00:2d10:b0:717:9462:8bda with SMTP id d2e1a72fcca58-71936a5fb10mr30684467b3a.12.1726721242032; Wed, 18 Sep 2024 21:47:22 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:21 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 18/34] hw/net: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:25 -0700 Message-Id: <20240919044641.386068-19-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/net_rx_pkt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 6b9c4c9559d..0ea87344745 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -376,7 +376,6 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, break; default: g_assert_not_reached(); - break; } net_toeplitz_key_init(&key_data, key); From patchwork Thu Sep 19 04:46:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807345 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A74B2208B8 for ; Thu, 19 Sep 2024 04:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721246; cv=none; b=mgmDZwFqaOxnyVZ8bqxa7JGLHyn/jVDMPOuY41Bpu67uxMdqzV0/lqOp+jlpEOwNCEcjfxEQDoRvnbI8V2hJue1DimMraxy7OUQpn3xd2I0bG0HfJ991ENBXu/Fs25kfDGlzejWRnrKPqH5DXbXWPWa9FJktCo0gFDjUXzFwDkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721246; c=relaxed/simple; bh=/YgPPDVBxt/OAJU/NmCCEhS4tA4WAYYnO4Wjhf5MEdA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YGs4QVRc6kyaxQYRUfkcpNJzTxc7ndPSaI/2EUyiAQDbsCVFt2huTxvEY5q4RMNy10WmGFt6zYuos5Agbgbn3MwzEkcljlZp/vun4GZMBSzkJTgpKQwunu1PEwANSu/SogcfNIo97Ud55OYdhfzhWZ2iT5qNuxydP/K2+RLWNlU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z2ec0F4T; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z2ec0F4T" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7197970e2aeso262675b3a.2 for ; Wed, 18 Sep 2024 21:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721244; x=1727326044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XHltE5X3jHFpn43VYV0IEXfKWmPwceAvVFkYvY3AXAY=; b=Z2ec0F4To+xh1hR5JCYFZ9HWfgThXF/JHqSA3c6knNaJJsohcpWzQ0eyafkvimFWjb Pq5aQ/ablX2Cn9T2QID5ZvGmsEm4nnlX6erJf5/J4MUHmjdkSj2ADLWiwhaplmPWNh0A TJ027PUwiiGYovgyZ3QoTHxqa+MDxdYr8L8dycfnPPko/8dU2Lu+oODTFTk/qDrxZMRG ygKJ6lxtMW69onUbHvwsP5lN5XsMQi5NnHPmQFqcDCKoScGGio4BxtxeRz430Oohl2S8 BcaeWBlEs+PAVr0AkbEquCNO2VaydBphjSbtJJ8SMPGMkBdhB8ikV/F4RI9tNn7PVHcf /sAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721244; x=1727326044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XHltE5X3jHFpn43VYV0IEXfKWmPwceAvVFkYvY3AXAY=; b=oYYDQ3gKYdh1wYleNf9i1qvRfezHkhby3mSJ+JCjSpLr7RNtyp5L998Jn3YVw6eOIi LkiWciJwp+r1CxyOeP26tLdtAaEb4T5BqckZwSfDhRmn87v/hX8IluxbV+T8tWvN6m2+ 7ru1tY2e9fDBZv/8N9vuoVeSLzBDZhsRI+ZNWZvlCMY79oHWFEit77+/MjjMNU2g1Z9M rkspeOvZTjW33of0QUza3+xfriDIjKzlg/azI0f+KeoV6i/glVk/HI4s0usXnFiA/D99 kmaKKrlQ1Egk5h2yQfaBWeLxddyfMi/D61BDU1SggPN6tV8GF49RqlxGui/l0rlfPXdg kxYA== X-Forwarded-Encrypted: i=1; AJvYcCVbzoXkHIr61BrfXQDYUl84UX8wx2aNB+3VkjGf8Ba8GEJQ0zJHZHdIaEK4FlJRfCxe5t4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMp1s+new3MXDALKQIszogVFKTB8lLqN7ROD9VTfN0x211ruwV inLpfzA/afnG9r4mzjmdCbE6INskESmxe4kgB/r14dgSoU8Ohgu1Fg6Cp3Qo1BU= X-Google-Smtp-Source: AGHT+IEr6T2O+sP6OWidgpOc/m8gapGLSSLw0H5w0hv1V3XRgPMEmphvXT69kJGdrAWtPBAoW9bd/w== X-Received: by 2002:a05:6a20:1918:b0:1cf:37bd:b548 with SMTP id adf61e73a8af0-1d112e8bf2cmr21148987637.37.1726721244023; Wed, 18 Sep 2024 21:47:24 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:23 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 19/34] hw/scsi: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:26 -0700 Message-Id: <20240919044641.386068-20-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- hw/scsi/virtio-scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 9f02ceea099..6637cfeaf51 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -357,7 +357,6 @@ static void virtio_scsi_do_one_tmf_bh(VirtIOSCSIReq *req) default: g_assert_not_reached(); - break; } out: From patchwork Thu Sep 19 04:46:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807346 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A067552F6F for ; Thu, 19 Sep 2024 04:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721248; cv=none; b=hgtt7abu35fnzQeL5r6ismHuwHvCwTYkABRMQoLPTjE3i9RFRphvo+xPie2YFw1RIJbqWxDJy46/tZGOi52dO4Jo6x/UrhR/ESZ/vHFZlt94UG8AmZ1kXF0dpEpb8v56FpqsBnfAR85etPhmjHc3r/w7sy8Bmc2/N8TXfxSd9ag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721248; c=relaxed/simple; bh=GmFJeUgV5bFGkizDdfVVWI5ddUSFN3ijhX6KnkR3hS4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZB2qKyIUXriFyRJQOF66EgJ2rfsicT5fJl9zPv7bdmZz3zM1rW6krB0vY/MoCZ8xXbiNJjbPY0GnIg23XN56wXs5W26MGGPrI+sWOXGYDxgNpD3ER8oaVi2bZ9uL+AlX7qH03kt5/OErSGRlnc5B4fs07FFShVNRu4DRTDYvQrc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CFtzh0sD; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CFtzh0sD" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7db12af2f31so333534a12.1 for ; Wed, 18 Sep 2024 21:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721246; x=1727326046; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kRUr7Rigd7KXsxIxUKl75LNzfJl8HLKhUx0dIIEBKEI=; b=CFtzh0sDXYNXzqPtKEKM3lKbDjkKiMYrTpe6yUDeTBGjKxrDLg3fXS3ylMAd64R4UB Xc1q3sK5H0U/TDlRzxejS/meKvHzmtNRMO865/cDWqQTxeYSxoXhhoxsbeX1Jmy0UwGs x0N7Cn74nqfs+JH9SvkpTAIaGEPWznPFdp1mj3pQnUAaUKqCQ5ONIeeoJskpY3L7W2Z1 wWBwslGYcpySU5NRqYmuTw2gmLfoR1tl+RwsP3Rn8hokc3lY3E072iwQNgF4B2iqdBlu OC2QABKLVJLWHTElH0CfrWVIJN8mwOC0P4hiw1K4AelqGExmqVOa+Hh0QiBbZKRhIBgz pEUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721246; x=1727326046; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kRUr7Rigd7KXsxIxUKl75LNzfJl8HLKhUx0dIIEBKEI=; b=v7z+XWQ9yyJ8MXRMjyaLRWpppILaDs2vN1TSsDY7yTEbekIi+DSjJNj2wmYkgfFdWF iclkNEtkIM9ZKes3WCUYBN7h2YAOndPDtl5jisx1H58vL0NfT0diJe2Vtjniig6G7fkV b23vxpfqf+MlFxPUj2gI+EgdwRgPS4/6ohg0GnKl6fx7jm1k6skvUAq2h5k0EnX0O7r6 Vif//ZnNj9yaqmLrgKvtfiFH4Tla4KEIVLj+oKZCGhmwY35Z9coESmP1luYFBlRDmUzo PY/TG+/NeYk0Ycs5n2lOUoRLTXRtEsvqeKMBOOas13RIb8rq44iE6wcehyls268cI8SZ SBiw== X-Forwarded-Encrypted: i=1; AJvYcCXOkrrXnYBbCH+b4WbRalnLyM+KYsVeNHqV4RFQhLGreOAalwPUvGnfILwmApmVZJm8Z6o=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd9k9RBpJvgSUvRS8mHRoXEVe3/BGTGpmCgCWrbO2N7jDSv/e7 aAyVnHn9ux54LatDdWcAcSDnYhqBwJkGLoQqthkp3bicv3WW+Kxks0Y0L4uxyTY7GaMsrQGoyfD VExKvjA== X-Google-Smtp-Source: AGHT+IH/FIQf5IQhPyXOoAeAod0TK8mpE9ZpDATxxMEhePCSvOyFGL8wr8yUWnyqTIM9Ik9UbYX11A== X-Received: by 2002:a05:6a21:2d8a:b0:1cf:1217:ce87 with SMTP id adf61e73a8af0-1cf75ea2251mr39237052637.2.1726721245964; Wed, 18 Sep 2024 21:47:25 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:25 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 20/34] hw/tpm: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:27 -0700 Message-Id: <20240919044641.386068-21-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/tpm/tpm_spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c index e084e987e6e..5f7a0dfc617 100644 --- a/hw/tpm/tpm_spapr.c +++ b/hw/tpm/tpm_spapr.c @@ -206,7 +206,6 @@ static int tpm_spapr_do_crq(struct SpaprVioDevice *dev, uint8_t *crq_data) break; default: g_assert_not_reached(); - break; } trace_tpm_spapr_do_crq_get_version(be32_to_cpu(local_crq.data)); spapr_tpm_send_crq(dev, &local_crq); From patchwork Thu Sep 19 04:46:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807347 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8356055885 for ; Thu, 19 Sep 2024 04:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721249; cv=none; b=US7t6piiL3rM8usNjWioq49p1u9Yv420bAZBrDSRe5lUtuS4ibc8Q96hg+WjapCzEhIPvSKKCT2fVfycEvnR1uhfSn0Y6g/hNgzRQI6hl21SsCDSYG/vz1bMP+jRs2ZD2tkMl99nea0aXLWo9NXuNEuTxtW2L5OuqU8rWO/InUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721249; c=relaxed/simple; bh=UxMxgMmU6rXl5QkO71lpCL3jaK/IWI74zWJB0msEGQ4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mHYHOObyPYHp4KxBUoBONvGQ1F6UNVI46gspNiqFPSN34miyL4GW6BfY5mvqZAbeM6qL/qAIFSWE0rc03aW3u2dMqr8HxSzIkmijbmtFeDKvGKjwqK5ZPg9oAdjusVHDqdYpAgZ9z8hZG2HBoTeuD+Bgc85iqHamhDXbJB/UL6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cL8NI6AZ; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cL8NI6AZ" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-718e3c98b5aso280390b3a.0 for ; Wed, 18 Sep 2024 21:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721248; x=1727326048; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fOTDlymCoYoChOB3X8FuVGmcdRWIYVQOru1+/fCCr8A=; b=cL8NI6AZ2BDA0PPt1yrrjcYCSGmSg9K2EshlsDMMduo8HNGh3IHrvGSFn5ULRXXnOT kyk97dfKR7y9hYSRYYuNoVnqxJW6R3U1vqwQ2Lr7lLNkB8rN/hOeB//cmAmjqi8kiHXd vqv00HHxGAZBHKZwrZ0jGjODYTeLTJYqfN5rW0prEJlTQE9C9trvnuSPIC94PyEa6zMc fH2+eExSNOW6mt+vo03DU47T5DOJPX6Va2Gz4YlZyyvyzUV72Pg0kaTBHSZs6umy4AeO q6PL5Yzfkl1KSh2Sfz+PeEsndgTWim/NfWRUfpI3/IE6+f1ZAerw4k7ya+0vd8aLVAsp vq+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721248; x=1727326048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fOTDlymCoYoChOB3X8FuVGmcdRWIYVQOru1+/fCCr8A=; b=X4VFfRaMmiM6on7Zo7sMi6txJar5I7j/wrFXszVgs1WgzZTSC93y51+JH03yi6Gh8M 3ln9/gLoMHmiMaTdDlLUb+Qx8WmHXPrwXXLCeN9Qd6nonTux9Irca8cVO93lOGXk/+7w 0Apv67cuyOnwAVgXAjqwCfz6ZPIk7QYpe5dyM/Sd8o78sufkyQM8STppq8YFYUZ5okN9 dw+mr7//9dVlg7/y2L+i/25vhaZoWfaBZmBXtn269ocIKvoRJP4JoffqMHVckOs9wbPt a88GdH5RyPZYwJvw/vbKJem2RuXycPWiaKLGOjLqrbHjUmg1WHAUT4IaR5HGvm3NwaiD tOSw== X-Forwarded-Encrypted: i=1; AJvYcCUJlZzSka700KYyF8u9HfD3Gwb7nE6BgvkgbSs61R1jug8Su+40y7d8dSMA3jB1rhkW+wE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4bO48U3CUwPZcopRN4yQeEb4RUeO3J8VSp91XLXxsjGkvGWDL 78l8YdJJbnd/iNH1I2wnEe0c/YbJKr1Nb3UiKgGPBMXRownlHtShhd+FnJu457w= X-Google-Smtp-Source: AGHT+IF4VdR408ElGh9vDAVjdbcMP3qqXEsAp/0wcOEvsQ0+y71/UwITZuPKa7pIAYx77zAYCo1WvA== X-Received: by 2002:a05:6a21:2d86:b0:1cf:5437:e768 with SMTP id adf61e73a8af0-1cf75d7fe57mr34834771637.7.1726721247872; Wed, 18 Sep 2024 21:47:27 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:27 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 21/34] target/arm: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:28 -0700 Message-Id: <20240919044641.386068-22-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/hyp_gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index f120d55caab..1e861263b3d 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -158,7 +158,6 @@ int insert_hw_watchpoint(target_ulong addr, target_ulong len, int type) break; default: g_assert_not_reached(); - break; } if (len <= 8) { /* we align the address and set the bits in BAS */ From patchwork Thu Sep 19 04:46:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807348 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9A32219EB for ; Thu, 19 Sep 2024 04:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721253; cv=none; b=SHyHQK9lc19UfWW8326FNVs5f6sA/OyvIWA9Z0GPmoYGTXq+H0Isztd9W+FpqVm7SX8+nxcrbejUtV8Su++upLX7IgBAWyDx9DAFJFb+n8S7kruiE4EBvd1t1/V4bYPkfvycyArsX3zu+vaB7Tg5nh3yZp04pFovzQGzhlpaeog= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721253; c=relaxed/simple; bh=kZzqIDT1mymDXK40PTnYGQq6EWN8LMqSeQL8CVADzkE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CdhVQy0uvKZUn1gMfjcSnXsnhSGiVoCwhj9Ab0n5w8O8wKVzGq9h1bj4zkAHx3E4ilKFSgnoAIosJTDW6tZ+6F75yk8ultxKU+asRMkHpgba51knnnHsNzgzSvhCg4zkI4xmIuEzwa0I1Hl7Yr9V8xa4SbhRCYzHR3Kdg/NxPZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kPd+64qC; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kPd+64qC" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7d916b6a73aso213693a12.1 for ; Wed, 18 Sep 2024 21:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721250; x=1727326050; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l5Ewnrr/qjz52ggXP5z2OAFJ85TodMlAQJmzdk5fJ2U=; b=kPd+64qCIYwg78mpCXQhEdAadOBwATnS7k11ZNbXOEFlNEE7wy3TkQId+ffjL1bKfl GHSJ6L/YCSOAMtrzswavJOTFvedBSDOXCRdTpYe1hClqo03m5xZWtY87rlKG0QsMKgjB ZslThJWfzfWtQ54H4qTWTQdWvUKcJ+tOdhbYjyRRrzBS73wpGsXThidQ5CZJQw3LXZYF /hf9Fp47UHhge/0eViIwzpjwR5u7k+wkLxPpGi2rgq+7PHyvlWMRm8ul2JBuwyFnGKUP OToTjLCXlZbPwymTwdZixrHCWwelvGS4G/iUWiiTz39x1RGrl7bCMJy+HKuB6R1W1J1W oTtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721250; x=1727326050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l5Ewnrr/qjz52ggXP5z2OAFJ85TodMlAQJmzdk5fJ2U=; b=h8ZrjiXy1uRLySxRRmJFCWwmq1j14+4ShJLlLXwl3isLdmwO3CHKgfIP430990bly1 pJ92+MwUDW6a1XOEw0rKZ6wtG1qD1MmS27JmiXkrzmEe5TUp2n07X3+tRfatD06rzfcK Tq73G20anr35z4x8wOebFDT3XbSN10tVSt6Le4uF6sYwNubWFxEMKzrb8w0+5vsLowK6 7J8eiS+d/gmLMY8oLyYp6szjHmoPnV4f17r/at0WIrlGYB4cO6JJ5wU3r8pnvZ5q/4Xi lbr7oJdoGyIG6FBHpdHDIhr7P6689ItjoF2yZ0kZwL73NuPjnoaoa2UiYzH/SdXHtLDy NHYQ== X-Forwarded-Encrypted: i=1; AJvYcCUe8g3B/lOyz02S+21oIW+6iue0skbidhaSW/SkI+Ry+zpPbU9JlgvHvalM5LqhhNNGzh4=@vger.kernel.org X-Gm-Message-State: AOJu0YyhVJK+Qu/sqTM050tzjIfqTsdANkiLuwGfu/UjrhG22acs/oR8 AjsIfBFGmyaCuY7CsPnIm8xyyC/BYAqpN5AiLbG9ersf+ohj0AFNrKkcZpo9MDA= X-Google-Smtp-Source: AGHT+IHOtMj/Kr5ExQ1Dywx7ERrNLhz2hVxVxQFKG+INI6zzOgF8wrQsA7qvcA3V9hiv+CFRCBs7cw== X-Received: by 2002:a05:6a20:b58b:b0:1cf:3838:1ed9 with SMTP id adf61e73a8af0-1cf76239c73mr33120242637.50.1726721249781; Wed, 18 Sep 2024 21:47:29 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:29 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 22/34] target/riscv: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:29 -0700 Message-Id: <20240919044641.386068-23-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/riscv/monitor.c | 1 - target/riscv/insn_trans/trans_rvv.c.inc | 2 -- 2 files changed, 3 deletions(-) diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c index f5b1ffe6c3e..100005ea4e9 100644 --- a/target/riscv/monitor.c +++ b/target/riscv/monitor.c @@ -184,7 +184,6 @@ static void mem_info_svxx(Monitor *mon, CPUArchState *env) break; default: g_assert_not_reached(); - break; } /* calculate virtual address bits */ diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_trans/trans_rvv.c.inc index 3a3896ba06c..f8928c44a8b 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -3172,7 +3172,6 @@ static void load_element(TCGv_i64 dest, TCGv_ptr base, break; default: g_assert_not_reached(); - break; } } @@ -3257,7 +3256,6 @@ static void store_element(TCGv_i64 val, TCGv_ptr base, break; default: g_assert_not_reached(); - break; } } From patchwork Thu Sep 19 04:46:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807349 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD28F1BC40 for ; Thu, 19 Sep 2024 04:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721254; cv=none; b=F0jB0XRSw9RW0sSjrp7Z7oNfFiJ8Dzb0zv4eeaZsCC5u8UKnqpVx8CXFPj2e0gV/6Azfj5wdgN9HfvyX5EbqkIC5TBBJon416ZT+VU9qk14LWs8HaE1eSjxxSOT9Mj7rmmsHaV3SEDVGkolHY+m3aBqQbmfSCeMid8Uw4XnE2u8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721254; c=relaxed/simple; bh=iEfdVoaYIysQOl8X5WTQZj/hRoLe/J+kj8qq0ntwh4k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uYknBEVG8esyaSSNlBu/pnDfA8p3vnnyg8Gt2HmRpmeEwQo/O6JGcz80r1EooyQ6c4PRnQkZYIgdnORBKKpz3y5smVwdW0rDQMWFxx7Kmi9xJGsNAAc1u+gy7upjgfnvOvrxlE4YOSVXZC08J9N/arykkXsEmaW/eAwDwHYa5F0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bG5t9pj5; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bG5t9pj5" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-718816be6cbso311817b3a.1 for ; Wed, 18 Sep 2024 21:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721252; x=1727326052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=htcD0BwVI8E53kI5D4tk23OSCVl4GJymUerem5Vd+Nc=; b=bG5t9pj5M0TDhOAqFoq7Gn48/nXwmKjshjC3mN6GLG16WbWMjMLg++TDyF3junXcWm xTMRwkMoY0GvOo8rl34VeCeVZXkAMIQBWG0ZLYg4ERgxgIOE/S5LzOkFNx1FUO7zR2AQ +EHCp0hmrXzBayfq1jOduO3r+jH33PXv0sYnhjrEnmm6zQlSyWZMe5iVYVhXx6InQ5TD gf2o6CgeU9UudkCdlwTaEfy9Y8d6TQEVo7jCxdZW79M1fExIQYCJgJWTn6l/pHHBjWUO P9+LpXX1/IBKphUpXZXwsgtgiVBw5hd24Q1i9IYSeaw2tmMFxuVFrsaeVpyxdL5R+Ly9 Wt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721252; x=1727326052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=htcD0BwVI8E53kI5D4tk23OSCVl4GJymUerem5Vd+Nc=; b=mLfo2pVgsCOsMryj92FA06K4YCaU7vZ+vKkuNeTyquuR+xX5bC922AUjuJpOWb7uU0 P1Uje4B3266HaxRa8fJlc9pH8VaCvMg7AmrtPTsHWScEDMwvpUR0tA5D8XP6IN6l+lMv H3V40OOnoHxz4th2To4NiUcTeaC8KC1E3Vq3zDmDokc13bt4j7UeZB9+bPu4G+lItnsV lXbilh9nxcc0r48WD+pTcGJtaYsUIwCLL+EffdvpKZEo7mfwLGPimy5Heu/TgsvDOBGN Cq77hqFNjQlik8++RMqmqn5A6H70kX1ayFaBUqvJ4TvuUoWCIsHHIq7S6ln+U7G4CLA1 Ct0w== X-Forwarded-Encrypted: i=1; AJvYcCV3yJP9orZfCgBDRjpLBYCT1WaNbPk9cd0suMSvRAPgrkdWznsqhTM6423pZ3qiG8yiXXw=@vger.kernel.org X-Gm-Message-State: AOJu0YzKqf95CbSxlCOA/e+mGMWkekEzknHuUfW+1sFKCd60jNaxCKAp TpZH7W9yi70fhjSG8w0yZRIokKZqrEQi17QC/GzHclRGcC2GGZxW5SbATJpMFCeUbgGIIGil5ue oG9rfZA== X-Google-Smtp-Source: AGHT+IG3VDWYQsL5o+dqVWGrfQofsayNLblIyTF0AVQE/kr+M4nxrlPbIJFiaP/P/b9fsRX/Gu2PzA== X-Received: by 2002:a05:6a00:124f:b0:714:1e28:da95 with SMTP id d2e1a72fcca58-7192608198cmr37650198b3a.7.1726721251825; Wed, 18 Sep 2024 21:47:31 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:31 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 23/34] fpu: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:30 -0700 Message-Id: <20240919044641.386068-24-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- fpu/softfloat-parts.c.inc | 2 -- 1 file changed, 2 deletions(-) diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc index a44649f4f4a..cc6e06b9761 100644 --- a/fpu/softfloat-parts.c.inc +++ b/fpu/softfloat-parts.c.inc @@ -1373,7 +1373,6 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b, break; default: g_assert_not_reached(); - break; } switch (b->cls) { case float_class_normal: @@ -1386,7 +1385,6 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b, break; default: g_assert_not_reached(); - break; } } From patchwork Thu Sep 19 04:46:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807350 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC8266BFA5 for ; Thu, 19 Sep 2024 04:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721256; cv=none; b=q6VQzLUU3rGFVaDT1clITmll9dJcOQSc7P79CPkIQxGlp0A49On23lZQraPetFu9E+zdN7aAeXJIi2jc7cJS54i316ZipPFpQq+1a/qznZG4APZ+7mB+4+wcUkI4C2v4zD4Df58BI4bu7SnsIj0BHUf1F74OXBN3WdGeSnZEmIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721256; c=relaxed/simple; bh=cRpllvxBxjvz6fI8fQEUykm3BKHY1dND/57a/4JFwH0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OTtcrZHzwjvkHMUL41zlTAcjY/hMKPbnfbWkW8bsxjSb88iDAHJWD11tg7n7M4F9Q2TR4vDUrVXmGI3YNTiTobRLzUv5V8CbjRJH9ZIUkILQhzjghbelontpbqfLiPkRFqklKuOWCyu04CoU7ytqG16UNB0VVasAoTcrqtvPQZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L8UdPtG8; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L8UdPtG8" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7198de684a7so265263b3a.2 for ; Wed, 18 Sep 2024 21:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721254; x=1727326054; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aSSHMg0OaePxq3iPPMHVPRVV3RpF6c4DjTvgexruOiU=; b=L8UdPtG8W4QuVhwO9jF/h7ipUHUbFZJeN+srP0c9cdG7jDS0/bvZ0jdiBjZd2u6Gld RRQmwh2Wv3sy+S2wVDS5KYSW9VWpAzSmQ7lISTdi3YedFMW4i32GOa0b4gGxLcwEMMkv iYOP4xL4RnvUAhSPWlWbqpS7gathZDDSfOn8hQLsCBvNKmG9IHmK61E6aNhX76NKsDIB oOcV3vOKqsXfhuR1heWBMyerICaqrx3wej2PZrqjhndXXLOZe4noaibWDwqNlvBepCF3 nUIP1TwmJC3GjF4QRlkZIfFkRH58AEIx246gD+gpa2z9DIBdYMkvYPy/3e55q5aZY153 I9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721254; x=1727326054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aSSHMg0OaePxq3iPPMHVPRVV3RpF6c4DjTvgexruOiU=; b=Oarg7loMgTGxWa+uv7I3uq58I4+pK3haermz2UJK0rVDDS9SPKaugenwTMGOUkW1fX GcyYaW2gAprgRUHxetAqeyY9ACkO0OcgWow1oiLYuhuwD/dk6owdbjkHCeQArasiQG87 Or5yEWdx9erToiKAR4jC2jffxVCazWYlEIdIPAhz8QPKGJuj6X/jTLId2mKvL6wmJd9K k4F0niweGTuOl6qEn+Y2EQensySH+1MefEu8eCaCH0AG/2Nd5dy0BG43semmu3l0UJQ8 J2UW86DsnIm9XAPk7wE7FFxrDbryP7SsrrLYOblB4tjHAy4uAKPNnTBfjW+TJpknUes6 lDpA== X-Forwarded-Encrypted: i=1; AJvYcCVrAIaRhIVFMi3YoqzWxIlEVAFBztIVYxzMB1xq5/T078WxriiF8PDunTTWb2QBrACYvTY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0hZOxUQNhmWScQANW/7B26f+lTBLfHkzj3QICyeCyImrixE8p 4XUJbqjRf5xpakPWejjC2kcBBMjzPM68PKr/m5bdGQXFM+eimbrC+E3yOYqgg08= X-Google-Smtp-Source: AGHT+IE3j8c7TJIEEHqr1Tk9wQkhE0pmUtXEeEmFijt9ElqSlK/SONVHUSLzvsaukMbj++mLsF2x3g== X-Received: by 2002:a05:6a00:1a86:b0:70d:265a:eec6 with SMTP id d2e1a72fcca58-7192609113emr31183331b3a.13.1726721253864; Wed, 18 Sep 2024 21:47:33 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:33 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 24/34] tcg/loongarch64: remove break after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:31 -0700 Message-Id: <20240919044641.386068-25-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tcg/loongarch64/tcg-target.c.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index 5b7ed5c176b..973601aec36 100644 --- a/tcg/loongarch64/tcg-target.c.inc +++ b/tcg/loongarch64/tcg-target.c.inc @@ -650,7 +650,6 @@ static int tcg_out_setcond_int(TCGContext *s, TCGCond cond, TCGReg ret, default: g_assert_not_reached(); - break; } return ret | flags; From patchwork Thu Sep 19 04:46:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807351 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA8D5C8FC for ; Thu, 19 Sep 2024 04:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721257; cv=none; b=SyLbUQqw0C3l9q0E3m3mfjEnQLtvBP6SuKshYzYg4CNPssn4oQQ4m5NrpGbxBcAtq3lO435Aob7/zqJ1dZPC0QlwNEekuc74Ga5HkQFkJ2z24LwFGrtb7fN0hA9kd8lTnKU9xY/lXkHMMfXQi8DJ2Wg08vgflmyajLKUF4Yhdw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721257; c=relaxed/simple; bh=+QP0X51SLIF6z5AoVSvs92lSsFVIGaFLT/YtRglR5qc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Iyn9nATUuGIATmN8qAaPNg3dkeP6Q8gznxMxA1bf971lwcE24eTm3Mbw/5JC3ffL62LDCxQOcTNh0upZsVzSN8woTiZHKmsYfH5kwjoPZp2Xa7Qs/3Z2ggbYWlPsP3MXvMO51QqMmIuff2MQfW+vAm3l2B3KnqIRdHZjiVGWHOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AZ4AFysn; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AZ4AFysn" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7179069d029so297733b3a.2 for ; Wed, 18 Sep 2024 21:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721256; x=1727326056; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eNWqkzSNCBE+28dt8xOll3Id+6eEjKMEGJfuDzGU1co=; b=AZ4AFysnstq306qAddybnf94H+wevJW1E6KMMfAF1kqfZ7U6XlYEUhEgcYy69fzJzV surI8KzrGHZKBB8pyN6txkxPpO5YOZVl0hdjPqvnAoYDpMXBmLMM+bL44fK3fo9YdXz9 +gU2y66OhcUZhra/HjqFUMAeTofxc77ugo3eXbkbY4trICAtluW301cQMxRHqRy8Jh1P mKX6pnGLrFzwytS5moeuu6IsnKpBlV4AYmLKtMt9XnVOQdScpxV7hgwddlgtmcvNHaln HE/Ofuz9vVgjg6F/onHwoI8hA5wSNzmnoq16bL8PbrRUslKPJr7Q+kHBmA/iEdKmQjWH 7I6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721256; x=1727326056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eNWqkzSNCBE+28dt8xOll3Id+6eEjKMEGJfuDzGU1co=; b=YmsNqb8I6O8gn+45tcbckdsilCl7jB8ADYdXrUqC4+aSrwCsdkBGTNXY9/TZv9JaH+ k8L+lF8hvX8PvJ29w6JoRUCBu+tZfbGP2Hnd7uXQbpxrgAhWVa6fApOhQGhq9dPNfq9S 1CmBwywxl2XKk1Tp4XIN6QgzXiNKS3IF+7FPbpo9eEjdFuSqnSmaRyJkkvg5NoOT8jZw ILrt95pODFuoPQn2pfOgDfvaC7hna0/+2IEyeXAusSvS+Qom0zJmSU802HoU7DPb605W LIxSFUg65mM7Xfz5dY4rZ6lkB75AW+GN+QBVAPPqUIawAYVJIhy5M4XNaHm3Vmiq+o3f MOyg== X-Forwarded-Encrypted: i=1; AJvYcCUlAjjgvliAz9kEooOZvAXEpfpkH1GtI3Mvf3nHxWNyYU+Yl2yhw5qB8C80udJvGdTInbU=@vger.kernel.org X-Gm-Message-State: AOJu0YwMHNrBa+qlsO2Jyfq/5jXZ7s1kNmd58mht5IXzDwaOmGWC6JYx EAmSIdA0JGiE71IAeoGR9RUJJjAe1pAXqbBQwgRJ8r5nX3QRIILPqaR/fOOJXG4= X-Google-Smtp-Source: AGHT+IG0RTXo4zmQGQBlENczTzliTQANG1tf/+V1ayQphhYWAEQO8ZekAqNGAnEsgrQycROh/RQPBw== X-Received: by 2002:a05:6a21:1690:b0:1cf:4348:d5c8 with SMTP id adf61e73a8af0-1d112e8bfaemr31803053637.39.1726721255788; Wed, 18 Sep 2024 21:47:35 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:35 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 25/34] include/qemu: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:32 -0700 Message-Id: <20240919044641.386068-26-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/qemu/pmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qemu/pmem.h b/include/qemu/pmem.h index d2d7ad085cc..e12a67ba2c0 100644 --- a/include/qemu/pmem.h +++ b/include/qemu/pmem.h @@ -22,7 +22,6 @@ pmem_memcpy_persist(void *pmemdest, const void *src, size_t len) /* If 'pmem' option is 'on', we should always have libpmem support, or qemu will report a error and exit, never come here. */ g_assert_not_reached(); - return NULL; } static inline void From patchwork Thu Sep 19 04:46:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807352 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8113B74424 for ; Thu, 19 Sep 2024 04:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721259; cv=none; b=R7SHMom+rNzKYzRBG/F9Q3xWSjIjh/ud49CQk8bVcF58bE0UhXqxS+ZM2mSVxz3zNHaHuEPJMVhns0oOhh8M/fEC6tw8SM1zPi9q60YkOpRgBXoldjjc1+Rgf6kJGvBKfbo5A6319+cLT1iPqBhU85ljmkWiBq4xWyF0qc1jfdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721259; c=relaxed/simple; bh=Tro7KQvkuedU8Bfjd301PIUE1oOHUdBXyh7zt6awA54=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pBH3HVgdb2TStjPvkMe2XwDDgwA1YEOVsljQhlTY4uWXEPPcfKBzBIIaMa2jdpCDnd4uz6Hu+lfwKq3+r90R9QS4justQ6JF2S9UR8TLlps+TGtiz5E6ONQUdtSCfInskmbEkx7rajxa1JVavsu2NDmHjp3Sy49ETw/HWgkCLec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yPqQ6pnR; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yPqQ6pnR" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71798661a52so341973b3a.0 for ; Wed, 18 Sep 2024 21:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721258; x=1727326058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eJDiyfguep+d+77wBjyKgjr0G7lr/7MmmWqca8wnD0Q=; b=yPqQ6pnR6ktMGCu6EdmtK6lCXCOyoObjHr+7wOLE+YxREwMnJJZow+vmcHN22EFq+s 2ffXiCqfOIM0MZgApcJ/Wok+QjA4HKKNzZTGfUdJ8x5WL6vVSP2MKsqEX3IpgYVQbVxP vmDAiw9esMbFL2EHFBcgg9qMqbVSzsIUhNDk4+s5UpOG9hqk61SHvDJWQl4MQxrtAg4N o7ZB88xlXOw4ix3kJL39MXI4adoqwWkUseUDVkh4XkMqPrmG6PXtHh2RJSEUxP7G9tm2 5DowSRE7xQ2cYPcqCL2Fqr3+SWGNlfGRWPJ6c36mnihMNeQlXwZMAB9BG++TgQumk81A sLVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721258; x=1727326058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJDiyfguep+d+77wBjyKgjr0G7lr/7MmmWqca8wnD0Q=; b=HA/zybtw7ozqr1luXbo4wSAMALEmGDTToRvChpArFwvKFPQ+1JjdBFppWpKla2/6tP eDpwT6Dn36Jikko3n1Jfc3WVvQB0yqnyMQ0pa9tMEms9NulXkWoTaVNUo7xN/hWyJmXx ItWi48alcBFr5xAgeYgNLP55/NDKRSWc8NHpwQW6u51/QTheozZGDySR9IB5ARxEo4If TZJ0dgTQ7UTn9+Bs0yccIMvhG07WzylxQ3VKRvGO41UZFjIdb47v9UzGBSIUGYUi6k/B ZPwC5UeOYlRxNghP0lj/tXKsDRQVGtiDSEcmHOV6ObZHzt4YvwNwFdl4ulABGWjpCoL4 VfSw== X-Forwarded-Encrypted: i=1; AJvYcCUDMbXTvHCTx0Q8iY+rkNH9fyfzNi6LzNa/Yx8cke940RcVYhwrP7kK1J4jfNXVQgNAkF8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm+36PmcurzAhAWYIQHZvQIhYf3+v1h+C4cUQvn6NSBjMxWoba 9mbtuEcSktfN/h3hs5nSK27A3BucEIlaWNCy+5UITA6LM1Vdkf1U6yDEaHdWpJs= X-Google-Smtp-Source: AGHT+IHnfsGB0bg29RNFw85uJlnmT1vGFn1h2prLiEcUTMhAcq9d1LGEwFC0+nQGjVzZjK+KJFVYQA== X-Received: by 2002:a05:6a00:4fc9:b0:717:8b4e:a17f with SMTP id d2e1a72fcca58-7198e2862cfmr2976167b3a.4.1726721257757; Wed, 18 Sep 2024 21:47:37 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:37 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 26/34] hw/hyperv: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:33 -0700 Message-Id: <20240919044641.386068-27-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 1 - hw/hyperv/vmbus.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index ef50e490c4e..a630ca70476 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -89,7 +89,6 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, } } g_assert_not_reached(); - return NULL; } static void sint_route_destroy(HypervTestDev *dev, diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 03f415bf226..b36bd3d67d5 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1890,7 +1890,6 @@ static bool complete_create_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_gpadl_teardown(VMBus *vmbus, @@ -1947,7 +1946,6 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_open_channel(VMBus *vmbus, vmbus_message_open_channel *msg, @@ -2021,7 +2019,6 @@ static bool complete_open_channel(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void vdev_reset_on_close(VMBusDevice *vdev) From patchwork Thu Sep 19 04:46:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807353 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BAAC770E9 for ; Thu, 19 Sep 2024 04:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721261; cv=none; b=htalzZnlRU1OnekfKSh6gEf+WKiuh5J0tM4R1GGbY/LcTCGO58X42sbjXHEkm7DZZzx148WpbqzLPXiHrPwUsu0E0lEKvcoMx0fQLD98AinxxypabDHFDRxGoraZRdEEjrZSndAv/Zx72TpwMLuIWC82DA9YlAxqL3Y1lAueQqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721261; c=relaxed/simple; bh=tptLqlcF/Nx0RRmv6IB9N0XbV+UnMzYqcQa/pMA/Qe8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=m4kta8RGS8Hx0qO0zeqH4CMqu9B6cYliR7hJPQ+fF+fPgYc9EXQCtxmgM8Z3OB/7HRmhEh29bs9/LXpFVk0obQIlhN4XNTCZlOqjHozTTM3aZWKop03hPoyxeptT2f7srTQT1RuIhK/3/efPuRhoDS98LVOBHXptekgw1QtBw1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=b32aZyIM; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b32aZyIM" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7191df6b5f5so286978b3a.0 for ; Wed, 18 Sep 2024 21:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721260; x=1727326060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aVLlQ1azCZTPpBP5TtwQ0P5RnlTFYhwK6Tm+S/9eUGE=; b=b32aZyIMcN4wdkYc7RCAOCGUKdgK+brgqmR74IYcfpsC0rvhHnZ9v0qVtg2TAQ4Gcw cA0R0b4VvUbCnY/IOLYhxr2RPROsm3zdvMNSM6W6f09nN/w8gUg7CMD8gohxDMwX2DJX Cydyb2dqDurawraKEiEhmA5I5CWOaWm3l97bNs08ekK3oHqjbbVkQE728WktYDxbq/Nu MChyGDN02VS2/3Ksw2BWRWq2BOs5X2M+0jvccsNDi66xLiEP2nUJXu9BZ9I56iLgRjIn fiVjvtxecvhaBwlABys62u1hFedSjSupxGjCK9PjAHPoWjQE6IdNhz3MQVE3XR12/1uk TFkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721260; x=1727326060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aVLlQ1azCZTPpBP5TtwQ0P5RnlTFYhwK6Tm+S/9eUGE=; b=XsZlsmIj/Y2KhBQFxZ/S/z4Q++/Xru3ch1cA0VvhZiUHAp8pnEuImXOjUG+b1vjbj6 kbVe4tOcldq+RPvlZsUNGyNqIDYcgubfBmrDm1pggGnPzCyy+9v2QsAz2OUzgYHuKfmQ FKgIMJI/Ms88kwLD4t+NTrqoAs6d7TQb/6boA7BB2LVMGz0mfB4Y4S9DjKxE3TeHJIEB yhMrEaYTzbJqHvLHM0acFE23jMRDppNDo8HPZkUXF+S1Gh/mQP3hDsvuXAkApB4nj8KE iDL2yaZATX+PRVrnKmhbvqrQoRspmRLofEPElQltjGwxvtYFAld5wrZZTiC3b6AAyNx/ w5DA== X-Forwarded-Encrypted: i=1; AJvYcCUteab1Qk7gC7FMiVCgbT4tDwb5SVM5r4UjYP7FwT8iGF1U93/03SsSg/a8q0blwcHXS60=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh8agycJAUB8C5yhCh8WBw13ghoqP7Q0eoobzOnnfjarG+R5/D ySCDBvcrLhIgT56N9t4p7x9lof3pDB2+1o7xhz+VzpCreKxnAZj4i6sv0tPeV/Y= X-Google-Smtp-Source: AGHT+IGrzvQ2fWBlgZ0/fu1uxdvH2ybmzImXSv0pyHCUPeGuO+jD1r3RwXqEDbd4priHhUIUEE1u1A== X-Received: by 2002:a05:6a20:cd0e:b0:1cf:476f:2d10 with SMTP id adf61e73a8af0-1cf76239c98mr35848879637.49.1726721259880; Wed, 18 Sep 2024 21:47:39 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:39 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 27/34] hw/net: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:34 -0700 Message-Id: <20240919044641.386068-28-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 -- hw/net/igb_core.c | 2 -- hw/net/vmxnet3.c | 1 - 3 files changed, 5 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 248381f9766..2e4c50ddbaf 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -562,7 +562,6 @@ e1000e_rss_calc_hash(E1000ECore *core, break; default: g_assert_not_reached(); - return 0; } return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]); @@ -841,7 +840,6 @@ e1000e_ring_free_descr_num(E1000ECore *core, const E1000ERingInfo *r) } g_assert_not_reached(); - return 0; } static inline bool diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 6be61407715..5dffa12c64b 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -398,7 +398,6 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) break; default: g_assert_not_reached(); - return 0; } return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]); @@ -747,7 +746,6 @@ igb_ring_free_descr_num(IGBCore *core, const E1000ERingInfo *r) } g_assert_not_reached(); - return 0; } static inline bool diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index bb8583c7aba..8aa8c462283 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -456,7 +456,6 @@ vmxnet3_setup_tx_offloads(VMXNET3State *s) default: g_assert_not_reached(); - return false; } return true; From patchwork Thu Sep 19 04:46:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807354 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A99A7839F7 for ; Thu, 19 Sep 2024 04:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721264; cv=none; b=GZW/zqZhMyVUbIE/CfA/Ce85GGfyyKMgXvm/VG+o3eV8JNDCCJdlgXBBeTDdgiNUshiMRjyGoR1eIAN+AG03XOtUxT+CNY5aHlOSBt61ldU/jxV/WXbgkIpg9sz9qPEIIQTVAQYl4iHGZIRSRbRT18i29aiIpko+R36PlDjgc0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721264; c=relaxed/simple; bh=25lbqox4bT09Xf5Plsemd4lkKHcoBxvtHR5q7wmN2pA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aGCObqwCZAGGeIXBtzbHKMjAQ2YITRXN37C8yxI5kmV/5xC4qypm9EPAkbn50WpNGs07TcebvL5PmSmmfmkR6dwlAaEzIrlSME/quZmj7mjUZdt7BscjYa78LKV7LzsZSArhNRr12gm33jGh7bsRb5DmJElhmqYoumIb4HS0YJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PIAPAE9Q; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PIAPAE9Q" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71788bfe60eso311243b3a.1 for ; Wed, 18 Sep 2024 21:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721262; x=1727326062; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mp3yl1TjwHpJ2DET+AsHEAo67XBOppY+FOew/7+eLo4=; b=PIAPAE9Q5uVQlQHJuK23EckxjHQAIY38zjAQBo14w6WlcKqt1UtLD2e6uWKsISEhHL ouZLf4Ulyi1oU7vWZEKTfjsRKpcR/nC0xEuO+CZMW0ysY53uO7DT2Z1NSGX074b9a0kp J/p8LefztARo4M5OxyLjv8zvIdjq5B/cYuVfhekvpJCoZ+jR0c/KBQBnxReFCTX68fNs 1idEeppYn9pxfUchDjTdQX0o7J5uIF0kvLzuX5oftsiv2L3iC6pf5ceiF4D4E6biFUUe WmpiUig0dLcK5fCcxxGRM6jxYi9Met+BB2414Q2RT2WmF1yOJJpIcKwqU7FJm8FipX4Q Sx2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721262; x=1727326062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mp3yl1TjwHpJ2DET+AsHEAo67XBOppY+FOew/7+eLo4=; b=lam5EI+lbz2QtNjytz5sS2XGxU7LgdFfS6gsso/03u1bBDc9f2N/Z4itguL23YUQPm F0n+XMJwhIyjzLxqZAeVjeGjAR1FX6NoWZssQjPFB8r6TcEon+QDZliwe728NjkV2skA wLEkB09hKDi8/48XAtMPMGyz+cWwCSV0BnozsGzareqTylR+pSYiDi6bqcLw8sXqaoIV D33+wMYAx1EplHyiYsVV2Q0ROpltKXcBtCEorg55NMBYldRTC/+FSUQ4F98XxxmUl0KD Vk3Jj29pXPiuhs9XwcXfqwogLx0D43LRpNcjtflLTlJrkSYFzH0gpP1DjABJjq4TKCEz 2ovQ== X-Forwarded-Encrypted: i=1; AJvYcCVuceo0P+QLsDarvD7I2gWOPC0Kseh/PyJ9UwceFmE3k2WI7YdLplS02seoJK48ndLPEVQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9is0NdIAfID3FvtgCMSQ4wejdSOKSZknw+705bfQPZ1WgXME6 JKyuiRDH2zrOVHMER3zLHQ+aT+OOejuwtL5mfoGH1LjHczl2zODZ19YInOAe//0= X-Google-Smtp-Source: AGHT+IGTH8Je8M6ejpwdBpT0Z6Qq2OjP8dnJm8Cntg/tnIi4gVE22oFZXABE3c3Lz1gX4VojsLrJsA== X-Received: by 2002:a05:6a00:2daa:b0:717:9154:b5b6 with SMTP id d2e1a72fcca58-7192606ce9emr38950232b3a.7.1726721261958; Wed, 18 Sep 2024 21:47:41 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:41 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 28/34] hw/pci: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:35 -0700 Message-Id: <20240919044641.386068-29-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index c6950e21bd4..3397d0c82ea 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -47,13 +47,11 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { g_assert_not_reached(); - return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { g_assert_not_reached(); - return 0; } /* Required by ahci.c */ From patchwork Thu Sep 19 04:46:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807355 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD4BB130495 for ; Thu, 19 Sep 2024 04:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721266; cv=none; b=W7/rljJEPJiBzzm3ANcCWtfujMGLOqzanbDS2vX98AGQpnsdonRj7PbTKAsW0ZxhTY3sJJ+8DwxpcZRreFrBAD6InAF0i/47Kjy1OROtsoXvBArnCnHU8tOR54rNB6XQBcKR6tDnr5reRju36zp31dIY7rz/CuWHd+fNEYf7OwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721266; c=relaxed/simple; bh=HWwY24WZZLHk/J+SJCHhl6mzgvIAogrzwEH+WFoXwuc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=VRVqW2eDjvyCt3naewgyLhGwcRPjbh20uZN+THV6TS9qjZrDMPdQqPq+DPrTcwIfDtnFor+a/4D34bKHGv9n43vzpxBk0ASI6s38YR0Ji2L6VZEDsJ+dT6TatwEESYOeGrw7tnijmajRdCxE/HkdfSwG9ws7DmjvpK3SkVIwxNE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MLerGjK7; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MLerGjK7" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-71798661a52so342044b3a.0 for ; Wed, 18 Sep 2024 21:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721264; x=1727326064; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZHfEx5g5BzL1PX1RgAlJ8l3kVoVW/oh/s4YLt1Je16g=; b=MLerGjK7mKXFKl6ftyGcaOces0UpsulGfMPcebfES2VOVSbVe4iFtHO1zCaKdpbphV H3+wGy8GRWWuHr503OLGGZAF8LMA/6Azap6JVCLAfvY6J8IvwKaefgiSpawWVL3atlmU 4fzojVH+qYSz4y1w3ysmV7eNTcpZ3SNcS3Fzw273otUn4cXM5nPuPsxSXUY3qtR5sXUV Rp24ZdQGqcN8wGWfQflfYWKenRPdXIN2odk53YR37BYk+Uwxe4UiTOqIGOPFddEczL2P PDH3LpL8CgUZB9X+rwcgBvpkvetSTfmW/UgDaO00MAujvmkvfhLh4BQewJ+gNmsVHNE8 KFzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721264; x=1727326064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZHfEx5g5BzL1PX1RgAlJ8l3kVoVW/oh/s4YLt1Je16g=; b=LJrQWAQay0wORLzJmr7kOwJ3DloDeke/3eImVzaJ3M/Fly+u+yLdKu77DJZJOGGHVG +8SfWxe/A1g27GO5KlxklMVP522kuMtHerdAWBVS8799b/K+JM1IjlTjmL4dohb7JN+7 ZMz3g9AxDLNIO0O92mzv8eG8R9vB2sm7ErrgVVQ5r73Ehva0rKWMK3QjCN/MFDfKcC+w BkzO+wuZ8/wdjz7tonK9H2471vbZfz8EaSIaLMP6w8Ik0jQhWAqGMFzvsKocDwG4QXGZ oPn6DGxaGNGVHtplYFx43DkEWKpmCnPPNQThHJlvYJOUe2UGHkoumQf9FQglGV6tAmtU DE8g== X-Forwarded-Encrypted: i=1; AJvYcCUOkjR4vA5Wswywe0zNAwECi4NfSb9G9oSf9Z3hIuiFrcUpQo8ztcotazz482pxQvVvNR8=@vger.kernel.org X-Gm-Message-State: AOJu0YwJyVcahCqyUR06RGwu/yQ5GUhNRMhNzoC+LsLYaFZmzNom+5Ck RO80O2e2fGIie3luJQPaZjWyZvmeOxbeavJnpqs5Du5w0RmmWiHQc+SjZT0laqo= X-Google-Smtp-Source: AGHT+IGn0zKE4NWTBii40hBHgJl3lvYHO2m3pyUcQ8D1+09Ub75s0ooGndgxJcjdbl40KxBP6dN9PQ== X-Received: by 2002:a05:6a00:1746:b0:70d:2a1b:422c with SMTP id d2e1a72fcca58-7198e2a8f1dmr3107578b3a.7.1726721264030; Wed, 18 Sep 2024 21:47:44 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:43 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier , =?utf-8?q?C=C3=A9dric_Le_Go?= =?utf-8?q?ater?= Subject: [PATCH v3 29/34] hw/ppc: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:36 -0700 Message-Id: <20240919044641.386068-30-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/ppc/ppc.c | 1 - hw/ppc/spapr_events.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index e6fa5580c01..fde46194122 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -267,7 +267,6 @@ static void power9_set_irq(void *opaque, int pin, int level) break; default: g_assert_not_reached(); - return; } } diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 38ac1cb7866..4dbf8e2e2ef 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -646,7 +646,6 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, * that don't support them */ g_assert_not_reached(); - return; } if (hp_id == RTAS_LOG_V6_HP_ID_DRC_COUNT) { From patchwork Thu Sep 19 04:46:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807356 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A1C839F7 for ; Thu, 19 Sep 2024 04:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721268; cv=none; b=epbCDhiLvNjdC5+izgTOzS0+MXmJb7Ug25jRknrcMAia5Shjsctvs2hr/sxr0kMiov51tdYhis61zfXdP4jSBTayRIEWRz/UkTLHjYrq2FpYmfTZxvk9Wd+4e+HNMCRG9YNu6lRARpymdFcdtgXtXYFSQDenUoQ4iwCtzOCJ3ss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721268; c=relaxed/simple; bh=uTz0auK1I+RUbKfAt7P2FPVRTqZni3nijk17xT3fNmM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K2lpfp7Jm4YwikAdWnfY3f2qfwpWSXzRTCfWtpTrZJVePaUFCaFLhlnhNDBWcMggtfLbA/XQswmGaP4O8I+oibccZNSqSIVera2IYPeAPLtmtDJaoNhCtNLplhBjjFRF7mEwtR3x+0qae9Of/zQ6+FUUoQ5oGV+0x0F7W9UKLtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=boyG8oOA; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="boyG8oOA" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7d50e865b7aso308911a12.0 for ; Wed, 18 Sep 2024 21:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721266; x=1727326066; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ozWlgV20eXCZ0c9b/13N/LAwE/BLpMMoDcMJfurfVNw=; b=boyG8oOA/aOyIJnhxBhZ4rFvfyVXlltScc+acefImb/T0L/HVyn2LcG8Mi/F56AvOf atNvZtb5v27aStHzR8eMS05lC9FsyS3ymoo2/9AxeuGWipz6FqT/Jvsi+Ad2NtVp4k8a zuCr3nSD7QQa9sU8LU/IfmXXu1gprw5rC81G+9jims5llZeoRqKasIstu4XhtoL8QW2B D1Z+jt7ufhAvn3eNPWSbc2WcUwo5ksTgHJjgAoUrtjm0/pHtPm+bqBpeCN7d4Mlfxxdp BYcfs+wo6a95dWjUYQeMT0ir7M4jLvHVbnJlmFjbHdDHJw1ypzEFHyNDQylABPnggpiL 282g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721266; x=1727326066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ozWlgV20eXCZ0c9b/13N/LAwE/BLpMMoDcMJfurfVNw=; b=J0X8HGQ+fkxKzCCxiwJEjVy/H1nkVNpIuiggMYdVSCgw+pl6f412IULRxjZ423NUQ8 7uSBIkjiOht87MHdw/wtT7hy74cAYlGzP8h9OxG8Xrli+HGguPANrMGxi+uTzE6cZcR7 24CU7Yq33vHYivl9wt42dstEQMRkVDRBOW2eI1bRDYX9KL3fgtTJmgEUIHixopbiJQde 5Jo7L+Lm4K9V73MQ1n5abufsDeHhWSYFMWPnrZzdIma8tzVMmEseOwF5fNoxsIb1ixQ+ TPMjyfjVPMD3NHrhVkjXqwrGyD4/4wjfS7BP7eK+8Uw/oHdbwQMAzOVm+43zjowd7xdw 2SoA== X-Forwarded-Encrypted: i=1; AJvYcCVbPk5LYd/i5j4c9hCXs/hiEU152odc/ZFqSEeTVfvA5GndNKDCGBRLdBHEYCVNy+jn5vE=@vger.kernel.org X-Gm-Message-State: AOJu0YyJdvj+/N5KIkXmVbx0UfPUDdShaaYJ75pop86sLS5uulut/ssh TXr+dIr02xXeqMbkyqLO3La4vBeBdTA82EMfQ659U2Gx3q54cc/+vupEBvXuAW8= X-Google-Smtp-Source: AGHT+IHsHP2GkF8PiOM9Z52fH8cAj4VN2oMaI0BFSJQoP5lyLdMB2INYK+7wocFS7jMYdV3UCDnxug== X-Received: by 2002:a05:6a21:38d:b0:1d2:e945:77c4 with SMTP id adf61e73a8af0-1d2e94578b5mr9976706637.2.1726721266025; Wed, 18 Sep 2024 21:47:46 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:45 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 30/34] migration: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:37 -0700 Message-Id: <20240919044641.386068-31-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth --- migration/dirtyrate.c | 1 - migration/postcopy-ram.c | 7 ------- migration/ram.c | 2 -- 3 files changed, 10 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index c03b13b624f..5478d58de36 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -229,7 +229,6 @@ static int time_unit_to_power(TimeUnit time_unit) return -3; default: g_assert_not_reached(); - return 0; } } diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index f431bbc0d4f..0fe9d83d44a 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1412,40 +1412,34 @@ int postcopy_ram_incoming_init(MigrationIncomingState *mis) int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_ram_prepare_discard(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb, uint64_t client_addr, uint64_t rb_offset) { g_assert_not_reached(); - return -1; } int postcopy_ram_incoming_setup(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from, RAMBlock *rb) { g_assert_not_reached(); - return -1; } int postcopy_place_page_zero(MigrationIncomingState *mis, void *host, RAMBlock *rb) { g_assert_not_reached(); - return -1; } int postcopy_wake_shared(struct PostCopyFD *pcfd, @@ -1453,7 +1447,6 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd, RAMBlock *rb) { g_assert_not_reached(); - return -1; } #endif diff --git a/migration/ram.c b/migration/ram.c index 0aa5d347439..81eda2736a9 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1766,13 +1766,11 @@ bool ram_write_tracking_available(void) bool ram_write_tracking_compatible(void) { g_assert_not_reached(); - return false; } int ram_write_tracking_start(void) { g_assert_not_reached(); - return -1; } void ram_write_tracking_stop(void) From patchwork Thu Sep 19 04:46:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807357 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9047E25776 for ; Thu, 19 Sep 2024 04:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721269; cv=none; b=SFkxeduX6H7rzWDhQ3TZRKC5bzh89Fah1xib1wywML7aFtTKGh18Ultv+PWTHaa21Fwnib1OeaWxwEkbxcLT9ZSnC9r4gLI8eVqbu+rfXqeXyV0qE4O1Yxjmp3PCmGaCM5QGrUFQUrwYn1H7fjEPur+IlFZ9L2DDBJFkWsyNBVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721269; c=relaxed/simple; bh=nrbaSR+EkYP6PuyDjsSDQ2S2g3Fhxr3AdAybeqnCY3Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pOOOOGuMc1+dcyGCrXxdST+1rI8hYdXWQ7F2ZJsbTpYaR6qOSuKhxc1Wl1kTP6kqEnv6+FN8uI0lk6fNUMT5YibVPctzzHFDwhZivX1Dnt0o+yl4xmOAxZloHAFEl1Mut9pmiRXrgaI8uGA0xU48lpiDI2MoCiB38kR9/iBzhH0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NuRaeDW8; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NuRaeDW8" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20570b42f24so5297605ad.1 for ; Wed, 18 Sep 2024 21:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721268; x=1727326068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lJWuRI2a+xcGlqE9ilLL21KPqsM5FE8vZBWYVBf4fqk=; b=NuRaeDW8sjP2EDzXIeLyQN0ud832IV/FAv78fZa8vRL2aY2xYqoYSWeqtHLNk4/PhX 19BCcgegxcQtBY1LnaW+DA2ZBeboXJPVALY5mK7+ngzfROoNV2OErhfAhLG9whMHO4kw F1v/kqJ2FEZB19MOPPdQTOOD1z0HmxpX4/WMNvEQ39MQc0ykI+kECbvtGUfgDFpvkJYj pFJ6DNFHQ1Y7SCu0N1zKP+QgiDJZ3msP+htB5B1lQxEQAK/pcx1Nk2x+0IC3VR3WxBoY /0JcqRb66LnsMKIow7U+B6bAlcY2Cd/8Fc5WJoGVL8ldln5FsMnEUzar92P54pUv2T7i CriQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721268; x=1727326068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lJWuRI2a+xcGlqE9ilLL21KPqsM5FE8vZBWYVBf4fqk=; b=U5yxJlpouYaOykfBYjk3FGayGX9j4fUj13fTJgPBEWvcEdzzNfz4oKzgJcVXkm2wVx 3xqzC8drkojvDAP7uE5tBQw2+w2yUcmLBNh5Uq1k9RRp/KKM0hyIDgGKLwmKCF6EX0f0 WaQ/mqPTkzFH9KHJVvAj5Ase5thTCgg7mRADG1+hMeddmJZxiGG9Qh2ND+UYZn0TUS1Q CKBL41cRUBUktfNft+ipQdM+f2setNbUuzX8ZhMzLv96NHPPdQ6QF5xcr5Ax4bHqO/TE 2Ej1OwRxgvCJBVD/Q8JpJOur0Bs3ZS7qURr6gAfOWbKfjuWiFHgODWsnr31H2CiynP/o Rgpg== X-Forwarded-Encrypted: i=1; AJvYcCXogQV43hA1AtQFHYeF4RS8GpD+5RdNSVYgDIacm2brCzgYZfFG/eC9Yn/z2O0McvdFYs8=@vger.kernel.org X-Gm-Message-State: AOJu0YyFdOTnfWGvFuE2Hho1xD7oWUm1Ij2akhLsWJ+jWWPGFiousXse ujj+EMYFCKXNSLs+YgYg9zn95rmV0xH3fSla1kQYq6yvmHMNd3TPwauCSXNHcms= X-Google-Smtp-Source: AGHT+IEWVDdbKcjFcT6g/UvYMSE83MFSMfB5S4IXaD3yJyhmupuCthkvU2aYKDc9W7+wO1/hWbEPng== X-Received: by 2002:a05:6a21:3a81:b0:1d2:e8a5:689b with SMTP id adf61e73a8af0-1d2e8a569famr9583177637.14.1726721267939; Wed, 18 Sep 2024 21:47:47 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:47 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 31/34] qobject: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:38 -0700 Message-Id: <20240919044641.386068-32-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- qobject/qnum.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qobject/qnum.c b/qobject/qnum.c index 2138b563a9f..dd8ea495655 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -86,7 +86,6 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) } g_assert_not_reached(); - return false; } /** @@ -124,7 +123,6 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) } g_assert_not_reached(); - return false; } /** @@ -157,7 +155,6 @@ double qnum_get_double(QNum *qn) } g_assert_not_reached(); - return 0.0; } char *qnum_to_string(QNum *qn) @@ -173,7 +170,6 @@ char *qnum_to_string(QNum *qn) } g_assert_not_reached(); - return NULL; } /** From patchwork Thu Sep 19 04:46:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807358 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A83288C3 for ; Thu, 19 Sep 2024 04:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721271; cv=none; b=f0tQ/jsTjpNuCiOF0JuTPz5cbIw70WWRrczafelyMGPQpFy2FmSErwOTweZbnKI1L3ESr5AvyxnP/UVaiwMdNrB+oEPR4HVId6edFVDEny4/QJAyTeY1mZEMvXTdYO47zf4D0LxPv1qGmoBMNBygbBOum8LtyBP3hIfF+zHtQqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721271; c=relaxed/simple; bh=STQD/JrIwGSp5JQg9H5J6QkyWrzeOa7Cmx8S98scipM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YP8OD+KPD4ThShI5bLDGHUiOQfd3BRyYYJy6S76Ez5buiDPJP2fjsImQ02CAXwJ5diPpsFgDXf5j+md8r5UfAELenG5ruStEYfkl6ZdbGggrqH85iWbSjLZP1dNyo7n1nSjNr8b9FtuJBAl1gXoJvcpR6leK6HttSVnv2GkEHEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Pr6F6Ev9; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pr6F6Ev9" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7db12af2f31so333779a12.1 for ; Wed, 18 Sep 2024 21:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721270; x=1727326070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wsHCjwrGb9kFALwWqgq3B+HDSbUQOfqxzvxaIUK0xNk=; b=Pr6F6Ev96mffvxwJjqPA97yQFeBkGMNYNM+glz2KXc0LD893CX/KuD5xp++eh6kEFh 8u73o5dL0HYuvLqfey+mSUiVqHStWNjYACX587pHOvBGlxscDB44QuiLVyK34XO5WuXp opN2oiU98mGg9aQyiwHe2Mtd6aG1mEvj5mJ4RnA5IvkREfzXzovtjzFs2uowgugBkzBf YwbfaVrtGAUqUfKGD9gHS0pBYfzzS35rOr2CeWQ3SN0xd78mrpwWVmnO3cgtzL3V7nph Hg8+RwOoDj9fsgyqK6kgXmOYxAC0u0CwwvKNP4J+T7BJ5Je5VLHBFg/5H9axBSI7BBYs R3Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721270; x=1727326070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wsHCjwrGb9kFALwWqgq3B+HDSbUQOfqxzvxaIUK0xNk=; b=WxFONZzwm0o9I+QsvjP97wBmBFZgt9jMQV7TIxooKK/729DL+/DchQgXs1mN2AYLNE jpp7llX/17rbtcZYyDGIP2ghxOJFHYhJkv1hOAXHa7NUWsjYFdHFerBRdGBQmqCygiFH tjlNG9p/KglPGb6yJEXJID7fDwptJd7d34HfB+/F8qPT5fXCLGxEqhkkdk6D1Vt4vlLr mXZZrBmrgvuds3nne1vKab5Jup1vkXQYJBaIDB53HeXH7sLdL+0Blzim8IWdVFbyKqpc SWis1kfiYNBQkSPugTSzCPDiXnM27uICXmB/SKspXNLZAK0Zcav7victy3b/yZ9cFTNr P4ww== X-Forwarded-Encrypted: i=1; AJvYcCVWBi4Qiv7w5yh4WnwQsH3UXLMd2kYGs3OlAHZq7LOfeRg+YLvzM55z9XgjCz2svRhOnwE=@vger.kernel.org X-Gm-Message-State: AOJu0YwnmOX9fcLzFM1QSDV7bqcBpnHp/OlG0bUQFjTdK7Q9i/MZaS/8 VVhOFVzqy7vf7WreHhyywKMjJC44k/UB4LoVvsXFml/wvvMcNAaNclMckgvbg0s= X-Google-Smtp-Source: AGHT+IGSEJfg9NiDwsfGQNgMzoJXvgeBnRfAVLKv9CjCjZDAdI9sAnhanA6KRSoF6muQ/s1OmrvU9A== X-Received: by 2002:a05:6a20:cf8e:b0:1d2:bcba:70b7 with SMTP id adf61e73a8af0-1d2bcba78c6mr22172622637.27.1726721269821; Wed, 18 Sep 2024 21:47:49 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:49 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 32/34] qom: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:39 -0700 Message-Id: <20240919044641.386068-33-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- qom/object.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 157a45c5f8b..28c5b66eab5 100644 --- a/qom/object.c +++ b/qom/object.c @@ -2079,7 +2079,6 @@ const char *object_get_canonical_path_component(const Object *obj) /* obj had a parent but was not a child, should never happen */ g_assert_not_reached(); - return NULL; } char *object_get_canonical_path(const Object *obj) From patchwork Thu Sep 19 04:46:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807359 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA7913A878 for ; Thu, 19 Sep 2024 04:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721273; cv=none; b=ePmLGGhvfqS7n6rsyB+4K40zsWwnoRJVKjnRMcukNb0QQzwyfkibvxpmGLu3kF+Pj8S+kOSBhfOQ6gmpIuVilc0jhRPGm6ftalpqUHTQEWgwQu3JN5S0a9YzHOFv3M1bPGQEITFp04sPzibniLVi8u/MJvj6826X9zfqS6XSOek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721273; c=relaxed/simple; bh=U5fjiVedkYeOh6w1Ljorg2MNfMmdU45BnzLBKfMi88A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LUxe+fFw2TA8yIx2KGYFew/73hwCK+pCtb431wH4dzLr+HfqPeS6cIoOkjP3GcJJ/GSRkLqYTdUZikFXb/2zcymV3ezSZPj91gkdhIPsIwdhf+VdGbVEySYZ5EfPSexZU+oOpVH/w+TFh4c+0SbV36f+i8pJJo0nJKPZZrXig3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W1uHyWQX; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W1uHyWQX" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-718d91eef2eso279126b3a.1 for ; Wed, 18 Sep 2024 21:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721272; x=1727326072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/nGORvbHJ+qdXbStyLX4ZDxj18G9D+mDlGJ72uSFPz4=; b=W1uHyWQXy7HZZfyXEVz5v8y62St0PVxq1qbTjw6J/TIwMS4YMvTmq8jB3NF9zK0YKV 6Fnyp6iUPHuHvmUF27I+yYSmQmjlv2NezeeXrOWA4cAXb7dgQSmeqGRaAxLR1W6CUEQb KNVea3JxgVaNP6g54qdFTo1PjqsQiXSjRywle6nitaIjK3vccpOWaYrkw5oZuhk6O5yR u+WF+WhZuWZ1o0B9K3po571FLHD2CFmB1jWwMfCwXeWRSFmdB1fVmnpMSNMJXzNH0JeB XqaAMIvd1VFKlp93u+Y5iA669Dz1sxAe7bBAcfEIAWsK5fVfJZvtEIiiXpkNTO48+TEi tCpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721272; x=1727326072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/nGORvbHJ+qdXbStyLX4ZDxj18G9D+mDlGJ72uSFPz4=; b=eB8I5mqBb7J0x/R4Tz8ggsAXIiZjM4rdmGZ7hzL7w7EYq+Takvw3CQLkioLYug13JD +NLp2Jxmp7J2yrKGXiIjL9uOPevX28Ubu5fRsAfwRPsJNjb135E8VBQO7RAgN6HBvYKe 00zgtzhngewIwfc3fg7mIc6Jj125yP3ztjeMiLTmL39JzogwPwK2oEDf/w38ed1SeDOn x24vgB1/bSUluter03Iq+9ZPk6Igrne31eBGNbWjAc2McnNUVEbuTTi73VTD+z3ugtJ/ I9ei7/M7Zp/1vZAS0XpELkFW0X6RcmjGZFaGPPcSMJpmH7jeSm+gHIxXLpbAafigIeB8 gbtA== X-Forwarded-Encrypted: i=1; AJvYcCUKCwjIPzmbiV0LcOF20O0GX7AjRnux+JVTBaxxViwWgRdA51Tn3h+68zwIGQ0emOu2E+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxjbH7w6zSdzkEGRDyacS3NaMF0YvmmAMxc3E9MOHpH/JYhdbzZ 65M6F+phOHRxI73XEeQ+qdSjlM/kocUHGRFeFZW3RspeqKD9U+bvmq0nbEC6OsI= X-Google-Smtp-Source: AGHT+IEDg2pn0QyAuvoiOwCdHYylFwrCXGUqq3XEUUTIp+6S2LNPDo0LRqpJhUmVkaR/AJ8UyQGZ3g== X-Received: by 2002:a05:6a00:1885:b0:708:41c4:8849 with SMTP id d2e1a72fcca58-7198e2c832dmr2743657b3a.9.1726721271832; Wed, 18 Sep 2024 21:47:51 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:51 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 33/34] tests/qtest: remove return after g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:40 -0700 Message-Id: <20240919044641.386068-34-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/qtest/acpi-utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/acpi-utils.c b/tests/qtest/acpi-utils.c index 673fc975862..9dc24fbe5a0 100644 --- a/tests/qtest/acpi-utils.c +++ b/tests/qtest/acpi-utils.c @@ -156,5 +156,4 @@ uint64_t acpi_find_rsdp_address_uefi(QTestState *qts, uint64_t start, g_usleep(TEST_DELAY); } g_assert_not_reached(); - return 0; } From patchwork Thu Sep 19 04:46:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 13807360 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 837E013AD39 for ; Thu, 19 Sep 2024 04:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721275; cv=none; b=uexngjOsrApSc2sweIsde78sGP5lCR9chIjbS4lPuFEGuRn+NzmVM3TFi/9Uwe6DwIwF030GQHV7Mot8IhQRqs/lt7oW77OttISvmnEnqkRQDD0S1MFFCiOvLKLbJuvVaV5OhUOr2OeWn6zdrOxFofF5MC40S4LqWHekX86y2b8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726721275; c=relaxed/simple; bh=P8irt90jCfPiVTa7W4ZKArTNgFUgTas7aATeexfAzhA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UgsFaYA1N0mX4xgb3cp11DpKEDDch4+bWy24QBZ6+W/KVwgOkrhs8sk+DfFc+v+QZCcz6gTv8UwMKwUla9W9KBHQ7PxuGL561s+9g9IMZQ64Kk5FRRtopb8xAzVSLdWQK89R8/qSNjVYjFUAO6NXxlNZ71ZkHlyjNJ8TYSB8Z7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DZ2p1TTQ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DZ2p1TTQ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-718e3c98b5aso280698b3a.0 for ; Wed, 18 Sep 2024 21:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721274; x=1727326074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tx1S3zr1/95ZbSlSEpzuV5Mw8JtyoYuXcwzt94aV9gc=; b=DZ2p1TTQTy8jt4dUeT+8+DPp8IRgkUzo/JeagE7jrOjOuk3FjjDMBZ1HBWxOoDik1F K2mtlrXvBmLnitevMooNZOdExy7W9HxfTdZFrsq0i6iazG6N3D2NH3EbIER42GtikIxc gMbRIm8bBQBJRScHTZfG569r7GktPpuJPSZrWk1nYxXnzl+LH94cljkWkqFC0ptMAXKN z0D5HgLu4jrMkBNPyaixJ1Z+X6jqYJynDFoAF+tpTPhrTQzHGX/dtTaBDqwgp5yCAVk7 x4X/RI6Axz39D6psv0RWk2kO8EjzAa1NIuIODHXgr5Rc2PC015kyflN5FG+8KjF684yk PDfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721274; x=1727326074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tx1S3zr1/95ZbSlSEpzuV5Mw8JtyoYuXcwzt94aV9gc=; b=UEoLau3QYYefVPV/U6p2VYvNu5sGmq4RqZvwbYZUb5JAUUak4aLSnx23S1R5j/Gm7I cns4VZb6/CA2S61ufnQjGleR0iI0TGcJYf6dK/lkioltx7zrmPtE9gNxyyLUS9WNfKfo v+UzInetnul/lE47VeuShEinUu5LBIzIsnWZT8nElvbR0XLHmoSCPuKMPSJygIw3Lwfg lcy2SqwxGX5A9awHriptPfzmnTHKtA6Oeyhoeu2AjVdsAJiyrFOxakVsfib+WL69JyN4 lBUI7i3MK6PQmm4QVsCTsXPtCs+Vtqp9+MQZhB0NV/JSWWN3Aae70dCkibE9jwVmkiAO bMog== X-Forwarded-Encrypted: i=1; AJvYcCWRk3YPvkjf9s1Vk/0JaZUpeFYXhZtU6fZnTlnZCtlFFMle+fE4UF9152BDIBKLk0yUW+g=@vger.kernel.org X-Gm-Message-State: AOJu0YwXYKwrj9tmopmjWvDyifB4aprjW6Dg3W8HRbrZEL0nMHOsJhCb yxKhqXb5eJ8wqMdLFnm6NT3eiLR/V657MDb5ld1LOCoQyqZPjol18X76RRmh1tk= X-Google-Smtp-Source: AGHT+IGxUDLX/EdmxHd8lBwEQSgvpOMo5EV+rxbHrbQJ6oH4Ek//dhdYk+b8MbHM5eBQ51CMojJGfw== X-Received: by 2002:a05:6a00:190d:b0:714:1e36:3bcb with SMTP id d2e1a72fcca58-7192606bcb9mr34659991b3a.9.1726721273726; Wed, 18 Sep 2024 21:47:53 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:53 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 34/34] scripts/checkpatch.pl: emit error when using assert(false) Date: Wed, 18 Sep 2024 21:46:41 -0700 Message-Id: <20240919044641.386068-35-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- scripts/checkpatch.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 65b6f46f905..fa9c12230eb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3102,6 +3102,9 @@ sub process { if ($line =~ /\b(g_)?assert\(0\)/) { ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr); } + if ($line =~ /\b(g_)?assert\(false\)/) { + ERROR("use g_assert_not_reached() instead of assert(false)\n" . $herecurr); + } if ($line =~ /\bstrerrorname_np\(/) { ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr); }