From patchwork Sat Sep 21 12:02:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 13808906 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40B91E49F; Sat, 21 Sep 2024 12:02:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726920175; cv=none; b=DWeCyh7TUPi0b7Y02HcQFZPTI8ratza57KhTQ3OwgxzDJoFlMFBdyHqy1CuPXsxcn1oP2kDfJGBhx/vooDwQyoF9xWqjZJJ6LU3/AxnnG/OnQc2pi8CCwD6zP3MZWz1VV/GoLNlxZZ2cS95p+AUuHV1Pm7q0a1v9T82Yrtp2leM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726920175; c=relaxed/simple; bh=CEawkW4j/3FwdhrrG8z9uxgUjpJrgxwwD3ERQwXJENc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=OHFwze/oZipjH2jZRJ1GlQ/vOhyXc9PGTvQiXsl5t+3Ude9roNp0juLbpJn9XrcOcpx4ArxuDAk9SIZQ3YbiSrzC0stlW9jWY6McryrBKjucEBd2V4tS+pfF2YOUTgTl9GO1EvLZ7Q2wFtwf3tLVxd7n9v6cUaiV9AuYngjb2To= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=Ny2nJI+D; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="Ny2nJI+D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1726920150; x=1727524950; i=markus.elfring@web.de; bh=HzVrrsfa6DHNfn9T2DCLPRLw5kYNl9j3zngi6zzGsxw=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:From:To: Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=Ny2nJI+DGSaGjbingVCf3l1/7Rwnh7+dmEgZUOjF3LyGP08smL9GYOfpIi66iI9e X4ZL4YuKbX1lvADNla7HFc0OQyclkiLZMd9RkxVZ8hbBq6ZiFFDZnppSK1w6fSCmz hZrdBOhVtoZN02k5Pql95l3R71Iqv+TJ8mAyApjntXWSmbmgEHtzGrD8cCDmGZi6z hea7Zrt+W3LXHZA+KRIm7aOqtn+YRAPE+N9/gFVCUTofLiPZlCWhcTnczqTbZqBic +aLB5mGF4qIIeQUiQrtPyuMsNQmlpi2uGIpTJgZxPAHoQ5b3mUEQP0sf+ve5mDIF7 +lnKRKWAPhFrrDBpDg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.91.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N3Xjb-1rs0Rh31Od-00xfD2; Sat, 21 Sep 2024 14:02:30 +0200 Message-ID: <5437e685-8fb5-45f4-a78e-9aa961f5adf7@web.de> Date: Sat, 21 Sep 2024 14:02:29 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/3] ath6kl: Use sdio_release_host(func) call only once in ath6kl_sdio_power_on() From: Markus Elfring To: linux-wireless@vger.kernel.org, James Minor , Kalle Valo , Krzysztof Kozlowski Cc: LKML , Steve deRosier , Julia Lawall References: Content-Language: en-GB In-Reply-To: X-Provags-ID: V03:K1:I3CBTEDZ5u89hl5A2Q9zxpyRlYtNA2Egj4hxcZduSNQoxyEy1by B6z0SKEkzLf4VCHM+huaHxQytgLBrlm9Tf9fND1TOhjM86k7ahDKuK6NZVSLss1bSvCGtns dlaS4qqS8HnahSuOr/Zpbap+anDuUQM+TWDEEBs2uAwB9qP+ninwuuuIyB/f/k17eyPcbsV Iwd7w1UhbEWkTRd2Q6JcQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XL2DkwLxsII=;4l7w30JC3zBu26fh7+kgGa2pC8r XYBljwpWzlIXFt2GZSb2p5ft6S8HMaqWxt+FhINKyzR0Q1Iwn1/+K8VudbyTH5oD7/eZLd2KO mSzmVl/FiniKPmz9Cu22rYz4Q2tQSmvBRXbftW4OBhlXf2824wqdqx88blx0d7fHQEwAjVfNy RrXwRAW8LVY8PMNZcHdP5xaQVVZnPlizIybtI7BvERnZiYIZPPR0tzzSdkjDrzEeJCsVX4bvr CcTxlC3INXi1dzm1G5kICLlnjnO5/CKZFgfQSQLfyfpZLuO3y/uTwt3gUk51HVu6qRCK8V/e2 xcJ6vF1QgL/YSmOwlWWdTNAw0Sh8ztCMuW8D7nQKuyAq262OgbeNRBe7VzGqYdduYJ0EMxoSG kVc/OLl52AhJ4o7N1vCd1V2G+aVI3J9pnSUuL7AU6N3yFEv7zJGNok/JoDfKak3hxM1wFXlP0 n08mVws9RtddPdhJJdeVDyeeIOuRH7d9MET7ryIcLoNh+5hcyy85cNlGTTh/dPPpfnIt97nJg OWujc0Ov2CbojLqhhzU2FNPECmNsDBYkp0z/6Z4+HrqIMPmTgqAqWivsvst4i5qHNqXkJ3sWO 8Wr/hYFlj7HUzzKmkixzRSNWmHGB6bworKA0J0fX3m3erzxuYb64EZ2+6HFs08BRq2tnoERTU KL70OWkw6RWwZ7YCev4+62SXQ2YvqaSm+JSAYjcm1Oi1QKHh079ZqovYncZE8up6Hn43UoPwg rnhr4aKtQy657zUaYmq8UrkM0DRDILwoHld3cY5IBUgVDHOgBZGy4yVaml0a3gu0JiWJVHDgT khkc9sLTXCVOpkrRg0GEHa4Q== From: Markus Elfring Date: Sat, 21 Sep 2024 12:00:19 +0200 A sdio_release_host(func) call was immediately used after a return code check for a sdio_enable_func() call in this function implementation. Thus use such a function call only once instead directly before the check. This issue was transformed by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/wireless/ath/ath6kl/sdio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.46.0 diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index 9ab091044706..5106c6909dc8 100644 --- a/drivers/net/wireless/ath/ath6kl/sdio.c +++ b/drivers/net/wireless/ath/ath6kl/sdio.c @@ -514,14 +514,12 @@ static int ath6kl_sdio_power_on(struct ath6kl *ar) sdio_claim_host(func); ret = sdio_enable_func(func); + sdio_release_host(func); if (ret) { ath6kl_err("Unable to enable sdio func: %d)\n", ret); - sdio_release_host(func); return ret; } - sdio_release_host(func); - /* * Wait for hardware to initialise. It should take a lot less than * 10 ms but let's be conservative here. From patchwork Sat Sep 21 12:04:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 13808907 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E5851E49F; Sat, 21 Sep 2024 12:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726920263; cv=none; b=XxvT1+MI6EPX4Nx3BpMzjgrTNZyYRW9sq6rquXKt7MGnm5gAHK5vpS+Jw7OS1CgBOzcbRn5kbqdNZf+JV71AeYaRg7UbljIKv6hvCEhd3mFQOpk+e4nXdlZvQxddlXKmkTzPsh3/M4B4ATiYi7EKReUMQqFBsi9DOv4sSu+vhMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726920263; c=relaxed/simple; bh=zeHBd+jpN0FHswZRhXNBVhUMYHPwBCudf70YBsWzHkM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kD+O65hDRuHWYUv3FrPUQN4oc8UvLf1S3c4J2kd6MilcwYNaEZXkW3e1ecmk6cAHc5XlRPH2ZaNIjDsguIgTLrQMNBOi2fKW0ENxobqxDVwVhCVttp6GDEB+OrufpzjDXN3Bsjluqo+XaAuir37CpkCXhETmsqYXKTfJ0PRhswE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=uCDzUkm7; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="uCDzUkm7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1726920250; x=1727525050; i=markus.elfring@web.de; bh=sU9bIIzGnTpvnLV1pwylT++PxrcoOaCsoLi2elpHlM4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:From:To: Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=uCDzUkm7pLFHKI7ZiSOp5GdJgmYKmtzO5t595In59SS0QOIqxpElBLklJYTZJdzU bevQobXBV5+0L3CSzMzzcVr6lGQm86r07jsECQD5j4eWyByWn6COTINcfjYTHzKaV gA9xDe2al4zycunM+3RvSntot2U+dTqOYIP92ddgOlJxY1MA28qUzkcJy8vMe4Kdp 9O6+tWODD6os4Xgi/1GXX9QmclY7jwH8p4b6Pd1rZkY6a+zyYu/GkkT2/evYnf96C C4DO7flN1bKRjvQ8vthQvYWReYzPt1xCrIfpsMP+EVHHRL+lcU5O1a6rCazbudTj1 u96tc87XWZtp2GbQ4Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.91.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MnX17-1s8z2l3BMz-00heVG; Sat, 21 Sep 2024 14:04:10 +0200 Message-ID: Date: Sat, 21 Sep 2024 14:04:09 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/3] ath6kl: Omit a label in ath6kl_sdio_power_on() From: Markus Elfring To: linux-wireless@vger.kernel.org, James Minor , Kalle Valo , Krzysztof Kozlowski Cc: LKML , Steve deRosier , Julia Lawall References: Content-Language: en-GB In-Reply-To: X-Provags-ID: V03:K1:TDUV9U6gQOqxrKmW9o59nvLv9E4o2pQmEQ3E9hKDGagv8IpMPo7 QtiHVlTAYg+P0aLksAr70DZDsJVrIy0KjzhXKKqHu1vy41cnk/dx+PXiFNFs580ghPNKPii v8zakZQzVqrVMUtvjiQZyBPGWYMAfFVRji8lOCov3ZVdqoEfvZ7zf/ODptFVEKnD/9RIYgO 91GXsUY1rCa9c8l4IcD6Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4RUt3BWjUFo=;XVGyb+3wc7uW2QVYBkEr0Yey1k6 5Eb4DHu6qD9owH3Al4m41moThfiV9Anai7y0nFX8y7VDemjvu7aafMy2Aum8LCQH+z5hACH8S jmwlTOzD8E8BbZkuWIeQDGnFrfN0ED4w/ISWYa54xxWscTWkBl1etGqJZu1AxE1xnzrHONAS+ umYNxjx12CQcwajAnHuFHcj8PRfeeBeSK6/OmRXTy1Y4enWbBkO307NO9nb5lpjSzkZbuXmnv +YvY5uOyhwuUc/NSHkcOgDaCFYbyQNl6CsLqweTc1N72fW8uIvyDPfmoTOj+nGDrLU9oy6B9o i9b6RSQgRGmBjBpXc9uxUMFF+Ylt7a1ZEiTsQIJeN4wcBeyT12kNotsRHpq+muhSFCsXtz/PB NIz5uVEd2I6UiIVx7FtMWb7TVvxai2bcXgNgkw/3nD9Dh27c+Kmv4tvmQZwa3K8R93jKL+Wp8 AeR/c9FVKda3piomxPhhVPZZMY4eIGumlZM8hRab+XDNWwnlNf883p/k/SgFnrWLtAkyUWWQz aQ673U74bQKBhdh2/Y047KR5HGeURhCJwOzHDeQGy1szY5jZxrO6JchLstYvW8ZncddREBLm3 4vva5NVF30IOg6+GIFeKvjA+75rK4Y0CgocDQKIzXr2CwT2Vlf04LCgP/F9GTZV1h9E4PeaOf 14AhnG5fqZ54+3WXV3WiKErsuhxzer+pzbynDA3Bd23S3IedDz9h69mwDPh61RSdvVmYH7Y9F jsPRMIFjI/pkA32H0oMB/PKTR1VVL0THIgYSGTtOLdR+jHmAu3vapwIKAN5tEdJBw/f/9ZcIo unT9kJ26SAzs893/zg1GKgQg== From: Markus Elfring Date: Sat, 21 Sep 2024 13:04:19 +0200 Delete the label “out” so that this function implementation becomes a bit more succinct. Signed-off-by: Markus Elfring --- drivers/net/wireless/ath/ath6kl/sdio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.46.0 diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index 5106c6909dc8..e4d15cc9b36c 100644 --- a/drivers/net/wireless/ath/ath6kl/sdio.c +++ b/drivers/net/wireless/ath/ath6kl/sdio.c @@ -529,13 +529,11 @@ static int ath6kl_sdio_power_on(struct ath6kl *ar) ret = ath6kl_sdio_config(ar); if (ret) { ath6kl_err("Failed to config sdio: %d\n", ret); - goto out; + return ret; } ar_sdio->is_disabled = false; - -out: - return ret; + return 0; } static int ath6kl_sdio_power_off(struct ath6kl *ar) From patchwork Sat Sep 21 12:06:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 13808908 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D771038FAD; Sat, 21 Sep 2024 12:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726920391; cv=none; b=tpRfqGLiwbCOTRryzTF5KArABWGfUMzTPVnToAYEg6Sq58spPZQGgre3elXC7okxYAPAKcHh1U8C2aJb1R0KUlK5eN31vYgBu/7suXrXMUdq0pSLxlQJBFvFEvR2ylCxeZNLLUEFhholsZUcXz9IUc8LaILBWg4Ly5hO1tie7KQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726920391; c=relaxed/simple; bh=zr0gouvj17I6fBXXOtd2ymGKS+xiRy4XeRt48l60BIY=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=BEai0NCPdXKdoOrL9pXsbHuPKn5r5Dg7U4V09k1D/LNNK780LR3dK0535sKJJby3rqYMjq4AkOk66KM81cZmQK/EF+Q27icMAJwcFPB8gHlOoihQr6Rd4rukokHrkwzorAvBXg6RUfpgPrsXvnwz2vJha6JrI7aHtVI/3Wxx83g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=krahBzQr; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="krahBzQr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1726920368; x=1727525168; i=markus.elfring@web.de; bh=TK18ZHNWFJjXGBqBT4dkWADl7TFmWTlo5r5480j6deo=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:From:To: Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=krahBzQrlEQqIsS5yBasyazsIQhK8Ww/AwFRMiL3ajvBut54SdRh3IhAmmrcnLmG f2n+YSzNMQg3CmifnNiAjVoLrAizI4LBFQHiwVlP+EyCUaQ1dUxpxoeBZDsiJtld9 Yl6vrK0q+9blpD8CEXjvNY05EpYaamkCNDyw2R6fKHohKQM1FjO4WtsTNXo0D/jnj LBMA1Z6gug3kNgizg0kVT5ZXFHoLpSK0/0/WiAWu4Sqm4zpBwNggqSQXi1vRZ066E DCSpedcIX0XtxumqkGKoS0pO5UYJQUHPRN0JUfNBr2h3m+4Z+DP0b7JQMSD3EEIa0 RnwvK0Oo8iFxfxZ3CQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.91.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MUl9B-1sRtR31baT-00Osak; Sat, 21 Sep 2024 14:06:08 +0200 Message-ID: <33b08664-fa25-4cef-86b2-49f65b4369c9@web.de> Date: Sat, 21 Sep 2024 14:06:07 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/3] ath6kl: Reduce scopes for two variables in ath6kl_sdio_power_on() From: Markus Elfring To: linux-wireless@vger.kernel.org, James Minor , Kalle Valo , Krzysztof Kozlowski Cc: LKML , Steve deRosier , Julia Lawall References: Content-Language: en-GB In-Reply-To: X-Provags-ID: V03:K1:99V4E3mGFuvjnUZkMhWYuj/BeKN26mTx+uQu6VxiEI1CP8OfQ8c puhfxyJrZLsj4yqNsEL6q0grzKYo8p3C3q/zJ5UcAJOPY93y0WI1B5tLLq0niKBcbAbkBAJ tXZ9UKnYZzCMDnQ7beLyMEifzV4SZp0Jc51PIIlkQxSO7jgFL6dTz0y7vemfZgtclYpErR3 6DvK52caKuOWlWBaopYow== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:fG7TVt/+ZC0=;kRVzu2eNJ1b31ZuzA6D0ZqV8FDh XavHzTx7p6cz/UALvWLtJZcr0CiWRlRZIarktZiOhtJt38mGJkGvQsZS0nHABs5ABHy4iT0yF vwwkirYMZvlkAGNqLIwMqQ9WUkheHKVS6H9v0MLteCJxBXZA4GGBUtLmB7fDVQuuQxEGHQmZk MBMZjdWADy7AJxvPtLNmTM9AaK6PLfY0RUzEsXpn07cdDs7Nncl+es20I2kjFZn4lVZGpXoqx EOjsUd0rG829Wx4rub81t4J/Gv0Rn7W7JvDSzUaujNTp95aJ92D+Lg2rYtkQuYsMJiDpp2qqG UAlZl0oVfpmBA8ozmYo+OeQ0AWPDd4xgjvuKFuxCpT8fC6OQaxYUhE+v+nCE1xcQVzKyyAXEJ nLLd9mMssQ2kA4CN7l6i8eSvjMCFKKmrtpOFNdgrho51dtQmO/QEUEOGEMpua1yVaTIE5n1KV YlREskaCuz3GGeRoezKEQbKFEA1lx0Bg43niRoV1j9/BqSrGsB4aTyRdPJsHtC5zylfUjJmDV oqNgKTQCAVKCNYKmFaffFalSAXi/TGmR722D1BGjDCY2NEtHTtNmkBT5Vf15I6y770nAQ0M2t J1TMYeGxITP7yRV38mZVL5Br8dOz0FHH4fQTLd2CyG9uN25VAZaB7qri+AT5BnteVxrgQw2/S kCjoFE0KO/iCDD8qNtWYms9knbaGO9ZUanVkc1CPYrlmfpJzwC+EBJ2DPnxHkXYE3oLiGZbNs jLuV5VmD61WqFVmEKhKelUGjyB1sdtoymTbrCLCkifTPhlaFBrjDC6ToHe/T1Yn5H0KAC1y9q 8dL7WApqdGKsKdStE3la1IjQ== From: Markus Elfring Date: Sat, 21 Sep 2024 13:30:48 +0200 Adjust the definitions for the local variables "func" and "ret" so that the corresponding setting will be performed a bit later. Signed-off-by: Markus Elfring --- drivers/net/wireless/ath/ath6kl/sdio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.46.0 diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index e4d15cc9b36c..689f83f6bce5 100644 --- a/drivers/net/wireless/ath/ath6kl/sdio.c +++ b/drivers/net/wireless/ath/ath6kl/sdio.c @@ -503,17 +503,15 @@ static void ath6kl_sdio_irq_handler(struct sdio_func *func) static int ath6kl_sdio_power_on(struct ath6kl *ar) { struct ath6kl_sdio *ar_sdio = ath6kl_sdio_priv(ar); - struct sdio_func *func = ar_sdio->func; - int ret = 0; if (!ar_sdio->is_disabled) return 0; ath6kl_dbg(ATH6KL_DBG_BOOT, "sdio power on\n"); - + struct sdio_func *func = ar_sdio->func; sdio_claim_host(func); - ret = sdio_enable_func(func); + int ret = sdio_enable_func(func); sdio_release_host(func); if (ret) { ath6kl_err("Unable to enable sdio func: %d)\n", ret);