From patchwork Mon Sep 23 03:10:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kandpal, Suraj" X-Patchwork-Id: 13809243 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22126CF9C6C for ; Mon, 23 Sep 2024 03:12:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9084410E0A8; Mon, 23 Sep 2024 03:12:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SCwK//3q"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id E260210E0A8 for ; Mon, 23 Sep 2024 03:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727061168; x=1758597168; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7jHUGuDahRNdnifskPvR+jYWGIgmNod7c9WeAihQf3c=; b=SCwK//3qbMHr0MZJt8vipLdmwKHhT7AxOJ2etySmuixTHfZXa8VICixs uytrAs3BeJgpwpUuk7pLc0MoFiCkMKFG0kO2NBSOM4vicbekA9olyrH2O Pyhjialf6DXdsRCT5cddIqbCmezxWmHNYUE8LXLBLuC0IZF+g48pPkdUW kQ/snEhLjFNOMs5ZfAuMaFo3yoN5OpE/Yb5kcn7ELqq68kwVZFiFqy8kG BSrcy/7SX0I/SN2ZbQUcbxaMTSRtPDKDo7cSWenbOG43XoJTyKkwRlUuz iQq5n9MkmQHwdgEYm3U/c4J30dsMiTi/muAaylpXsJ96YSDlPMR8Sbrdp A==; X-CSE-ConnectionGUID: 9WczBjqESh6LR1CjkTloMA== X-CSE-MsgGUID: h7HBc6UwQ8yENUfC9xNIEA== X-IronPort-AV: E=McAfee;i="6700,10204,11202"; a="26110935" X-IronPort-AV: E=Sophos;i="6.10,250,1719903600"; d="scan'208";a="26110935" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2024 20:12:48 -0700 X-CSE-ConnectionGUID: M0IK9EGkQC+tTO4qjLM4Gg== X-CSE-MsgGUID: bdo5cTSZSoaJLXb9qbnKAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,250,1719903600"; d="scan'208";a="70510764" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.32]) by fmviesa007.fm.intel.com with ESMTP; 22 Sep 2024 20:12:46 -0700 From: Suraj Kandpal To: intel-gfx@lists.freedesktop.org Cc: uma.shankar@intel.com, matthew.d.roper@intel.com, Suraj Kandpal Subject: [PATCH 1/2] drm/i915/hotplug: Reduce SHPD_FLITER_CNT for DISPLAY_VER() == 12 Date: Mon, 23 Sep 2024 08:40:07 +0530 Message-ID: <20240923031007.1058072-3-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240923031007.1058072-2-suraj.kandpal@intel.com> References: <20240923031007.1058072-2-suraj.kandpal@intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Reduce SHPD_CNT to 250us for display version 12 as it lines up with DP1.4a(Table3-4) spec. --v2 -Update commit message and comment [Matt] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hotplug_irq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c index 2c4e946d5575..8427386132e6 100644 --- a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c +++ b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c @@ -849,7 +849,11 @@ static void icp_hpd_irq_setup(struct drm_i915_private *dev_priv) enabled_irqs = intel_hpd_enabled_irqs(dev_priv, dev_priv->display.hotplug.pch_hpd); hotplug_irqs = intel_hpd_hotplug_irqs(dev_priv, dev_priv->display.hotplug.pch_hpd); - if (INTEL_PCH_TYPE(dev_priv) <= PCH_TGP) + /* + * We reduce the value to 250us to be able to detect SHPD when an external display + * is connected. This is also expected of us as stated in DP1.4a Table 3-4. + */ + if (INTEL_PCH_TYPE(dev_priv) < PCH_TGP) intel_uncore_write(&dev_priv->uncore, SHPD_FILTER_CNT, SHPD_FILTER_CNT_500_ADJ); else intel_uncore_write(&dev_priv->uncore, SHPD_FILTER_CNT, SHPD_FILTER_CNT_250); From patchwork Mon Sep 23 03:10:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kandpal, Suraj" X-Patchwork-Id: 13809245 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F37E8CF9C70 for ; Mon, 23 Sep 2024 03:12:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1E8410E361; Mon, 23 Sep 2024 03:12:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JdFKtzjw"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86A8E10E35F for ; Mon, 23 Sep 2024 03:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727061170; x=1758597170; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Os+asMlziseSqaTpxcygTo6mzkYzD6y0fT5NONbSOcY=; b=JdFKtzjw1VivxHUkh42mOM++XzbjlpyMULcw2qvUcLw4woXtV7lDaSRn Sr6yu+qfkwrnEisMKUYa6cR3+/UydMhIsCah5GFCuVkEfKKf+QUidlMWO c52jsURFGYHf30YKwAA/WUDUGgR6/aVJzj5wNC4T0m5ZWm+qzP/GWclnn sjj6XCHFJXfhaC/5QVP2H4fnn4RC1uIdXKWokMupProKOIBt1dqvQ4Y40 6y7JTD/CBH43v0kklrsuQTJ/q6iCv/l0Uv5gfEBYKP0XRwyE8QzcR6h6H LIx/LbGYBpLjb1rXRK9sPx4HXGhjJHoZz8dxm9cGnSRo77wT9/UMToUSg w==; X-CSE-ConnectionGUID: 69cic56fS7yWIoOkxZ78Xw== X-CSE-MsgGUID: JIjM+Ip9SJCZ5UAQaIVX1w== X-IronPort-AV: E=McAfee;i="6700,10204,11202"; a="26110937" X-IronPort-AV: E=Sophos;i="6.10,250,1719903600"; d="scan'208";a="26110937" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2024 20:12:50 -0700 X-CSE-ConnectionGUID: 1GKUyuJlQoeTqdXasjQdUg== X-CSE-MsgGUID: WibXxybRTiWfmFz9mUNWRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,250,1719903600"; d="scan'208";a="70510769" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.32]) by fmviesa007.fm.intel.com with ESMTP; 22 Sep 2024 20:12:48 -0700 From: Suraj Kandpal To: intel-gfx@lists.freedesktop.org Cc: uma.shankar@intel.com, matthew.d.roper@intel.com, Suraj Kandpal Subject: [PATCH 2/2] drm/i915/hotplug: Add comment for XE_LPD+ SHPD_FILTER_CNT value Date: Mon, 23 Sep 2024 08:40:08 +0530 Message-ID: <20240923031007.1058072-4-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240923031007.1058072-2-suraj.kandpal@intel.com> References: <20240923031007.1058072-2-suraj.kandpal@intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Add the reason for having SHPD_FILTER_CNT value for XE_LPD+ and above as 250us instead of 500us. --v2 -Update commit message [Matt] Signed-off-by: Suraj Kandpal Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_hotplug_irq.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c index 8427386132e6..f28f35121e5a 100644 --- a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c +++ b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c @@ -1064,6 +1064,10 @@ static void mtp_hpd_irq_setup(struct drm_i915_private *i915) enabled_irqs = intel_hpd_enabled_irqs(i915, i915->display.hotplug.pch_hpd); hotplug_irqs = intel_hpd_hotplug_irqs(i915, i915->display.hotplug.pch_hpd); + /* + * Use 250us here to align with the DP1.4a(Table 3-4) spec as to what the + * SHPD_FILTER_CNT value should be. + */ intel_de_write(i915, SHPD_FILTER_CNT, SHPD_FILTER_CNT_250); mtp_hpd_invert(i915);