From patchwork Tue Sep 24 13:00:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeongjun Park X-Patchwork-Id: 13810929 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3514CF9C6B for ; Tue, 24 Sep 2024 13:01:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39E8D6B008C; Tue, 24 Sep 2024 09:01:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34E446B009A; Tue, 24 Sep 2024 09:01:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2162D6B00A3; Tue, 24 Sep 2024 09:01:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 035116B008C for ; Tue, 24 Sep 2024 09:01:12 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 82966161A51 for ; Tue, 24 Sep 2024 13:01:12 +0000 (UTC) X-FDA: 82599642384.28.4237F9F Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf20.hostedemail.com (Postfix) with ESMTP id 9EFB61C0012 for ; Tue, 24 Sep 2024 13:01:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Isr5DHpa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of aha310510@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=aha310510@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727182739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=jOHx3jt17bRvX9omo0JNdSDeC4C6PZPInAKFhyka334=; b=E7UkGxfK2yY+ckvYDnHNIb+iQlEiDfsPGUZKSTBKIIjoO1KKIu2Sl8YjhNZU8LKq3OGIlg jp0bQI8Y8GNp8Iglib4wusy8jywGD2qDHyg2/MCpTCvnxE/N1DwDjznNmtVwYQV0Noipl9 aVWUxBrwLGsGbY96YzJfuihehEXo7+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727182739; a=rsa-sha256; cv=none; b=qaFEl5+4X2Uk76E8GvhQ5ghKPeyORWZPkxabLLAymjjdHeAR4EOS7ntffM8JCi6CEFjF2K 7qpvshAd7bnAAOsuxOl4tutvC+x1/Jr/l3mvyxxeq8gQmiKUgKPbWnoP8ligGaD9oA5ZJu JKyw6k5ghCk7SAykXx5bCb1tSew3LEs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Isr5DHpa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of aha310510@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=aha310510@gmail.com Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2059204f448so47219775ad.0 for ; Tue, 24 Sep 2024 06:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727182869; x=1727787669; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jOHx3jt17bRvX9omo0JNdSDeC4C6PZPInAKFhyka334=; b=Isr5DHpa1i+7x4ZUJ/bPit+YdszwUiubGEl87F8qIJxn2A00hhtOmjml+E0lhPCDaX EoRpimJcDE05nu13uJdzhQ4VizshQj8Fml3nTLeJnkKd8oLsqdUQUPlTk9XqtKLSlmR7 MuB7ehqMS+koj9g5OgpiOZMq6yoTtU7nOZ2rSdpJRGErNVhMlVOdroBLtF3kStMRQF3h +Im+DyYdSneNvaPRN+fZfk4LRYYcmwHL39Y3WHGto2NOKwMPX5IoLPudj5ZIYC7j6tpB Jtkqkb0J6zJbtC4hwLH7PvfGvhnL7h6EjTE9NCpk+6LM9zU7qVAddJPfy0ik+Xqc7c6e jjFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727182869; x=1727787669; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jOHx3jt17bRvX9omo0JNdSDeC4C6PZPInAKFhyka334=; b=vMVTncnfuxJGkclIb/BH1PkQDw2CajmblBrrnxEbHQBi3vJ03PgiDJHqhsqvWlEUnn s/YUutmVlAqvlYU6zUjKud0Q8T7AEc0K4XUXytbe9Db549UY34LiGUmZPdIW1yXTjoor pGE7QC+KmWMii06wtkyGhxD4DaZ74/pXARggTrIIxOaKZGcBygAcusD3Sfa55VybUlNR k7fiWC2wiEqYdkcJFMCXGkoLsfL2Gz375WDAiyV8CDEhr9bcJ3zBZw9PaYL9OKRGNjjx AvXveMaEhG2MaIovjNtogmqoPddtN0KhNsNh24CeH4iUc6OGPZ2AVBNxFIgB3aO47/PV JRyQ== X-Forwarded-Encrypted: i=1; AJvYcCWYmioR8yOmAJD4JCy75TB50naNhnYLFoMYDkL/hwWvl9UQu0ew3Tiulqu32zLIPysPTklmz3Ieeg==@kvack.org X-Gm-Message-State: AOJu0Ywgbt2wUM0mSlY9r8W5xQWvIxvd8RQurBbK9xJWr6wISe1vaYk8 jHffaYIzJZAd/3J+C1Ihp6ejUSAcdbntaCq3VfC6Fz1ydZ5bbISn X-Google-Smtp-Source: AGHT+IFi/yOofOOt9bF3sPPRxdrO5yL/oo6fP1unaQK+KC7RWRazovhiSEyZuzaNmKxTi8Xi8+MP/g== X-Received: by 2002:a17:902:ea03:b0:205:4a1d:ba37 with SMTP id d9443c01a7336-208d986a5a7mr209150565ad.38.1727182868925; Tue, 24 Sep 2024 06:01:08 -0700 (PDT) Received: from kernelexploit-virtual-machine.localdomain ([121.185.186.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20af1822c43sm9983085ad.193.2024.09.24.06.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 06:01:08 -0700 (PDT) From: Jeongjun Park To: akpm@linux-foundation.org, willy@infradead.org, david@redhat.com Cc: wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot , stable@vger.kernel.org, Jeongjun Park Subject: [PATCH] mm: migrate: annotate data-race in migrate_folio_unmap() Date: Tue, 24 Sep 2024 22:00:53 +0900 Message-Id: <20240924130053.107490-1-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9EFB61C0012 X-Stat-Signature: bdxqzx41pb9kjmeqpwoatdubrh389uyb X-Rspam-User: X-HE-Tag: 1727182870-964148 X-HE-Meta: U2FsdGVkX19jLa0JD1YC99L06SGFnafv8llSv8wg5Meu4VsPd48Eg8IMXyXoNQRFQXF5MQteUIoaALKcfvymQelguQDnt/xjY/XkA9FU8Oo1K7do9F06HMmtIHM5X1P6UXF5fGYZT3HeZZrkAHCUsVzO+/wwxOdzrNzarpJtUNa4cJ4Ojp9FVbf2o0f5Q8dyjdVnnfXYyAveH8MGQbTuHFYXS+p9t4alT4sV0AYlGn6puteTSmME/za6mc5xaYpB8CW05UydcQAumqrvlpOjbXRV5ayZEsmbivUcqBJdDnZhCZFNndiTNyiXV2j7Hv8dtFAhKVCJl2ZFzTbNaSf+eeV7mWKn3bf2Acf7pC3Ea4I1KPy5RGKmOYFs/PwXgBbHvrl06kc0X7xPzzz3y5Y0+g+nevWZplRRi7/v0TWfpgNZAu9Sy4UJuJQAhAl7HUpjJSWNpjJVMTpKtG7gugxYdF+iYm1hgk+Ii9nYU1OywLLL32W3dOtIZzr2rdPt1uS6OkGkNZIAZTlLD8j6D9T6IGB/gZvgNN/R5Osnw5YWetBErjD/i76QCrIbJubsIYQ7UhjV8G3817Z2Hy6DjnEZT9GYpTg0lXMV/qMUmKr+unRQx+N5TtMIoqN67SUw6eZip8MU+V8gGpkUcDTQHHc+Oky3NH58ABBHSBjuMyzh/ZJtjHU+cbfSEAOccd1Zo8yFutKSqrdCUAT54jlUvX5qyZfc/uXzIv3F5u70mVGLT4TdHhn/OuLQZnJ/G2HO3O+q+tIgzYLP+3pF3DT+EW/Lf2IWkfKJBl1SZaEm84XwYuMZ88jNlJw1fuQEdIYRm60oxPyTC4GnbpMaN2A6jP8cAFEi9qZPczBY+L7nvLNmMAI2MV0wjRKx2/4ga+TL/KmwmilI6GwBDz/ve/QEqgyD9EAImft13IbLAcm4fXrO+hWN35y2yvL7XcIFfWuRMYFyl88simhd/1t80pb2haT vRh/Hvh2 T9eDb0g7uYDclZWNxzyRpJNwUKhElj1CpFyFGwHf2eE5EHcWhYphj6c4uh9cY8l8qvc7aNdadQbnQlWwuvAVUkHrLuM5cscpv4LCFQVpy3AWvRNRxnjum3uoErXaq2lVSLmDYrr+XqiPj/hkutSp6hZNs6bmsaopx/0tA4IJNPkpYihtOsNT6eN+1jH1bqExTbcWDPCN9Db4BC4j3sR+pWEeND2erOn4KEDIpOt/y1cEmL1Fm5uTMDfC/D/lKEQlY3j8z7T76VGwrszYi0V/TIFzMpXiadUS7DRTAQaHr2nQtY5uARH63AftpdovNVo8bxGr+eM4VHoojgJuqk4DQETdrinsN8FT+qIPvu8kbeWCxkI1P2dkeIgIjis1YMQdWMa4wNdPSZeQRzpF8CidtJSZnXy8fkxtA2/DEfJ/6M5utXeTcE0OpuKiR6vdUveoo53+EQdBT1rHr+wfNQjSkwsAe6j1oHpunld20mBeT/q07LYSFfilUpWdkfQJIuINedAh7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I found a report from syzbot [1] This report shows that the value can be changed, but in reality, the value of __folio_set_movable() cannot be changed because it holds the folio refcount. Therefore, it is appropriate to add an annotate to make KCSAN ignore that data-race. [1] ================================================================== BUG: KCSAN: data-race in __filemap_remove_folio / migrate_pages_batch write to 0xffffea0004b81dd8 of 8 bytes by task 6348 on cpu 0: page_cache_delete mm/filemap.c:153 [inline] __filemap_remove_folio+0x1ac/0x2c0 mm/filemap.c:233 filemap_remove_folio+0x6b/0x1f0 mm/filemap.c:265 truncate_inode_folio+0x42/0x50 mm/truncate.c:178 shmem_undo_range+0x25b/0xa70 mm/shmem.c:1028 shmem_truncate_range mm/shmem.c:1144 [inline] shmem_evict_inode+0x14d/0x530 mm/shmem.c:1272 evict+0x2f0/0x580 fs/inode.c:731 iput_final fs/inode.c:1883 [inline] iput+0x42a/0x5b0 fs/inode.c:1909 dentry_unlink_inode+0x24f/0x260 fs/dcache.c:412 __dentry_kill+0x18b/0x4c0 fs/dcache.c:615 dput+0x5c/0xd0 fs/dcache.c:857 __fput+0x3fb/0x6d0 fs/file_table.c:439 ____fput+0x1c/0x30 fs/file_table.c:459 task_work_run+0x13a/0x1a0 kernel/task_work.c:228 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0xbe/0x130 kernel/entry/common.c:218 do_syscall_64+0xd6/0x1c0 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f read to 0xffffea0004b81dd8 of 8 bytes by task 6342 on cpu 1: __folio_test_movable include/linux/page-flags.h:699 [inline] migrate_folio_unmap mm/migrate.c:1199 [inline] migrate_pages_batch+0x24c/0x1940 mm/migrate.c:1797 migrate_pages_sync mm/migrate.c:1963 [inline] migrate_pages+0xff1/0x1820 mm/migrate.c:2072 do_mbind mm/mempolicy.c:1390 [inline] kernel_mbind mm/mempolicy.c:1533 [inline] __do_sys_mbind mm/mempolicy.c:1607 [inline] __se_sys_mbind+0xf76/0x1160 mm/mempolicy.c:1603 __x64_sys_mbind+0x78/0x90 mm/mempolicy.c:1603 x64_sys_call+0x2b4d/0x2d60 arch/x86/include/generated/asm/syscalls_64.h:238 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xc9/0x1c0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f value changed: 0xffff888127601078 -> 0x0000000000000000 Reported-by: syzbot Cc: stable@vger.kernel.org Fixes: 7e2a5e5ab217 ("mm: migrate: use __folio_test_movable()") Signed-off-by: Jeongjun Park --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- diff --git a/mm/migrate.c b/mm/migrate.c index 923ea80ba744..368ab3878fa6 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1118,7 +1118,7 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, int rc = -EAGAIN; int old_page_state = 0; struct anon_vma *anon_vma = NULL; - bool is_lru = !__folio_test_movable(src); + bool is_lru = data_race(!__folio_test_movable(src)); bool locked = false; bool dst_locked = false;