From patchwork Tue Sep 24 19:41:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Remi Pommarel X-Patchwork-Id: 13811138 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from e3i110.smtp2go.com (e3i110.smtp2go.com [158.120.84.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B422D41760 for ; Tue, 24 Sep 2024 19:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=158.120.84.110 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727206846; cv=none; b=fIrRQbiVJEykjRQJ2+zefJGC2pBtLnMbq2wSP479tx0tFnoZms+4p2pO1Bfa93LMKL73P5PTEQNbozkFuUrFTUYFZFa6QFIEr4+rBiEpBOF8Ya4HJnTV/bKplgmBt3x53NI0ViBCfvNNt7RCR5X7zj0stQmRR+Wf8uIDfRGVgJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727206846; c=relaxed/simple; bh=bv6/yP+3GsD9E4dCyFq3/EAghWl1KfvjbhuV5oaCHAA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uJMVuCwTwluL5aALQV5sdgIS07ij6lbwczM5l/rsyAXD1GQr/887Ts0QKUFyKmcpQngmmlTMZbLo75bOu/V+IQKHiEo7LtsOFw8PocaY3+aPsBQlJ7eev+kgbh67U66Xe0mpfUXaQLlzRsCrEveng7+PuaguED3JXs3XZeir6mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt; spf=pass smtp.mailfrom=em510616.triplefau.lt; dkim=pass (2048-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=tNa38AHu; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b=UoTsFJeh; arc=none smtp.client-ip=158.120.84.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em510616.triplefau.lt Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="tNa38AHu"; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b="UoTsFJeh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smtpservice.net; i=@smtpservice.net; q=dns/txt; s=a1-4; t=1727206841; h=feedback-id : x-smtpcorp-track : date : message-id : to : subject : from : reply-to : sender : list-unsubscribe : list-unsubscribe-post; bh=ZAFC15upJHpYWIyEc4vqiTRRNBTzf2DlM6fPlb+qayY=; b=tNa38AHu8kFCSOk1YpxAIdZ/tSCfBLVkrv1fR8pzL+f4kzR9S4sWIbCHgAYnGjWEpuTJP o5dczZs9+dhC5ZWJdr7eB10zSJ5gVRofXnlE9aTJFU14aVSbRNK0vos6PrAWbIye0/6LUmY sAd31dnxubJa6LPvn0R5ENaej8KirV1uTJ50uVBDt6ZlP3kaBglShzGLW/2aAj9eZBT2otx 5ZARkr7RewXZFVYGFwFZdavNsV7KPlxbwYk+7fudeNv6ujkUfGtNBhCzzv+lnG02L50ea+R kq5GTRn8OKgARDMOi2vTZd6vU1fH+JSefX0Z+9EtTQjnAR72Vr93OgQf/DxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triplefau.lt; i=@triplefau.lt; q=dns/txt; s=s510616; t=1727206841; h=from : subject : to : message-id : date; bh=ZAFC15upJHpYWIyEc4vqiTRRNBTzf2DlM6fPlb+qayY=; b=UoTsFJehudssggHNTyOgBxxLlzrhJ2abvJgm1PoNPzmKjbI19WZbC/pk7pVEPpPcdyR9i RlJ+o/fGrMS//lHeGd2x77Fj8Xfxm9pfPDoeRqQ2F2WFXQk+dMX19onPAJsUv1aeVanzv4G bxiX9+XsAZCUXZlpfKVM58GvpwGrTOL4vVitEg+VABohbFA7z2yxu79+FvZB0reA840i9v6 jvDYf7x0BB5zO6i4Bd+GRKn4DeFxPt8vzfcyltoZNUqHUbutmXZqAjykeKVguh72s8jEXeI 7LPeRdyAOYjUgupy8JeaEvxm05H5nE4m0aXNiYgewHlOmEvOmmKGjwBwQf9A== Received: from [10.12.239.196] (helo=localhost) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97.1-S2G) (envelope-from ) id 1stBOo-AIkwcC8mZ9b-HsRu; Tue, 24 Sep 2024 19:40:38 +0000 From: Remi Pommarel To: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kalle Valo , Jeff Johnson , Praneesh P , Remi Pommarel Subject: [PATCH v2] wifi: ath11k: Fix invalid ring usage in full monitor mode Date: Tue, 24 Sep 2024 21:41:19 +0200 Message-Id: <20240924194119.15942-1-repk@triplefau.lt> X-Mailer: git-send-email 2.40.0 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Report-Abuse: Please forward a copy of this message, including all headers, to Feedback-ID: 510616m:510616apGKSTK:510616sosVF_l1gq X-smtpcorp-track: bIuPsYZBupU5.Uopk879wKHN5.1oeEtgxKn2l On full monitor HW the monitor destination rxdma ring does not have the same descriptor format as in the "classical" mode. The full monitor destination entries are of hal_sw_monitor_ring type and fetched using ath11k_dp_full_mon_process_rx while the classical ones are of type hal_reo_entrance_ring and fetched with ath11k_dp_rx_mon_dest_process. Although both hal_sw_monitor_ring and hal_reo_entrance_ring are of same size, the offset to useful info (such as sw_cookie, paddr, etc) are different. Thus if ath11k_dp_rx_mon_dest_process gets called on full monitor destination ring, invalid skb buffer id will be fetched from DMA ring causing issues such as the following rcu_sched stall: rcu: INFO: rcu_sched self-detected stall on CPU rcu: 0-....: (1 GPs behind) idle=c67/0/0x7 softirq=45768/45769 fqs=1012 (t=2100 jiffies g=14817 q=8703) Task dump for CPU 0: task:swapper/0 state:R running task stack: 0 pid: 0 ppid: 0 flags:0x0000000a Call trace: dump_backtrace+0x0/0x160 show_stack+0x14/0x20 sched_show_task+0x158/0x184 dump_cpu_task+0x40/0x4c rcu_dump_cpu_stacks+0xec/0x12c rcu_sched_clock_irq+0x6c8/0x8a0 update_process_times+0x88/0xd0 tick_sched_timer+0x74/0x1e0 __hrtimer_run_queues+0x150/0x204 hrtimer_interrupt+0xe4/0x240 arch_timer_handler_phys+0x30/0x40 handle_percpu_devid_irq+0x80/0x130 handle_domain_irq+0x5c/0x90 gic_handle_irq+0x8c/0xb4 do_interrupt_handler+0x30/0x54 el1_interrupt+0x2c/0x4c el1h_64_irq_handler+0x14/0x1c el1h_64_irq+0x74/0x78 do_raw_spin_lock+0x60/0x100 _raw_spin_lock_bh+0x1c/0x2c ath11k_dp_rx_mon_mpdu_pop.constprop.0+0x174/0x650 ath11k_dp_rx_process_mon_status+0x8b4/0xa80 ath11k_dp_rx_process_mon_rings+0x244/0x510 ath11k_dp_service_srng+0x190/0x300 ath11k_pcic_ext_grp_napi_poll+0x30/0xc0 __napi_poll+0x34/0x174 net_rx_action+0xf8/0x2a0 _stext+0x12c/0x2ac irq_exit+0x94/0xc0 handle_domain_irq+0x60/0x90 gic_handle_irq+0x8c/0xb4 call_on_irq_stack+0x28/0x44 do_interrupt_handler+0x4c/0x54 el1_interrupt+0x2c/0x4c el1h_64_irq_handler+0x14/0x1c el1h_64_irq+0x74/0x78 arch_cpu_idle+0x14/0x20 do_idle+0xf0/0x130 cpu_startup_entry+0x24/0x50 rest_init+0xf8/0x104 arch_call_rest_init+0xc/0x14 start_kernel+0x56c/0x58c __primary_switched+0xa0/0xa8 Thus ath11k_dp_rx_mon_dest_process(), which use classical destination entry format, should no be called on full monitor capable HW. Fixes: 67a9d399fcb0 ("ath11k: enable RX PPDU stats in monitor co-exist mode") Signed-off-by: Remi Pommarel Reviewed-by: Praneesh P --- v2: set ppdu_status to DP_PPDU_STATUS_DONE as suggested by https://lore.kernel.org/ath11k/d376023d-267a-4512-8749-f816fefeb842@quicinc.com/ drivers/net/wireless/ath/ath11k/dp_rx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index c087d8a0f5b2..40088e62572e 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -5291,8 +5291,11 @@ int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, int mac_id, hal_status == HAL_TLV_STATUS_PPDU_DONE) { rx_mon_stats->status_ppdu_done++; pmon->mon_ppdu_status = DP_PPDU_STATUS_DONE; - ath11k_dp_rx_mon_dest_process(ar, mac_id, budget, napi); - pmon->mon_ppdu_status = DP_PPDU_STATUS_START; + if (!ab->hw_params.full_monitor_mode) { + ath11k_dp_rx_mon_dest_process(ar, mac_id, + budget, napi); + pmon->mon_ppdu_status = DP_PPDU_STATUS_START; + } } if (ppdu_info->peer_id == HAL_INVALID_PEERID ||