From patchwork Thu Sep 26 09:03:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Dahl X-Patchwork-Id: 13813077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20775CCF9E9 for ; Thu, 26 Sep 2024 09:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=YerQMbh2SXmIPNoVbAJiCzp0lKj3lArlIsJMwwpDYQk=; b=TBGJqNfepwuny6 YR6cCX62kQqrMS3JjkblNJ973fexZGxCga8yh6vsuciXLiOdWp+U4FuO2Z3wAoNVpyxAeA1KbISh3 VadTmwBrIUalS58UFd2YpCHfYcwFaztqfgZeH/WSwdKoH5wjRHU6WFUWn4KlJWF8mf4dX4JuXemoS 2cAkxkYoiYpHg5tEbD4SrmimyHRRwnCGRzYaRWXgSEKlxY1ptdSxjnYBy8DeQ3AM4Kn81sZ3vNcT7 m4sTh7mHtZKiePN8TItaGcrp2WTQ38APUGwO2kyfhfEpBDe/VZD3YjNw7WEOBJGBC1+PdZgxZJGMi DLBIMEs2kEnsy6k9iiUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stkV8-00000007olb-14my; Thu, 26 Sep 2024 09:09:30 +0000 Received: from mail.thorsis.com ([2003:a:e28:26e4::10]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stkPt-00000007nYt-1gDk for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2024 09:04:07 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 20BE91486845; Thu, 26 Sep 2024 11:04:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1727341442; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=YerQMbh2SXmIPNoVbAJiCzp0lKj3lArlIsJMwwpDYQk=; b=SANw2WbDEm9YDkv+7rROoSh+Wg5RCiKUYSU2FODxpwqDzTZFJqJAcSDo9uAAfW2q8xn5Fc cf0r8NQ2eAp0MMwOcDBKnA9MSk32ohBtXJYT8mMeRG42anlpZiE/sYb+TRFKXn8BHOlq4V cv6d2SJ38aMIjnDCClAIOmCgntEjX4x9/O62d5n61PxOnd8+spf52pyl5+PadwoJgmvxAC 8onl71B8nC6aLBttT2BVjdEWNIbZjlmfYUj08MsNjJPyNk5FBYnCPa3K3XfMf5rh+cmdq2 85b250MCLfkyvfKPQ3V/+CiOfLknPlQc8TGYYSIA8y+V06eV9rixH5lylQmYJQ== From: Alexander Dahl To: Mark Brown Subject: [PATCH] spi: atmel-quadspi: Fix wrong register value written to MR Date: Thu, 26 Sep 2024 11:03:56 +0200 Message-Id: <20240926090356.105789-1-ada@thorsis.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_020405_664496_FD588EA9 X-CRM114-Status: UNSURE ( 8.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , open list , "open list:SPI SUBSYSTEM" , Claudiu Beznea , "moderated list:ARM/Microchip AT91 SoC support" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org aq->mr should go to MR, nothing else. Fixes: 329ca3eed4a9 ("spi: atmel-quadspi: Avoid overwriting delay register settings") Signed-off-by: Alexander Dahl Link: https://lore.kernel.org/linux-spi/20240926-macarena-wincing-7c4995487a29@thorsis.com/T/#u --- Notes: based on today's master drivers/spi/atmel-quadspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 11a299a7933e03c83818b431e6a1c53ad387423d diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c index 4f288f07e38f..95cdfc28361e 100644 --- a/drivers/spi/atmel-quadspi.c +++ b/drivers/spi/atmel-quadspi.c @@ -377,7 +377,7 @@ static int atmel_qspi_set_cfg(struct atmel_qspi *aq, */ if (!(aq->mr & QSPI_MR_SMM)) { aq->mr |= QSPI_MR_SMM; - atmel_qspi_write(aq->scr, aq, QSPI_MR); + atmel_qspi_write(aq->mr, aq, QSPI_MR); } /* Clear pending interrupts */