From patchwork Thu Sep 26 12:53:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 13813360 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63EDCCF9C69 for ; Thu, 26 Sep 2024 12:54:18 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.805431.1216522 (Exim 4.92) (envelope-from ) id 1sto0J-00015T-CZ; Thu, 26 Sep 2024 12:53:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 805431.1216522; Thu, 26 Sep 2024 12:53:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sto0J-00013H-9E; Thu, 26 Sep 2024 12:53:55 +0000 Received: by outflank-mailman (input) for mailman id 805431; Thu, 26 Sep 2024 12:53:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sto0H-0000wg-Mu for xen-devel@lists.xenproject.org; Thu, 26 Sep 2024 12:53:53 +0000 Received: from mail137-23.atl71.mandrillapp.com (mail137-23.atl71.mandrillapp.com [198.2.137.23]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60ac2c48-7c06-11ef-99a2-01e77a169b0f; Thu, 26 Sep 2024 14:53:51 +0200 (CEST) Received: from pmta07.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail137-23.atl71.mandrillapp.com (Mailchimp) with ESMTP id 4XDtnp20TWz1XLGNW for ; Thu, 26 Sep 2024 12:53:50 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id fe2bd7a58ced47f285932fb5db668bcf; Thu, 26 Sep 2024 12:53:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60ac2c48-7c06-11ef-99a2-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1727355230; x=1727615730; bh=bqBQgdFu7ue35t1gEEJMNLjaBSVlQaaf2h4TrHlMzIA=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=nFjDeqALLCe4hlD+f1a6Gu+hEzOpHcXdo87mcv9WSYOAbJq2MTvnCAViCVqL8ELeL uDu1i97IH3Kown/JSCfcxZE908ZJMr8H3jcI722ufU9vNQWBCNjJ6dIt+uz95NPKhi EK/33yBaA970PVUag4ZBL2YYhjGjMSK4F9QmlZz8XxdJQ/s0cmE/1RqxWYpeyJwtnn wcXrhMmGTz0MAh7LeLq8SbnZ7T8oeY912DpUu9Y0dGKNX7XN3pB3uvj0D3g7+QqFzs +OkwnDEmp8XwMM8b3tvM2aMzzBS83n1fXPmg3mw8odjzgK/swNKr/Ql1esi4O3QWms uWFb21ZS9aFiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1727355230; x=1727615730; i=anthony.perard@vates.tech; bh=bqBQgdFu7ue35t1gEEJMNLjaBSVlQaaf2h4TrHlMzIA=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=ihqwDZRbi47tsDpw7XvJNeN2Pd7/XQ7PGDRVG5KoVrZhXfyxcDhnuOyjdYnCEiVBm DiRbYR3gPaPkaKVa2tZa5I8vSuQkLKgVvW9zzrn/7yS8vUdxo7JxckTrVXimKGY72p oZEUuKzLbCI1ZtePe2RAmFKVmmdEsmV/ET5EgZHQE/LWYzozEbVMeXUFrQEB6tIpBC pHxji9Hy5Sy7ff3aFHs+Gbrppz4plJ8hZugreZVm+F3lEjS/gGgGbNiPba+M1neTjW BL3i7mZiVd7sJgm6loXsRKNgEusvVodqgCJg9zZk9ZFJy6IZaXTRmBmX7EwbNNuWwP BMRmuArHw4ykA== From: Anthony PERARD Subject: =?utf-8?q?=5BXEN_PATCH_1/2=5D_blkif=3A_Fix_alignment_description_fo?= =?utf-8?q?r_discard_request?= X-Mailer: git-send-email 2.39.2 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1727355229388 To: xen-devel@lists.xenproject.org Cc: =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Anthony PERARD , Juergen Gross Message-Id: <20240926125347.23738-2-anthony.perard@vates.tech> In-Reply-To: <20240926125347.23738-1-anthony.perard@vates.tech> References: <20240926125347.23738-1-anthony.perard@vates.tech> X-Native-Encoded: 1 X-Report-Abuse: =?utf-8?q?Please_forward_a_copy_of_this_message=2C_including?= =?utf-8?q?_all_headers=2C_to_abuse=40mandrill=2Ecom=2E_You_can_also_report_?= =?utf-8?q?abuse_here=3A_https=3A//mandrillapp=2Ecom/contact/abuse=3Fid=3D30?= =?utf-8?q?504962=2Efe2bd7a58ced47f285932fb5db668bcf?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20240926:md Date: Thu, 26 Sep 2024 12:53:50 +0000 MIME-Version: 1.0 The discard feature have an other xenstore node to described the size of the blocks than can be discarded, "discard-granularity", which default to "sector-size" when absent as noted in the properties and in note 4. So discard request should be aligned on this value. Fixes: 221f2748e8da ("blkif: reconcile protocol specification with in-use implementations") Signed-off-by: Anthony PERARD --- xen/include/public/io/blkif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index 9b00d633d3..789bab65ab 100644 --- a/xen/include/public/io/blkif.h +++ b/xen/include/public/io/blkif.h @@ -668,7 +668,7 @@ typedef struct blkif_request blkif_request_t; * * The 'sector_number' field is in units of 512b, despite the value of the * 'sector-size' xenstore node. Note however that the offset in - * 'sector_number' must be aligned to 'sector-size'. + * 'sector_number' must be aligned to 'discard-granularity'. */ struct blkif_request_discard { uint8_t operation; /* BLKIF_OP_DISCARD */ From patchwork Thu Sep 26 12:53:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 13813362 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98F63CF9C69 for ; Thu, 26 Sep 2024 12:54:25 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.805430.1216519 (Exim 4.92) (envelope-from ) id 1sto0J-00010E-6S; Thu, 26 Sep 2024 12:53:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 805430.1216519; Thu, 26 Sep 2024 12:53:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sto0J-0000yn-1C; Thu, 26 Sep 2024 12:53:55 +0000 Received: by outflank-mailman (input) for mailman id 805430; Thu, 26 Sep 2024 12:53:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sto0H-0000wb-IU for xen-devel@lists.xenproject.org; Thu, 26 Sep 2024 12:53:53 +0000 Received: from mail180-17.suw31.mandrillapp.com (mail180-17.suw31.mandrillapp.com [198.2.180.17]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6198e9a8-7c06-11ef-a0ba-8be0dac302b0; Thu, 26 Sep 2024 14:53:52 +0200 (CEST) Received: from pmta11.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail180-17.suw31.mandrillapp.com (Mailchimp) with ESMTP id 4XDtnp32StzRKMbZC for ; Thu, 26 Sep 2024 12:53:50 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 7a9d2d34a38545abbe55566e732f249d; Thu, 26 Sep 2024 12:53:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6198e9a8-7c06-11ef-a0ba-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1727355230; x=1727615730; bh=dqVOEUMEgLvoqekBnl/uiNPh+iS1Y+lnSegp5okDHEQ=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=WKIzlhWkdonUPuTKW/d8p6Y3Cu3w6l0gRvEAE4p9tejFwG4XakrFX1k9F4YocjaJC lvcXtwA7DU7IpLVfvW1z9V4A3DssglXfs3i0h5gyq60VHYeepm0RSJl2ID/xVeybiU /q2SUxLdf7uSPMDveS0827Kz2XSyYmqqgEpc/xqwCbVE1v51R/XAkI+xpRLamFhab0 TauxCdJ8cWdUi4V4g7Zt1GQE+IexJ5CXolXkXaVSl4TdrEVNAh1sJkGh6ekLh0Z78W 8yn9hqwG13/Jm2KKRJ6Q//5e8kc3rrmqNfh6Xh9JHRMPUdUSJPpNKWKh0foosemnUg CsiA9kDurk0WA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1727355230; x=1727615730; i=anthony.perard@vates.tech; bh=dqVOEUMEgLvoqekBnl/uiNPh+iS1Y+lnSegp5okDHEQ=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=jT/fW5mRCrNGBBs7CUPuDGMfgYk7R8W9MLpzzoxJZl8Nb4RLoPTpfl9Ok4wEC+ZMw +h3+wZ3TPN66IUwOPn0X5B2lTmEgfFvMMEeLOJu1a0E2miIlnKkEDGg1Y4WVCRbLMH HkkqWbNpc7QUJMcw+wmUWVNMZWGw1fRRML9nKt+Irj2+Cq4D99fV5n/4nJ6Nz2fhjl u4oqw88AVhN9dYBgtx2rO8IWCE5+r1IkKT0y9jlMKlmqbMUunDelUSBunFi/qSsSX4 oFaKUtOTNmGHBieQNimWfst9k/7tnF5nZmE8osyEFDYFWk2ri5+P73chyZK0IW/j0A CKi66R3rFUO+A== From: Anthony PERARD Subject: =?utf-8?q?=5BXEN_PATCH_2/2=5D_blkif=3A_Fix_a_couple_of_typos?= X-Mailer: git-send-email 2.39.2 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1727355229754 To: xen-devel@lists.xenproject.org Cc: =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Anthony PERARD , Juergen Gross Message-Id: <20240926125347.23738-3-anthony.perard@vates.tech> In-Reply-To: <20240926125347.23738-1-anthony.perard@vates.tech> References: <20240926125347.23738-1-anthony.perard@vates.tech> X-Native-Encoded: 1 X-Report-Abuse: =?utf-8?q?Please_forward_a_copy_of_this_message=2C_including?= =?utf-8?q?_all_headers=2C_to_abuse=40mandrill=2Ecom=2E_You_can_also_report_?= =?utf-8?q?abuse_here=3A_https=3A//mandrillapp=2Ecom/contact/abuse=3Fid=3D30?= =?utf-8?q?504962=2E7a9d2d34a38545abbe55566e732f249d?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20240926:md Date: Thu, 26 Sep 2024 12:53:50 +0000 MIME-Version: 1.0 Those where fixed in OVMF's copy. (And one of them fixed in QEMU's copy but later discarded by an update.) Signed-off-by: Anthony PERARD Reviewed-by: Frediano Ziglio --- xen/include/public/io/blkif.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index 789bab65ab..8407453324 100644 --- a/xen/include/public/io/blkif.h +++ b/xen/include/public/io/blkif.h @@ -42,7 +42,7 @@ * All data in the XenStore is stored as strings. Nodes specifying numeric * values are encoded in decimal. Integer value ranges listed below are * expressed as fixed sized integer types capable of storing the conversion - * of a properly formated node string, without loss of information. + * of a properly formatted node string, without loss of information. * * Any specified default value is in effect if the corresponding XenBus node * is not present in the XenStore. @@ -328,7 +328,7 @@ * access (even when it should be read-only). If the frontend hits the * maximum number of allowed persistently mapped grants, it can fallback * to non persistent mode. This will cause a performance degradation, - * since the the backend driver will still try to map those grants + * since the backend driver will still try to map those grants * persistently. Since the persistent grants protocol is compatible with * the previous protocol, a frontend driver can choose to work in * persistent mode even when the backend doesn't support it.