From patchwork Fri Sep 27 14:16:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13814353 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BB8A8493 for ; Fri, 27 Sep 2024 14:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446576; cv=none; b=IOEi2EGVIfrodzAiYGm9+3t8qZc+hfQurELnWtwAhEXpJ2ipZAPH+lMyxFzH02ShBOLgyyiIWXCNqqC12r4aGxEx6aeDqPiqTJ0sTjb0os/9ibARfxVnV3f+XscwG/jVlyqX5CGOJJY0p5NvJDNfIZKZLMosvvBwUsJUG9HYOWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446576; c=relaxed/simple; bh=nFOjVQ+Q6pI+KtmxTBhIGG74BM7aRQGhqhPG57v7/cM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JW/JDdAsHejDRmDyouxHM6iiIiyhFbuflhiGOf3H9274p6gNWpjyRAntjATptlcXI+OThZrVdhy95S/9n5fk+NeABawSTsiEXql670Juo4lLvjAZmeVP+Krc/zZ0JI3Dt975f2zsA9AF1retZ5Ptpe8q6dtV4uL9aGIpcXGHZPA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bi4G7z47; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bi4G7z47" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727446573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TFW1BIJrUCI5UKgWkQUSCNzAomMKqYJA8V/kv/ybMls=; b=Bi4G7z47Uz6BP2Z2Jq6MpOtSB8hMLcOOFOTp4ggks99kzSSxJNz38c9ynk4tsDJSqWTZDp rfjRDj5B4pCb2SjUh8bSSQm6L4IPVb2VVn5rOPGgLHlxsIk2kALpEaYmjpkssrFklnpm9p 4gMS3L2NZOEhlIiXeXoRKUBVXQRHAd8= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-qLzXGBzjNPyoLCA1zTA_vw-1; Fri, 27 Sep 2024 10:16:12 -0400 X-MC-Unique: qLzXGBzjNPyoLCA1zTA_vw-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F1E5B18F36B2; Fri, 27 Sep 2024 14:16:09 +0000 (UTC) Received: from shalem.redhat.com (unknown [10.39.192.213]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7EC843003E4D; Fri, 27 Sep 2024 14:16:07 +0000 (UTC) From: Hans de Goede To: "Rafael J . Wysocki" Cc: Hans de Goede , Ben Mayo , Paul Menzel , Tamim Khan , linux-acpi@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH 1/4] ACPI: resource: Remove duplicate Asus E1504GAB IRQ override Date: Fri, 27 Sep 2024 16:16:03 +0200 Message-ID: <20240927141606.66826-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Commit d2aaf1996504 ("ACPI: resource: Add DMI quirks for ASUS Vivobook E1504GA and E1504GAB") does exactly what the subject says, adding DMI matches for both the E1504GA and E1504GAB. But DMI_MATCH() does a substring match, so checking for E1504GA will also match E1504GAB. Drop the unnecessary E1504GAB entry since that is covered already by the E1504GA entry. Fixes: d2aaf1996504 ("ACPI: resource: Add DMI quirks for ASUS Vivobook E1504GA and E1504GAB") Cc: Ben Mayo Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede --- drivers/acpi/resource.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 8a4726e2eb69..1ff251fd1901 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -511,19 +511,12 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, { - /* Asus Vivobook E1504GA */ + /* Asus Vivobook E1504GA* */ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), DMI_MATCH(DMI_BOARD_NAME, "E1504GA"), }, }, - { - /* Asus Vivobook E1504GAB */ - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), - DMI_MATCH(DMI_BOARD_NAME, "E1504GAB"), - }, - }, { /* Asus Vivobook Pro N6506MV */ .matches = { From patchwork Fri Sep 27 14:16:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13814354 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCB8C8493 for ; Fri, 27 Sep 2024 14:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446580; cv=none; b=WlEV/Itk+rPaf4qGxe+oNG9VsuqBenU3NJM/Nn9wi435iiiWDwSzimOOKrvXqtpCIOd7xkiQWMbI4t7R4ZyNG/B8ksWzfNBbVXpgatH0eOzJgc3ZqehgKS5K+Xc0rNXtioy3medsi6LTjqlEsxfOtDxO/6u9jMorszKPCboDPNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446580; c=relaxed/simple; bh=JGRnTam6wOgX0GfiGrUOUmnr/nbZ45ODyhVr0wrKvmM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cx3q5kCSiU4Qznbk4ffSWOwY2oJ0Ie/5SaIlnlRT/EQINRASq07rugzYi/AyBtfFBqRywKHb/bNKiwMFghmG9lLmEIbXXDwXPhFMlXthDE9A2I+rPR9waerY+cjOTNaomviALwIN+iaqMBu8T3glHOkT57CJuo2QF9fspWTBHFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BKTrU1Vj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BKTrU1Vj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727446577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SOFBPnBC7lN1uRdqkUmvoJFNcklxzjyW8PN4nLsCvLk=; b=BKTrU1VjoWDJLE3lna9+NUJvOqBdRW3W27bZAv47D5Yw+KHAEXqRBzOnKMoBWb1JlmDjSO jbX6bBZNHufD7ogAUBQZ/lLv8bSyWnGRWI/VpcLsSXCrfFos8pLtJMJlHDx9gD0uB8l1jC wyKmYX5+AKMeTlTiH7Iv6DC4QW++qys= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-_WFFAZgiNi-5tFt9mWX0AA-1; Fri, 27 Sep 2024 10:16:13 -0400 X-MC-Unique: _WFFAZgiNi-5tFt9mWX0AA-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B63C1975ACE; Fri, 27 Sep 2024 14:16:12 +0000 (UTC) Received: from shalem.redhat.com (unknown [10.39.192.213]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 603C33003DEC; Fri, 27 Sep 2024 14:16:10 +0000 (UTC) From: Hans de Goede To: "Rafael J . Wysocki" Cc: Hans de Goede , Ben Mayo , Paul Menzel , Tamim Khan , linux-acpi@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH 2/4] ACPI: resource: Loosen the Asus E1404GAB DMI match to also cover the E1404GA Date: Fri, 27 Sep 2024 16:16:04 +0200 Message-ID: <20240927141606.66826-2-hdegoede@redhat.com> In-Reply-To: <20240927141606.66826-1-hdegoede@redhat.com> References: <20240927141606.66826-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Like other Asus Vivobooks, the Asus Vivobook Go E1404GA has a DSDT describing IRQ 1 as ActiveLow, while the kernel overrides to Edge_High. $ sudo dmesg | grep DMI:.*BIOS [ 0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023 $ sudo cp /sys/firmware/acpi/tables/DSDT dsdt.dat $ iasl -d dsdt.dat $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1 IRQ (Level, ActiveLow, Exclusive, ) {1} There already is an entry in the irq1_level_low_skip_override[] DMI match table for the "E1404GAB", change this to match on "E1404GA" to cover the E1404GA model as well (DMI_MATCH() does a substring match). Reported-by: Paul Menzel Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Cc: Tamim Khan Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede --- Note this patch replaces Paul Menzel's patch which added a new entry for the "E1404GA", instead of loosening the "E1404GAB" match: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg.de/ --- drivers/acpi/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 1ff251fd1901..dfe108e2ccde 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -504,10 +504,10 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, { - /* Asus Vivobook Go E1404GAB */ + /* Asus Vivobook Go E1404GA* */ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), - DMI_MATCH(DMI_BOARD_NAME, "E1404GAB"), + DMI_MATCH(DMI_BOARD_NAME, "E1404GA"), }, }, { From patchwork Fri Sep 27 14:16:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13814355 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19A8113AA47 for ; Fri, 27 Sep 2024 14:16:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446582; cv=none; b=EawtcTl2HGRp7C6psscsx73BED7vdafWTMlMQiTA10VK4mUOCMWfxaps2lqe7wUZFCrIEDp24+6/t8lNnArmo60IKyvw/22b8ORjzsNJT+Ux6aA9ubiJgP0lZLemzTTnvj0CJB8r7bldTj3Y3mILDDcXFNis2Ayo9h3qfm6PVKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446582; c=relaxed/simple; bh=gh9rcBnLoktcwNOQG1qG234HpzZYoZyvaM4Y8zNBXeQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DOVwZ/KLSmPxKy01YyT4koAZskStHJNLrAKeWif1SBTXyE5GcfQrYemWlKwiQJfK9VTEEHn5FAWMeuojTmvrR6YOTDhY5zMr+7TvEqmEqfWZxasoiZF2+n/5s6wyL4WfDhvG42tQU7Ru44bhVRV5CGgzMWEZyTOMeUJTTcSlzxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FGU9Grl8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FGU9Grl8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727446580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pePjaCmWorVHVAoQp30DP/JCU/QFnyFXqgGyMCgWztE=; b=FGU9Grl8I0hkdFs9lNObaHiv+cdcljRLTrAjDvwr+rrE8dlKBlATHkkaSgWlveuLdVjRBz mRweQu8UACO6RgK1fKuQnTWRjcRlKznZ/QMtQIY3EG4Pfes6KoorUAKqqNbXjMGhDgi5In ynGnMZ/DGafqh7elypGPb+TuT7I/iSo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-y9lu6ccROz-cLhUoNGZrVA-1; Fri, 27 Sep 2024 10:16:17 -0400 X-MC-Unique: y9lu6ccROz-cLhUoNGZrVA-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 751CF18F377F; Fri, 27 Sep 2024 14:16:15 +0000 (UTC) Received: from shalem.redhat.com (unknown [10.39.192.213]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DE5AB3003DEC; Fri, 27 Sep 2024 14:16:12 +0000 (UTC) From: Hans de Goede To: "Rafael J . Wysocki" Cc: Hans de Goede , Ben Mayo , Paul Menzel , Tamim Khan , linux-acpi@vger.kernel.org, regressions@lists.linux.dev, Lamome Julien , stable@vger.kernel.org Subject: [PATCH 3/4] ACPI: resource: Add Asus Vivobook X1704VAP to irq1_level_low_skip_override[] Date: Fri, 27 Sep 2024 16:16:05 +0200 Message-ID: <20240927141606.66826-3-hdegoede@redhat.com> In-Reply-To: <20240927141606.66826-1-hdegoede@redhat.com> References: <20240927141606.66826-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Like other Asus Vivobook models the X1704VAP has its keybopard IRQ (1) described as ActiveLow in the DSDT, which the kernel overrides to EdgeHigh which breaks the keyboard. Add the X1704VAP to the irq1_level_low_skip_override[] quirk table to fix this. Reported-by: Lamome Julien Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078696 Closes: https://lore.kernel.org/all/1226760b-4699-4529-bf57-6423938157a3@wanadoo.fr/ Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede --- drivers/acpi/resource.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index dfe108e2ccde..8e672790ac51 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -440,6 +440,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"), }, }, + { + /* Asus Vivobook X1704VAP */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "X1704VAP"), + }, + }, { /* Asus ExpertBook B1402CBA */ .matches = { From patchwork Fri Sep 27 14:16:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13814356 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736E21386D1 for ; Fri, 27 Sep 2024 14:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446582; cv=none; b=QpBvgx4BJBSJ8yDfOzNAFt74hk5qetybtqJyu/0eMsF72/wGpGhHCnkdXR7IbQ/rKIv7PS9e5ixi1fItZN5d1k5KhU1KQFTgIyrQwsNzkEry+6UE/jcYK/h2FGjjshEj2zexptjyFHjzuIaEslXiVht3U2VXwx/eS1ZF5VeM93E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727446582; c=relaxed/simple; bh=lgnNlVYyaY1Gq35epLXc2xk3UmcREDNwbqplkuqtrxk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JexQj2cjN23e10gBNKYZ3jYfqL7SzaKhJDN3jlNsKUmQAIY3ZcmCuE+w8YKqdHL7mbV1GIj9xXV42hhmrOadP+OT1SOrxgtb6S9duORYnUV1DHhviMdKBmNYnHtsuJJ1DGQ15Mczn/sHPzL7SMlYH/CK2RwVtiB4shyYfyBDa3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ES45IAOz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ES45IAOz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727446580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1nhcvv20+83wxqlmldyHBKA2HMfVVTDyvB5SLewi9B8=; b=ES45IAOz+KZdrINPWRt9ZZ1AMbakHDma+Aa5RlDe7GpHBWxPFP4XFJSPsfg9nUbdp9gTH2 3V7H+7czcCmSnYScrzJLmYQJm7QGwxlpawthVjpDBHKWkSJf/eTGzKKQfpBFgbdqeeXZth t0UwEbsVxWOOkyDJV9xLYu0QLapR/as= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-_N-DxtUUMKCx3hI8arBe1Q-1; Fri, 27 Sep 2024 10:16:19 -0400 X-MC-Unique: _N-DxtUUMKCx3hI8arBe1Q-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1193518B0960; Fri, 27 Sep 2024 14:16:18 +0000 (UTC) Received: from shalem.redhat.com (unknown [10.39.192.213]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DD1A73003FD2; Fri, 27 Sep 2024 14:16:15 +0000 (UTC) From: Hans de Goede To: "Rafael J . Wysocki" Cc: Hans de Goede , Ben Mayo , Paul Menzel , Tamim Khan , linux-acpi@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH 4/4] ACPI: resource: Add Asus ExpertBook B2502CVA to irq1_level_low_skip_override[] Date: Fri, 27 Sep 2024 16:16:06 +0200 Message-ID: <20240927141606.66826-4-hdegoede@redhat.com> In-Reply-To: <20240927141606.66826-1-hdegoede@redhat.com> References: <20240927141606.66826-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Like other Asus ExpertBook models the B2502CVA has its keybopard IRQ (1) described as ActiveLow in the DSDT, which the kernel overrides to EdgeHigh which breaks the keyboard. Add the B2502CVA to the irq1_level_low_skip_override[] quirk table to fix this. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217760 Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede --- drivers/acpi/resource.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 8e672790ac51..3d74ebe9dbd8 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -510,6 +510,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { DMI_MATCH(DMI_BOARD_NAME, "B2502FBA"), }, }, + { + /* Asus ExpertBook B2502CVA */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "B2502CVA"), + }, + }, { /* Asus Vivobook Go E1404GA* */ .matches = {