From patchwork Mon Sep 30 11:20:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815855 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51C6F18DF66; Mon, 30 Sep 2024 11:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695307; cv=none; b=c8f+VhHa8pcn12BiSRa+MmKLb+u7GtVQYjpAT5BQbFT3kSqUkAeM6ZXj8PLyvIU8u6nlIw9k2+kEQaYDc7puONwTXB5qR9XUEseOqdhD+TRFT3nvZS1A+aDV8826tU0HdtrqdUM7ZMyZ5FgyyvvRVYTqkYCWeqm/QNKQHlSezxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695307; c=relaxed/simple; bh=tiPypvdgIX3UNjxLor6apsPW9dMipmDIhqCV9bEUOD0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ReEQhXFnL6l+W2AsabGEW/ZdXTcYngpd2QsAU7IbcpZWRcCFQM4IqJMZj4N0MBjdWXcIhq8RL0Xpq2J/WytgfbQWWQrtSNbvl5E9d2OkIDgQDQWBjFuTFDyIeg2ujHStfIQZxnbPmh8vYgxuOo3JLoTqdhsHuVov7HgIv/yzWJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=vr4z8+uH; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="vr4z8+uH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+p76pyonorQH0EdArmWLA7KPzT5wrEkQVbK8fq3xix0=; b=vr4z8+uHFG1CzL+hFBLDIvd1zO/XG2c9OBw801pU4u0CwGqemBa+oWRF /zNyWA6zlGk5bHgTv/wvpJ+JbGhjXIpYO9N2Nw4VCgl2zp8ka3xduxDH9 p0nOVcdno6NUqk48zzoAS0iKt5h7m6wgQvj/xsO7XsUKhl5tRkWtA+9hJ Y=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956879" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:26 +0200 From: Julia Lawall To: Alexander Viro Cc: kernel-janitors@vger.kernel.org, Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/35] fs: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:20:54 +0200 Message-Id: <20240930112121.95324-9-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall Reviewed-by: Jan Kara --- fs/char_dev.c | 2 +- fs/dcache.c | 4 ++-- fs/seq_file.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/char_dev.c b/fs/char_dev.c index 57cc096c498a..c2ddb998f3c9 100644 --- a/fs/char_dev.c +++ b/fs/char_dev.c @@ -562,8 +562,8 @@ int cdev_device_add(struct cdev *cdev, struct device *dev) /** * cdev_device_del() - inverse of cdev_device_add - * @dev: the device structure * @cdev: the cdev structure + * @dev: the device structure * * cdev_device_del() is a helper function to call cdev_del and device_del. * It should be used whenever cdev_device_add is used. diff --git a/fs/dcache.c b/fs/dcache.c index d7f6866f5f52..2894b30d8e40 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -2039,8 +2039,8 @@ EXPORT_SYMBOL(d_obtain_root); /** * d_add_ci - lookup or allocate new dentry with case-exact name - * @inode: the inode case-insensitive lookup has found * @dentry: the negative dentry that was passed to the parent's lookup func + * @inode: the inode case-insensitive lookup has found * @name: the case-exact name to be associated with the returned dentry * * This is to avoid filling the dcache with case-insensitive names to the @@ -2093,8 +2093,8 @@ EXPORT_SYMBOL(d_add_ci); /** * d_same_name - compare dentry name with case-exact name - * @parent: parent dentry * @dentry: the negative dentry that was passed to the parent's lookup func + * @parent: parent dentry * @name: the case-exact name to be associated with the returned dentry * * Return: true if names are same, or false diff --git a/fs/seq_file.c b/fs/seq_file.c index e676c8b0cf5d..8bbb1ad46335 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -343,8 +343,8 @@ EXPORT_SYMBOL(seq_lseek); /** * seq_release - free the structures associated with sequential file. - * @file: file in question * @inode: its inode + * @file: file in question * * Frees the structures associated with sequential file; can be used * as ->f_op->release() if you don't have private data to destroy. From patchwork Mon Sep 30 11:20:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815854 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5CE18FDAB; Mon, 30 Sep 2024 11:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695307; cv=none; b=qhfjnS1Vzow6pUERPiiWwPMXBZABGttKOnJHMqOVw0sTbhMjbIgkvPGTxqujOHVH0BpMuv83BTaFAwhPEWTnX+MAzsQzu2sd2c9kcmzhpJOpeszo4NAFkQAEU6f8iatxcUfhEXR9LnKadWigiSFNmpNurwbeB+bDjQsHJDUEQcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695307; c=relaxed/simple; bh=yr69Xt+oBFSxFfHWaYuaGHrNy9SgdK9fwESIzSXfPTk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DoAgo3/nuZkGlH5gsQkVV93kqVMXrBUzhuB7beFOZayXxAW5rba7Nnc0y2IX28fOSHsCCmIoFwTCJdtYo8GNw7K3tlOls7Xx7C7d8/shlnn3yM6j0J/kwd9tzpkeX+kmnjy45yikk7kvQeklGeLMPaTo8YqJHibDnY561eMYam4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=JSmhmrWO; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="JSmhmrWO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Kwh8q1Ub6dpDycuiPQuN0DU5T3cLRGRT4zRLWwisCJE=; b=JSmhmrWOhGxp7Ap0wkpPv1i/0DTr292EhwEaconbaBVw8HuWE/rA2m17 dxrDQrtNIungZrCIEe41yJaubnu+W7m+66QuDgR2sARL+8zQdWHFfBCRU 9cAaywX5qeVIo4PIAyKrKYLV/IWJMSEMj6cqyheX/EcuqP1LqB59BiCRL s=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956880" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:26 +0200 From: Julia Lawall To: Luis Chamberlain Cc: kernel-janitors@vger.kernel.org, Kees Cook , Joel Granados , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 09/35] sysctl: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:20:55 +0200 Message-Id: <20240930112121.95324-10-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Joel Granados --- kernel/sysctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 79e6cb1d5c48..5c9202cb8f59 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1305,7 +1305,6 @@ int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int write, * @write: %TRUE if this is a write to the sysctl file * @buffer: the user buffer * @lenp: the size of the user buffer - * @ppos: file position * @ppos: the current position in the file * * Reads/writes up to table->maxlen/sizeof(unsigned int) integer