From patchwork Mon Sep 30 11:20:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815867 X-Patchwork-Delegate: kuba@kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6919118E042; Mon, 30 Sep 2024 11:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695302; cv=none; b=SwNJfkVKUqDayv3GVbUIVKGa2DPmHozEfwgGaNjeMMzWrqXa8vLOdekBnqEykCD/6fcapKp5KCjZNuBCURXhusI2L7amqweV8h0kJDoUzd5kWnaxNkInzaVE9xqExUwRge1ao/mMPTp0tkJq2rQ4iHlUO/SizKPuSx9oNioICao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695302; c=relaxed/simple; bh=eSjouLfxGmVji7JdCEAg4WXxt7IxGP+mS6Kae6CCgYg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=h4/zJHfYIGZmMbGcqjPmj1/DH/cow4PRpLlbkY7p1BlDsj/rtBJuiqIcLG6libDwObU3TAGwgftDPEuzNhsLyQqMUR0BGrSIId3IUl7l9pJV2SHsoizlGT8t1vtEv8YcvF1cFPH5nOWejcu+ngEvGCANJ2+qR5kSXuDyMWmZ/Vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=SYzrieHm; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="SYzrieHm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=G3ifI7N9pFjRhbukFRN+v1CH5AuIXashGVsJlh26LjU=; b=SYzrieHmLrf4vwgmOWeFYWi2RcwXiujn0mPzUijlk/ON5rNN+p3ko4N6 ixRZQDEUpGJcafndhDtL73zWP5afI3Qe4Nc7szNsatl5hTl2oFKiY7juB jnnAIGUy7bS8W+3iCA5PIkXSC6u/5aKJmkkt+52OCQfKh/xuW6P89OwCk w=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956871" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:26 +0200 From: Julia Lawall To: Michael Chan Cc: kernel-janitors@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/35] bnxt_en: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:20:49 +0200 Message-Id: <20240930112121.95324-4-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c index d2fd2d04ed47..3ba7a51a8afa 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c @@ -171,8 +171,8 @@ void hwrm_req_alloc_flags(struct bnxt *bp, void *req, gfp_t gfp) * such as hwrm_req_send(), should thus use req and not new_req (in fact, * calls to HWRM API functions will fail if non-managed request objects * are passed). - * @len: The length of new_req. * @new_req: The pre-built request to copy or reference. + * @len: The length of new_req. * * Replaces the request data in req with that of new_req. This is useful in * scenarios where a request object has already been constructed by a third From patchwork Mon Sep 30 11:20:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815869 X-Patchwork-Delegate: kuba@kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3979190052; Mon, 30 Sep 2024 11:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695308; cv=none; b=tzlw2riSRuIda6JleYz5nGL2P/KFH8ITLVaD84n2yEE0hvXlOAG0/f+K8UkPtZ4Q9GO8XId9cOvMn6qNGIEscAoQ2n9SoQ/dHzHmB28PqrkUT8YtMRgWcrvDQli/q0NkKJgZx49j2C/t/G59TJ7uz9ajZoi8CUggtO/jsbuepNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695308; c=relaxed/simple; bh=pLq3YOT6+rNHjYOPVLrgKEdscljtkQsbJ2htKr9ITqg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pcPT++bsgmBctQKn7htTdFsvoxJOR10oJcC9l6MMu0qzpyHaXAoDko4qumgby01hmiG4SDNn8xj5kOmN1As9oLekQT0dNeFXh+t0hpdxccx/zOyn1KjT9aOWYRJ777oz95isvW1JqBrJ2dttt8SFNGqxFLbSL4qUr/l1/WNcpJ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=lJFK0vOr; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="lJFK0vOr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nWSmtARBk2gEHkUFa2bT2tPofkcYuwxfvTcgtvxT/uU=; b=lJFK0vOrS5fbWQcJGzSnI82bsXvhhboUYzhz+27wFj1HndtT1jdW/RKo cudYKM4L4K4LzaoL4iGHMmEBrKkm7m9GkpYOrbZYVBk/H0o6DKRAtN8m2 3eOQfpu8wZljBWVMPZwGSGTbDJSQSEsJ3vDUlPEEGBErsEpZKryOfXUu4 I=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956881" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:26 +0200 From: Julia Lawall To: "David S. Miller" Cc: kernel-janitors@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/35] dccp: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:20:56 +0200 Message-Id: <20240930112121.95324-11-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- net/dccp/feat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/feat.c b/net/dccp/feat.c index 54086bb05c42..90ac50556ee0 100644 --- a/net/dccp/feat.c +++ b/net/dccp/feat.c @@ -626,9 +626,9 @@ static u8 dccp_feat_sp_list_ok(u8 feat_num, u8 const *sp_list, u8 sp_len) /** * dccp_feat_insert_opts - Generate FN options from current list state - * @skb: next sk_buff to be sent to the peer * @dp: for client during handshake and general negotiation * @dreq: used by the server only (all Changes/Confirms in LISTEN/RESPOND) + * @skb: next sk_buff to be sent to the peer */ int dccp_feat_insert_opts(struct dccp_sock *dp, struct dccp_request_sock *dreq, struct sk_buff *skb) From patchwork Mon Sep 30 11:21:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815871 X-Patchwork-Delegate: kuba@kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4D4191F6F; Mon, 30 Sep 2024 11:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695311; cv=none; b=VmiummY5HelXmBqX1QqupXiK9TiJK8DjMr2+VhLPdKZub3utHP7QDaUT8lFZXWJvnet359j7ue02cFfXdWKE0TvwsnjEaxMqlywcxbYen5rT3mldvtTThURJ1gJhAmydT8exGBwNLl5iL/4AYbtSfoB/G1tEjtP1LbM3Y4OPlEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695311; c=relaxed/simple; bh=lkksD6NGuXpIY+XpTHVBhF7SHlisT53r+IndpiuzOwY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P1IqxbSsDBa4v6NUjtxwODjF0lYor2gwzwOcr2t1OehTTMoWxZmevfXDLG0/BaOqDc0qKuZwYZJGTocOE6cdy0YCL+l/E+Dcho9hdlTbSHGMpkDUSO/s5FWbhalTSwOPOE/Aqp4gcubgyc8OPApSudzgz6pl5+dMpmlwRq3LQXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=k/WLK6em; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="k/WLK6em" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2XKlhDn6AgGoqTZxo5VdksoOUikd1owa2yhjw2qwHt0=; b=k/WLK6em86nT5+RBYtbTv2INfkmz5Wvk4WVE0xnMflr/XVcrxCQt6b/U dXroARqG7x8nBEoU3LOJhCYDlkFZyaTX4S4eHuLdxJm3ZxSHZNRRaqrke bKckiNeCeD30R1cMAvG+/UuxU0neSY+lKsK2E8ddr03qnWL/BU17EFPae A=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956886" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:26 +0200 From: Julia Lawall To: Jon Maloy Cc: kernel-janitors@vger.kernel.org, Ying Xue , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH 15/35] tipc: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:21:01 +0200 Message-Id: <20240930112121.95324-16-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- net/tipc/link.c | 14 +++++++------- net/tipc/msg.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/tipc/link.c b/net/tipc/link.c index 5c2088a469ce..55c2ad1d88a2 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c @@ -461,15 +461,15 @@ u32 tipc_link_state(struct tipc_link *l) * @min_win: minimal send window to be used by link * @max_win: maximal send window to be used by link * @session: session to be used by link + * @self: local unicast link id * @peer: node id of peer node + * @peer_id: 128-bit ID of peer * @peer_caps: bitmap describing peer node capabilities * @bc_sndlink: the namespace global link used for broadcast sending * @bc_rcvlink: the peer specific link used for broadcast reception * @inputq: queue to put messages ready for delivery * @namedq: queue to put binding table update messages ready for delivery * @link: return value, pointer to put the created link - * @self: local unicast link id - * @peer_id: 128-bit ID of peer * * Return: true if link was created, otherwise false */ @@ -538,17 +538,17 @@ bool tipc_link_create(struct net *net, char *if_name, int bearer_id, /** * tipc_link_bc_create - create new link to be used for broadcast * @net: pointer to associated network namespace + * @ownnode: identity of own node + * @peer: node id of peer node + * @peer_id: 128-bit ID of peer * @mtu: mtu to be used initially if no peers * @min_win: minimal send window to be used by link * @max_win: maximal send window to be used by link + * @peer_caps: bitmap describing peer node capabilities * @inputq: queue to put messages ready for delivery * @namedq: queue to put binding table update messages ready for delivery - * @link: return value, pointer to put the created link - * @ownnode: identity of own node - * @peer: node id of peer node - * @peer_id: 128-bit ID of peer - * @peer_caps: bitmap describing peer node capabilities * @bc_sndlink: the namespace global link used for broadcast sending + * @link: return value, pointer to put the created link * * Return: true if link was created, otherwise false */ diff --git a/net/tipc/msg.c b/net/tipc/msg.c index 76284fc538eb..dc3000c28d43 100644 --- a/net/tipc/msg.c +++ b/net/tipc/msg.c @@ -196,8 +196,8 @@ int tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf) * tipc_msg_append(): Append data to tail of an existing buffer queue * @_hdr: header to be used * @m: the data to be appended - * @mss: max allowable size of buffer * @dlen: size of data to be appended + * @mss: max allowable size of buffer * @txq: queue to append to * * Return: the number of 1k blocks appended or errno value From patchwork Mon Sep 30 11:21:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815870 X-Patchwork-Delegate: kuba@kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECF5A191F8D; Mon, 30 Sep 2024 11:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695311; cv=none; b=DvBhEY8XDmSq12GngvebVc087qFtJJHdl3h3bmk0nYU0D6X+qg0bRjFQbhFqfykj3BlaTE5x5vH6URLV55khNZkZgbiRnUiKO817OxHjDralaGAOb/66oAnV11IUnTjPKyyJpMCcK1oqfxx076ofhJGty7Um19TPnmNSxY2RB5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695311; c=relaxed/simple; bh=PgwIMygjWOyNNQQhqkAx39w3297DqiDCBEhTHKUEBpo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A9sq9N9TiyAqsQs8aGzmAGm27PCY5xta4T8d1d/K/v9s9jm/JrFpvm43SanYyQ6IabiKbvJhcmDWHdaJ5F9EfeEvG1bgjcvTbh8JxUnD+fEkjYliUrlOqQGc/NH5v6XnPtyZ5BlXJkRFBHBZk6suRNk8nTSL2FyfrSXbkO8GBFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=s06oSpFg; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="s06oSpFg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tiAMZdHfzRRadEJUpeFbdHkU5NVv6AAREPGmWLFa9N8=; b=s06oSpFgNGj4vEEvBslzvjOKYQsmgjcckUHnAXT0NQdiYMYLFkYqyLKf GIj0BnZ4kI2kL8qj2nuqgVAZUbMdVmTG0ceim4mOrZKYqF/Dvm+x+n11e /1Y0OhDC2c3e2uNvX0jyHlKwa1N6HD6/W9OfIhrQDKI1XoM8vqiZNT4SE c=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956887" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:27 +0200 From: Julia Lawall To: "David S. Miller" Cc: kernel-janitors@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/35] net: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:21:02 +0200 Message-Id: <20240930112121.95324-17-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index 601ad74930ef..f4ac3939fbb0 100644 --- a/net/socket.c +++ b/net/socket.c @@ -235,8 +235,8 @@ static const struct net_proto_family __rcu *net_families[NPROTO] __read_mostly; /** * move_addr_to_kernel - copy a socket address into kernel space * @uaddr: Address in user space - * @kaddr: Address in kernel space * @ulen: Length in user space + * @kaddr: Address in kernel space * * The address is copied into kernel space. If the provided address is * too long an error code of -EINVAL is returned. If the copy gives From patchwork Mon Sep 30 11:21:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815872 X-Patchwork-Delegate: kuba@kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A5B61957F4; Mon, 30 Sep 2024 11:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695316; cv=none; b=lUpWqlInMUHFDEpbJYhCyBSAZF2xDpGpuD5pUnmq70FcvnS+hxHgJm0XXhNXjy+IVy4hfNMpVIhvibSEkr76h2fgNqcj8P/4hu52S9YOEeIjEyDFGCnOkm49rIJzr2chpumD7xj1jT8EzcsjtAsF2ACXXV+Sy7oeVZRTV+QSpIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695316; c=relaxed/simple; bh=cbKZFVxD8vKFKjYfmXBm/w08xlle6y2Pu4DuJ3uL0EA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jlLF8bC3GPESElQ265SMaaHlORsjtNU9CmqxvM6NGoyCmXbZFx8w1OGMv24AxxfFUEY9is4aDO8yR2XxEHUlm1/oUR/lf1lKgy9S0bkmhptTmSlTqPz1ykVZnD5cQtKCb9+WtrYZEJAX/DPO0e20cUr2zUCCb+Qoc05JNjdx2xc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=HpmzvhmZ; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="HpmzvhmZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=k7bOPAFANWhA0Ui7wz343CvWa6yOufJZVnn75o1MDXU=; b=HpmzvhmZWC2nifwxAkGqF5zn2ddWpZTd4Jm6XdJsfTfdDk4Xy54BJ8aA HC095yAgkdAWThCfCejCAoVSe44Av8xZfTRLjbHChvcp11KNRzMMH/Rr3 peeeFJwrxfFz+dlCVLg60S2pZK/IDFL433lk0UrHQYzw93SUiA+nuJ9wR U=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956900" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:27 +0200 From: Julia Lawall To: Trond Myklebust Cc: kernel-janitors@vger.kernel.org, Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/35] SUNRPC: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:21:09 +0200 Message-Id: <20240930112121.95324-24-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- net/sunrpc/xprt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index 09f245cda526..59ac26423f2e 100644 --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c @@ -255,8 +255,8 @@ static void xprt_clear_locked(struct rpc_xprt *xprt) /** * xprt_reserve_xprt - serialize write access to transports - * @task: task that is requesting access to the transport * @xprt: pointer to the target transport + * @task: task that is requesting access to the transport * * This prevents mixing the payload of separate requests, and prevents * transport connects from colliding with writes. No congestion control From patchwork Mon Sep 30 11:21:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815873 X-Patchwork-Delegate: kuba@kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A76B198A1B; Mon, 30 Sep 2024 11:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695317; cv=none; b=HME3rtDWd45Dva6F2P6YU7tGpHVKhrTJAGhNcWG+MYvAyhCwJUqjUoeD3VHXDzLwGKYUh6LbveHoLPw5e3PtBRhqNRWwslz/H8PxSOLnlYAGj5MWK67L317kSZ83ZDasYNqWf7ajRkWPi73zksCCSSzXlVV7+CapTeAWsklekX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695317; c=relaxed/simple; bh=wlSJzOFwNkVwK6xhV9kGwcyLBVel4D1ySXl/FG5utrs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=N2qPbZB6jAjifC0FNaGQmxGl1HTiQvLznuXmP9JHkych/AfBghv4QRI6A9hUwa83lWb/pIhaYCEz5bmgbX/0jNJMwERf55llT7t1I3C/CbVd2sq9rcguAn+682netKHebTZoN4mxRAo7uvBpCJHCB3JTkMCahjyrze546RvpqL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=hKCq+v+D; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="hKCq+v+D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TN+wnXyWailQ6qfE02yp7w4g8GHrjDQVwQg6y7qPRjc=; b=hKCq+v+DH0RjVxpepkxEilNpVdaZZAlhESNrzRtL8fd78LMFK/FXsSOk MDBBdu9Ss5UfB8xZSIdqnm2JdLiRAnr9Jb3K6shFP0CAKmikUW4Z8hZeq x54ZKx8iZbAbnOLRSh1NGjbiLfQ1iF1vVvUoFxNJnBRj0nYigBLLWuide Y=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956906" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:28 +0200 From: Julia Lawall To: Johannes Berg Cc: kernel-janitors@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 27/35] mac80211: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:21:13 +0200 Message-Id: <20240930112121.95324-28-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall Reviewed-by: Jeff Johnson --- net/mac80211/mesh_hwmp.c | 6 +++--- net/mac80211/mesh_pathtbl.c | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c index 024f48db6b05..0b13a6648e08 100644 --- a/net/mac80211/mesh_hwmp.c +++ b/net/mac80211/mesh_hwmp.c @@ -220,12 +220,12 @@ static void prepare_frame_for_deferred_tx(struct ieee80211_sub_if_data *sdata, /** * mesh_path_error_tx - Sends a PERR mesh management frame * + * @sdata: local mesh subif * @ttl: allowed remaining hops * @target: broken destination * @target_sn: SN of the broken destination * @target_rcode: reason code for this PERR * @ra: node this frame is addressed to - * @sdata: local mesh subif * * Note: This function may be called with driver locks taken that the driver * also acquires in the TX path. To avoid a deadlock we don't transmit the @@ -1137,8 +1137,8 @@ void mesh_path_start_discovery(struct ieee80211_sub_if_data *sdata) /** * mesh_nexthop_resolve - lookup next hop; conditionally start path discovery * - * @skb: 802.11 frame to be sent * @sdata: network subif the frame will be sent through + * @skb: 802.11 frame to be sent * * Lookup next hop for given skb and start path discovery if no * forwarding information is found. @@ -1245,8 +1245,8 @@ void mesh_path_refresh(struct ieee80211_sub_if_data *sdata, * this function is considered "using" the associated mpath, so preempt a path * refresh if this mpath expires soon. * - * @skb: 802.11 frame to be sent * @sdata: network subif the frame will be sent through + * @skb: 802.11 frame to be sent * * Returns: 0 if the next hop was found. Nonzero otherwise. */ diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c index 30c0d89203af..9f9cb5af0a97 100644 --- a/net/mac80211/mesh_pathtbl.c +++ b/net/mac80211/mesh_pathtbl.c @@ -300,8 +300,8 @@ __mesh_path_lookup_by_idx(struct mesh_table *tbl, int idx) /** * mesh_path_lookup_by_idx - look up a path in the mesh path table by its index - * @idx: index * @sdata: local subif, or NULL for all entries + * @idx: index * * Returns: pointer to the mesh path structure, or NULL if not found. * @@ -315,8 +315,8 @@ mesh_path_lookup_by_idx(struct ieee80211_sub_if_data *sdata, int idx) /** * mpp_path_lookup_by_idx - look up a path in the proxy path table by its index - * @idx: index * @sdata: local subif, or NULL for all entries + * @idx: index * * Returns: pointer to the proxy path structure, or NULL if not found. * @@ -670,8 +670,8 @@ void mesh_fast_tx_flush_addr(struct ieee80211_sub_if_data *sdata, /** * mesh_path_add - allocate and add a new path to the mesh path table - * @dst: destination address of the path (ETH_ALEN length) * @sdata: local subif + * @dst: destination address of the path (ETH_ALEN length) * * Returns: 0 on success * @@ -916,8 +916,8 @@ static int table_path_del(struct mesh_table *tbl, /** * mesh_path_del - delete a mesh path from the table * - * @addr: dst address (ETH_ALEN length) * @sdata: local subif + * @addr: dst address (ETH_ALEN length) * * Returns: 0 if successful */ @@ -996,8 +996,8 @@ int mesh_path_send_to_gates(struct mesh_path *mpath) /** * mesh_path_discard_frame - discard a frame whose path could not be resolved * - * @skb: frame to discard * @sdata: network subif the frame was to be sent through + * @skb: frame to discard * * Locking: the function must me called within a rcu_read_lock region */ From patchwork Mon Sep 30 11:21:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 13815874 X-Patchwork-Delegate: kuba@kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50C9B19ABA3; Mon, 30 Sep 2024 11:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695321; cv=none; b=Ps8Fruo1eOmsnRVm8VL3ssz04y6CXbxvWy1H5mT5BfloMyywuosV4TYojYpvmSfbalSUBoqD2PQEjPUU45Le2edymkKK7+8Kzqb86eikQEIJddGBY6MxE3xmOVcBVH+bRJmXq6RHsSgB9lbG6SdhKfYPSuIqPYNBjKlZNUOnWk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727695321; c=relaxed/simple; bh=PmT9O/+7fwVt790lDpgSQowywQ0NFr1wjwDGR8wZGuk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gNSw4GZjN//espLkOl2P9K5LzfAy5jdb4SYJKAEKr8mAS8+1RzpTSXnj1jOh3cjqf9XqPYaKmHfoljBGn2IPDINuZetksRV1xgGVjtPZnHuuiRoILYvCgx3aMl3bdiXA5bC3KsF4/h33vZJBekSOb2mJGtTyV++WbF/emQSKPww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=fI/8/wTg; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="fI/8/wTg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RF4M5sp1M89dXG5TKYPlc4/p+FQQxzTT+AquUnods1A=; b=fI/8/wTgbpT6vBh1PM5rYudE7uS62YQ4nXCzxZ/NVCKH6UlVWUjRLhd/ Bkublc0NZ60/cyxnlT9W0CSfRCb3cGxqKBP883vvCKW56EZWRXJBNPCW4 zD4qjLQF8omsa0jpyKF6ldnQaUYgMaCkmO/y/uxSocAqLGd01dy0PVNoJ M=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.11,165,1725314400"; d="scan'208";a="185956915" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 13:21:28 +0200 From: Julia Lawall To: Tony Nguyen Cc: kernel-janitors@vger.kernel.org, Przemek Kitszel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 33/35] drivers/net/ethernet/intel: Reorganize kerneldoc parameter names Date: Mon, 30 Sep 2024 13:21:19 +0200 Message-Id: <20240930112121.95324-34-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240930112121.95324-1-Julia.Lawall@inria.fr> References: <20240930112121.95324-1-Julia.Lawall@inria.fr> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall Reviewed-by: Tony Nguyen --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_common.c | 7 +++---- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c index f9328f2e669f..1b7e78018b8f 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c @@ -3839,8 +3839,8 @@ static s32 e1000_spi_eeprom_ready(struct e1000_hw *hw) * e1000_read_eeprom - Reads a 16 bit word from the EEPROM. * @hw: Struct containing variables accessed by shared code * @offset: offset of word in the EEPROM to read - * @data: word read from the EEPROM * @words: number of words to read + * @data: word read from the EEPROM */ s32 e1000_read_eeprom(struct e1000_hw *hw, u16 offset, u16 words, u16 *data) { diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c index e8031f1a9b4f..f2d342ffc6d6 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_common.c +++ b/drivers/net/ethernet/intel/i40e/i40e_common.c @@ -1045,9 +1045,9 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink) /** * i40e_aq_get_phy_capabilities * @hw: pointer to the hw struct - * @abilities: structure for PHY capabilities to be filled * @qualified_modules: report Qualified Modules * @report_init: report init capabilities (active are default) + * @abilities: structure for PHY capabilities to be filled * @cmd_details: pointer to command details structure or NULL * * Returns the various PHY abilities supported on the Port. @@ -1948,7 +1948,6 @@ int i40e_aq_get_switch_config(struct i40e_hw *hw, * i40e_aq_set_switch_config * @hw: pointer to the hardware structure * @flags: bit flag values to set - * @mode: cloud filter mode * @valid_flags: which bit flags to set * @mode: cloud filter mode * @cmd_details: pointer to command details structure or NULL @@ -2534,9 +2533,9 @@ int i40e_aq_add_mirrorrule(struct i40e_hw *hw, u16 sw_seid, * @hw: pointer to the hw struct * @sw_seid: Switch SEID (to which rule refers) * @rule_type: Rule Type (ingress/egress/VLAN) - * @count: length of the list * @rule_id: Rule ID that is returned in the receive desc as part of * add_mirrorrule. + * @count: length of the list * @mr_list: list of mirrored VLAN IDs to be removed * @cmd_details: pointer to command details structure or NULL * @rules_used: Number of rules used in internal switch @@ -3444,8 +3443,8 @@ int i40e_aq_start_lldp(struct i40e_hw *hw, bool persist, /** * i40e_aq_set_dcb_parameters * @hw: pointer to the hw struct - * @cmd_details: pointer to command details structure or NULL * @dcb_enable: True if DCB configuration needs to be applied + * @cmd_details: pointer to command details structure or NULL * **/ int diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c index 009716a12a26..8a61e13eca1d 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -5301,8 +5301,8 @@ ice_aq_get_output_pin_cfg(struct ice_hw *hw, u8 output_idx, u8 *flags, * @hw: pointer to the HW struct * @dpll_num: DPLL index * @ref_state: Reference clock state - * @config: current DPLL config * @dpll_state: current DPLL state + * @config: current DPLL config * @phase_offset: Phase offset in ns * @eec_mode: EEC_mode * diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c index 3be1bfb16498..f6559b1d1433 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c @@ -2635,9 +2635,9 @@ void ixgbe_release_swfw_sync(struct ixgbe_hw *hw, u32 mask) /** * prot_autoc_read_generic - Hides MAC differences needed for AUTOC read * @hw: pointer to hardware structure - * @reg_val: Value we read from AUTOC * @locked: bool to indicate whether the SW/FW lock should be taken. Never * true in this the generic case. + * @reg_val: Value we read from AUTOC * * The default case requires no protection so just to the register read. **/