From patchwork Fri Mar 8 17:14:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10845189 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA64F922 for ; Fri, 8 Mar 2019 17:14:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A8E3F287A5 for ; Fri, 8 Mar 2019 17:14:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CAD5287C9; Fri, 8 Mar 2019 17:14:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F30128761 for ; Fri, 8 Mar 2019 17:14:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726864AbfCHROf (ORCPT ); Fri, 8 Mar 2019 12:14:35 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52721 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbfCHROf (ORCPT ); Fri, 8 Mar 2019 12:14:35 -0500 Received: by mail-wm1-f66.google.com with SMTP id f65so13219867wma.2 for ; Fri, 08 Mar 2019 09:14:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b1aZaa7qJ/t0zmMfl0v7mjZ2rBQkdXS8aoMYMSi7kTE=; b=QmXCtfpIEAxG1ONhBw/r48JW84/muJ903Zco+ZNy4KaWiu9npNWnoBUF0lpLxYVypl pspxcSS85Qfvbvzq4MCXLOkhiEZqIbM6/rKishimMRldFH0ioPhX/tybAr27ZiNIrwtJ lxQupdQG4wa5Ng4kkisbNZop7ect7ZU1kCAlfn8HhZY24UUKng2d9c14XZo/4veAEGpN ozQznQgSREumcPPMgX/MHQRWmsmwGRFAAm/8wwHSEr+IUt0Af2K5ut/b0SaiHvajDTNm +525isgLMZNupwvCiNJ+gHrvJBKuWjxDKt+hYmlEdbSkThL6mRecG+snjuugcxyVz7uB wIGQ== X-Gm-Message-State: APjAAAWoh4uQ+CYPSKCk1oKbjYpH90QtMtfWafeZtnXwdWWRGmrDPxJF /ebASibtGRWusrVKUhI3XZc= X-Google-Smtp-Source: APXvYqzPRHinbRampi91Uvz5NabFbAUjo2LAZKYqZmsKAiuophNHHZe8lS7J8PBrVaAoUefO800b5Q== X-Received: by 2002:a7b:cc86:: with SMTP id p6mr9468698wma.32.1552065273571; Fri, 08 Mar 2019 09:14:33 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id o5sm6126796wmh.12.2019.03.08.09.14.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 09:14:33 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 1/4] kernel-shark: Define addPlugin method for KsPluginManager Date: Fri, 8 Mar 2019 19:14:02 +0200 Message-Id: <20190308171405.15266-2-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190308171405.15266-1-ykaradzhov@vmware.com> References: <20190308171405.15266-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The method can be used to register and load a user-defined plugin. All other previously loaded plugins will be reloaded. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsUtils.cpp | 17 +++++++++++++++++ kernel-shark/src/KsUtils.hpp | 3 +++ 2 files changed, 20 insertions(+) diff --git a/kernel-shark/src/KsUtils.cpp b/kernel-shark/src/KsUtils.cpp index d7b1753..4d05bda 100644 --- a/kernel-shark/src/KsUtils.cpp +++ b/kernel-shark/src/KsUtils.cpp @@ -596,6 +596,23 @@ void KsPluginManager::unregisterPlugin(const QString &plugin) } } +/** @brief Add to the list and load a user-provided plugin. All other + * previously loaded plugins will be reloaded. + * + * @param fileName: the library file (.so) of the plugin. +*/ +void KsPluginManager::addPlugin(const QString &fileName) +{ + kshark_context *kshark_ctx(nullptr); + + if (!kshark_instance(&kshark_ctx)) + return; + + kshark_handle_plugins(kshark_ctx, KSHARK_PLUGIN_CLOSE); + registerPlugin(fileName); + kshark_handle_plugins(kshark_ctx, KSHARK_PLUGIN_INIT); +} + /** Unload all plugins. */ void KsPluginManager::unloadAll() { diff --git a/kernel-shark/src/KsUtils.hpp b/kernel-shark/src/KsUtils.hpp index cb95b4f..ae7f6d1 100644 --- a/kernel-shark/src/KsUtils.hpp +++ b/kernel-shark/src/KsUtils.hpp @@ -210,6 +210,9 @@ public: void registerPlugin(const QString &plugin); void unregisterPlugin(const QString &plugin); + + void addPlugin(const QString &fileName); + void unloadAll(); void updatePlugins(QVector pluginId); From patchwork Fri Mar 8 17:14:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10845191 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 16C77922 for ; Fri, 8 Mar 2019 17:14:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE3AB28B26 for ; Fri, 8 Mar 2019 17:14:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E26D22E0D6; Fri, 8 Mar 2019 17:14:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82A4728B26 for ; Fri, 8 Mar 2019 17:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbfCHROh (ORCPT ); Fri, 8 Mar 2019 12:14:37 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36358 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbfCHROh (ORCPT ); Fri, 8 Mar 2019 12:14:37 -0500 Received: by mail-wm1-f66.google.com with SMTP id j125so13103516wmj.1 for ; Fri, 08 Mar 2019 09:14:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d8qIf07kLv3HxeAuVR8KpZN9q8ZltOAblg+BDgthPg8=; b=sj/rolefxO2bR1JQScNTV0hKjT9SfT+J/6nFGrwSv/40rJ5uhNDKfdPUKq98ZNUle1 Vu/MgrFdJKnxD7AUeKD7Pm5zT4aV4nrUOfm1F4Xb9JVZKJJFynTy6vSyl9WdswDBVdYN h8gVHOTruN1M7z2cJ/xxZqse2B8vDoCsvguIozLCDeanpSp485aTYSfOjj1cBda8gXdo 1cM4KVGxPq2qETJ2If8wjfHdJSQkKNrUPbHiC3nUmJjZgaYkc6xK6T0JQZkhV3mmu9aU RZ/4SxkCjSXbWtJYGMobby/6st0qfics04VRJr22SSLKMkEWf5HphSRB08/sWHBa/Yvz H+ZA== X-Gm-Message-State: APjAAAUgHDBt6yuUKJSnmwiGK/X9ZHSBLgwKQcuyLwUpYrt7nad0Xl0q mm2pusISbSvEsK/7cdsa+bM= X-Google-Smtp-Source: APXvYqxAyuQ/F4QNO/pXtBfFp/W2c8l8E/c+V9E3uUQL4onbcMT3hmfQCKuQctovM+n+gqdDY+DdUA== X-Received: by 2002:a05:600c:2144:: with SMTP id v4mr9697814wml.4.1552065274992; Fri, 08 Mar 2019 09:14:34 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id o5sm6126796wmh.12.2019.03.08.09.14.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 09:14:34 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 2/4] kernel-shark: Add dialog for user-defined plugin to the Tools menu Date: Fri, 8 Mar 2019 19:14:03 +0200 Message-Id: <20190308171405.15266-3-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190308171405.15266-1-ykaradzhov@vmware.com> References: <20190308171405.15266-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The dialog allows the user to find and load the plugin's lobrary (.so file). Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsMainWindow.cpp | 20 ++++++++++++++++++++ kernel-shark/src/KsMainWindow.hpp | 4 ++++ 2 files changed, 24 insertions(+) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 362b955..004c9ac 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -59,6 +59,7 @@ KsMainWindow::KsMainWindow(QWidget *parent) _cpuSelectAction("CPUs", this), _taskSelectAction("Tasks", this), _pluginsAction("Plugins", this), + _addPluginAction("Add plugin", this), _captureAction("Record", this), _colorAction(this), _colSlider(this), @@ -233,6 +234,11 @@ void KsMainWindow::_createActions() connect(&_pluginsAction, &QAction::triggered, this, &KsMainWindow::_pluginSelect); + _addPluginAction.setStatusTip("Add plugin"); + + connect(&_addPluginAction, &QAction::triggered, + this, &KsMainWindow::_pluginAdd); + _captureAction.setIcon(QIcon::fromTheme("media-record")); _captureAction.setShortcut(tr("Ctrl+R")); _captureAction.setStatusTip("Capture trace data"); @@ -336,6 +342,7 @@ void KsMainWindow::_createMenus() /* Tools menu */ tools = menuBar()->addMenu("Tools"); tools->addAction(&_pluginsAction); + tools->addAction(&_addPluginAction); tools->addAction(&_captureAction); tools->addSeparator(); tools->addAction(&_colorAction); @@ -796,6 +803,19 @@ void KsMainWindow::_pluginSelect() dialog->show(); } +void KsMainWindow::_pluginAdd() +{ + QString fileName; + + fileName = QFileDialog::getOpenFileName(this, "Add KernelShark plugin", KS_DIR, + "KernelShark Plugins (*.so);;"); + + if (fileName.isEmpty()) + return; + + _plugins.addPlugin(fileName); +} + void KsMainWindow::_record() { #ifndef DO_AS_ROOT diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp index 969b603..a4eed19 100644 --- a/kernel-shark/src/KsMainWindow.hpp +++ b/kernel-shark/src/KsMainWindow.hpp @@ -132,6 +132,8 @@ private: // Tools menu. QAction _pluginsAction; + QAction _addPluginAction; + QAction _captureAction; QWidgetAction _colorAction; @@ -185,6 +187,8 @@ private: void _pluginSelect(); + void _pluginAdd(); + void _record(); void _setColorPhase(int); From patchwork Fri Mar 8 17:14:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10845193 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 277B514E1 for ; Fri, 8 Mar 2019 17:14:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0873F2E0D6 for ; Fri, 8 Mar 2019 17:14:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E708C28DE1; Fri, 8 Mar 2019 17:14:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A1E52FDAC for ; Fri, 8 Mar 2019 17:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726815AbfCHROi (ORCPT ); Fri, 8 Mar 2019 12:14:38 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:46476 "EHLO mail-wr1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbfCHROi (ORCPT ); Fri, 8 Mar 2019 12:14:38 -0500 Received: by mail-wr1-f42.google.com with SMTP id i16so22141036wrs.13 for ; Fri, 08 Mar 2019 09:14:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fEMG8i3cd/bPD/fZYAvwM7m/cMijjdt0l3+lKT1OcB4=; b=abKHe208lo74o8thj2vfu89odI9mBj04z9VDJCQc3GlXkuKXsvMTppoPW5jjfhKqz/ wNilGep6BJ5Zp7CsHh4FXzZSO0/rVI4qVWOUQWsFafH6/sJ+zWmIlyC8E67NciNiLRJ9 pCPdq6ATAQaz+bpgJFP+z8JtXMxmPabkW9QuoV5ZBGT99q+wpR20g0y2NgK4ce5EZbsr iKbz3afPFOcHk3G42DoGkgSN7JE75Rswz1oMEMBEkEmo/clZEDc6SbY2tC15ezxPn5e2 3yg+v9RqLk8aQRH/LQHU47xU4Vqf0nRLUNl8V7v6gq5H3/Dbng9540ozfnKVKEac7+EA xC9g== X-Gm-Message-State: APjAAAXIr4hdq3ZlxQsAm7WuymJxmnrKRWUYS/PWIYLJl727L5MTBHtK mBvvXRNO3MkwpkXcUEggMvw= X-Google-Smtp-Source: APXvYqxpJzfOaWfhBIyvQ+caFRNmS+pGQJMuHZYgw6HiyrvnywRRbUrUY2iDJncC2zeF63sE7MmcUg== X-Received: by 2002:a5d:4a43:: with SMTP id v3mr2866477wrs.249.1552065276449; Fri, 08 Mar 2019 09:14:36 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id o5sm6126796wmh.12.2019.03.08.09.14.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 09:14:36 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 3/4] kernel-shark: Rename the manu action for managing registered plugins Date: Fri, 8 Mar 2019 19:14:04 +0200 Message-Id: <20190308171405.15266-4-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190308171405.15266-1-ykaradzhov@vmware.com> References: <20190308171405.15266-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The menu action in Tools that is used to manage all registered plugins is renamed in order to avoid confusion with the "Add plugin" menu action, implemented in the previous patch. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsMainWindow.cpp | 10 +++++----- kernel-shark/src/KsMainWindow.hpp | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 004c9ac..f6889ca 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -58,7 +58,7 @@ KsMainWindow::KsMainWindow(QWidget *parent) _clearAllFilters("Clear all filters", this), _cpuSelectAction("CPUs", this), _taskSelectAction("Tasks", this), - _pluginsAction("Plugins", this), + _managePluginsAction("Manage plugins", this), _addPluginAction("Add plugin", this), _captureAction("Record", this), _colorAction(this), @@ -228,10 +228,10 @@ void KsMainWindow::_createActions() this, &KsMainWindow::_taskSelect); /* Tools menu */ - _pluginsAction.setShortcut(tr("Ctrl+P")); - _pluginsAction.setStatusTip("Manage plugins"); + _managePluginsAction.setShortcut(tr("Ctrl+P")); + _managePluginsAction.setStatusTip("Manage plugins"); - connect(&_pluginsAction, &QAction::triggered, + connect(&_managePluginsAction, &QAction::triggered, this, &KsMainWindow::_pluginSelect); _addPluginAction.setStatusTip("Add plugin"); @@ -341,7 +341,7 @@ void KsMainWindow::_createMenus() /* Tools menu */ tools = menuBar()->addMenu("Tools"); - tools->addAction(&_pluginsAction); + tools->addAction(&_managePluginsAction); tools->addAction(&_addPluginAction); tools->addAction(&_captureAction); tools->addSeparator(); diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp index a4eed19..0727631 100644 --- a/kernel-shark/src/KsMainWindow.hpp +++ b/kernel-shark/src/KsMainWindow.hpp @@ -130,7 +130,7 @@ private: QAction _taskSelectAction; // Tools menu. - QAction _pluginsAction; + QAction _managePluginsAction; QAction _addPluginAction; From patchwork Fri Mar 8 17:14:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10845195 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 457A114E1 for ; Fri, 8 Mar 2019 17:14:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28F1728931 for ; Fri, 8 Mar 2019 17:14:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 275EC28D61; Fri, 8 Mar 2019 17:14:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C92DA28D72 for ; Fri, 8 Mar 2019 17:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726818AbfCHROk (ORCPT ); Fri, 8 Mar 2019 12:14:40 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51844 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbfCHROk (ORCPT ); Fri, 8 Mar 2019 12:14:40 -0500 Received: by mail-wm1-f67.google.com with SMTP id n19so13207234wmi.1 for ; Fri, 08 Mar 2019 09:14:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FX6hXlBTlZ165tI/EewOYO80nEa1jieyDK8ocZCG1L8=; b=HnmjQhCF/tZaaYcHmeeYJtIqr2vTHTYojk6Kx9zM7S89KYD7ub4JHnVJhG4fqeTPc0 w1fmY85twEkEKYhwatNI8vG1kmzM04L+UW346VxK8Zw81m97XGIC0GXnXqkf653LFrt/ UAVl2oYIVdQzLEidWYOEpOw2rOKZHvoKwJvbUwwtwNjpQoeUjB1QLOSZoM85BgAc4QYW xNoCXsI8ZdCblQpoEPj72KkILPGQqdm4uL3Q9lbDa3WC7w4gb8tVPTLPz4qa1lfPxGEC cMAIr2saKLMOTV2ScuW1ypsAXZwBzQPNd7sKo2MFSFlt4DbJQNxvKrK/v7uu6sy+3iWK t+QQ== X-Gm-Message-State: APjAAAVdnPY59JawGfu+KDSK8rASSeWPBNOx+j/8+uHT6g8TUwpE/Xqc cj3d+y505xmnfiQZcqN1Pe8= X-Google-Smtp-Source: APXvYqxV71L+PZDQf/LXPQ717EYjLiAD4eBuGkfHcfktdTTVNBU2kbBNEF7NGlmO9VZlAD6skmpKGw== X-Received: by 2002:a1c:9c12:: with SMTP id f18mr4188957wme.16.1552065278411; Fri, 08 Mar 2019 09:14:38 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id o5sm6126796wmh.12.2019.03.08.09.14.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 09:14:38 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 4/4] kernel-shark: Add icons for "Add plugin" and "Manage plugins" Date: Fri, 8 Mar 2019 19:14:05 +0200 Message-Id: <20190308171405.15266-5-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190308171405.15266-1-ykaradzhov@vmware.com> References: <20190308171405.15266-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Just a small cosmetic improvement. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsMainWindow.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index f6889ca..782b230 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -229,11 +229,13 @@ void KsMainWindow::_createActions() /* Tools menu */ _managePluginsAction.setShortcut(tr("Ctrl+P")); + _managePluginsAction.setIcon(QIcon::fromTheme("preferences-system")); _managePluginsAction.setStatusTip("Manage plugins"); connect(&_managePluginsAction, &QAction::triggered, this, &KsMainWindow::_pluginSelect); + _addPluginAction.setIcon(QIcon::fromTheme("applications-engineering")); _addPluginAction.setStatusTip("Add plugin"); connect(&_addPluginAction, &QAction::triggered,