From patchwork Tue Oct 1 11:27:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20803CE7D0D for ; Tue, 1 Oct 2024 11:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=23R0TZIA0axsqA2eYwuXEJ8B9IwUUAXH2P+ON9b6WwU=; b=hzjXlNTESxhisCrAnfJYHe5sd3 eY2Dkjb2dRH6TckpTj9qpY4MqBjqJ2UY3rOeYbXvLYdsbt6FgkomhkV+Edsm81uRnKqnXPq3yzqhV /OP6kv0yqTTi0IaP8CM29mLakDfJRi4tn91LKTfcZYFEtrNUpzUr2jsAiNLTx0PCrIEjw3eXrzQ9S KGjPlD223CKpLftatyZ+kk7rqE26Y+mptxTRILEg+CNKTP8W2gITgcoBFjsQ9kcrk0auzUDZibu/Q OG/5aUrlx/Ft4SV15lVy3KdRWV1PW76f5f31hIELWhP3/viEbVsG8aHqPkik6q3J02SzXjKqj5heY Gi60OMzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbAx-00000002Xf6-1jSm; Tue, 01 Oct 2024 11:36:19 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb68-00000002WGW-1uxs for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:21 +0000 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-7179069d029so3890855b3a.2 for ; Tue, 01 Oct 2024 04:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782280; x=1728387080; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=23R0TZIA0axsqA2eYwuXEJ8B9IwUUAXH2P+ON9b6WwU=; b=giZg4nvxjE11ZvdCmn+zWvtdyLxBeAJ9ZJ2lr+2GwVHTADaUrSpX164UUn43N/HP8g K4Kqk0AhFZU1d6ZlzubdzZckyQCrHQwckp1pIIK/yLsHWAxZt2cLleDMuyb8Kn6iE9Ll WZ48UxShw+S9ip/IZBcxeFOCLxUYqaVQ8KZRk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782280; x=1728387080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=23R0TZIA0axsqA2eYwuXEJ8B9IwUUAXH2P+ON9b6WwU=; b=aLRczWUdHYJentjEMzp1d5o/o0PQQtCoW/EBom/sNfw58pfRFhX4REpwyV8Mu6UXA4 JILInWvAe2MOguCykQNH2w4US/uh7dEfPnnrywM/gKEMKtYzPMPiAyiRWmkRCc3mJR6o gzAnzYamaKbjXhdQ6tj/Fbfai1IOGt9FSrFCQr84CX/PrhFzdPdQp1r8//fDqlT7t8Tt vU2eTaGLvY/ThUFyYcwp2Z7tfFctPfWIbHjTNmqZOJq2BetuCdKfaMr+UWKNcp6o3TQ8 yUv878J7FJTtElI+4O8oB3YePmknI4Uowu5rRowdgulf5eMkfI2bDEac/nyhJNLREl9D fCng== X-Forwarded-Encrypted: i=1; AJvYcCUGg4rROMSmJU0e2lHqXG2a9XSdjJ737oNP95yOmPKArPOEUE9XXNGk8vRtAKE2xGRdXAghzTFcF8hkDazE9e0S@lists.infradead.org X-Gm-Message-State: AOJu0YzMto1DVPVw5yPhEXe/cEt0tXaVmFIkzkb6Y2KE4otfonqHZruL W/mzdz+NuJELJSEXMuR9rfAx64LqHlFN/HrnvdeMeX6HGUQfgX1LiAxR5h9u7Q== X-Google-Smtp-Source: AGHT+IF0uBLqB/6IIB8dOP9zNZ4TWM/ZpZfM3H+BJ9RdIgLyjCLjfViOtBRFUY/B925GuvlwYj39cg== X-Received: by 2002:a05:6a00:194f:b0:70d:1dcf:e2b4 with SMTP id d2e1a72fcca58-71b25f00bf2mr23616838b3a.1.1727782279856; Tue, 01 Oct 2024 04:31:19 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:18 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , "Rob Herring (Arm)" , Conor Dooley , Fabien Parent , Krzysztof Kozlowski , MandyJH Liu , Matthias Brugger , Ulf Hansson , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 1/8] dt-bindings: power: mediatek: Add another nested power-domain layer Date: Tue, 1 Oct 2024 19:27:19 +0800 Message-ID: <20241001113052.3124869-2-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043120_563074_C271DAFA X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MT8188 SoC has a more in-depth power-domain tree, and the CHECK_DTBS=y check could fail because the current MediaTek power dt-binding is insufficient to cover its CAM_SUBA and CAM_SUBB sub-domains. Add one more nested power-domain layer to pass the check. Acked-by: Rob Herring (Arm) Signed-off-by: Fei Shao --- (no changes since v1) .../devicetree/bindings/power/mediatek,power-controller.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml index 8985e2df8a56..a7df4041b745 100644 --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml @@ -54,6 +54,10 @@ patternProperties: patternProperties: "^power-domain@[0-9a-f]+$": $ref: "#/$defs/power-domain-node" + patternProperties: + "^power-domain@[0-9a-f]+$": + $ref: "#/$defs/power-domain-node" + unevaluatedProperties: false unevaluatedProperties: false unevaluatedProperties: false unevaluatedProperties: false From patchwork Tue Oct 1 11:27:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817891 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E73ACCE7D10 for ; Tue, 1 Oct 2024 11:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HExE/eexnESQrLRIjvabM8eZD3ePYvWvDq6AbBnCJhI=; b=KcwSXWoCfWFboguZqiOJtJPKzQ 5Ov/niFghlx2a0/wcJMPVInGf9vB8YgZXSJU1zcn7A1fRrw9sQkhuBO8i3gSoHN8zVp5sIbJe/oQF 87Or4sS7W7Gif865zl1BJQL3gK1s7dW1rvMgqRGbZlQYXIbO98bUQVoDp2cXZR9VsMHAxBFq29HfG biHdAsQ+kR/FJN96DRDEihDxrDAGdqGbMPgjG3x0Gq0pdKaPcCeONo3qH9hgovQXH3AiuIjfDXIWS SawPJ4KRW3GZL3Oy7JrvpuG7AxY6yV4FZg2u34xkL1mtnQQOMSmguKCM3A9e0Io2Q/kvUPhhdCRnd hYvy2jlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbEb-00000002YQb-3af2; Tue, 01 Oct 2024 11:40:05 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb6C-00000002WIo-3Z7P for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:26 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-71b00a97734so4687806b3a.1 for ; Tue, 01 Oct 2024 04:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782284; x=1728387084; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HExE/eexnESQrLRIjvabM8eZD3ePYvWvDq6AbBnCJhI=; b=H4SAEiobGxBVSGRi+gsIsYrMuTBlMfuf0qfMz03t2PHRv1OLPC5zo0GvKKkQYkyYRI ZjEBXSddUEg9AueW+EsIbTS0Mn5WFmCVrLl0TtqstkJEVxvFLpLzUbGux8vY9IBY1Jzm gTZdokymoVW0isbKzWyPYoxk9rIVgIxJB2Yts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782284; x=1728387084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HExE/eexnESQrLRIjvabM8eZD3ePYvWvDq6AbBnCJhI=; b=TvoNAgzZG9SHZMyBQWeDv/DSLNsIe3QH2c1RCxVHTg9QZKVegvnEXPXiZ/0nM1opI0 xUyFQ4EkvZHmOgR7ju/Xwbx8QNOHQtrhMOfGVh1TsIqLtYXbmghe86NpLlFsYHFbtjDN RjiAifAarErukbIZnUIHu0ofbOslq4lfOeRld18QLA8HRNUyE2nLTZ6jB09xDI0nVysd sKKP3GAudz3fOfan+JUuQIdgcFCUCH0EBkKtC4ugZHy3Uml6HtEfGek0qgXI4hUJDGL2 bBUiniEFXtnHzMvgDMSveSwVPQ3ZLzpQb2qGpCd1vgAbkKyPOBpqwm8aysR3tsu9R3rF BH+A== X-Forwarded-Encrypted: i=1; AJvYcCUhLNRyevW90mVvlF7o/guj4a+3vaRaWjo5agyt87vTwZuwvq2IuK6yKILMrC/uTFJe3L5EJ039WyCGM6RCo/c/@lists.infradead.org X-Gm-Message-State: AOJu0YyOlKKYskryAal9oMITyTDCwa3Aq9gc2s0lcpiI0GUeXvQtkNpT KGSL0gybsh52rGMhgT2E1biGGYgvu3s+DRrhkZBeJwT5MYcwriHT4hfmAltsNA== X-Google-Smtp-Source: AGHT+IEKMhrohdkvwi4Udq7vmrZm1RN5zUB0skQ6nIN1r9c0R1TPgRRbL55DWTsl/CIJ8EZMUnlJMA== X-Received: by 2002:a05:6a00:8c2:b0:710:bd4b:8b96 with SMTP id d2e1a72fcca58-71b26079af9mr22686021b3a.28.1727782283633; Tue, 01 Oct 2024 04:31:23 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:23 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , Krzysztof Kozlowski , Bjorn Helgaas , Conor Dooley , Jianjun Wang , Krzysztof Kozlowski , =?utf-8?q?Krzysztof_Wilczy=C5=84s?= =?utf-8?q?ki?= , Lorenzo Bianconi , Lorenzo Pieralisi , Manivannan Sadhasivam , Matthias Brugger , Rob Herring , Ryder Lee , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org Subject: [PATCH v2 2/8] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Date: Tue, 1 Oct 2024 19:27:20 +0800 Message-ID: <20241001113052.3124869-3-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043124_919561_6F3FF397 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In MediaTek PCIe gen3 bindings, "clocks" accepts a range of 1-6 clocks across all SoCs. But in practice, each SoC requires a particular number of clocks as defined in "clock-names", and the length of "clocks" and "clock-names" can be inconsistent with current bindings. For example: - MT8188, MT8192 and MT8195 all require 6 clocks, while the bindings accept 4-6 clocks. - MT7986 requires 4 clocks, while the bindings accept 4-6 clocks. Update minItems and maxItems properties for individual SoCs as needed to only accept the correct number of clocks. Fixes: c6abd0eadec6 ("dt-bindings: PCI: mediatek-gen3: Add support for Airoha EN7581") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Fei Shao --- (no changes since v1) .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml index 898c1be2d6a4..f05aab2b1add 100644 --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml @@ -149,7 +149,7 @@ allOf: then: properties: clocks: - minItems: 4 + minItems: 6 clock-names: items: @@ -178,7 +178,7 @@ allOf: then: properties: clocks: - minItems: 4 + minItems: 6 clock-names: items: @@ -207,6 +207,7 @@ allOf: properties: clocks: minItems: 4 + maxItems: 4 clock-names: items: From patchwork Tue Oct 1 11:27:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6723CE7D0D for ; Tue, 1 Oct 2024 11:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RLdzbrr7qqklLHRlLDBt3HAIeNP30xh3waq/7+yRzz8=; b=E51UlMLWhkhm34kPA+65H3qriG 1TqR8dpgF/W22y0fYtzzY1B/0cMtHgkQV6NCLa9WY9+PgyhlHLviCwtWwb+PdDQdj6PM1fLCa4kXT J5fmd7raC9AtB3NpPZLw60T7ILz/RdaxM0oEC8SS5GK0ktdlzAOSM/uD76JocFEVf7AixSWhmja+A JR58jIru/NfqAX2pZPhd7Ki6+ywRkcUl/KzynhDyEsX9SOi0x1jS6SpzMyTMHndq+jzTXHS4VGCJz nVi1yXYQVLJO9nPK/UlR9/FexW2HqmdM0FVg0+iZDTj4KqGtA+VEFFXS7C0NVijyHjAQIod3TOMJH tKHZ85qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbGz-00000002Ykd-2ks7; Tue, 01 Oct 2024 11:42:33 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb6F-00000002WLO-3wzN for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:29 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-7198de684a7so3734036b3a.2 for ; Tue, 01 Oct 2024 04:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782287; x=1728387087; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RLdzbrr7qqklLHRlLDBt3HAIeNP30xh3waq/7+yRzz8=; b=KHi8YPS8atkzZgX0PkelN9BiRWxVk6L42X4OZRVcpkftmIE+zL5POEmlemXMSbCh4n yGUKW7zx7Lm6Yfb13gH2VSXuVcp47F7O2VeYmag31vlasRGBfXdJiqn6goMfiKEPGdIX rChx6CzsxYJNem5rlqeixkxIiySzMD0EHL8wY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782287; x=1728387087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RLdzbrr7qqklLHRlLDBt3HAIeNP30xh3waq/7+yRzz8=; b=uVZTqYTTI8lDs6iBh+cq2xa7cf9IKpY42hEel5loTcGYf159WwgnCFMlOn8FCNpQKs jGBG+CRPSmOBBnx1fsaOrTWOAJ/7tJ8GtqeoltLpyFhYVleN/NZVQYyHYcVDC8H9S942 iiKg1bM7omyPv5RHMahYg+WWWAUE40+W+Ow3p6OHoOBWvBmjjaVbSkafHGAF8N8HGTPs zXYvfgFsE1rYTbVw9kCNPGTclrFjW/Nhb3mNSLwoQBhoFK9z6XDxhidckUX9pztRRqZE gGnqmMV4hdpC6h/XgoTDjIDRylNauyRpgfyeBgPuN8vy+658QSziy6pPhSowxDeMDUmZ v4IQ== X-Forwarded-Encrypted: i=1; AJvYcCUnAM4VP4j8DvFHy0s4cz01ZfbvpEFfTFfL83v5ECh3YWamM+jmgJsEDxzxsaymtIRHaS4b8UOR28hfkLkG5IR2@lists.infradead.org X-Gm-Message-State: AOJu0Yz1jD0GaeHuCBc7Sz6MzUYVm+Vd14JD09z/B2UrwrCqjiXYQx9D FNe0yxaGzyxK+kXkOtd0kHnYYpRimt+pzEKV6HIPV6GT/5EDj7ZRtdz8ts6GaA== X-Google-Smtp-Source: AGHT+IEgct/3Kv8qNzy6ataUfgMbDap5NRUyRDA2O/6Uj+INj/mxGJhKqWWS0ioNmqqYyO5Ym6qkyQ== X-Received: by 2002:a05:6a21:e8b:b0:1d2:e94d:6e6d with SMTP id adf61e73a8af0-1d4fa806eb0mr21813265637.45.1727782286787; Tue, 01 Oct 2024 04:31:26 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:26 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , Bin Liu , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Mauro Carvalho Chehab , Rob Herring , Xia Jiang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 3/8] dt-bindings: media: mediatek,jpeg: Relax IOMMU max item count Date: Tue, 1 Oct 2024 19:27:21 +0800 Message-ID: <20241001113052.3124869-4-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043128_043301_0B410E52 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On MediaTek platforms with Multimedia MMU (M4U), a multimedia hardware can be assigned with a local arbiter (LARB) which has a maximum of 32 ports for MediaTek's IOMMU infrastructure. That means there can be at most 32 items in the iommus property in theory. Instead of relaxing the max item count every time a newly introduced device tree hits the limit, bump the number to 32 as an one-time effort. On the other hand, all existing and foreseeable JPEG decoder nodes at this point have at least 2 IOMMUs, so set minItems to 2 accordingly. Signed-off-by: Fei Shao Acked-by: Krzysztof Kozlowski --- It's not in the upstream tree yet, but the upcoming MT8188 DT will have 6 IOMMUs in its JPEG decoder. This patch is to pave the way for that. Changes in v2: New patch. .../devicetree/bindings/media/mediatek-jpeg-decoder.yaml | 3 ++- .../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml index cfabf360f278..a4aacd3eb189 100644 --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml @@ -44,7 +44,8 @@ properties: maxItems: 1 iommus: - maxItems: 2 + minItems: 2 + maxItems: 32 description: | Points to the respective IOMMU block with master port as argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details. diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml index 83c020a673d6..5b15f8977f67 100644 --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml @@ -39,7 +39,7 @@ properties: iommus: minItems: 2 - maxItems: 4 + maxItems: 32 description: | Points to the respective IOMMU block with master port as argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details. From patchwork Tue Oct 1 11:27:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52276CE7D0D for ; Tue, 1 Oct 2024 11:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ejGJNBzCUSn/2STvxEtP4Qm9W+BBPtGa+kdNm7gnwwU=; b=NLXbcdjqt57S8rkE2HqwfL1lM8 SXjP88jGzG9f2keRm8dZYsVS4AJT2uDwUVWsfPNJXYhWtdEu8ULxZoW5IlQhiR/EXLiApQ53zNB8E QdBGCHprY6G4Xf4N7LWK8UFEVA8VetM2Glygqdj50B0t4PWjBbISm2ys66cRse03fsNpebs64Zetz Tp0dMchW0Wb5WbDt6YDEJP2T3VdBf5oXK2K4RVKFMBU2jaCUgZdX9c4E3kVdIELlf0uad89PbAb+e kAGrPToQMrzujDus6XVpmJv5bQjzqPTHxFb9dL1uLBWedb2f8IBFNMv5xjF+D441fdNoMnFMOZNnu zFcnu2OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbID-00000002Z6M-2ogy; Tue, 01 Oct 2024 11:43:49 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb6I-00000002WMv-3ikc for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:32 +0000 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-6e7b121be30so3593824a12.1 for ; Tue, 01 Oct 2024 04:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782290; x=1728387090; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ejGJNBzCUSn/2STvxEtP4Qm9W+BBPtGa+kdNm7gnwwU=; b=WnAlb3q611HZwRtoSAbWFYm0pNwxESrRwP/2fgdL5YMOZrLC/3MgHsEyZ6E3ALWgxt T5DQSQY5PRtFVB+3ytG+mYI2ZdACWNAfCXD7cD1GGHiH1pSnktoOxpcTYaXXLvL4LMbu CGzHdekM0VJ8/PLgbCTEfiUgR7/dj8yQWxNlY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782290; x=1728387090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ejGJNBzCUSn/2STvxEtP4Qm9W+BBPtGa+kdNm7gnwwU=; b=sPHeRezuVuRHJm8WbG7Xmm/1HWZYWLv5Y4X8DXVltUkPI4ltDxKDHTw0EUjjyPIN9i xrEamrWiUI+cj64pSBEbEwdBdx5772KflwSiMFBZPyzNytXlY1PHvo1pguJem0+TFomm BwRoBCyxJJ7oVxwGO3hDH88ElfIwFLfX4UrSxgCPIuNqgogoxufzZ0JYOwEIQMHr9uOb 0jZ2SSbUZGmrmmqwn3kjoMbOMDFvPUpA96O9SlTY+ct8QCMJBbaGOEukvIa+Tmfoj4iX dEEtLfCj8EZasdWqa9ypPaaE79fbsct9Ds5eOA4+fG0Fv/xO9N01ECtx+bk9AACAes4t ilVw== X-Forwarded-Encrypted: i=1; AJvYcCVkjM5SFMblmFnsDA39QJ+mVFkWp9CZm85vB/B1j/AmLuic+rpxFD+kImPyQAcI4+Buieb9f842yUgnI+9GeKW2@lists.infradead.org X-Gm-Message-State: AOJu0YwydkACfvfVs2iSOuyf+A9a+HqOj9Z14U0K/bhIxkbcEZDqk1m8 sNpVPT79d4JW7endGa9+dsd00jv1kmXOK1h/3UbWQAgrS0ng3gbin4jQvBakAyeY9IDTUEKdKiE = X-Google-Smtp-Source: AGHT+IGmqm0A1CKXunN+IYhXZlTEbv5bvkc+2qchW2O8DdvX6JHtqPJaxZtG+8eE9yYDL747Fo4WoQ== X-Received: by 2002:a05:6a21:1583:b0:1d4:e500:ad6c with SMTP id adf61e73a8af0-1d4fa64d6a4mr21967043637.3.1727782289986; Tue, 01 Oct 2024 04:31:29 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:29 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , Andrew-CT Chen , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Mauro Carvalho Chehab , Rob Herring , Tiffany Lin , Yunfei Dong , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 4/8] dt-bindings: media: mediatek,vcodec: Revise description Date: Tue, 1 Oct 2024 19:27:22 +0800 Message-ID: <20241001113052.3124869-5-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043130_953996_EB931BE3 X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Revise the description of MediaTek video decoder to improve wording, fix typos, simplify diagram, and extend the pipeline architecture used in newer MediaTek SoCs (MT8186 and MT8188). Signed-off-by: Fei Shao Acked-by: Krzysztof Kozlowski --- Feedback are welcome. I've tried my best to organize the existing information with some educated guesses, but there might be inaccuracies or gaps still. Please let me know if you have anything to add so we can make this more comprehensive. Thanks! Changes in v2: New patch. .../media/mediatek,vcodec-subdev-decoder.yaml | 100 +++++++++++------- 1 file changed, 59 insertions(+), 41 deletions(-) diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml index a500a585c692..52a96a5aec96 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml @@ -5,52 +5,70 @@ $id: http://devicetree.org/schemas/media/mediatek,vcodec-subdev-decoder.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Mediatek Video Decode Accelerator With Multi Hardware +title: MediaTek Video Decode Accelerator With Multi Hardware maintainers: - Yunfei Dong description: | - Mediatek Video Decode is the video decode hardware present in Mediatek - SoCs which supports high resolution decoding functionalities. Required - parent and child device node. - - About the Decoder Hardware Block Diagram, please check below: - - +------------------------------------------------+-------------------------------------+ - | | | - | input -> lat soc HW -> lat HW -> lat buffer --|--> lat buffer -> core HW -> output | - | || || | || | - +------------||-------------||-------------------+---------------------||--------------+ - || lat || | core workqueue - -------------||-------------||-------------------|---------------------||--------------- - ||<------------||----------------HW index---------------->|| - \/ \/ \/ - +-------------------------------------------------------------+ - | enable/disable | - | clk power irq iommu | - | (lat/lat soc/core0/core1) | - +-------------------------------------------------------------+ - - As above, there are parent and child devices, child mean each hardware. The child device - controls the information of each hardware independent which include clk/power/irq. - - There are two workqueues in parent device: lat workqueue and core workqueue. They are used - to lat and core hardware decoder. Lat workqueue need to get input bitstream and lat buffer, - then enable lat to decode, writing the result to lat buffer, dislabe hardware when lat decode - done. Core workqueue need to get lat buffer and output buffer, then enable core to decode, - writing the result to output buffer, disable hardware when core decode done. These two - hardwares will decode each frame cyclically. - - For the smi common may not the same for each hardware, can't combine all hardware in one node, - or leading to iommu fault when access dram data. - - Lat soc is a hardware which is related with some larb(local arbiter) ports. For mt8195 - platform, there are some ports like RDMA, UFO in lat soc larb, need to enable its power and - clock when lat start to work, don't have interrupt. - - mt8195: lat soc HW + lat HW + core HW - mt8192: lat HW + core HW + MediaTek Video Decode Accelerator is the video decoding hardware present in + MediaTek SoCs that supports high-resolution decoding functionalities. + It consists of parent and child nodes. + + The decoder hardware block diagram is shown below: + + +------------------------------------------------+------------------------------+ + | | | + | input -> LAT-SoC HW -> LAT HW -> LAT buffer --|--> Core HW -> output buffer | + | || || | || | + +--------------||-----------||-------------------+-------||---------------------+ + LAT Workqueue | Core Workqueue + ---------------||-----------||-------------------|-------||---------------------- + ||<----------||---------HW index--------->|| + \/ \/ \/ + +-------------------------------------------------------------+ + | enable/disable | + | clk power irq iommu | + | (lat/lat-soc/core0/core1) | + +-------------------------------------------------------------+ + + The child nodes represent the individual hardware blocks within the decoding + pipeline, such as LAT-SoC, LAT and Core. + Each child node is responsible for managing the dedicated resources of the + hardware, such as clocks, power domains, interrupts and IOMMUs. + + The parent node is a central point of control for the child nodes. + It identifies the specific video decoding pipeline architecture used by the + SoC, manages the shared resources like workqueues and platform data, and + handles V4L2 API calls on behalf of the underlying hardware. + + The parent utilizes two workqueues to manage the decoding process. + 1. LAT Workqueue, for LAT-SoC and LAT decoder: + Its workers take input bitstream and LAT buffer, enable the hardware for + decoding tasks, write the result to LAT buffer, and disable the hardware + after the LAT decoding is done. + 2. Core Workqueue, for Core decoder: + Its workers take LAT buffer and output buffer, enable the hardware for + decoding tasks, write the result to output buffer, and disable the hardware + after the Core decoding is done. + + These hardware decode each frame cyclically. + + The hardware might be associated with different SMI-common devices. + To prevent IOMMU faults during DRAM access in such cases, each hardware with + the unique SMI-common device must be placed under a separate parent node in + the device tree. + + LAT-SoC refers to another hardware block that connected to additional LARB + (local arbiter) ports, such as RDMA and UFO. + It requires independent power and clock control to work with LAT decoder, and + it doesn't have a dedicated interrupt. + + The used video decoding pipeline architecture across various Mediatek SoC: + MT8195: LAT-SoC + LAT + Core + MT8192: LAT + Core + MT8188: LAT + Core + MT8186: Core properties: compatible: From patchwork Tue Oct 1 11:27:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 440DDCE7D10 for ; Tue, 1 Oct 2024 11:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LkkLEEucgoW7bgbQKsmRzFtFQZp/ikQpw3ZnY6QygrQ=; b=MzkE/6LeQX8cyZ+1A0N2b7zToo AeNumMQLnwuoSR31ZOwAT3N7FUheE9rawC1u7MwVxnnmEiLVJKwh5xicsWi7UJhXmn07Fv2xVx6z3 fD89yibeKL62IMjMlxFjcwAAP2hQmGeJ3LdlC8ogwVkpHJWZ0TwBuhMO479XKTGh65GQaPkaEbkvD gT/aDsGOXnBgl0HY9dKEGv76NHmH7YYZ9oA3VyB+7P/ST5+0x1N3LiFFqjg6gGK8+rt4xfxX3wbBP DafQ9lZktttzbqLODaDcSggyBO803CllWt3Y4r4W5gK98TYIIY8VwBj1/NxzeXO6Zc57BfqGycj7c GBff3TkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbJR-00000002ZUJ-2ZoS; Tue, 01 Oct 2024 11:45:05 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb6L-00000002WOB-3aCQ for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:35 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-71971d2099cso4356717b3a.2 for ; Tue, 01 Oct 2024 04:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782293; x=1728387093; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LkkLEEucgoW7bgbQKsmRzFtFQZp/ikQpw3ZnY6QygrQ=; b=XE946Lp6tpMajEzMlSuHk4+WaHnfxhnldGA/T6GJGVyiIYr7ZzzA2K3XeHh8cCj7Qk j1Zx+4B06vWb4wYG20u+B/V8g/4ESi+2LHxKFTP6TfuhGCZ7uPtDhzYBgJNJPLseoVZo /EuBBS/6dnodQHxWt79imVfeiFgqyHsPO1DHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782293; x=1728387093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LkkLEEucgoW7bgbQKsmRzFtFQZp/ikQpw3ZnY6QygrQ=; b=ERLtelWTurwz/QnX+5BwdmZn7MTNV8TH102cD3tDbzxYsrx8LQsnoONrXdL5XOM+LF Q65Wh2MaOnPLL5EoDnbgr1CzOmsdcmirgrdpZb0enDl3KPMLiBBrsWk7CuS4FiXIGBX/ Vn9IxCc2V3zbjU8JmjETl614rpcuq403i4ekrArrt++kbndklvIO7fHwKWECP0IVLNJI HTAkAeQie2LJ4eBOIcD7XQ5tC9lsUOdi3Zd58YbfeZ0uCQXt6kW+nDNZoNm17KjeWWpy 9S9T3H+/RGjKeOSy3aH9/KWcKy8BET+A17t+wlEbeMhHBxvIK7U+Ap26wSe5erRyqZUi 8Yvg== X-Forwarded-Encrypted: i=1; AJvYcCXUS/wpSjNRvF54W/rDG0k9bGk875RLDPvgIXM5JUX8qDWSL9eYfBYWn2vhQ8wpnRaTPqjG5h4JyDmnwT2fcpwX@lists.infradead.org X-Gm-Message-State: AOJu0YzU4Jdx08ynnVEYIBwsrQSBcgFGZSKW//t5l9v5AEy/8yHXeGsQ wx6RUXQ29oVWIjfdkn36DL6r3n6/LBME2koy6fsRNAXoVKEqrl4dNd2vevxsng== X-Google-Smtp-Source: AGHT+IEgzRkoFd2sNCI4/vjWyPLOdY4pO3TPXtmTpmnMfuOP0TUArqKEjA+xqCTmER3Sm89xeggSoA== X-Received: by 2002:a05:6a00:194f:b0:717:e01d:312f with SMTP id d2e1a72fcca58-71b26078cf5mr25062339b3a.27.1727782292819; Tue, 01 Oct 2024 04:31:32 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:32 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 5/8] arm64: dts: mediatek: mt8188: Add missing dma-ranges to soc node Date: Tue, 1 Oct 2024 19:27:23 +0800 Message-ID: <20241001113052.3124869-6-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043133_918924_92EA7EFA X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the missing dma-ranges property to the soc node, similar to how it was done for MT8195 and MT8192. This allows the entire 16GB of iova range to be used and enables multimedia processing usages, like vcodec and MIPI camera. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Fei Shao --- (no changes since v1) arch/arm64/boot/dts/mediatek/mt8188.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi index cd27966d2e3c..69390da9cfe0 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -878,6 +878,7 @@ soc { #address-cells = <2>; #size-cells = <2>; compatible = "simple-bus"; + dma-ranges = <0x0 0x0 0x0 0x0 0x4 0x0>; ranges; gic: interrupt-controller@c000000 { From patchwork Tue Oct 1 11:27:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CC24CE7D10 for ; Tue, 1 Oct 2024 11:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T7arz2GOR4HIAXAfbaFzx9rN3NGNRkgqXFpAbKN4p48=; b=UyAjFfv9C5t9nVUxmxK9kx1BAO xomaNiptm4bXFCNSLOazOtrResXyEiakPIQ+uw+ElH5Rl+ECYvoPstbjNAh1lKG53MaLr3DnTNlnE OINstbcDl+qq241fxNZe9CpOcOeFW1X/8PcgNjTf6bPqQhgWh+Bd5a5GQFoVSKe0ze5uPSJB4Fn3w YdnUdti8DD69lsUHceKXNq5IvnMKv4TLq2rYVXDExNCGA9YpKOs53yfzS32tlFZHWFmzlgkq+JtSS Z7R7f8cDia8T0l0ac5Kt7ujryUqpdkBQVtfB+ELln7iSfgV+YJyuocvgHVccKEiruYlat+HbiBpL+ v6PJy4Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbKc-00000002Zcv-0w4A; Tue, 01 Oct 2024 11:46:18 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb6O-00000002WPu-2Pn1 for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:38 +0000 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-7db908c9c83so3341891a12.2 for ; Tue, 01 Oct 2024 04:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782295; x=1728387095; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T7arz2GOR4HIAXAfbaFzx9rN3NGNRkgqXFpAbKN4p48=; b=ZIjlw9zDYm9tmj8H5dr487hj+HOPOpy+EeyplrbXTTpH3ShHRlzXhvqVz526H5pNXW NjJoUfF8T2OPB84BG+/jVxbGn7BxnzIXfe7x85oUnR2OubruzL1rDfmtUQ42TjgiE0sr KhlqFe888PcJPcX7acxUCCJbHOopeHXhwXoFE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782295; x=1728387095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T7arz2GOR4HIAXAfbaFzx9rN3NGNRkgqXFpAbKN4p48=; b=Rfe7V1KIw4EySTdgyytdGn246lHbYvE+yRUTGCLZX/ianNAFz4Z8be2HfbeHLkQiup 8UhMe+BFMdHN5+efIZSSdw1IPAnUXTpOCpqf7TZlOedrPXw6cqbUINTCcnuFcSY+5vxG DRldV8utyVTzW2Bu7RgRU79YJQOQVdvnCJI76d02ND1yOdchiAmTfLX7ji+tz3Zl0oCJ zm7/ezGUuHpesS3z5zOeCvVPBv1JWFOLOiCWOk80xBNwbQBwiNe0nQl9wVl/DMdEk2IF Jr7ecavguW0INVwf2PNBWarUn01TU9NHDl6av0aE6z6DAWbbwTL/9KeStEbhoEq7jaQx sHxQ== X-Forwarded-Encrypted: i=1; AJvYcCVLf+hh81hhROkHQVjashNUJ8Yo2qKdnnqNRihXkdgLhrLVUXUNKk1eLtETlFEsmeuNVz0n+R4FKmhHG2TfYsmD@lists.infradead.org X-Gm-Message-State: AOJu0YzWUHVVBQIh1NNLxqrGaLs8eL825cm0X2Cxp3nthgvf5/fKtKSv CgQo2x3KrDr3QqnHyKgPj+KqJCBYvnjLtqmLN9kfv1uCOEBbjST3jAscV7NT+A== X-Google-Smtp-Source: AGHT+IHdeJ+m2YdxFmcKkDEUnn9huq/Q65T1UQKcTtMSHmlkaYTIq2vIz4YB7usbL5TVj+ABMTIHsA== X-Received: by 2002:a05:6300:668c:b0:1d2:ba9c:6d9f with SMTP id adf61e73a8af0-1d4fa69ed6amr22343842637.17.1727782295442; Tue, 01 Oct 2024 04:31:35 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:35 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 6/8] arm64: dts: mediatek: mt8188: Update vppsys node names to syscon Date: Tue, 1 Oct 2024 19:27:24 +0800 Message-ID: <20241001113052.3124869-7-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043136_656312_6E971E72 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MediaTek mmsys is more than just a clock controller; it's a system controller. In addition to clock controls, it provides display pipeline routing controls and other miscellaneous control registers. On the MT8188 and MT8195 SoCs, the mmsys blocks utilize the same mmsys driver but have been aliased to "vdosys" and "vppsys", likely to better represent their actual functionality. Update the vppsys node names and compatibles in MT8188 DT to reflect that and fix dtbs_check errors against mediatek/mt8188-evb.dtb. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Fei Shao --- (no changes since v1) arch/arm64/boot/dts/mediatek/mt8188.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi index 69390da9cfe0..790315c1bdb3 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -1779,8 +1779,8 @@ mfgcfg: clock-controller@13fbf000 { #clock-cells = <1>; }; - vppsys0: clock-controller@14000000 { - compatible = "mediatek,mt8188-vppsys0"; + vppsys0: syscon@14000000 { + compatible = "mediatek,mt8188-vppsys0", "syscon"; reg = <0 0x14000000 0 0x1000>; #clock-cells = <1>; }; @@ -1797,8 +1797,8 @@ wpesys_vpp0: clock-controller@14e02000 { #clock-cells = <1>; }; - vppsys1: clock-controller@14f00000 { - compatible = "mediatek,mt8188-vppsys1"; + vppsys1: syscon@14f00000 { + compatible = "mediatek,mt8188-vppsys1", "syscon"; reg = <0 0x14f00000 0 0x1000>; #clock-cells = <1>; }; From patchwork Tue Oct 1 11:27:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E63ACE7D0D for ; Tue, 1 Oct 2024 11:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z8fXwFowiSq282GBggx76buGJQF3HVDXJm077wJTisA=; b=fHyR+d1PhFAt0FPCXQvQcwklkE 1w/f/V5RjaYqnXpuGs1K9gMZeJNdHiayOXAUFP5JUCst3TMG0j1x3bDCTWR00sDYxV+iMVtdpSnP/ k0hrx2BxYnlVe3X9q6HOzIw4thcN+WjBNM4OuOKrv+bX0uuLoyLaMnwXQzWgBQE/dverGNruRV7Z1 MMnHWNDtfeyRWoPnl/Bef/mXIVY/9yZxKgfzmJix2ibnWukSfnaISWtxX7ToaIUniRefeFnHGnK37 GbPFgKXZbrs7WSZObSEy8HYe3NGN5QZMV674ZDWP8GQoVIGGePunl8MCLIybJl/5mHAgH5Nm4M9BH 3aAJLG2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbLo-00000002Zp5-2cL7; Tue, 01 Oct 2024 11:47:32 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb6Q-00000002WRi-2bSJ for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:39 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-71b20ffd809so3998952b3a.0 for ; Tue, 01 Oct 2024 04:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782298; x=1728387098; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z8fXwFowiSq282GBggx76buGJQF3HVDXJm077wJTisA=; b=jCrmllnYlgYY15b7c+Bo9qL4+w/u1mhJ4Ll2OfsXI3SnwhU6s2ItpODFHw0RpipwXk JwDK4SFhDOmE7raF0hTZLlqxLr/WDC5K9Y5Wvrz6KKdnWx+1D/V5AtDrhYEeoXuEpkGk tX/KaGr0pbX7GwCghjRv/7C5EhW8O/Y7MeldQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782298; x=1728387098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z8fXwFowiSq282GBggx76buGJQF3HVDXJm077wJTisA=; b=gWvebEkovxyWibu3vFFBuMq2mRWbI0gij2WcUv/D9eb8CXNowj1jNgvlsj1+wXaCNZ Y53iF0xsjVDPteiVsOQVoQ7T/Kpp3vJIMTAGl2a09JuyOKhys/Qol0jedLrF28bLO+iJ VLt/IbG/va7cLGpxV8R71xK+yAvOYZ1ZvcvQCmFXetgEL54Sm7/yKf+qJKeoCd0+p4mj j5p/a55g6i5LorieqS764reQrI32KZz5ElliF1wn/+nULLuKMzFedH79TrL6OdLK8RxT lB95RxrNeCTctwsdfc7dTi7QWSv3AkRaZFXtfX4RmOcJ7tYOXINb7mLESA0XH/5LyrPV KnrQ== X-Forwarded-Encrypted: i=1; AJvYcCW5U/HPJd/okqtp1ZXjsb+vcRfqFM2HvAsUHqBKzOju6rANUYQWKERB1VrTVP3la8zt7VslukJvh2sc92BMtmbv@lists.infradead.org X-Gm-Message-State: AOJu0YxVwUosY1BlQS/b0fS4eeNTq+2M9KFFzw2U73VGcWJ6xlpP4oWW SY1OiwDTCqtXyBB9qI3cpMtf1IaxyF80EFIQxU/v+s7zuC2L6vEDEzNfupk0jw== X-Google-Smtp-Source: AGHT+IH09z3QCZ1p0pTjFjuPslZ4C1g3IxE08k1hiNGnKInQp2WoOjwX15K0+Vnyd5cLS3+99kg5ug== X-Received: by 2002:a05:6a00:17a9:b0:70d:2fb5:f996 with SMTP id d2e1a72fcca58-71b25f451e7mr23221279b3a.11.1727782298034; Tue, 01 Oct 2024 04:31:38 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:37 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 7/8] arm64: dts: mediatek: mt8188: Move vdec1 power domain under vdec0 Date: Tue, 1 Oct 2024 19:27:25 +0800 Message-ID: <20241001113052.3124869-8-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043138_680065_0497DA29 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MT8188 video decoder pipeline has two hardware IP blocks: LAT and Core, which are powered by vdec0 and vdec1 power domains, respectively. The hardware design includes a dependency between the vdec0 and vdec1 power domains to ensure that Core is powered down before LAT. Without correctly describing this dependency in DT, the system will fail to suspend. As a comparable reference, MT8192 also uses the LAT + Core decoding pipeline, and it has the correct power domain dependency defined in DT. Update vdec1 as a sub-domain of vdec0 in MT8188 DT to reflect the hardware design. Also, use more specific clock names for both power domains. Signed-off-by: Fei Shao --- Changes in v2: Revise commit message. arch/arm64/boot/dts/mediatek/mt8188.dtsi | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi index 790315c1bdb3..ca50ed20fca0 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -1062,20 +1062,22 @@ power-domain@MT8188_POWER_DOMAIN_VPPSYS1 { #power-domain-cells = <0>; }; - power-domain@MT8188_POWER_DOMAIN_VDEC1 { - reg = ; - clocks = <&vdecsys CLK_VDEC2_LARB1>; - clock-names = "ss-vdec"; - mediatek,infracfg = <&infracfg_ao>; - #power-domain-cells = <0>; - }; - power-domain@MT8188_POWER_DOMAIN_VDEC0 { reg = ; clocks = <&vdecsys_soc CLK_VDEC1_SOC_LARB1>; - clock-names = "ss-vdec"; + clock-names = "ss-vdec1-soc-l1"; mediatek,infracfg = <&infracfg_ao>; - #power-domain-cells = <0>; + #address-cells = <1>; + #size-cells = <0>; + #power-domain-cells = <1>; + + power-domain@MT8188_POWER_DOMAIN_VDEC1 { + reg = ; + clocks = <&vdecsys CLK_VDEC2_LARB1>; + clock-names = "ss-vdec2-l1"; + mediatek,infracfg = <&infracfg_ao>; + #power-domain-cells = <0>; + }; }; cam_vcore: power-domain@MT8188_POWER_DOMAIN_CAM_VCORE { From patchwork Tue Oct 1 11:27:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 13817902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48D89CE7D0D for ; Tue, 1 Oct 2024 11:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iHVpAqtBhTjk/tW32shjLNYqZYBHOi3xkZZdLwrHsZc=; b=srbOvuJA/fIHR+KQtb1eDFGcri tvaxGtcdIWFv4VtCQF3m98EiH3+KtomRyaHf3whK/nB18TUVu62nnouiwxXFvbI0CSb6HlFEDN4AR u7cGOKLp4ojuzqwEasctCa0J7ij3FJgi8h9uSk3PUySUy22tpifBKGyqrw9vNK/CYegE2u8dmAyBb +gZtV0JAUkh8o6ABihOh/b2zsfcKnke5Y0LqrnlqVDinNUuE87Ys7fpwLz66Ik+b3g4SsQ/CWTP4H OEh5ZlIWQSc17yZ67FUozA8RsfpGgs1FMDYzALyUPAv/ulyVCdK+erHFOOAy3VHfQ8DnWG6d1fVbK /XS0X2bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svbN0-00000002a1j-0PDE; Tue, 01 Oct 2024 11:48:46 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svb6T-00000002WTE-1NV1 for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 11:31:42 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-71b8d10e990so2459410b3a.3 for ; Tue, 01 Oct 2024 04:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727782301; x=1728387101; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iHVpAqtBhTjk/tW32shjLNYqZYBHOi3xkZZdLwrHsZc=; b=R+uoPQIB3MtHmRDtbjH90BDJcggwW8qbNnV+6u9gUheCKpOaQ1QSYS4h7Hj4FNbE1I sSXKetJXB7Zvfq7NtJ4Zr5n13s7Lku0zoGLWQKA1hAeQF1sxxmeOx0Y9og9fQqxMyUb5 oyFP3Tc8/fVHPMj133vDhf0CeA40nRdVyyy8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727782301; x=1728387101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iHVpAqtBhTjk/tW32shjLNYqZYBHOi3xkZZdLwrHsZc=; b=kynTbqpoyFv40vdUAbGse6AIxMyD4DlHOzWHd0e/9ZJSl5/5BXKhM0bOM2nbJ0vmEi u6JfcvL++Fee9U9G2voLKK2g29hdtc1QzW3GJrmYv2NjSyvNgURuDrG9+hQegBeZ+lWl e/ZsnJJzaVVZ6/x+3X/KS31JyiT/2R6KyVHcxGA7mCfBil9F+GQUueeJnRtSc0nNipOZ OoixoeZp4tBeKqGBgi98lsFbCH3FLDcSMSv7dzFfrkDpG6LIwwRbwIt9QzaxOHoQRrCW ZDHYF82/bhv8binFUGXzV73i43iQobt0zTfmIKKyms2qWpfYxvKSM/Oi1eLtIYf9IMRh vEtw== X-Forwarded-Encrypted: i=1; AJvYcCUlTn6LNcNnfIApBxTQxSQXu1zygBvPdoeOy6jGGC/DOEBAZXrRVoEMna4ooKAtHr8IyP+ZCKEVIErFEtLQZl/q@lists.infradead.org X-Gm-Message-State: AOJu0Yy7ZpIAnyhtFrvYmomLYOWQzdY88zf3kZuE9x5QCdaizJhNIYVU JT041LQcBt2TwVxLvzJiLsGoVMuN4dWLr0XrCupDipBWUNmppWl63OSOCUWwxQ== X-Google-Smtp-Source: AGHT+IFZ3oUWJS1Sa53CgoaQveyvKTUyDvv6ZPmGhi3kZ/l698r7fpVxnLWRxa7awXLoABaq4SwyfA== X-Received: by 2002:a05:6a20:1d98:b0:1cf:22d4:3832 with SMTP id adf61e73a8af0-1d4fa64c5admr19196260637.5.1727782300706; Tue, 01 Oct 2024 04:31:40 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:e044:f156:126b:d5c6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b63d9sm7810646b3a.52.2024.10.01.04.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 04:31:40 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno Cc: Fei Shao , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 8/8] arm64: dts: mediatek: mt8188: Move SPI NOR *-cells properties Date: Tue, 1 Oct 2024 19:27:26 +0800 Message-ID: <20241001113052.3124869-9-fshao@chromium.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org> References: <20241001113052.3124869-1-fshao@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_043141_387546_EDEDC9FF X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move the #address-cells and #size-cells properties from the board dts to SoC dtsi to be reused by other boards and avoid duplicated lines. Signed-off-by: Fei Shao --- Changes in v2: New patch. arch/arm64/boot/dts/mediatek/mt8188-evb.dts | 2 -- arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8188-evb.dts b/arch/arm64/boot/dts/mediatek/mt8188-evb.dts index 68a82b49f7a3..f89835ac36f3 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188-evb.dts +++ b/arch/arm64/boot/dts/mediatek/mt8188-evb.dts @@ -140,8 +140,6 @@ &mt6359_vrf12_ldo_reg { &nor_flash { pinctrl-names = "default"; pinctrl-0 = <&nor_pins_default>; - #address-cells = <1>; - #size-cells = <0>; status = "okay"; flash@0 { diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi index ca50ed20fca0..e2c6ed816507 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -1618,6 +1618,8 @@ nor_flash: spi@1132c000 { clock-names = "spi", "sf", "axi"; assigned-clocks = <&topckgen CLK_TOP_SPINOR>; interrupts = ; + #address-cells = <1>; + #size-cells = <0>; status = "disabled"; };