From patchwork Fri Mar 8 19:46:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramsay Jones X-Patchwork-Id: 10845349 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6351714E1 for ; Fri, 8 Mar 2019 19:46:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C33F2FE2A for ; Fri, 8 Mar 2019 19:46:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3FC7E2FEA4; Fri, 8 Mar 2019 19:46:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5AF02FE2A for ; Fri, 8 Mar 2019 19:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbfCHTqp (ORCPT ); Fri, 8 Mar 2019 14:46:45 -0500 Received: from avasout04.plus.net ([212.159.14.19]:46192 "EHLO avasout04.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbfCHTqo (ORCPT ); Fri, 8 Mar 2019 14:46:44 -0500 Received: from [10.0.2.15] ([146.198.133.33]) by smtp with ESMTPA id 2LS6hxv1NAOoy2LS7hozWH; Fri, 08 Mar 2019 19:46:43 +0000 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.3 cv=Rdm+9Wlv c=1 sm=1 tr=0 a=VCDsReDbrwk4B7AcQzWGLw==:117 a=VCDsReDbrwk4B7AcQzWGLw==:17 a=IkcTkHD0fZMA:10 a=EBOSESyhAAAA:8 a=G3HwsQ4Ae5TlnPrUaEkA:9 a=QEXdDO2ut3YA:10 a=yJM6EZoI5SlJf8ks9Ge_:22 X-AUTH: ramsayjones@:2500 To: Jonathan Tan Cc: Junio C Hamano , GIT Mailing-list From: Ramsay Jones Subject: [PATCH] upload-pack.c: fix a sparse 'NULL pointer' warning Message-ID: <3d3e6647-0f22-aed5-f388-fe5243662f94@ramsayjones.plus.com> Date: Fri, 8 Mar 2019 19:46:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Language: en-GB X-CMAE-Envelope: MS4wfPPtKdQfI6ipA7Y4sFurWStw4911Rm5/6qfIQxNa65hUe6KzKE/NUhNNkeFB+8PXrJjK6tmREWH2Insly9/wrliZUp1DqNYqbbwRbGqmcgSRmrN07+l/ hKDWGnycQQvFl82ZNbGRgSDZJ91LMWz/TMrX4OiM/mxNfGQGwCSihRQ3H2VFlcG2Fe87HxaXOrxmpQ== Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Ramsay Jones --- Hi Jonathan, If you need to re-roll your 'jt/fetch-cdn-offload' branch, could you please squash this into the relevant patch (commit 0e821b4427 ("upload-pack: send part of packfile response as uri", 2019-02-23)). Thanks! ATB, Ramsay Jones upload-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/upload-pack.c b/upload-pack.c index 534e8951a2..a421df2bbb 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -1164,7 +1164,7 @@ void upload_pack(struct upload_pack_options *options) if (want_obj.nr) { struct object_array have_obj = OBJECT_ARRAY_INIT; get_common_commits(&reader, &have_obj, &want_obj); - create_pack_file(&have_obj, &want_obj, 0); + create_pack_file(&have_obj, &want_obj, NULL); } }