From patchwork Fri Mar 8 19:46:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anderson Reis X-Patchwork-Id: 10845353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8AA3814E1 for ; Fri, 8 Mar 2019 19:47:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75B8A2FD33 for ; Fri, 8 Mar 2019 19:47:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 692092FE7C; Fri, 8 Mar 2019 19:47:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBB582FD33 for ; Fri, 8 Mar 2019 19:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbfCHTrh (ORCPT ); Fri, 8 Mar 2019 14:47:37 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:44710 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbfCHTrg (ORCPT ); Fri, 8 Mar 2019 14:47:36 -0500 Received: by mail-qk1-f195.google.com with SMTP id u22so2989641qkj.11; Fri, 08 Mar 2019 11:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p2Ize1qdd/+pcZ9Tq8J7ceDNACDDuhrJ3Re5syZqpYs=; b=EDqnDhlOqoC3k/JHRM46+brhChFEDWpche5SR6l8Bkgenep3WEH+bpoth0fTEoxwpD sV5n2S8tm64ekKym1+aKfHggu6CI/FGqzY7rThSRA2Ayqb3oxL2tyB2b+JS/Rwo3+w70 XcHWLV7dIddHHqnhDqV3t5ldgJxxqHRw4hXCZVThmbjEYx+HDv+0NvPp1zV/8N33SlAb r/NYXgc7lLXGFZ+BPJ6pitkveehqEUX7LrPxRe4dn6aoCyUig7L55VbRdTUu0T7HoXrY puOaGLvT4EhD49zS46QPNtNCc9Yi0yh2iIkKMkgFLqhbTn+H9kNJAHL6rxhhVMpaGmjn Z2RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p2Ize1qdd/+pcZ9Tq8J7ceDNACDDuhrJ3Re5syZqpYs=; b=c4pJ9faokuQJECd8+6uR9u+rGaWbUihpydoB+5x6L3lEGeNJMRVQabmgDnvE5vvvTz 6+QR/1dE+x0XfE/bvujcrSkkTEykoL5Z4KgKLt7TgV2FpXwFxjuAL9yTCluJs5FMM/SW MYdcWZC7RvVQHBb8XO/KQYW88QJ4YP3YADpreP1czWxpPSbl+BESaKjTIgkFVUkmNS7j o7tk7kR80winG5PRAvNhC0+kwCS4TYdyjhEiMNAxkSeX/Vg4hZa6M+M99CEb0Kb1dp0N 3de3cDmnV6hzCXl46b3jk8P2aN/VtCrTbn6o28d+XvXe95m0fs4RY/oiiqmd8fZgwRXx Y1cw== X-Gm-Message-State: APjAAAUspNJZwSM2dV3O/Iwy6+f5Vs5OBwxuAZNQtl9xzOg+IWJvBIMw rDwx8PF0qc7GVmLu/JpRWdE= X-Google-Smtp-Source: APXvYqwt9TmSP17ftfGUKD7wujl6S9fp9XXmpebaLPA+biK2RSO9sjDEOQq9dXu0W4Qod9Tp0v6UYQ== X-Received: by 2002:a05:620a:15a8:: with SMTP id f8mr2801331qkk.127.1552074455750; Fri, 08 Mar 2019 11:47:35 -0800 (PST) Received: from crypto.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id n27sm2393038qtf.11.2019.03.08.11.47.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 11:47:35 -0800 (PST) From: Anderson Reis X-Google-Original-From: Anderson Reis To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, matt.ranostay@konsulko.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Lucas Oshiro , Anderson Reis Subject: [PATCH v2 1/4] iio:potentiostat:lmp91000: remove unnecessary parentheses Date: Fri, 8 Mar 2019 16:46:52 -0300 Message-Id: <20190308194655.5983-2-anderson.reis.rosa@usp.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190308194655.5983-1-anderson.reis.rosa@usp.com> References: <20190308194655.5983-1-anderson.reis.rosa@usp.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Lucas Oshiro Remove unnecessary parentheses on line 116, and solve these checkpatch.pl CHECKs: - lmp91000.c:116: CHECK: Unnecessary parentheses around 'state != channel' - lmp91000.c:116: CHECK: Unnecessary parentheses around 'channel == LMP91000_REG_MODECN_TEMP' Signed-off-by: Lucas Oshiro Signed-off-by: Anderson Reis --- drivers/iio/potentiostat/lmp91000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c index 90e895adf997..03d277621861 100644 --- a/drivers/iio/potentiostat/lmp91000.c +++ b/drivers/iio/potentiostat/lmp91000.c @@ -113,7 +113,7 @@ static int lmp91000_read(struct lmp91000_data *data, int channel, int *val) return -EINVAL; /* delay till first temperature reading is complete */ - if ((state != channel) && (channel == LMP91000_REG_MODECN_TEMP)) + if (state != channel && channel == LMP91000_REG_MODECN_TEMP) usleep_range(3000, 4000); data->chan_select = channel != LMP91000_REG_MODECN_3LEAD; From patchwork Fri Mar 8 19:46:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anderson Reis X-Patchwork-Id: 10845355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 341A514E1 for ; Fri, 8 Mar 2019 19:47:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20F422FE2A for ; Fri, 8 Mar 2019 19:47:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 150752FE90; Fri, 8 Mar 2019 19:47:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B43C72FE2A for ; Fri, 8 Mar 2019 19:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbfCHTrr (ORCPT ); Fri, 8 Mar 2019 14:47:47 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:40606 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726924AbfCHTrq (ORCPT ); Fri, 8 Mar 2019 14:47:46 -0500 Received: by mail-qk1-f196.google.com with SMTP id h28so11868778qkk.7; Fri, 08 Mar 2019 11:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PCmgnf+DSePwylqGHbW4EX8PQba6O1Evd59WRGue5aM=; b=jbTn8BUf9D4Hq3835SC0r4+906XV2OJt9ZHAECl/2hx9e/16jENlWcbhh8vhnrPTEt UgE0LspmAuFH+A/DDj5LNLoC1qBmCaMkzIUEfmjQupWa13Ufxe4JHKrnMEABIpxv17uf 6Ul9BNThi83zpMwzfK6MsEFJW10ZPOBtbUs30kyNUDYrA7AdQrvrwHvqvAxLwQ4B8bB3 x36o+Gx+d6v+XLebvGXe825MCePQJfLkhEj35ihaqXAYUeqmyBHpE90leZizxyVBLoCj wBN7H3NzxSI3MLN9RrMiVu+ZdO3JNY2B7CpVXi6Zt1oYPwDfnHIsYAQk+2i9Sh1SiOqX fbqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PCmgnf+DSePwylqGHbW4EX8PQba6O1Evd59WRGue5aM=; b=bdHzWk2osGUtOgBqufVodLuETeQOMzOnIPQfAcnREVz2msmZzqYkAIWhrSn0EdyG9b jGdKNHF2GyGsEEshDNlpFsOEkooNkeWuVBCoC8B4Sd8nCPT+DGi8l1TbzlWwLRpJ+inH w8zQ2R45TYUD0r15+Oxqd9Achv1MIOYKo/MddrzMMtxI+F2vjBGJ/hJ8b2/yfQNjpO+2 CGmWRISRc4qPyiTJw2j7hHLAYII+QXAk7BGnx1yNeWM/t+M13nsT8svsyTJ/2Z3KgOol 6+oJAmqZ/a4PF2KyfLnaTPCf2TJO7a9zKkJ265fwMuLgC56UTKdbjokAGDt9PEFTuauz oIKA== X-Gm-Message-State: APjAAAWImbxmi6lXYsm+Z99DQxK1TpI209YpGpBzq+MALVcd0+jmiHOI 2TsRSgA6moyueVJFRtvzILI= X-Google-Smtp-Source: APXvYqwVVKo5PrEmmRlLWdBO1b/hrn/JB5tEBL9+KIlMira8qsKmHodyMhtCHGjltLo0uMHlTl3IWg== X-Received: by 2002:a37:6042:: with SMTP id u63mr14587176qkb.289.1552074465571; Fri, 08 Mar 2019 11:47:45 -0800 (PST) Received: from crypto.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id n27sm2393038qtf.11.2019.03.08.11.47.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 11:47:44 -0800 (PST) From: Anderson Reis X-Google-Original-From: Anderson Reis To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, matt.ranostay@konsulko.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Anderson Reis , Lucas Oshiro , Anderson Reis Subject: [PATCH v2 2/4] iio:potentiostat:lmp91000: reduce line width and remove blank line Date: Fri, 8 Mar 2019 16:46:53 -0300 Message-Id: <20190308194655.5983-3-anderson.reis.rosa@usp.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190308194655.5983-1-anderson.reis.rosa@usp.com> References: <20190308194655.5983-1-anderson.reis.rosa@usp.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Break the line 258 in order fit the line width on 80 characters. Remove the blank line 279, as the line before is also a blank line. Solve these checkpath.el WARNING and CHECK: - lmp91000.c:258: WARNING: line over 80 characters - lmp91000.c:279: CHECK: Please don't use multiple blank lines Signed-off-by: Lucas Oshiro Signed-off-by: Anderson Reis --- drivers/iio/potentiostat/lmp91000.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c index 03d277621861..c45cfb632649 100644 --- a/drivers/iio/potentiostat/lmp91000.c +++ b/drivers/iio/potentiostat/lmp91000.c @@ -255,8 +255,8 @@ static int lmp91000_read_config(struct lmp91000_data *data) regmap_write(data->regmap, LMP91000_REG_LOCK, 0); regmap_write(data->regmap, LMP91000_REG_TIACN, reg); - regmap_write(data->regmap, LMP91000_REG_REFCN, LMP91000_REG_REFCN_EXT_REF - | LMP91000_REG_REFCN_50_ZERO); + regmap_write(data->regmap, LMP91000_REG_REFCN, + LMP91000_REG_REFCN_EXT_REF | LMP91000_REG_REFCN_50_ZERO); regmap_write(data->regmap, LMP91000_REG_LOCK, 1); return 0; @@ -276,7 +276,6 @@ static int lmp91000_buffer_cb(const void *val, void *private) static const struct iio_trigger_ops lmp91000_trigger_ops = { }; - static int lmp91000_buffer_preenable(struct iio_dev *indio_dev) { struct lmp91000_data *data = iio_priv(indio_dev); From patchwork Fri Mar 8 19:46:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anderson Reis X-Patchwork-Id: 10845357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDD9A922 for ; Fri, 8 Mar 2019 19:47:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAB1A2FE2A for ; Fri, 8 Mar 2019 19:47:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE2072FE90; Fri, 8 Mar 2019 19:47:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BF7E2FE2A for ; Fri, 8 Mar 2019 19:47:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbfCHTrz (ORCPT ); Fri, 8 Mar 2019 14:47:55 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:33200 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbfCHTry (ORCPT ); Fri, 8 Mar 2019 14:47:54 -0500 Received: by mail-qt1-f196.google.com with SMTP id z39so22580580qtz.0; Fri, 08 Mar 2019 11:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RrEnffFHlOD8ovUk228i30cx429UY6FjxAK/KSGO/hk=; b=cSAgw7gkCCwz21cKMyBbT6sKKKpZwA8Ju/AeHRPRoaBYC7UhizTBeYwXLETDbScOlt zfHnUYLSXxKyouhGhFVXnAFTGHB0h6HNojpEdTecogIJ787e5X2T4MbRaXbsXrKlpZwV SkWFB5SaS3pFIzRkdqjvjKQR6kxMkh5H3FxYbYZFhuBloiKdF90Y2Zzp7dwCptQ+CDxY 0qmc4WVuWomKiHoeKXEj1qFNjhPpc8ttNsw3ojvy5vzDj8xtQlCSyK1jGOO4P2QQhVtc 1XfCHjhpQB4wf4PRUNPDVWk4oOkl/Z+VdDUdV9EI6rr0Ej9Wd46+Bhensg3K7LjKKuvQ kZuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RrEnffFHlOD8ovUk228i30cx429UY6FjxAK/KSGO/hk=; b=LRBV85akN48hZQcjeNZx4nLa/ihaHvZWuQhrP928XyKak88PWoJueWfWPU9XS8AH8b r1/+QWhNI2b7zuh6x/UECi08S6K4pf3xM1X+P5AVJvJpKSQI/KtSaHHC8b045/f7Rk6x Cys9U+qhSPhQbiy9wqykUowqr4ygo9+EHntypOmGp2GtDuZU0I/za9PwA0ozvauXwMm/ wIlnN0J+DDXBiB0zl9FrqZQPp35vrbqurtchLB66LXmYQLaDP4D2gOYQOLMXcji2V6vk U3agoSVQLcE0bHPE62IMSsW3h4W76elwQ5OuE8j6fsGMFjgVOY5iupjlxHSieuOCUsN0 8OTA== X-Gm-Message-State: APjAAAWsgH2dytV92WrXjqkBdoAbcF8bUGMS5nKD7k2ii4h6Y8bzqmTH B8K2SFcpeOW/Pnbxyj4su80= X-Google-Smtp-Source: APXvYqxXRO54DIoDjTs7SHBRMb9v7T5ktd4ozhmpf8eak+y0mKmwIE2DRz+BSqn4vajm2fVJCYw9Ag== X-Received: by 2002:ac8:37f6:: with SMTP id e51mr15910001qtc.1.1552074473449; Fri, 08 Mar 2019 11:47:53 -0800 (PST) Received: from crypto.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id n27sm2393038qtf.11.2019.03.08.11.47.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 11:47:52 -0800 (PST) From: Anderson Reis X-Google-Original-From: Anderson Reis To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, matt.ranostay@konsulko.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Anderson Reis , Lucas Oshiro , Anderson Reis Subject: [PATCH v2 3/4] iio:potentiostat:lmp91000: invert if statement Date: Fri, 8 Mar 2019 16:46:54 -0300 Message-Id: <20190308194655.5983-4-anderson.reis.rosa@usp.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190308194655.5983-1-anderson.reis.rosa@usp.com> References: <20190308194655.5983-1-anderson.reis.rosa@usp.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Invert if statement arms in line 214, in order to make the code cleaner, solve these checkpatch.pl CHECKs: - lmp9100.c:214: CHECK: braces {} should be used on all arms of this statement - lmp9100.c:216: CHECK: Unbalanced braces around else statement Signed-off-by: Lucas Oshiro Signed-off-by: Anderson Reis --- drivers/iio/potentiostat/lmp91000.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c index c45cfb632649..1de17924e154 100644 --- a/drivers/iio/potentiostat/lmp91000.c +++ b/drivers/iio/potentiostat/lmp91000.c @@ -211,12 +211,11 @@ static int lmp91000_read_config(struct lmp91000_data *data) ret = of_property_read_u32(np, "ti,tia-gain-ohm", &val); if (ret) { - if (of_property_read_bool(np, "ti,external-tia-resistor")) - val = 0; - else { + if (!of_property_read_bool(np, "ti,external-tia-resistor")) dev_err(dev, "no ti,tia-gain-ohm defined"); return ret; } + val = 0; } ret = -EINVAL; From patchwork Fri Mar 8 19:46:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anderson Reis X-Patchwork-Id: 10845359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE556922 for ; Fri, 8 Mar 2019 19:48:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 985222FE7C for ; Fri, 8 Mar 2019 19:48:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AD7B2FEA4; Fri, 8 Mar 2019 19:48:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B1C52FE7C for ; Fri, 8 Mar 2019 19:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbfCHTsA (ORCPT ); Fri, 8 Mar 2019 14:48:00 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35565 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726348AbfCHTsA (ORCPT ); Fri, 8 Mar 2019 14:48:00 -0500 Received: by mail-qk1-f194.google.com with SMTP id z13so11886585qki.2; Fri, 08 Mar 2019 11:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M8JbYhBkREjKi9HdILjG0gKF6tKhRCypgsFQponE9l8=; b=B+8O2BzAqk0hBkXUnzUXqQ53gf9+a2gRiTVy2oQ+Bp+kEhjqEGhrxI8HYWrD/ghZMu CgQPUM6WPv3u4Zw9Gn/DNMn37eDETlFx5XMWd7/Cmb+dcf9eS+0S8mibk2beyaI724la 6zCuFK6x5A7qbFUoAUsxB2P541BhfrfAjtB6A7maH7/HAMQvT5edgOk2ODj9CwvQLRvx B49KBLthWqCZUOvCgDNxpKX1AmE147nr0Xe2TKQNmE/dUecYJCN3ojxjiKuZi9NtOuqB PGA8yLoNN+DLrtVDwNXBhQSXgvlqykL9Q+ZbyQD2RYS4yVrboo1Hmc1tWctkxA139LCh blvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M8JbYhBkREjKi9HdILjG0gKF6tKhRCypgsFQponE9l8=; b=qdMh9Fo39ye6LSQQG+kEvwcqW+64PKROcxsoe1Z2wCccDy2gYfc2vD2q+iPsX13yb5 HDFIUs55ig6wSl/5C+k1/O+TdSZoRo5jCEEmDH7x0Smyk63xd06WLZHALSwRG5zp8z9N HXucthNh6IXpDW6MWk7BiTSDHu6k1e9NTnOaoHDK/mHdRPnwoKOEbgKpqUSnZ+5eMY4n khrjVkw19TTNi9acLmFOWXnjcZSr1eEg255ZE59rWtwt2P/92Fa62cPUyEOmWMz6+2of j7MCP3AJeijJg7lKUNISbBp/kRjNWn1aXcJiBdzkwOqmdEL0WRnYAH4rmBbSQcCBXs9l Hyrg== X-Gm-Message-State: APjAAAUPjPRlKAX0MiLiQCTWqaljLr3q5tI28XWoCL09JhZbmgYL1m/y tNIOMsY2VuRfbd1PIiiP0gE= X-Google-Smtp-Source: APXvYqzWZqkNZGP7vjDwLBBxZZzQaOdHtuZX3zfIZKaDB8RgVqw6yh5tV73IyiMXWmvL606KM9/V3w== X-Received: by 2002:a37:a10d:: with SMTP id k13mr6739803qke.203.1552074479453; Fri, 08 Mar 2019 11:47:59 -0800 (PST) Received: from crypto.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id n27sm2393038qtf.11.2019.03.08.11.47.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 11:47:58 -0800 (PST) From: Anderson Reis X-Google-Original-From: Anderson Reis To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, matt.ranostay@konsulko.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Anderson Reis , Anderson Reis , Lucas Oshiro Subject: [PATCH v2 4/4] iio:potentiostat:lmp91000: change dev_err message Date: Fri, 8 Mar 2019 16:46:55 -0300 Message-Id: <20190308194655.5983-5-anderson.reis.rosa@usp.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190308194655.5983-1-anderson.reis.rosa@usp.com> References: <20190308194655.5983-1-anderson.reis.rosa@usp.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Change dev_err message on line 215 in order to inform that tia-gain-ohm is not defined and an external resistor is not specified. Signed-off-by: Anderson Reis Signed-off-by: Lucas Oshiro --- drivers/iio/potentiostat/lmp91000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c index 1de17924e154..5ed9752008a5 100644 --- a/drivers/iio/potentiostat/lmp91000.c +++ b/drivers/iio/potentiostat/lmp91000.c @@ -212,7 +212,7 @@ static int lmp91000_read_config(struct lmp91000_data *data) ret = of_property_read_u32(np, "ti,tia-gain-ohm", &val); if (ret) { if (!of_property_read_bool(np, "ti,external-tia-resistor")) - dev_err(dev, "no ti,tia-gain-ohm defined"); + dev_err(dev, "no ti,tia-gain-ohm defined and external resistor not specified\n"); return ret; } val = 0;