From patchwork Mon Oct 7 06:53:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeongjun Park X-Patchwork-Id: 13824184 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFE0CFB440 for ; Mon, 7 Oct 2024 06:53:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9B8E6B0110; Mon, 7 Oct 2024 02:53:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4B786B0111; Mon, 7 Oct 2024 02:53:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B39E76B0112; Mon, 7 Oct 2024 02:53:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 98F0B6B0110 for ; Mon, 7 Oct 2024 02:53:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EEBC780883 for ; Mon, 7 Oct 2024 06:53:16 +0000 (UTC) X-FDA: 82645889592.18.C2C6C6A Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf07.hostedemail.com (Postfix) with ESMTP id 4AB2A40002 for ; Mon, 7 Oct 2024 06:53:14 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="gqVemjv/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of aha310510@gmail.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=aha310510@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728283969; a=rsa-sha256; cv=none; b=g/EAfp68WPmSbdho295EjaSMVts6OlyTz8I4xP2PxxYSBc7rK9hC3GeOOxCPWqGojyowBL n+BmHuKurj1Vaveam7Iv8Ff2LCekJkNfY2P5bRZaJ5Gf0viZwHp8ubTKdEFXZBInqUTojV Ji0jX38tczZfFDc6dBkNgobtXRwOEog= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="gqVemjv/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of aha310510@gmail.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=aha310510@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728283969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ceeahQe9wcl46lPcO7fUS/hyZJL8m6PhkmRtZJytXcI=; b=1Vt+blRvSsbNZivsFj9e8sD42xeJXWx4ikTLNWFuJP2RTwY2/sjJ8jxPqv0n3R9LyI0kwP myMxdY+Ljrgzaye7WBsYvrQioo1wpVYJ2V8tBs7B/VV68l7l0lcL7aDeHxUItjdgl3nLS+ J9RSpscoOWLEjKNwV3k523jbXr2zzVw= Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-287f29182b0so372580fac.0 for ; Sun, 06 Oct 2024 23:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728283993; x=1728888793; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ceeahQe9wcl46lPcO7fUS/hyZJL8m6PhkmRtZJytXcI=; b=gqVemjv/Pa9pqkSSPOwcA+2PJ3zO5C0zz6nDPYVEiUzUN1nS9PFIEUAPnCW9j6SoOx eQltRK8gKDihn+DA4R5a45OWzA0q3F2suOLxTwKG4CN9rQRGxh4WOItwCKhE2BeQaaNA AO4wqOSz7B/ueaosF/FQhoi9RB6Yd8A+XXO6pBtgU9Jp6bFKId+Ax5AReVAW9x7UFVvQ b32YGqm2KN8T5FrflFLWPlq9Vl+BEiG+mUZkkacSZ9dHV5ZzzcsmQanmu32b09Ou6Agx FfFfCdyeysPJWG9mVowk1gPX3gEPVfyrPeZwIHSXr/RAI48nOFR+Dl5eNotXmdS/LjTM aQHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728283993; x=1728888793; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ceeahQe9wcl46lPcO7fUS/hyZJL8m6PhkmRtZJytXcI=; b=M4T0j6Wf4hVX4RsTaaSWOALALqxV35LGs7vI7osO0qaBD2bxYMczwpHDnEL9YEvE5h qtG0io1/aCSa5/ahqLODLLuhakZLhoYz2vtNCYpajrs/pG6pgqbz8kxOgVAGL7zu32nw TeAjx07nzV2MVrMZKCZD+srbyY96fOlEKjqwNnXm3Lg7abLYTv48d7jL8ngE9vGWoIuL iZD7H77IHEbSa08o8BJWyyaJNa1YiMDFzqa474AtORYQX/Mx/PHoFWcQEaNwPcxu4QhU zChYTQtCXjontLKwmcV+OO/WuClZia7Oe79A1vZVTmLyKCiGTG8JPdyjchiZmN8Vhfbf tEPw== X-Forwarded-Encrypted: i=1; AJvYcCXdW3krE+cWbrKX/eaEtFS+mhX1VaoUua+FL722pbtqUQshhEhwMMp955TGTRcS2CS7okFchms1sQ==@kvack.org X-Gm-Message-State: AOJu0Yz657pWvmxpgjZciAXUXJC6F5K++6rs6HawtZdJZ2t8BkLQgNQ9 KDaEs9WC51qIu81IKa1FD+KxaWSl39G/jfHxR9BT3KC6RB4l0FrD X-Google-Smtp-Source: AGHT+IEpvg/fv2oPovXfNcR+vR0vuvo5MLzuioMarvk5onqXjaJ/QULoZRprNjdBZBm6qHzZvky/qg== X-Received: by 2002:a05:6870:168a:b0:287:7695:6a87 with SMTP id 586e51a60fabf-287c1d38d48mr6445913fac.10.1728283993195; Sun, 06 Oct 2024 23:53:13 -0700 (PDT) Received: from kernelexploit-virtual-machine.localdomain ([121.185.186.233]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9f6c376cfsm3542555a12.61.2024.10.06.23.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 23:53:12 -0700 (PDT) From: Jeongjun Park To: akpm@linux-foundation.org Cc: usama.anjum@collabora.com, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jeongjun Park Subject: [PATCH] mm: remove the newlines, which are added for unknown reasons and interfere with bug analysis Date: Mon, 7 Oct 2024 15:53:07 +0900 Message-Id: <20241007065307.4158-1-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: otcgj31pwx8u7h395awd77s8mzsje5fw X-Rspamd-Queue-Id: 4AB2A40002 X-Rspamd-Server: rspam02 X-HE-Tag: 1728283994-971180 X-HE-Meta: U2FsdGVkX185DPVAls/Y8+dd3MuNy8JwQemUwbjBT7ZxxmxuVVvblabJFGeg4ihXFoKASJcRylQW4arJ5mlGvpr+fo59o3A0PjJ2YuXjx5o4Zud+I2L7CdNhVqUobbnG2SKp0JJhgV5xFQtZRJwLGoX2kGKnRYOb4pQ6eCimprsrG0xjdnpRVBz/ey2py9XQOoTc0FZxD4X89zWiIyfUdFy45KSQNJ7zj0iTWktgWWBeWR7WBzp3g2i6ezTin26t5IeJCnQCAQgyZasEDQUcfpFuMYwDRMT38M8WcRo8VWnyTmBwJjoC5wXo87Y1o4l9cI+vtGtG8b8XxHYd3/Jc9lg9NcqIDfHkyjq3naAmwxNPU8W/Bm0smOMHhngthzKgPkx4w1g9h0VwRv+zHAuEWRVjiFs7L6bigTH+GRizgUwt3ndGhP4l9q3m//ay1cvrqyyJwGQj4E3yD+Sx/0hV3Ky4g6gxPIW5NYW8/DUUQZrnyQH3IBxAZFhl7E+fJxZOmI59VSOAVwIWw7y6Tsu1GUAcNOj8Amfpcogus5G4CZEcMJpIT9HDYskiB4AIDS/GfG/83+S9moAd4shPjX3Af0U8H+KOWf+6yzH3/ersgsIJLeldCXkmLMCOQFUqi1xg4MRmLA044nLCVBD/34H6XWUTwBtoELT/zFhfAEqlfEz1+MznT+srU2tO1F0iecghcHF1LBphFDqbcC48LmyAGitud32OqkwBhoSdhtOulRnjk8uKPWsUOqnKbkNC1ex+K0aiuE/dlbSFZCjd7xYAVf9LgGPgFWktYjPtVe8yHoHpfPdUedp7nmzzowT4tlpBTtwzB0618phk1HdrxydyNwD3u7T5EEO0vSOaZID0gEKeHa0suIWIpiBEodyY2zaOWYds/Gs/jkwSmrqgm8QWGey8gFnKmR8snQLj/JIO0+OkERtmh3LJGiMzbv2CXEhlhvQvKnmjm+af1GDR6+4 ccJmG4n/ 0HQ67O11RosdljkVE0oFMRVsUawyKyTD692ihitIVHq0W9QUr8WxHZi0p0y/ajAR3n1EFXdTaBszW2vTYF5Ok0OkUV7Ax4l4kAKKggoZ/OO0tMXkffsqwNuz4o28PYh9L8+Vwg3o7q/1GRPWoSI39smRMRTnDDJTXdDPkIz+m1GqZ82hY8+4/+DMVE85z2GwNs98l2KZngyA1zKm+0zAKka3V+nKGxiGG1rtHjqQXmFH65ICl0jDOHrUftYWEI5Dlovn64JziC4jz+ssndszVPajc0m7hUJT9EO11/CSdJdfXHVjtClUXdRyOdEKmA51QyFIl/WpKRBDQ8GmCVCBWFLObfiKRpAa2SZr+hEfiA8IJVbkfM+qZhvxuzO5Ze6AJZ0+uhmUm6O/tNLYU6P2Vt0EyW+ZJZ36CxXpfCjIIpUWyOUoj8jmNqhbptnMa7Qllg9mKZcX+ahSktBI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000780, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Looking at the source code links for mm/memory.c in the sample reports in the syzbot report links [1]. it looks like the line numbers are designated as lines that have been increased by 1. This may seem like a problem with syzkaller or the addr2line program that assigns the line numbers, but there is no problem with either of them. In the previous commit d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC"), when modifying mm/memory.c, an unknown line break is added to the very first line of the file. However, the git.kernel.org site displays the source code with the added line break removed, so even though addr2line has assigned the correct line number, it looks like the line number has increased by 1. This may seem like a trivial thing, but I think it would be appropriate to remove all the newline characters added to the upstream and stable versions, as they are not only incorrect in terms of code style but also hinder bug analysis. [1] https://syzkaller.appspot.com/bug?extid=4145b11cdf925264bff4 https://syzkaller.appspot.com/bug?extid=fa43f1b63e3aa6f66329 https://syzkaller.appspot.com/bug?extid=890a1df7294175947697 Fixes: d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC") Cc: stable@vger.kernel.org Signed-off-by: Jeongjun Park Reported-by: Jeongjun Park Signed-off-by: Andrew Morton --- mm/memory.c | 1 - 1 file changed, 1 deletion(-) -- diff --git a/mm/memory.c b/mm/memory.c index 2366578015ad..7dffe8749014 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1,4 +1,3 @@ - // SPDX-License-Identifier: GPL-2.0-only /* * linux/mm/memory.c