From patchwork Mon Oct 7 16:18:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13825007 X-Patchwork-Delegate: frank.li@nxp.com Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2067.outbound.protection.outlook.com [40.107.105.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D41B21D434E for ; Mon, 7 Oct 2024 16:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728317924; cv=fail; b=ETuRT0yhqP6dlfgT4jl/ZIItwW3z8yvppaqQGkGdEa81JBoDMRKDIipcQOyW1BdA+qlv7btLoPvZiOQv6AyT9YccIDtcSWvwIfRBFLWYlaR649ZDroQBdXLk2ZM4A/BG22mIFer6NaV+Sr/PH4fKY/7huNXiLpRteIs0Yl3RhAY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728317924; c=relaxed/simple; bh=Su7/lpVX5WLPwhGPv3ctAuwWYIn0aT0Nm8tcPmq80uE=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=DMDih6auP9lo7roxJl3FX1i+LRMBo85mnCX1C1aVxc4I7DXi+sG4vZB0n2oJNzqNAYHUHbC7Tr6qyM0HhsWp4hd5T/E7V4yxHlizOSPVLulr0Qo77thROrBfAkvjZLncQPuLRChL+YElODCJC1UfhQkMtdGd+irQ9O9Xx4wQD2E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=DXgvcaJV; arc=fail smtp.client-ip=40.107.105.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="DXgvcaJV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZVz9D5TO+83DkQJxtuKQ0N+TGonXz0DrtqNtCIzZ8Jq8ht0THwAsvKa+2j49cd8K9nUWu3uZivFeaWGGSnonqP8ykl1XDQXq18hRBQSrOKyOmIhrNq+ba+axMz4Bz+yzciEl60gAee7c4956/gXFezKjy66uQXhLaApHyFGKNA8FufidPtIjMcEQmlNP5NORW7K52F1nJ0kV+3NOrBMjmMkCkc+3QO9M5r7977KSKa0zC0ZsjAyn2ShtZc2ZcjRgWVhI1Jgk/TIpxC+NKtIEGNHgHJb0kooitkNvDsZGlY/UpHRkbjr5R8t3zs9BSDbC/dJajzp2Hr1zotigregzZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G1BlkR5H7VbR69PcwYeXfwIXkxTWOPOYmcA6C4j54Eg=; b=MK+zQpQVPp58NwYtOC3bdMqqAEBUqnA7i7/AB84HbEsmHuDwCObYX7wFFCv76OCOQ9uA1DTRrtb+EV+S6F7lvl8asLpK2EyEw+9t+wowIyMUyBm2uFq3yQmbt4LHKayib65q6qXWS/Bhfj3uBxzCznPJAPHUECyJgOKNGa8y8+1bmnP5alFqva4Vmh3J5mEm6zVLI8d3UD6qYjlfyxxx6NPRbLoPmWWql6PSjFkd0uNvZyyIEly9a8Qsdw+PY9F+tyU35MVSWi6MesxiM86B+vJWdxNBOpnIh0BkehrjHb7BiEXMezdG7Z8KHpge6zOh+AXw9bOo8KTr2d7bDlOXCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G1BlkR5H7VbR69PcwYeXfwIXkxTWOPOYmcA6C4j54Eg=; b=DXgvcaJVpOGohyY0B6BqRHKNDzB2Nbg4u+bC+T1rpTHMikhdLsgyrlMvW/fsrgO9t7nhCfvL4q7qbvvx96FqhzpDR7quAVChsSiE7o/KZ7EhZuihEqpsXq4NOm0Oi7qavgEZLPFe956RJYqKoFUgTiNY+P1dgqZBdF5yuroVw6FH/LON1hmwwURngkZgr0nek3sy2vRqamjwrYk5veYu1MW8ns57/3HEMuge8mvUyHz3wO74zWNhhTAAGDsjKzuxpi6UiSRGRQ1YJ7JMh88zH/YySZEeRiNPijOZxTw/+M5QmFHtAFJ4Eg3wByY15IJ2w3tuoV+F7v5J0To8RQkz6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by VI0PR04MB10254.eurprd04.prod.outlook.com (2603:10a6:800:240::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.20; Mon, 7 Oct 2024 16:18:39 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8026.019; Mon, 7 Oct 2024 16:18:39 +0000 From: Frank Li To: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , linux-kernel@vger.kernel.org (open list:IRQCHIP DRIVERS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Cc: imx@lists.linux.dev Subject: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl,ls-extirq: workaround wrong interrupt-map number Date: Mon, 7 Oct 2024 12:18:23 -0400 Message-Id: <20241007161823.811021-1-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: BY3PR10CA0019.namprd10.prod.outlook.com (2603:10b6:a03:255::24) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|VI0PR04MB10254:EE_ X-MS-Office365-Filtering-Correlation-Id: b932883a-18fd-4271-56db-08dce6ebb41b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: QIppfB6H2wF87lUdUj0sR7azE2YUsxQsilRNChLiqe1/jyRCTsfIiM4XS9PVRrqAlLSvm14gYh0oxQYcsH5XssBlr0wNvn4kjZEvKvirLkOcudwIZEfpL654vg6O6MWHtT1gCWS2g2jSrCt5ZieMWVWJNX97bfLvUIVpEDqPF3I5Uu8B0RNW5/nUNO/0F0MmNI/rnxwFJFkm5S6BT77jRm5ZZE5SeUFyz6tTZ1NL4aOU+7PrUbcrqQvumlpUdm0ggxcWZsgT1L7n7sDOAlLaTafbMWzUj2b8a/5GIxOIBNE2dwgptJ78OWctofTN57YpkVBRxTtGwWozXWkGt5tthc1h14auapyPgFUrqnsj9Pu81JG22E9sRTlMqoz1msBzgTUP4EtG2OTVpna044Fqexh3ZQiMuLpQrdiBb6f/TpD6soilAYlm676/YiynbVmiVcq+huwlcVLVhd/w56sampThibNTVQi3sc1bxASn6K7f/gV63qDCKFf/A0Ms/CuxFB3NYtkixImpAvEQa5CvJzW5COCnBf6pYzzBXJbxfpP3PY+WmlGZ2NtK8cYmq3t1tTxIXYiMhwmnUk5qj0k0WJ016UQUhK9Sj1TQk/gFaaXW1rtb9V+F5b3aPJkGSepY7yDcjwieG06lcoYQFotSyKHhNzzmldaeQr5lwNr3HcLMaz7blO0XAc20ptCJ9pBDdbIzUwqBKffEDD7X4+eZb/fLzVnLWTrCcnp8VGKArgT0uDkum8xi/sRPYrGn7KyBXykNlQzh99UZCnO2As/WYnBHz+GNAM7cMQ7nYsfAoRZpH0HBMl8JZjvUXDlWZKC7PdratJX3fvmWCBM8hqt7toGMhr26IyKvTfCQMzSCwACP7GtW9kxExASIk5Vans0tNo0IxUrfBJ+N5hoSJ5aHD3JxrXMlmyTH6d28aP2eziz7da/RHO/bazM8HUZUDvOvASJmjtnFlc0Nt+EhnnBh8eR5I5cQin8hryrxrfFSiZST3VWwYvofZ9A/tO9lC6ysEsCe6Wagh6itgk0K5lbMYH6E1w4BEJMgLbVZJhWiFQB5g181O4a7KpQnhljwxwohQVS2/jTKFb/kg4kBXW/zZZO8spwajT9qezcI3RPBqdxJq1V6Hh8YiUeQ48R4+hmF9BC1wvYExWa7YnwBEBunOchlHsLBUML2gyX9GYs9hEjWsQsYoG2Clj1Cfqtc7AHFdmQ1/zkICxg5VZcqfkpmAVy1oiTNHkpE8zBg8EZz0jPVWHE54/nLb4u3GiP3VBPRNPd0vnp3vDzg2rKSgqHIUXVaEz8av7WYDp6+GIWAfWjs7YTzfFpu8f1SXd28txq+PYfrCQ3xbFD/f8l0WG0Mjw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 639X42lGv9iNwaMh2z6k6xIW5RP+Jl+ulFZSjD+V9N1ocQeDO5/SfI7dO3BPyyRjRCw2oC1XZ6WVURFFVCa/5ROC6cGUyfJ3mHL6Kne9aU7Q37qOYEs5G/3JMZwH0X0TXKpx6f7fWotaF1NBEpAXdQN4MyLhxgPoDoc27B6PywfhhL2jKI29Hz6Nae1CIowm2k+wSlVLDSHaSmnfH4vipgWUqchfle03lzI3Y6VYVjn9J9B8Ysj1Jm/XvetCllxMxTCXU7O8BUltSaBl2cIwi/2xl10bzxabRuKkkMTjwCmqnAKl2SOmgLbHeB1Ko8DXeVHtwco90tfLApJ0XaFZ/Wl8A8EvkdHP5QUoxe3lHUCBJKCm0weGmx7NCdj1Y5xwwayeEwzPGTINbzVCSpgC0+N3Ee52Z1fjxq7H6bCc4cge4vuaHUbQu/VoPzDVJN0m5GtMjHjFZYYOl+/q4zoHdStQWlUd3uahHm+qBY+6CmfMRy9hLFk5HPRGcU9FsZ73wTou910Hl1qcfDbghiLOEWFHBdZQS7h1eWJE23SvWxW2Cc34d46QRZrsix0O0PP7QFSyIRjfQh0Wlag5f5HTV27yvVKW1Gwpdbot8N6L6JL2TfmHagqi0EcX0QQBGFBY2zAw2koleIFKpdwQYMqdAzlcbfREIfYh7tstgODV+4abWLj65sSAC2dCFbAVDrkZ+FVKIQihky+xb67Yh/6dJ4O6OFCKDDkreUeeIyGh+8U1Oz7AJBmrVM6pTEWSsmyVJiKBhID7MshUc4HJzYh5Q0uTSJkrV7q07p26tb7G/QHq81bPNEeBht4nNr+Om1xetp37ECSLl2ty5f6QWf5aw//7VRIH31REPKOuwx1AS/v6ACJPNVxgvLobxT1m01Xk6P+YUiP3RpWBBQ76GUq0hFYdyMrqIMI6Cd+Dp6t0WoS3atXKbR2k7xGJC67IoG9eOtIg4Pkathz/BrG+REPzS9vAF1PBtFHOWN0f9YyGFIJCzAOG9/QCcr/xW/UB6f4FlVURUEDoSMgnLKpqJZa175yBW4dz7O3zhoNuo8spRxCMfXkzKvtsATl+QzAtzx9Dh0mKMlSImTDcxN4hXHNx9mw/kkdHxcVumocJh/4yzrXbFcsNNyNmbIvzVpSDhYh8+xpTJXBKqchQRXeXLfyqRiT+DA9CTTHV2DM4q9suQVQ8lKljqg3t+SMWZViGNvRrecUNGsLE2KqIRr60iSJiRfp7fqlRIiSu0rK7HDKPxYat5S5R7pucZrsUO3Sffdyz+k+9hp3AnyymG0A5Xtt60Nc4HyKMSybPrqxMlyqxhxmOOsQjcwCKOT4/0CwhmBnTVRl4IEPeQ97RBq0GcgUiU1/XKQ5djrraZbk8EJ3RBIkUSd406k9lf1jTXPhWntvyJM/4RyxkPzIcTXrVzLAEcw+sseYAV5n7+s3/WFgZk8lB5Gw5nnQYzpmSfzbCcyBA9qgaugqgIxErOj5jQo3M1jRzMFGBLb36W1dFf7wmzVC6I10asXKxsKBL0Dnv/zBK0sKslKrNDcUyqVmhDzcmteHKSFd/fcA2IsV03dEcU2U= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b932883a-18fd-4271-56db-08dce6ebb41b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2024 16:18:39.4715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a9PCrTs8yLp2T7ZcYb6H00KrXM9aVSw/JV7AEjXBbsHy8+tvqwcfN9v4w/zjTjPlV8FcKvqUgujmE4jFrsN8QQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10254 The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT function to parser interrupt-map. So it doesn't consider '#address-size' in parent interrupt controller, such as GIC. When dt-binding verify interrupt-map, item data matrix is spitted at incorrect position. So cause below warning: arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dtb: interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, 0, 1, 4, 2, 0, 1, 0], ... is too short Remove interrupt-map restriction to workaround this warning for 'fsl,ls1088a-extirq', 'fsl,ls2080a-extirq' and fsl,lx2160a-extirq. Other keep the same restriction. Signed-off-by: Frank Li --- Change from v2 to v3 - remove interrupt-map restriction according rob's suggestion. Change from v1 to v2 - remove duplicate function in commit message - only reduce miniItems for after 1088a chips - maxItems change to 9. Otherwise report too long. --- .../interrupt-controller/fsl,ls-extirq.yaml | 26 ++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml index 199b34fdbefc4..7ff4efc4758ab 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml @@ -82,9 +82,6 @@ allOf: enum: - fsl,ls1043a-extirq - fsl,ls1046a-extirq - - fsl,ls1088a-extirq - - fsl,ls2080a-extirq - - fsl,lx2160a-extirq then: properties: interrupt-map: @@ -95,6 +92,29 @@ allOf: - const: 0xf - const: 0 + - if: + properties: + compatible: + contains: + enum: + - fsl,ls1088a-extirq + - fsl,ls2080a-extirq + - fsl,lx2160a-extirq +# The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT +# function to parser interrupt-map. So it doesn't consider '#address-size' +# in parent interrupt controller, such as GIC. +# +# When dt-binding verify interrupt-map, item data matrix is spitted at +# incorrect position. Remove interrupt-map restriction because it always +# wrong. + + then: + properties: + interrupt-map-mask: + items: + - const: 0xf + - const: 0 + additionalProperties: false examples: