From patchwork Sat Mar 9 04:19:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 10845885 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 61A2F1390 for ; Sat, 9 Mar 2019 09:38:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4901F2DF41 for ; Sat, 9 Mar 2019 09:38:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A06A29918; Sat, 9 Mar 2019 09:38:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1EFA628696 for ; Sat, 9 Mar 2019 09:38:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6850089B18; Sat, 9 Mar 2019 09:38:32 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 426 seconds by postgrey-1.36 at gabe; Sat, 09 Mar 2019 04:27:05 UTC Received: from mta-p5.oit.umn.edu (mta-p5.oit.umn.edu [134.84.196.205]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85A046E34B for ; Sat, 9 Mar 2019 04:27:05 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id 8F2A0CDC for ; Sat, 9 Mar 2019 04:19:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZPstUqOTzJIP for ; Fri, 8 Mar 2019 22:19:58 -0600 (CST) Received: from mail-it1-f200.google.com (mail-it1-f200.google.com [209.85.166.200]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id 68E4CCD2 for ; Fri, 8 Mar 2019 22:19:58 -0600 (CST) Received: by mail-it1-f200.google.com with SMTP id v12so13788099itv.9 for ; Fri, 08 Mar 2019 20:19:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7eog7oJx2PJgBSvuyndleqUfLc5OD3EgjG/1TSyVsWU=; b=h4kmAz/W+AltCDaQXAS4pIq5v0VtfxLdHtbHy9Ijd+VbX+5boLzow1jLt+Mjlxm6HF tca2CkfYxuhuq11KFyGZ/Ru3yIcDk6PyDgoCALOo+Ti3Z3XAgfYhATyAEW8XYi1SfKqf nfHHer9j+Ds4jLNDUJ0dSDtuIos0r1XsLLatXHT+RO2dux3TTJmV4yLp7Ahi7CWWcHk2 gilbF892dgJ94jZcbA95HuvCfCBvquHxpa/diKhjkWnUuat0mRJhSm88ALJjmSMYZn1w 9kQDRMURUF7khuqYGj5QMeJ4lUEkB0JhQE9yqr4gjn+X18+yYqgMzPgdPCMdQyCXoSA0 0eyQ== X-Gm-Message-State: APjAAAXOKylmqwMVYvxqBSkh+0QMHrNN6adPiX6dSlUh2x9rEdu/wY5g Hej5xvUium02WFA62QLVMK6E0C/DRpS01mvj3pK/qkaJbLBj8RCGXqFL/Zn9ZI6CiayQbHfr+7D g7VtpZJu8V0txc4ZRkAvM9Y1UuhxtV1TN X-Received: by 2002:a5d:8d92:: with SMTP id b18mr10917775ioj.272.1552105196571; Fri, 08 Mar 2019 20:19:56 -0800 (PST) X-Google-Smtp-Source: APXvYqysyNrq0vPZx87InMpYskfQPQrNrjUWLxG54PiNcb5M/5Cig1Gnk95kMFLQm9tASmnCdsp+NQ== X-Received: by 2002:a5d:8d92:: with SMTP id b18mr10917764ioj.272.1552105196336; Fri, 08 Mar 2019 20:19:56 -0800 (PST) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id 136sm5022628itu.35.2019.03.08.20.19.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 20:19:55 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Subject: [PATCH] gpu: amdkfd: fix a missing check of kmemdup Date: Fri, 8 Mar 2019 22:19:49 -0600 Message-Id: <20190309041949.3176-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Sat, 09 Mar 2019 09:38:30 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=7eog7oJx2PJgBSvuyndleqUfLc5OD3EgjG/1TSyVsWU=; b=ldfOFN+rB/MrY/mXDgmE3QAipnxqper6KVxDFMHnx00WccQRZU7ldT7ymxabMUuDee rUC8IXiaul8z8TGrkO2sKg957bKgbH04lT/KbF6Iqq6QqnE4USiy7+tVjeA8ff2CDF4k uuZ4c3XstJBQaxoKkwB1E8NmuJ9DyBT+4Q0GdOOf3TCAl1v39PzY6b/S0RYZncnO9BBk 6OvRUApxa+OpW70l4BlQDEw1xvgyvaqmF/zKdjJxANwHQzergNliIx1A1hucB5pAq2Bg Ym1dgqqpbxhs1N6TRM59J6qPRkLN+Tu2JOOmbDrNMOAOgmUNQgkgnzjcy1fkcDlxdt9C TGgw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, pakki001@umn.edu, Alex Deucher , =?utf-8?q?Chris?= =?utf-8?q?tian_K=C3=B6nig?= MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP kmemdup could fail and return NULL. To avoid null pointer dereference, the fix checkes its return value and returns ENOMEM upon failures. Signed-off-by: Kangjie Lu --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 2e7c44955f43..7ef62d4e7598 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c @@ -404,6 +404,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink, return -ENODEV; /* same everything but the other direction */ props2 = kmemdup(props, sizeof(*props2), GFP_KERNEL); + if (!props2) + return -ENOMEM; + props2->node_from = id_to; props2->node_to = id_from; props2->kobj = NULL;