From patchwork Sat Oct 12 06:21:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chizoba ODINAKA X-Patchwork-Id: 13833487 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1935137923 for ; Sat, 12 Oct 2024 06:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728714099; cv=none; b=OFBOatykYViO8euhLOSBxqRwAuULe1aR9A6L/ZwbRNAtuh+wkb52olb4ANwGrCWR0b7ecMrRuaVNqKHhq6uKbO6JGLqnpVeDN1s5RHmb3p6KBo9SyzllJqDNJV/v6oQZydc+VjlTyYIKd1Rz7sOiQ8dGzp53SmKFtMN4PmGnUQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728714099; c=relaxed/simple; bh=EjJ52DYtB0yjlyMo++o1RFENLnRBJCMFA9idXWFpWbY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fFHWTGFWZN0Gk7JjXd75iEX9pYH8xpLWrugX/Xq4yk5WKbIe8x94VjBX2Dd3uxBKnWADew7T1sBRO2qAzz81a5wO11yFcL0IMr4LxcqBunw9QgmEe8jZFbpOwwSDDm9hFeg3M4ojrvyLMEEVbsMDXdrBTjuzDzIZpRXn9dHYJAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NBcS02sl; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NBcS02sl" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-430558cddbeso17237505e9.1 for ; Fri, 11 Oct 2024 23:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728714096; x=1729318896; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2aYpFNXHM9b20tni5G6h0Yy4dvobJ1ztmeu72K6iwFA=; b=NBcS02sluV+IJ4lxy1RI/7vo2rA936cFVAc9F2n3WrZ3KQElcQdqCf/VycmCFD/2OQ gLpVFTFiWlEZQdKUO45UnX9hFxXkgYe/BV7Sx1sYzVJHbkjUZ4e2jidEJaBc5Y2nyapb Kv0nMA6JAsq6c2hmdWsfDFWDdpOT1ViqDiroIDDAvPJlrgJ+4bMK9cnCJLV6P1tQYq9c qcf/PThPk3rkX1ppN5RKNjP2gZFd0CbrFttMAPnd2Gyyb8c9Mc4tTbXR1k1EuUTBS07i dkPXstNJCyibQAK/uu7c2W2y4uNFFPWQ6CktyoqwEXTxwboXXMP8X/FhjRVgxEWVCwme 9Ijg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728714096; x=1729318896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2aYpFNXHM9b20tni5G6h0Yy4dvobJ1ztmeu72K6iwFA=; b=ACOboA5xVnWiK0D09jL3NsgKvGy63nDhOnRs95qKcQnySZBGY5rjEV6pPTUKOi1BEF rHK+NGKachrLY2JS2aDIxx/YpBwTWO+GkI5r85tkFp2RgYzI75wGfy+C2cZk62cwmePB JyRzg/gtBCnHRsW3RCd2YTavCLrDDqtel+uoGg5bAqdIOcUoILLHfhXeN6Rh87a/n7N+ qLk8epjnq8tP/miQlqez2jt6qCx3FYAjdlduWgg5FcaWVL08AqJ/rkZTrSlhfAZVQ+in 7JavJLeSRH57+Ez51fRHZe3VNidWN+E90wjdl3woPy3pbURf3Jvt86Wn4rj6qqSi9OzJ 17Tw== X-Gm-Message-State: AOJu0YwzHWDHbVXSoBYsBnI8Vahce1WgA/i8NGDu5dPvgqfhFlhzgjQT faQeZsokYlulg1DSpspfKlT6g745o34alTDoG1itKTpeFQ7OD5TYwMtVrfFVfcs= X-Google-Smtp-Source: AGHT+IGu0Nhof0cuSaDKXH4b6SyTeBsVQDOBNJTNdGhSvlRxVP8FBND8da2lU9F0syPeymzthIP66Q== X-Received: by 2002:a05:600c:b9a:b0:42f:84ec:3f9 with SMTP id 5b1f17b1804b1-4311d884328mr41946235e9.3.1728714095540; Fri, 11 Oct 2024 23:21:35 -0700 (PDT) Received: from zihco-Latitude-7390-2-in-1.. ([105.113.33.177]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-37d4b79fa3bsm5504932f8f.78.2024.10.11.23.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 23:21:34 -0700 (PDT) From: chizobajames21@gmail.com To: chizobajames21@gmail.com Cc: git@vger.kernel.org, gitster@pobox.com, phillip.wood@dunelm.org.uk, ps@pks.im, sunshine@sunshineco.com Subject: [Outreachy][PATCH v5] t6050: avoid pipes with upstream Git commands Date: Sat, 12 Oct 2024 07:21:26 +0100 Message-Id: <20241012062126.603967-1-chizobajames21@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241011235959.596136-1-chizobajames21@gmail.com> References: <20241011235959.596136-1-chizobajames21@gmail.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Chizoba ODINAKA In pipes, the exit code of a chain of commands is determined by the final command. In order not to miss the exit code of a failed Git command, avoid pipes instead write output of Git commands into a file. For better debugging experience, instances of "grep" were changed to "test_grep". "test_grep" provides more context in case of a failed "grep". Signed-off-by: Chizoba ODINAKA Changes in v5: - replace 'sort -o' which might not be supported by some platforms to the more conventional output redirection, > . --- Range-diff against v4: 1: 28cab4c752 ! 1: b339b1f550 t6050: avoid pipes with upstream Git commands @@ Commit message failed "grep". Signed-off-by: Chizoba ODINAKA - Changes in v4: - - Correct the subject - - fixed some ommitted output option in sorts that where writing to - stdout + Changes in v5: + - replace 'sort -o' which might not be supported by some platforms + to the more conventional output redirection, > . ## t/t6050-replace.sh ## @@ t/t6050-replace.sh: test_expect_success 'set up buggy branch' ' @@ t/t6050-replace.sh: test_expect_success 'test --format medium' ' echo "$MYTAG -> $HASH1" } | sort >expected && - git replace -l --format medium | sort >actual && -+ git replace -l --format medium >actual && -+ sort actual -o actual && ++ git replace -l --format medium >output && ++ sort output >actual && test_cmp expected actual ' @@ t/t6050-replace.sh: test_expect_success 'test --format long' ' echo "$MYTAG (tag) -> $HASH1 (commit)" } | sort >expected && - git replace --format=long | sort >actual && -+ git replace --format=long >actual && -+ sort actual -o actual && ++ git replace --format=long >output && ++ sort output >actual && test_cmp expected actual ' t/t6050-replace.sh | 133 +++++++++++++++++++++++++++++---------------- 1 file changed, 86 insertions(+), 47 deletions(-) diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh index d7702fc756..37cb6547b6 100755 --- a/t/t6050-replace.sh +++ b/t/t6050-replace.sh @@ -98,30 +98,42 @@ test_expect_success 'set up buggy branch' ' ' test_expect_success 'replace the author' ' - git cat-file commit $HASH2 | grep "author A U Thor" && - R=$(git cat-file commit $HASH2 | sed -e "s/A U/O/" | git hash-object -t commit --stdin -w) && - git cat-file commit $R | grep "author O Thor" && + git cat-file commit $HASH2 >actual && + test_grep "author A U Thor" actual && + R=$(sed -e "s/A U/O/" actual | git hash-object -t commit --stdin -w) && + git cat-file commit $R >actual && + test_grep "author O Thor" actual && git update-ref refs/replace/$HASH2 $R && - git show HEAD~5 | grep "O Thor" && - git show $HASH2 | grep "O Thor" + git show HEAD~5 >actual && + test_grep "O Thor" actual && + git show $HASH2 >actual && + test_grep "O Thor" actual ' test_expect_success 'test --no-replace-objects option' ' - git cat-file commit $HASH2 | grep "author O Thor" && - git --no-replace-objects cat-file commit $HASH2 | grep "author A U Thor" && - git show $HASH2 | grep "O Thor" && - git --no-replace-objects show $HASH2 | grep "A U Thor" + git cat-file commit $HASH2 >actual && + test_grep "author O Thor" actual && + git --no-replace-objects cat-file commit $HASH2 >actual && + test_grep "author A U Thor" actual && + git show $HASH2 >actual && + test_grep "O Thor" actual && + git --no-replace-objects show $HASH2 >actual && + test_grep "A U Thor" actual ' test_expect_success 'test GIT_NO_REPLACE_OBJECTS env variable' ' - GIT_NO_REPLACE_OBJECTS=1 git cat-file commit $HASH2 | grep "author A U Thor" && - GIT_NO_REPLACE_OBJECTS=1 git show $HASH2 | grep "A U Thor" + GIT_NO_REPLACE_OBJECTS=1 git cat-file commit $HASH2 >actual && + test_grep "author A U Thor" actual && + GIT_NO_REPLACE_OBJECTS=1 git show $HASH2 >actual && + test_grep "A U Thor" actual ' test_expect_success 'test core.usereplacerefs config option' ' test_config core.usereplacerefs false && - git cat-file commit $HASH2 | grep "author A U Thor" && - git show $HASH2 | grep "A U Thor" + git cat-file commit $HASH2 >actual && + test_grep "author A U Thor" actual && + git show $HASH2 >actual && + test_grep "A U Thor" actual ' cat >tag.sig <actual && + test_grep "A U Thor" actual && + git show $HASH2 >actual && + test_grep "A U Thor" actual && git cat-file commit $R && git repack -a -d && test_must_fail git cat-file commit $R && git fetch ../ "refs/replace/*:refs/replace/*" && - git show HEAD~5 | grep "O Thor" && - git show $HASH2 | grep "O Thor" && + git show HEAD~5 >actual && + test_grep "O Thor" actual && + git show $HASH2 >actual && + test_grep "O Thor" actual && git cat-file commit $R ) ' @@ -169,13 +185,15 @@ test_expect_success '"git replace" listing and deleting' ' test_must_fail git replace --delete && test_must_fail git replace -l -d $HASH2 && git replace -d $HASH2 && - git show $HASH2 | grep "A U Thor" && + git show $HASH2 >actual && + test_grep "A U Thor" actual && test -z "$(git replace -l)" ' test_expect_success '"git replace" replacing' ' git replace $HASH2 $R && - git show $HASH2 | grep "O Thor" && + git show $HASH2 >actual && + test_grep "O Thor" actual && test_must_fail git replace $HASH2 $R && git replace -f $HASH2 $R && test_must_fail git replace -f && @@ -186,7 +204,8 @@ test_expect_success '"git replace" resolves sha1' ' SHORTHASH2=$(git rev-parse --short=8 $HASH2) && git replace -d $SHORTHASH2 && git replace $SHORTHASH2 $R && - git show $HASH2 | grep "O Thor" && + git show $HASH2 >actual && + test_grep "O Thor" actual && test_must_fail git replace $HASH2 $R && git replace -f $HASH2 $R && test_must_fail git replace --force && @@ -209,10 +228,12 @@ test_expect_success '"git replace" resolves sha1' ' # test_expect_success 'create parallel branch without the bug' ' git replace -d $HASH2 && - git show $HASH2 | grep "A U Thor" && + git show $HASH2 >actual && + test_grep "A U Thor" actual && git checkout $HASH1 && git cherry-pick $HASH2 && - git show $HASH5 | git apply && + git show $HASH5 >actual && + git apply actual && git commit --amend -m "hello: 4 more lines WITHOUT the bug" hello && PARA2=$(git rev-parse --verify HEAD) && git cherry-pick $HASH3 && @@ -225,7 +246,8 @@ test_expect_success 'create parallel branch without the bug' ' git checkout main && cur=$(git rev-parse --verify HEAD) && test "$cur" = "$HASH7" && - git log --pretty=oneline | grep $PARA2 && + git log --pretty=oneline >actual && + test_grep $PARA2 actual && git remote add cloned ./clone_dir ' @@ -234,23 +256,30 @@ test_expect_success 'push to cloned repo' ' ( cd clone_dir && git checkout parallel && - git log --pretty=oneline | grep $PARA2 + git log --pretty=oneline >actual && + test_grep $PARA2 actual ) ' test_expect_success 'push branch with replacement' ' - git cat-file commit $PARA3 | grep "author A U Thor" && - S=$(git cat-file commit $PARA3 | sed -e "s/A U/O/" | git hash-object -t commit --stdin -w) && - git cat-file commit $S | grep "author O Thor" && + git cat-file commit $PARA3 >actual && + test_grep "author A U Thor" actual && + S=$(sed -e "s/A U/O/" actual | git hash-object -t commit --stdin -w) && + git cat-file commit $S >actual && + test_grep "author O Thor" actual && git replace $PARA3 $S && - git show $HASH6~2 | grep "O Thor" && - git show $PARA3 | grep "O Thor" && + git show $HASH6~2 >actual && + test_grep "O Thor" actual && + git show $PARA3 >actual && + test_grep "O Thor" actual && git push cloned $HASH6^:refs/heads/parallel2 && ( cd clone_dir && git checkout parallel2 && - git log --pretty=oneline | grep $PARA3 && - git show $PARA3 | grep "A U Thor" + git log --pretty=oneline >actual && + test_grep $PARA3 actual && + git show $PARA3 >actual && + test_grep "A U Thor" actual ) ' @@ -260,14 +289,14 @@ test_expect_success 'fetch branch with replacement' ' cd clone_dir && git fetch origin refs/heads/tofetch:refs/heads/parallel3 && git log --pretty=oneline parallel3 >output.txt && - ! grep $PARA3 output.txt && + test_grep ! $PARA3 output.txt && git show $PARA3 >para3.txt && - grep "A U Thor" para3.txt && + test_grep "A U Thor" para3.txt && git fetch origin "refs/replace/*:refs/replace/*" && git log --pretty=oneline parallel3 >output.txt && - grep $PARA3 output.txt && + test_grep $PARA3 output.txt && git show $PARA3 >para3.txt && - grep "O Thor" para3.txt + test_grep "O Thor" para3.txt ) ' @@ -284,8 +313,8 @@ test_expect_success 'bisect and replacements' ' ' test_expect_success 'index-pack and replacements' ' - git --no-replace-objects rev-list --objects HEAD | - git --no-replace-objects pack-objects test- && + git --no-replace-objects rev-list --objects HEAD >actual && + git --no-replace-objects pack-objects test- actual && + test_grep $PARA3 actual && echo $PARA3 | git cat-file --batch ' @@ -344,7 +374,8 @@ test_expect_success 'test --format medium' ' echo "$PARA3 -> $S" && echo "$MYTAG -> $HASH1" } | sort >expected && - git replace -l --format medium | sort >actual && + git replace -l --format medium >output && + sort output >actual && test_cmp expected actual ' @@ -356,7 +387,8 @@ test_expect_success 'test --format long' ' echo "$PARA3 (commit) -> $S (commit)" && echo "$MYTAG (tag) -> $HASH1 (commit)" } | sort >expected && - git replace --format=long | sort >actual && + git replace --format=long >output && + sort output >actual && test_cmp expected actual ' @@ -374,12 +406,16 @@ test_expect_success 'setup fake editors' ' test_expect_success '--edit with and without already replaced object' ' test_must_fail env GIT_EDITOR=./fakeeditor git replace --edit "$PARA3" && GIT_EDITOR=./fakeeditor git replace --force --edit "$PARA3" && - git replace -l | grep "$PARA3" && - git cat-file commit "$PARA3" | grep "A fake Thor" && + git replace -l >actual && + test_grep "$PARA3" actual && + git cat-file commit "$PARA3" >actual && + test_grep "A fake Thor" actual && git replace -d "$PARA3" && GIT_EDITOR=./fakeeditor git replace --edit "$PARA3" && - git replace -l | grep "$PARA3" && - git cat-file commit "$PARA3" | grep "A fake Thor" + git replace -l >actual && + test_grep "$PARA3" actual && + git cat-file commit "$PARA3" >actual && + test_grep "A fake Thor" actual ' test_expect_success '--edit and change nothing or command failed' ' @@ -387,8 +423,10 @@ test_expect_success '--edit and change nothing or command failed' ' test_must_fail env GIT_EDITOR=true git replace --edit "$PARA3" && test_must_fail env GIT_EDITOR="./failingfakeeditor" git replace --edit "$PARA3" && GIT_EDITOR=./fakeeditor git replace --edit "$PARA3" && - git replace -l | grep "$PARA3" && - git cat-file commit "$PARA3" | grep "A fake Thor" + git replace -l >actual && + test_grep "$PARA3" actual && + git cat-file commit "$PARA3" >actual && + test_grep "A fake Thor" actual ' test_expect_success 'replace ref cleanup' ' @@ -468,7 +506,8 @@ test_expect_success GPG 'set up a merge commit with a mergetag' ' git checkout main && git merge -s ours test_tag && HASH10=$(git rev-parse --verify HEAD) && - git cat-file commit $HASH10 | grep "^mergetag object" + git cat-file commit $HASH10 >actual && + test_grep "^mergetag object" actual ' test_expect_success GPG '--graft on a commit with a mergetag' '