From patchwork Mon Mar 11 02:16:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10846575 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80FF81874 for ; Mon, 11 Mar 2019 02:16:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6858628E3E for ; Mon, 11 Mar 2019 02:16:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5CF1428E40; Mon, 11 Mar 2019 02:16:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C90B228E3F for ; Mon, 11 Mar 2019 02:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727116AbfCKCQk (ORCPT ); Sun, 10 Mar 2019 22:16:40 -0400 Received: from mail-eopbgr50045.outbound.protection.outlook.com ([40.107.5.45]:16622 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727076AbfCKCQk (ORCPT ); Sun, 10 Mar 2019 22:16:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wQj6XBAJpoCzjJx0538v1P/Jx5rtEMPRB5jfLasTRFE=; b=kuYKau930ZHKlYxFAMDW6mU7iurUPYqNIEywaoDg7475SFDLlBASkqIXay3LlXxDuF9/HZkUVbNg5uPFCctnADaxomOvUN+jqyHJc6B5L/Tt9Wf743BsNj1dyL8ewrvYOYeqbEdkB9ul1Cli75KV93QUcV1nUT1opySVlgPY8Og= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB5373.eurprd04.prod.outlook.com (20.178.120.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Mon, 11 Mar 2019 02:16:36 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1686.021; Mon, 11 Mar 2019 02:16:36 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v5 1/5] mmc: sdhci-of-esdhc: add erratum eSDHC5 support Thread-Topic: [PATCH v5 1/5] mmc: sdhci-of-esdhc: add erratum eSDHC5 support Thread-Index: AQHU17B0lD/1lUIffUeUWC+7OMb+9Q== Date: Mon, 11 Mar 2019 02:16:36 +0000 Message-ID: <20190311021814.42326-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0P153CA0047.APCP153.PROD.OUTLOOK.COM (2603:1096:203:17::35) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7a71b98-4d01-4f78-1c0b-08d6a5c7963f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5373; x-ms-traffictypediagnostic: VI1PR04MB5373: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB5373=3B23=3A7j?= =?iso-8859-1?q?bDD0xwEBo2UemZE/ZaKLNO9Fvf7z1XrPL2pQDZ7HWJ2k925Gv4D/WAV4Cmri?= =?iso-8859-1?q?JTQelXaYrhmzE1yIRjN0s0rrQP/sQ46EJLkEyENwEyo9RMfwD7/q7y4S6oS3?= =?iso-8859-1?q?vV30TT5E8/yGLIvAXhjqwmscP4qwc89L1VkEQ+uhcH7LM0kJZE6y5Ll4nPqe?= =?iso-8859-1?q?tx1ZQ08aGiIFC1sWSbudTDYEheh9PjRGq5gC4ZzmJwOHZVxumVcEHQIDUtNh?= =?iso-8859-1?q?UJ+cSDtDqa7la2m88ganFy1nVlKvSxxGDq/ruyi2q8GWugL37MdwjnKQo++E?= =?iso-8859-1?q?8AuW2eyAoW6LDcVgOSXUesSE+xi2eSmBBTWhcI5FRakKk4gjvOC77J4HEk+g?= =?iso-8859-1?q?w8mydEdUZR81wUADX33pPZ4biJxPpQKEAA3o6D9vy2nqHPXS84rXOJgk8Pu+?= =?iso-8859-1?q?bY8bhNO+NtWATQtJBwdiE2m/Sp4JFF+2wXkTMhIQagzwh4o28kVyhaToGm16?= =?iso-8859-1?q?swoUAGvLFcD6/C3G3T285AxYuxWmB90LjHrEWmFSGZxGzckjhV5bP4C4nAKh?= =?iso-8859-1?q?iFjKJlzQVEYZ2OVq1ltkNlX8EsdvmVDIS5LsCQbU4aRN2L7xw8LdVp6oQ6wi?= =?iso-8859-1?q?OHwViwU+9AhthYlI8AVGDf/csExr1DXrdqGeQnWBVDXUS0Vh8DWTJSMnSNJ9?= =?iso-8859-1?q?D44iEztjpT95dgW1qBfv/9cTmbh1KCHm/v4FppOvFHhWMmhdrIZhlSbSauZb?= =?iso-8859-1?q?cbyxJ0TBr/oK03hxiCUnijWXISImcS1ocCkazsaiFAmQ4Ix2BamhwQZwk/NS?= =?iso-8859-1?q?qqIdEjKyds25Eob2LZg5M7QRImw6j69xe8dhvNX8Jr7CdPptksc+CGJXrQCR?= =?iso-8859-1?q?E5OiqA89ciazTC+0Wcz1MlDb1pyHf8ixFlvcBjpafnPpKwmGg6Y3WbJsJtqb?= =?iso-8859-1?q?FVpdcqufllI9m1UX8eoGIADngCAZzVTBsdQ3w6sRR/X6l1msII2uILDGP1zw?= =?iso-8859-1?q?kgijOiAAB5YgYM/v9lyddU/sywcTjmGiGh8zAxzelW7TNpTFImp0fWJAeOI2?= =?iso-8859-1?q?h6TnkmwspNUVbWr4juUTwRy/tnEdlJ8SWhu8Vqf1q29SmhZDE7oFdOtyPQxR?= =?iso-8859-1?q?DMKeHZKuENbDXfqFBoNd7fnXP1GL29duf24HGSjuUCK8z4TRM8HyQEL5ZP6e?= =?iso-8859-1?q?3hcpc2x3uV8vR3HJpDd3oQZVGED7Jj2nvytGp/+5MWt7Ml+SKB9buxEn29O9?= =?iso-8859-1?q?oTC9FspuKZvyKh?= x-microsoft-antispam-prvs: x-forefront-prvs: 09730BD177 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(39860400002)(366004)(376002)(136003)(189003)(199004)(50226002)(106356001)(44832011)(66066001)(53936002)(486006)(2906002)(476003)(2616005)(478600001)(6512007)(14454004)(52116002)(26005)(7736002)(71190400001)(54906003)(256004)(14444005)(110136005)(316002)(6436002)(305945005)(102836004)(6486002)(36756003)(97736004)(6506007)(71200400001)(68736007)(86362001)(4326008)(99286004)(386003)(186003)(105586002)(2501003)(1076003)(8676002)(81156014)(81166006)(25786009)(8936002)(5660300002)(3846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5373;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: mFNvQhWKim/qkbRyMUm20GSRvXwT9o0bY9nJhIsdmBf7fW8Hukzn9MCh76EjG3pmNXFbZaxOLO11WMQySGYYJHuo/J1u6L1SV9gc/6u05qL5jbPHxFIJajyMOmsewhxMy7azKLCeuE4cBCsu115aPqwIAbdJjIEjNVopOEsPtmCChFcpC65OVDcDj4mKGxvSXiIyxXEZwSbQeVdKRqQchHs+3kcEFICTZzTj7WFcbnRxOql7ur44LRpc5nC3avDPEE8dfs5BtIPVjUiFUBruMDiEdIonfca3hWQXfUaFMvw92UdmmrkTnMhY3laZ2hC0IUDDZeZoMohyccvBLwRoNltcLtx+N/jFMXfq1Mju/O3w9lwyvL5olSqx4/NKGBzKyDh5ZkbX3QpG4PXreYd9son0GcrDZHzAKzvAVpHucDU= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7a71b98-4d01-4f78-1c0b-08d6a5c7963f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2019 02:16:36.4362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5373 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu Software writing to the Transfer Type configuration register (system clock domain) can cause a setup/hold violation in the CRC flops (card clock domain), which can cause write accesses to be sent with corrupt CRC values. This issue occurs only for write preceded by read. this erratum is to fix this issue. Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 4e669b4edfc1..9da53e548691 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -1074,6 +1074,9 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (esdhc->vendor_ver > VENDOR_V_22) host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST; + if (of_device_is_compatible(np, "fsl,p5040-esdhc") || of_device_is_compatible(np, "fsl,p5020-esdhc") || of_device_is_compatible(np, "fsl,p4080-esdhc") || From patchwork Mon Mar 11 02:16:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10846577 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 770A5922 for ; Mon, 11 Mar 2019 02:16:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6266528E3E for ; Mon, 11 Mar 2019 02:16:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5671228E40; Mon, 11 Mar 2019 02:16:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E701828E3E for ; Mon, 11 Mar 2019 02:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbfCKCQo (ORCPT ); Sun, 10 Mar 2019 22:16:44 -0400 Received: from mail-eopbgr00059.outbound.protection.outlook.com ([40.107.0.59]:20967 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727076AbfCKCQn (ORCPT ); Sun, 10 Mar 2019 22:16:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2nbR9f2RaiW9/64INmx5nLa71hGKoHF6PFehDPpbMG8=; b=AlwAC6z+jcXtfsjG3dZOPAywQTtUHZ5NKpGmejwVFVGlcaYaBcmxy9tTcPWKJvWB9xoC2gGNYlNW2dvIa9eM0b4Gy1aJ+Vc+IAQ/Uoja1OMAqdj1F8XEntxDJn6wPN+FEwRAdARHxVW4+/h53sW342T/8arCtEYfUOYF7dd7L8c= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB5373.eurprd04.prod.outlook.com (20.178.120.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Mon, 11 Mar 2019 02:16:40 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1686.021; Mon, 11 Mar 2019 02:16:40 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v5 2/5] mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support Thread-Topic: [PATCH v5 2/5] mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support Thread-Index: AQHU17B23knGKUSwDEq471whA+Ah3A== Date: Mon, 11 Mar 2019 02:16:40 +0000 Message-ID: <20190311021814.42326-2-yinbo.zhu@nxp.com> References: <20190311021814.42326-1-yinbo.zhu@nxp.com> In-Reply-To: <20190311021814.42326-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0P153CA0047.APCP153.PROD.OUTLOOK.COM (2603:1096:203:17::35) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6785e0cb-dfaa-489c-e558-08d6a5c79896 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5373; x-ms-traffictypediagnostic: VI1PR04MB5373: x-microsoft-exchange-diagnostics: =?utf-8?q?1=3BVI1PR04MB5373=3B23=3AitaH8km?= =?utf-8?q?1VjQzznHswB5UPytwSwM5xEdnPHR5FoQiWJVatX6ocgz5KQyjhUMni0JOXOYrz//t?= =?utf-8?q?7pSdo/+wf9S4rZwBLWFX0quzaPgMAaWOV3vqc8FuK8NpK/u6tj+EyjpfQ0au+Tw+o?= =?utf-8?q?XTIoMORLL+4s4kXXP5WX0LmblfZHK7oYg7mMVwcqSnWTkOZfdvxs0gH6JWtXX7K4A?= =?utf-8?q?YuCvgwzWNNj9LRN6qHdR56Ncl0LJr3ZnJuGEW7OcOJBANzOXZJNAFTwholMRfb5kX?= =?utf-8?q?zQyNIHa5RgG7UaSvXwQLsLjFT48cR0SeyzpB6VWZO6SEnT5ARkXMNfVybXTrrMUdn?= =?utf-8?q?AhejKfdgWrc92id0/8JQNma+s7R8TnccC9DFEZpOtCllyXXqzkiE8xv4ZEeAzvtwM?= =?utf-8?q?fLThmaaW/gZ89GhTgqTgf+IaB7Wrvm98QWN5RkIx8sBROwW6SFk0KqRCq6dhLqs0f?= =?utf-8?q?0IQM0zWO+bTtubf6IT/pVbQjFGRXt+NPxo3A6yanlNrup2wHTdSSvK64H4jHI9haT?= =?utf-8?q?tYmrUc0JW0m4xHzwLvfHlx03pzuUXGj7HJE64op2+j1vys/NKcsVhI7oM9PDsih4o?= =?utf-8?q?80sKeA6tlsHZjX9q65njcd+y5mFGxhkFGnhmnCPST/cFyLgehPPQjqkpt2MBNFz6D?= =?utf-8?q?eM3u06z8eM1sacAqF62l8o7Kkizt4L3oxuudgERIKhsopllk7/FmRCggT6AHITEpR?= =?utf-8?q?xaBRbXt/LOSLxtWwnpNDbgzkOxgOuWUzL5/QEVu9lhOq+YXTQ3BDEQh5WGjf1AW2C?= =?utf-8?q?9/+IZNg7zptv/98xvQ+mS8k9lIfeR/a7COVHshsG9Ycay8x1ssWT+3f7WMfHT/rYi?= =?utf-8?q?VJA2P16H4XuUWD9M5p2TqflD+pkAwfgV4NaeYrDtNey9SOoT5dw9K4DlNCPqF33Iw?= =?utf-8?q?IBEPiDk8NrLBRxPB2Pd/+ukmsMbIVH4Cxz0VHv5QcHhG/Ua1b47q4GQN0Y4/zYHSm?= =?utf-8?q?Mk40vpUg/Zyeo87cu2Rw1AEnPS9PQpRhiNbiJELbqkZQ7sjKl74Lox/mn5NKhau20?= =?utf-8?q?fyLkhAF7ZXCtworWHv5+1SR6Gz/IS4x0JjcoIkwVMxjdXruWkWc4wJbMHzjb2OIgK?= =?utf-8?q?p57GK2m/A3JrWGtKGLwu8q2uZh1tfjoX4z9Faf6ZSrJUWzRnRia0kfgp9h+utBH/u?= =?utf-8?q?gLOE/jsK8l3E63GJYy3CfVwcHNR8uS4BdnBSXqn/gYNz6MtwyWTdW0Yf9ke6qnLiG?= =?utf-8?q?RV6XqwI8qpy1S8mhr86FbFCzDD9HxEL6IBdac9?= x-microsoft-antispam-prvs: x-forefront-prvs: 09730BD177 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(39860400002)(366004)(376002)(136003)(189003)(199004)(50226002)(106356001)(44832011)(66066001)(53936002)(486006)(2906002)(476003)(2616005)(478600001)(6512007)(14454004)(446003)(52116002)(76176011)(26005)(7736002)(71190400001)(54906003)(256004)(14444005)(110136005)(316002)(6436002)(305945005)(11346002)(102836004)(6486002)(36756003)(97736004)(6506007)(71200400001)(68736007)(86362001)(4326008)(99286004)(386003)(186003)(105586002)(2501003)(1076003)(8676002)(81156014)(81166006)(25786009)(8936002)(5660300002)(3846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5373;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: D6vUAPmho+qVMCk7AJNYktJJTutQxh/dgoFlFj7ificV/5PlagtzctOOJh7UZu8C+9Zk652G5UpFnsyL+cGWtuyNjPM0sjk9vMUpUVwOfD1L8h51bIj/bkmmEJTcpmdCIxR9yi6Z1CbuGrdGkEFoWfpkiDp5hvKb4K5B+2Tg4eSehmLWXgwHb1d23ATD4rBc4eBznySW+iNkGVmVBCpd5mmvkfYnY1F88ud0KljM9YP7V9H4LQeCWeyrz7KrDOzUg2Ny9IIPKj5BLtzjM27Pd1mSdWwQZnNebuL9ERBnqO3IFRyMjbUlNJM4F8mIq/NJLd2X1WPv11nPICYSAXb8bFyC4t/Phru9nS6aEjc2VPtia80JG4XrVyK8NGW2WhaOFYiG4vJ8MESj0VtzWJ1e9Mw2Hy1+o8QPgT/RFy1L7wk= Content-ID: <6A13AB151952F241B791A36448B2AA6F@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6785e0cb-dfaa-489c-e558-08d6a5c79896 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2019 02:16:40.4940 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5373 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu eSDHC-A001: The data timeout counter (SYSCTL[DTOCV]) is not reliable for DTOCV values 0x4(2^17 SD clock), 0x8(2^21 SD clock), and 0xC(2^25 SD clock). The data timeout counter can count from 2^13–2^27, but for values 2^17, 2^21, and 2^25, the timeout counter counts for only 2^13 SD clocks. A-008358: The data timeout counter value loaded into the timeout counter is less than expected and can result into early timeout error in case of eSDHC data transactions. The table below shows the expected vs actual timeout period for different values of SYSCTL[DTOCV]: these two erratum has the same quirk to control it, and set SDHCI_QUIRK_RESET_AFTER_REQUEST to fix above issue. Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 9da53e548691..1ac11331671e 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -1074,8 +1074,10 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (esdhc->vendor_ver > VENDOR_V_22) host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; - if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) { host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST; + host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; + } if (of_device_is_compatible(np, "fsl,p5040-esdhc") || of_device_is_compatible(np, "fsl,p5020-esdhc") || From patchwork Mon Mar 11 02:16:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10846579 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E4054922 for ; Mon, 11 Mar 2019 02:16:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF06528E3E for ; Mon, 11 Mar 2019 02:16:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C38DC28E40; Mon, 11 Mar 2019 02:16:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 655BE28E3E for ; Mon, 11 Mar 2019 02:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727201AbfCKCQs (ORCPT ); Sun, 10 Mar 2019 22:16:48 -0400 Received: from mail-eopbgr00081.outbound.protection.outlook.com ([40.107.0.81]:12679 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727076AbfCKCQr (ORCPT ); Sun, 10 Mar 2019 22:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nCFFYhx+pL7dgO0w+spAZRxoEZ09Adjdg6DyOfbhWtk=; b=ifqGYLR4Rl7l2Zbn9lNiC9SRefIP8FhTx/5RD5wpgtcq0SucWmTN1M8lziyEqhTotHHF0G5uwqqZQl0vMkaApGB4SD/j7G2zG37l3MC0mtF6miDLtco6kd5OdsIHyrhapPedAu6sn7BHw4IF4d00lkrTol/YsH0GbemVcoZrVnY= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB5373.eurprd04.prod.outlook.com (20.178.120.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Mon, 11 Mar 2019 02:16:44 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1686.021; Mon, 11 Mar 2019 02:16:44 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v5 3/5] mmc: sdhci-of-esdhc: add erratum A-009204 support Thread-Topic: [PATCH v5 3/5] mmc: sdhci-of-esdhc: add erratum A-009204 support Thread-Index: AQHU17B4X3T3axT8zU6yyJouF6e/aw== Date: Mon, 11 Mar 2019 02:16:44 +0000 Message-ID: <20190311021814.42326-3-yinbo.zhu@nxp.com> References: <20190311021814.42326-1-yinbo.zhu@nxp.com> In-Reply-To: <20190311021814.42326-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0P153CA0047.APCP153.PROD.OUTLOOK.COM (2603:1096:203:17::35) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3152907-1147-4c19-3a43-08d6a5c79b02 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5373; x-ms-traffictypediagnostic: VI1PR04MB5373: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB5373=3B23=3A2x?= =?iso-8859-1?q?UwfG8W0VFIFY1FK3GDmzEl9U6nEahbEFnpOmsyPoqzkQ+8+nPZYADFQIU7JU?= =?iso-8859-1?q?AAOUirLPMy2bvsLoejRpGAaQTUqx2uNO2Newpy4celDrrqSBpl9NcYt33/o0?= =?iso-8859-1?q?OfZIq+wv4OGC97zUJcGvZrLtFkyFicOAstaTSxAFEnvjL3IeY9mFCbl0oUeV?= =?iso-8859-1?q?DahLbcSRrgefySJkcBdLy8sFdxWjIEfYHZDD0xFnZMVu65uhZKDXPEW0DpFb?= =?iso-8859-1?q?KV8qeBPlFRZ41/Y9T+JS4HmuILH3cQqT/RWfY7uWwxQFj8sVLgKCMpdAkzyR?= =?iso-8859-1?q?CvlrFjU9GiWzyqXPGFM7OWZA4gmYZUr97Ufx7motJgJPCt+8cJo/ITPkMD7B?= =?iso-8859-1?q?+pQr6Utc3VC0YiPAoxh1ImvlIosB/Zhro1ht/i62V+UJYTjHVu4miaSuCceK?= =?iso-8859-1?q?d+6OgjswLiD1Vx5T6r84/y1rh8f5V/UE828vMH1u8nVi6G8CyLZyOLcDsmiV?= =?iso-8859-1?q?swzqM+yWf14GBaGDT4IVH+89S62j+BUpSobsNbhO736yaLn3IiD9oQHnUlbN?= =?iso-8859-1?q?cJA2vXyuh1H788IH1frKfDEnSa9TF/nEpTnTLn2DK1g2z4qN8CBwMHee937l?= =?iso-8859-1?q?bUOCg2E+o6h/QLjBsCN2v0VYTym72SrfNsPRTnXnNKIsecNkkXvWjKc8FyHy?= =?iso-8859-1?q?itBeISWrinMiF7fpJ+BvV7J1CISF0dVmSJcta3Yh73J0Vh4LJVF/CkGPNVJ+?= =?iso-8859-1?q?Akg5aq4JrXWIhnjXCn8A2NxcAWfRS4kQ2MgqlN7lTDkgwCKYTCYj9YvV1z1k?= =?iso-8859-1?q?lA7KO9d7dwjXeVvkaRgIJD1waUFAyzyxof1myt89uqF+4gF5AZ21L8FWj42N?= =?iso-8859-1?q?gDDxJ9FwefyOnlLstRgESiYmWfOoJAoDO/UWwKQiHYrXDEOxqSsYLAXoFpxf?= =?iso-8859-1?q?/dTcxGWr/gIAg5diI8+2gwUW33Hl0MLvsWUUkGMYx/blylxZu4QNjuWYC5XS?= =?iso-8859-1?q?DYUbn00ZA3yMWQk1TqnLBZK/uip4mt7lUZ+gRcdrgQDCYMXsbuCRi/KH6KpL?= =?iso-8859-1?q?w4WfBEaVTdWZcOwmkfpD6+bMeSEJiIR88TUSLOful0ZdXKCZvYhBwEklCo/S?= =?iso-8859-1?q?ZQKNP9gkYxw6AUH9USmR3HCWTezaIUqL2yKJRVY6tSWiITXLlTXksQJz+8QK?= =?iso-8859-1?q?EzU5VS6s2Rjy9ivri9ffWKbXWVBOUS9efTcUbwe507DjHgRvRK7ACcjXvLjW?= =?iso-8859-1?q?bu9/EVQ9prlgoybzioLgMVUw66VcIhgmXX0UeMRqGNIhd5VtKkBmmKpSx5P8?= =?iso-8859-1?q?BTINLJ0VIMi2anOONn?= x-microsoft-antispam-prvs: x-forefront-prvs: 09730BD177 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(39860400002)(366004)(376002)(136003)(189003)(199004)(50226002)(106356001)(44832011)(66066001)(53936002)(486006)(2906002)(476003)(2616005)(478600001)(6512007)(14454004)(446003)(52116002)(76176011)(26005)(7736002)(71190400001)(54906003)(256004)(14444005)(110136005)(316002)(6436002)(305945005)(11346002)(102836004)(6486002)(36756003)(97736004)(6506007)(71200400001)(68736007)(86362001)(4326008)(99286004)(386003)(186003)(105586002)(2501003)(1076003)(8676002)(81156014)(81166006)(25786009)(8936002)(5660300002)(3846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5373;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cmDwLOh/PtGZ//Pua1tIfoY0FXsPGigUHOgvcQkAcAWTheLkCWknJbdKCDSGgWR3trfdMJJmWbkQbYqYe3Bh2cYjoSNbKt68LoYPJGyMO7wTE/3+eaEyq+FlwnJEbX76ecGMesqn/DaMBZVKkZ0rQoXgU9zYw7ZR+EeYAuihOHYiq38F9DOtItftNu2SqCeFeT5AFyD1XzXGUD3aDQK06eCGN5XfVxZKa+EuWhwK3FtK3Hn/7lLJXyPm76qx5YQZS68lrRTlhxF3oJDyPk6PkBsG0KK9MiVJBdw6iAL7NnWJzT/jbakXiSUfxARHGe0iZLvwxlETKrS++fqfcY55Vg7OaJ2JVjmZZf8cBk9aaxe7hFQUrXgrUJDJSs/zBtfR+N1Kbcxtt7co7g9MgeDpm0+oLaFGICWRQU5xnFX/xKc= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3152907-1147-4c19-3a43-08d6a5c79b02 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2019 02:16:44.4338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5373 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu In the event of that any data error (like, IRQSTAT[DCE]) occurs during an eSDHC data transaction where DMA is used for data transfer to/from the system memory, setting the SYSCTL[RSTD] register may cause a system hang. If software sets the register SYSCTL[RSTD] to 1 for error recovery while DMA transferring is not complete, eSDHC may hang the system bus. This happens because the software register SYSCTL[RSTD] resets the DMA engine without waiting for the completion of pending system transactions. This erratum is to fix this issue. Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 1ac11331671e..7e0eae8dafae 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -694,6 +694,9 @@ static void esdhc_reset(struct sdhci_host *host, u8 mask) sdhci_writel(host, host->ier, SDHCI_INT_ENABLE); sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE); + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + mdelay(5); + if (mask & SDHCI_RESET_ALL) { val = sdhci_readl(host, ESDHC_TBCTL); val &= ~ESDHC_TB_EN; From patchwork Mon Mar 11 02:16:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10846581 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC91F1823 for ; Mon, 11 Mar 2019 02:16:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B795328E3E for ; Mon, 11 Mar 2019 02:16:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AC2D928E40; Mon, 11 Mar 2019 02:16:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41F6428E3E for ; Mon, 11 Mar 2019 02:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727203AbfCKCQv (ORCPT ); Sun, 10 Mar 2019 22:16:51 -0400 Received: from mail-eopbgr00053.outbound.protection.outlook.com ([40.107.0.53]:28225 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727076AbfCKCQv (ORCPT ); Sun, 10 Mar 2019 22:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHyiw5bXdTtV7hMRxycyJRSPp4j1uqU0/rf8fSs+vOQ=; b=ld7J+PiSGhv7T8jE/HXvD3jwQQUX2nA4gG+c1QDhl4CtjAtFnf5u63FLqVd0cUI/eK0ZI6gYXJbXkgYCu91qajoGI6UcfK0enFeGq/z0FoXhOw51JSEYr7rTpAOP2LN+ebvsLV7pQLtda7HAzeZ9492d9fhi2LjlTmUlz4e+eGM= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB5373.eurprd04.prod.outlook.com (20.178.120.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Mon, 11 Mar 2019 02:16:48 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1686.021; Mon, 11 Mar 2019 02:16:48 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v5 4/5] mmc: sdhci-of-esdhc: add erratum eSDHC7 support Thread-Topic: [PATCH v5 4/5] mmc: sdhci-of-esdhc: add erratum eSDHC7 support Thread-Index: AQHU17B7Z/Y1Y0VvsEGkS332tQofDw== Date: Mon, 11 Mar 2019 02:16:47 +0000 Message-ID: <20190311021814.42326-4-yinbo.zhu@nxp.com> References: <20190311021814.42326-1-yinbo.zhu@nxp.com> In-Reply-To: <20190311021814.42326-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0P153CA0047.APCP153.PROD.OUTLOOK.COM (2603:1096:203:17::35) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9cf70cf2-6185-48b8-8e74-08d6a5c79d59 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5373; x-ms-traffictypediagnostic: VI1PR04MB5373: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB5373=3B23=3ANp?= =?iso-8859-1?q?2HUyv2Wtn4fh0SYxZIR/utVxP+B6swsPd4EIPtkk9pMvOWDAHzyPMjakd7fj?= =?iso-8859-1?q?OawS4H35Sn0PYbDtvx7eEjJVQ3oOZjCV9ufyyvD7mJz8MI9NGlkSBwpKNDk7?= =?iso-8859-1?q?v/HC91O1z1MXHN39lbtvCohcysXmh1/rnj6bNQXVhqzTjURmzMVgH9efvcVy?= =?iso-8859-1?q?AtakmLKE5rK1DUmvYnEqoMyJfyWlmNOe+pKM//7IVxHiGGqislIURZCYSFhk?= =?iso-8859-1?q?IfhPPE7v1ahMrtKyCTnR3ZSciZbVf+G/Rn8yZQ2JeqT2Jnccv7zXJqMYXgej?= =?iso-8859-1?q?4RcEW5IF5TDGMPMJ3F0wKWHhGQf6z9r6I0MnF/M7VypdV1P2TUWdqwpSD8YS?= =?iso-8859-1?q?fmvBciQpiLjHYqGbLP618zxHHyXpqCJj5bEsHZGCDe1sDHM2XWrupoJ1O6gr?= =?iso-8859-1?q?VyNg/I8C/CINurtOlb5054ZGwjiVPwrhKqY5U0nO7rGC07Hfm83jMngn7q93?= =?iso-8859-1?q?jgmgKKzMjFyLK/aupyyf0W79WLk4GSRhE97hjBEQ52xsrTCftcoXa3uTBLNw?= =?iso-8859-1?q?sUCtqSasH9Oj0Dt54uz3Lql83LB56+IG4prvQVG219xo8eJBNXm/Ms15pvC+?= =?iso-8859-1?q?+086hbdmW5XD91MSEk3+smOeS9mPfZ7ldxyk0Q3cKNrAnP74rTm9Ihjn7Z83?= =?iso-8859-1?q?cG1tZW2y2GaojTqqeBwjwUg9u0mrvq847DWlX246n8I5g6wqtb2ZO4uOoLf4?= =?iso-8859-1?q?+rKrXMhXHdMlb3JjkPUDYkd2Wn4u3+Nef553r+P8HOhiRsavkOsofJeI/5Gs?= =?iso-8859-1?q?37y1O+QtnryowdhBYDZfpNa5M6ieLvNhUZZTxES4Vnba9QfDiBthjXMxjmU5?= =?iso-8859-1?q?4M96DTr7joJeXYXJt73XlMFgOh0TW2f7cLNWi3skI+BQGQSaAiLeW0aFDQ3A?= =?iso-8859-1?q?Wrv4GzNj4jsgAYcsDaThuLwk+iuvP40z9ofJY7hcxMkP8TOAs8ecjpLSig3X?= =?iso-8859-1?q?3aXH6JebNTp4RCaY/Fuza9ScQWjAFkdTigrswNMrD9vDFpEds59AT1pqZ1Kd?= =?iso-8859-1?q?0fxXFj/KwdpZuozEjn9VAJ7fL4zlU2D5c6O294UcLIfewyOFiLgmXCr0WcF2?= =?iso-8859-1?q?905WfgeVUCXNELcDzzgW/HMrhROB22q13ZMoogtFFEQWFcvhiBL6dIPUQbPK?= =?iso-8859-1?q?k9uQlN+1ITAp8K1LtzRX/6+DfPf6PecCff6F7nOYiLtnn9kmfGZFKGBBMafe?= =?iso-8859-1?q?YTkAbJpZ3Tu5aipkXrSd3mC67hCKqPgl6b1xEZ+97a7rNye1js59fuYdYjTB?= =?iso-8859-1?q?CC429p+qSZnlkHiC+e?= x-microsoft-antispam-prvs: x-forefront-prvs: 09730BD177 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(39860400002)(366004)(376002)(136003)(189003)(199004)(50226002)(106356001)(44832011)(66066001)(53936002)(486006)(2906002)(476003)(2616005)(478600001)(6512007)(14454004)(446003)(52116002)(76176011)(26005)(7736002)(71190400001)(54906003)(256004)(14444005)(110136005)(316002)(6436002)(305945005)(11346002)(102836004)(6486002)(36756003)(97736004)(6506007)(71200400001)(68736007)(86362001)(4326008)(99286004)(386003)(186003)(105586002)(2501003)(1076003)(8676002)(81156014)(81166006)(25786009)(8936002)(5660300002)(3846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5373;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: K2A+BC7r8+MHmtfkBTZIFHUIAFABd6Ags4Su6I4l98wc4QL/20hCbFMFNvlProscnof05/tDXuPUNxLcjMvmOjwSf97LwMhHUKOutp9A6b3+ACxT3I+RfPCdMzCEgY+4YPW6LmZG0f3yatuTdAn3EyZSjaPGmw8OXu6PM0EodQTg76vzmD1Wx+oqxjxgYSNFCziK9mmSUz1Qg3jJAZ1s5lP/3dLMCNp3QwADNQb67/dPuPdoRMaMazmZN7mzjOJl+D+oJqm5U+fou5j8OWvtKLvzA5tx7qeWdganoKnfwVVZOKHCx/HnWc2S3PZ96G6vq3GmlG+p89qiUn0in3ixTeac1ICMXq+z8sYTXRNJvpLcTxQPQpY3FWqr/9udRii540mw2BRIKZojy5iB4R+pDvGY57eV0On9vLIQvzNz3Cw= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf70cf2-6185-48b8-8e74-08d6a5c79d59 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2019 02:16:47.9653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5373 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu Invalid Transfer Complete (IRQSTAT[TC]) bit could be set during multi-write operation even when the BLK_CNT in BLKATTR register has not reached zero. Therefore, Transfer Complete might be reported twice due to this erratum since a valid Transfer Complete occurs when BLK_CNT reaches zero. This erratum is to fix this issue Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- Change in v5: write SDHCI_INT_DATA_END to SDHCI_INT_STATUS to clear it drivers/mmc/host/sdhci-of-esdhc.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 7e0eae8dafae..6870193640d5 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -24,6 +24,7 @@ #include #include #include +#include #include "sdhci-pltfm.h" #include "sdhci-esdhc.h" @@ -867,6 +868,25 @@ static void esdhc_set_uhs_signaling(struct sdhci_host *host, sdhci_set_uhs_signaling(host, timing); } +static u32 esdhc_irq(struct sdhci_host *host, u32 intmask) +{ + u32 command; + + if (of_find_compatible_node(NULL, NULL, + "fsl,p2020-esdhc")) { + command = SDHCI_GET_CMD(sdhci_readw(host, + SDHCI_COMMAND)); + if (command == MMC_WRITE_MULTIPLE_BLOCK && + sdhci_readw(host, SDHCI_BLOCK_COUNT) && + intmask & SDHCI_INT_DATA_END) { + intmask &= ~SDHCI_INT_DATA_END; + sdhci_writel(host, SDHCI_INT_DATA_END, + SDHCI_INT_STATUS); + } + } + return intmask; +} + #ifdef CONFIG_PM_SLEEP static u32 esdhc_proctl; static int esdhc_of_suspend(struct device *dev) @@ -914,6 +934,7 @@ static const struct sdhci_ops sdhci_esdhc_be_ops = { .set_bus_width = esdhc_pltfm_set_bus_width, .reset = esdhc_reset, .set_uhs_signaling = esdhc_set_uhs_signaling, + .irq = esdhc_irq, }; static const struct sdhci_ops sdhci_esdhc_le_ops = { @@ -931,6 +952,7 @@ static const struct sdhci_ops sdhci_esdhc_le_ops = { .set_bus_width = esdhc_pltfm_set_bus_width, .reset = esdhc_reset, .set_uhs_signaling = esdhc_set_uhs_signaling, + .irq = esdhc_irq, }; static const struct sdhci_pltfm_data sdhci_esdhc_be_pdata = { From patchwork Mon Mar 11 02:16:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10846583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 198901823 for ; Mon, 11 Mar 2019 02:16:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03E6C28E3E for ; Mon, 11 Mar 2019 02:16:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC6BC28E40; Mon, 11 Mar 2019 02:16:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79BB728E3E for ; Mon, 11 Mar 2019 02:16:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfCKCQz (ORCPT ); Sun, 10 Mar 2019 22:16:55 -0400 Received: from mail-eopbgr00080.outbound.protection.outlook.com ([40.107.0.80]:34689 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727076AbfCKCQy (ORCPT ); Sun, 10 Mar 2019 22:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v/bPo+ZlZtWg1Wtvq7y68iLsUpkAuM4tm9/yRecRAMg=; b=tRJcKdP1GJjEtYgUXlw3ayl2DU1n12Uq6J1jl96h1lic2nDRiaIistQiytCrFJzDqA5JZOGVf25xyqB53vcLBj7UthfiSJUAP8kvYl8wj8ahZRu58qoEc2F9F7ldMeqI/caubN+7FzdzkftqXqRz6kyaSDCSX6uAU3iJvth2e7g= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB5373.eurprd04.prod.outlook.com (20.178.120.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Mon, 11 Mar 2019 02:16:51 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%5]) with mapi id 15.20.1686.021; Mon, 11 Mar 2019 02:16:51 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v5 5/5] mmc: sdhci-of-esdhc: add quirk to ignore command inhibit for data Thread-Topic: [PATCH v5 5/5] mmc: sdhci-of-esdhc: add quirk to ignore command inhibit for data Thread-Index: AQHU17B9f+ZOzbIcQEmmgsq7nr2RrQ== Date: Mon, 11 Mar 2019 02:16:51 +0000 Message-ID: <20190311021814.42326-5-yinbo.zhu@nxp.com> References: <20190311021814.42326-1-yinbo.zhu@nxp.com> In-Reply-To: <20190311021814.42326-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0P153CA0047.APCP153.PROD.OUTLOOK.COM (2603:1096:203:17::35) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 520cc7f6-9619-4cf2-43c1-08d6a5c79f74 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5373; x-ms-traffictypediagnostic: VI1PR04MB5373: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB5373=3B23=3AXU?= =?iso-8859-1?q?YrlUm3KIhKYGmrciafnNh3VrZIPZo+1Xk+JSwHLwsNpilinDRliu3r/6BuGm?= =?iso-8859-1?q?9sQ4Zwzm67bXdZWqXOOndXHuNGNdZTWWqucdaNFFN+wblX/d0nWfEJg7kQj5?= =?iso-8859-1?q?ebZPDwonPAHyxqdO0JIh+hQ97o3qfYn+SDmYP9GQGjt35lPe9ljvXKiJQk97?= =?iso-8859-1?q?1Abcg9EOrLUdayshgz59JCY1OO1XentVqVRTAO7aOt6eT4Wh0yXzMSstAyvT?= =?iso-8859-1?q?8V9SOSX6g0G3kygQpqPR4annHUh09aPX484En0pQIMKgQogRDp5l6RW+tww3?= =?iso-8859-1?q?pMP+wl2GXfoSTD8fzvw+jNSKrP6TQKom2tpTsz5qEw62Rd7tROhJbm+k0H+p?= =?iso-8859-1?q?ye/i/hIf8t1sk+gNnYZ1n135uBRtLfUwEGGWrXjX7mGP34Ud/XS1XHXQvTLm?= =?iso-8859-1?q?kVka90xnQboPi0/Mx5eRGxnDZ0OGmczu4mNbIF7F2fsk0fHoKsA8kTdx5X+g?= =?iso-8859-1?q?/S59q+FfMhERJXWnFCzzf3CwuRYpsioJ7uTlY5xNl7BHN38Fb4tnY28TXQxx?= =?iso-8859-1?q?gdGt87n5SjTnRKdJM7FYiI/TT8JgAmWslMpXXqQKi/zH9AUuZ1rJtmKZjZNG?= =?iso-8859-1?q?32NJ8c6BBI5LWXsJNkvFWvfkGXKiymT729NzLefgMOiqZ6SfmxvEpvtX/QNg?= =?iso-8859-1?q?9Xn4Kq1St7sYyuy8siO1JJAWRI2DgL/qK6sq/ma/2wNBPXs5Ai8nHo9OcODp?= =?iso-8859-1?q?11bSe/QzsqwsyD9/nVTE5ghUGhV+iAnlaAsC9PfGwSYgkK/Aq8i8KmaRz+9m?= =?iso-8859-1?q?7T6IJHSw/uph77J3whrA85I3fPWmn/M0NJMe1ycbTF5ETz9hYW+Ldj2C/23b?= =?iso-8859-1?q?2oMKKwNSQjhDscLqp6lG2v59AFI2xAsDApLY99iKFoKZht2xPR35ELyBowhF?= =?iso-8859-1?q?TBuAREVBhujk9KozG+vSb7iLVp9FtocVa3Asmjm/9y2gj5NGss0dg+FFs8md?= =?iso-8859-1?q?QOk6V03ajxXTwaNfGGN09K/Qx33IbGie8BZo9n9AVF8p3lTRbKrs1TKlqqaC?= =?iso-8859-1?q?Cc/XH7dkIW/Et10DxJr8Hhlf7xb/mQ+vd0dGHq7Jan9sDnbM3v/kptTLABFY?= =?iso-8859-1?q?SSNP//0Vjj5lxbN6MmTcxOO9nEVeYwGafYMPwucuhGY93Ib6MG89KiQcJpwi?= =?iso-8859-1?q?AjZn+r3MZtLbeLl7BjQeyQdlwIMqtGo31vBtIK3Var3s42uxfy20I5bBqNWR?= =?iso-8859-1?q?4j+7+JGvzjRgcDTh0XApWo3vPI3EzpJmHCCYKOjxCKbey+RXgyDTS1H/o=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09730BD177 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(39860400002)(366004)(376002)(136003)(189003)(199004)(50226002)(106356001)(44832011)(66066001)(53936002)(486006)(2906002)(476003)(2616005)(478600001)(6512007)(14454004)(446003)(52116002)(76176011)(26005)(7736002)(71190400001)(54906003)(256004)(110136005)(316002)(6436002)(305945005)(11346002)(102836004)(6486002)(36756003)(97736004)(6506007)(71200400001)(68736007)(86362001)(4326008)(99286004)(386003)(186003)(105586002)(2501003)(1076003)(8676002)(81156014)(81166006)(25786009)(8936002)(5660300002)(3846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5373;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: fsXAvF5uYMdJRQg0oCX162FCt9s5GbZWxGcNvzF5MDrCGNyf4v1Newv5/3NCGWqEoCstTwwFq70MHw/oIFURBhjeGoT/ZzltZxtYcoq0vl6j8Kus05MFZR5ZLo3ssZR12DDzboyLVteIAyJM2AEwkeZuV3wrIxdn2SIWXFeVzRMI5D0PL9AU5/t1KEAWB4DkU8lmcQ97lnn7CX7iqJx6K99pi0qNQ3QLdnnvxEL/EyvkBtUB+qrsed6aylCRWThN6asmYF8TsbxqHNIWU7kKFi3Ds7rZ1ZDUcmi5kOiSXD6T6LS3aG0W/USZwIAn+TlSu7OaMayvuFZIR2GvcsAALBvp483PS4iqLGxiFPR3ooOZGtntat9ZB3QnQs92hIX+J3Jk9MJLbxQldZPQ9L3Xmi3Nv88OLrrgjb7o0okBQVc= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 520cc7f6-9619-4cf2-43c1-08d6a5c79f74 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2019 02:16:51.4897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5373 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yangbo Lu For some controllers, in Present State Register, Data Line Active bit is not reliable for commands (such as CMD6, CMD7, CMD12, CMD28, CMD29, or CMD38) with busy signal. DLA affects Command with Data Inhibit bit. Therefore, software driver may not know the busy status in DLA/CDIHB. Futunately MMC core driver has already polled card status with CMD13 after sending any command with busy signal. So we can just ignore CDIHB never released issue for such controllers. This patch is to add a quirk to handle this. Signed-off-by: Yangbo Lu Signed-off-by: Yinbo Zhu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 6870193640d5..9ff03305591e 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -82,6 +82,7 @@ struct sdhci_esdhc { bool quirk_limited_clk_division; bool quirk_unreliable_pulse_detection; bool quirk_fixup_tuning; + bool quirk_ignore_data_inhibit; unsigned int peripheral_clock; const struct esdhc_clk_fixup *clk_fixup; u32 div_ratio; @@ -148,6 +149,19 @@ static u32 esdhc_readl_fixup(struct sdhci_host *host, return ret; } + /* + * Some controllers have unreliable Data Line Active + * bit for commands with busy signal. This affects + * Command Inhibit (data) bit. Just ignore it since + * MMC core driver has already polled card status + * with CMD13 after any command with busy siganl. + */ + if ((spec_reg == SDHCI_PRESENT_STATE) && + (esdhc->quirk_ignore_data_inhibit == true)) { + ret = value & ~SDHCI_DATA_INHIBIT; + return ret; + } + ret = value; return ret; } @@ -1114,12 +1128,14 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (of_device_is_compatible(np, "fsl,ls1021a-esdhc")) host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; + esdhc->quirk_ignore_data_inhibit = false; if (of_device_is_compatible(np, "fsl,p2020-esdhc")) { /* * Freescale messed up with P2020 as it has a non-standard * host control register */ host->quirks2 |= SDHCI_QUIRK2_BROKEN_HOST_CONTROL; + esdhc->quirk_ignore_data_inhibit = true; } /* call to generic mmc_of_parse to support additional capabilities */